⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 17, 2005:

9:01 PM Changeset in webkit [11648] by darin
  • 2 edits
    3 adds in trunk/WebCore

Reviewed and landed by Darin.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.
  • manual-tests/resources/frame1.html: Added.
  • manual-tests/resources/frame2.html: Added.
7:09 PM Changeset in webkit [11647] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

  • fast/js/string-split-ignore-case-expected.txt: Added.
  • fast/js/string-split-ignore-case.html: Added.
7:09 PM Changeset in webkit [11646] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

Glossary:
RegExpImp: The C++ object you get when JavaScript executes

"new RegExp()".

RegExp: A C++ wrapper object that performs regular expression

matching on behalf of a RegExpImp.

Instead of unnecessarily constructing a RegExp which (wrongly) lacks
any modifiers, String.split() now uses the RegExp built in to the
RegExpImp passed to it, which has the right modifiers already.

I also cleaned up other bits of the string code to standardized how
we handle RegExpImp arguments.

  • ChangeLog:
  • kjs/string_object.cpp: (replace): (StringProtoFunc::callAsFunction):
12:12 PM Changeset in webkit [11645] by andersca
  • 2 edits in trunk/WebCore

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
12:09 PM Changeset in webkit [11644] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
10:10 AM Changeset in webkit [11643] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/text/atsui-rtl-override-selection-expected.checksum: Added.
  • fast/text/atsui-rtl-override-selection-expected.png: Added.
  • fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • fast/text/atsui-rtl-override-selection.html: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing it with a text direction parameter.
  • khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.
  • kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag in the style instead.
  • kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.

WebKit:

Reviewed and landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Update since the layout only includes from -> to now. (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove reversed parameter. (CG_floatWidthForRun): Add code to handle RTL case. (addDirectionalOverride): Put the override around the entire run. (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work. Also round. (ATSU_pointToOffset): Remove reversed parameter and run swapping. (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.

Dec 16, 2005:

4:46 PM Changeset in webkit [11642]
  • 211 copies
    17 deletes in tags/WebCore-417~15

This commit was manufactured by cvs2svn to create tag
'WebCore-417~15'.

4:46 PM Changeset in webkit [11641] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.15

3:01 PM Changeset in webkit [11640] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:56 PM Changeset in webkit [11639] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/date_object.cpp

Fix the calls to strftime on the non-apple code path to take const tm* and not just tm

2:48 PM Changeset in webkit [11638] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/ustring.cpp

Add assert.h include to ustring.cpp

2:45 PM Changeset in webkit [11637] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/interpreter.cpp

ifdef out the getpid call on windows.

2:27 PM Changeset in webkit [11636] by hyatt
  • 2 edits in trunk/JavaScriptCore

Remove unused RefPtr constructors that can create an ambiguity in ustring on some platforms.

Reviewed by mjs

  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr):
2:26 PM Changeset in webkit [11635] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6106
Submitted by: eseidel
Reviewed by: darin

DOMString should hold its impl in a RefPtr
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6106
I also cleaned up spacing in dom_string.cpp
No tests needed (no functionality changes).

  • khtml/dom/dom_string.cpp: (DOM::DOMString::DOMString): (DOM::DOMString::operator += ): (DOM::DOMString::insert): (DOM::DOMString::operator []): (DOM::DOMString::find): (DOM::DOMString::length): (DOM::DOMString::truncate): (DOM::DOMString::remove): (DOM::DOMString::split): (DOM::DOMString::lower): (DOM::DOMString::upper): (DOM::DOMString::percentage): (DOM::DOMString::unicode): (DOM::DOMString::qstring): (DOM::DOMString::toInt): (DOM::DOMString::copy): (DOM::strcasecmp): (DOM::DOMString::toCoordsArray): (DOM::DOMString::toLengthArray): (DOM::operator==):
  • khtml/dom/dom_string.h: (DOM::DOMString::DOMString): (DOM::DOMString::impl):
2:16 PM Changeset in webkit [11634]
  • 26 copies
    3 deletes in tags/WebKit-312~8

This commit was manufactured by cvs2svn to create tag 'WebKit-312~8'.

2:16 PM Changeset in webkit [11633] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning.

1:43 PM Changeset in webkit [11632] by eseidel
  • 3 edits in trunk/WebCore

Bug #: 6110
Submitted by: eseidel
Reviewed by: darin

No test cases needed (no functionality changes).

  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLImportRuleImpl::XSLImportRuleImpl): (DOM::XSLImportRuleImpl::~XSLImportRuleImpl): (DOM::XSLImportRuleImpl::setStyleSheet):
  • khtml/xsl/xsl_stylesheetimpl.h: (DOM::XSLImportRuleImpl::styleSheet):
1:30 PM Changeset in webkit [11631] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
1:21 PM Changeset in webkit [11630] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim O.

  • fix <rdar://problem/4380428> window.onbeforeunload works on IE but not on Safari
  • khtml/ecma/kjs_window.cpp:
12:35 PM Changeset in webkit [11629] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4381546> Safari crash at www.dallascowboys.com in KWQListIteratorImpl::current()

  • khtml/khtml_part.cpp: (KHTMLPart::slotFinishedParsing): ref the part before calling checkCompleted.
12:33 PM Changeset in webkit [11628] by hyatt
  • 1 edit in trunk/JavaScriptCore/kxmlcore/HashTraits.h

Don't include bits/cpp_type_traits on win32

12:27 PM Changeset in webkit [11627]
  • 120 copies
    5 deletes in tags/WebCore-315~13

This commit was manufactured by cvs2svn to create tag
'WebCore-315~13'.

12:27 PM Changeset in webkit [11626] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.13

11:30 AM Changeset in webkit [11625] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-14 Adele Peterson <​adele@apple.com>

Reviewed by Darin and Tim Hatcher.

  • fixed <rdar://problem/4375502> 10.4.4 REGRESSION: Clicking on anchor tag in email causes unwanted horizontal scroll

When scrolling views, we were failing to take the current scroll position into account when calculating the new scroll position.

  • kwq/KWQScrollView.h: Added scrollPointRecursively.
  • kwq/KWQScrollView.mm: (QScrollView::scrollXOffset): Calculates the x-coordinate scroll offset for a view. (QScrollView::scrollYOffset): Calculates the y-coordinate scroll offset for a view. (QScrollView::scrollPointRecursively): This function walks up the view hierarchy to scroll to a point. I moved this from setContentsPos so that function would only have an effect on the current view. (QScrollView::setContentsPos): return to old behavior where this function calls scrollPoint on a view and doesn't recurse.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::scrollRectToVisible): Uses new QScrollView functions scrollXOffset and scrollYOffset to correctly calculate how a view should scroll. Also determines whether or not QScrollView should try to scroll recursively (which happens when scrollRectToVisible is done calling itself recursively).
10:35 AM Changeset in webkit [11624] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

Layout test added:

  • fast/js/Plug-ins-expected.checksum: Added.
  • fast/js/Plug-ins-expected.png: Added.
  • fast/js/Plug-ins-expected.txt: Added.
  • fast/js/Plug-ins.html: Added.
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): Changed initialization of KConfig from empty string to pluginsinfo.
10:34 AM Changeset in webkit [11623] by ggaren
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6112
REGRESSION: navigator.plugins empty.

  • fast/js/Plug-ins-expected.checksum: Added.
  • fast/js/Plug-ins-expected.png: Added.
  • fast/js/Plug-ins-expected.txt: Added.
  • fast/js/Plug-ins.html: Added.
10:20 AM Changeset in webkit [11622] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

  • fast/text/international/bidi-european-terminators-expected.checksum: Added.
  • fast/text/international/bidi-european-terminators-expected.png: Added.
  • fast/text/international/bidi-european-terminators-expected.txt: Added.
  • fast/text/international/bidi-european-terminators.html: Added.
10:18 AM Changeset in webkit [11621] by darin
  • 2 edits in trunk/WebCore

Reviewed and landed by Darin.

Test: fast/text/international/bidi-european-terminators.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6014
Bidi algorithm: incorrect resolved levels for neutrals between R and
ET ON L

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Keep track of the last position before the current run of ETs directly using a new BidiState member, lastBeforeET.
8:51 AM Changeset in webkit [11620] by darin
  • 1 edit
    4 adds in trunk/LayoutTests
  • Added layout tests Evan Gross contributed about converting to attributed string. The results here currently seem wrong, but are what I get with TOT.
  • fast/text/attributed-substring-from-range-expected.txt: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Added.
  • fast/text/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range.html: Added.
8:51 AM Changeset in webkit [11619] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView attributedSubstringFromRange:]): Implement by calling the same RTF conversion used when copying to the pasteboard.
8:40 AM Changeset in webkit [11618] by darin
  • 20 edits in trunk

LayoutTests:

Reviewed and landed by Darin.

Updated tests that include RTL or "bidi override" runs since DumpRenderTree now
dumps those runs.

  • fast/block/basic/016-expected.txt:
  • fast/block/float/026-expected.txt:
  • fast/block/float/028-expected.txt:
  • fast/block/positioning/auto/006-expected.txt:
  • fast/dom/HTMLElement/bdo-expected.txt:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-CS-after-AN-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-explicit-embedding-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
  • fast/text/international/bidi-override-expected.txt:

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQRenderTreeDebug.cpp: (writeTextRun): Dump the additional flags.
8:18 AM Changeset in webkit [11617] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed and landed by Darin.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6043
Incorrect selection highlighting in pre-formatted text with tabs

  • khtml/rendering/render_text.cpp: Correct parameters in calls to RenderText::width(). (InlineTextBox::selectionRect): (InlineTextBox::placeEllipsisBox): (InlineTextBox::paintDecoration): (InlineTextBox::paintMarker): (InlineTextBox::paintMarkedTextUnderline):
  • manual-tests/pre-tab-selection-rect.html: Added.
8:13 AM Changeset in webkit [11616] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

  • fast/js/replace-child-siblings-expected.txt: Added.
  • fast/js/replace-child-siblings.html: Added.

WebCore:

Reviewed and landed by Darin.

Test: fast/js/replace-child-siblings.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6069
Assertion failure in RenderBlock::addChildToFlow during replaceChild

  • khtml/xml/dom_nodeimpl.cpp: (DOM::ContainerNodeImpl::replaceChild): If the new child was right before or right after the old child, then it just stays.
8:11 AM Changeset in webkit [11615] by darin
  • 2 edits in trunk/WebKit

Reviewed and landed by Darin.

  • WebView.subproj/WebImageView.m: (-[WebImageView elementAtPoint:]): Use WebCoreElementImageRendererKey for the image renderer and WebElementImageKey for the image.
12:08 AM Changeset in webkit [11614] by darin
  • 30 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • kjs/internal.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::evaluate): Change to take a character pointer and length rather than a UString.
  • kjs/interpreter.h:
  • kjs/interpreter.cpp: (Interpreter::evaluate): Ditto.
  • kjs/protect.h: Remove uneeded "convert to bool" operator since we already have a "convert to raw pointer" operator in this class.

WebCore:

Reviewed by Maciej.

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getListener): Use listenerObj instead of listenerObjImp.
  • khtml/ecma/kjs_html.cpp: (KJS::Image::getValueProperty): Ditto.
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::getValueProperty): Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getListener): Ditto. (KJS::Window::getJSLazyEventListener): Take code as a DOMString, not QString.
  • khtml/ecma/kjs_events.cpp: (KJS::jsStringOrUndefined): Renamed function and moved it to the top of the file. (KJS::JSAbstractEventListener::handleEvent): Cleaned up function, removed double logging, and fixed code path to not use UString::ascii(). (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Updated since type of the window object is now Window. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Ditto. (KJS::JSUnprotectedEventListener::windowObj): Ditto. (KJS::JSEventListener::JSEventListener): Ditto. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSEventListener::windowObj): Ditto. (KJS::JSLazyEventListener::JSLazyEventListener): Ditto. Also changed code to be a DOMString instead of a QString. (KJS::JSLazyEventListener::handleEvent): Removed function because the base class handleEvent already calls listenerObj which takes care of parseCode -- no need to do an additional parseCode here. (KJS::JSLazyEventListener::parseCode): Rearrange and clean up a bit. Code is now a DOMString instead of a QString. (KJS::Clipboard::Clipboard): Remove explicit ref since we now use a RefPtr for the clipboard object. (KJS::Clipboard::getValueProperty): Update to call jsStringOrUndefined.
  • khtml/ecma/kjs_events.h: Reformatted the file. Changed windowObj functions to return Window* instead of ObjectImp*. Removed listenerObjImp function. Removed destructors from many classes that don't need them. Used a RefPtr for the ClipboardImpl in a Clipboard object.
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate): Take filename and code as DOMString instead of QString. (KJSProxyImpl::createHTMLEventHandler): Take URL and code as DOMString.
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code. (DocumentImpl::setHTMLWindowEventListener): Added an overload that takes an attribute pointer. Calls through after extracting the code from the attribute value.
  • khtml/html/html_elementimpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setHTMLEventListener): New version of function that takes an attribute pointer; calls through to the base class after extracting the code from the attribute value.
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Change to use new setHTMLWindowEventListener and setHTMLEventListener that takes an attribute pointer. (HTMLFrameElementImpl::parseMappedAttribute): Ditto. (HTMLFrameSetElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLButtonElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLInputElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLabelElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLSelectElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLTextAreaElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): Ditto.
  • khtml/html/html_headimpl.h:
  • khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::notifyFinished): Don't convert URL to QString since we now take a DOMString. (HTMLScriptElementImpl::evaluateScript): Change to take script as a DOMString.
  • khtml/khtml_part.h:
  • khtml/khtml_part.cpp: (KHTMLPart::createHTMLEventListener): Take a DOMString rather than a QString for the JavaScript code.
  • kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Change code path so it doesn't convert an NSString to UTF-8 to get it into the JavaScript machinery. Use QString::fromNSString instead for now.
12:04 AM Changeset in webkit [12224] by darin
  • 2 edits in trunk/JavaScriptGlue

Reviewed by Maciej.

  • JSRun.cpp: (JSRun::Evaluate): Updated for change to Interpreter::evaluate.
Note: See TracTimeline for information about the timeline view.