⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 18, 2005:

4:27 PM Changeset in webkit [11659] by darin
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed, tweaked, and landed by Darin.

  • kjs/array_object.h:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added implementation of indexOf.

LayoutTests:

Reviewed, tweaked, and landed by Darin.

  • fast/js/array-indexof-expected.txt: Added.
  • fast/js/array-indexof.html: Added.
3:41 PM Changeset in webkit [11658] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/DOMInternal.mm: (DOMString::DOMString): Remove now-unneeded ref.
3:40 PM Changeset in webkit [11657] by darin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Cast pointer to a TextImpl before calling containsOnlyWhitespace; the code already checked isTextNode.
  • khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration): Expanded an if statement into a few separate ones for slight additional clarity. Added a check of isTextNode and cast pointer to a TextImpl.
  • khtml/xml/dom_nodeimpl.h: Remove containsOnlyWhitespace function.
  • khtml/xml/dom_textimpl.h: Remove virtual keyword from containsOnlyWhitespace.
2:55 PM Changeset in webkit [11656] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

Test: fast/text/international/bidi-ignored-for-first-child-inline.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiNext): Adjust embedding at inline containers' boundaries instead of inside. (khtml::RenderBlock::bidiFirst): (khtml::RenderBlock::determineStartPosition):
2:37 PM Changeset in webkit [11655] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • test of a particular character set name that is not in the WebCore table but is in the ICU table (see bugzilla 5932)
  • fast/encoding/charset-cp1251-expected.txt: Added.
  • fast/encoding/charset-cp1251.html: Added.

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName): Fall back on ICU encoding names if we don't find the name in the WebCore encoding names table.
2:23 PM Changeset in webkit [11654] by darin
  • 5 edits
    6 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • XSLT document encoding tests
  • fast/xsl/xslt-doc-enc-expected.txt: Added.
  • fast/xsl/xslt-doc-enc.xml: Added.
  • fast/xsl/xslt-doc-enc.xsl: Added.
  • fast/xsl/xslt-doc-noenc-expected.txt: Added.
  • fast/xsl/xslt-doc-noenc.xml: Added.
  • fast/xsl/xslt-doc-noenc.xsl: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform): Get encoding from transform and pass in to XSLTProcessor.
  • khtml/xsl/xslt_processorimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Added encoding parameter. Create a Decoder and use it to decode the source document (default encoding UTF-8). (DOM::XSLTProcessorImpl::transformToString): Add an encoding result. Set it to the encoding from the libxml2 document object. (DOM::XSLTProcessorImpl::transformToDocument): Get encoding from transform and pass in to XSLTProcessor. (DOM::XSLTProcessorImpl::transformToFragment): Ditto.
2:13 PM Changeset in webkit [11653] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric, landed by Darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Fix incorrectly nested else.
5:28 AM Changeset in webkit [11652] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date

5:27 AM Changeset in webkit [11651] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4000
Object.prototype is missing isPrototypeOf

  • fast/js/test-isPrototypeOf-expected.txt: Added.
  • fast/js/test-isPrototypeOf.html: Added.
5:27 AM Changeset in webkit [11650] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add isPrototypeOf to object prototype.

(ObjectProtoFunc::callAsFunction):
Implement isPrototypeOf

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add id for isPrototypeOf.
1:20 AM Changeset in webkit [11649] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

updaated changelog to remove previous suggestion that darin was a nobody

Dec 17, 2005:

9:01 PM Changeset in webkit [11648] by darin
  • 2 edits
    3 adds in trunk/WebCore

Reviewed and landed by Darin.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::layout):
  • manual-tests/bugzilla-5768.html: Added. Can't seem to get it to work (fail) as an automated test.
  • manual-tests/resources/frame1.html: Added.
  • manual-tests/resources/frame2.html: Added.
7:09 PM Changeset in webkit [11647] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

  • fast/js/string-split-ignore-case-expected.txt: Added.
  • fast/js/string-split-ignore-case.html: Added.
7:09 PM Changeset in webkit [11646] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6119
split() function ignores case insensitive modifier.

Glossary:
RegExpImp: The C++ object you get when JavaScript executes

"new RegExp()".

RegExp: A C++ wrapper object that performs regular expression

matching on behalf of a RegExpImp.

Instead of unnecessarily constructing a RegExp which (wrongly) lacks
any modifiers, String.split() now uses the RegExp built in to the
RegExpImp passed to it, which has the right modifiers already.

I also cleaned up other bits of the string code to standardized how
we handle RegExpImp arguments.

  • ChangeLog:
  • kjs/string_object.cpp: (replace): (StringProtoFunc::callAsFunction):
12:12 PM Changeset in webkit [11645] by andersca
  • 2 edits in trunk/WebCore

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
12:09 PM Changeset in webkit [11644] by andersca
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

2005-12-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/css/css_ruleimpl.h: (DOM::CSSMediaRuleImpl::media): Make m_lstMedia a smart pointer.
10:10 AM Changeset in webkit [11643] by darin
  • 9 edits
    4 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • fast/text/atsui-rtl-override-selection-expected.checksum: Added.
  • fast/text/atsui-rtl-override-selection-expected.png: Added.
  • fast/text/atsui-rtl-override-selection-expected.txt: Added.
  • fast/text/atsui-rtl-override-selection.html: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/rendering/font.h: Remove reversed parameter from checkSelectionPoint, replacing it with a text direction parameter.
  • khtml/rendering/render_text.cpp: (InlineTextBox::offsetForPosition): Ditto.
  • kwq/KWQFontMetrics.h: Add a directional override parameter to checkSelectionPoint.
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Pass the directional override through to the text renderer. Don't pass the reversed flag redundantly -- use the rtl flag in the style instead.
  • kwq/WebCoreTextRenderer.h: Remove reversed parameter from pointToOffset.

WebKit:

Reviewed and landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Update since the layout only includes from -> to now. (-[WebTextRenderer pointToOffset:style:position:includePartialGlyphs:]): Remove reversed parameter. (CG_floatWidthForRun): Add code to handle RTL case. (addDirectionalOverride): Put the override around the entire run. (ATSU_drawHighlight): Rearrange and reuse ATSU_floatWidthForRun for more of the work. Also round. (ATSU_pointToOffset): Remove reversed parameter and run swapping. (CG_pointToOffset): Remove reversed parameter, using rtl flag in style instead.
Note: See TracTimeline for information about the timeline view.