⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 19, 2005:

2:16 PM Changeset in webkit [11673] by adele
  • 35 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-multiple-renderers-expected.checksum: Added.
  • fast/text/atsui-multiple-renderers-expected.png: Added.
  • fast/text/atsui-multiple-renderers-expected.txt: Added.
  • fast/text/atsui-multiple-renderers.html: Added.
  • css1/text_properties/text-transCapitalize-expected.checksum:
  • css1/text_properties/text-transCapitalize-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.checksum:
  • fast/text/international/bidi-AN-after-L-expected.png:
  • fast/text/international/bidi-AN-after-L-expected.txt:
  • fast/text/international/bidi-L2-run-reordering-expected.checksum:
  • fast/text/international/bidi-L2-run-reordering-expected.png:
  • fast/text/international/bidi-L2-run-reordering-expected.txt:
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum:
  • fast/text/international/bidi-LDB-2-CSS-expected.png:
  • fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum:
  • fast/text/international/bidi-LDB-2-HTML-expected.png:
  • fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • fast/text/international/bidi-european-terminators-expected.checksum:
  • fast/text/international/bidi-european-terminators-expected.png:
  • fast/text/international/bidi-european-terminators-expected.txt:
  • fast/text/international/bidi-fallback-font-weight-expected.checksum:
  • fast/text/international/bidi-fallback-font-weight-expected.png:
  • fast/text/international/bidi-fallback-font-weight-expected.txt:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • fast/text/international/bidi-innertext-expected.checksum:
  • fast/text/international/bidi-innertext-expected.png:
  • fast/text/international/bidi-innertext-expected.txt:
  • fast/text/international/bidi-override-expected.checksum:
  • fast/text/international/bidi-override-expected.png:
  • fast/text/international/bidi-override-expected.txt:

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-multiple-renderers.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (overrideLayoutOperation): Fetch renderer info from the renderers array; add synthetic bold offset; render only synthetic bold in the synthetic bold pass. (drawGlyphs): Replaced 14 with new SYNTHETIC_OBLIQUE_ANGLE define. (initializeATSUStyle): Apply a skewing transform for synthetic oblique. (createATSUTextLayout): Merged into createATSUTextLayout. (createATSULayoutParameters): Merged in createATSUTextLayout; allocate and fill a renderers array and a character buffer for small caps and mirroring; (applyMirroringToRun): Merged into createATSULayoutParameters. (ATSU_drawHighlight): Deleted mirroring code. (ATSU_draw): Deleted mirroring code; added second pass for synthetic bold. (ATSU_pointToOffset): Deleted mirroring code.
1:03 PM Changeset in webkit [11672] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: darin

  • Scripts/run-webkit-tests: stop /etc/catalog warnings
12:54 PM Changeset in webkit [11671] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/atsui-kerning-and-ligatures-expected.checksum: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.png: Added.
  • fast/text/atsui-kerning-and-ligatures-expected.txt: Added.
  • fast/text/atsui-kerning-and-ligatures.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/atsui-kerning-and-ligatures.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (initializeATSUStyle): Disable kerning; disable ligatures unless the font does not contain 'a', in which case it is assumed to never be rendered by the CG code path.
12:48 PM Changeset in webkit [11670] by darin
  • 3 edits in trunk/JavaScriptCore

Originally done by both George Staikos and Alexey Proskuryakov.

Our coding guidelines say "use 0 instead of NULL" and both RefPtr and
PassRefPtr were using NULL, which required including a header that
defines NULL.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Use 0 instead of NULL. (KXMLCore::PassRefPtr::operator!): Use ! instead of == NULL.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Use 0 instead of NULL. (KXMLCore::RefPtr::operator!): Use ! instead of == NULL. Also did some reformatting.
12:41 PM Changeset in webkit [11669] by darin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::ElementImpl): Remove code to initialize the pointer; not needed since RefPtr gets initialized to 0. (ElementImpl::~ElementImpl): Remove code to deref the pointer; RefPtr handles that. (ElementImpl::attributes): Add get() call to get raw pointer. (ElementImpl::setAttributeMap): Remove code to deref the old map and set the new map. But added code to clear the element pointer from the old map (missing in the old version). Also added a FIXME. (ElementImpl::createAttributeMap): Remove ref(); RefPtr handles that. (NamedAttrMapImpl::addAttribute): Use a RefPtr to guarantee the element does not go away in the middle of dispatching DOM events. (StyledElementImpl::attributeChanged): Clean up code by using the inline function mappedAttributes() instead of doing type casts. (StyledElementImpl::parseMappedAttribute): Ditto. (StyledElementImpl::getClassList): Ditto.
  • khtml/xml/dom_elementimpl.h: Make ElementImpl::namedAttrMap be a RefPtr instead of raw pointer. Added an overload of StyledElementImpl::mappedAttributes for both const and non-const.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::addChild): Use a RefPtr to ref/deref the child so that it doesn't leak.
  • khtml/html/htmlparser.h: Changed isindex to use a RefPtr.
  • khtml/html/htmlparser.cpp: (HTMLParser::~HTMLParser): Removed now-unneeded ref. (HTMLParser::isindexCreateErrorCheck): Remove now-unneeded deref/ref. (HTMLParser::handleIsindex): Put isindex element into a RefPtr. This prevents a crash that was otherwise happening during layout tests (caused indirectly by the changes above). (HTMLParser::startBody): Added call to get().
11:56 AM Changeset in webkit [11668] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric Seidel.

  • DumpRenderTree/DumpRenderTree.m: (main): Call poseAs to substitute our NSPasteboard class for the default one. Create a local pasteboard (really a global one with a unique name) and release it when exiting from the function so we don't leave it in the pasteboard server. (dumpRenderTree): Added an autorelease pool around one small bit of code that ddn't have one. Fixed a leak in an unlikely error case. (+[DumpRenderTreePasteboard generalPasteboard]): Override the default version of this method to return our local pasteboard.
11:53 AM Changeset in webkit [11667] by darin
  • 42 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff Garen and Eric Seidel.

  • kjs/simple_number.h: Removed many unnecessary includes, including the <cmath> one to work around GCC library header bugs. We may have to add some includes elsewhere for platforms other than OS X, since our prefix header takes care of some things.
  • kxmlcore/AlwaysInline.h: Added. Now clients that don't include simple_number.h can still get the ALWAYS_INLINE macro.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added AlwaysInline.h.
  • bindings/NP_jsobject.h: Removed a lot of unnecessary includes and removed C-specific stuff from this C++-only header.
  • bindings/jni/jni_jsobject.h: Removed a lot of unnecessary includes and did some reformatting.
  • bindings/objc/objc_runtime.h: Removed an unnecessary include.
  • bindings/runtime.h: Removed some unneeded includes. Reformatted.
  • bindings/runtime.cpp: Updated to compile with header changes, including a lot of reformatting.
  • bindings/runtime_object.h: Removed an unnecessary include.

WebCore:

Reviewed by Geoff Garen and Eric Seidel.

  • ForwardingHeaders/kxmlcore/AlwaysInline.h: Added.
  • WebCorePrefix.h: Removed the use of <ostream>.
  • kwq/KWQDef.h: Removed now-unused Q_INT64, Q_INT16, Q_UINT16, qRound, and _KWQ_IOSTREAM_.
  • kwq/KWQKHTMLPart.h: Removed some unneeded headers and added forward-declarations of classes instead. Corrected some incorrect member function declarations.
  • kwq/KWQKHTMLPart.mm: Added a now-needed header.
  • khtml/ecma/kjs_window.cpp: Removed the <cmath> workaround.
  • khtml/rendering/bidi.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • khtml/rendering/render_canvasimage.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_image.cpp: Removed the <cmath> workaround.
  • khtml/rendering/render_text.cpp: Added include of AlwaysInline.h and removed a lot of unnecessary includes.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::calculateColor):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::notifyAttributeChange):
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): Replaced use of qRound with use of lroundf or lround as appropriate.
  • kwq/KWQCString.h:
  • kwq/KWQCString.mm:
  • kwq/KWQDateTime.h:
  • kwq/KWQDateTime.mm:
  • kwq/KWQMap.h:
  • kwq/KWQMemArray.h:
  • kwq/KWQPoint.mm:
  • kwq/KWQPointArray.h:
  • kwq/KWQPtrList.h:
  • kwq/KWQPtrStack.h:
  • kwq/KWQPtrVector.h:
  • kwq/KWQRect.h:
  • kwq/KWQRect.mm:
  • kwq/KWQSize.h:
  • kwq/KWQSize.mm:
  • kwq/KWQValueList.h: Removed _KWQ_IOSTREAM_ code that was used at one time for unit tests, but is now unneeded, and requires <ostream>.
11:51 AM Changeset in webkit [12225] by darin
  • 1 edit
    1 add in trunk/JavaScriptGlue

Reviewed by Geoff Garen and Eric Seidel.

  • kxmlcore/AlwaysInline.h: Added.
11:50 AM Changeset in webkit [11666] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen and John Sullivan.

  • kwq/KWQLoader.mm: (+[NSDictionary _webcore_dictionaryWithHeaderString:_webcore_dictionaryWithHeaderString:]): Check length of string before calling characterAtIndex:0 since it will fail for an empty string.
11:41 AM Changeset in webkit [11665] by bdakin
  • 2 edits
    1 add in trunk/WebCore

Bug #:
Submitted by:
Reviewed by:

11:37 AM Changeset in webkit [11664] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/text/should-use-atsui-expected.checksum: Added.
  • fast/text/should-use-atsui-expected.png: Added.
  • fast/text/should-use-atsui-expected.txt: Added.
  • fast/text/should-use-atsui.html: Added.

WebKit:

Reviewed by Darin, committed by Adele.

Test: fast/text/should-use-atsui.html

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Always start scanning from 0 since drawing and highlighting also measure everything up to run->from.
11:17 AM Changeset in webkit [11663] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin, committed by Adele.

  • khtml/ecma/xmlhttprequest.cpp: (getMIMEType): A helper function to get MIME type from a Content-Type string. (getCharset): A helper function to get charset from a Content-Type string. (KJS::XMLHttpRequest::getValueProperty): Factored out responseIsXML(). (KJS::XMLHttpRequest::getResponseHeader): Return QString instead of JSValue (to get rid of unnecessary JSLocks). (KJS::XMLHttpRequest::responseIsXML): A new method that analyses Content-Type. (KJS::XMLHttpRequest::slotData): Use a correct charset for responses, see bug for details. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Update for getResponseHeader() changes
  • khtml/ecma/xmlhttprequest.h:
11:16 AM Changeset in webkit [11662] by thatcher
  • 1 add in trunk/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

2:38 AM Changeset in webkit [11661] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Geoff and Adele

  • replaced custom Identifier hashtable with HashSet
  • kjs/identifier.cpp: (KXMLCore::): (KJS::identifierTable): (KJS::Identifier::equal): (KJS::hash): (KJS::equal): (KJS::convert): (KJS::Identifier::add): (KJS::Identifier::remove):
  • kjs/identifier.h:
  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject):
2:32 AM Changeset in webkit [11660] by mjs
  • 4 edits
    4 deletes in trunk

WebCore:

Rubber stamped by Eric.

  • removed unused SPI headers
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/DOM-compat.h: Removed.

WebKit:

Rubber stamped by Eric.

  • remove some unused SPI headers.
  • DOM.subproj/WebDOMDocument.h: Removed.
  • DOM.subproj/WebDOMElement.h: Removed.
  • DOM.subproj/WebDOMNode.h: Removed.
  • WebKit.xcodeproj/project.pbxproj:

Dec 18, 2005:

4:27 PM Changeset in webkit [11659] by darin
  • 4 edits
    2 adds in trunk

JavaScriptCore:

Reviewed, tweaked, and landed by Darin.

  • kjs/array_object.h:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Added implementation of indexOf.

LayoutTests:

Reviewed, tweaked, and landed by Darin.

  • fast/js/array-indexof-expected.txt: Added.
  • fast/js/array-indexof.html: Added.
3:41 PM Changeset in webkit [11658] by darin
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/DOMInternal.mm: (DOMString::DOMString): Remove now-unneeded ref.
3:40 PM Changeset in webkit [11657] by darin
  • 5 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget): Cast pointer to a TextImpl before calling containsOnlyWhitespace; the code already checked isTextNode.
  • khtml/rendering/render_line.cpp: (khtml::shouldDrawDecoration): Expanded an if statement into a few separate ones for slight additional clarity. Added a check of isTextNode and cast pointer to a TextImpl.
  • khtml/xml/dom_nodeimpl.h: Remove containsOnlyWhitespace function.
  • khtml/xml/dom_textimpl.h: Remove virtual keyword from containsOnlyWhitespace.
2:55 PM Changeset in webkit [11656] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, landed by Darin.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.txt: Added.
  • fast/text/international/bidi-ignored-for-first-child-inline.html: Added.

WebCore:

Reviewed by Hyatt, landed by Darin.

Test: fast/text/international/bidi-ignored-for-first-child-inline.html

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5980
Bidi properties of an inline container whose first child is an
inline container are ignored

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiNext): Adjust embedding at inline containers' boundaries instead of inside. (khtml::RenderBlock::bidiFirst): (khtml::RenderBlock::determineStartPosition):
2:37 PM Changeset in webkit [11655] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • test of a particular character set name that is not in the WebCore table but is in the ICU table (see bugzilla 5932)
  • fast/encoding/charset-cp1251-expected.txt: Added.
  • fast/encoding/charset-cp1251.html: Added.

WebCore:

Reviewed and landed by Darin.

  • kwq/KWQCharsets.mm: (KWQCFStringEncodingFromIANACharsetName): Fall back on ICU encoding names if we don't find the name in the WebCore encoding names table.
2:23 PM Changeset in webkit [11654] by darin
  • 5 edits
    6 adds in trunk

LayoutTests:

Reviewed and landed by Darin.

  • XSLT document encoding tests
  • fast/xsl/xslt-doc-enc-expected.txt: Added.
  • fast/xsl/xslt-doc-enc.xml: Added.
  • fast/xsl/xslt-doc-enc.xsl: Added.
  • fast/xsl/xslt-doc-noenc-expected.txt: Added.
  • fast/xsl/xslt-doc-noenc.xml: Added.
  • fast/xsl/xslt-doc-noenc.xsl: Added.

WebCore:

Reviewed and landed by Darin.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::applyXSLTransform): Get encoding from transform and pass in to XSLTProcessor.
  • khtml/xsl/xslt_processorimpl.h:
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Added encoding parameter. Create a Decoder and use it to decode the source document (default encoding UTF-8). (DOM::XSLTProcessorImpl::transformToString): Add an encoding result. Set it to the encoding from the libxml2 document object. (DOM::XSLTProcessorImpl::transformToDocument): Get encoding from transform and pass in to XSLTProcessor. (DOM::XSLTProcessorImpl::transformToFragment): Ditto.
2:13 PM Changeset in webkit [11653] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric, landed by Darin.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::attributedString): Fix incorrectly nested else.
5:28 AM Changeset in webkit [11652] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date

5:27 AM Changeset in webkit [11651] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4000
Object.prototype is missing isPrototypeOf

  • fast/js/test-isPrototypeOf-expected.txt: Added.
  • fast/js/test-isPrototypeOf.html: Added.
5:27 AM Changeset in webkit [11650] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-18 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • kjs/object_object.cpp: (ObjectPrototype::ObjectPrototype): Add isPrototypeOf to object prototype.

(ObjectProtoFunc::callAsFunction):
Implement isPrototypeOf

  • kjs/object_object.h: (KJS::ObjectProtoFunc::): Add id for isPrototypeOf.
1:20 AM Changeset in webkit [11649] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

updaated changelog to remove previous suggestion that darin was a nobody

Note: See TracTimeline for information about the timeline view.