⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 22, 2005:

11:55 PM Changeset in webkit [11742] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • khtml/khtml_part.cpp (KHTMLPart::write): Do not use the parent frame encoding as a default for sub-frames (revert rdar://3100151).
11:35 PM Changeset in webkit [11741] by mjs
  • 2 edits in trunk/JavaScriptCore
  • fix build problem from last commit.
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
7:57 PM Changeset in webkit [11740] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Eric.

  • made RefPtr<DOMStringImpl> usable as a hashtable key/value
  • changed XSLTProcessorImpl to make use of this instead of a QDict.
  • partially fixed broken param handling for xslt

See LayoutTests for updated test case.

  • khtml/xml/dom_stringimpl.cpp:
  • khtml/xml/dom_stringimpl.h: (KXMLCore::): Set things up so you can use RefPtr<DOMStringImpl> as a hashtable key (should already be usable as a value).
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::xsltParamArrayFromParameterMap): Updated to use a HashMap of RefPtrs instead of QDict. Also, fixed bugs that would have kept this from ever working at all. (DOM::XSLTProcessorImpl::transformToString): ditto (DOM::XSLTProcessorImpl::setParameter): ditto (DOM::XSLTProcessorImpl::getParameter): ditto (DOM::XSLTProcessorImpl::removeParameter): ditto
  • khtml/xsl/xslt_processorimpl.h:
5:52 PM Changeset in webkit [11739] by mjs
  • 13 edits in trunk

JavaScriptCore:

Reviewed by Darin.

The changes for support are relatively simple, but I also made extensive changes to
avoid copying, so that there isn't refcount thrash when you put RefPtrs into a HashMap.

  • kxmlcore/HashTable.h: (KXMLCore::swap): specialize swap for pairs, to swap elements individually, so that excess copies can be avoided. (KXMLCore::Mover::move): Template function to either copy or swap, used when transferring elements from old table to new. (KXMLCore::IdentityHashTranslator::hash): The old "converting lookup" templates that took two or three function parameters now take a class parameter, this is the class used to do a normal lookup. (KXMLCore::IdentityHashTranslator::equal): Ditto. (KXMLCore::IdentityHashTranslator::translate): Ditto. Translate now takes a reference to write into instead of returning a value to avoid redundant copies. (KXMLCore::HashTable::~HashTable): Use deallocateTable instead of freeing directly. (KXMLCore::HashTable::insert): Based on HashTranslator now instead of separate functions. Added a FIXME about a remaining rare excess copy. (KXMLCore::HashTable::isEmptyBucket): Use KeyTraits directly instead of unwrapping the key from Traits, to avoid creating and destroying pair, which copies. (KXMLCore::HashTable::isDeletedBucket): ditto (KXMLCore::HashTable::lookup): Use HashTranslator now instead of separate functions. (KXMLCore::HashTable::initializeBucket): Renamed from emptyBucket. Use placement new to work right for non-POD types. (KXMLCore::HashTable::deleteBucket): Use assignDeleted to avoid excess copies. (KXMLCore::HashTable::reinsert): use Mover template to copy or swap as appropriate (KXMLCore::HashTable::allocateTable): Initialize every bucket if calloc won't do. (KXMLCore::HashTable::deallocateTable): Destruct every bucket if needed. (KXMLCore::HashTable::rehash): Avoid copy before reinserting, so that swap can do its magic. (KXMLCore::HashTable::clear): use deallocateTable instead of freeing directly. (KXMLCore::HashTable::HashTable): be more dumb when copying to ensure that non-POD types work right
  • kxmlcore/HashFunctions.h: (KXMLCore::PointerHash): Specialize PointerHash for RefPtr
  • kxmlcore/HashMap.h: (KXMLCore::extractFirst): Return a reference not a full object to avoid copies. (KXMLCore::HashMapTranslator::hash): Use a special translator for insertion to defer making the pair as long as possible, thus avoiding needless copies. (KXMLCore::HashMapTranslator::equal): ditto (KXMLCore::HashMapTranslator::translate): ditto (KXMLCore::::inlineAdd): Shared by set and add to insert using HashMapTranslator (KXMLCore::::set): Use inlineAdd (KXMLCore::::add): Use inlineAdd
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::): Pass KeyTraits along
  • kxmlcore/HashSet.h: (KXMLCore::identityExtract): Return a reference not a full object to avoid copies. (KXMLCore::HashSetTranslatorAdapter::hash): Redo adapter stuff to work with the new HashTranslator approach. (KXMLCore::HashSetTranslatorAdapter::equal): ditto (KXMLCore::HashSetTranslatorAdapter::translate): ditto (KXMLCore::::insert): ditto
  • kxmlcore/HashTraits.h: (KXMLCore::GenericHashTraits): This is intended be used as a base class for customized traits: sensible defaults. (KXMLCore::): Use it a bunch (KXMLCore::assignDeleted): template function to allow pairs to be assigned the deleted value w/o excess copies. (KXMLCore::PairHashTraits::emptyValue): Updated (KXMLCore::PairHashTraits::deletedValue): Updated (KXMLCore::PairHashTraits::assignDeletedValue): part of assignDeleted hack (KXMLCore::DeletedValueAssigner::assignDeletedValue): Use template magic to either use use deletedValue or assignDeletedValue for the cases where we care.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::swap): Added swap method. (KXMLCore::swap): Added swap free function.
  • kjs/identifier.cpp: (KJS::CStringTranslator::hash): Use new HashTranslator class approach to alternate type based insertion. (KJS::CStringTranslator::equal): ditto (KJS::CStringTranslator::translate): ditto (KJS::Identifier::add): ditto (KJS::UCharBufferTranslator::hash): ditto (KJS::UCharBufferTranslator::equal): ditto (KJS::UCharBufferTranslator::translate): ditto
  • irrelevant change:
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Removed a stray space.

WebCore:

Reviewed by Darin.

  • update for new HashTranslator stuff
  • khtml/xml/dom_atomicstring.cpp: (DOM::CStringTranslator::hash): (DOM::CStringTranslator::equal): (DOM::CStringTranslator::translate): (DOM::AtomicString::equal): (DOM::AtomicString::add): (DOM::QCharBufferTranslator::hash): (DOM::QCharBufferTranslator::equal): (DOM::QCharBufferTranslator::translate):
  • khtml/xml/dom_qname.cpp: (DOM::QNameComponentsTranslator::hash): (DOM::QNameComponentsTranslator::equal): (DOM::QNameComponentsTranslator::translate): (DOM::QualifiedName::QualifiedName):
5:13 PM Changeset in webkit [11738] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Cleaned up a previous checkin by defining global const defaultForm.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::radioButtonChecked): (DocumentImpl::checkedRadioButtonForGroup): (DocumentImpl::removeRadioButtonGroup):
4:14 PM Changeset in webkit [11737] by vicki
  • 3 edits in branches/Safari-1-3-branch/WebCore

Reviewed by Eric.

  • fix <rdar://problem/4379899> *Panther* REGRESSION (TOT): Scrollwheel doesn't work on frameset pages (5450) and <rdar://problem/4379906> *Pan EU2* 10.4.4 Regression: Seed: scrolling with scrollwheel, trackpad doesn't work for nested framesets at gmail.com

Basically plug in the TOT fixes for Panther. Add passWheelEventToChildWidget, but add the event as a
parameter - since there's no concept of _currentEvent on the branch, we have to pass the event around.
Return true when passing the wheel event to the child widget, since we don't want to send the event on
to the nextResponder for this case.

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::scrollOverflowWithScrollWheelEvent): (KWQKHTMLPart::passWheelEventToChildWidget):
3:06 PM Changeset in webkit [11736] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

Tests for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • fast/forms/radio_checked_dynamic-expected.checksum: Added.
  • fast/forms/radio_checked_dynamic-expected.png: Added.
  • fast/forms/radio_checked_dynamic-expected.txt: Added.
  • fast/forms/radio_checked_dynamic.html: Added.

WebCore:

Reviewed by Tim Hatcher.

Fixed <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): update radio button hash map when moving form elements around. (DOM::HTMLGenericFormElementImpl::insertedIntoTree): ditto.
  • khtml/html/html_formimpl.h: (DOM::HTMLGenericFormElementImpl::isRadioButton): Added. (DOM::HTMLInputElementImpl::isRadioButton): Added.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::radioButtonChecked): Added comment explaining that we use 1 for the default form. We can't use a null pointer as a key for the hash map. (DocumentImpl::checkedRadioButtonForGroup): Added conversion of null form pointer to 1. (DocumentImpl::removeRadioButtonGroup): ditto.
2:38 PM Changeset in webkit [11735] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-21 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
2:36 PM Changeset in webkit [11734] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-20 Adele Peterson <​adele@apple.com>

Reviewed by Darin.

Fix for <rdar://problem/4387630> REGRESSION: <select> element's onClick event doesn't fire @ bugweb.apple.com

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::passSubframeEventToSubframe): only pass mouse down for khtmlviews.
1:10 PM Changeset in webkit [11733] by andersca
  • 14 edits in trunk/WebCore

2005-12-22 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.

  • khtml/ecma/XSLTProcessor.cpp:
  • khtml/ecma/domparser.cpp:
  • khtml/ecma/kjs_css.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_range.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/xmlhttprequest.cpp:
  • khtml/ecma/xmlserializer.cpp: Update for changes to JSC.
1:08 PM Changeset in webkit [11732] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove conflict markers

1:07 PM Changeset in webkit [11731] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-22 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric and Darin.

  • kjs/lookup.h: Move ClassName from KJS_DECLARE_PROTOTYPE to KJS_IMPLEMENT_PROTOTYPE. Also, namespace all macros by prefixing them with KJS_.
11:59 AM Changeset in webkit [11730] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/rendering/render_table.cpp

Fixing a merge issue with <rdar://problem/4364640> *PanEu2* REGRESSION: Table layout issue occurs at ​http://www.pixar.com/shorts/index.html

8:53 AM Changeset in webkit [11729] by darin
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Eric.

  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::self): Don't use static deleter for two reasons: (1) We don't want any globals with constructors in any of our frameworks because they slow down framework load time. (2) There's no need to destroy this object at process termination time -- it's extra work with no benefit. Because of both these reasons, our KStaticDeleter implementation was basically a no-op.
  • ksvg2/svg/SVGDOMImplementationImpl.cpp: (SVGDOMImplementationImpl::self): Ditto.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setDocumentChanged): Ditto.
  • khtml/html/html_canvasimpl.cpp: Removed include of kstringhandler.h.
  • khtml/html/html_imageimpl.cpp: Ditto.
  • khtml/khtmlpart_p.h: Removed something that was in an "APPLE_CANGES" ifdef.
  • ForwardingHeaders/kstaticdeleter.h: Removed.
  • ForwardingHeaders/kstringhandler.h: Removed.
  • kwq/KWQKStaticDeleter.h: Removed.
  • kwq/KWQKStringHandler.h: Removed.
  • kwq/KWQKStringHandler.mm: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed files.
8:50 AM Changeset in webkit [11728] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/parser/nsup-entity-expected.txt: Added.
  • fast/parser/nsup-entity.html: Added.

WebCore:

Reviewed by Eric.

  • khtml/html/kentities.gperf: Add "nsup" to table.
  • khtml/html/htmltokenizer.cpp: Removed old workaround for inlining issue that no longer seems to be necessary; also touches the file which is important because Xcode doesn't seem to understand the dependency on kentities.gperf and the need to recompile.
8:48 AM Changeset in webkit [11727] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/PassRefPtr.h: (KXMLCore::PassRefPtr::PassRefPtr): Remove non-template constructor that takes RefPtr since the constructor template that takes RefPtr should be sufficient. Add a constructor template that takes PassRefPtr&. (KXMLCore::PassRefPtr::adopt): Use PassRefPtr_Ref to avoid setting pointer first to 0 and then to the pointer. (KXMLCore::PassRefPtr::operator=): Added template versions that take PassRefPtr& and RefPtr parameters. (KXMLCore::PassRefPtr::operator PassRefPtr<U>): Changed to fix leak -- old version would release and then ref. (KXMLCore::operator==): Make templates have two parameters so you can mix types. Also remove unneeded const in raw pointer versions. (KXMLCore::operator!=): Ditto.
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): Add constructor template that takes PassRefPtr. (KXMLCore::RefPtr::operator=): Add assignment operator templates that take RefPtr and PassRefPtr. (KXMLCore::operator==): Make templates have two parameters so you can mix types. Also remove unneeded const in raw pointer versions. (KXMLCore::operator!=): Ditto.
8:46 AM Changeset in webkit [11726] by darin
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/rendering/DataRef.h: (khtml::DataRef::operator=): Eliminate an extra branch by doing ref before deref instead of == check.
  • khtml/rendering/render_style.cpp: (khtml::initDefaultStyle): Added. Function to initialize the default style for use in constructor. (khtml::RenderStyle::RenderStyle): Changed constructor to initalize all the members with constructor syntax instead of using assignment on all of them.
  • khtml/rendering/render_style.h: Removed static data member _default -- it's now a file scope global instead.

Dec 21, 2005:

11:39 PM Changeset in webkit [11725] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/cvs-create-patch: Handle newly-added directories using chdir.
10:55 PM Changeset in webkit [11724] by darin
  • 3 edits in trunk/LayoutTests
  • fast/text/attributed-substring-from-range-expected.txt: Updated.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Updated.
8:11 PM Changeset in webkit [11723] by darin
  • 14 edits in trunk/WebCore

Reviewed by Justin.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::applyBlockStyle): Call new updateLayout member function. (khtml::ApplyStyleCommand::applyInlineStyle): Ditto. (khtml::ApplyStyleCommand::pushDownTextDecorationStyleAtBoundaries): Ditto.
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::addBlockPlaceholderIfNeeded): Ditto. (khtml::CompositeEditCommand::findBlockPlaceholder): Ditto. (khtml::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Ditto.
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::fixupWhitespace): Ditto. (khtml::DeleteSelectionCommand::moveNodesAfterNode): Ditto.
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::apply): Ditto. (khtml::EditCommand::unapply): Ditto. (khtml::EditCommand::reapply): Ditto. (khtml::EditCommand::updateLayout): Added. Calls updateLayoutIgnorePendingStylesheets on the document.
  • khtml/editing/edit_command.h: Added updateLayout member function.
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply): Call new updateLayout member function.
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply): Ditto.
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::execCommand): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (DOM::JSEditor::queryCommandEnabled): Ditto. (DOM::JSEditor::queryCommandIndeterm): Ditto. (DOM::JSEditor::queryCommandState): Ditto. (DOM::JSEditor::queryCommandValue): Ditto.
  • khtml/editing/markup.cpp: (khtml::createMarkup): Ditto.
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplacementFragment::insertFragmentForTestRendering): Ditto. (khtml::ReplaceSelectionCommand::fixupNodeStyles): Call new updateLayout member function. (khtml::ReplacementFragment::computeStylesUsingTestRendering): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (khtml::ReplaceSelectionCommand::doApply): Call new updateLayout member function. (khtml::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto. (khtml::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • khtml/editing/visible_units.cpp: (khtml::previousLinePosition): Call updateLayoutIgnorePendingStylesheets instead of updateLayout. (khtml::nextLinePosition): Ditto.
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::innerText): Ditto.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]): Ditto. (-[WebCoreBridge smartDeleteRangeForProposedRange:]): Ditto.
8:06 PM Changeset in webkit [11722] by darin
  • 4 edits in trunk/WebCore

Reviewed by Geoff.

  • khtml/ecma/kjs_events.cpp: (KJS::DOMMouseEvent::getValueProperty): Change everything to just call through instead of doing the work here. (KJS::DOMWheelEvent::getValueProperty): Ditto.
  • khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::offsetX): (DOM::MouseRelatedEventImpl::offsetY):
  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Initialize new m_pageX, m_pageY, m_layerX, m_layerY, m_offsetX, and m_offsetY. (DOM::MouseRelatedEventImpl::computePositions): Renamed from computeLayerPos since it handles page position andoffset position too now. (DOM::MouseRelatedEventImpl::pageX): Added. Not in header since it's virtual. (DOM::MouseRelatedEventImpl::pageY): Ditto. (DOM::MouseRelatedEventImpl::x): Added, with FIXME since it should change eventually. (DOM::MouseRelatedEventImpl::y): Ditto. (DOM::MouseEventImpl::initMouseEvent): Call computePositions instead of computeLayerPos. (DOM::MouseEventImpl::toElement): Added. (DOM::MouseEventImpl::fromElement): Added.
5:40 PM Changeset in webkit [11721] by thatcher
  • 6 edits in trunk

JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebKit:

  • WebKit.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.
5:32 PM Changeset in webkit [12226] by thatcher
  • 2 edits in trunk/JavaScriptGlue

JavaScriptGlue:

  • JavaScriptGlue.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebBrowser:

  • WebBrowser.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.

WebKitSystemInterface:

  • WebKitSystemInterface.xcodeproj/project.pbxproj: Set tab width to 8, indent width to 4 and uses tabs to false per file.
5:25 PM Changeset in webkit [11720] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick and Darin Adler.

  • fixed HiDPI problem with forms auto-fill menu width

No test cases added; this code is used for "chrome" only.

  • kwq/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): convert entire rect to window coordinates, not just origin
4:55 PM Changeset in webkit [11719] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Removed evil hack for determining if a type is an integer, replaced
with template metaprogramming.

  • JavaScriptCore.xcodeproj/project.pbxproj: Set tab size to 2 for testkjs.cpp
  • kjs/testkjs.cpp: (main): Inserted asserts to test IsInteger. FIXME: Move these to KXMLCore unit tests directory when we create one.
  • kxmlcore/HashTraits.h: (KXMLCore::): Added IsInteger class for querying types.
2:51 PM Changeset in webkit [11718] by harrison
  • 13 edits in trunk/WebCore

Reviewed by Justin).

<rdar://problem/4039777> Pasting particular snippet of HTML containing list items and a link creates too many list items

  • Fixed paste crash by making calling RenderBox::deleteLineBoxWrapper() from RenderObject::remove(), so that the connection is broken before the InlineBox's parent gets deleted.
  • Fixed overzealous style changes when setting the style on a specific range of elements. These specific ranges are derived programmatically, e.g. as a part of pasting, so they must be respected exactly rather than modified by converting the endpoints to VisiblePositions.

Test cases coming soon.

  • khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::ApplyStyleCommand): (khtml::ApplyStyleCommand::updateStartEnd): (khtml::ApplyStyleCommand::startPosition): (khtml::ApplyStyleCommand::endPosition): (khtml::ApplyStyleCommand::applyBlockStyle): (khtml::ApplyStyleCommand::applyRelativeFontStyleChange): (khtml::ApplyStyleCommand::applyInlineStyle): (khtml::ApplyStyleCommand::removeInlineStyle): (khtml::ApplyStyleCommand::splitTextAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextAtEndIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtStartIfNeeded): (khtml::ApplyStyleCommand::splitTextElementAtEndIfNeeded): (khtml::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): (khtml::ApplyStyleCommand::mergeEndWithNextIfIdentical): (khtml::ApplyStyleCommand::joinChildTextNodes):
  • khtml/editing/apply_style_command.h:
  • khtml/editing/composite_edit_command.cpp: (khtml::CompositeEditCommand::applyStyle):
  • khtml/editing/composite_edit_command.h:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::fixupNodeStyles): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
  • khtml/rendering/render_box.cpp: (RenderBox::destroy): (RenderBox::deleteLineBoxWrapper):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListMarker::~RenderListMarker): (RenderListMarker::setStyle):
  • khtml/rendering/render_object.cpp: (RenderObject::remove):
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderWidget::destroy):
2:42 PM Changeset in webkit [11717]
  • 212 copies
    17 deletes in tags/WebCore-417~17

This commit was manufactured by cvs2svn to create tag
'WebCore-417~17'.

2:42 PM Changeset in webkit [11716] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

1:57 PM Changeset in webkit [11715] by adele
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim Hatcher.

Fix for <rdar://problem/4387433> Seed: Radio buttons behave incorrectly in Gmail settings

  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::registerFormElement): If this form element is already checked in the default form, remove it from m_selectedRadioButtons and add it for the new form.
9:43 AM Changeset in webkit [11714] by thatcher
  • 1 add in branches/Safari-1-3-branch/WebCore/ChangeLog

Rolled over to ChangeLog-2005-12-19

8:51 AM Changeset in webkit [11713] by thatcher
  • 1 delete in branches/Safari-1-3-branch/WebCore/ChangeLog

file ChangeLog was added on branch Safari-1-3-branch on 2005-12-21 17:43:18 +0000

8:50 AM Changeset in webkit [11712]
  • 1 copy in branches/Safari-1-3-branch/WebCore/ChangeLog

This commit was manufactured by cvs2svn to create branch
'Safari-1-3-branch'.

8:50 AM Changeset in webkit [11711] by adele
  • 19 edits in trunk

LayoutTests:

Reviewed by Darin.

Updating results for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div

These results all changed because we now select all for contenteditable elements when focus() is called on them.

  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:
  • fast/dom/blur-contenteditable-expected.txt:
  • fast/dom/focus-contenteditable-expected.checksum:
  • fast/dom/focus-contenteditable-expected.png:
  • fast/dom/focus-contenteditable-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:

WebCore:

Reviewed by Darin.

Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5911
REGRESSION: Page scroll position jumps when clicking on word in editable div

I moved the scrolling code out of setFocusNode, and consolidated some of the focus code to scroll when necessary.

  • khtml/html/html_formimpl.cpp: Removed HTMLButtonElementImpl::blur, HTMLButtonElementImpl::focus, HTMLInputElementImpl::blur, HTMLInputElementImpl::focus. New code in ElementImpl::focus will now handle these cases. This allows tabbing through the elements to go through the same code path as calling focus() on an element. Before, focus() would scroll to reveal for any form elements that had a RenderWidget, but wouldn't scroll for anchor elements, or any of the new form elements. Now the behavior will be more consistent. (DOM::HTMLLabelElementImpl::focus): calls ElementImpl::focus. (DOM::HTMLLegendElementImpl::focus): ditto.
  • khtml/html/html_formimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::selectAll): calls new function selectContentsOfNode (KHTMLPart::selectContentsOfNode): factored out code to selectAll for a particular node- which is useful for contenteditable elements.
  • khtml/khtml_part.h: added selectContentsOfNode
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): removed scrolling code.
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus): Calls updateLayout in case focus() is called before there's a renderer. Makes a selection for editable elements (right now we select all, but this will change). Doesn't scroll if the renderer is a RenderWidget, since that is handled when the view becomes first responder. This will go away when we convert the rest of our form elements.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::revealSelection): Made this more like centerSelectionInVisibleArea where we get the right rectangle if the selection is a caret. (KWQKHTMLPart::nextKeyViewInFrame): call ElementImpl::focus() for the node. This will set the selection too, which used to be done here.
2:53 AM Changeset in webkit [11710] by eseidel
  • 1 edit in trunk/LayoutTests/ChangeLog

Bug #: none
Submitted by: eseidel
Reviewed by: none needed.

Fixed ChangeLog typo.

2:44 AM Changeset in webkit [11709] by eseidel
  • 3 edits
    2 adds in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Beef up our XSLT processor tests to include a test which passes
a parameter into the transform. I also took this opportunity
to clean up the output a bit, and in the process found another
bug and file: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6180

  • fast/xsl/resources/xslt-param.xml: Added.
  • fast/xsl/resources/xslt-param.xsl: Added.
  • fast/xsl/xslt-processer-expected.txt:
  • fast/xsl/xslt-processer.html:
Note: See TracTimeline for information about the timeline view.