⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 24, 2005:

11:52 PM Changeset in webkit [11761] by eseidel
  • 2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Un-break HashTable copy constructor.

  • kxmlcore/HashTable.h: (KXMLCore::::HashTable): use const_iterator instead
9:11 PM Changeset in webkit [11760] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

Bug #: 6236
Submitted by: mitz
Reviewed by: eseidel

  • fast/forms/domstring-replace-crash-expected.txt: Added.
  • fast/forms/domstring-replace-crash.html: Added.
9:11 PM Changeset in webkit [11759] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 6326
Submitted by: mitz
Reviewed by: eseidel

Test: fast/forms/domstring-replace-crash.html

  • khtml/dom/dom_string.h: (DOMString::replace): Added check for null m_impl.
2:45 PM Changeset in webkit [11758] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::accessors): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::putValueProperty):
  • khtml/ecma/kjs_html.h:
2:06 PM Changeset in webkit [11757] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::HashMap): In all methods, explicitly cast all pointers to void * before passing to internal implementation. Use C-style casts instead of new-style casts, because the real solution would require a combo of reinterpret_cast anc const_cast.
2:00 PM Changeset in webkit [11756] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6231

  • Fixed assertion failure in QString::mid caused by my last checkin. parseWindowFeatuers() sometimes called QString::mid() with a start index past the end of the string but a length of 0. There were two problems there. (1) parseWindowString() shouldn't have gotten past the end of the string. (2) QString had range truncating code that was borked. So I fixed both.
  • khtml/ecma/kjs_window.cpp: (KJS::parseWindowFeatures): One of the "past the end" tests was > instead of >=.
  • kwq/KWQString.mm: (QString::mid): Truncate length *before* deciding whether to return early. Also, compare start and data._length before computing data._length - start, because the error case we're trying to catch will almost certainly cause unsigned overflow.
  • manual-tests/window-open-features-parsing.html: Added trailing ',' to uber-test to catch this failure, too.
2:02 AM Changeset in webkit [11755] by ap
  • 4 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Changed the parameter type of slotTextChanged to const DOMString &
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): ditto. (RenderLineEdit::slotTextChanged): ditto. (RenderFileButton::RenderFileButton): ditto. (RenderFileButton::slotTextChanged): ditto.

Dec 23, 2005:

5:05 PM Changeset in webkit [11754] by ggaren
  • 2 edits in branches/Safari-2-0-branch/WebCore

Fix by Darin, reviewed and landed by me.

  • khtml/rendering/render_container.cpp: (RenderContainer::updatePseudoChild): Don't have the parent call removeChild, because the child calls parent()->removeChild() on itself in detach().
4:54 PM Changeset in webkit [11753] by mjs
  • 8 edits in trunk/WebKit

Reviewed by John.

  • move more frame tree traversal code from WebView to WebFrame
  • WebView.subproj/WebFrame.m: (-[WebFrame _atMostOneFrameHasSelection]): Moved this debug method from WebView, renamed it and changed it to return a boolean so it is appropriate for use in assertions instead of giving its own errors. (-[WebFrame _accumulateFramesWithSelection:]): Helper for the above. (-[WebFrame _findFrameWithSelection]): Moved from WebView and renamed from _findSelectedFrame, also removed the skipping variant. (-[WebFrame _clearSelectionInOtherFrames]): Moved from WebView and changed how the logic works. Instead of clearing selection in any frame but the focus frame, it clears selection in all but this one.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebPDFView.m: (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Stop getting WebFrame in needlessly roundabout way. (-[WebPDFView becomeFirstResponder]): Call _clearSelectionInOtherFrames
  • WebView.subproj/WebTextView.m: (-[WebTextView _webFrame]): New helper method. (-[WebTextView _elementAtWindowPoint:]): Use it. (-[WebTextView becomeFirstResponder]): Call _clearSelectionInOtherFrames (-[WebTextView resignFirstResponder]): Fix style issue (-[WebTextView clickedOnLink:atIndex:]): Use new helkper
  • WebView.subproj/WebView.m: (-[WebView selectedFrame]): Call to WebFrame as appropriate (-[WebView _selectedOrMainFrame]): Fix style issue
  • WebView.subproj/WebViewInternal.h:
3:04 PM Changeset in webkit [11752] by ggaren
  • 5 edits
    3 adds in trunk/WebCore

Reviewed by vicki (yay!), eric.

  • Fixed: <rdar://problem/4377597> parsing of window.open features strings needs to be more forgiving

Manual test case: WebCore/manual-tests/window-open-features-parsing.html
Also fixed: WebCore/manual-tests/window-open-features.html, which had an incorrect URL in it.

This patch is long. Luckily, it's also complicated.

The main thing I've done is to change our parsing of the window.open 'features' argument to match Win IE. This is important because we now implement the correct defaults for window.open, and resizing and scrolling are turned off by default. So, if we parse the 'features' string incorrectly, we'll end up with an annoying, incorrectly sized window that can't resize or scroll.

To honor a long-standing request by Eric, I factored out the parsing into two new functions: parseWindowFeatures and constrainToScreen. I also added support for "innerWidth" and "innerHeight," since they're just synonyms for "width" and "height."

  • khtml/ecma/kjs_window.cpp: removed "emit" statements, since emit is #defined as "" (KJS::parseDialogFeatures): renamed from parseFeatures, since we now have a 'parseWindowFeatures'. (KJS::showModalDialog): ditto on parseFeatures. Also added some missing initializations for WindowArgs data members. (KJS::parseWindowFeatures): new function, all new functionality. (KJS::constrainToScreen): new function, no new functionality -- just cut and pasted code that used to run as part of our parsing routine. (KJS::WindowFunc::callAsFunction): (1) Factored out previous parsing code. (2) Factored 17 lines of custom popup-blocking code into 3 lines that use pre-existing 'allowPopUp' function. Gratuitous, but it cried out to me. (3) Changed URL parsing to substitute "" for undefined *and* null values (we already did this for undefined), to avoid trying to navigate to '​http://null'. (4) Factore a multiline if () { if () {}} into an if ( && ) (4) Removed the main body of code from a giant 'else' block by inserting early returns for the exceptional cases. This caused some things to show up in the diff even though they're just whitespace changes. I didn't actually change any code past the line "if (!str.isEmpty() && activePart)"
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Added code to set toolbars to visible if toolBarVisible is true *or* locationBarVisible is true. The parser used to do this for us, but it's really the browser that's responsible for saying that the toolbar and the locationbar are the same thing. Hopefully, we can add a setLocationBarVisible delegate in the future so that other webkit clients can make their own UI decisions.
  • kwq/KWQKPartsBrowserExtension.h: Added locationBarVisible data member to WindowArgs structure and renamed toolBarsVisible to toolBarVisible (see above). Removed initialization code from WindowArgs structure because this file is for platform-specific code, and what defaults to use for window arguments is purely engine stuff.
10:44 AM Changeset in webkit [11751] by eseidel
  • 59 edits
    6 deletes in trunk/WebCore

Bug #: 6138
Submitted by: eseidel
Reviewed by: mjs

Remove many use of .qstring()
Convert several instances of QStrings to DOMStrings
Add DOMString::replace(QChar, QChar)
Remove (unused) KWQLabel, KWQKGlobal
Slight performance improvement.
Also fixed ChangeLog line endings from previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6138

No tests needed, no functionality changes.

  • ChangeLog: Fixed line endings
  • ForwardingHeaders/kglobal.h: Removed.
  • ForwardingHeaders/qlabel.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: removed KWQLabel
  • khtml/css/css_base.cpp: (CSSSelector::selectorText):
  • khtml/css/css_stylesheetimpl.cpp: (MediaListImpl::setMediaText):
  • khtml/css/cssstyleselector.cpp: (khtml::checkPseudoState):
  • khtml/dom/dom_string.h: (DOM::DOMString::replace):
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::put): (KJS::DOMAttr::put): (KJS::DOMDocument::put):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::put): (KJS::KJS::HTMLElementFunction::callAsFunction): (KJS::KJS::HTMLElement::put): (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::evaluate):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::execute):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.h:
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::queryCommandSupported):
  • khtml/editing/markup.cpp: (khtml::stringValueForRange): (khtml::startMarkup):
  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::addHTMLAlignment):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLInputElementImpl::appendFormData): (DOM::HTMLTextAreaElementImpl::updateValue):
  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::parseMappedAttribute):
  • khtml/html/html_imageimpl.cpp: (DOM::HTMLImageElementImpl::parseMappedAttribute):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLObjectElementImpl::parseMappedAttribute): (DOM::HTMLParamElementImpl::isURLAttribute):
  • khtml/html/html_objectimpl.h:
  • khtml/html/html_tableimpl.cpp: (DOM::HTMLTableElementImpl::addChild): (DOM::HTMLTableElementImpl::parseMappedAttribute): (DOM::HTMLTablePartElementImpl::parseMappedAttribute): (DOM::HTMLTableSectionElementImpl::addChild): (DOM::HTMLTableRowElementImpl::addChild):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/khtml_part.cpp: (KHTMLPart::executeScript): (KHTMLPart::checkEmitLoadEvent):
  • khtml/misc/loader.cpp: (CachedObject::finish): (CachedCSSStyleSheet::checkNotify): (CachedXSLStyleSheet::checkNotify): (CachedXBLDocument::checkNotify): (DocLoader::requestImage): (DocLoader::requestStyleSheet): (DocLoader::requestScript): (Loader::servePendingRequests): (Loader::cancelRequests):
  • khtml/rendering/render_applet.cpp:
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::updateFirstLetter):
  • khtml/rendering/render_box.cpp: (RenderBox::~RenderBox):
  • khtml/rendering/render_form.cpp: (RenderFormElement::slotTextChanged): (RenderLineEdit::updateFromElement): (RenderTextArea::updateFromElement): (RenderTextArea::text):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_frames.cpp: (RenderPartObject::updateWidget):
  • khtml/rendering/render_line.cpp: (khtml::EllipsisBox::paint):
  • khtml/rendering/render_list.cpp: (RenderListItem::paint): (RenderListMarker::paint):
  • khtml/rendering/render_text.cpp: (khtml::RenderText::RenderText): (khtml::RenderText::position):
  • khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature): (DocumentImpl::getElementByAccessKey): (DocumentImpl::recalcStyleSelector): (DocumentImpl::defaultEventHandler):
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::recalcStyle):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dump): (DOM::appendAttributeDesc): (DOM::NodeImpl::showNode):
  • khtml/xml/dom_stringimpl.cpp: (DOM::DOMStringImpl::lower):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::executeScripts):
  • khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::loadChildSheets):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentViewForNode): (KWQKHTMLPart::runJavaScriptAlert): (KWQKHTMLPart::runJavaScriptConfirm): (KWQKHTMLPart::runJavaScriptPrompt): (KWQKHTMLPart::addMessageToConsole): (KWQKHTMLPart::passWheelEventToChildWidget): (KWQKHTMLPart::shouldDragAutoNode): (KWQKHTMLPart::snapshotDragImage): (convertAttributesToUnderlines): (KWQKHTMLPart::setMarkedTextRange): (KWQKHTMLPart::mousePressNode):
  • kwq/KWQKGlobal.h: Removed.
  • kwq/KWQKGlobal.mm: Removed.
  • kwq/KWQLabel.h: Removed.
  • kwq/KWQLabel.mm: Removed.
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setAutoSaveName): (QLineEdit::setPlaceholderString):
  • kwq/KWQPainter.mm: (QPainter::compositeOperatorFromString):
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.mm: (KWQSignal::call):
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.mm: (KWQSlot::call):
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setText): (QTextEdit::text): (QTextEdit::textWithHardLineBreaks):
  • ksvg2/scripts/cssmakeprops: removed kglobal.h
  • ksvg2/scripts/cssmakevalues: removed kglobal.h
12:55 AM Changeset in webkit [11750] by ap
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp (KJS::XMLHttpRequest::slotFinished): Make sure to fetch response headers and set the state to Loaded, if this hasn't been done already.
12:50 AM Changeset in webkit [11749] by ap
  • 3 edits in trunk/WebCore

Reviewed by Eric Seidel.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send): Set application/xml as a default Content-Type; use a proper codec for request body if a charset is specified. (KJS::XMLHttpRequest::getRequestHeader): Use getSpecificHeader. (KJS::XMLHttpRequest::getResponseHeader): Ditto. (KJS::XMLHttpRequest::getSpecificHeader): Factored out code from getResponseHeader. (KJS::XMLHttpRequestProtoFunc::callAsFunction): Removed a FIXME (this is done in send() now).
  • khtml/ecma/xmlhttprequest.h:
12:35 AM Changeset in webkit [11748] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

ChangeLog entry for the previous checkin

12:34 AM Changeset in webkit [11747] by mjs
  • 2 edits in trunk/JavaScriptCore
  • this time for sure
  • kxmlcore/RefPtr.h: (KXMLCore::::swap):
12:28 AM Changeset in webkit [11746] by ap
  • 6 adds in trunk/LayoutTests/fast/encoding

Reviewed by Darin Adler.

  • fast/encoding/frame-default-enc-expected.checksum: Added.
  • fast/encoding/frame-default-enc-expected.png: Added.
  • fast/encoding/frame-default-enc-expected.txt: Added.
  • fast/encoding/frame-default-enc.html: Added.
  • fast/encoding/resources/frame-default-enc-frame.html: Added.
12:19 AM Changeset in webkit [11745] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Eric.

  • move a few more methods from WebView to WebFrame.
  • WebView.subproj/WebFrame.m: (-[WebFrame _hasSelection]): Renamed from _frameIsSelected: and moved from WebView. (-[WebFrame _clearSelection]): Renamed from _deselectFrame: and moved from WebView.
  • WebView.subproj/WebFrameInternal.h:
  • WebView.subproj/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): Update for renames. (-[WebView _findSelectedFrameStartingFromFrame:skippingFrame:]): Ditto. (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]): Ditto. (-[WebView _selectedFrameDidChange]):
12:05 AM Changeset in webkit [11744] by justing
  • 1 edit
    2 adds
    2 deletes in trunk/LayoutTests

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6211>
fast/text/attributed-substring-from-range-lines needs LayoutTests/editing/editing.js

  • editing/input/attributed-substring-from-range-lines-expected.txt: Added.
  • editing/input/attributed-substring-from-range-lines.html: Added.
  • fast/text/attributed-substring-from-range-lines-expected.txt: Removed.
  • fast/text/attributed-substring-from-range-lines.html: Removed.
12:02 AM Changeset in webkit [11743] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Eric.

  • updated for WebCore changes to make XSLT params partially work
  • fast/xsl/xslt-processer-expected.txt:
Note: See TracTimeline for information about the timeline view.