Context Navigation

WebCoreSupport.subproj/WebBridge.h:
WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly asking for parent via WebFrame (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more because WebFame's _detachFromParent takes care of that now.
WebView.subproj/WebFrame.m: (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they can remove themselves. (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge until we are done with it. (-[WebFrame _transitionToCommitted:]): Remove some extra braces. (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent field directly. (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private since it is not there any more. (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer explicitly any more. (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field. (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces. (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the coding style. (-[WebFrame _previousFrameWithWrap:]): Ditto. (-[WebFrame parentFrame]): Get parent from the bridge.

12:06 AM Changeset in webkit [11766] by mjs

2 edits in trunk/WebKit

Reviewed by Hyatt.

fixed REGRESSION: world leak of WebDataSource http://bugzilla.opendarwin.org/show_bug.cgi?id=6242

WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): don't retain self until after the possible early return.

Dec 25, 2005:

10:28 AM Changeset in webkit [11765] by ggaren

1 edit in trunk/WebCore/ChangeLog

ChangeLog fixup

3:05 AM Changeset in webkit [11764] by mjs

5 edits in trunk/WebKit

Reviewed by Geoff.

rearrange some code in WebDataSource so that more of the frame traversal logic is in WebFrame, in preparation for moving it down to WebBridge. http://bugzilla.opendarwin.org/show_bug.cgi?id=6239

WebView.subproj/WebDataSource.m: (-[WebDataSource _archiveWithMarkupString:nodes:]): Assert that the data source is committed, doesn't make sense to archive otherwise. (-[WebDataSource _subframeArchivesWithCurrentState:]): New helper method. (-[WebDataSource _archiveWithCurrentState:]): Assert that the data source is committed. Use the helper. (-[WebDataSource _setWebView:]): Comment that we won't tell subframes that defers callback changed. (-[WebDataSource _startLoading]): Remove stray space. (-[WebDataSource _stopLoading]): Only handle local _stopLoading business. Cound on WebFrame to tell subframes to stop loading. Fold in _stopLoadingInternal and remove _recursiveStopLoading. (-[WebDataSource _startLoading:]): Clean up an assert slightly. (-[WebDataSource _setTitle:]): Remove stray spaces. (-[WebDataSource _defersCallbacksChanged]): Don't call subframes. WebFrame can do that. (-[WebDataSource isLoading]): Move checking of subframes down to WebFrame. (-[WebDataSource webArchive]): Return nil if the data source is not yet committed. It makes no sense to archive a provisional data source since it has no data yet. (-[WebDataSource addSubresource:]): Replace an assert with an early return, ASSERT is not an appropriate way to flag problems with the argument of a public method.
WebView.subproj/WebDataSourcePrivate.h:
WebView.subproj/WebFrame.m: (-[WebFrame _setLoadType:]): Remove stray space. (-[WebFrame _checkLoadCompleteForThisFrame]): Stop loading subframes manually and add a FIXME about confusingness of stopping loading here. (-[WebFrame _defersCallbacksChanged]): Tell our subframes. (-[WebFrame _addChild:]): Remove stray space. (-[WebFrame _stopLoadingSubframes]): New helper method. (-[WebFrame _subframeIsLoading]): New helper method, code moved from WebDataSource. (-[WebFrame stopLoading]): Tell subframes to stop loading. (-[WebFrame reload]): Remove extra braces.
WebView.subproj/WebFrameInternal.h:

1:22 AM Changeset in webkit [11763] by mjs

7 edits in trunk/JavaScriptCore

Reviewed by Eric and Dave Hyatt.

make even const PassRefPtrs give transfer of ownership semantics http://bugzilla.opendarwin.org/show_bug.cgi?id=6238

This is a somewhat cheesy change. Having to use PassRefPtr_Ref creates ambiguities
in assignment and copy construction. And this makes life way easier and removes
the need for pass(). It is not really correct, but we pretty much never need a real
const PassRefPtr, and this takes care of things for PassRefPtr temporaries.

kjs/identifier.cpp: (KJS::Identifier::add): No more need for pass()
kjs/property_map.cpp: (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): No more need for pass()
kjs/ustring.cpp: (KJS::UString::Rep::create): Use adoptRef (KJS::UString::UString): No more need for pass (KJS::UString::append): No more need for pass (KJS::UString::substr): No more need for pass
kxmlcore/PassRefPtr.h: made m_ptr mutable (ugh) (KXMLCore::PassRefPtr::PassRefPtr): Take a const PassRefPtr reference (KXMLCore::PassRefPtr::release): Made this a const method (ugh) (KXMLCore::PassRefPtr::operator=): clean up appropriately (KXMLCore::adoptRef): Added this to use instead of PassRefPtr<T>::adopt, I think it makes the behavior more clear and it is less verbose. (KXMLCore::static_pointer_cast): use adoptRef (KXMLCore::const_pointer_cast): use adoptRef
kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): take const PassRefPtr& (KXMLCore::PassRefPtr::operator=): take const PassRefPtr&

12:11 AM Changeset in webkit [11762] by eseidel

2 edits in trunk/JavaScriptCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Unbreak HashTableConstIterator++ by returning const_iterator

kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator++): use const_iterator

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed