⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 27, 2005:

7:47 PM Changeset in webkit [11787] by mjs
  • 3 edits in trunk/LayoutTests

Rubber stamped by Eric.

  • proper length for Array concat function is 1, not 0; also add test for String concat.
  • fast/js/kde/function_length-expected.txt:
  • fast/js/kde/resources/function_length.js:
12:06 PM Changeset in webkit [11786] by andersca
  • 5 edits in trunk/LayoutTests

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fast/js/array-every-expected.txt:
  • fast/js/array-every.html:
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Modify these tests since Array.every and Array.foreach now follow Mozilla and treat arrays as sparse, not visiting non-existing properties.
12:02 PM Changeset in webkit [11785] by andersca
  • 4 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement filter and map. Also, make the existing array iteration functions not invoke the callback for non-existing properties, just as Mozilla does now.
  • kjs/array_object.h: (KJS::ArrayProtoFunc::): Add filter and map.
  • tests/mozilla/expected.html: Update, two 1.6 tests now pass.
11:13 AM Changeset in webkit [11784] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Hyatt, landed by Darin.

  • khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the size changed and not everything was repainted.
  • manual-tests/bugzilla-5699.html: Added.
11:06 AM Changeset in webkit [11783] by darin
  • 25 edits in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/text/international/bidi-AN-after-L-expected.checksum: Updated.
  • fast/text/international/bidi-AN-after-L-expected.png: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.checksum: Updated.
  • fast/text/international/bidi-L2-run-reordering-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-CSS-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-HTML-expected.png: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Updated.
  • fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
  • fast/text/international/bidi-explicit-embedding-expected.png: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
  • fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Updated.
  • fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Updated.
  • fast/text/international/bidi-innertext-expected.checksum: Updated.
  • fast/text/international/bidi-innertext-expected.png: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.checksum: Updated.
  • fast/text/international/bidi-layout-across-linebreak-expected.png: Updated.
  • fast/text/international/bidi-override-expected.checksum: Updated.
  • fast/text/international/bidi-override-expected.png: Updated.

WebKit:

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.
10:39 AM Changeset in webkit [11782] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

  • fast/replaced/absolute-image-sizing-expected.checksum: Added.
  • fast/replaced/absolute-image-sizing-expected.png: Added.
  • fast/replaced/absolute-image-sizing-expected.txt: Added.
  • fast/replaced/absolute-image-sizing.html: Added.

WebCore:

Reviewed by Maciej, landed by Darin.

Added layout tests:

  • fast/replaced/absolute-image-sizing.html
  • khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth() for replaced elements. (RenderBox::calcAbsoluteVerticalValues): Same thing for height.
10:26 AM Changeset in webkit [11781] by darin
  • 8 edits in trunk/WebCore

Reviewed by Geoff and Eric.

  • khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token. Also removed use of bitfields in Token, since there's no need to optimize storage here.
  • khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Update for use of RefPtr in Token. (HTMLParser::textCreateErrorCheck): Ditto. (HTMLParser::commentCreateErrorCheck): Ditto. (HTMLParser::handleIsindex): Ditto.
  • khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): Ditto. (khtml::HTMLTokenizer::processToken): Ditto.
  • khtml/rendering/render_text.h: Reduce the number of includes, change SOFT_HYPHEN from a macro into a constant. Change originalString function to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr member be a RefPtr.
  • khtml/rendering/render_text.cpp: (khtml::RenderText::previousOffset): Update for use of RefPtr for str. (khtml::RenderText::nextOffset): Ditto. (khtml::RenderText::RenderText): Ditto. (khtml::RenderText::originalString): Change to return PassRefPtr, even though it's not necessary at this level (since it's a virtual function). (khtml::RenderText::posOfChar): Update for use of RefPtr for str. (khtml::RenderText::setText): Ditto. (khtml::RenderTextFragment::RenderTextFragment): Ditto. (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.
  • khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
  • kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer included by render_text.h.
10:05 AM Changeset in webkit [11780] by darin
  • 2 edits in trunk/WebCore

Fix suggested by Mitz.

  • khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions): Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part of my fix for clientX/Y in the original patch.
4:56 AM Changeset in webkit [11779] by mjs
  • 2 edits in trunk/JavaScriptCore
  • updated test results for new JS 1.6 tests
  • tests/mozilla/expected.html:
4:29 AM Changeset in webkit [11778] by andersca
  • 1 edit
    27 adds in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

Add Mozilla JS 1.6 tests.

  • tests/mozilla/js1_6/Array/browser.js: Added.
  • tests/mozilla/js1_6/Array/regress-290592.js: Added.
  • tests/mozilla/js1_6/Array/regress-304828.js: Added.
  • tests/mozilla/js1_6/Array/regress-305002.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-01.js: Added.
  • tests/mozilla/js1_6/Array/regress-310425-02.js: Added.
  • tests/mozilla/js1_6/Array/regress-320887.js: Added.
  • tests/mozilla/js1_6/Array/shell.js: Added.
  • tests/mozilla/js1_6/README: Added.
  • tests/mozilla/js1_6/Regress/browser.js: Added.
  • tests/mozilla/js1_6/Regress/regress-301574.js: Added.
  • tests/mozilla/js1_6/Regress/regress-309242.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-01.js: Added.
  • tests/mozilla/js1_6/Regress/regress-311157-02.js: Added.
  • tests/mozilla/js1_6/Regress/regress-314887.js: Added.
  • tests/mozilla/js1_6/Regress/regress-320172.js: Added.
  • tests/mozilla/js1_6/Regress/shell.js: Added.
  • tests/mozilla/js1_6/String/browser.js: Added.
  • tests/mozilla/js1_6/String/regress-306591.js: Added.
  • tests/mozilla/js1_6/String/shell.js: Added.
  • tests/mozilla/js1_6/browser.js: Added.
  • tests/mozilla/js1_6/shell.js: Added.
  • tests/mozilla/js1_6/template.js: Added.
4:24 AM Changeset in webkit [11777] by mjs
  • 6 edits in trunk/LayoutTests

No review, just a test harness change.

  • avoid bombing out if a shouldBe test case unexpectedly throws an exception
  • fast/js/kde/resources/base.js:
  • this lets some of the tests get a bit further, so new results:
  • fast/js/kde/Number-expected.txt:
  • fast/js/kde/RegExp-expected.txt:
  • fast/js/kde/exception_propagation-expected.txt:
  • fast/js/kde/parse-expected.txt:
4:05 AM Changeset in webkit [11776] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/forms/button-in-forms-collection-expected.txt: Added.
  • fast/forms/button-in-forms-collection.html: Added.

WebCore:

Reviewed and landed by Maciej.

Test: fast/forms/button-in-forms-collection.html

  • khtml/html/html_formimpl.h: (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true
3:07 AM Changeset in webkit [11775] by mjs
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed and landed by Maciej.

  • kjs/array_object.cpp: (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when looking for array properties.

LayoutTests:

Reviewed, tweaked and landed by Maciej.

  • fast/js/array-float-delete.html: Added.
2:35 AM Changeset in webkit [11774] by andersca
  • 2 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • kjs/object.cpp: (KJS::JSObject::defineSetter): Remove duplicate call to putDirect.
1:24 AM Changeset in webkit [11773] by mjs
  • 7 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

Changes by me and Anders.

  • also fixed some warnings reported by -Winline
  • JavaScriptCorePrefix.h: Move new and delete definitions higher so there aren't conflicts with use in standard C++ headers
  • kjs/object.cpp: (KJS::throwSetterError): Moved this piece of put into a seprate function to avoid the PIC branch. (KJS::JSObject::put): Use hasGetterSetterProperties to avoid expensive stuff when not needed. Also use GetterSetter properties attribute. (KJS::JSObject::deleteProperty): Recompute whether any properties are getter/setter properties any more, if this one was one. (KJS::JSObject::defineGetter): Let the PropertyMap know that it has getter/setter properties now (and use the new attribute). (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::fillGetterPropertySlot): Out-of-line helper for getOwnPropertySlot, to avoid global variable access in the hot code path.
  • kjs/object.h: (KJS::): Added GetterSetter attribute. (KJS::JSCell::isObject): Moved lower to be after inline methods it uses. (KJS::JSValue::isObject): ditto (KJS::JSObject::getOwnPropertySlot): try to avoid impact of getters and setters as much as possible in the case where they are not being used
  • kjs/property_map.cpp: (KJS::PropertyMap::containsGettersOrSetters): New method to help with this
  • kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): Ditto (KJS::PropertyMap::setHasGetterSetterProperties): Ditto (KJS::PropertyMap::PropertyMap): Added a crazy hack to store the global "has getter/setter properties" flag in the property map single entry, to avoid making objects any bigger.
  • kjs/value.h: Moved some things to object.h to make -Winline happier

Dec 26, 2005:

3:33 PM Changeset in webkit [11772] by hyatt
  • 5 adds in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in the beginnings of a VC 2005 project for JSCore dll.

3:07 PM Changeset in webkit [11771] by mjs
  • 1 edit
    162 adds in trunk/LayoutTests

Rubber stamped by Geoff.

  • land JavaScript tests from the kde version of kjs
  • fast/js/kde/Array-expected.txt: Added.
  • fast/js/kde/Array.html: Added.
  • fast/js/kde/Boolean-expected.txt: Added.
  • fast/js/kde/Boolean.html: Added.
  • fast/js/kde/Date-expected.txt: Added.
  • fast/js/kde/Date.html: Added.
  • fast/js/kde/Error-expected.txt: Added.
  • fast/js/kde/Error.html: Added.
  • fast/js/kde/GlobalObject-expected.txt: Added.
  • fast/js/kde/GlobalObject.html: Added.
  • fast/js/kde/Number-expected.txt: Added.
  • fast/js/kde/Number.html: Added.
  • fast/js/kde/Object-expected.txt: Added.
  • fast/js/kde/Object.html: Added.
  • fast/js/kde/Prototype-expected.txt: Added.
  • fast/js/kde/Prototype.html: Added.
  • fast/js/kde/RegExp-expected.txt: Added.
  • fast/js/kde/RegExp.html: Added.
  • fast/js/kde/StringObject-expected.txt: Added.
  • fast/js/kde/StringObject.html: Added.
  • fast/js/kde/assignments-expected.txt: Added.
  • fast/js/kde/assignments.html: Added.
  • fast/js/kde/cast-expected.txt: Added.
  • fast/js/kde/cast.html: Added.
  • fast/js/kde/comment-1-expected.txt: Added.
  • fast/js/kde/comment-1.html: Added.
  • fast/js/kde/comment-2-expected.txt: Added.
  • fast/js/kde/comment-2.html: Added.
  • fast/js/kde/completion-expected.txt: Added.
  • fast/js/kde/completion.html: Added.
  • fast/js/kde/conditional-expected.txt: Added.
  • fast/js/kde/conditional.html: Added.
  • fast/js/kde/const-expected.txt: Added.
  • fast/js/kde/const.html: Added.
  • fast/js/kde/constructor_length-expected.txt: Added.
  • fast/js/kde/constructor_length.html: Added.
  • fast/js/kde/crash-1-expected.txt: Added.
  • fast/js/kde/crash-1.html: Added.
  • fast/js/kde/crash-2-expected.txt: Added.
  • fast/js/kde/crash-2.html: Added.
  • fast/js/kde/delete-expected.txt: Added.
  • fast/js/kde/delete.html: Added.
  • fast/js/kde/empty-expected.txt: Added.
  • fast/js/kde/empty.html: Added.
  • fast/js/kde/encode_decode_uri-expected.txt: Added.
  • fast/js/kde/encode_decode_uri.html: Added.
  • fast/js/kde/eval-expected.txt: Added.
  • fast/js/kde/eval.html: Added.
  • fast/js/kde/evil-n-expected.txt: Added.
  • fast/js/kde/evil-n.html: Added.
  • fast/js/kde/exception_propagation-expected.txt: Added.
  • fast/js/kde/exception_propagation.html: Added.
  • fast/js/kde/exceptions-expected.txt: Added.
  • fast/js/kde/exceptions.html: Added.
  • fast/js/kde/function-expected.txt: Added.
  • fast/js/kde/function.html: Added.
  • fast/js/kde/function_arguments-expected.txt: Added.
  • fast/js/kde/function_arguments.html: Added.
  • fast/js/kde/function_constructor-expected.txt: Added.
  • fast/js/kde/function_constructor.html: Added.
  • fast/js/kde/function_length-expected.txt: Added.
  • fast/js/kde/function_length.html: Added.
  • fast/js/kde/garbage-n-expected.txt: Added.
  • fast/js/kde/garbage-n.html: Added.
  • fast/js/kde/inbuilt_function_proto-expected.txt: Added.
  • fast/js/kde/inbuilt_function_proto.html: Added.
  • fast/js/kde/inbuilt_function_tostring-expected.txt: Added.
  • fast/js/kde/inbuilt_function_tostring.html: Added.
  • fast/js/kde/iteration-expected.txt: Added.
  • fast/js/kde/iteration.html: Added.
  • fast/js/kde/j-comment-3-expected.txt: Added.
  • fast/js/kde/j-comment-3.html: Added.
  • fast/js/kde/j-comment-4-expected.txt: Added.
  • fast/js/kde/j-comment-4.html: Added.
  • fast/js/kde/literals-expected.txt: Added.
  • fast/js/kde/literals.html: Added.
  • fast/js/kde/math-expected.txt: Added.
  • fast/js/kde/math.html: Added.
  • fast/js/kde/md5-1-expected.txt: Added.
  • fast/js/kde/md5-1.html: Added.
  • fast/js/kde/md5-2-expected.txt: Added.
  • fast/js/kde/md5-2.html: Added.
  • fast/js/kde/object_prototype-expected.txt: Added.
  • fast/js/kde/object_prototype.html: Added.
  • fast/js/kde/object_prototype_tostring-expected.txt: Added.
  • fast/js/kde/object_prototype_tostring.html: Added.
  • fast/js/kde/operators-expected.txt: Added.
  • fast/js/kde/operators.html: Added.
  • fast/js/kde/parse-expected.txt: Added.
  • fast/js/kde/parse.html: Added.
  • fast/js/kde/prototype_length-expected.txt: Added.
  • fast/js/kde/prototype_length.html: Added.
  • fast/js/kde/prototype_proto-expected.txt: Added.
  • fast/js/kde/prototype_proto.html: Added.
  • fast/js/kde/resources/Array.js: Added.
  • fast/js/kde/resources/Boolean.js: Added.
  • fast/js/kde/resources/Date.js: Added.
  • fast/js/kde/resources/Error.js: Added.
  • fast/js/kde/resources/GlobalObject.js: Added.
  • fast/js/kde/resources/KNOWN_FAILURES: Added.
  • fast/js/kde/resources/Number.js: Added.
  • fast/js/kde/resources/Object.js: Added.
  • fast/js/kde/resources/Prototype.js: Added.
  • fast/js/kde/resources/README: Added.
  • fast/js/kde/resources/RegExp.js: Added.
  • fast/js/kde/resources/StringObject.js: Added.
  • fast/js/kde/resources/assignments.js: Added.
  • fast/js/kde/resources/base.js: Added.
  • fast/js/kde/resources/cast.js: Added.
  • fast/js/kde/resources/comment-1.js: Added.
  • fast/js/kde/resources/comment-2.js: Added.
  • fast/js/kde/resources/completion.js: Added.
  • fast/js/kde/resources/conditional.js: Added.
  • fast/js/kde/resources/const.js: Added.
  • fast/js/kde/resources/constructor_length.js: Added.
  • fast/js/kde/resources/crash-1.js: Added.
  • fast/js/kde/resources/crash-2.js: Added.
  • fast/js/kde/resources/delete.js: Added.
  • fast/js/kde/resources/empty.js: Added.
  • fast/js/kde/resources/encode_decode_uri.js: Added.
  • fast/js/kde/resources/eval.js: Added.
  • fast/js/kde/resources/evil-n.js: Added.
  • fast/js/kde/resources/exception_propagation.js: Added.
  • fast/js/kde/resources/exceptions.js: Added.
  • fast/js/kde/resources/function.js: Added.
  • fast/js/kde/resources/function_arguments.js: Added.
  • fast/js/kde/resources/function_constructor.js: Added.
  • fast/js/kde/resources/function_length.js: Added.
  • fast/js/kde/resources/garbage-n.js: Added.
  • fast/js/kde/resources/inbuilt_function_proto.js: Added.
  • fast/js/kde/resources/inbuilt_function_tostring.js: Added.
  • fast/js/kde/resources/iteration.js: Added.
  • fast/js/kde/resources/j-comment-3.js: Added.
  • fast/js/kde/resources/j-comment-4.js: Added.
  • fast/js/kde/resources/literals.js: Added.
  • fast/js/kde/resources/math.js: Added.
  • fast/js/kde/resources/md5-1.js: Added.
  • fast/js/kde/resources/md5-2.js: Added.
  • fast/js/kde/resources/object_prototype.js: Added.
  • fast/js/kde/resources/object_prototype_tostring.js: Added.
  • fast/js/kde/resources/operators.js: Added.
  • fast/js/kde/resources/parse.js: Added.
  • fast/js/kde/resources/prototype_length.js: Added.
  • fast/js/kde/resources/prototype_proto.js: Added.
  • fast/js/kde/resources/scope.js: Added.
  • fast/js/kde/resources/shell.js: Added.
  • fast/js/kde/resources/statements.js: Added.
  • fast/js/kde/resources/string-1-n.js: Added.
  • fast/js/kde/resources/string-2-n.js: Added.
  • fast/js/kde/resources/var_decl_init.js: Added.
  • fast/js/kde/scope-expected.txt: Added.
  • fast/js/kde/scope.html: Added.
  • fast/js/kde/statements-expected.txt: Added.
  • fast/js/kde/statements.html: Added.
  • fast/js/kde/string-1-n-expected.txt: Added.
  • fast/js/kde/string-1-n.html: Added.
  • fast/js/kde/string-2-n-expected.txt: Added.
  • fast/js/kde/string-2-n.html: Added.
  • fast/js/kde/var_decl_init-expected.txt: Added.
  • fast/js/kde/var_decl_init.html: Added.
2:47 PM Changeset in webkit [11770] by hyatt
  • 1 edit in trunk/JavaScriptCore/Makefile.vc

Undo my accidental commit of Makefile.vc

2:23 PM Changeset in webkit [11769] by hyatt
  • 2 edits in trunk/JavaScriptCore/kjs

Make sure assert.h is included by including it in config.h

2:08 PM Changeset in webkit [11768] by hyatt
  • 2 edits in trunk/JavaScriptCore

Fix win32 bustage. ifdef the swap function for std pairs.

1:46 PM Changeset in webkit [11767] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Geoff.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge parent]): New method, relies on the KHTMLPart's parent pointer.

WebKit:

Reviewed by Geoff

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canTargetLoadInFrame:]): Use bridge parent method instead of needlessly asking for parent via WebFrame (-[WebBridge frameDetached]): Don't call _removeChild on the parent frame any more because WebFame's _detachFromParent takes care of that now.
  • WebView.subproj/WebFrame.m: (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Fix stray spaces (-[WebFrame _detachChildren]): Don't remove children as we loop any more, they can remove themselves. (-[WebFrame _detachFromParent]): Remove self from parent; don't nil out bridge until we are done with it. (-[WebFrame _transitionToCommitted:]): Remove some extra braces. (-[WebFrame _goToItem:withLoadType:]): Use parentFrame method in assert instead of parent field directly. (-[WebFrame _addChild:]): Don't poke at parent frame pointer in _private since it is not there any more. (-[WebFrame _removeChild:]): Remove extra braces and don't clear parent pointer explicitly any more. (-[WebFrame _addFramePathToString:]): Get parentFrame from method, not field. (-[WebFrame _loadDataSource:withLoadType:formState:]): Remove extra braces. (-[WebFrame _nextFrameWithWrap:]): Get parent in the proper way and clean up the coding style. (-[WebFrame _previousFrameWithWrap:]): Ditto. (-[WebFrame parentFrame]): Get parent from the bridge.
12:06 AM Changeset in webkit [11766] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): don't retain self until after the possible early return.
Note: See TracTimeline for information about the timeline view.