Context Navigation

khtml/html/html_headimpl.cpp: (HTMLScriptElementImpl::parseMappedAttribute): Parse the onload and onerror attributes. (HTMLScriptElementImpl::closeRenderer): Call base class's implementation. (HTMLScriptElementImpl::notifyFinished): Dispatch load and error events.
khtml/html/htmlparser.h:
khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Return the node that was inserted.
khtml/html/htmltokenizer.h: Added scriptNode, a RefPtr to the node corresponding to the current load request.
khtml/html/htmltokenizer.cpp: (HTMLTokenizer::scriptHandler): Reset scriptNode if a load request was not made. (HTMLTokenizer::parseTag): Set scriptNode to the node created from the script tag. (HTMLTokenizer::processToken): Return the node that was inserted. (HTMLTokenizer::notifyFinished): Reset scriptNode and dispatch load and error events.
khtml/misc/loader.h: (CachedScript::errorOccurred): Added.
khtml/misc/loader.cpp: (CachedScript::CachedScript): (CachedScript::error):

10:23 AM Changeset in webkit [11790] by ap

1 edit
2 adds in trunk/LayoutTests

Reviewed by Maciej.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6246 TextIterator::rangeFromLocationAndLength() returns nil range for an empty document

editing/input/range-for-empty-document-expected.txt: Added.
editing/input/range-for-empty-document.html: Added.

10:21 AM Changeset in webkit [11789] by ap

2 edits in trunk/WebCore

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6246 TextIterator::rangeFromLocationAndLength() returns nil range for an empty document

Test: editing/input/range-for-empty-document.html

khtml/editing/visible_text.cpp: (khtml::TextIterator::rangeFromLocationAndLength): Handle the case of an empty document and (0, 0) requested range.

10:18 AM Changeset in webkit [11788] by ggaren

2 edits in trunk/WebCore

Reviewed and landed by Geoff.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6269 ToT memory corruption

khtml/rendering/render_text.cpp: (khtml::RenderText::setText): Remove deref().

Dec 27, 2005:

7:47 PM Changeset in webkit [11787] by mjs

3 edits in trunk/LayoutTests

Rubber stamped by Eric.

proper length for Array concat function is 1, not 0; also add test for String concat.

fast/js/kde/function_length-expected.txt:
fast/js/kde/resources/function_length.js:

12:06 PM Changeset in webkit [11786] by andersca

5 edits in trunk/LayoutTests

2005-12-27 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

Update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6250 Implement Array.map and Array.filter

fast/js/array-every-expected.txt:
fast/js/array-every.html:
fast/js/array-foreach-expected.txt:
fast/js/array-foreach.html: Modify these tests since Array.every and Array.foreach now follow Mozilla and treat arrays as sparse, not visiting non-existing properties.

12:02 PM Changeset in webkit [11785] by andersca

4 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Implement filter and map. Also, make the existing array iteration functions not invoke the callback for non-existing properties, just as Mozilla does now.

kjs/array_object.h: (KJS::ArrayProtoFunc::): Add filter and map.

tests/mozilla/expected.html: Update, two 1.6 tests now pass.

11:13 AM Changeset in webkit [11784] by darin

2 edits
1 add in trunk/WebCore

Reviewed by Hyatt, landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5699 REGRESSION: incomplete repaint

khtml/rendering/render_object.cpp: (RenderObject::repaintAfterLayoutIfNeeded): Return false if only the size changed and not everything was repainted.
manual-tests/bugzilla-5699.html: Added.

11:06 AM Changeset in webkit [11783] by darin

25 edits in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4844 Render "simple" Hebrew using the CG codepath

fast/text/international/bidi-AN-after-L-expected.checksum: Updated.
fast/text/international/bidi-AN-after-L-expected.png: Updated.
fast/text/international/bidi-L2-run-reordering-expected.checksum: Updated.
fast/text/international/bidi-L2-run-reordering-expected.png: Updated.
fast/text/international/bidi-LDB-2-CSS-expected.checksum: Updated.
fast/text/international/bidi-LDB-2-CSS-expected.png: Updated.
fast/text/international/bidi-LDB-2-HTML-expected.checksum: Updated.
fast/text/international/bidi-LDB-2-HTML-expected.png: Updated.
fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Updated.
fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Updated.
fast/text/international/bidi-explicit-embedding-expected.checksum: Updated.
fast/text/international/bidi-explicit-embedding-expected.png: Updated.
fast/text/international/bidi-fallback-font-weight-expected.checksum: Updated.
fast/text/international/bidi-fallback-font-weight-expected.png: Updated.
fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Updated.
fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Updated.
fast/text/international/bidi-innertext-expected.checksum: Updated.
fast/text/international/bidi-innertext-expected.png: Updated.
fast/text/international/bidi-layout-across-linebreak-expected.checksum: Updated.
fast/text/international/bidi-layout-across-linebreak-expected.png: Updated.
fast/text/international/bidi-override-expected.checksum: Updated.
fast/text/international/bidi-override-expected.png: Updated.

WebKit:

Reviewed by Maciej, landed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4844 Render "simple" Hebrew using the CG codepath

WebCoreSupport.subproj/WebTextRenderer.m: (shouldUseATSU): Exclude Hebrew letters and maqaf.

10:39 AM Changeset in webkit [11782] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej, landed by Darin.

fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4101> CSS Fibonacci spiral using 4 images doesn't render correctly

fast/replaced/absolute-image-sizing-expected.checksum: Added.
fast/replaced/absolute-image-sizing-expected.png: Added.
fast/replaced/absolute-image-sizing-expected.txt: Added.
fast/replaced/absolute-image-sizing.html: Added.

WebCore:

Reviewed by Maciej, landed by Darin.

fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4101> CSS Fibonacci spiral using 4 images doesn't render correctly

Added layout tests:

fast/replaced/absolute-image-sizing.html

khtml/rendering/render_box.cpp: (RenderBox::calcAbsoluteHorizontalValues): Use calcReplacedWidth() instead of intrinsicWidth() for replaced elements. (RenderBox::calcAbsoluteVerticalValues): Same thing for height.

10:26 AM Changeset in webkit [11781] by darin

8 edits in trunk/WebCore

Reviewed by Geoff and Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6198 use RefPtr a few places in RenderText and related classes

khtml/html/htmltokenizer.h: Use RefPtr for some data members in Token. Also removed use of bitfields in Token, since there's no need to optimize storage here.
khtml/html/htmlparser.cpp: (HTMLParser::parseToken): Update for use of RefPtr in Token. (HTMLParser::textCreateErrorCheck): Ditto. (HTMLParser::commentCreateErrorCheck): Ditto. (HTMLParser::handleIsindex): Ditto.
khtml/html/htmltokenizer.cpp: (khtml::Token::addAttribute): Ditto. (khtml::HTMLTokenizer::processToken): Ditto.

khtml/rendering/render_text.h: Reduce the number of includes, change SOFT_HYPHEN from a macro into a constant. Change originalString function to return a PassRefPtr instead of a RefPtr. Make str and m_generatedContentStr member be a RefPtr.
khtml/rendering/render_text.cpp: (khtml::RenderText::previousOffset): Update for use of RefPtr for str. (khtml::RenderText::nextOffset): Ditto. (khtml::RenderText::RenderText): Ditto. (khtml::RenderText::originalString): Change to return PassRefPtr, even though it's not necessary at this level (since it's a virtual function). (khtml::RenderText::posOfChar): Update for use of RefPtr for str. (khtml::RenderText::setText): Ditto. (khtml::RenderTextFragment::RenderTextFragment): Ditto. (khtml::RenderTextFragment::originalString): Change to return PassRefPtr.

khtml/html/html_inlineimpl.cpp: Re-sorted list of includes, added newly-needed ones.
kwq/KWQRenderTreeDebug.cpp: Added new include needed since QPtrVector is no longer included by render_text.h.

10:05 AM Changeset in webkit [11780] by darin

2 edits in trunk/WebCore

Fix suggested by Mitz.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6240 REGRESSION: scrollbars in overflows don't work

khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::computePositions): Remove the code to compute pageX/Y from clientX/Y, because clientX/Y are not passed in correctly (in fact, what's passed in is pageX/Y)! I accidentally included part of my fix for clientX/Y in the original patch.

4:56 AM Changeset in webkit [11779] by mjs

2 edits in trunk/JavaScriptCore

updated test results for new JS 1.6 tests

tests/mozilla/expected.html:

4:29 AM Changeset in webkit [11778] by andersca

1 edit
27 adds in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

Add Mozilla JS 1.6 tests.

tests/mozilla/js1_6/Array/browser.js: Added.
tests/mozilla/js1_6/Array/regress-290592.js: Added.
tests/mozilla/js1_6/Array/regress-304828.js: Added.
tests/mozilla/js1_6/Array/regress-305002.js: Added.
tests/mozilla/js1_6/Array/regress-310425-01.js: Added.
tests/mozilla/js1_6/Array/regress-310425-02.js: Added.
tests/mozilla/js1_6/Array/regress-320887.js: Added.
tests/mozilla/js1_6/Array/shell.js: Added.
tests/mozilla/js1_6/README: Added.
tests/mozilla/js1_6/Regress/browser.js: Added.
tests/mozilla/js1_6/Regress/regress-301574.js: Added.
tests/mozilla/js1_6/Regress/regress-309242.js: Added.
tests/mozilla/js1_6/Regress/regress-311157-01.js: Added.
tests/mozilla/js1_6/Regress/regress-311157-02.js: Added.
tests/mozilla/js1_6/Regress/regress-314887.js: Added.
tests/mozilla/js1_6/Regress/regress-320172.js: Added.
tests/mozilla/js1_6/Regress/shell.js: Added.
tests/mozilla/js1_6/String/browser.js: Added.
tests/mozilla/js1_6/String/regress-306591.js: Added.
tests/mozilla/js1_6/String/shell.js: Added.
tests/mozilla/js1_6/browser.js: Added.
tests/mozilla/js1_6/shell.js: Added.
tests/mozilla/js1_6/template.js: Added.

4:24 AM Changeset in webkit [11777] by mjs

6 edits in trunk/LayoutTests

No review, just a test harness change.

avoid bombing out if a shouldBe test case unexpectedly throws an exception

fast/js/kde/resources/base.js:

this lets some of the tests get a bit further, so new results:

fast/js/kde/Number-expected.txt:
fast/js/kde/RegExp-expected.txt:
fast/js/kde/exception_propagation-expected.txt:
fast/js/kde/parse-expected.txt:

4:05 AM Changeset in webkit [11776] by mjs

3 edits
2 adds in trunk

LayoutTests:

Reviewed, tweaked and landed by Maciej.

test case for 4405: <button> not listed in form collections. http://bugzilla.opendarwin.org/show_bug.cgi?id=4405

fast/forms/button-in-forms-collection-expected.txt: Added.
fast/forms/button-in-forms-collection.html: Added.

WebCore:

Reviewed and landed by Maciej.

fixed 4405: <button> not listed in form collections. http://bugzilla.opendarwin.org/show_bug.cgi?id=4405

Test: fast/forms/button-in-forms-collection.html

khtml/html/html_formimpl.h: (DOM::HTMLButtonElementImpl::isEnumeratable): override to return true

3:07 AM Changeset in webkit [11775] by mjs

3 edits
1 add in trunk

JavaScriptCore:

Reviewed and landed by Maciej.

fixed 6234: Can delete array index property incorrectly. http://bugzilla.opendarwin.org/show_bug.cgi?id=6234

kjs/array_object.cpp: (ArrayInstance::deleteProperty): use toArrayIndex instead of toUInt32 when looking for array properties.

LayoutTests:

Reviewed, tweaked and landed by Maciej.

test case for 6234: Can delete array index property incorrectly. http://bugzilla.opendarwin.org/show_bug.cgi?id=6234

fast/js/array-float-delete.html: Added.

2:35 AM Changeset in webkit [11774] by andersca

2 edits in trunk/JavaScriptCore

2005-12-27 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

kjs/object.cpp: (KJS::JSObject::defineSetter): Remove duplicate call to putDirect.

1:24 AM Changeset in webkit [11773] by mjs

7 edits in trunk/JavaScriptCore

Reviewed by Darin and Geoff.

Changes by me and Anders.

mostly fixed REGRESSION: 5-10% performance regression on JS iBench from getter/setter change http://bugzilla.opendarwin.org/show_bug.cgi?id=6083

also fixed some warnings reported by -Winline

JavaScriptCorePrefix.h: Move new and delete definitions higher so there aren't conflicts with use in standard C++ headers
kjs/object.cpp: (KJS::throwSetterError): Moved this piece of put into a seprate function to avoid the PIC branch. (KJS::JSObject::put): Use hasGetterSetterProperties to avoid expensive stuff when not needed. Also use GetterSetter properties attribute. (KJS::JSObject::deleteProperty): Recompute whether any properties are getter/setter properties any more, if this one was one. (KJS::JSObject::defineGetter): Let the PropertyMap know that it has getter/setter properties now (and use the new attribute). (KJS::JSObject::defineSetter): Ditto. (KJS::JSObject::fillGetterPropertySlot): Out-of-line helper for getOwnPropertySlot, to avoid global variable access in the hot code path.
kjs/object.h: (KJS::): Added GetterSetter attribute. (KJS::JSCell::isObject): Moved lower to be after inline methods it uses. (KJS::JSValue::isObject): ditto (KJS::JSObject::getOwnPropertySlot): try to avoid impact of getters and setters as much as possible in the case where they are not being used
kjs/property_map.cpp: (KJS::PropertyMap::containsGettersOrSetters): New method to help with this
kjs/property_map.h: (KJS::PropertyMap::hasGetterSetterProperties): Ditto (KJS::PropertyMap::setHasGetterSetterProperties): Ditto (KJS::PropertyMap::PropertyMap): Added a crazy hack to store the global "has getter/setter properties" flag in the property map single entry, to avoid making objects any bigger.
kjs/value.h: Moved some things to object.h to make -Winline happier

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed