⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 10, 2006:

10:34 PM Changeset in webkit [12228] by darin
  • 26 edits in trunk/JavaScriptGlue

top level:

  • Makefile: Removed some unneeded stray characters.
  • <tons of files>: Updated flags (removed executable, set MIME types, etc.)

Tools:

  • Makefile: Removed some unneeded stray characters.
  • Tools/Scripts/commit-log-editor: Updated to handle paths with spaces.

Tests:

  • performance: Removed.
9:50 PM Changeset in webkit [11995] by darin
  • 8899 edits in trunk
  • Makefile: Took out unneeded "export" line.
  • <many-files>: Changed a lot of flags (cleared bogus executable bits, set MIME types, other small corrections).
6:48 PM Changeset in webkit [11994] by mjs
  • 4 edits
    14 moves
    3 adds in trunk/WebCore

Reviewed by Darin.

  • moved files related to the Frame class and the forthcoming Page class to WebCore/page


  • moved files related to the MacFrame class and other bridging-related classes to WebCore/bridge/mac
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • ForwardingHeaders/ksvg2/KSVGView.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge: Added.
  • bridge/mac: Added.
  • bridge/mac/KWQKHTMLPartBrowserExtension.h: Added.
  • bridge/mac/KWQKHTMLPartBrowserExtension.mm: Added.
  • bridge/mac/KWQKHTMLView.cpp: Added.
  • bridge/mac/KWQKPartsBrowserExtension.h: Added.
  • bridge/mac/KWQKPartsBrowserInterface.mm: Added.
  • bridge/mac/MacFrame.h: Added.
  • bridge/mac/MacFrame.mm: Added.
  • bridge/mac/WebCoreBridge.h: Added.
  • bridge/mac/WebCoreBridge.mm: Added.
  • khtml/Frame.cpp: Removed.
  • khtml/Frame.h: Removed.
  • khtml/khtmlpart_p.h: Removed.
  • khtml/khtmlview.cpp: Removed.
  • khtml/khtmlview.h: Removed.
  • kwq/KWQKHTMLPartBrowserExtension.h: Removed.
  • kwq/KWQKHTMLPartBrowserExtension.mm: Removed.
  • kwq/KWQKHTMLView.cpp: Removed.
  • kwq/KWQKPartsBrowserExtension.h: Removed.
  • kwq/KWQKPartsBrowserInterface.mm: Removed.
  • kwq/MacFrame.h: Removed.
  • kwq/MacFrame.mm: Removed.
  • kwq/WebCoreBridge.h: Removed.
  • kwq/WebCoreBridge.mm: Removed.
  • page: Added.
  • page/Frame.cpp: Added.
  • page/Frame.h: Added.
  • page/khtmlpart_p.h: Added.
  • page/khtmlview.cpp: Added.
  • page/khtmlview.h: Added.
4:32 PM Changeset in webkit [11993] by hyatt
  • 2 edits in trunk/WebCore

#if Win32 the KWQMemArray overloads, since they're working around
a Windows compiler bug.


  • kwq/KWQMemArray.h:
4:20 PM Changeset in webkit [11992] by hyatt
  • 1 edit in trunk/WebCore/khtml/rendering/RenderText.cpp

Fix other gnuc spot.

4:19 PM Changeset in webkit [11991] by hyatt
  • 2 edits in trunk/WebCore

Fix the broken ifdef in KWQString.h

  • kwq/KWQString.h:
2:36 PM Changeset in webkit [11990] by hyatt
  • 93 edits in trunk/WebCore

Land fix for bug 6458.

2:20 PM Changeset in webkit [11989] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-10 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by eseidel. Committed by eseidel.

  • Scripts/run-webkit-tests: Add a command-line flag to prevent Safari being launched to display failed tests. Always exit with non-zero status when tests have failed.
2:18 PM Changeset in webkit [11988] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-10 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by eseidel. Committed by eseidel.

  • Scripts/build-webkit: Use correct bits of subprocess exit code when passing back through as build-webkit's exit code.
12:59 PM Changeset in webkit [11987] by hyatt
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

Remove the need for the WebKitTools environment variable.

6:01 AM Changeset in webkit [11986] by eseidel
  • 2 edits in trunk/WebCore

2006-01-10 Eric Seidel <eseidel@apple.com>

No review needed, build (linking deployment) fix only.

  • kwq/MacFrame.h: remove bogus KHTMLView *view() const delcaration
5:46 AM Changeset in webkit [11985] by eseidel
  • 4 edits in trunk/WebCore

2006-01-10 Eric Seidel <eseidel@apple.com>

Roll out local changes committed by accident w/ Mitz's patch.

  • kwq/KWQAccObjectCache.h:
  • kwq/KWQAccObjectCache.mm: (KWQAccObjectCache::KWQAccObjectCache): (KWQAccObjectCache::~KWQAccObjectCache): (KWQAccObjectCache::accObject): (KWQAccObjectCache::setAccObject): (KWQAccObjectCache::removeAccObject): (KWQAccObjectCache::getAccObjectID): (KWQAccObjectCache::removeAccObjectID): (KWQAccObjectCache::textMarkerForVisiblePosition): (KWQAccObjectCache::visiblePositionForTextMarker): (KWQAccObjectCache::childrenChanged):
  • kwq/KWQObject.cpp: (QObject::restartTimer): (QObject::timerIntervals): (deleteTimer): (QObject::killTimer): (deleteOneTimer): (QObject::killTimers): (sendDeferredTimerEvent):
5:35 AM Changeset in webkit [11984] by eseidel
  • 5 edits in trunk/WebCore

2006-01-10 Mitz Pettel <opendarwin.org@mitzpettel.com>

No tests possible, no functionality changes.

Reviewed by darin. Committed by eseidel.


  • khtml/rendering/bidi.cpp: (khtml::operator==): Return true if BidiContexts match and both don't have a parent.
5:23 AM Changeset in webkit [11983] by eseidel
  • 2 edits
    16 adds in trunk/WebKitTools

2006-01-10 Eric Seidel <eseidel@apple.com>

Restored corrupted nibs from TOT CVS.

  • DrawTest/English.lproj/DrawTestDocument.nib: Replaced.
  • DrawTest/English.lproj/DrawTestDocument.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/DrawTestDocument.nib/info.nib: Replaced.
  • DrawTest/English.lproj/DrawTestDocument.nib/keyedobjects.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib/info.nib: Replaced.
  • DrawTest/English.lproj/Inspector.nib/keyedobjects.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib/info.nib: Replaced.
  • DrawTest/English.lproj/MainMenu.nib/keyedobjects.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib/classes.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib/info.nib: Replaced.
  • DrawTest/English.lproj/TestViewer.nib/keyedobjects.nib: Replaced.
4:45 AM Changeset in webkit [11982] by eseidel
  • 13 edits in trunk/WebKitTools

2006-01-10 Nefaur Khandker <nefaurk@gmail.com>

Reviewed by eseidel. Committed by eseidel.

DrawTestView now subclasses WebView instead of DrawView.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DrawTest/DrawTestDocument.h:
  • DrawTest/DrawTestDocument.m: (-[DrawTestDocument dealloc]): (-[DrawTestDocument readFromFile:ofType:]): (-[DrawTestDocument windowControllerDidLoadNib:]): (-[DrawTestDocument dumpSVGToConsole:]): (-[DrawTestDocument openSourceForSelection:]): (-[DrawTestDocument dataRepresentationOfType:]):
  • DrawTest/DrawTestToolbarController.h:
  • DrawTest/DrawTestToolbarController.m: (-[DrawTestToolbarController initWithDrawView:]): (-[DrawTestToolbarController clickedToolbarItem:]): (-[DrawTestToolbarController validateToolbarItem:]):
  • DrawTest/DrawTestView.h:
  • DrawTest/DrawTestView.m: (-[DrawTestView initWithFrame:]): (-[DrawTestView setDocument:]):
  • DrawTest/SVGTest.h:
  • DrawTest/SVGTest.m: (+[SVGTest sharedDrawView]): (-[SVGTest generateCompositeIfNecessary]):
  • DrawTest/TestController.h:
  • DrawTest/TestController.m: (-[TestController awakeFromNib]): (-[TestController setSelectedTest:]): (-[TestController openTestViewerForSelection:]): (-[TestController toggleViewersScaleRule:]):
  • DrawTest/TestViewerSplitView.m: (-[TestViewerSplitView drawRect:]):
4:40 AM Changeset in webkit [11981] by eseidel
  • 2 edits in trunk/WebCore

2006-01-10 Eric Seidel <eseidel@apple.com>

Removed broken links in project file, no review need.

  • WebCore.xcodeproj/project.pbxproj:
3:03 AM Changeset in webkit [11980] by mjs
  • 8 edits
    1 delete in trunk/WebCore

Reviewed by Eric.

  • move C++-only methods down from Frame to MacFrame
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/Frame.cpp: (Frame::init): (Frame::setSettings): (Frame::provisionalLoadStarted): (Frame::userGestureHint): (Frame::renderer): (Frame::selectionRect): (Frame::isFrameSet): (Frame::openURL): (Frame::didNotOpenURL): (Frame::selectionStart): (scanForForm): (Frame::currentForm): (Frame::setEncoding): (Frame::addData): (Frame::revealSelection): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::pauseTimeouts): (Frame::resumeTimeouts): (Frame::canCachePage): (Frame::saveWindowProperties): (Frame::saveLocationProperties): (Frame::restoreWindowProperties): (Frame::restoreLocationProperties): (Frame::saveInterpreterBuiltins): (Frame::restoreInterpreterBuiltins): (Frame::frameForWidget): (Frame::frameForNode): (Frame::nodeForWidget): (Frame::setDocumentFocus): (Frame::clearDocumentFocus): (Frame::mutableInstances): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayout): (Frame::forceLayoutWithPageWidthRange): (Frame::sendResizeEvent): (Frame::sendScrollEvent): (Frame::scrollbarsVisible): (Frame::addMetaData): (Frame::scrollToAnchor): (Frame::closeURL): (Frame::canMouseDownStartSelect): (Frame::khtmlMouseDoubleClickEvent): (Frame::passWidgetMouseDownEventToWidget): (Frame::clearTimers): (Frame::centerSelectionInVisibleArea): (Frame::styleForSelectionStart): (Frame::selectionStartOffset): (Frame::selectionEndOffset): (Frame::selectionEnd): (Frame::setMediaType): (Frame::setSelectionFromNone): (Frame::displaysWithFocusAttributes): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol): (Frame::setName): (Frame::markedTextUsesUnderlines): (Frame::markedTextUnderlines): (Frame::prepareForUserAction): (Frame::isFrame): (Frame::mousePressNode):
  • khtml/Frame.h: (Frame::instances): (Frame::MarkedTextUnderline::MarkedTextUnderline):
  • kwq/MacFrame.cpp: Removed.
  • kwq/MacFrame.h: (MacFrame::markedTextRange):
  • kwq/MacFrame.mm: - humped a bunch of stuff down to Frame
  • kwq/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): use Mac calls
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): ditto
1:33 AM Changeset in webkit [11979] by eseidel
  • 24 edits
    28 copies
    1 add in trunk/WebCore

2006-01-10 Eric Seidel <eseidel@apple.com>

Rubber-stamped by mjs.

Split html_formimpl.{cpp,h} into multiple files (one per class)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6461

  • WebCore.xcodeproj/project.pbxproj: added files
  • khtml/ecma/kjs_html.cpp: updated includes
  • khtml/html/FormDataList.h: Added.
  • khtml/html/FormDataList.cpp: Added.
  • khtml/html/HTMLButtonElementImpl.cpp: Added.
  • khtml/html/HTMLButtonElementImpl.h: Added.
  • khtml/html/HTMLFieldSetElementImpl.cpp: Added.
  • khtml/html/HTMLFieldSetElementImpl.h: Added.
  • khtml/html/HTMLFormElementImpl.cpp: Added.
  • khtml/html/HTMLFormElementImpl.h: Added.
  • khtml/html/HTMLGenericFormElementImpl.cpp: Added.
  • khtml/html/HTMLGenericFormElementImpl.h: Added.
  • khtml/html/HTMLInputElementImpl.cpp: Added.
  • khtml/html/HTMLInputElementImpl.h: Added.
  • khtml/html/HTMLIsIndexElementImpl.cpp: Added.
  • khtml/html/HTMLIsIndexElementImpl.h: Added.
  • khtml/html/HTMLKeygenElementImpl.cpp: Added.
  • khtml/html/HTMLKeygenElementImpl.h: Added.
  • khtml/html/HTMLLabelElementImpl.cpp: Added.
  • khtml/html/HTMLLabelElementImpl.h: Added.
  • khtml/html/HTMLLegendElementImpl.cpp: Added.
  • khtml/html/HTMLLegendElementImpl.h: Added.
  • khtml/html/HTMLOptGroupElementImpl.cpp: Added.
  • khtml/html/HTMLOptGroupElementImpl.h: Added.
  • khtml/html/HTMLOptionElementImpl.cpp: Added.
  • khtml/html/HTMLOptionElementImpl.h: Added.
  • khtml/html/HTMLOptionsCollectionImpl.h: Added.
  • khtml/html/HTMLSelectElementImpl.cpp: Added.
  • khtml/html/HTMLSelectElementImpl.h: Added.
  • khtml/html/HTMLTextAreaElementImpl.cpp: Added.
  • khtml/html/HTMLTextAreaElementImpl.h: Added.
  • khtml/html/html_documentimpl.cpp: updated includes
  • khtml/html/html_imageimpl.cpp: updated includes
  • khtml/html/html_miscimpl.cpp: updated includes
  • khtml/html/html_objectimpl.cpp: updated includes
  • khtml/html/htmlfactory.cpp: updated includes
  • khtml/html/htmlparser.cpp: updated includes
  • khtml/khtmlview.cpp: updated includes
  • khtml/rendering/render_block.cpp: updated includes
  • khtml/rendering/render_button.cpp: updated includes
  • khtml/rendering/render_canvasimage.cpp: updated includes
  • khtml/rendering/render_flow.cpp: updated includes
  • khtml/rendering/render_form.cpp: updated includes
  • khtml/rendering/render_form.h: updated includes
  • khtml/rendering/render_image.cpp: updated includes
  • khtml/rendering/render_line.cpp: updated includes
  • khtml/rendering/render_theme.cpp: updated includes
  • khtml/xml/dom_docimpl.cpp: updated includes
  • kwq/DOMHTML.mm: updated includes
  • kwq/KWQAccObject.mm: updated includes
  • kwq/MacFrame.mm: updated includes
  • kwq/WebCoreBridge.mm: updated includes

Jan 9, 2006:

10:03 PM Changeset in webkit [11978] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Darin.

Test case: fast/parser/entity-surrogate-pairs.html

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseEntity): Don't check if we got a surrogate.
9:52 PM Changeset in webkit [11977] by hyatt
  • 4 adds in trunk/WebCore/WebCore.vcproj

Commit the Visual Studio project for WebCore.

7:32 PM Changeset in webkit [11976] by eseidel
  • 5 edits in trunk/WebCore

2006-01-09 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Further code removal (and build fix!)

  • khtml/Frame.cpp: (Frame::init): (Frame::~Frame): (Frame::restoreURL): (Frame::didOpenURL): (Frame::baseURL): (Frame::baseTarget):
  • khtml/Frame.h: (Frame::khtmlMouseDoubleClickEvent): (Frame::khtmlDrawContentsEvent):
  • kwq/KWQLoader.mm: (KWQServeRequest):
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
6:24 PM Changeset in webkit [11975] by eseidel
  • 5 edits in trunk/WebCore

2006-01-09 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Remove unused code from Frame.

  • khtml/Frame.cpp: (Frame::clear): (Frame::receivedFirstData): (Frame::checkCompleted): (Frame::completeURL): (Frame::khtmlMousePressEvent): (Frame::handleMouseMoveEventSelection): (Frame::khtmlMouseReleaseEvent):
  • khtml/Frame.h:
  • khtml/khtmlpart_p.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportWheelEvent): (KHTMLView::focusOutEvent):
5:26 PM Changeset in webkit [11974] by eseidel
  • 21 edits
    9 deletes in trunk/WebCore

2006-01-09 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Remove khtml-specific forwarding headers.

  • ForwardingHeaders/css: Removed.
  • ForwardingHeaders/css/css_base.h: Removed.
  • ForwardingHeaders/css/css_computedstyle.h: Removed.
  • ForwardingHeaders/css/css_ruleimpl.h: Removed.
  • ForwardingHeaders/css/css_stylesheetimpl.h: Removed.
  • ForwardingHeaders/css/css_valueimpl.h: Removed.
  • ForwardingHeaders/css/csshelper.h: Removed.
  • ForwardingHeaders/css/cssparser.h: Removed.
  • ForwardingHeaders/css/cssproperties.h: Removed.
  • ForwardingHeaders/css/cssstyleselector.h: Removed.
  • ForwardingHeaders/css/cssvalues.h: Removed.
  • ForwardingHeaders/dom: Removed.
  • ForwardingHeaders/dom/css_rule.h: Removed.
  • ForwardingHeaders/dom/css_stylesheet.h: Removed.
  • ForwardingHeaders/dom/css_value.h: Removed.
  • ForwardingHeaders/dom/dom2_events.h: Removed.
  • ForwardingHeaders/dom/dom2_range.h: Removed.
  • ForwardingHeaders/dom/dom2_traversal.h: Removed.
  • ForwardingHeaders/dom/dom_exception.h: Removed.
  • ForwardingHeaders/dom/dom_node.h: Removed.
  • ForwardingHeaders/dom/dom_string.h: Removed.
  • ForwardingHeaders/ecma: Removed.
  • ForwardingHeaders/ecma/kjs_binding.h: Removed.
  • ForwardingHeaders/ecma/kjs_dom.h: Removed.
  • ForwardingHeaders/ecma/kjs_proxy.h: Removed.
  • ForwardingHeaders/editing: Removed.
  • ForwardingHeaders/editing/SelectionController.h: Removed.
  • ForwardingHeaders/editing/edit_actions.h: Removed.
  • ForwardingHeaders/editing/html_interchange.h: Removed.
  • ForwardingHeaders/editing/htmlediting.h: Removed.
  • ForwardingHeaders/editing/jsediting.h: Removed.
  • ForwardingHeaders/editing/markup.h: Removed.
  • ForwardingHeaders/editing/text_affinity.h: Removed.
  • ForwardingHeaders/editing/text_granularity.h: Removed.
  • ForwardingHeaders/editing/visible_position.h: Removed.
  • ForwardingHeaders/editing/visible_text.h: Removed.
  • ForwardingHeaders/editing/visible_units.h: Removed.
  • ForwardingHeaders/html: Removed.
  • ForwardingHeaders/html/html_baseimpl.h: Removed.
  • ForwardingHeaders/html/html_blockimpl.h: Removed.
  • ForwardingHeaders/html/html_canvasimpl.h: Removed.
  • ForwardingHeaders/html/html_documentimpl.h: Removed.
  • ForwardingHeaders/html/html_elementimpl.h: Removed.
  • ForwardingHeaders/html/html_formimpl.h: Removed.
  • ForwardingHeaders/html/html_headimpl.h: Removed.
  • ForwardingHeaders/html/html_imageimpl.h: Removed.
  • ForwardingHeaders/html/html_inlineimpl.h: Removed.
  • ForwardingHeaders/html/html_listimpl.h: Removed.
  • ForwardingHeaders/html/html_miscimpl.h: Removed.
  • ForwardingHeaders/html/html_objectimpl.h: Removed.
  • ForwardingHeaders/html/html_tableimpl.h: Removed.
  • ForwardingHeaders/html/htmlparser.h: Removed.
  • ForwardingHeaders/html/htmltokenizer.h: Removed.
  • ForwardingHeaders/misc: Removed.
  • ForwardingHeaders/misc/decoder.h: Removed.
  • ForwardingHeaders/misc/formdata.h: Removed.
  • ForwardingHeaders/misc/helper.h: Removed.
  • ForwardingHeaders/misc/khtmllayout.h: Removed.
  • ForwardingHeaders/misc/loader.h: Removed.
  • ForwardingHeaders/misc/loader_client.h: Removed.
  • ForwardingHeaders/misc/shared.h: Removed.
  • ForwardingHeaders/misc/stringit.h: Removed.
  • ForwardingHeaders/rendering: Removed.
  • ForwardingHeaders/rendering/font.h: Removed.
  • ForwardingHeaders/rendering/render_applet.h: Removed.
  • ForwardingHeaders/rendering/render_block.h: Removed.
  • ForwardingHeaders/rendering/render_box.h: Removed.
  • ForwardingHeaders/rendering/render_br.h: Removed.
  • ForwardingHeaders/rendering/render_canvas.h: Removed.
  • ForwardingHeaders/rendering/render_canvasimage.h: Removed.
  • ForwardingHeaders/rendering/render_flow.h: Removed.
  • ForwardingHeaders/rendering/render_form.h: Removed.
  • ForwardingHeaders/rendering/render_frames.h: Removed.
  • ForwardingHeaders/rendering/render_image.h: Removed.
  • ForwardingHeaders/rendering/render_layer.h: Removed.
  • ForwardingHeaders/rendering/render_line.h: Removed.
  • ForwardingHeaders/rendering/render_list.h: Removed.
  • ForwardingHeaders/rendering/render_object.h: Removed.
  • ForwardingHeaders/rendering/render_replaced.h: Removed.
  • ForwardingHeaders/rendering/render_style.h: Removed.
  • ForwardingHeaders/rendering/render_table.h: Removed.
  • ForwardingHeaders/rendering/table_layout.h: Removed.
  • ForwardingHeaders/xbl: Removed.
  • ForwardingHeaders/xbl/xbl_binding_manager.h: Removed.
  • ForwardingHeaders/xml: Removed.
  • ForwardingHeaders/xml/EventNames.h: Removed.
  • ForwardingHeaders/xml/dom2_eventsimpl.h: Removed.
  • ForwardingHeaders/xml/dom2_rangeimpl.h: Removed.
  • ForwardingHeaders/xml/dom2_traversalimpl.h: Removed.
  • ForwardingHeaders/xml/dom2_viewsimpl.h: Removed.
  • ForwardingHeaders/xml/dom_atomicstring.h: Removed.
  • ForwardingHeaders/xml/dom_docimpl.h: Removed.
  • ForwardingHeaders/xml/dom_elementimpl.h: Removed.
  • ForwardingHeaders/xml/dom_nodeimpl.h: Removed.
  • ForwardingHeaders/xml/dom_position.h: Removed.
  • ForwardingHeaders/xml/dom_stringimpl.h: Removed.
  • ForwardingHeaders/xml/dom_textimpl.h: Removed.
  • ForwardingHeaders/xml/dom_xmlimpl.h: Removed.
  • ForwardingHeaders/xml/xml_tokenizer.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_valueimpl.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/jsediting.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_elementimpl.cpp:
  • khtml/html/html_formimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_listimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/khtml_part.cpp:
  • khtml/misc/decoder.cpp:
  • khtml/rendering/render_frames.cpp:
  • khtml/xml/dom_elementimpl.cpp:
5:15 PM Changeset in webkit [11973] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by Timothy.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the default language to "en", so language tests will work.
5:14 PM Changeset in webkit [11972] by thatcher
  • 1 edit in trunk/WebKitTools/ChangeLog

This is a test commit and a cleanup.

Reviewed by Timothy.

  • DumpRenderTree/DumpRenderTree.m: Set the default language to "en", so language tests will work.
4:22 PM Changeset in webkit [11971] by andersca
  • 2 edits in trunk/WebKitTools

2006-01-10 Anders Carlsson <andersca@mac.com>

Reviewed by Timothy.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the default language to "en", so language tests will work.
3:24 PM Changeset in webkit [11970] by andersca
  • 5 edits in trunk/WebCore

2006-01-10 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

  • renamed ChildFrame::m_frame to m_renderer and ChildFrame::m_part to m_frame which makes more sense.


This also fixes some bugs which were introduced in Maciej's
previous commit.


  • khtml/Frame.cpp: (Frame::stopLoading): (Frame::clear): (Frame::stopAnimations): (Frame::checkEmitLoadEvent): (Frame::requestFrame): (Frame::requestObject): (Frame::processObjectRequest): (Frame::childFrame): (Frame::findFrame): (Frame::frameExists): (Frame::setZoomFactor): (Frame::frames): (Frame::childFrameNamed): (Frame::connectChild): (Frame::disconnectChild): (Frame::handleFallbackContent):
  • khtml/khtmlpart_p.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement):
  • kwq/MacFrame.mm: (Frame::frameDetached): (MacFrame::createPart): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::setPolicyBaseURL):
3:21 PM Changeset in webkit [11969] by ggaren
  • 3 edits in trunk/WebKit

small terminology fixup recommended in review

2:31 PM Changeset in webkit [11968] by hyatt
  • 1 delete in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore.suo

Remove the .suo file. Not needed.

2:29 PM Changeset in webkit [11967] by hyatt
  • 3 edits in trunk/JavaScriptCore/JavaScriptCore.vcproj

Check in a fixed JSCore project.

1:39 PM Changeset in webkit [11966] by mjs
  • 107 edits
    5 moves in trunk/WebCore

Reviewed by Darin.

  • renamed KHTMLPart to Frame (and KWQKHTMLPart to MacFrame for now)
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/Frame.cpp: Added. (khtml::PartStyleSheetLoader::PartStyleSheetLoader): (khtml::PartStyleSheetLoader::setStyleSheet): (Frame::Frame): (Frame::init): (Frame::~Frame): (Frame::restoreURL): (Frame::didOpenURL): (Frame::didExplicitOpen): (Frame::stopLoading): (Frame::closeURL): (Frame::browserExtension): (Frame::view): (Frame::setJScriptEnabled): (Frame::jScriptEnabled): (Frame::setMetaRefreshEnabled): (Frame::metaRefreshEnabled): (Frame::jScript): (Frame::replaceContentsWithScriptResult): (Frame::executeScript): (Frame::scheduleScript): (Frame::executeScheduledScript): (Frame::setJavaEnabled): (Frame::javaEnabled): (Frame::setPluginsEnabled): (Frame::pluginsEnabled): (Frame::slotDebugDOMTree): (Frame::slotDebugRenderTree): (Frame::setAutoloadImages): (Frame::autoloadImages): (Frame::clear): (Frame::openFile): (Frame::xmlDocImpl): (Frame::replaceDocImpl): (Frame::receivedFirstData): (Frame::slotFinished): (Frame::childBegin): (Frame::begin): (Frame::write): (Frame::end): (Frame::endIfNotLoading): (Frame::stop): (Frame::stopAnimations): (Frame::gotoAnchor): (Frame::slotFinishedParsing): (Frame::slotLoaderRequestStarted): (Frame::slotLoaderRequestDone): (Frame::checkCompleted): (Frame::checkEmitLoadEvent): (Frame::settings): (Frame::baseURL): (Frame::baseTarget): (Frame::completeURL): (Frame::scheduleRedirection): (Frame::scheduleLocationChange): (Frame::isScheduledLocationChangePending): (Frame::scheduleHistoryNavigation): (Frame::cancelRedirection): (Frame::changeLocation): (Frame::slotRedirect): (Frame::slotRedirection): (Frame::encoding): (Frame::setUserStyleSheet): (Frame::setStandardFont): (Frame::setFixedFont): (Frame::urlCursor): (Frame::onlyLocalReferences): (Frame::setOnlyLocalReferences): (Frame::selectedText): (Frame::hasSelection): (Frame::selection): (Frame::selectionGranularity): (Frame::setSelectionGranularity): (Frame::dragCaret): (Frame::mark): (Frame::setMark): (Frame::setSelection): (Frame::setDragCaret): (Frame::clearSelection): (Frame::invalidateSelection): (Frame::setCaretVisible): (Frame::clearCaretRectIfNeeded): (isFrameElement): (Frame::setFocusNodeIfNeeded): (Frame::selectionLayoutChanged): (Frame::setXPosForVerticalArrowNavigation): (Frame::xPosForVerticalArrowNavigation): (Frame::timerEvent): (Frame::paintCaret): (Frame::paintDragCaret): (Frame::urlSelected): (Frame::requestFrame): (Frame::requestFrameName): (Frame::requestObject): (Frame::processObjectRequest): (Frame::submitFormAgain): (Frame::submitForm): (Frame::slotParentCompleted): (Frame::slotChildStarted): (Frame::slotChildCompleted): (Frame::childFrame): (Frame::findFrame): (Frame::frameExists): (Frame::parentFrame): (Frame::zoomFactor): (Frame::slotIncZoom): (Frame::slotDecZoom): (Frame::setZoomFactor): (Frame::setJSStatusBarText): (Frame::setJSDefaultStatusBarText): (Frame::jsStatusBarText): (Frame::jsDefaultStatusBarText): (Frame::referrer): (Frame::lastModified): (Frame::reparseConfiguration): (Frame::frameNames): (Frame::frames): (Frame::childFrameNamed): (Frame::setDNDEnabled): (Frame::dndEnabled): (Frame::shouldDragAutoNode): (Frame::customEvent): (Frame::isPointInsideSelection): (Frame::selectClosestWordFromMouseEvent): (Frame::handleMousePressEventDoubleClick): (Frame::handleMousePressEventTripleClick): (Frame::handleMousePressEventSingleClick): (Frame::khtmlMousePressEvent): (Frame::khtmlMouseDoubleClickEvent): (Frame::handleMouseMoveEventSelection): (Frame::khtmlMouseMoveEvent): (Frame::khtmlMouseReleaseEvent): (Frame::khtmlDrawContentsEvent): (Frame::startAutoScroll): (Frame::stopAutoScroll): (Frame::selectAll): (Frame::selectContentsOfNode): (Frame::shouldChangeSelection): (Frame::shouldBeginEditing): (Frame::shouldEndEditing): (Frame::isContentEditable): (Frame::lastEditCommand): (Frame::appliedEditing): (Frame::unappliedEditing): (Frame::reappliedEditing): (Frame::typingStyle): (Frame::setTypingStyle): (Frame::clearTypingStyle): (Frame::slotPartRemoved): (Frame::createHTMLEventListener): (Frame::opener): (Frame::setOpener): (Frame::openedByJS): (Frame::setOpenedByJS): (Frame::preloadStyleSheet): (Frame::preloadScript): (Frame::restored): (Frame::incrementFrameCount): (Frame::decrementFrameCount): (Frame::topLevelFrameCount): (Frame::tabsToLinks): (Frame::tabsToAllControls): (Frame::copyToPasteboard): (Frame::cutToPasteboard): (Frame::pasteFromPasteboard): (Frame::pasteAndMatchStyle): (Frame::transpose): (Frame::redo): (Frame::undo): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (updateState): (Frame::selectionHasStyle): (Frame::selectionStartHasStyle): (Frame::selectionStartStylePropertyValue): (Frame::selectionComputedStyle): (Frame::applyEditingStyleToBodyElement): (Frame::removeEditingStyleFromBodyElement): (Frame::applyEditingStyleToElement): (Frame::removeEditingStyleFromElement): (Frame::isCharacterSmartReplaceExempt): (Frame::connectChild): (Frame::disconnectChild): (Frame::keepAlive): (Frame::slotEndLifeSupport): (Frame::selectFrameElementInParentIfFullySelected): (Frame::handleFallbackContent):
  • khtml/Frame.h: Added.
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::checkOneSelector): (khtml::CSSStyleSelector::applyProperty): (khtml::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): (KJS::ScriptInterpreter::~ScriptInterpreter):
  • khtml/ecma/kjs_binding.h: (KJS::ScriptInterpreter::frame):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::getDOMDocumentNode): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): (KJS::JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocFunction::callAsFunction): (KJS::HTMLDocument::namedItemGetter): (KJS::HTMLDocument::getValueProperty): (KJS::KJS::HTMLDocument::putValueProperty): (KJS::HTMLElement::framesetNameGetter): (KJS::HTMLElement::frameWindowPropertyGetter): (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElement::implementsCall): (KJS::Image::notifyFinished):
  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::Navigator): (KJS::Navigator::getValueProperty): (KJS::NavigatorFunc::callAsFunction):
  • khtml/ecma/kjs_navigator.h: (KJS::Navigator::frame):
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::KJSProxyImpl): (KJSProxyImpl::evaluate): (KJSProxyImpl::clear): (KJSProxyImpl::createHTMLEventHandler): (KJSProxyImpl::interpreter): (KJSProxyImpl::initScript):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::History::History): (KJS::FrameArray::FrameArray): (KJS::Screen::getValueProperty): (KJS::Window::Window): (KJS::Window::interpreter): (KJS::Window::retrieveWindow): (KJS::Window::retrieve): (KJS::Window::location): (KJS::Window::selection): (KJS::Window::locationbar): (KJS::Window::menubar): (KJS::Window::personalbar): (KJS::Window::statusbar): (KJS::Window::toolbar): (KJS::Window::scrollbars): (KJS::allowPopUp): (KJS::createNewWindow): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::childFrameGetter): (KJS::Window::namedFrameGetter): (KJS::Window::indexGetter): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::toBoolean): (KJS::Window::scheduleClose): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::setCurrentEvent): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::WindowQObject::WindowQObject): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot): (KJS::Location::Location): (KJS::Location::getValueProperty): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::Location::toString): (KJS::LocationFunc::callAsFunction): (KJS::Selection::Selection): (KJS::Selection::getValueProperty): (KJS::Selection::getOwnPropertySlot): (KJS::Selection::toString): (KJS::SelectionFunc::callAsFunction): (KJS::BarInfo::BarInfo): (KJS::BarInfo::getValueProperty): (KJS::BarInfo::getOwnPropertySlot): (KJS::History::getValueProperty): (KJS::HistoryFunc::callAsFunction):
  • khtml/ecma/kjs_window.h: (KJS::Window::frame): (KJS::Location::frame): (KJS::Selection::frame): (KJS::BarInfo::frame):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::changeState): (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::modify): (khtml::SelectionController::xPosForVerticalArrowNavigation):
  • khtml/editing/SelectionController.h: (khtml::SelectionController::frame):
  • khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
  • khtml/editing/edit_command.cpp: (khtml::EditCommand::EditCommand): (khtml::EditCommand::apply): (khtml::EditCommand::unapply): (khtml::EditCommand::reapply): (khtml::EditCommand::styleAtPosition):
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
  • khtml/editing/jsediting.cpp: (DOM::JSEditor::execCommand): (DOM::JSEditor::queryCommandEnabled): (DOM::JSEditor::queryCommandIndeterm): (DOM::JSEditor::queryCommandState): (DOM::JSEditor::queryCommandValue):
  • khtml/editing/jsediting.h:
  • khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply):
  • khtml/editing/text_granularity.h:
  • khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::insertText): (khtml::TypingCommand::insertLineBreak): (khtml::TypingCommand::insertParagraphSeparatorInQuotedContent): (khtml::TypingCommand::insertParagraphSeparator): (khtml::TypingCommand::markMisspellingsAfterTyping): (khtml::TypingCommand::typingAddedToOpenCommand): (khtml::TypingCommand::insertTextRunWithoutNewlines):
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::isURLAllowed): (HTMLFrameElementImpl::openURL): (HTMLFrameElementImpl::attach): (HTMLFrameElementImpl::close): (HTMLFrameElementImpl::contentPart): (HTMLFrameElementImpl::contentDocument): (HTMLIFrameElementImpl::attach):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp: (DOM::HTMLDocumentImpl::lastModified):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isContentEditable): (HTMLElementImpl::setContentEditable):
  • khtml/html/html_formimpl.cpp: (DOM::HTMLFormElementImpl::formData): (DOM::HTMLFormElementImpl::prepareSubmit): (DOM::HTMLFormElementImpl::submit): (DOM::HTMLFormElementImpl::reset): (DOM::HTMLGenericFormElementImpl::isKeyboardFocusable): (DOM::HTMLKeygenElementImpl::appendFormData):
  • khtml/html/html_headimpl.cpp: (HTMLBaseElementImpl::process): (HTMLLinkElementImpl::process): (HTMLScriptElementImpl::parseMappedAttribute): (HTMLScriptElementImpl::insertedIntoDocument): (HTMLScriptElementImpl::evaluateScript):
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp: (DOM::HTMLAnchorElementImpl::isKeyboardFocusable): (DOM::HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/html_objectimpl.cpp: (DOM::HTMLAppletElementImpl::createRenderer): (DOM::HTMLAppletElementImpl::getAppletInstance): (DOM::HTMLEmbedElementImpl::getEmbedInstance): (DOM::HTMLEmbedElementImpl::rendererIsNeeded): (DOM::HTMLObjectElementImpl::getObjectInstance): (DOM::HTMLObjectElementImpl::rendererIsNeeded):
  • khtml/html/html_tableimpl.cpp:
  • khtml/html/htmlparser.cpp: (HTMLParser::noscriptCreateErrorCheck):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::scriptHandler): (khtml::HTMLTokenizer::scriptExecution): (khtml::HTMLTokenizer::parseTag): (khtml::HTMLTokenizer::write): (khtml::HTMLTokenizer::stopParsing): (khtml::HTMLTokenizer::timerEvent): (khtml::HTMLTokenizer::processToken):
  • khtml/khtml_part.cpp: Removed.
  • khtml/khtml_part.h: Removed.
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate):
  • khtml/khtmlview.cpp: (KHTMLView::KHTMLView): (KHTMLView::~KHTMLView): (KHTMLView::clearPart): (KHTMLView::clear): (KHTMLView::resizeEvent): (KHTMLView::adjustViewSize): (KHTMLView::layout): (KHTMLView::updateDashboardRegions): (KHTMLView::viewportMousePressEvent): (KHTMLView::viewportMouseDoubleClickEvent): (selectCursor): (KHTMLView::viewportMouseMoveEvent): (KHTMLView::viewportMouseReleaseEvent): (KHTMLView::keyPressEvent): (KHTMLView::dispatchDragEvent): (KHTMLView::updateDragAndDrop): (KHTMLView::focusNextPrevNode): (KHTMLView::mediaType): (KHTMLView::dispatchMouseEvent): (KHTMLView::viewportWheelEvent): (KHTMLView::focusInEvent): (KHTMLView::focusOutEvent): (KHTMLView::timerEvent): (KHTMLView::scheduleRelayout): (KHTMLView::unscheduleRelayout):
  • khtml/khtmlview.h: (KHTMLView::frame):
  • khtml/misc/CachedImageCallback.cpp: (khtml::CachedImageCallback::notifyUpdate): (khtml::CachedImageCallback::notifyFinished): (khtml::CachedImageCallback::clear):
  • khtml/misc/CachedObject.h:
  • khtml/misc/DocLoader.cpp: (khtml::DocLoader::DocLoader): (khtml::DocLoader::requestImage): (khtml::DocLoader::requestStyleSheet): (khtml::DocLoader::requestScript): (khtml::DocLoader::requestXSLStyleSheet): (khtml::DocLoader::requestXBLDocument):
  • khtml/misc/DocLoader.h: (khtml::DocLoader::frame):
  • khtml/misc/loader.cpp: (khtml::Loader::slotReceivedResponse):
  • khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::paintMarkedTextUnderline):
  • khtml/rendering/InlineTextBox.h:
  • khtml/rendering/render_applet.cpp: (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::paintCaret):
  • khtml/rendering/render_canvas.cpp:
  • khtml/rendering/render_form.cpp: (RenderFileButton::RenderFileButton):
  • khtml/rendering/render_frames.cpp: (isURLAllowed): (RenderPartObject::updateWidget):
  • khtml/rendering/render_layer.cpp:
  • khtml/rendering/render_object.cpp: (RenderObject::draggableNode):
  • khtml/rendering/render_replaced.cpp: (RenderWidget::eventFilter):
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::updateTitle): (DocumentImpl::frame): (DocumentImpl::recalcStyle): (DocumentImpl::updateSelection): (DocumentImpl::open): (DocumentImpl::close): (DocumentImpl::implicitClose): (DocumentImpl::processHttpEquiv): (DocumentImpl::selectedStylesheetSet): (DocumentImpl::setSelectedStylesheetSet): (DocumentImpl::recalcStyleSelector): (DocumentImpl::relinquishesEditingFocus): (DocumentImpl::acceptsEditingFocus): (DocumentImpl::clearSelectionIfNeeded): (DocumentImpl::createHTMLEventListener): (DocumentImpl::ownerElement): (DocumentImpl::referrer): (DocumentImpl::parentDocument):
  • khtml/xml/dom_docimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::focus):
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::dispatchEvent):
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::processingInstruction): (khtml::XMLTokenizer::executeScripts): (khtml::XMLTokenizer::notifyFinished):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished):
  • kwq/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • kwq/DOMHTML.mm:
  • kwq/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject value]): (-[KWQAccObject accessibilityPerformAction:]): (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]): (-[KWQAccObject doSetAXSelectedTextMarkerRange:]):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (KWQClipboard::KWQClipboard): (KWQClipboard::dragNSImage):
  • kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]): (-[KWQPopUpButton nextKeyView]): (-[KWQPopUpButton previousKeyView]):
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::focusPolicy): (KWQFileButton::focusChanged):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • kwq/KWQKHTMLFactory.h:
  • kwq/KWQKHTMLPart.cpp: Removed.
  • kwq/KWQKHTMLPart.h: Removed.
  • kwq/KWQKHTMLPart.mm: Removed.
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::KHTMLPartBrowserExtension): (KHTMLPartBrowserExtension::openURLRequest): (KHTMLPartBrowserExtension::createNewWindow): (KHTMLPartBrowserExtension::setIconURL): (KHTMLPartBrowserExtension::setTypedIconURL): (KHTMLPartBrowserExtension::canRunModal): (KHTMLPartBrowserExtension::canRunModalNow): (KHTMLPartBrowserExtension::runModal):
  • kwq/KWQKHTMLView.cpp: (KHTMLView::topLevelWidget):
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQKPartsBrowserInterface.h: (KParts::BrowserInterface::BrowserInterface):
  • kwq/KWQKPartsBrowserInterface.mm: (KParts::BrowserInterface::property): (KParts::BrowserInterface::callMethod):
  • kwq/KWQLineEdit.mm:
  • kwq/KWQListBox.mm: (-[KWQListBoxScrollView becomeFirstResponder]): (-[KWQTableView keyDown:]): (-[KWQTableView keyUp:]): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]): (-[KWQTableView nextKeyView]): (-[KWQTableView previousKeyView]):
  • kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest): (KWQCheckIfReloading): (KWQCheckCacheObjectStatus): (KWQCacheObjectExpiresTime):
  • kwq/KWQObject.cpp: (QObject::inherits): (QObject::isFrame):
  • kwq/KWQObject.h:
  • kwq/KWQPageState.mm: (-[KWQPageState dealloc]): (-[KWQPageState finalize]):
  • kwq/KWQRegExp.cpp: (QRegExp::KWQRegExpPrivate::compile):
  • kwq/KWQRenderTreeDebug.cpp: (write): (writeSelection):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (-[KWQSlider nextKeyView]): (-[KWQSlider previousKeyView]): (-[KWQSlider canBecomeKeyView]): (QSlider::focusPolicy):
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): (KWQSlot::call):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView _isResizableByUser]): (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView nextKeyView]): (-[KWQTextAreaTextView previousKeyView]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): (-[KWQTextAreaTextView drawRect:]): (-[KWQTextAreaTextView insertTab:]): (-[KWQTextAreaTextView insertBacktab:]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView shouldDrawInsertionPoint]): (-[KWQTextAreaTextView selectedTextAttributes]): (-[KWQTextAreaTextView keyDown:]): (-[KWQTextAreaTextView keyUp:]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidBeginEditing:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController control:textView:doCommandBySelector:]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]):
  • kwq/KWQTimer.h:
  • kwq/KWQWidget.mm: (QWidget::setActiveWindow): (QWidget::hasFocus): (QWidget::setFocus): (QWidget::clearFocus): (QWidget::isVisible): (QWidget::mapFromGlobal): (QWidget::setIsSelected):
  • kwq/MacFrame.cpp: Added. (MacFrame::isFrameSet):
  • kwq/MacFrame.h: Added. (MacFrame::instances): (Mac):
  • kwq/MacFrame.mm: Added. (Frame::completed): (Frame::openURL): (Frame::onURL): (Frame::setStatusBarText): (Frame::started): (redirectionTimerMonitor): (MacFrame::MacFrame): (MacFrame::~MacFrame): (MacFrame::freeClipboard): (MacFrame::setSettings): (MacFrame::generateFrameName): (MacFrame::provisionalLoadStarted): (MacFrame::userGestureHint): (MacFrame::openURL): (MacFrame::openURLRequest): (MacFrame::didNotOpenURL): (MacFrame::currentForm): (MacFrame::searchForLabelsAboveCell): (MacFrame::searchForLabelsBeforeElement): (MacFrame::matchLabelsAgainstElement): (MacFrame::findString): (MacFrame::clearRecordedFormValues): (MacFrame::recordFormValue): (MacFrame::submitForm): (MacFrame::setEncoding): (MacFrame::addData): (Frame::frameDetached): (MacFrame::urlSelected): (MacFrame::createPart): (MacFrame::setView): (MacFrame::view): (MacFrame::setTitle): (MacFrame::setStatusBarText): (MacFrame::scheduleClose): (MacFrame::unfocusWindow): (MacFrame::revealSelection): (MacFrame::advanceToNextMisspelling): (MacFrame::scrollOverflow): (MacFrame::wheelEvent): (MacFrame::redirectionTimerStartedOrStopped): (MacFrame::paint): (MacFrame::adjustPageHeight): (MacFrame::renderer): (MacFrame::userAgent): (MacFrame::mimeTypeForFileName): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::nextKeyView): (MacFrame::nextKeyViewForWidget): (MacFrame::currentEventIsMouseDownInWidget): (MacFrame::currentEventIsKeyboardOptionTab): (MacFrame::handleKeyboardOptionTabInView): (MacFrame::tabsToLinks): (MacFrame::tabsToAllControls): (MacFrame::executionContextForDOM): (MacFrame::bindingRootObject): (MacFrame::windowScriptObject): (MacFrame::windowScriptNPObject): (MacFrame::partClearedInBegin): (MacFrame::pauseTimeouts): (MacFrame::resumeTimeouts): (MacFrame::canCachePage): (MacFrame::saveWindowProperties): (MacFrame::saveLocationProperties): (MacFrame::restoreWindowProperties): (MacFrame::restoreLocationProperties): (MacFrame::saveInterpreterBuiltins): (MacFrame::restoreInterpreterBuiltins): (MacFrame::openURLFromPageCache): (MacFrame::frameForWidget): (MacFrame::bridgeForWidget): (MacFrame::frameForNode): (MacFrame::documentViewForNode): (MacFrame::nodeForWidget): (MacFrame::setDocumentFocus): (MacFrame::clearDocumentFocus): (MacFrame::saveDocumentState): (MacFrame::restoreDocumentState): (MacFrame::mutableInstances): (MacFrame::updatePolicyBaseURL): (MacFrame::setPolicyBaseURL): (MacFrame::requestedURLString): (MacFrame::incomingReferrer): (MacFrame::forceLayout): (MacFrame::forceLayoutWithPageWidthRange): (MacFrame::sendResizeEvent): (MacFrame::sendScrollEvent): (MacFrame::runJavaScriptAlert): (MacFrame::runJavaScriptConfirm): (MacFrame::runJavaScriptPrompt): (MacFrame::locationbarVisible): (MacFrame::menubarVisible): (MacFrame::personalbarVisible): (MacFrame::scrollbarsVisible): (MacFrame::statusbarVisible): (MacFrame::toolbarVisible): (MacFrame::addMessageToConsole): (MacFrame::createEmptyDocument): (MacFrame::addMetaData): (MacFrame::keyEvent): (MacFrame::scrollToAnchor): (MacFrame::closeURL): (MacFrame::canMouseDownStartSelect): (MacFrame::khtmlMousePressEvent): (MacFrame::khtmlMouseDoubleClickEvent): (MacFrame::passWidgetMouseDownEventToWidget): (MacFrame::lastEventIsMouseUp): (MacFrame::mouseDownViewIfStillGood): (MacFrame::dragHysteresisExceeded): (MacFrame::dispatchDragSrcEvent): (MacFrame::eventMayStartDrag): (MacFrame::khtmlMouseMoveEvent): (MacFrame::dragSourceMovedTo): (MacFrame::dragSourceEndedAt): (MacFrame::dispatchCPPEvent): (MacFrame::mayCut): (MacFrame::mayCopy): (MacFrame::mayPaste): (MacFrame::tryCut): (MacFrame::tryCopy): (MacFrame::tryPaste): (MacFrame::khtmlMouseReleaseEvent): (MacFrame::clearTimers): (MacFrame::passSubframeEventToSubframe): (MacFrame::passWheelEventToChildWidget): (MacFrame::mouseDown): (MacFrame::mouseDragged): (MacFrame::mouseUp): (MacFrame::sendFakeEventsAfterWidgetTracking): (MacFrame::mouseMoved): (MacFrame::shouldDragAutoNode): (MacFrame::sendContextMenuEvent): (MacFrame::fileWrapperForElement): (MacFrame::attributedString): (MacFrame::selectionRect): (MacFrame::visibleSelectionRect): (MacFrame::centerSelectionInVisibleArea): (MacFrame::imageFromRect): (MacFrame::selectionImage): (MacFrame::snapshotDragImage): (MacFrame::styleForSelectionStart): (MacFrame::fontForSelection): (MacFrame::fontAttributesForSelectionStart): (MacFrame::baseWritingDirectionForSelectionStart): (MacFrame::topLevelWidget): (MacFrame::tokenizerProcessedData): (MacFrame::selectionStartOffset): (MacFrame::selectionEndOffset): (MacFrame::selectionStart): (MacFrame::selectionEnd): (MacFrame::setBridge): (MacFrame::overrideMediaType): (MacFrame::setMediaType): (MacFrame::setSelectionFromNone): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::displaysWithFocusAttributes): (MacFrame::setWindowHasFocus): (MacFrame::backslashAsCurrencySymbol): (MacFrame::bodyBackgroundColor): (MacFrame::keyboardUIMode): (MacFrame::setName): (MacFrame::didTellBridgeAboutLoad): (MacFrame::haveToldBridgeAboutLoad): (MacFrame::clear): (Frame::print): (MacFrame::getAppletInstanceForWidget): (MacFrame::getEmbedInstanceForWidget): (MacFrame::getObjectInstanceForWidget): (MacFrame::addPluginRootObject): (MacFrame::cleanupPluginRootObjects): (MacFrame::registerCommandForUndoOrRedo): (MacFrame::registerCommandForUndo): (MacFrame::registerCommandForRedo): (MacFrame::clearUndoRedoOperations): (MacFrame::issueUndoCommand): (MacFrame::issueRedoCommand): (MacFrame::issueCutCommand): (MacFrame::issueCopyCommand): (MacFrame::issuePasteCommand): (MacFrame::issuePasteAndMatchStyleCommand): (MacFrame::issueTransposeCommand): (Frame::canUndo): (Frame::canRedo): (Frame::canPaste): (MacFrame::markMisspellingsInAdjacentWords): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::shouldChangeSelection): (MacFrame::respondToChangedContents): (MacFrame::isContentEditable): (MacFrame::shouldBeginEditing): (MacFrame::shouldEndEditing): (convertAttributesToUnderlines): (MacFrame::setMarkedTextRange): (MacFrame::markedTextUsesUnderlines): (MacFrame::markedTextUnderlines): (MacFrame::canGoBackOrForward): (MacFrame::prepareForUserAction): (MacFrame::didFirstLayout): (MacFrame::dashboardRegionsDictionary): (MacFrame::dashboardRegionsChanged): (MacFrame::isCharacterSmartReplaceExempt): (MacFrame::isFrame): (MacFrame::mousePressNode): (MacFrame::handledOnloadEvents): (MacFrame::shouldClose):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (updateRenderingForBindings): (frameHasSelection): (+[WebCoreBridge bridgeForDOMDocument:]): (-[WebCoreBridge init]): (-[WebCoreBridge initializeSettings:]): (-[WebCoreBridge dealloc]): (-[WebCoreBridge finalize]): (-[WebCoreBridge part]): (-[WebCoreBridge setParent:]): (-[WebCoreBridge parent]): (-[WebCoreBridge provisionalLoadStarted]): (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreBridge setEncoding:userChosen:]): (-[WebCoreBridge addData:]): (-[WebCoreBridge closeURL]): (-[WebCoreBridge stopLoading]): (-[WebCoreBridge didNotOpenURL:pageCache:]): (-[WebCoreBridge saveDocumentState]): (-[WebCoreBridge restoreDocumentState]): (-[WebCoreBridge scrollToAnchorWithURL:]): (-[WebCoreBridge scrollOverflowInDirection:granularity:]): (-[WebCoreBridge sendScrollWheelEvent:]): (-[WebCoreBridge saveDocumentToPageCache]): (-[WebCoreBridge canCachePage]): (-[WebCoreBridge clear]): (-[WebCoreBridge end]): (-[WebCoreBridge stop]): (-[WebCoreBridge handleFallbackContent]): (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreBridge scrollToAnchor:]): (-[WebCoreBridge isSelectionEditable]): (-[WebCoreBridge selectionState]): (-[WebCoreBridge _documentTypeString]): (-[WebCoreBridge selectedString]): (-[WebCoreBridge stringForRange:]): (-[WebCoreBridge selectAll]): (-[WebCoreBridge deselectAll]): (-[WebCoreBridge deselectText]): (-[WebCoreBridge isFrameSet]): (-[WebCoreBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreBridge _setupRootForPrinting:]): (-[WebCoreBridge forceLayoutAdjustingViewSize:]): (-[WebCoreBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): (-[WebCoreBridge sendResizeEvent]): (-[WebCoreBridge sendScrollEvent]): (-[WebCoreBridge drawRect:withPainter:]): (-[WebCoreBridge drawRect:]): (-[WebCoreBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreBridge adjustPageHeightNew:top:bottom:limit:]): (-[WebCoreBridge copyDOMTree:]): (-[WebCoreBridge copyRenderTree:]): (-[WebCoreBridge removeFromFrame]): (-[WebCoreBridge installInFrame:]): (-[WebCoreBridge setActivationEventNumber:]): (-[WebCoreBridge mouseDown:]): (-[WebCoreBridge mouseDragged:]): (-[WebCoreBridge mouseUp:]): (-[WebCoreBridge mouseMoved:]): (-[WebCoreBridge sendContextMenuEvent:]): (-[WebCoreBridge currentForm]): (-[WebCoreBridge searchForLabels:beforeElement:]): (-[WebCoreBridge matchLabels:againstElement:]): (-[WebCoreBridge elementAtPoint:]): (-[WebCoreBridge URLWithAttributeString:]): (-[WebCoreBridge searchFor:direction:caseSensitive:wrap:]): (-[WebCoreBridge advanceToNextMisspelling]): (-[WebCoreBridge advanceToNextMisspellingStartingJustBeforeSelection]): (-[WebCoreBridge unmarkAllMisspellings]): (-[WebCoreBridge setTextSizeMultiplier:]): (-[WebCoreBridge textEncoding]): (-[WebCoreBridge nextKeyView]): (-[WebCoreBridge previousKeyView]): (-[WebCoreBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): (-[WebCoreBridge windowScriptObject]): (-[WebCoreBridge windowScriptNPObject]): (-[WebCoreBridge DOMDocument]): (-[WebCoreBridge selectedAttributedString]): (-[WebCoreBridge attributedStringFrom:startOffset:to:endOffset:]): (-[WebCoreBridge selectionRect]): (-[WebCoreBridge visibleSelectionRect]): (-[WebCoreBridge centerSelectionInVisibleArea]): (-[WebCoreBridge selectionImage]): (-[WebCoreBridge setName:]): (-[WebCoreBridge name]): (-[WebCoreBridge URL]): (-[WebCoreBridge baseURL]): (-[WebCoreBridge referrer]): (-[WebCoreBridge domain]): (-[WebCoreBridge opener]): (-[WebCoreBridge setOpener:]): (-[WebCoreBridge needsLayout]): (-[WebCoreBridge setNeedsLayout]): (-[WebCoreBridge interceptKeyEvent:toView:]): (-[WebCoreBridge renderTreeAsExternalRepresentation]): (-[WebCoreBridge setSelectionFromNone]): (-[WebCoreBridge setDisplaysWithFocusAttributes:]): (-[WebCoreBridge setWindowHasFocus:]): (-[WebCoreBridge numPendingOrLoadingRequests]): (-[WebCoreBridge doneProcessingData]): (-[WebCoreBridge shouldClose]): (-[WebCoreBridge bodyBackgroundColor]): (-[WebCoreBridge selectionColor]): (-[WebCoreBridge adjustViewSize]): (-[WebCoreBridge accessibilityTree]): (-[WebCoreBridge setDrawsBackground:]): (-[WebCoreBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreBridge rangeByAlteringCurrentSelection:verticalDistance:]): (-[WebCoreBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreBridge selectionGranularity]): (-[WebCoreBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreBridge selectedDOMRange]): (-[WebCoreBridge convertToNSRange:DOM::]): (-[WebCoreBridge convertToDOMRange:]): (-[WebCoreBridge selectNSRange:]): (-[WebCoreBridge selectedNSRange]): (-[WebCoreBridge selectionAffinity]): (-[WebCoreBridge setMarkDOMRange:]): (-[WebCoreBridge markDOMRange]): (-[WebCoreBridge setMarkedTextDOMRange:customAttributes:ranges:]): (-[WebCoreBridge markedTextDOMRange]): (-[WebCoreBridge markedTextNSRange]): (-[WebCoreBridge replaceMarkedTextWithText:]): (-[WebCoreBridge smartDeleteRangeForProposedRange:]): (-[WebCoreBridge smartInsertForString:replacingRange:beforeString:afterString:]): (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreBridge documentFragmentWithText:]): (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreBridge insertLineBreak]): (-[WebCoreBridge insertParagraphSeparator]): (-[WebCoreBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreBridge insertText:selectInsertedText:]): (-[WebCoreBridge setSelectionToDragCaret]): (-[WebCoreBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreBridge _visiblePositionForPoint:]): (-[WebCoreBridge moveDragCaretToPoint:]): (-[WebCoreBridge removeDragCaret]): (-[WebCoreBridge dragCaretDOMRange]): (-[WebCoreBridge deleteSelectionWithSmartDelete:]): (-[WebCoreBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreBridge forwardDeleteKeyPressedWithSmartDelete:]): (-[WebCoreBridge typingStyle]): (-[WebCoreBridge setTypingStyle:withUndoAction:]): (-[WebCoreBridge applyStyle:withUndoAction:]): (-[WebCoreBridge applyParagraphStyle:withUndoAction:]): (-[WebCoreBridge selectionStartHasStyle:]): (-[WebCoreBridge selectionHasStyle:]): (-[WebCoreBridge applyEditingStyleToBodyElement]): (-[WebCoreBridge removeEditingStyleFromBodyElement]): (-[WebCoreBridge applyEditingStyleToElement:]): (-[WebCoreBridge removeEditingStyleFromElement:]): (-[WebCoreBridge fontForSelection:]): (-[WebCoreBridge fontAttributesForSelectionStart]): (-[WebCoreBridge baseWritingDirectionForSelectionStart]): (-[WebCoreBridge ensureSelectionVisible]): (-[WebCoreBridge eventMayStartDrag:]): (-[WebCoreBridge dragOperationForDraggingInfo:]): (-[WebCoreBridge dragExitedWithDraggingInfo:]): (-[WebCoreBridge concludeDragForDraggingInfo:]): (-[WebCoreBridge dragSourceMovedTo:]): (-[WebCoreBridge dragSourceEndedAt:operation:]): (-[WebCoreBridge mayDHTMLCut]): (-[WebCoreBridge mayDHTMLCopy]): (-[WebCoreBridge mayDHTMLPaste]): (-[WebCoreBridge tryDHTMLCut]): (-[WebCoreBridge tryDHTMLCopy]): (-[WebCoreBridge tryDHTMLPaste]): (-[WebCoreBridge rangeOfCharactersAroundCaret]): (-[WebCoreBridge dashboardRegions]): (-[WebCoreBridge executionContextForView:]):
  • kwq/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]):
1:01 PM Changeset in webkit [11965] by darin
  • 3 edits
    3 deletes in trunk

JavaScriptCore:

  • Makefile.am: Removed.

WebCore:

  • Makefile.am: Removed.

WebKit:

  • Makefile.am: Removed.
11:29 AM Changeset in webkit [11964] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Beth Dakin.


  • fixed <rdar://problem/4302263> CrashTracer: 504 crashes in Safari at com.apple.AppKit: NSTargetForSendAction + 1060


The problem was that back/forward/stop/reload context menu items had nil targets,
and thus were relying on AppKit to start from the context menu target (the clicked-upon
view) and use the responder chain to find the WebView to act as the target. In Tiger,
context menus don't retain their implicit target (the clicked-upon view again), and
there was a race condition where the WebHTMLView could be dealloc'ed while the menu item
was being processed, eventually crashing in AppKit. The fix is to explicitly set the
target of these four menu items to the WebView, since the WebView is not dealloc'ed
in the loading process.


This might be fixed in a future version of AppKit by making the context menu retain its
implicit target until it is dismissed, but with this change it will be fixed regardless
of potential AppKit changes.

  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:]): Added target: parameter and removed code that set the target for some menu items; now the caller is responsible for supplying the target. (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): Supply target (or nil) in calls to menuItemWithTag:target:. This matches existing behavior except for Back/Forward/Stop/Reload, which used to supply no target but now supply the WebView as the target. (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Supply target (or nil) in calls to menuItemWithTag:target:
10:35 AM Changeset in webkit [11963] by ggaren
  • 4 edits
    5 adds in trunk

LayoutTests:

Layout tests for

<rdar://problem/4268278> Submitting a form in onUnload event handler
causes crash in -[WebDataSource(WebPrivate) _commitIfReady:].)

and

  • fast/loader/form-events-back-forward-expected.txt: Added.
  • fast/loader/form-events-back-forward.html: Added.
  • fast/loader/onunload-form-submit-crash-expected.txt: Added.
  • fast/loader/onunload-form-submit-crash.html: Added.
  • fast/loader/resources/onunload-form-submit-crash2.html: Added.

WebKit:

Reviewed by Darin.


  • Second cut at fixing <rdar://problem/4268278> Submitting a form in onUnload event handler causes crash in -[WebDataSource(WebPrivate) _commitIfReady:].)


  • WebView.subproj/WebDataSource.m: (-[WebDataSource _stopLoading]): (1) If there are no resource loaders to signal the WebView that we've been canceled, manufacture the signal. Otherwise, the cancel gets ignored and nobody cleans up after the load. (We signal the WebView but not the WebFrame because we don't want the WebFrame to tear down the DataSource. Unlike most canceled DataSources, this one has valid data because it's in the back/forward cache.) (2) Update _private->stopping before returning because if the DataSource is in the back/forward cache it can be reused, so it needs to be in a consistent state. (We never encountered this situation before because we would always crash first.) (-[WebDataSource _commitLoadWithData:]): Move _commitIfReady call inside retain block because the commit may cause an unload event to fire, which may start a new load, deallocating the current DataSource. (This is the same reason the rest of the function is in the retain block.)
  • WebView.subproj/WebFrame.m: (-[WebFrame _transitionToCommitted:]): If the unload handler started a new load, return early to avoid stomping it. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Undo previous incorrect fix. (-[WebFrame stopLoading]): Remove misleading comment. Setting provisionalDataSource to nil is not optional but required for internal consistency.
8:52 AM Changeset in webkit [11962] by thatcher
  • 15987 edits in trunk

Removes svn:keywords from all files.

7:05 AM Changeset in webkit [11961] by sullivan
  • 2 edits in trunk/WebCore
  • khtml/misc/decoder.cpp: removed #include of recently-removed kcharsets.h to fix build
5:20 AM Changeset in webkit [11960] by eseidel
  • 357 edits
    15 adds in trunk/LayoutTests

2006-01-09 Alexander Kellett <lypanov@kde.org>

Reviewed by eseidel. Committed by eseidel

Updated results for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=5748
Also committed several missing results.

  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.png:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.png:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.checksum:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.png:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.png:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.checksum:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.png:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.png:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.png:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.png:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.png:
  • svg/custom/conditional-processing-outside-switch-expected.png: Added.
  • svg/custom/control-points-for-S-and-T-expected.checksum:
  • svg/custom/control-points-for-S-and-T-expected.png: Added.
  • svg/custom/fill-update-expected.png: Added.
  • svg/custom/fractional-rects-expected.checksum:
  • svg/custom/grayscale-gradient-mask-expected.png: Added.
  • svg/custom/grayscale-gradient-mask-expected.txt:
  • svg/custom/junk-data-expected.checksum: Added.
  • svg/custom/junk-data-expected.png: Added.
  • svg/custom/path-bad-data-expected.png: Added.
  • svg/custom/path-update-expected.png: Added.
  • svg/custom/rounded-rects-expected.png: Added.
  • svg/custom/simpleCDF-expected.png: Added.
  • svg/custom/transform-ignore-after-invalid-expected.png: Added.
  • svg/custom/transform-invalid-expected.png: Added.
  • svg/custom/transform-with-ending-space-expected.png: Added.
  • svg/custom/use-forward-refs-expected.png: Added.
5:07 AM Changeset in webkit [11959] by eseidel
  • 14 edits in trunk/WebCore

2006-01-08 Alexander Kellett <lypanov@kde.org>

Reviewed by eseidel. Committed by eseidel.

First set of refactors to fix
http://bugzilla.opendarwin.org/show_bug.cgi?id=5748.

Refactors to delay paintserver creation until usage and thereby
simplify much code in the process. Causes several changes in rendertree
output all of which are improvements rather than regressions.

  • kcanvas/KCanvasItem.cpp: setupForDraw() logic moved to KCanvasItemQuartz
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasResources.cpp: (KCanvasResource::addClient): const-ify
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle): minor refactor/inline - keeps most output the same after patch, some minor const'ifications
  • kcanvas/device/KRenderingFillPainter.cpp: setter (KRenderingFillPainter::Private::Private):
  • kcanvas/device/KRenderingFillPainter.h: refactor out paintserver and draw()
  • kcanvas/device/KRenderingStrokePainter.cpp: refactor out paintserver and draw() (KRenderingStrokePainter::Private::Private):
  • kcanvas/device/KRenderingStrokePainter.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): (KCanvasItemQuartz::hitsPath):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KCanvasRenderingStyle::KCanvasRenderingStyle): (KCanvasRenderingStyle::~KCanvasRenderingStyle): (KCanvasRenderingStyle::overrideFillPaintServer): (KCanvasRenderingStyle::isFilled): (KCanvasRenderingStyle::fillPaintServer): (KCanvasRenderingStyle::overrideStrokePaintServer): (KCanvasRenderingStyle::isStroked): (KCanvasRenderingStyle::strokePaintServer): (KCanvasRenderingStyle::updateStyle): remove paintserver constructions from update notification and instead create on usage, removing disable.*Painter() methods
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::notifyFinished): use paintserver override logic
4:58 AM Changeset in webkit [11958] by ap
  • 2 edits in trunk/WebCore

Fix broken build (CachedObject.cpp was still including kcharsets.h).
Proposed and reviewed by Eric Seidel.

4:29 AM Changeset in webkit [11957] by eseidel
  • 15 edits
    2 adds
    16 deletes in trunk/WebCore

Reviewed by mjs.

Remove more unused code from kwq.

  • ForwardingHeaders/dcopclient.h: Removed.
  • ForwardingHeaders/kaction.h: Removed.
  • ForwardingHeaders/kcharsets.h: Removed.
  • ForwardingHeaders/kcombobox.h: Removed.
  • ForwardingHeaders/klineedit.h: Removed.
  • ForwardingHeaders/klistbox.h: Removed.
  • ForwardingHeaders/kwin.h: Removed.
  • ForwardingHeaders/qcombobox.h: Added.
  • ForwardingHeaders/qlineedit.h: Added.
  • WebCore.xcodeproj/project.pbxproj: remove files.
  • khtml/css/csshelper.cpp:
  • khtml/css/cssstyleselector.cpp:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_formimpl.cpp: (DOM::HTMLOptionElementImpl::index): (DOM::HTMLOptionElementImpl::setIndex):
  • khtml/html/htmltokenizer.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/khtml_part.cpp:
  • khtml/khtmlpart_p.h:
  • khtml/rendering/render_form.cpp: (RenderLineEdit::RenderLineEdit): (RenderLineEdit::setStyle): (RenderLineEdit::updateFromElement): (RenderLineEdit::selectionStart): (RenderLineEdit::selectionEnd): (RenderLineEdit::setSelectionStart): (RenderLineEdit::setSelectionEnd): (RenderLineEdit::select): (RenderLineEdit::setSelectionRange): (ComboBoxWidget::ComboBoxWidget): (ComboBoxWidget::event): (ComboBoxWidget::eventFilter): (RenderSelect::setWidgetWritingDirection): (RenderSelect::updateFromElement): (RenderSelect::layout): (RenderSelect::slotSelectionChanged): (RenderSelect::createListBox): (RenderSelect::updateSelection): (RenderTextArea::RenderTextArea):
  • khtml/rendering/render_form.h: (khtml::RenderLineEdit::widget):
  • kwq/KWQDCOPClient.h: Removed.
  • kwq/KWQKCharsets.cpp: Removed.
  • kwq/KWQKCharsets.h: Removed.
  • kwq/KWQKComboBox.h: Removed.
  • kwq/KWQKKAction.h: Removed.
  • kwq/KWQKLineEdit.h: Removed.
  • kwq/KWQKListBox.h: Removed.
  • kwq/KWQKWin.cpp: Removed.
  • kwq/KWQKWin.h: Removed.
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm:
3:41 AM Changeset in webkit [11956] by eseidel
  • 21 edits
    11 deletes in trunk/WebCore

Reviewed by mjs.

Removing more unused parts of KWQ.

  • ForwardingHeaders/java/kjavaappletcontext.h: Removed.
  • ForwardingHeaders/khtml_find.h: Removed.
  • ForwardingHeaders/qimage.h: Removed.
  • ForwardingHeaders/rendering/break_lines.h: Removed.
  • ForwardingHeaders/rendering/render_text.h: Removed.
  • ForwardingHeaders/xbl/xbl_docimpl.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::~KHTMLPart): (KHTMLPart::clear):
  • khtml/khtml_part.h:
  • khtml/khtmlpart_p.h: (KHTMLPartPrivate::KHTMLPartPrivate): (KHTMLPartPrivate::~KHTMLPartPrivate):
  • khtml/rendering/render_applet.cpp: (RenderApplet::RenderApplet): (RenderApplet::createWidgetIfNecessary):
  • khtml/rendering/render_applet.h:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • kwq/DOMHTML.mm:
  • kwq/KWQDummyView.h: Removed.
  • kwq/KWQDummyView.m: Removed.
  • kwq/KWQImage.h: Removed.
  • kwq/KWQKHTMLFind.h: Removed.
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQKHTMLPartBrowserExtension.h:
  • kwq/KWQKJavaAppletContext.h: Removed.
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • kwq/KWQKPartsBrowserExtension.h:
  • kwq/KWQObject.h:
  • kwq/KWQRegion.h:
2:57 AM Changeset in webkit [11955] by mjs
  • 8 edits in trunk/LayoutTests
  • fix layout tests that I broke
  • fast/forms/button-in-forms-collection.html:
  • fast/js/date-parse-comments-test-expected.txt:
  • fast/js/date-parse-test-expected.txt:
  • fast/js/kde/Date-expected.txt:
  • fast/js/kde/resources/Date.js:
  • fast/js/resources/date-parse-comments-test.js:
  • fast/js/resources/date-parse-test.js:
2:11 AM Changeset in webkit [11954] by ap
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

Affects many layout tests (when running with primary Russian language).

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Use glyphForCharacter() instead of -[NSFont glyphWithName:].
1:29 AM Changeset in webkit [11953] by eseidel
  • 43 edits
    22 copies
    1 delete in trunk/WebCore

Rubber stamped by mjs.

Broke out loader.{h,cpp} into multiple files, one per class.
This patch also updates all files which previously included
loader.h to only include the necessary renamed headers.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6444

  • ForwardingHeaders/kdom/cache/KDOMCachedDocument.h: Removed.
  • ForwardingHeaders/kdom/cache/KDOMCachedImage.h: updated include
  • ForwardingHeaders/kdom/cache/KDOMCachedObject.h: updated include
  • ForwardingHeaders/kdom/cache/KDOMCachedScript.h: updated include
  • WebCore.xcodeproj/project.pbxproj: added files
  • khtml/css/css_computedstyle.cpp: updated includes
  • khtml/css/css_ruleimpl.cpp: updated includes
  • khtml/css/css_stylesheetimpl.h: updated includes
  • khtml/css/css_valueimpl.cpp: updated includes
  • khtml/css/cssstyleselector.cpp: updated includes
  • khtml/ecma/kjs_events.cpp: updated includes
  • khtml/ecma/kjs_html.cpp: updated includes
  • khtml/ecma/xmlhttprequest.cpp: updated includes
  • khtml/html/html_headimpl.cpp: updated includes
  • khtml/html/html_imageimpl.cpp: updated includes
  • khtml/html/html_imageimpl.h: updated includes
  • khtml/html/htmltokenizer.cpp: updated includes
  • khtml/khtml_part.cpp: updated includes
  • khtml/khtmlview.cpp: updated includes
  • khtml/misc/Cache.cpp: Added.
  • khtml/misc/Cache.h: Added.
  • khtml/misc/CachedCSSStyleSheet.cpp: Added.
  • khtml/misc/CachedCSSStyleSheet.h: Added.
  • khtml/misc/CachedImage.cpp: Added.
  • khtml/misc/CachedImage.h: Added.
  • khtml/misc/CachedImageCallback.cpp: Added.
  • khtml/misc/CachedImageCallback.h: Added.
  • khtml/misc/CachedObject.cpp: Added.
  • khtml/misc/CachedObject.h: Added, fixed tabs -> spaces.
  • khtml/misc/CachedObjectClientWalker.cpp: Added.
  • khtml/misc/CachedObjectClientWalker.h: Added.
  • khtml/misc/CachedScript.cpp: Added.
  • khtml/misc/CachedScript.h: Added.
  • khtml/misc/CachedXBLDocument.cpp: Added.
  • khtml/misc/CachedXBLDocument.h: Added.
  • khtml/misc/CachedXSLStyleSheet.cpp: Added.
  • khtml/misc/CachedXSLStyleSheet.h: Added.
  • khtml/misc/DocLoader.cpp: Added.
  • khtml/misc/DocLoader.h: Added.
  • khtml/misc/Request.cpp: Added.
  • khtml/misc/Request.h: Added.
  • khtml/misc/loader.cpp: updated includes
  • khtml/misc/loader.h: updated includes
  • khtml/misc/loader_client.h: updated includes
  • khtml/rendering/render_box.cpp: updated includes
  • khtml/rendering/render_line.cpp: updated includes
  • khtml/rendering/render_list.cpp: updated includes
  • khtml/rendering/render_object.cpp: updated includes
  • khtml/xml/dom_docimpl.cpp: updated includes
  • khtml/xml/dom_xmlimpl.cpp: updated includes
  • khtml/xml/xml_tokenizer.cpp: updated includes
  • khtml/xsl/xsl_stylesheetimpl.cpp: updated includes
  • khtml/xsl/xsl_stylesheetimpl.h: updated includes
  • khtml/xsl/xslt_processorimpl.cpp: updated includes
  • ksvg2/svg/SVGCursorElementImpl.cpp: updated includes
  • ksvg2/svg/SVGDocumentImpl.cpp: updated includes
  • ksvg2/svg/SVGFEImageElementImpl.cpp: updated includes
  • ksvg2/svg/SVGImageElementImpl.cpp: updated includes
  • ksvg2/svg/SVGImageElementImpl.h: updated includes
  • kwq/KWQKHTMLPart.mm: updated includes
  • kwq/KWQLoader.mm: updated includes
  • kwq/KWQPixmap.mm: updated includes
  • kwq/KWQTextArea.mm: updated includes
  • kwq/WebCoreBridge.mm: updated includes
  • kwq/WebCoreCache.mm: updated includes
12:59 AM Changeset in webkit [11952] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Maciej.

Test case: fast/frames/frameElement-widthheight.html

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::frameGetter):
  • khtml/ecma/kjs_html.h: Add FrameWidth, FrameHeight
  • khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::frameWidth): (HTMLFrameElementImpl::frameHeight):
  • khtml/html/html_baseimpl.h: Add frameWidth, frameHeight
12:42 AM Changeset in webkit [11951] by ap
  • 3 edits
    4 adds in trunk

Reviewed by Maciej, landed by ap.


Test: fast/replaced/inline-box-wrapper-handover.html



  • khtml/rendering/render_line.cpp: (khtml::InlineBox::deleteLine): Don't reset the inline box wrapper when deleting an extracted box.
12:37 AM Changeset in webkit [11950] by ap
  • 3 adds in trunk/LayoutTests

Re-added the files

12:36 AM Changeset in webkit [11949] by ap
  • 1 edit
    3 deletes in trunk/LayoutTests

Reviewed by Eric.


  • Updated tests broken by SVN conversion (CR/LF translation)


  • fast/encoding/utf-16-big-endian.html:
  • fast/encoding/utf-16-little-endian.html:
  • css1/text_properties/text-transCapitalize.html:
Note: See TracTimeline for information about the timeline view.