Context Navigation

(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.

ForwardingHeaders/kdom/css: Removed.
ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
WebCore+SVG/RGBColorImpl.cpp:
WebCore.xcodeproj/project.pbxproj:
css: Added.
css/css_base.cpp: Added.
css/css_base.h: Added.
css/css_computedstyle.cpp: Added.
css/css_computedstyle.h: Added.
css/css_grammar.y: Added.
css/css_ruleimpl.cpp: Added.
css/css_ruleimpl.h: Added.
css/css_stylesheetimpl.cpp: Added.
css/css_stylesheetimpl.h: Added.
css/css_valueimpl.cpp: Added.
css/css_valueimpl.h: Added.
css/csshelper.cpp: Added.
css/csshelper.h: Added.
css/cssparser.cpp: Added.
css/cssparser.h: Added.
css/cssproperties.in: Added.
css/cssstyleselector.cpp: Added.
css/cssstyleselector.h: Added.
css/cssvalues.in: Added.
css/html4.css: Added.
css/makeprop: Added.
css/maketokenizer: Added.
css/makevalues: Added.
css/quirks.css: Added.
css/tokenizer.flex: Added.
khtml/css: Removed.
khtml/css/css_base.cpp: Removed.
khtml/css/css_base.h: Removed.
khtml/css/css_computedstyle.cpp: Removed.
khtml/css/css_computedstyle.h: Removed.
khtml/css/css_grammar.y: Removed.
khtml/css/css_ruleimpl.cpp: Removed.
khtml/css/css_ruleimpl.h: Removed.
khtml/css/css_stylesheetimpl.cpp: Removed.
khtml/css/css_stylesheetimpl.h: Removed.
khtml/css/css_valueimpl.cpp: Removed.
khtml/css/css_valueimpl.h: Removed.
khtml/css/csshelper.cpp: Removed.
khtml/css/csshelper.h: Removed.
khtml/css/cssparser.cpp: Removed.
khtml/css/cssparser.h: Removed.
khtml/css/cssproperties.in: Removed.
khtml/css/cssstyleselector.cpp: Removed.
khtml/css/cssstyleselector.h: Removed.
khtml/css/cssvalues.in: Removed.
khtml/css/html4.css: Removed.
khtml/css/makeprop: Removed.
khtml/css/maketokenizer: Removed.
khtml/css/makevalues: Removed.
khtml/css/quirks.css: Removed.
khtml/css/tokenizer.flex: Removed.
ksvg2/css/SVGCSSStyleSelector.cpp:
ksvg2/ecma/Ecma.cpp:
ksvg2/misc/KCanvasRenderingStyle.cpp:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGClipPathElementImpl.cpp:
ksvg2/svg/SVGColorImpl.cpp:
ksvg2/svg/SVGColorImpl.h:
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGElementImpl.cpp:
ksvg2/svg/SVGGradientElementImpl.cpp:
ksvg2/svg/SVGMaskElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.cpp:
ksvg2/svg/SVGStyledElementImpl.h:
ksvg2/svg/SVGTextElementImpl.cpp:

9:41 PM Changeset in webkit [12143] by thatcher

2 edits in trunk/WebKit

Rubber stamped by Maciej.

Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.

WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]):

6:37 PM Changeset in webkit [12142] by eseidel

1 edit
4 adds in trunk/LayoutTests

2006-01-16 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

A proactive test case to prevent crashes in recursive clippath defs

svg/custom/recursive-clippath-expected.checksum: Added.
svg/custom/recursive-clippath-expected.png: Added.
svg/custom/recursive-clippath-expected.txt: Added.
svg/custom/recursive-clippath.svg: Added.

6:20 PM Changeset in webkit [12141] by ggaren

3 edits
3 adds in trunk

JavaScriptCore:

Reviewed by darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6322 DateProtoFuncImp::callAsFunction can crash due to lack of type checking

kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Type check calls to all methods. This matches section 15.9.5 in the spec.

LayoutTests:

Added layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6322 DateProtoFuncImp::callAsFunction can crash due to lack of type checking

fast/js/date-proto-generic-invocation-expected.txt: Added.
fast/js/date-proto-generic-invocation.html: Added.
fast/js/resources/date-proto-generic-invocation.js: Added.

4:35 PM Changeset in webkit [12140] by hyatt

2 edits
22 moves
3 adds in trunk/WebCore

Move the Objective-C dom bindings from kwq to bindings/objc.

Reviewed by eseidel

WebCore.xcodeproj/project.pbxproj:
bindings: Added.
bindings/js: Added.
bindings/objc: Added.
bindings/objc/DOM.h: Added.
bindings/objc/DOM.mm: Added.
bindings/objc/DOMCSS.h: Added.
bindings/objc/DOMCSS.mm: Added.
bindings/objc/DOMCore.h: Added.
bindings/objc/DOMEvents.h: Added.
bindings/objc/DOMEvents.mm: Added.
bindings/objc/DOMEventsInternal.h: Added.
bindings/objc/DOMExtensions.h: Added.
bindings/objc/DOMHTML.h: Added.
bindings/objc/DOMHTML.mm: Added.
bindings/objc/DOMHTMLInternal.h: Added.
bindings/objc/DOMInternal.h: Added.
bindings/objc/DOMInternal.mm: Added.
bindings/objc/DOMPrivate.h: Added.
bindings/objc/DOMRange.h: Added.
bindings/objc/DOMStylesheets.h: Added.
bindings/objc/DOMTraversal.h: Added.
bindings/objc/DOMUtility.mm: Added.
bindings/objc/DOMViews.h: Added.
bindings/objc/DOMViews.mm: Added.
bindings/objc/DOMViewsInternal.h: Added.
kwq/DOM-CSS.mm: Removed.
kwq/DOM.h: Removed.
kwq/DOM.mm: Removed.
kwq/DOMCSS.h: Removed.
kwq/DOMCore.h: Removed.
kwq/DOMEvents.h: Removed.
kwq/DOMEvents.mm: Removed.
kwq/DOMEventsInternal.h: Removed.
kwq/DOMExtensions.h: Removed.
kwq/DOMHTML.h: Removed.
kwq/DOMHTML.mm: Removed.
kwq/DOMHTMLInternal.h: Removed.
kwq/DOMInternal.h: Removed.
kwq/DOMInternal.mm: Removed.
kwq/DOMPrivate.h: Removed.
kwq/DOMRange.h: Removed.
kwq/DOMStylesheets.h: Removed.
kwq/DOMTraversal.h: Removed.
kwq/DOMUtility.mm: Removed.
kwq/DOMViews.h: Removed.
kwq/DOMViews.mm: Removed.
kwq/DOMViewsInternal.h: Removed.

3:43 PM Changeset in webkit [12139] by andersca

1 edit in trunk/WebKit/ChangeLog

Fix bugzilla url

3:41 PM Changeset in webkit [12138] by andersca

4 edits in trunk/WebKit

2006-01-17 Anders Carlsson <andersca@mac.com>

Reviewed by Timothy Hatcher.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5367 Web Inspector: finish node attributes

WebInspector.subproj/webInspector/inspector.css:
WebInspector.subproj/webInspector/inspector.html:
WebInspector.subproj/webInspector/inspector.js: Add initial support for element attributes.

2:25 PM Changeset in webkit [12137] by sullivan

2 edits in trunk/WebKit

Reviewed by Vicki Murley.

fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, Jump to Selection doesn't beep

WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hasInsertionPoint]): new helper method (-[NSArray validateUserInterfaceItem:]): Don't validate this menu item (or a couple of others) if the selection is a caret and the page isn't editable. In that state, there is no visible selection so this menu item doesn't make sense. I suspect this was broken by some editing-related change that makes selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.

2:01 PM Changeset in webkit [12136] by ap

4 edits
1 add in trunk/WebCore

Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6473 REGRESSION: Serious painting problems on new iLife and iWorks pages

khtml/css/css_grammar.y: (DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to opacity and border-radius, respectively.
khtml/rendering/render_box.cpp: (RenderBox::setStyle): Set the object's layer to 0 before removing the layer, to allow child layers to update their positions correctly.
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children of the layer being removed.
manual-tests/bugzilla-6473.html: Added.

1:46 PM Changeset in webkit [12135] by ap

2 edits in trunk/WebCore

Patch by Mark Rowe. Reviewed by Darin, landed by ap.

Fix typo in CSSPrimitiveValueImpl::setStringValue.

khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.

12:34 PM Changeset in webkit [12134] by ap

3 edits
2 adds in trunk

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5401 [WebCoreBridge firstRectForDOMRange:] works incorrectly for the first character after a line wrap

Test: editing/input/wrapped-line-char-rect.html

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]): Use DOWNSTREAM affinity for the range start

12:25 PM Changeset in webkit [12133] by justing

1 edit
12 adds in trunk/LayoutTests

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

editing/selection/replaced-boundaries-1-expected.checksum: Added.
editing/selection/replaced-boundaries-1-expected.png: Added.
editing/selection/replaced-boundaries-1-expected.txt: Added.
editing/selection/replaced-boundaries-1.html: Added.
editing/selection/replaced-boundaries-2-expected.checksum: Added.
editing/selection/replaced-boundaries-2-expected.png: Added.
editing/selection/replaced-boundaries-2-expected.txt: Added.
editing/selection/replaced-boundaries-2.html: Added.
editing/selection/replaced-boundaries-3-expected.checksum: Added.
editing/selection/replaced-boundaries-3-expected.png: Added.
editing/selection/replaced-boundaries-3-expected.txt: Added.
editing/selection/replaced-boundaries-3.html: Added.

12:24 PM Changeset in webkit [12132] by justing

4 edits in trunk/WebCore

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.

khtml/rendering/render_image.cpp: (RenderImage::paint):
khtml/rendering/render_replaced.cpp: (WebCore::RenderReplaced::isSelected): (WebCore::RenderWidget::paint):
khtml/rendering/render_replaced.h:

12:04 PM Changeset in webkit [12131] by tomernic

7 edits in trunk

Fixed <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

9:56 AM Changeset in webkit [12130] by darin

2 edits
4 deletes in trunk/WebCore

actually removed QPtrDict itself

ForwardingHeaders/qptrdict.h: Removed.
WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
kwq/KWQPtrDict.h: Removed.
kwq/KWQPtrDictImpl.cpp: Removed.
kwq/KWQPtrDictImpl.h: Removed.

9:52 AM Changeset in webkit [12129] by darin

83 edits in trunk/WebCore

Reviewed by John Sullivan.

removed all uses of QPtrDict, most uses of QMap

khtml/ecma/kjs_dom.cpp: Converted tabs to spaces. (KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
khtml/ecma/kjs_events.cpp: Converted tabs to spaces. (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap. (KJS::JSEventListener::JSEventListener): Use HashMap. (KJS::JSLazyEventListener::parseCode): Use HashMap.
khtml/ecma/kjs_html.cpp: Convert tabs to spaces. (KJS::KJS::HTMLElement::classInfo): Use HashMap.
khtml/ecma/kjs_window.cpp: Convert tabs to spaces. (KJS::Window::~Window): Use HashMap. (KJS::Window::getJSEventListener): Ditto. (KJS::Window::getJSUnprotectedEventListener): Ditto. (KJS::WindowQObject::parentDestroyed): Ditto. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerEvent): Ditto.
khtml/ecma/kjs_window.h: Use HashMap.
khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces. (KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set. (KJS::XMLHttpRequest::addToRequestsByDocument): Ditto. (KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto. (KJS::XMLHttpRequest::cancelRequests): Ditto.
khtml/ecma/xmlhttprequest.h: Ditto.
khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): Use HashMap. (RenderCanvas::setSelection): Ditto.
khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
khtml/rendering/render_object.h: Used HashSet. Converted tabs to spaces and did namespace changes too.
khtml/xml/DocumentImpl.cpp: (DocumentImpl::DocumentImpl): Use HashSet and HashMap. (DocumentImpl::~DocumentImpl): Ditto. (DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto. (DocumentImpl::addImageMap): Ditto. (DocumentImpl::removeImageMap): Ditto. (DocumentImpl::getImageMap): Ditto. (DocumentImpl::addMarker): Ditto. (DocumentImpl::copyMarkers): Ditto. (DocumentImpl::removeMarkers): Ditto. (DocumentImpl::markersForNode): Ditto. (DocumentImpl::shiftMarkers): Ditto. (DocumentImpl::radioButtonChecked): Ditto. (DocumentImpl::checkedRadioButtonForGroup): Ditto. (DocumentImpl::removeRadioButtonGroup): Ditto.
khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList): Use HashSet. (WebCore::NodeImpl::unregisterNodeList): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have to include NodeListImpl.h in the header.
khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeKey): Added. Hash table key. (WebCore::MappedAttributeKeyTraits): Added. Hash table key traits. (WebCore::MappedAttributeHash): Added. Hash function. (WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap. (WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto. (WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto. (WebCore::MappedAttributeHash::hash): Added. Hash function.
khtml/xml/dom_elementimpl.h: Use HashMap.

khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling to use AtomicString.
khtml/html/html_imageimpl.h: (WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.

khtml/dom/dom_string.h: Added a default argument to substring, also reduced includes and updated namespace.
khtml/xml/dom_stringimpl.h: Ditto.

bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace. Updated includes for header changes.
kcanvas/RenderForeignObject.cpp: Ditto.
kcanvas/RenderForeignObject.h: Ditto.
kcanvas/RenderSVGImage.h: Ditto.
kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
khtml/css/css_ruleimpl.cpp: Ditto.
khtml/css/css_valueimpl.h: Ditto.
khtml/ecma/kjs_dom.h: Ditto.
khtml/ecma/kjs_html.h: Ditto.
khtml/editing/composite_edit_command.cpp: Ditto.
khtml/editing/delete_selection_command.cpp: Ditto.
khtml/html/html_tableimpl.cpp: Ditto.
khtml/khtml_events.cpp: Ditto.
khtml/rendering/RenderText.cpp: Ditto.
khtml/rendering/render_block.cpp: Ditto.
khtml/rendering/render_br.cpp: Ditto.
khtml/rendering/render_inline.cpp: Ditto.
khtml/rendering/render_object.cpp: Ditto.
khtml/rendering/render_replaced.cpp: Ditto.
khtml/xml/dom2_rangeimpl.cpp: Ditto.
kwq/DOM.mm: Ditto.
page/Frame.cpp: Ditto.

kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a constant moved into the WebCore namespace.
kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
kcanvas/RenderSVGText.h: Ditto.
kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): Ditto. (KCanvasItemQuartz::nodeAtPoint): Ditto.
kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): Ditto.

khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.

khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
khtml/xml/dom_xmlimpl.h: Ditto.

ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
ksvg2/svg/SVGPointImpl.cpp: Ditto.

kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb (now in qcolor.h). Also converted tabs to spaces.

kwq/KWQPainter.h: Added newly-needed include.

kwq/KWQPtrVector.h: Added append function.
kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
kwq/KWQVectorImpl.h: Added append.

kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.

kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
kwq/KWQWMatrix.h: Ditto.

loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.

loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
loader/CachedCSSStyleSheet.h: Ditto.
loader/CachedImage.cpp: Ditto.
loader/CachedImage.h: Ditto.
loader/CachedImageCallback.cpp: Ditto.
loader/CachedObject.cpp: Ditto.
loader/CachedObject.h: Ditto.
loader/CachedObjectClient.h: Ditto.
loader/CachedObjectClientWalker.cpp: Ditto.
loader/CachedObjectClientWalker.h: Ditto.
loader/CachedScript.cpp: Ditto.
loader/CachedScript.h: Ditto.
loader/CachedXSLStyleSheet.cpp: Ditto.

loader/loader.cpp: (WebCore::Loader::Loader): Changed to use HashMap. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::slotFinished): Ditto. (WebCore::Loader::slotReceivedResponse): Ditto. (WebCore::Loader::slotData): Ditto. (WebCore::Loader::numRequests): Ditto. (WebCore::Loader::cancelRequests): Ditto. (WebCore::Loader::jobForRequest): Ditto.
loader/loader.h: Ditto.

1:03 AM Changeset in webkit [12128] by eseidel

5 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Remove usage of Tahoma font. (previous commit was incomplete)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6569

fast/box-sizing/percentage-height-expected.checksum:
fast/box-sizing/percentage-height-expected.png:
fast/box-sizing/percentage-height-expected.txt:
fast/box-sizing/percentage-height.html:

12:49 AM Changeset in webkit [12127] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

fix problem with ++, ==, and != on const iterators in HashMaps that are using the pointer specialization

kxmlcore/HashMapPtrSpec.h: (KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator. (KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto. (KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.

12:30 AM Changeset in webkit [12126] by darin

2 edits in trunk/WebCore

WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match where it is in the source tree.

12:05 AM Changeset in webkit [12125] by andersca

2 edits in trunk/WebKit

2006-01-16 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

WebInspector.subproj/webInspector/inspector.js: Use defined NodeType values instead of integers.

Jan 15, 2006:

11:50 PM Changeset in webkit [12124] by eseidel

3 edits in trunk/LayoutTests

2006-01-15 Eric Seidel <eseidel@apple.com>

Update out-of-date pixel results.

fast/dom/dom-parse-serialize-expected.checksum:
fast/dom/dom-parse-serialize-expected.png:

6:45 PM Changeset in webkit [12123] by thatcher

3 edits in trunk/LayoutTests

Reviewed by Darin.

fast/box-sizing/percentage-height-expected.txt:
fast/box-sizing/percentage-height.html:

6:42 PM Changeset in webkit [12122] by thatcher

24 edits
38 adds in trunk

WebCore:

Reviewed by Darin.

Support for the new DOM Inspector.

khtml/ecma/kjs_dom.cpp: exposes scrollIntoViewIfNeeded to JS
khtml/ecma/kjs_dom.h:
khtml/rendering/RenderText.cpp: (RenderText::lineBoxRects): returns text run rects
khtml/rendering/RenderText.h:
khtml/rendering/render_container.cpp: (RenderContainer::lineBoxRects): returns all child line box rects
khtml/rendering/render_container.h:
khtml/rendering/render_object.cpp: (RenderObject::lineBoxRects): returns an empty list
khtml/rendering/render_object.h:
khtml/xml/dom_elementimpl.cpp: (ElementImpl::scrollIntoViewIfNeeded): scrolls only if needed, bool decides to center to align to nearest edge
khtml/xml/dom_elementimpl.h: Ditto
kwq/DOM.mm: (-[DOMNode boundingBox]): returns the bounding box for a node (-[DOMNode lineBoxRects]): returns text runs for a node
kwq/DOMCore.h: added missing @protocol DOMEventListener and @class DOMEvent
kwq/DOMExtensions.h: removes methods that haven't been API reviewed
kwq/DOMPrivate.h: new pending public API added for the Inspector

WebKit:

Reviewed by Darin.

New DOM Inspector that lives in WebKit and is accessible from any WebView.
Accessible from a contextual menu when the WebKitEnableInspectElementContextMenuItem default is
true or you have a development build. Browsing the tree, serialized HTML and CSS rules work.

To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true

http://bugzilla.opendarwin.org/show_bug.cgi?id=6571

English.lproj/Localizable.strings:
English.lproj/StringsNotToBeLocalized.txt: reorder of the entries
Misc.subproj/WebKitNSStringExtras.h:
Misc.subproj/WebKitNSStringExtras.m: (-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): collapses consecutive whitespace into a single space
WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): cleanup (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): call the new UI delegate method
WebInspector.subproj: Added.
WebInspector.subproj/WebInspector.h: Added.
WebInspector.subproj/WebInspector.m: Added. (+sharedWebInspector): (-init): (-initWithWebFrame:): (-dealloc): (-window): (-windowDidLoad): (-windowWillClose:): (-showWindow:): (-setWebFrame:): (-webFrame): (-setRootDOMNode:): (-rootDOMNode): (-setFocusedDOMNode:): (-focusedDOMNode): (-setSearchQuery:): (-searchQuery): (-searchResults): (-showOptionsMenu): (-selectNewRoot:): (-resizeTopArea:): (-treeViewScrollTo:): (-treeViewOffsetTop): (-treeViewScrollHeight): (-traverseTreeBackward): (-traverseTreeForward): (-_toggleIgnoreWhitespace:): (-_highlightNode:): (-_nodeHighlightExpired:): (-_focusRootNode:): (-_revealAndSelectNodeInTree:): (-_showSearchResults:): (-_refreshSearch): (-_update): (-_updateRoot): (-_updateTreeScrollbar): (+isSelectorExcludedFromWebScript:): (+webScriptNameForSelector:): (+isKeyExcludedFromWebScript:): (-handleEvent:): (-webView:didFinishLoadForFrame:): (-webView:plugInViewWithArguments:): (-outlineView:numberOfChildrenOfItem:): (-outlineView:isItemExpandable:): (-outlineView:child:ofItem:): (-outlineView:objectValueForTableColumn:byItem:): (-outlineView:willDisplayOutlineCell:forTableColumn:item:): (-outlineViewItemDidCollapse:): (-outlineViewSelectionDidChange:): (-[WebInspectorPrivate dealloc]): (-[DOMHTMLElement _addClassName:]): Helper method for the Inspector to append style classes (-[DOMHTMLElement _removeClassName:]): Helper method for the Inspector to remove style classes (-[DOMNode _contentPreview]): (-[DOMNode _isAncestorOfNode:]): (-[DOMNode _isDescendantOfNode:]): (-[DOMNode _isWhitespace]): (-[DOMNode _lengthOfChildNodesIgnoringWhitespace]): (-[DOMNode _childNodeAtIndexIgnoringWhitespace:]): (-[DOMNode _nextSiblingSkippingWhitespace]): (-[DOMNode _previousSiblingSkippingWhitespace]): (-[DOMNode _firstChildSkippingWhitespace]): (-[DOMNode _lastChildSkippingWhitespace]): (-[DOMNode _firstAncestorCommonWithNode:]): (-[DOMNode _traverseNextNodeStayingWithin:]): (-[DOMNode _traverseNextNodeSkippingWhitespaceStayingWithin:]): (-[DOMNode _traversePreviousNode]): (-[DOMNode _traversePreviousNodeSkippingWhitespace]): (-[DOMNode _nodeTypeName]): (-[DOMNode _shortDisplayName]): (-[DOMNode _displayName]):
WebInspector.subproj/WebInspectorInternal.h: Added.
WebInspector.subproj/WebInspectorOutlineView.h: Added.
WebInspector.subproj/WebInspectorOutlineView.m: Added. (-[WebInspectorOutlineView isOpaque]): (-[WebInspectorOutlineView _highlightColorForCell:]): (-[WebInspectorOutlineView _highlightRow:clipRect:]): (-[WebInspectorOutlineView drawBackgroundInClipRect:]):
WebInspector.subproj/WebInspectorPanel.h: Added.
WebInspector.subproj/WebInspectorPanel.m: Added. (-[WebInspectorPanel canBecomeKeyWindow]): (-[WebInspectorPanel canBecomeMainWindow]): (-[WebInspectorPanel moveWindow:]): (-[WebInspectorPanel resizeWindow:]): (-[WebInspectorPanel sendEvent:]):
WebInspector.subproj/WebNodeHighlight.h: Added.
WebInspector.subproj/WebNodeHighlight.m: Added. (-[WebNodeHighlight initWithBounds:andRects:forView:]): (-[WebNodeHighlight dealloc]): (-[WebNodeHighlight fractionComplete]): (-[WebNodeHighlight expire]): (-[WebNodeHighlight redraw:]):
WebInspector.subproj/WebNodeHighlightView.h: Added.
WebInspector.subproj/WebNodeHighlightView.m: Added. (-[WebNodeHighlightView roundedRect:withRadius:]): (-[WebNodeHighlightView initWithHighlight:andRects:forView:]): (-[WebNodeHighlightView dealloc]): (-[WebNodeHighlightView isOpaque]): (-[WebNodeHighlightView drawRect:]):
WebInspector.subproj/webInspector: Added.
WebInspector.subproj/webInspector/Images: Added.
WebInspector.subproj/webInspector/Images/close.png: Added.
WebInspector.subproj/webInspector/Images/closePressed.png: Added.
WebInspector.subproj/webInspector/Images/downTriangle.png: Added.
WebInspector.subproj/webInspector/Images/menu.png: Added.
WebInspector.subproj/webInspector/Images/menuPressed.png: Added.
WebInspector.subproj/webInspector/Images/popupFill.png: Added.
WebInspector.subproj/webInspector/Images/popupFillPressed.png: Added.
WebInspector.subproj/webInspector/Images/popupLeft.png: Added.
WebInspector.subproj/webInspector/Images/popupLeftPressed.png: Added.
WebInspector.subproj/webInspector/Images/popupRight.png: Added.
WebInspector.subproj/webInspector/Images/popupRightPressed.png: Added.
WebInspector.subproj/webInspector/Images/rightTriangle.png: Added.
WebInspector.subproj/webInspector/Images/scrollThumbBottom.png: Added.
WebInspector.subproj/webInspector/Images/scrollThumbMiddle.png: Added.
WebInspector.subproj/webInspector/Images/scrollThumbTop.png: Added.
WebInspector.subproj/webInspector/Images/scrollTrackBottom.png: Added.
WebInspector.subproj/webInspector/Images/scrollTrackMiddle.png: Added.
WebInspector.subproj/webInspector/Images/scrollTrackTop.png: Added.
WebInspector.subproj/webInspector/Images/squareButtonRight.png: Added.
WebInspector.subproj/webInspector/Images/squareButtonRightPressed.png: Added.
WebInspector.subproj/webInspector/Images/upTriangle.png: Added.
WebInspector.subproj/webInspector/inspector.css: Added.
WebInspector.subproj/webInspector/inspector.html: Added.
WebInspector.subproj/webInspector/inspector.js: Added.
WebKit.xcodeproj/project.pbxproj: Adds Web Inspector files
WebView.subproj/WebUIDelegatePrivate.h: new UI delegate method to supply a replacement view for plugins
WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]): Add a new context menu item for inspecting (-[WebView _inspectElement:]): Context menu item target for inspecting

5:29 PM Changeset in webkit [12121] by darin

21 edits
1 move in trunk/WebCore

Reviewed by Eric.

changed WebCore namespace change to work on Win32 as well as Mac OS X

WebCorePrefix.h: Removed things needed cross-platform.

config.h: Moved from khtml subdirectory. Added defines from WebCorePrefix.h, and added a define that makes KSVG a synonym for WebCore.
khtml/config.h: Removed.

khtml/css/css_grammar.y: Changed SVG functions to use function name rather than namespace to avoid collision with the XML and HTML DOM. Changes tabs to spaces.
khtml/css/css_valueimpl.cpp: (WebCore::propertyID): Add SVG properties ot the ones understood here. This allows us to set SVG properties from JavaScript.

ksvg2/scripts/cssmakeprops: Put functions inside the namespace to avoid compiler warning, and renamed functions to include CSS and SVG.
ksvg2/scripts/cssmakevalues: Ditto.

ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::parseMappedAttribute): Use property ID function by its new name.

ksvg2/ksvg.h: Renamed ExceptionCode to SVGExceptionCode.

khtml/ecma/XSLTProcessor.cpp: Moved "config.h" header up above the ifdef so that the ifdef works.
khtml/xbl/xbl_binding.cpp: Ditto.
khtml/xbl/xbl_binding_manager.cpp: Ditto.
khtml/xbl/xbl_docimpl.cpp: Ditto.
khtml/xbl/xbl_protobinding.cpp: Ditto.
khtml/xbl/xbl_tokenizer.cpp: Ditto.
khtml/xsl/xsl_stylesheetimpl.cpp: Ditto.
khtml/xsl/xslt_processorimpl.cpp: Ditto.
loader/CachedXBLDocument.cpp: Ditto.

ksvg2/svg/SVGFELightElementImpl.h: Removed include of "config.h". That's supposed to only be included by code files, not headers.

ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added missing include of "config.h". Did a few other tweaks to the file.
ksvg2/svg/SVGFEPointLightElementImpl.cpp: Ditto.
ksvg2/svg/SVGFESpotLightElementImpl.cpp: Ditto.

4:38 PM Changeset in webkit [12120] by eseidel

19 edits in trunk/WebCore

2006-01-15 Eric Seidel <eseidel@apple.com>

Rubber-stamped by darin.

Updated files w/ missing copyrights from Oliver.

kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel:
kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel:
kcanvas/device/quartz/filters/WKPointLightFilter.cikernel:
kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel:
ksvg2/svg/SVGAnimatedColorImpl.cpp:
ksvg2/svg/SVGAnimatedColorImpl.h:
ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
ksvg2/svg/SVGFEDistantLightElementImpl.cpp:
ksvg2/svg/SVGFEDistantLightElementImpl.h:
ksvg2/svg/SVGFELightElementImpl.cpp:
ksvg2/svg/SVGFELightElementImpl.h:
ksvg2/svg/SVGFEPointLightElementImpl.cpp:
ksvg2/svg/SVGFEPointLightElementImpl.h:
ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
ksvg2/svg/SVGFESpecularLightingElementImpl.h:
ksvg2/svg/SVGFESpotLightElementImpl.cpp:
ksvg2/svg/SVGFESpotLightElementImpl.h:

3:37 PM Changeset in webkit [12119] by darin

2 adds in trunk/WebCore/khtml/editing

Oops, didn't check in these two files!

3:32 PM Changeset in webkit [12118] by darin

23 edits in trunk/WebCore

Reviewed and tweaked a bit by Darin.

Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=6523>
"Extract data from SelectionController"

This patch refactors the data portions of SelectionController into its
own class, "Selection".

The extracted data are the base/extent/start/end positions and cursor
affinity. Also a couple cached values generated by validation are kept around
in the new class.

This patch does away with all the different affinities
(start/end/base/extent) that were never implemented properly, since affinity
only makes sense when the selection is a caret (as per discussion with mjs and
darin on #webkit).

No test cases added because this is a refactoring.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::baseWritingDirectionForSelectionStart): (MacFrame::respondToChangedSelection):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionState]): (-[WebCoreFrameBridge selectNSRange:]): (-[WebCoreFrameBridge selectionAffinity]): (-[WebCoreFrameBridge setMarkDOMRange:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
khtml/editing/Selection.cpp: Added. (khtml::Selection::Selection): (khtml::Selection::clear): (khtml::Selection::toRange): (khtml::Selection::validate): (khtml::Selection::adjustForEditableContent): (khtml::Selection::debugPosition):
khtml/editing/Selection.h: Added. (khtml::Selection::): (khtml::Selection::state): (khtml::Selection::setAffinity): (khtml::Selection::affinity): (khtml::Selection::setBase): (khtml::Selection::setExtent): (khtml::Selection::setStart): (khtml::Selection::setEnd): (khtml::Selection::base): (khtml::Selection::extent): (khtml::Selection::start): (khtml::Selection::end): (khtml::Selection::isNone): (khtml::Selection::isCaret): (khtml::Selection::isRange): (khtml::Selection::isCaretOrRange): (khtml::Selection::isBaseFirst): (khtml::operator==): (khtml::operator!=):
khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::operator=): (khtml::SelectionController::moveTo): (khtml::SelectionController::setModifyBias): (khtml::SelectionController::modifyExtendingRightForward): (khtml::SelectionController::modifyMovingRightForward): (khtml::SelectionController::modifyExtendingLeftBackward): (khtml::SelectionController::modifyMovingLeftBackward): (khtml::SelectionController::modify): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::xPosForVerticalArrowNavigation): (khtml::SelectionController::clear): (khtml::SelectionController::setBase): (khtml::SelectionController::setExtent): (khtml::SelectionController::toString): (khtml::SelectionController::getRangeAt): (khtml::SelectionController::frame): (khtml::SelectionController::collapseToEnd): (khtml::SelectionController::collapseToStart): (khtml::SelectionController::layout): (khtml::SelectionController::caretRect): (khtml::SelectionController::needsCaretRepaint): (khtml::SelectionController::paintCaret): (khtml::SelectionController::debugRenderer): (khtml::SelectionController::formatForDebugger): (khtml::SelectionController::showTree):
khtml/editing/SelectionController.h: (khtml::SelectionController::state): (khtml::SelectionController::affinity): (khtml::SelectionController::base): (khtml::SelectionController::extent): (khtml::SelectionController::start): (khtml::SelectionController::end): (khtml::SelectionController::isNone): (khtml::SelectionController::isCaret): (khtml::SelectionController::isRange): (khtml::SelectionController::isCaretOrRange): (khtml::SelectionController::toRange): (khtml::SelectionController::baseNode): (khtml::SelectionController::extentNode): (khtml::SelectionController::baseOffset): (khtml::SelectionController::extentOffset): (khtml::SelectionController::anchorNode): (khtml::SelectionController::anchorOffset): (khtml::SelectionController::focusNode): (khtml::SelectionController::focusOffset): (khtml::operator==):
khtml/editing/apply_style_command.cpp: (khtml::ApplyStyleCommand::updateStartEnd):
khtml/editing/break_blockquote_command.cpp: (khtml::BreakBlockquoteCommand::doApply):
khtml/editing/delete_selection_command.cpp: (khtml::DeleteSelectionCommand::initializePositionData): (khtml::DeleteSelectionCommand::handleGeneralDelete): (khtml::DeleteSelectionCommand::doApply):
khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::input):
khtml/editing/move_selection_command.cpp: (khtml::MoveSelectionCommand::doApply):
khtml/editing/replace_selection_command.cpp: (khtml::ReplaceSelectionCommand::doApply): (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): (khtml::TypingCommand::forwardDeleteKeyPressed): (khtml::TypingCommand::markMisspellingsAfterTyping):
khtml/xml/DocumentImpl.cpp: (DocumentImpl::updateSelection):
kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityAttributeValue:]): (-[KWQAccObject doAXTextMarkerRangeForLine:]):
kwq/KWQRenderTreeDebug.cpp: (writeSelection):
page/Frame.cpp: (Frame::selectContentsOfNode): (Frame::shouldChangeSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::revealSelection): (Frame::centerSelectionInVisibleArea): (Frame::styleForSelectionStart):

<a few other files, including editing ones>: Added includes since Selection.h and SelectionController.h now include fewer things.

2:38 PM Changeset in webkit [12117] by darin

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5619 CSS2: pre-wrap has overflow/selection problems

fast/text/whitespace/pre-wrap-overflow-selection-expected.checksum: Added.
fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Added.
fast/text/whitespace/pre-wrap-overflow-selection.html: Added.

WebCore:

Test: fast/text/whitespace/pre-wrap-overflow-selection.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5619 CSS2: pre-wrap has overflow/selection problems

khtml/rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionRect): Clip selection rect to the text box (khtml::InlineTextBox::paintSelection): Clip selection painting to the text box.
khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): Remove code that re-added border width, since it is already included in availableWidth.

1:52 PM Changeset in webkit [12116] by darin

16 edits in trunk/WebCore

Reviewed by Anders.

fix regression in duplicate ID layout test

khtml/xml/DocumentImpl.cpp: (DocumentImpl::getElementById): Change to take AtomicString, so we can use the string pointer as a hash key and not worry about ref'ing the pointer or about object lifetime since the string will be stored for the lifetime of the ID attribute. Also update for the counted set formerly named m_idCount to use its new name, m_duplicateIds. (DocumentImpl::addElementById): Ditto. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::recalcStyleSelector): Pass a DOMStringImpl* (see below).
khtml/xml/DocumentImpl.h: Change functions to take AtomicString.

kcanvas/KCanvasFilters.cpp: (getFilterById): Use AtomicString.
kcanvas/KCanvasFilters.h: Ditto.
kcanvas/KCanvasResources.cpp: (getResourceById): Ditto. (getMarkerById): Ditto. (getClipperById): Ditto. (getMaskerById): Ditto. (getPaintServerById): Ditto.
kcanvas/KCanvasResources.h: Ditto.
khtml/ecma/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): Ditto.
khtml/html/HTMLLabelElementImpl.cpp: (DOM::HTMLLabelElementImpl::formElement): Ditto.
khtml/xml/NodeListImpl.cpp: (DOM::NodeListImpl::itemById): Ditto.
khtml/xml/NodeListImpl.h: Ditto. Also removed unnecessary "virtual".

khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheetList::nameGetter): Pass a DOMStringImpl*, which gets converted to an AtomicString implicitly, rather than a DOMString, which does not. (But that's a crazy rule -- we should change this around long term.) (KJS::DOMStyleSheetList::getOwnPropertySlot): Ditto.
khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeList::nameGetter): Ditto. (KJS::DOMNodeList::getOwnPropertySlot): Ditto. (KJS::DOMDocumentProtoFunc::callAsFunction): Ditto.

Merge khtml, DOM, and KDOM into one big namespace, WebCore.

WebCorePrefix.h: Use defined to map the old namespace names to WebCore. Now that this is done in the prefix, we can start actually calling it by that name, phase out the old names, then remove the defines.

other changes

khtml/xml/DocumentTypeImpl.cpp: Converted tabs to spaces.
khtml/xml/dom2_eventsimpl.cpp: Ditto.

12:04 PM Changeset in webkit [12115] by andersca

18 edits in trunk/WebCore

2006-01-15 Alexander Kellett <lypanov@kde.org>

Reviewed and landed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6553
Remove KCanvasCommonArgs and pass around RenderPath objects instead.

WebCore.xcodeproj/project.pbxproj:
kcanvas/KCanvasCreator.h:
kcanvas/KCanvasItem.cpp:
kcanvas/KCanvasItem.h:
kcanvas/KCanvasTypes.h: Removed.
kcanvas/device/KRenderingDevice.cpp:
kcanvas/device/KRenderingDevice.h:
kcanvas/device/KRenderingFillPainter.h:
kcanvas/device/KRenderingPaintServer.h:
kcanvas/device/KRenderingStrokePainter.h:
kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint):
kcanvas/device/quartz/KRenderingDeviceQuartz.h:
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (drawShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::draw):
kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerImageQuartz::draw):
ksvg2/misc/KCanvasRenderingStyle.cpp:
ksvg2/svg/SVGPatternElementImpl.h:

7:14 AM Changeset in webkit [12114] by darin

22 edits
5 deletes in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6528 remove all use of QDict from WebCore

I ran performance tests and the change results in a slight improvement.

bridge/mac/MacFrame.h: Removed include of KWQDict.h. Changed didTellBridgeAboutLoad and haveToldBridgeAboutLoad functions to take DOMString instead of QString. Changed urlsBridgeKnowsAbout from a QDict to a HashMap.
bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad): Updated to use QDict and DOMString. (MacFrame::haveToldBridgeAboutLoad): Ditto.

khtml/editing/jsediting.h: Removed include of qdict.h.

khtml/rendering/render_frames.cpp: Removed include of qdict.h. Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. (khtml::RenderPartObject::updateWidget): Changed the local variable uniqueParamNames to be a HashSet instead of a QDict.

khtml/xml/DocumentImpl.h: Removed include of qdict.h, changed m_elementsById, m_idCount, and m_elementsByAccessKey to use HashMap and HashCountedSet instead of QDict.
khtml/xml/DocumentImpl.cpp: Changed tabs to spaces. (DocumentImpl::getElementById): Updated to use HashMap for m_elementsById and HashCountedSet for m_idCount. (DocumentImpl::addElementById): Ditto. Remove code to clear m_accessKeyDictValid, since setDocumentChanged already takes care of that. (DocumentImpl::removeElementById): Ditto. (DocumentImpl::getElementByAccessKey): Updated to use HashMap for m_elementsByAccessKey. (DocumentImpl::setDocumentChanged): Rearranged to do a couple fewer branches. Clear out the m_elementsByAccessKey map when clearing m_accessKeyMapValid to avoid keeping stale pointers around.

ksvg2/svg/SVGDocumentImpl.cpp: Removed include of q3dict.h.

WebCore.vcproj/WebCore/WebCore.vcproj: Removed obsolete QDict sources.
WebCore.xcodeproj/project.pbxproj: Ditto.

ForwardingHeaders/q3dict.h: Removed.
ForwardingHeaders/qdict.h: Removed.
kwq/KWQDict.h: Removed.
kwq/KWQDictImpl.cpp: Removed.
kwq/KWQDictImpl.h: Removed.

WebCore+SVG/SVGNamesWrapper.cpp: Touched this file just so I could build again.

kwq/KWQKURL.h: Removed unused canonicalURL, _path, _user, _pass, and _host functions.
kwq/KWQKURL.mm: Changed tabs to spaces, removed unused functions, replaced NULL with 0.

kwq/KWQLoader.mm: Changed tabs to spaces. (KWQServeRequest): Removed QString conversion from call to didTellBridgeAboutLoad. (KWQServeSynchronousRequest): Ditto. (KWQCheckCacheObjectStatus): Ditto. Same for haveToldBridgeAboutLoad.

loader/Cache.h: Removed include of qdict.h. Changed declaration of the LRUList struct to just be a forward declaration. Changed tabs to spaces. Removed the static data member called "cache". Added a static member function called get. Renamed removeCacheEntry to remove.
loader/Cache.cpp: Put file inside the khtml namespace instead of just using the namespace. Changed tabs to spaces. Changed the main cache itself to a HashMap and made it a static variable local to this file instead of a static data member of Cache to hide its type from the header. Also made the LRUList type private to this file. (khtml::Cache::init): Create a HashMap instead of a QDict. (khtml::Cache::clear): To replace the use of setAutoDelete, write a loop to delete all the items in the cache map. (khtml::Cache::requestImage): Change code to use HashMap functions instead of QDict. (khtml::Cache::requestStyleSheet): Ditto. (khtml::Cache::preloadStyleSheet): Ditto. (khtml::Cache::requestScript): Ditto. (khtml::Cache::preloadScript): Ditto. (khtml::Cache::requestXSLStyleSheet): Ditto. (khtml::Cache::requestXBLDocument): Ditto. (khtml::Cache::removeCacheEntry): Ditto. (khtml::Cache::FastLog2): Fixed this for 64-bit compiles. (khtml::Cache::getStatistics): Ditto. (khtml::Cache::flushAll): Ditto. (khtml::Cache::get): Added. Function used by the loader.

loader/CachedObject.h: Removed include of qdict.h.

loader/DocLoader.h: Removed include of qdict.h.
loader/DocLoader.cpp: (khtml::DocLoader::needReload): Changed to use new get function of Cache instead of getting at the map directly. Also changed call to removeCacheEntry to remove because it was renamed.

loader/CachedImage.cpp: (khtml::CachedImage::data): Changed call to removeCacheEntry to remove because it was renamed.
loader/CachedImageCallback.cpp: (khtml::CachedImageCallback::handleError): Ditto.
loader/loader.cpp: (khtml::Loader::slotFinished): Ditto. (khtml::Loader::cancelRequests): Ditto.

6:39 AM Changeset in webkit [12113] by ap

2 edits in trunk/JavaScriptCore

Reviewed by Anders.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6561 run-javascriptcore-tests doesn't work

JavaScriptCore/tests/mozilla/Getopt/Mixed.pm: Changed revision number to 1.8 (broken by svn migration).

4:28 AM Changeset in webkit [12112] by eseidel

1 edit
1 move in trunk/LayoutTests

2006-01-15 Eric Seidel <eseidel@apple.com>

Disabling broken test until results can be consistent:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6560

dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Removed.
dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Added.

4:03 AM Changeset in webkit [12111] by eseidel

1 edit
1 move
1 delete in trunk/LayoutTests

2006-01-15 Eric Seidel <eseidel@apple.com>

Disabling broken test until timezone bug is fixed:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6547

fast/js/kde/Date-expected.txt: Removed.
fast/js/kde/Date.html: Removed.
fast/js/kde/Date.html-disabled: Added.

3:48 AM Changeset in webkit [12110] by andersca

2 edits in trunk/JavaScriptCore

2006-01-14 David Kilzer <ddkilzer@kilzer.net>

Reviewed and landed by Anders.

kjs/create_hash_table: Fixed comment typo.

3:47 AM Changeset in webkit [12109] by eseidel

3 edits
4 adds in trunk

2006-01-15 Alexander Kellett <lypanov@kde.org>

Reviewed by eseidel.

<mask> inside <defs> crashes Safari.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6548

ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):

2:47 AM Changeset in webkit [12108] by eseidel

39 edits in trunk

2006-01-15 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add basic <tspan> support using RenderInline.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6428
Also fix <text transform=""> while we're at it.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6552

ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::parseMappedAttribute): code cleanup
ksvg2/svg/SVGPatternElementImpl.cpp: (SVGPatternElementImpl::parseMappedAttribute): code cleanup
ksvg2/svg/SVGStyledTransformableElementImpl.cpp: (SVGStyledTransformableElementImpl::parseMappedAttribute): cleanup
ksvg2/svg/SVGTSpanElementImpl.cpp: (SVGTSpanElementImpl::childShouldCreateRenderer): added. (SVGTSpanElementImpl::createRenderer): added.
ksvg2/svg/SVGTSpanElementImpl.h: (KSVG::SVGTSpanElementImpl::rendererIsNeeded): added.
ksvg2/svg/SVGTextElementImpl.cpp: (SVGTextElementImpl::transform): added. (SVGTextElementImpl::localMatrix): added. (SVGTextElementImpl::parseMappedAttribute): support transform. (SVGTextElementImpl::updateLocalTransform): added. (SVGTextElementImpl::attach): added. (SVGTextElementImpl::childShouldCreateRenderer): allow tspan.
ksvg2/svg/SVGTextElementImpl.h:
ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute): code cleanup.
ksvg2/svg/SVGTransformableImpl.h:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed