⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 17, 2006:

10:41 PM Changeset in webkit [12166] by darin
  • 8 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

  • Remove the now-unused KRenderingPaintServerImage[Quartz].
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/KRenderingPaintServerImage.cpp: Removed.
  • kcanvas/device/KRenderingPaintServerImage.h: Removed.
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  • ksvg2/svg/SVGFEImageElementImpl.cpp:
  • kwq/KWQPainter.mm:
10:16 PM Changeset in webkit [12165] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • bridge/mac/MacFrame.mm: (MacFrame::bindingRootObject): Assert that this is only called when JavaScript is enabled. (MacFrame::windowScriptObject): Return 0 if JavaScript is disabled. (MacFrame::windowScriptNPObject): Ditto. (MacFrame::partClearedInBegin): Don't call the "window script object available" call if JavaScript is disabled.
9:55 PM Changeset in webkit [12164] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by darin


Layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at ​http://www.schepers.cc/comiclink

9:53 PM Changeset in webkit [12163] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at ​http://www.schepers.cc/comiclinks.html


Layout test added:

  • editing/selection/after-line-wrap.html
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): Don't stop at the first candidate, it may be visually equivalent to the original position.
  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): Don't move to a position on a different line. (DOM::Position::downstream): Ditto.
8:33 PM Changeset in webkit [12162] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • kxmlcore/HashTable.h: (KXMLCore::addIterator): Added. Helper function that adds an iterator to the list maintained by the specified hash table. (KXMLCore::removeIterator): Added. Helper function that removes an iterator from the list maintained by the hash table it's in. (KXMLCore::HashTableConstIterator::HashTableConstIterator): Added a HashTable parameter, ignored when not debugging. Call addIterator. (KXMLCore::HashTableConstIterator::~HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator=): Call removeIterator. (KXMLCore::HashTableConstIterator::operator*): Call checkValidity. (KXMLCore::HashTableConstIterator::operator->): Ditto. (KXMLCore::HashTableConstIterator::operator++): Ditto. (KXMLCore::HashTableConstIterator::operator==): Ditto. (KXMLCore::HashTableConstIterator::operator!=): Ditto. (KXMLCore::HashTableConstIterator::checkValidity): Checks that the hash table pointer is not 0 and if there are two iterators that both point at the same table. (KXMLCore::HashTableIterator::HashTableIterator): Changed to use the const iterator as an implementation detail, to avoid having two separate iterator implementations. (KXMLCore::HashTableIterator::operator*): Ditto. (KXMLCore::HashTableIterator::operator->): Ditto. (KXMLCore::HashTableIterator::operator++): Ditto. (KXMLCore::HashTableIterator::operator==): Ditto. (KXMLCore::HashTableIterator::operator!=): Ditto. (KXMLCore::HashTable::HashTable): Initialize pointer to head of iterators list. (KXMLCore::HashTable::~HashTable): Added call to invalidateIterators. (KXMLCore::HashTable::makeIterator): Pass this pointer. (KXMLCore::HashTable::makeConstIterator): Ditto. (KXMLCore::HashTable::insert): Call invalidateIterators, since this is a public entry point that modifies the hash table. (KXMLCore::HashTable::remove): Ditto. (KXMLCore::HashTable::clear): Ditto. (KXMLCore::HashTable::swap): Ditto. (KXMLCore::HashTable::invalidateIterators): Added. Walks the iterators list and clears out the table, next, and previous pointers in all of them, and then clears the head so we have an empty list. (KXMLCore::addIterator): Added. Adds the iterator the the linked list in the passed-in table, and points the iterator at the table. (KXMLCore::removeIterator): Added. Removes the iterator from the linked list in the passed-in table.
  • kxmlcore/HashTraits.h: A bit of tweaking and formatting.
8:16 PM Changeset in webkit [12161] by justing
  • 7 edits in trunk

Deployment builds now use -O2

5:33 PM Changeset in webkit [12160] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/4112029> With Quartz scaling on, Safari incorrectly
handles mouseover effects

The location of an event in the window should be converted to the superview
of the contentView to do accurate hitTesting.

5:18 PM Changeset in webkit [12159] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Geoff.

Test for <rdar://problem/4405836> REGRESSION: crash at
webmail.aol.com when deleting mail in
khtml::RenderTableCell::collapsedBottomBorder() const + 232

3:56 PM Changeset in webkit [12158] by thatcher
  • 269 adds in trunk/WebKitSite

Moving the webkit.opendarwin.org site into our Subversion repository.

2:49 PM Changeset in webkit [12157] by hyatt
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix group path for rendering in project file.

2:46 PM Changeset in webkit [12156] by hyatt
  • 3 edits in trunk/WebCore

Fix build bustage caused by my partial commit.

1:07 PM Changeset in webkit [12155] by hyatt
  • 2 edits
    63 copies
    1 add
    1 delete in trunk/WebCore

Move khtml/rendering to WebCore/rendering.

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/rendering: Removed.
  • khtml/rendering/DataRef.h: Removed.
  • khtml/rendering/InlineTextBox.cpp: Removed.
  • khtml/rendering/InlineTextBox.h: Removed.
  • khtml/rendering/RenderText.cpp: Removed.
  • khtml/rendering/RenderText.h: Removed.
  • khtml/rendering/RenderTextFragment.cpp: Removed.
  • khtml/rendering/RenderTextFragment.h: Removed.
  • khtml/rendering/bidi.cpp: Removed.
  • khtml/rendering/bidi.h: Removed.
  • khtml/rendering/break_lines.cpp: Removed.
  • khtml/rendering/break_lines.h: Removed.
  • khtml/rendering/font.cpp: Removed.
  • khtml/rendering/font.h: Removed.
  • khtml/rendering/render_applet.cpp: Removed.
  • khtml/rendering/render_applet.h: Removed.
  • khtml/rendering/render_arena.cpp: Removed.
  • khtml/rendering/render_arena.h: Removed.
  • khtml/rendering/render_block.cpp: Removed.
  • khtml/rendering/render_block.h: Removed.
  • khtml/rendering/render_box.cpp: Removed.
  • khtml/rendering/render_box.h: Removed.
  • khtml/rendering/render_br.cpp: Removed.
  • khtml/rendering/render_br.h: Removed.
  • khtml/rendering/render_button.cpp: Removed.
  • khtml/rendering/render_button.h: Removed.
  • khtml/rendering/render_canvas.cpp: Removed.
  • khtml/rendering/render_canvas.h: Removed.
  • khtml/rendering/render_canvasimage.cpp: Removed.
  • khtml/rendering/render_canvasimage.h: Removed.
  • khtml/rendering/render_container.cpp: Removed.
  • khtml/rendering/render_container.h: Removed.
  • khtml/rendering/render_flexbox.cpp: Removed.
  • khtml/rendering/render_flexbox.h: Removed.
  • khtml/rendering/render_flow.cpp: Removed.
  • khtml/rendering/render_flow.h: Removed.
  • khtml/rendering/render_form.cpp: Removed.
  • khtml/rendering/render_form.h: Removed.
  • khtml/rendering/render_frames.cpp: Removed.
  • khtml/rendering/render_frames.h: Removed.
  • khtml/rendering/render_image.cpp: Removed.
  • khtml/rendering/render_image.h: Removed.
  • khtml/rendering/render_inline.cpp: Removed.
  • khtml/rendering/render_inline.h: Removed.
  • khtml/rendering/render_layer.cpp: Removed.
  • khtml/rendering/render_layer.h: Removed.
  • khtml/rendering/render_line.cpp: Removed.
  • khtml/rendering/render_line.h: Removed.
  • khtml/rendering/render_list.cpp: Removed.
  • khtml/rendering/render_list.h: Removed.
  • khtml/rendering/render_object.cpp: Removed.
  • khtml/rendering/render_object.h: Removed.
  • khtml/rendering/render_replaced.cpp: Removed.
  • khtml/rendering/render_replaced.h: Removed.
  • khtml/rendering/render_style.cpp: Removed.
  • khtml/rendering/render_style.h: Removed.
  • khtml/rendering/render_table.cpp: Removed.
  • khtml/rendering/render_table.h: Removed.
  • khtml/rendering/render_theme.cpp: Removed.
  • khtml/rendering/render_theme.h: Removed.
  • khtml/rendering/render_theme_mac.h: Removed.
  • khtml/rendering/render_theme_mac.mm: Removed.
  • khtml/rendering/table_layout.cpp: Removed.
  • khtml/rendering/table_layout.h: Removed.
  • rendering: Added.
  • rendering/DataRef.h: Added.
  • rendering/InlineTextBox.cpp: Added.
  • rendering/InlineTextBox.h: Added.
  • rendering/RenderText.cpp: Added.
  • rendering/RenderText.h: Added.
  • rendering/RenderTextFragment.cpp: Added.
  • rendering/RenderTextFragment.h: Added.
  • rendering/bidi.cpp: Added.
  • rendering/bidi.h: Added.
  • rendering/break_lines.cpp: Added.
  • rendering/break_lines.h: Added.
  • rendering/font.cpp: Added.
  • rendering/font.h: Added.
  • rendering/render_applet.cpp: Added.
  • rendering/render_applet.h: Added.
  • rendering/render_arena.cpp: Added.
  • rendering/render_arena.h: Added.
  • rendering/render_block.cpp: Added.
  • rendering/render_block.h: Added.
  • rendering/render_box.cpp: Added.
  • rendering/render_box.h: Added.
  • rendering/render_br.cpp: Added.
  • rendering/render_br.h: Added.
  • rendering/render_button.cpp: Added.
  • rendering/render_button.h: Added.
  • rendering/render_canvas.cpp: Added.
  • rendering/render_canvas.h: Added.
  • rendering/render_canvasimage.cpp: Added.
  • rendering/render_canvasimage.h: Added.
  • rendering/render_container.cpp: Added.
  • rendering/render_container.h: Added.
  • rendering/render_flexbox.cpp: Added.
  • rendering/render_flexbox.h: Added.
  • rendering/render_flow.cpp: Added.
  • rendering/render_flow.h: Added.
  • rendering/render_form.cpp: Added.
  • rendering/render_form.h: Added.
  • rendering/render_frames.cpp: Added.
  • rendering/render_frames.h: Added.
  • rendering/render_image.cpp: Added.
  • rendering/render_image.h: Added.
  • rendering/render_inline.cpp: Added.
  • rendering/render_inline.h: Added.
  • rendering/render_layer.cpp: Added.
  • rendering/render_layer.h: Added.
  • rendering/render_line.cpp: Added.
  • rendering/render_line.h: Added.
  • rendering/render_list.cpp: Added.
  • rendering/render_list.h: Added.
  • rendering/render_object.cpp: Added.
  • rendering/render_object.h: Added.
  • rendering/render_replaced.cpp: Added.
  • rendering/render_replaced.h: Added.
  • rendering/render_style.cpp: Added.
  • rendering/render_style.h: Added.
  • rendering/render_table.cpp: Added.
  • rendering/render_table.h: Added.
  • rendering/render_theme.cpp: Added.
  • rendering/render_theme.h: Added.
  • rendering/render_theme_mac.h: Added.
  • rendering/render_theme_mac.mm: Added.
  • rendering/table_layout.cpp: Added.
  • rendering/table_layout.h: Added.
12:52 PM Changeset in webkit [12154] by hyatt
  • 3 edits in trunk/WebCore

Land support for a style method on DOMAttr from JS that will
allow the Web Inspector to include presentational attributes
in the style list.


Reviewed by xenon

  • khtml/ecma/kjs_dom.cpp: (KJS::DOMAttr::getValueProperty):
  • khtml/ecma/kjs_dom.h: (KJS::DOMAttr::):
11:40 AM Changeset in webkit [12153] by bdakin
  • 8 edits in trunk/WebCore

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.`

10:14 AM Changeset in webkit [12152] by ap
  • 21 edits in trunk/WebCore

Patch by Duncan Wilcox, reviewed by Darin.

This patch replaces the use of SelectionController with Selection in the edit commands.

It also cleans up the relationship between Selection and SelectionController:
SelectionController used to need to be friend to Selection to call validate()
on it, now validation is enforced on every update of Selection.

9:35 AM Changeset in webkit [12151] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/generic-form-element-assert.html: Added.
  • fast/dom/generic-form-element-assert-expected.txt: Added.

WebCore:

Test: fast/dom/generic-form-element-assert.html

Reviewed and reworked by Darin.


  • khtml/html/HTMLGenericFormElementImpl.cpp: Tweaked formatting and namespaces a bit. Removed unneeded includes. (WebCore::findRoot): Added helper function. (WebCore::HTMLGenericFormElementImpl::removedFromTree): Rewrote to do the check in a simpler way, since the two separate cases amounted to the same check.
9:29 AM Changeset in webkit [12150] by darin
  • 2 edits in trunk/JavaScriptCore/kxmlcore

Updated copyright dates (oops, forgot).

9:28 AM Changeset in webkit [12149] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • kxmlcore/PassRefPtr.h: Always set m_ptr before calling deref.
  • kxmlcore/RefPtr.h: Ditto.
1:00 AM Changeset in webkit [12148] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

Fix second part of WebCore-no-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Mark three headers as private rather than project in the WebCore-no-SVG target.

Jan 16, 2006:

11:39 PM Changeset in webkit [12147] by hyatt
  • 2 edits in trunk/WebCore

Reviewed by hyatt

  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Assign the new item to index m_count, not m_size.
10:53 PM Changeset in webkit [12146] by eseidel
  • 2 edits in trunk/WebCore

2006-01-17 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by eseidel.

WebCore-SVG fails to build.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6607

  • WebCore.xcodeproj/project.pbxproj: Fix build of WebCore-no-SVG target. Removes SVG specific files and adds new files omitted from the target.
10:50 PM Changeset in webkit [12145] by eseidel
  • 2 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Fixed test case to remove invisible chars (thus fixing test).

  • svg/custom/recursive-clippath.svg:
9:41 PM Changeset in webkit [12144] by hyatt
  • 19 edits
    25 copies
    1 add
    2 deletes in trunk/WebCore

(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.

  • ForwardingHeaders/kdom/css: Removed.
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
  • ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
  • ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
  • ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
  • WebCore+SVG/RGBColorImpl.cpp:
  • WebCore.xcodeproj/project.pbxproj:
  • css: Added.
  • css/css_base.cpp: Added.
  • css/css_base.h: Added.
  • css/css_computedstyle.cpp: Added.
  • css/css_computedstyle.h: Added.
  • css/css_grammar.y: Added.
  • css/css_ruleimpl.cpp: Added.
  • css/css_ruleimpl.h: Added.
  • css/css_stylesheetimpl.cpp: Added.
  • css/css_stylesheetimpl.h: Added.
  • css/css_valueimpl.cpp: Added.
  • css/css_valueimpl.h: Added.
  • css/csshelper.cpp: Added.
  • css/csshelper.h: Added.
  • css/cssparser.cpp: Added.
  • css/cssparser.h: Added.
  • css/cssproperties.in: Added.
  • css/cssstyleselector.cpp: Added.
  • css/cssstyleselector.h: Added.
  • css/cssvalues.in: Added.
  • css/html4.css: Added.
  • css/makeprop: Added.
  • css/maketokenizer: Added.
  • css/makevalues: Added.
  • css/quirks.css: Added.
  • css/tokenizer.flex: Added.
  • khtml/css: Removed.
  • khtml/css/css_base.cpp: Removed.
  • khtml/css/css_base.h: Removed.
  • khtml/css/css_computedstyle.cpp: Removed.
  • khtml/css/css_computedstyle.h: Removed.
  • khtml/css/css_grammar.y: Removed.
  • khtml/css/css_ruleimpl.cpp: Removed.
  • khtml/css/css_ruleimpl.h: Removed.
  • khtml/css/css_stylesheetimpl.cpp: Removed.
  • khtml/css/css_stylesheetimpl.h: Removed.
  • khtml/css/css_valueimpl.cpp: Removed.
  • khtml/css/css_valueimpl.h: Removed.
  • khtml/css/csshelper.cpp: Removed.
  • khtml/css/csshelper.h: Removed.
  • khtml/css/cssparser.cpp: Removed.
  • khtml/css/cssparser.h: Removed.
  • khtml/css/cssproperties.in: Removed.
  • khtml/css/cssstyleselector.cpp: Removed.
  • khtml/css/cssstyleselector.h: Removed.
  • khtml/css/cssvalues.in: Removed.
  • khtml/css/html4.css: Removed.
  • khtml/css/makeprop: Removed.
  • khtml/css/maketokenizer: Removed.
  • khtml/css/makevalues: Removed.
  • khtml/css/quirks.css: Removed.
  • khtml/css/tokenizer.flex: Removed.
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/ecma/Ecma.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGMaskElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
9:41 PM Changeset in webkit [12143] by thatcher
  • 2 edits in trunk/WebKit

Rubber stamped by Maciej.

Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.

  • WebView.subproj/WebView.m: (-[WebView _menuForElement:defaultItems:]):
6:37 PM Changeset in webkit [12142] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

A proactive test case to prevent crashes in recursive clippath defs

  • svg/custom/recursive-clippath-expected.checksum: Added.
  • svg/custom/recursive-clippath-expected.png: Added.
  • svg/custom/recursive-clippath-expected.txt: Added.
  • svg/custom/recursive-clippath.svg: Added.
6:20 PM Changeset in webkit [12141] by ggaren
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by darin.

  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction): Type check calls to all methods. This matches section 15.9.5 in the spec.

LayoutTests:

  • fast/js/date-proto-generic-invocation-expected.txt: Added.
  • fast/js/date-proto-generic-invocation.html: Added.
  • fast/js/resources/date-proto-generic-invocation.js: Added.
4:35 PM Changeset in webkit [12140] by hyatt
  • 2 edits
    22 moves
    3 adds in trunk/WebCore

Move the Objective-C dom bindings from kwq to bindings/objc.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bindings: Added.
  • bindings/js: Added.
  • bindings/objc: Added.
  • bindings/objc/DOM.h: Added.
  • bindings/objc/DOM.mm: Added.
  • bindings/objc/DOMCSS.h: Added.
  • bindings/objc/DOMCSS.mm: Added.
  • bindings/objc/DOMCore.h: Added.
  • bindings/objc/DOMEvents.h: Added.
  • bindings/objc/DOMEvents.mm: Added.
  • bindings/objc/DOMEventsInternal.h: Added.
  • bindings/objc/DOMExtensions.h: Added.
  • bindings/objc/DOMHTML.h: Added.
  • bindings/objc/DOMHTML.mm: Added.
  • bindings/objc/DOMHTMLInternal.h: Added.
  • bindings/objc/DOMInternal.h: Added.
  • bindings/objc/DOMInternal.mm: Added.
  • bindings/objc/DOMPrivate.h: Added.
  • bindings/objc/DOMRange.h: Added.
  • bindings/objc/DOMStylesheets.h: Added.
  • bindings/objc/DOMTraversal.h: Added.
  • bindings/objc/DOMUtility.mm: Added.
  • bindings/objc/DOMViews.h: Added.
  • bindings/objc/DOMViews.mm: Added.
  • bindings/objc/DOMViewsInternal.h: Added.
  • kwq/DOM-CSS.mm: Removed.
  • kwq/DOM.h: Removed.
  • kwq/DOM.mm: Removed.
  • kwq/DOMCSS.h: Removed.
  • kwq/DOMCore.h: Removed.
  • kwq/DOMEvents.h: Removed.
  • kwq/DOMEvents.mm: Removed.
  • kwq/DOMEventsInternal.h: Removed.
  • kwq/DOMExtensions.h: Removed.
  • kwq/DOMHTML.h: Removed.
  • kwq/DOMHTML.mm: Removed.
  • kwq/DOMHTMLInternal.h: Removed.
  • kwq/DOMInternal.h: Removed.
  • kwq/DOMInternal.mm: Removed.
  • kwq/DOMPrivate.h: Removed.
  • kwq/DOMRange.h: Removed.
  • kwq/DOMStylesheets.h: Removed.
  • kwq/DOMTraversal.h: Removed.
  • kwq/DOMUtility.mm: Removed.
  • kwq/DOMViews.h: Removed.
  • kwq/DOMViews.mm: Removed.
  • kwq/DOMViewsInternal.h: Removed.
3:43 PM Changeset in webkit [12139] by andersca
  • 1 edit in trunk/WebKit/ChangeLog

Fix bugzilla url

3:41 PM Changeset in webkit [12138] by andersca
  • 4 edits in trunk/WebKit

2006-01-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy Hatcher.


  • WebInspector.subproj/webInspector/inspector.css:
  • WebInspector.subproj/webInspector/inspector.html:
  • WebInspector.subproj/webInspector/inspector.js: Add initial support for element attributes.
2:25 PM Changeset in webkit [12137] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Vicki Murley.


  • fixed <rdar://problem/4409288> REGRESSION (TOT): When no selection is present on page, Jump to Selection doesn't beep
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _hasInsertionPoint]): new helper method (-[NSArray validateUserInterfaceItem:]): Don't validate this menu item (or a couple of others) if the selection is a caret and the page isn't editable. In that state, there is no visible selection so this menu item doesn't make sense. I suspect this was broken by some editing-related change that makes selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.
2:01 PM Changeset in webkit [12136] by ap
  • 4 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.

  • khtml/css/css_grammar.y: (DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to opacity and border-radius, respectively.
  • khtml/rendering/render_box.cpp: (RenderBox::setStyle): Set the object's layer to 0 before removing the layer, to allow child layers to update their positions correctly.
  • khtml/rendering/render_layer.cpp: (khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children of the layer being removed.
  • manual-tests/bugzilla-6473.html: Added.
1:46 PM Changeset in webkit [12135] by ap
  • 2 edits in trunk/WebCore

Patch by Mark Rowe. Reviewed by Darin, landed by ap.

Fix typo in CSSPrimitiveValueImpl::setStringValue.

  • khtml/css/css_valueimpl.cpp: (DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.
12:34 PM Changeset in webkit [12134] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Justin.

Test: editing/input/wrapped-line-char-rect.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]): Use DOWNSTREAM affinity for the range start
12:25 PM Changeset in webkit [12133] by justing
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)

  • editing/selection/replaced-boundaries-1-expected.checksum: Added.
  • editing/selection/replaced-boundaries-1-expected.png: Added.
  • editing/selection/replaced-boundaries-1-expected.txt: Added.
  • editing/selection/replaced-boundaries-1.html: Added.
  • editing/selection/replaced-boundaries-2-expected.checksum: Added.
  • editing/selection/replaced-boundaries-2-expected.png: Added.
  • editing/selection/replaced-boundaries-2-expected.txt: Added.
  • editing/selection/replaced-boundaries-2.html: Added.
  • editing/selection/replaced-boundaries-3-expected.checksum: Added.
  • editing/selection/replaced-boundaries-3-expected.png: Added.
  • editing/selection/replaced-boundaries-3-expected.txt: Added.
  • editing/selection/replaced-boundaries-3.html: Added.
12:24 PM Changeset in webkit [12132] by justing
  • 4 edits in trunk/WebCore

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)


Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.

  • khtml/rendering/render_image.cpp: (RenderImage::paint):
  • khtml/rendering/render_replaced.cpp: (WebCore::RenderReplaced::isSelected): (WebCore::RenderWidget::paint):
  • khtml/rendering/render_replaced.h:
12:04 PM Changeset in webkit [12131] by tomernic
  • 7 edits in trunk

Fixed <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

9:56 AM Changeset in webkit [12130] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • actually removed QPtrDict itself
  • ForwardingHeaders/qptrdict.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
  • kwq/KWQPtrDict.h: Removed.
  • kwq/KWQPtrDictImpl.cpp: Removed.
  • kwq/KWQPtrDictImpl.h: Removed.
9:52 AM Changeset in webkit [12129] by darin
  • 83 edits in trunk/WebCore

Reviewed by John Sullivan.

  • removed all uses of QPtrDict, most uses of QMap
  • khtml/ecma/kjs_dom.cpp: Converted tabs to spaces. (KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
  • khtml/ecma/kjs_events.cpp: Converted tabs to spaces. (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap. (KJS::JSEventListener::JSEventListener): Use HashMap. (KJS::JSLazyEventListener::parseCode): Use HashMap.
  • khtml/ecma/kjs_html.cpp: Convert tabs to spaces. (KJS::KJS::HTMLElement::classInfo): Use HashMap.
  • khtml/ecma/kjs_window.cpp: Convert tabs to spaces. (KJS::Window::~Window): Use HashMap. (KJS::Window::getJSEventListener): Ditto. (KJS::Window::getJSUnprotectedEventListener): Ditto. (KJS::WindowQObject::parentDestroyed): Ditto. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerEvent): Ditto.
  • khtml/ecma/kjs_window.h: Use HashMap.
  • khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces. (KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set. (KJS::XMLHttpRequest::addToRequestsByDocument): Ditto. (KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto. (KJS::XMLHttpRequest::cancelRequests): Ditto.
  • khtml/ecma/xmlhttprequest.h: Ditto.
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
  • khtml/rendering/render_canvas.cpp: (RenderCanvas::selectionRect): Use HashMap. (RenderCanvas::setSelection): Ditto.
  • khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
  • khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
  • khtml/rendering/render_object.h: Used HashSet. Converted tabs to spaces and did namespace changes too.
  • khtml/xml/DocumentImpl.cpp: (DocumentImpl::DocumentImpl): Use HashSet and HashMap. (DocumentImpl::~DocumentImpl): Ditto. (DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto. (DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto. (DocumentImpl::addImageMap): Ditto. (DocumentImpl::removeImageMap): Ditto. (DocumentImpl::getImageMap): Ditto. (DocumentImpl::addMarker): Ditto. (DocumentImpl::copyMarkers): Ditto. (DocumentImpl::removeMarkers): Ditto. (DocumentImpl::markersForNode): Ditto. (DocumentImpl::shiftMarkers): Ditto. (DocumentImpl::radioButtonChecked): Ditto. (DocumentImpl::checkedRadioButtonForGroup): Ditto. (DocumentImpl::removeRadioButtonGroup): Ditto.
  • khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList): Use HashSet. (WebCore::NodeImpl::unregisterNodeList): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto. (WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto. (WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have to include NodeListImpl.h in the header.
  • khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeKey): Added. Hash table key. (WebCore::MappedAttributeKeyTraits): Added. Hash table key traits. (WebCore::MappedAttributeHash): Added. Hash function. (WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap. (WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto. (WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto. (WebCore::MappedAttributeHash::hash): Added. Hash function.
  • khtml/xml/dom_elementimpl.h: Use HashMap.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling to use AtomicString.
  • khtml/html/html_imageimpl.h: (WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.
  • khtml/dom/dom_string.h: Added a default argument to substring, also reduced includes and updated namespace.
  • khtml/xml/dom_stringimpl.h: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace. Updated includes for header changes.
  • kcanvas/RenderForeignObject.cpp: Ditto.
  • kcanvas/RenderForeignObject.h: Ditto.
  • kcanvas/RenderSVGImage.h: Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
  • khtml/css/css_ruleimpl.cpp: Ditto.
  • khtml/css/css_valueimpl.h: Ditto.
  • khtml/ecma/kjs_dom.h: Ditto.
  • khtml/ecma/kjs_html.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Ditto.
  • khtml/editing/delete_selection_command.cpp: Ditto.
  • khtml/html/html_tableimpl.cpp: Ditto.
  • khtml/khtml_events.cpp: Ditto.
  • khtml/rendering/RenderText.cpp: Ditto.
  • khtml/rendering/render_block.cpp: Ditto.
  • khtml/rendering/render_br.cpp: Ditto.
  • khtml/rendering/render_inline.cpp: Ditto.
  • khtml/rendering/render_object.cpp: Ditto.
  • khtml/rendering/render_replaced.cpp: Ditto.
  • khtml/xml/dom2_rangeimpl.cpp: Ditto.
  • kwq/DOM.mm: Ditto.
  • page/Frame.cpp: Ditto.
  • kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a constant moved into the WebCore namespace.
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
  • kcanvas/RenderSVGText.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): Ditto. (KCanvasItemQuartz::nodeAtPoint): Ditto.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::paint): Ditto.
  • khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
  • khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
  • khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.
  • khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
  • khtml/xml/dom_xmlimpl.h: Ditto.
  • ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
  • ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
  • ksvg2/svg/SVGPointImpl.cpp: Ditto.
  • kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb (now in qcolor.h). Also converted tabs to spaces.
  • kwq/KWQPainter.h: Added newly-needed include.
  • kwq/KWQPtrVector.h: Added append function.
  • kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
  • kwq/KWQVectorImpl.h: Added append.
  • kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.
  • kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
  • kwq/KWQWMatrix.h: Ditto.
  • loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.
  • loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
  • loader/CachedCSSStyleSheet.h: Ditto.
  • loader/CachedImage.cpp: Ditto.
  • loader/CachedImage.h: Ditto.
  • loader/CachedImageCallback.cpp: Ditto.
  • loader/CachedObject.cpp: Ditto.
  • loader/CachedObject.h: Ditto.
  • loader/CachedObjectClient.h: Ditto.
  • loader/CachedObjectClientWalker.cpp: Ditto.
  • loader/CachedObjectClientWalker.h: Ditto.
  • loader/CachedScript.cpp: Ditto.
  • loader/CachedScript.h: Ditto.
  • loader/CachedXSLStyleSheet.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::Loader): Changed to use HashMap. (WebCore::Loader::~Loader): Ditto. (WebCore::Loader::servePendingRequests): Ditto. (WebCore::Loader::slotFinished): Ditto. (WebCore::Loader::slotReceivedResponse): Ditto. (WebCore::Loader::slotData): Ditto. (WebCore::Loader::numRequests): Ditto. (WebCore::Loader::cancelRequests): Ditto. (WebCore::Loader::jobForRequest): Ditto.
  • loader/loader.h: Ditto.
1:03 AM Changeset in webkit [12128] by eseidel
  • 5 edits in trunk/LayoutTests

2006-01-16 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove usage of Tahoma font. (previous commit was incomplete)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6569

  • fast/box-sizing/percentage-height-expected.checksum:
  • fast/box-sizing/percentage-height-expected.png:
  • fast/box-sizing/percentage-height-expected.txt:
  • fast/box-sizing/percentage-height.html:
12:49 AM Changeset in webkit [12127] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix problem with ++, ==, and != on const iterators in HashMaps that are using the pointer specialization
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator. (KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto. (KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.
12:30 AM Changeset in webkit [12126] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match where it is in the source tree.
12:05 AM Changeset in webkit [12125] by andersca
  • 2 edits in trunk/WebKit

2006-01-16 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • WebInspector.subproj/webInspector/inspector.js: Use defined NodeType values instead of integers.
Note: See TracTimeline for information about the timeline view.