Context Navigation

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.

khtml/html/HTMLInputElementImpl.cpp: (DOM::HTMLInputElementImpl::defaultEventHandler): If the click is simulated, set xPos and yPos to 0.
khtml/html/html_elementimpl.cpp: (HTMLElementImpl::setContentEditable): Fix spacing. (HTMLElementImpl::click): It isn't necessary to check if there is a renderer.
khtml/rendering/render_layer.cpp: (khtml::RenderLayer::hitTest): Call updateLayout().
khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchSimulatedMouseEvent): Set isSimulated to true. (WebCore::NodeImpl::dispatchMouseEvent): Keep track of isSimulated.
khtml/xml/NodeImpl.h: Same.
khtml/xml/dom2_eventsimpl.cpp: (DOM::MouseRelatedEventImpl::MouseRelatedEventImpl): Add isSimulated to MouseRelatedEventImpl(). (DOM::MouseRelatedEventImpl::computePositions): Only change the offsets if it's not simulated. (DOM::MouseEventImpl::MouseEventImpl): Add isSimulated to MouseEventImpl()
khtml/xml/dom2_eventsimpl.h: (DOM::MouseRelatedEventImpl::isSimulated): Declarations of isSimulated (DOM::MouseEventImpl::isSimulated): Same.

4:59 PM Changeset in webkit [12184] by hyatt

1 edit in trunk/WebCore/page/Frame.h

It's called pure virtual for a reason. (Fingers crossed.)

4:51 PM Changeset in webkit [12183] by hyatt

2 edits in trunk/WebCore

Umm. Yeah. Let's try making BrowserExtensionMac actually declare and use a class called BrowserExtensionMac.

4:43 PM Changeset in webkit [12182] by hyatt

1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.mm

Remove KParts using from WebCoreFrameBridge.mm (yes, more bustage).

4:39 PM Changeset in webkit [12181] by hyatt

1 edit in trunk/WebCore/page/FrameView.cpp

Make sure FrameView includes MacFrame.h on mac only.

4:30 PM Changeset in webkit [12180] by hyatt

1 edit in trunk/WebCore/page/FrameView.cpp

More Mac build bustage. Fix the dashboard region call to still cast to MacFrame.

4:15 PM Changeset in webkit [12179] by hyatt

3 edits in trunk/WebCore

OMG I BROKE THE MAC. (Fixed)

3:59 PM Changeset in webkit [12178] by hyatt

30 edits
3 moves
2 deletes in trunk/WebCore

Eliminate uses of MacFrame in cross-platform code.

1:14 PM Changeset in webkit [12177] by hyatt

3 edits in trunk/WebCore/kwq

Make the signals/stubs/slots compile on Win32 by removing #imports.

1:12 PM Changeset in webkit [12176] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

change KWQList to use qsort instead of CFArraySort

kwq/KWQListImpl.cpp: (compareFuncWrapper): Wrapper that uses global variables to overcome the lack of a "data" pointer in qsort. Could have used qsort_r but that would be less portable. (KWQListImpl::sort): Use qsort instead of CFArraySortValues.

12:19 PM Changeset in webkit [12175] by darin

4 edits
3 moves in trunk/WebCore

Reviewed by Beth.

changed the three signal/slot related files from ObjC++ to C++ files

WebCore.xcodeproj/project.pbxproj:
kwq/KWQSignal.cpp: Added.
kwq/KWQSignal.mm: Removed.
kwq/KWQSignalStubs.cpp: Added.
kwq/KWQSignalStubs.mm: Removed.
kwq/KWQSlot.cpp: Added.
kwq/KWQSlot.mm: Removed.

11:48 AM Changeset in webkit [12174] by hyatt

2 edits in trunk/WebCore

Add KWQListImpl.cpp to Win32 but ifdef out all the LAME LAME LAME CF dependencies.

11:41 AM Changeset in webkit [12173] by thatcher

11 edits
2 adds in branches/Safari-2-0-branch/LayoutTests

Fix for binary files.

11:31 AM Changeset in webkit [12172] by hyatt

3 edits in trunk/JavaScriptCore

Make testkjs.exe compile without warnings.

11:31 AM Changeset in webkit [12171] by hyatt

5 edits in trunk/WebCore

Make Win32 WebCore build again.

9:19 AM Changeset in webkit [12170] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6618 Inline in RTL block with overflow:auto and left border makes scroll bar appear

fast/overflow/overflow-rtl-inline-scrollbar-expected.checksum: Added.
fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Added.
fast/overflow/overflow-rtl-inline-scrollbar.html: Added.

WebCore:

Test: fast/overflow/overflow-rtl-inline-scrollbar.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6618 Inline in RTL block with overflow:auto and left border makes scroll bar appear

Inline flows were always returning 0 for leftmostPosition(). Their real leftmost
edges are determined by their inline boxes, which
RenderBlock::leftmostPosition already takes into account.

khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't descend into inline flows. (RenderFlow::rightmostPosition): Ditto. (RenderFlow::leftmostPosition): Ditto.

8:51 AM Changeset in webkit [12169] by andersca

3 edits in trunk/WebCore

2006-01-18 Anders Carlsson <andersca@mac.com>

Fix build.

khtml/ecma/kjs_navigator.cpp:
page/FrameView.cpp: Remove kstandarddirs.h includes.

12:57 AM Changeset in webkit [12168] by darin

1 edit in trunk/WebCore/ChangeLog

Fixed change log.

12:56 AM Changeset in webkit [12167] by darin

8 edits
1 move
2 adds
6 deletes in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6646 compile CSS sources in instead of reading them from disk

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:

css/make-css-file-arrays.pl: Added. Used to generate C array forms of the ".css" files.
css/UserAgentStyleSheets.cpp: Added. Used to indirectly compile the generated file.

WebCore.xcodeproj/project.pbxproj: Added new source files. Added a build phase to invoke the make-css-file-arrays.pl script. Removed the .css files, which no longer need to be installed as part of the final package.

css/cssstyleselector.cpp: (WebCore::parseUASheet): Removed code to read user agent sheets from disk. Replaced with code that gets them from compiled-in arrays instead. Uses a pretty lame DOMString hack that could be reworked some day. (WebCore::CSSStyleSelector::loadDefaultStyle): Change to load from arrays intead of disk.

css/html4.css: Added missing license header, tweaked format a bit.
css/quirks.css: Added missing license header, tweaked format.
css/svg.css: Moved from ksvg2/css directory.
ksvg2/css/svg.css: Moved to top level css directory.

page/Frame.cpp: Removed includes of qfile.h and kstandarddirs.h.

ForwardingHeaders/kstandarddirs.h: Removed.
ForwardingHeaders/qfile.h: Removed.
kwq/KWQFile.h: Removed.
kwq/KWQFile.mm: Removed.
kwq/KWQKStandardDirs.h: Removed.
kwq/KWQKStandardDirs.mm: Removed.

Jan 17, 2006:

10:41 PM Changeset in webkit [12166] by darin

8 edits
2 deletes in trunk/WebCore

Reviewed by Maciej.

Remove the now-unused KRenderingPaintServerImage[Quartz].

WebCore.xcodeproj/project.pbxproj:
kcanvas/KCanvasTreeDebug.cpp:
kcanvas/device/KRenderingPaintServer.h:
kcanvas/device/KRenderingPaintServerImage.cpp: Removed.
kcanvas/device/KRenderingPaintServerImage.h: Removed.
kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
ksvg2/svg/SVGFEImageElementImpl.cpp:
kwq/KWQPainter.mm:

10:16 PM Changeset in webkit [12165] by darin

2 edits in trunk/WebCore

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6377 <rdar://problem/4400315> All XML crashes in TOT with JavaScript disabled (6377)

bridge/mac/MacFrame.mm: (MacFrame::bindingRootObject): Assert that this is only called when JavaScript is enabled. (MacFrame::windowScriptObject): Return 0 if JavaScript is disabled. (MacFrame::windowScriptNPObject): Ditto. (MacFrame::partClearedInBegin): Don't call the "window script object available" call if JavaScript is disabled.

9:55 PM Changeset in webkit [12164] by justing

1 edit
4 adds in trunk/LayoutTests

Reviewed by darin

Layout tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at http://www.schepers.cc/comiclink

9:53 PM Changeset in webkit [12163] by justing

3 edits in trunk/WebCore

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/4407845>
REGRESSION (TOT): blank space before found text selected at http://www.schepers.cc/comiclinks.html

Layout test added:

editing/selection/after-line-wrap.html

khtml/editing/visible_position.cpp: (khtml::VisiblePosition::previous): Don't stop at the first candidate, it may be visually equivalent to the original position.
khtml/xml/dom_position.cpp: (DOM::Position::upstream): Don't move to a position on a different line. (DOM::Position::downstream): Ditto.

8:33 PM Changeset in webkit [12162] by darin

3 edits in trunk/JavaScriptCore

Reviewed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6611 add assertions to check correct use of hash table iterators

kxmlcore/HashTable.h: (KXMLCore::addIterator): Added. Helper function that adds an iterator to the list maintained by the specified hash table. (KXMLCore::removeIterator): Added. Helper function that removes an iterator from the list maintained by the hash table it's in. (KXMLCore::HashTableConstIterator::HashTableConstIterator): Added a HashTable parameter, ignored when not debugging. Call addIterator. (KXMLCore::HashTableConstIterator::~HashTableConstIterator): (KXMLCore::HashTableConstIterator::operator=): Call removeIterator. (KXMLCore::HashTableConstIterator::operator*): Call checkValidity. (KXMLCore::HashTableConstIterator::operator->): Ditto. (KXMLCore::HashTableConstIterator::operator++): Ditto. (KXMLCore::HashTableConstIterator::operator==): Ditto. (KXMLCore::HashTableConstIterator::operator!=): Ditto. (KXMLCore::HashTableConstIterator::checkValidity): Checks that the hash table pointer is not 0 and if there are two iterators that both point at the same table. (KXMLCore::HashTableIterator::HashTableIterator): Changed to use the const iterator as an implementation detail, to avoid having two separate iterator implementations. (KXMLCore::HashTableIterator::operator*): Ditto. (KXMLCore::HashTableIterator::operator->): Ditto. (KXMLCore::HashTableIterator::operator++): Ditto. (KXMLCore::HashTableIterator::operator==): Ditto. (KXMLCore::HashTableIterator::operator!=): Ditto. (KXMLCore::HashTable::HashTable): Initialize pointer to head of iterators list. (KXMLCore::HashTable::~HashTable): Added call to invalidateIterators. (KXMLCore::HashTable::makeIterator): Pass this pointer. (KXMLCore::HashTable::makeConstIterator): Ditto. (KXMLCore::HashTable::insert): Call invalidateIterators, since this is a public entry point that modifies the hash table. (KXMLCore::HashTable::remove): Ditto. (KXMLCore::HashTable::clear): Ditto. (KXMLCore::HashTable::swap): Ditto. (KXMLCore::HashTable::invalidateIterators): Added. Walks the iterators list and clears out the table, next, and previous pointers in all of them, and then clears the head so we have an empty list. (KXMLCore::addIterator): Added. Adds the iterator the the linked list in the passed-in table, and points the iterator at the table. (KXMLCore::removeIterator): Added. Removes the iterator from the linked list in the passed-in table.

kxmlcore/HashTraits.h: A bit of tweaking and formatting.

8:16 PM Changeset in webkit [12161] by justing

7 edits in trunk

Deployment builds now use -O2

5:33 PM Changeset in webkit [12160] by bdakin

2 edits in trunk/WebKit

Reviewed by Darin.

Fix for <rdar://problem/4112029> With Quartz scaling on, Safari incorrectly
handles mouseover effects

The location of an event in the window should be converted to the superview
of the contentView to do accurate hitTesting.

5:18 PM Changeset in webkit [12159] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Geoff.

Test for <rdar://problem/4405836> REGRESSION: crash at
webmail.aol.com when deleting mail in
khtml::RenderTableCell::collapsedBottomBorder() const + 232

3:56 PM Changeset in webkit [12158] by thatcher

269 adds in trunk/WebKitSite

Moving the webkit.opendarwin.org site into our Subversion repository.

2:49 PM Changeset in webkit [12157] by hyatt

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix group path for rendering in project file.

2:46 PM Changeset in webkit [12156] by hyatt

3 edits in trunk/WebCore

Fix build bustage caused by my partial commit.

1:07 PM Changeset in webkit [12155] by hyatt

2 edits
63 copies
1 add
1 delete in trunk/WebCore

Move khtml/rendering to WebCore/rendering.

WebCore.xcodeproj/project.pbxproj:
khtml/rendering: Removed.
khtml/rendering/DataRef.h: Removed.
khtml/rendering/InlineTextBox.cpp: Removed.
khtml/rendering/InlineTextBox.h: Removed.
khtml/rendering/RenderText.cpp: Removed.
khtml/rendering/RenderText.h: Removed.
khtml/rendering/RenderTextFragment.cpp: Removed.
khtml/rendering/RenderTextFragment.h: Removed.
khtml/rendering/bidi.cpp: Removed.
khtml/rendering/bidi.h: Removed.
khtml/rendering/break_lines.cpp: Removed.
khtml/rendering/break_lines.h: Removed.
khtml/rendering/font.cpp: Removed.
khtml/rendering/font.h: Removed.
khtml/rendering/render_applet.cpp: Removed.
khtml/rendering/render_applet.h: Removed.
khtml/rendering/render_arena.cpp: Removed.
khtml/rendering/render_arena.h: Removed.
khtml/rendering/render_block.cpp: Removed.
khtml/rendering/render_block.h: Removed.
khtml/rendering/render_box.cpp: Removed.
khtml/rendering/render_box.h: Removed.
khtml/rendering/render_br.cpp: Removed.
khtml/rendering/render_br.h: Removed.
khtml/rendering/render_button.cpp: Removed.
khtml/rendering/render_button.h: Removed.
khtml/rendering/render_canvas.cpp: Removed.
khtml/rendering/render_canvas.h: Removed.
khtml/rendering/render_canvasimage.cpp: Removed.
khtml/rendering/render_canvasimage.h: Removed.
khtml/rendering/render_container.cpp: Removed.
khtml/rendering/render_container.h: Removed.
khtml/rendering/render_flexbox.cpp: Removed.
khtml/rendering/render_flexbox.h: Removed.
khtml/rendering/render_flow.cpp: Removed.
khtml/rendering/render_flow.h: Removed.
khtml/rendering/render_form.cpp: Removed.
khtml/rendering/render_form.h: Removed.
khtml/rendering/render_frames.cpp: Removed.
khtml/rendering/render_frames.h: Removed.
khtml/rendering/render_image.cpp: Removed.
khtml/rendering/render_image.h: Removed.
khtml/rendering/render_inline.cpp: Removed.
khtml/rendering/render_inline.h: Removed.
khtml/rendering/render_layer.cpp: Removed.
khtml/rendering/render_layer.h: Removed.
khtml/rendering/render_line.cpp: Removed.
khtml/rendering/render_line.h: Removed.
khtml/rendering/render_list.cpp: Removed.
khtml/rendering/render_list.h: Removed.
khtml/rendering/render_object.cpp: Removed.
khtml/rendering/render_object.h: Removed.
khtml/rendering/render_replaced.cpp: Removed.
khtml/rendering/render_replaced.h: Removed.
khtml/rendering/render_style.cpp: Removed.
khtml/rendering/render_style.h: Removed.
khtml/rendering/render_table.cpp: Removed.
khtml/rendering/render_table.h: Removed.
khtml/rendering/render_theme.cpp: Removed.
khtml/rendering/render_theme.h: Removed.
khtml/rendering/render_theme_mac.h: Removed.
khtml/rendering/render_theme_mac.mm: Removed.
khtml/rendering/table_layout.cpp: Removed.
khtml/rendering/table_layout.h: Removed.
rendering: Added.
rendering/DataRef.h: Added.
rendering/InlineTextBox.cpp: Added.
rendering/InlineTextBox.h: Added.
rendering/RenderText.cpp: Added.
rendering/RenderText.h: Added.
rendering/RenderTextFragment.cpp: Added.
rendering/RenderTextFragment.h: Added.
rendering/bidi.cpp: Added.
rendering/bidi.h: Added.
rendering/break_lines.cpp: Added.
rendering/break_lines.h: Added.
rendering/font.cpp: Added.
rendering/font.h: Added.
rendering/render_applet.cpp: Added.
rendering/render_applet.h: Added.
rendering/render_arena.cpp: Added.
rendering/render_arena.h: Added.
rendering/render_block.cpp: Added.
rendering/render_block.h: Added.
rendering/render_box.cpp: Added.
rendering/render_box.h: Added.
rendering/render_br.cpp: Added.
rendering/render_br.h: Added.
rendering/render_button.cpp: Added.
rendering/render_button.h: Added.
rendering/render_canvas.cpp: Added.
rendering/render_canvas.h: Added.
rendering/render_canvasimage.cpp: Added.
rendering/render_canvasimage.h: Added.
rendering/render_container.cpp: Added.
rendering/render_container.h: Added.
rendering/render_flexbox.cpp: Added.
rendering/render_flexbox.h: Added.
rendering/render_flow.cpp: Added.
rendering/render_flow.h: Added.
rendering/render_form.cpp: Added.
rendering/render_form.h: Added.
rendering/render_frames.cpp: Added.
rendering/render_frames.h: Added.
rendering/render_image.cpp: Added.
rendering/render_image.h: Added.
rendering/render_inline.cpp: Added.
rendering/render_inline.h: Added.
rendering/render_layer.cpp: Added.
rendering/render_layer.h: Added.
rendering/render_line.cpp: Added.
rendering/render_line.h: Added.
rendering/render_list.cpp: Added.
rendering/render_list.h: Added.
rendering/render_object.cpp: Added.
rendering/render_object.h: Added.
rendering/render_replaced.cpp: Added.
rendering/render_replaced.h: Added.
rendering/render_style.cpp: Added.
rendering/render_style.h: Added.
rendering/render_table.cpp: Added.
rendering/render_table.h: Added.
rendering/render_theme.cpp: Added.
rendering/render_theme.h: Added.
rendering/render_theme_mac.h: Added.
rendering/render_theme_mac.mm: Added.
rendering/table_layout.cpp: Added.
rendering/table_layout.h: Added.

12:52 PM Changeset in webkit [12154] by hyatt

3 edits in trunk/WebCore

Land support for a style method on DOMAttr from JS that will
allow the Web Inspector to include presentational attributes
in the style list.

Reviewed by xenon

khtml/ecma/kjs_dom.cpp: (KJS::DOMAttr::getValueProperty):
khtml/ecma/kjs_dom.h: (KJS::DOMAttr::):

11:40 AM Changeset in webkit [12153] by bdakin

8 edits in trunk/WebCore

Reviewed by Hyatt and Darin

Fix for <rdar://problem/4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232

RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.`

10:14 AM Changeset in webkit [12152] by ap

21 edits in trunk/WebCore

Patch by Duncan Wilcox, reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6609 Use Selection instead of SelectionController where possible

This patch replaces the use of SelectionController with Selection in the edit commands.

It also cleans up the relationship between Selection and SelectionController:
SelectionController used to need to be friend to Selection to call validate()
on it, now validation is enforced on every update of Selection.

9:35 AM Changeset in webkit [12151] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5926 Assertion failure in HTMLGenericFormElementImpl::removedFromTree

fast/dom/generic-form-element-assert.html: Added.
fast/dom/generic-form-element-assert-expected.txt: Added.

WebCore:

Test: fast/dom/generic-form-element-assert.html

Reviewed and reworked by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5926 Assertion failure in HTMLGenericFormElementImpl::removedFromTree

khtml/html/HTMLGenericFormElementImpl.cpp: Tweaked formatting and namespaces a bit. Removed unneeded includes. (WebCore::findRoot): Added helper function. (WebCore::HTMLGenericFormElementImpl::removedFromTree): Rewrote to do the check in a simpler way, since the two separate cases amounted to the same check.

9:29 AM Changeset in webkit [12150] by darin