⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 20, 2006:

7:47 PM Changeset in webkit [12271] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 6666, pseudo-element rules incorrectly displayed
in Web Inspector.


Reviewed by darin

Added fast/inspector/matchedrules.html as test case.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):
7:45 PM Changeset in webkit [12270] by hyatt
  • 2 adds in trunk/LayoutTests/fast/inspector

Add a test case for Web Inspector style matching bug.

7:05 PM Changeset in webkit [12269] by thatcher
  • 7 edits
    2 deletes in trunk

WebCore:

Reviewed by John.

Removes code that is no longer needed with the new Web Inspector.

  • bridge/mac/WebCoreFrameBridge.h: removes the WebCoreDOMTreeCopier protocol.
  • bridge/mac/WebCoreFrameBridge.mm: removes copyDOMNode:copier:

WebKit:

Reviewed by John, some parts by Darin.

Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
that menu item to prevent a crash.

  • WebKit.exp: adds WebInspector, removes WebDebugDOMNode
  • WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
  • WebView.subproj/WebDebugDOMNode.h: Removed.
  • WebView.subproj/WebDebugDOMNode.m: Removed.
  • WebView.subproj/WebView.m: (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item
5:03 PM Changeset in webkit [12268] by andersca
  • 17 edits in trunk/WebCore

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by David Hyatt.

Rename Frame::xmlDocImpl => Frame::document and
Frame::replaceDocImpl => Frame::setDocument


  • bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::keyEvent): (MacFrame::dispatchCPPEvent): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::bodyBackgroundColor): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::setMarkedTextRange): (MacFrame::dashboardRegionsDictionary): (MacFrame::shouldClose):
  • bridge/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): (frameHasSelection): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge saveDocumentState]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge saveDocumentToPageCache]): (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge deselectAll]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge copyDOMTree:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge unmarkAllMisspellings]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge DOMDocument]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge doneProcessingData]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::callAsFunction):
  • khtml/editing/jsediting.cpp:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::contentDocument):
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]):
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
  • page/Frame.cpp: (Frame::document): (Frame::setDocument): (Frame::setFocusNodeIfNeeded): (Frame::isPointInsideSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectionComputedStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::renderer): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayoutWithPageWidthRange): (Frame::sendScrollEvent): (Frame::clearTimers): (Frame::styleForSelectionStart): (Frame::setSelectionFromNone): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol):
  • page/Frame.h:
  • page/FrameView.cpp: (FrameView::~FrameView): (FrameView::clear): (FrameView::resizeEvent): (FrameView::adjustViewSize): (FrameView::layout): (FrameView::updateDashboardRegions): (FrameView::viewportMousePressEvent): (FrameView::viewportMouseDoubleClickEvent): (FrameView::viewportMouseMoveEvent): (FrameView::viewportMouseReleaseEvent): (FrameView::keyPressEvent): (FrameView::dispatchDragEvent): (FrameView::updateDragAndDrop): (FrameView::focusNextPrevNode): (FrameView::dispatchMouseEvent): (FrameView::viewportWheelEvent): (FrameView::timerEvent): (FrameView::scheduleRelayout): (FrameView::unscheduleRelayout):
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
2:54 PM Changeset in webkit [12267] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Hyatt.

Corrects the cascade order for mapped attributes.
Shows "inline stylesheet" rather than "null" for rules in <style> tags.

1:48 PM Changeset in webkit [12266] by cpeterse
  • 2 edits in trunk/WebCore

Reviewed by eseidel.

Build fix.

  • khtml/xml/DocumentImpl.cpp:
12:20 PM Changeset in webkit [12265] by eseidel
  • 3 edits in trunk/WebCore

2006-01-20 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Unbreak build (partial commit of animation patch)

  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
  • khtml/xml/DocumentImpl.h:
11:30 AM Changeset in webkit [12264] by eseidel
  • 4 edits in trunk/WebCore

2006-01-20 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Missed the kcanvas directory in my previous commit.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6683

  • kcanvas/KCanvasContainer.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGText.h:
11:24 AM Changeset in webkit [12263] by eseidel
  • 28 edits
    8 copies
    6 moves in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Break classes in render_table out into separate files.
Move render_block to RenderBlock.
Move render_container to RenderContainer.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • kcanvas/KCanvasContainer.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGText.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::insertRow):
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom_position.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • page/Frame.cpp:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp: Added.
  • rendering/RenderBlock.h: Added.
  • rendering/RenderContainer.cpp: Added. (WebCore::RenderContainer::addChild):
  • rendering/RenderContainer.h: Added.
  • rendering/RenderTable.cpp: Added. (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::updateFirstLetter):
  • rendering/RenderTable.h: Added.
  • rendering/RenderTableCell.cpp: Added. (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateFromElement):
  • rendering/RenderTableCell.h: Added.
  • rendering/RenderTableCol.cpp: Added. (WebCore::RenderTableCol::RenderTableCol): (WebCore::RenderTableCol::updateFromElement):
  • rendering/RenderTableCol.h: Added.
  • rendering/RenderTableRow.cpp: Added. (WebCore::RenderTableRow::RenderTableRow):
  • rendering/RenderTableRow.h: Added.
  • rendering/RenderTableSection.cpp: Added. (WebCore::RenderTableSection::RenderTableSection):
  • rendering/RenderTableSection.h: Added.
  • rendering/RenderText.cpp:
  • rendering/bidi.cpp:
  • rendering/render_block.cpp: Removed.
  • rendering/render_block.h: Removed.
  • rendering/render_box.cpp:
  • rendering/render_canvas.h:
  • rendering/render_container.cpp: Removed.
  • rendering/render_container.h: Removed.
  • rendering/render_flexbox.h:
  • rendering/render_flow.cpp:
  • rendering/render_flow.h:
  • rendering/render_form.h:
  • rendering/render_frames.h:
  • rendering/render_inline.cpp:
  • rendering/render_inline.h:
  • rendering/render_line.cpp:
  • rendering/render_list.h:
  • rendering/render_object.cpp:
  • rendering/render_replaced.h:
  • rendering/render_table.cpp: Removed.
  • rendering/render_table.h: Removed.
  • rendering/table_layout.cpp:
11:10 AM Changeset in webkit [12262] by mjs
  • 1 edit
    3 adds in trunk/LayoutTests
  • added test case for a parsing bug that was fixed in different ways in KJS and JSC. In older KJS versions, there would have been a parse error.
  • fast/js/parse-backslash-before-newline-expected.txt: Added.
  • fast/js/parse-backslash-before-newline.html: Added.
  • fast/js/resources/parse-backslash-before-newline.js: Added.
10:45 AM Changeset in webkit [12261] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

  • fast/overflow/image-selection-highlight-expected.checksum: Added.
  • fast/overflow/image-selection-highlight-expected.png: Added.
  • fast/overflow/image-selection-highlight-expected.txt: Added.
  • fast/overflow/image-selection-highlight.html: Added.

WebCore:

Test: fast/overflow/image-selection-highlight.html

Reviewed by Darin, committed by Adele.


  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionRect): Subtract the containing block's scroll offset.
10:13 AM Changeset in webkit [12260] by thatcher
  • 5 copies in tags/Safari-521.6

Final Safari-521.6 tag. Ignore the diffs, they are wrong!

10:11 AM Changeset in webkit [12259] by thatcher
  • 1 delete in tags/Safari-521.6

This tag needs updated.

9:42 AM Changeset in webkit [12258] by thatcher
  • 1 edit in trunk/WebKitSite/contact.html

Add ​irc://irc.freenode.net/#webkit links.

9:26 AM Changeset in webkit [12257] by thatcher
  • 1 edit in trunk/WebKitSite/coding/contributing.html

Fixes the rest of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6535
add <tt></tt> around an instance of "svn diff".

12:18 AM Changeset in webkit [12256] by thatcher
  • 2 edits in trunk/WebKitSite

Replace all "cvs" references with "svn".

Jan 19, 2006:

11:45 PM Changeset in webkit [12255] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Eric.

Adds inline style reporting and mapped attribute support to the Inspector Style pane.
Cleans up the node attributes area with a more natural attr = "value" look.
Slight optimization to only update visible scrollbars during a window resize.

10:42 PM Changeset in webkit [12254] by thatcher
  • 1 edit in trunk

Add WebKitBuild to the svn:ignore

10:21 PM Changeset in webkit [12253] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix a typo that made WebCore build and link UserAgentStyleSheets.cpp every time, even if nothing changed.

9:10 PM Changeset in webkit [12252] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6631
Inspector window has inappropriate maximum height

5:40 PM Changeset in webkit [12251] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • WebKit.xcodeproj/project.pbxproj: made WebNSUserDefaultsExtras.h private (SPI) so its one method can be called from Safari, so Safari can stop calling the similar method in Foundation.
5:22 PM Changeset in webkit [12250] by eseidel
  • 2 edits in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<embed> and <object> tags show up blank when going back/forward.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6679

No test currently possible.

  • page/Frame.cpp: (Frame::canCachePage):
5:02 PM Changeset in webkit [12249] by sullivan
  • 5 edits
    1 add in trunk/WebKit

Reviewed by Tim Omernick.


Made _webKit_guessedMIMEType SPI so Safari can use it in order to stop using
the similar SPI method in Foundation. This involved splitting it out of the file
it was in, to avoid creating any other new SPI here. Poor svn diff got mighty
confused in the process.

  • Misc.subproj/WebNSDataExtras.h: removed _webkit_guessedMIMEType from here
  • Misc.subproj/WebNSDataExtrasPrivate.h: Added. Contains only _webkit_guessedMIMEType. This file is private (SPI), whereas WebNSDataExtras.h is project-internal. I could have renamed WebNSDateExtras.h to WebNSDateExtrasInternal.h also, but I minimized the gratuitous change level here by not doing that.


  • Misc.subproj/WebNSDataExtras.m: Despite the great confusion of svn diff, all I actually did here was move _webkit_guessedMIMEType and its helper _webkit_guessedMIMETypeForXML into a new category. No lines of code were harmed while creating this patch.
  • WebKit.xcodeproj/project.pbxproj: updated for new file
  • WebView.subproj/WebView.m: Added #import for new file since WebView uses _webkit_guessedMIMEType
4:29 PM Changeset in webkit [12248] by thatcher
  • 5 copies in tags/Safari-521.6

Trying the Safari-521.6 tag again

4:26 PM Changeset in webkit [12247] by thatcher
  • 1 delete in tags/Safari-521.6

Bad tag, not sure what happened.

4:22 PM Changeset in webkit [12246] by thatcher
  • 5 copies in tags/Safari-521.6

Tagging Safari-521.6

3:57 PM Changeset in webkit [12245] by thatcher
  • 8 adds in branches/Safari-Leo-branch

Versioning to 521.6

3:50 PM Changeset in webkit [12244] by thatcher
  • 1 add in branches/Safari-Leo-branch
3:50 PM Changeset in webkit [12243] by eseidel
  • 64 edits
    6 copies
    4 moves in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Split html_miscimpl.* into separate files and move html_elementimpl
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6670

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_valueimpl.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/html/HTMLBaseFontElementImpl.cpp: Added.
  • khtml/html/HTMLBaseFontElementImpl.h: Added.
  • khtml/html/HTMLButtonElementImpl.cpp:
  • khtml/html/HTMLCollectionImpl.cpp: Added. (WebCore::HTMLCollectionImpl::traverseNextItem):
  • khtml/html/HTMLCollectionImpl.h: Added.
  • khtml/html/HTMLElementImpl.cpp: Added.
  • khtml/html/HTMLElementImpl.h: Added.
  • khtml/html/HTMLFieldSetElementImpl.cpp:
  • khtml/html/HTMLFormCollectionImpl.cpp: Added.
  • khtml/html/HTMLFormCollectionImpl.h: Added.
  • khtml/html/HTMLFormElementImpl.cpp:
  • khtml/html/HTMLFormElementImpl.h:
  • khtml/html/HTMLGenericFormElementImpl.cpp:
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp:
  • khtml/html/HTMLIsIndexElementImpl.cpp:
  • khtml/html/HTMLLabelElementImpl.h:
  • khtml/html/HTMLLegendElementImpl.cpp:
  • khtml/html/HTMLNameCollectionImpl.cpp: Added.
  • khtml/html/HTMLNameCollectionImpl.h: Added.
  • khtml/html/HTMLOptGroupElementImpl.cpp:
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLOptionElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_blockimpl.cpp:
  • khtml/html/html_blockimpl.h:
  • khtml/html/html_canvasimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_elementimpl.cpp: Removed.
  • khtml/html/html_elementimpl.h: Removed.
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading):
  • khtml/html/html_headimpl.h:
  • khtml/html/html_imageimpl.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_inlineimpl.h:
  • khtml/html/html_listimpl.h:
  • khtml/html/html_miscimpl.cpp: Removed.
  • khtml/html/html_miscimpl.h: Removed.
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmlfactory.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution):
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/dom2_rangeimpl.cpp:
  • khtml/xml/dom_elementimpl.cpp:
  • kwq/KWQAccObject.mm:
  • loader/loader.cpp:
  • page/Frame.cpp: (Frame::restoreURL): (Frame::stopLoading): (Frame::receivedFirstData): (Frame::gotoAnchor): (Frame::requestObject): (Frame::processObjectRequest): (Frame::submitForm): (Frame::slotParentCompleted): (Frame::findFrame): (Frame::executeScript):
  • page/FrameView.cpp: (FrameView::useSlowRepaints):
  • rendering/render_applet.cpp:
  • rendering/render_applet.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::contentWidth): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcHeight):
  • rendering/render_canvasimage.cpp:
  • rendering/render_canvasimage.h:
  • rendering/render_frames.cpp:
  • rendering/render_image.cpp:
  • rendering/render_image.h:
  • rendering/render_layer.cpp:
3:44 PM Changeset in webkit [12242] by thatcher
  • 1 delete in branches/Safari-Leo-branch

Redoing this branch so we only include Info.plists

3:08 PM Changeset in webkit [12241] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/report-include-statistics: Added a new script.
1:42 PM Changeset in webkit [12240] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

  • Misc.subproj/WebNSURLExtras.h: added declaration of _webkit_rangeOfURLScheme so Safari can call it as a step towards weaning Safari from Foundation SPI.
11:45 AM Changeset in webkit [12239] by thatcher
  • 2 edits in trunk/WebKitTools
  • Scripts/build-webkit: include JavaScriptGlue in the build
10:57 AM Changeset in webkit [12238] by darin
  • 1 edit in trunk/Makefile

Build JavaScriptGlue.

9:14 AM Changeset in webkit [12237] by andersca
  • 7 edits in trunk

2006-01-19 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::cssPropertyGetter): if getCSSPropertyValue returns 0 (which is true for shorthand properties), try getPropertyValue instead.
1:35 AM Changeset in webkit [12236] by adele
  • 10 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt and Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6665
Implement NSView-less version of <input type="text">


Initial implementation of new and improved text fields.
This will only be turned on if an input element has khtml-appearance: textfield.

  • WebCore.xcodeproj/project.pbxproj: Added RenderTextField.h and RenderTextField.cpp
  • css/cssvalues.in: Fixed omitted button-bevel value. This was causing an off-by-one error when getting khtml-appearance value.
  • khtml/html/HTMLInputElementImpl.cpp: Added checks for khtml-appearance to decide when to use RenderTextField instead of RenderLineEdit. (DOM::HTMLInputElementImpl::selectionStart): (DOM::HTMLInputElementImpl::selectionEnd): (DOM::HTMLInputElementImpl::setSelectionStart): (DOM::HTMLInputElementImpl::setSelectionEnd): (DOM::HTMLInputElementImpl::select): (DOM::HTMLInputElementImpl::setSelectionRange): (DOM::HTMLInputElementImpl::createRenderer): (DOM::HTMLInputElementImpl::defaultEventHandler):
  • khtml/html/HTMLInputElementImpl.h:
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isFocusable): Also allow editable elements with no parent to be focusable.
  • khtml/xml/NodeImpl.h: (WebCore::NodeImpl::setAttached): Added to set m_attached without having to call attach().
  • rendering/RenderTextField.cpp: Added. (khtml:::RenderBlock): (khtml::RenderTextField::~RenderTextField): (khtml::RenderTextField::addChild): (khtml::RenderTextField::removeChild): (khtml::RenderTextField::setStyle): (khtml::RenderTextField::getDivStyle): (khtml::RenderTextField::updateFromElement): (khtml::RenderTextField::selectionStart): (khtml::RenderTextField::selectionEnd): (khtml::RenderTextField::setSelectionStart): (khtml::RenderTextField::setSelectionEnd): (khtml::RenderTextField::select): (khtml::RenderTextField::setSelectionRange):
  • rendering/RenderTextField.h: Added. (khtml::RenderTextField::removeLeftoverAnonymousBoxes): (khtml::RenderTextField::renderName):
  • rendering/render_container.cpp: (RenderContainer::destroy): use renamed destroyLeftoverChildren. (RenderContainer::destroyLeftoverChildren): renamed from destroyLeftoverAnonymousChildren.
  • rendering/render_container.h:
  • rendering/render_flow.cpp: (RenderFlow::destroy): use renamed destroyLeftoverChildren.
1:20 AM Changeset in webkit [12235] by eseidel
  • 5 edits
    4 adds in trunk

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin & anders.

Fix opacity crasher for <text> and <image>.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6668
Even though the crash is fixed, opacity still doesn't work.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6669

  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (RenderSVGText::paint):
1:18 AM Changeset in webkit [12234] by darin
  • 21 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Changed SVG check to work even if the path has spaces in it by using the form of open that treats each argument as a string rather than backtick syntax for reading the output of the nm tool.
12:59 AM Changeset in webkit [12233] by darin
  • 43 edits
    4 deletes in trunk/WebCore

Reviewed by Hyatt.

  • removed all use of QMap
  • ForwardingHeaders/qmap.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed KWQMap.h, KWQMapImpl.h, KWQMapImpl.cpp.
  • kwq/KWQMap.h: Removed.
  • kwq/KWQMapImpl.cpp: Removed.
  • kwq/KWQMapImpl.h: Removed.
  • bridge/BrowserExtension.h: (WebCore::URLArgs::metaData): Converted from QMap of QString to HashMap of DOMString.
  • bridge/mac/BrowserExtensionMac.mm: Ditto.
  • bridge/mac/MacFrame.mm: (MacFrame::openURLRequest): Ditto. (MacFrame::urlSelected): Ditto. (MacFrame::createPart): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::parseModalDialogFeatures): Ditto. (KJS::boolFeature): Ditto. (KJS::intFeature): Ditto. (KJS::createNewWindow): Ditto. (KJS::showModalDialog): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::createRenderer): Ditto.
  • khtml/xml/dom_xmlimpl.cpp: (DOM::ProcessingInstructionImpl::checkStyleSheet): Ditto.
  • khtml/xml/xml_tokenizer.cpp: (WebCore::toString): Added. Converts to DOMString instead of QString. (WebCore::attributesStartElementNsHandler): Converted from QMap of QString to HashMap of DOMString. (WebCore::parseAttributes): Ditto.
  • khtml/xml/xml_tokenizer.h: (WebCore::Tokenizer::setTransformSource): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll): Ditto.
  • kwq/KWQKJavaAppletWidget.h: Ditto.
  • kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): Ditto.
  • kwq/KWQKJobClasses.h: Ditto.
  • kwq/KWQKJobClasses.mm: (KIO::TransferJob::addMetaData): Ditto.
  • page/Frame.cpp: (Frame::didOpenURL): Ditto. (Frame::changeLocation): Ditto. (Frame::mark): Ditto. (Frame::setMark): Ditto. (Frame::urlSelected): Ditto. (Frame::requestObject): Ditto. (Frame::processObjectRequest): Ditto. (Frame::submitForm): Ditto.
  • rendering/render_applet.cpp: (WebCore::RenderApplet::RenderApplet): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Ditto. (WebCore::RenderApplet::layout): Ditto.
  • rendering/render_applet.h: (WebCore::RenderApplet::renderName): Ditto. (WebCore::RenderApplet::element): Ditto. (WebCore::RenderEmptyApplet::renderName): Ditto.
  • khtml/dom/dom_string.h: (WebCore::DOMString::createCFString): Added. Not yet implemented or used. (WebCore::DOMString::operator NSString*): Updated to call through to DOMStringImpl. Added hash functions and hash traits so you can use DOMString in hash tables.
  • khtml/xml/dom_stringimpl.h: Added conversion to and from CFStringRef/NSString.
  • khtml/xml/dom_stringimpl.cpp: Took out an excess "DOM::".
  • bindings/objc/DOMInternal.mm: (DOMStringImpl::operator NSString *): Moved from DOMString to DOMStringImpl.
  • changed the mark from a SelectionController to a Selection (maybe it can be a Position instead?)
  • page/Frame.h: Changed mark() and setMark() to use a Selection.
  • page/FramePrivate.h: Changed mark to a Selection.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setMarkDOMRange:]): Updated for change from SelectionController to Selection.
  • removed extraneous includes
  • kwq/KWQKHTMLSettings.h: Removed include of "KWQMap.h".
  • kwq/KWQKIOGlobal.h: Ditto.
  • khtml/editing/htmlediting.h: Removed extraneous includes and namespace prefixes.
  • khtml/html/html_canvasimpl.h: Removed extraneous includes and moved into the WebCore namespace.
  • khtml/html/html_canvasimpl.cpp: Ditto.
  • khtml/html/htmltokenizer.cpp: Ditto.
  • khtml/html/htmltokenizer.h: Ditto.
  • khtml/xml/DocumentImpl.cpp: Ditto.
  • kwq/KWQEditCommand.mm: Ditto.
  • rendering/render_canvasimage.h: Ditto.
  • rendering/render_image.h: Ditto.
  • khtml/editing/composite_edit_command.cpp: Updated includes because of ones that were removed from headers.
  • khtml/editing/htmlediting.cpp: Ditto.
  • khtml/editing/jsediting.cpp: Ditto.
  • khtml/editing/replace_selection_command.cpp: Ditto.
  • rendering/render_canvasimage.cpp: Ditto.
  • rendering/render_image.cpp: Ditto.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): Removed code to add the cache control string, since that was hardcoded to empty string anyway.
12:59 AM Changeset in webkit [12232] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Hyatt.

  • hash table fixes needed for my WebCore changes
  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::operator=): Added a missing return statement.
  • kxmlcore/HashTraits.h: Fix traits so they work properly for classes where you can't instantiate with a 0 by using traits rather than ? : to select the default emtpy value of hash table keys.
  • small cleanup of "runtime" code left over from recent JavaScript crash fix
  • bindings/runtime_root.h: (KJS::Bindings::RootObject::RootObject): No explicit initialization of _imp needed since it's now a ProtectedPtr. (KJS::Bindings::RootObject::setRootObjectImp): Remove old code that relied on the fact that _imp was 0 and replaced with use of ProtectedPtr. (KJS::Bindings::RootObject::rootObjectImp): Updated since _imp is a ProtectedPtr.
12:16 AM Changeset in webkit [12231] by eseidel
  • 2 edits in trunk/WebCore

2006-01-19 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove CFDictionary usage from KWQObject.*
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6468

  • kwq/KWQObject.cpp: (KWQObjectTimer::KWQObjectTimer): (QObject::restartTimer): (QObject::timerIntervals): (KWQObjectTimer::deleteTimer): (QObject::killTimer): (QObject::killTimers): (sendDeferredTimerEvent):
Note: See TracTimeline for information about the timeline view.