Context Navigation

← Previous Period
Next Period →

Timeline

Jan 21, 2006:

10:20 PM Changeset in webkit [12280] by staikos

5 edits in trunk/JavaScriptCore

Reviewed by Maciej

Merge some build fixes for various Perl and gcc versions from KDE SVN.

8:28 PM Changeset in webkit [12279] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3509 REGRESSION(125-412) Portion of nested table is not painted correctly on cafepress site

manual-tests/bugzilla-3509.html: Added.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Force repaint if the child didn't move but didn't repaint correctly during layout because it was not at its final position then.

4:25 PM Changeset in webkit [12278] by thatcher

2 edits in trunk/WebKit

Reviewed by Anders Carlsson.

Make sure shorthand properties get striked-out if
all the properties they expand into are overloaded.

WebInspector.subproj/webInspector/inspector.js:

2:11 PM Changeset in webkit [12277] by eseidel

4 edits in trunk/WebKitTools

2006-01-20 David Kilzer <ddkilzer@kilzer.net>

Reviewed by eseidel.

fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6682 Call to checkWebCoreSVGSupport() broken in build-drawtest and run-drawtest

Scripts/build-drawtest: Changed bareword 'true' to 1.
Scripts/run-drawtest: Changed bareword 'true' to 1.

1:58 PM Changeset in webkit [12276] by andersca

7 edits
7 adds in trunk

2006-01-21 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3869
Should use HTML Image element instead of JS Image object

khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction): Don't check Image object. Instead, if the element passed in is an image element which isn't in any document, use its pixmap.

khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::imageGetter): Add complete.

(KJS::ImageConstructorImp::construct):
Take a QPixmap instead of an Image.

(KJS::KJS::Context2DFunction::callAsFunction):
Remove usage of Image and use HTMLImageElementImpl instead.

khtml/ecma/kjs_html.h: Remove Image class.

(KJS::HTMLElement::):
Add ImgComplete.

khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): If the element has no renderer but its image size is known return that instead.

(WebCore::HTMLImageElementImpl::complete):
New function, returns true if an image has finished loading.

khtml/html/html_imageimpl.h: Add complete.

manual-tests/drag-image.html: Added.

1:20 PM Changeset in webkit [12275] by andersca

2 edits in trunk/LayoutTests

2006-01-21 Anders Carlsson <andersca@mac.com>

editing/editing.js: Fix typo which made editing test cases fail.

12:15 PM Changeset in webkit [12274] by andersca

4 edits
4 adds in trunk

2006-01-21 Anders Carlsson <andersca@mac.com>

Reviewed by Darin.

fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=6691 TinyMCE: strikethrough unimplemented

khtml/editing/jsediting.cpp: Add support for the "Strikethrough" command.

12:02 PM Changeset in webkit [12273] by darin

6 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5983 REGRESSION: onmouseover-powered navbar at MacNN renders incorrectly

fast/dynamic/hovered-detach.html: Added.
fast/dynamic/hovered-detach-expected.txt: Added.

WebCore:

Test: fast/dynamic/hovered-detach.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5983 REGRESSION: onmouseover-powered navbar at MacNN renders incorrectly

khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Set m_hovered to false and set the document's hoverNode to an hovered ancestor that still has a renderer.
rendering/render_layer.cpp: Changed static method hoverAncestor() into a RenderObject instance method. (WebCore::commonAncestor): (WebCore::RenderLayer::updateHoverActiveState):
rendering/render_object.cpp: Ditto. (WebCore::RenderObject::hoverAncestor)
rendering/render_object.h: Ditto.

11:22 AM Changeset in webkit [12272] by thatcher

4 edits in trunk/WebKit

Reviewed by Darin.

Adds computed style to the Web Inspector.
Adds a "mapped style" link to the mapped attributes.

WebInspector.subproj/webInspector/inspector.css:
WebInspector.subproj/webInspector/inspector.html:
WebInspector.subproj/webInspector/inspector.js:

Jan 20, 2006:

7:47 PM Changeset in webkit [12271] by hyatt

2 edits in trunk/WebCore

Fix for bug 6666, pseudo-element rules incorrectly displayed
in Web Inspector.

Reviewed by darin

Added fast/inspector/matchedrules.html as test case.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList):

7:45 PM Changeset in webkit [12270] by hyatt

2 adds in trunk/LayoutTests/fast/inspector

Add a test case for Web Inspector style matching bug.

7:05 PM Changeset in webkit [12269] by thatcher

7 edits
2 deletes in trunk

WebCore:

Reviewed by John.

Removes code that is no longer needed with the new Web Inspector.

bridge/mac/WebCoreFrameBridge.h: removes the WebCoreDOMTreeCopier protocol.
bridge/mac/WebCoreFrameBridge.mm: removes copyDOMNode:copier:

WebKit:

Reviewed by John, some parts by Darin.

Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
that menu item to prevent a crash.

WebKit.exp: adds WebInspector, removes WebDebugDOMNode
WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
WebView.subproj/WebDebugDOMNode.h: Removed.
WebView.subproj/WebDebugDOMNode.m: Removed.
WebView.subproj/WebView.m: (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item

5:03 PM Changeset in webkit [12268] by andersca

17 edits in trunk/WebCore

2006-01-21 Anders Carlsson <andersca@mac.com>

Reviewed by David Hyatt.

Rename Frame::xmlDocImpl => Frame::document and
Frame::replaceDocImpl => Frame::setDocument

bridge/mac/MacFrame.mm: (MacFrame::findString): (MacFrame::advanceToNextMisspelling): (MacFrame::nextKeyViewInFrame): (MacFrame::nextKeyViewInFrameHierarchy): (MacFrame::keyEvent): (MacFrame::dispatchCPPEvent): (MacFrame::setDisplaysWithFocusAttributes): (MacFrame::bodyBackgroundColor): (MacFrame::markMisspellings): (MacFrame::respondToChangedSelection): (MacFrame::setMarkedTextRange): (MacFrame::dashboardRegionsDictionary): (MacFrame::shouldClose):
bridge/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings): (frameHasSelection): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge saveDocumentState]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge saveDocumentToPageCache]): (-[WebCoreFrameBridge _documentTypeString]): (-[WebCoreFrameBridge deselectAll]): (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge _setupRootForPrinting:]): (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]): (-[WebCoreFrameBridge copyDOMTree:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge unmarkAllMisspellings]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge DOMDocument]): (-[WebCoreFrameBridge baseURL]): (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge numPendingOrLoadingRequests]): (-[WebCoreFrameBridge doneProcessingData]): (-[WebCoreFrameBridge selectionColor]): (-[WebCoreFrameBridge accessibilityTree]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]): (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): (-[WebCoreFrameBridge documentFragmentWithText:]): (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:]):
khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowFunc::callAsFunction): (KJS::Window::updateLayout): (KJS::ScheduledAction::execute): (KJS::Location::put): (KJS::LocationFunc::callAsFunction):
khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequestProtoFunc::callAsFunction):
khtml/editing/jsediting.cpp:
khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::contentDocument):
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
kwq/KWQAccObject.mm: (-[KWQAccObject textUnderElement]): (-[KWQAccObject doAXTextMarkerForPosition:]): (-[KWQAccObject rendererForView:]):
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
page/Frame.cpp: (Frame::document): (Frame::setDocument): (Frame::setFocusNodeIfNeeded): (Frame::isPointInsideSelection): (Frame::computeAndSetTypingStyle): (Frame::applyStyle): (Frame::applyParagraphStyle): (Frame::selectionComputedStyle): (Frame::selectFrameElementInParentIfFullySelected): (Frame::renderer): (Frame::scrollOverflow): (Frame::paint): (Frame::adjustPageHeight): (Frame::updatePolicyBaseURL): (Frame::setPolicyBaseURL): (Frame::forceLayoutWithPageWidthRange): (Frame::sendScrollEvent): (Frame::clearTimers): (Frame::styleForSelectionStart): (Frame::setSelectionFromNone): (Frame::setWindowHasFocus): (Frame::backslashAsCurrencySymbol):
page/Frame.h:
page/FrameView.cpp: (FrameView::~FrameView): (FrameView::clear): (FrameView::resizeEvent): (FrameView::adjustViewSize): (FrameView::layout): (FrameView::updateDashboardRegions): (FrameView::viewportMousePressEvent): (FrameView::viewportMouseDoubleClickEvent): (FrameView::viewportMouseMoveEvent): (FrameView::viewportMouseReleaseEvent): (FrameView::keyPressEvent): (FrameView::dispatchDragEvent): (FrameView::updateDragAndDrop): (FrameView::focusNextPrevNode): (FrameView::dispatchMouseEvent): (FrameView::viewportWheelEvent): (FrameView::timerEvent): (FrameView::scheduleRelayout): (FrameView::unscheduleRelayout):
rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):

2:54 PM Changeset in webkit [12267] by thatcher

2 edits in trunk/WebKit

Reviewed by Hyatt.

Corrects the cascade order for mapped attributes.
Shows "inline stylesheet" rather than "null" for rules in <style> tags.

WebInspector.subproj/webInspector/inspector.js:

1:48 PM Changeset in webkit [12266] by cpeterse

2 edits in trunk/WebCore

Reviewed by eseidel.

Build fix.

khtml/xml/DocumentImpl.cpp:

12:20 PM Changeset in webkit [12265] by eseidel

3 edits in trunk/WebCore

2006-01-20 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Unbreak build (partial commit of animation patch)

khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
khtml/xml/DocumentImpl.h:

11:30 AM Changeset in webkit [12264] by eseidel

4 edits in trunk/WebCore

2006-01-20 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Missed the kcanvas directory in my previous commit.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6683

kcanvas/KCanvasContainer.h:
kcanvas/RenderForeignObject.h:
kcanvas/RenderSVGText.h:

11:24 AM Changeset in webkit [12263] by eseidel

28 edits
8 copies
6 moves in trunk/WebCore

2006-01-19 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Break classes in render_table out into separate files.
Move render_block to RenderBlock.
Move render_container to RenderContainer.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm:
kcanvas/KCanvasContainer.h:
kcanvas/RenderForeignObject.h:
kcanvas/RenderSVGText.h:
khtml/editing/visible_units.cpp:
khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::insertRow):
khtml/xml/dom2_rangeimpl.cpp:
khtml/xml/dom_position.cpp:
kwq/KWQRenderTreeDebug.cpp:
page/Frame.cpp:
rendering/InlineTextBox.cpp:
rendering/RenderBlock.cpp: Added.
rendering/RenderBlock.h: Added.
rendering/RenderContainer.cpp: Added. (WebCore::RenderContainer::addChild):
rendering/RenderContainer.h: Added.
rendering/RenderTable.cpp: Added. (WebCore::RenderTable::RenderTable): (WebCore::RenderTable::updateFirstLetter):
rendering/RenderTable.h: Added.
rendering/RenderTableCell.cpp: Added. (WebCore::RenderTableCell::RenderTableCell): (WebCore::RenderTableCell::updateFromElement):
rendering/RenderTableCell.h: Added.
rendering/RenderTableCol.cpp: Added. (WebCore::RenderTableCol::RenderTableCol): (WebCore::RenderTableCol::updateFromElement):
rendering/RenderTableCol.h: Added.
rendering/RenderTableRow.cpp: Added. (WebCore::RenderTableRow::RenderTableRow):
rendering/RenderTableRow.h: Added.
rendering/RenderTableSection.cpp: Added. (WebCore::RenderTableSection::RenderTableSection):
rendering/RenderTableSection.h: Added.
rendering/RenderText.cpp:
rendering/bidi.cpp:
rendering/render_block.cpp: Removed.
rendering/render_block.h: Removed.
rendering/render_box.cpp:
rendering/render_canvas.h:
rendering/render_container.cpp: Removed.
rendering/render_container.h: Removed.
rendering/render_flexbox.h:
rendering/render_flow.cpp:
rendering/render_flow.h:
rendering/render_form.h:
rendering/render_frames.h:
rendering/render_inline.cpp:
rendering/render_inline.h:
rendering/render_line.cpp:
rendering/render_list.h:
rendering/render_object.cpp:
rendering/render_replaced.h:
rendering/render_table.cpp: Removed.
rendering/render_table.h: Removed.
rendering/table_layout.cpp:

11:10 AM Changeset in webkit [12262] by mjs

1 edit
3 adds in trunk/LayoutTests

added test case for a parsing bug that was fixed in different ways in KJS and JSC. In older KJS versions, there would have been a parse error.

fast/js/parse-backslash-before-newline-expected.txt: Added.
fast/js/parse-backslash-before-newline.html: Added.
fast/js/resources/parse-backslash-before-newline.js: Added.

10:45 AM Changeset in webkit [12261] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin, committed by Adele.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6673 Selection highlight doesn't scroll along with an image contained in an overflow:scroll block