⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 22, 2006:

11:23 PM Changeset in webkit [12306] by darin
  • 2 edits
    1 delete in trunk/WebCore
  • Info.plist: Updated Apple copyright date. Need to update others too at some point.
  • WebCore-svg.exp: Removed unused empty file.
11:20 PM Changeset in webkit [12305] by staikos
  • 6 edits in trunk/JavaScriptCore

Reviewed by Maciej and Darin.

  • kxmlcore/Assertions.h: This file only works with APPLE right now
  • kjs/interpreter.cpp: ditto
  • kjs/simple_number.h: Add assert.h and remove from config.h
  • kjs/array_object.cpp: Use relative paths for kxmlcore includes
  • kjs/testkjs.cpp: Use relative paths for kxmlcore includes
11:01 PM Changeset in webkit [12304] by staikos
  • 2 edits in trunk/JavaScriptCore

Rubber stamp from Maciej:

  • Assertions is only valid in APPLE right now
11:00 PM Changeset in webkit [12303] by eseidel
  • 24 edits
    2 adds in trunk/WebCore

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make <animateColor> work again (broke during DOM merger).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5964

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::getAbsoluteRepaintRect): moved to .cpp file
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose): start svg animations (WebCore::DocumentImpl::svgExtensions): svg document extensions (WebCore::DocumentImpl::accessSVGExtensions): svg doc extensions
  • khtml/xml/DocumentImpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): cleanup
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent): update css lookup
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent): fix css property lookup
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer): use doc extensions (SVGAnimationElementImpl::targetAttribute): fix css properties (SVGAnimationElementImpl::setTargetAttribute): fix css properties
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::svgView): remove unnecessary static cast (SVGDocumentImpl::executeScripts):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.cpp: (WebCore::SVGElementImpl::addSVGEventListener): helper function (WebCore::SVGElementImpl::parseMappedAttribute): use helper
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGGElementImpl.cpp:
  • ksvg2/svg/SVGGElementImpl.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::SVGSVGElementImpl): (WebCore::SVGSVGElementImpl::~SVGSVGElementImpl): (WebCore::SVGSVGElementImpl::addSVGWindowEventListner): helper (WebCore::SVGSVGElementImpl::parseMappedAttribute): use helper
  • ksvg2/svg/SVGSVGElementImpl.h:
  • ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent): use doc extensions
  • ksvg2/svg/SVGStyledElementImpl.h:
  • page/Frame.cpp: (Frame::pauseTimeouts): pause svg animation (Frame::resumeTimeouts): resume svg animation
  • rendering/render_canvas.h:
10:55 PM Changeset in webkit [12302] by staikos
  • 2 edits in trunk/JavaScriptCore

unbreak preprocessor change
Reviewed by Maciej

10:10 PM Changeset in webkit [12301] by staikos
  • 17 edits in trunk/JavaScriptCore

Approved by Maciej and Darin.

  • kjs/:
  • kxmlcore/:

Update FSF address in license to make merging easier

9:44 PM Changeset in webkit [12300] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej and Darin.

  • kjs/collector.cpp: merge major speedup from KDE on Linux

patch by Maks Orlovich, bug #6145
Also unify cpu detection

  • kjs/config.h: define simpler CPU macros
9:43 PM Changeset in webkit [12299] by darin
  • 2 edits in trunk/WebCore
  • fix deployment builds
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Init bool.
9:29 PM Changeset in webkit [12298] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/table/form-with-table-style.html: Added.
  • fast/table/form-with-table-style-expected.txt: Added.
  • fast/table/form-with-table-style-expected.png: Added.
  • fast/table/form-with-table-style-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

Test: fast/table/form-with-table-style.html

Hang was caused by the fact that RenderContainer has code to wrap table
styled elements in appropriate anonymous table elements, but the table
elements themselves have a special case for form elements that causes them
to call through, which led to infinite recursion as RenderContainer kept
making new tables which kept calling through to RenderContainer::addChild.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Improved logic about wrapping children in anonymous table sections in the following ways: (1) Do wrap a form properly it has a table display style (such as table-cell or table-row). (2) When an item has a particular display style, check that it has the right type of render object before casting it to that type. Also restructured the code a little to make it slightly more readable. (WebCore::RenderTable::layout): Added a FIXME about forms that have a display style that makes it a table section, since they will be skipped here in the loop to lay children out. (WebCore::RenderTable::recalcSections): Added checks similar to the ones in addChild above.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Moved form tag logic inside render object type check so that a table row that happens to be a form element won't be affected by the special form tag logic. Also added an explicit check for the table-cell style so we will wrap it in a row rather than just putting the form at this level.
  • rendering/RenderTableRow.h: Removed removeChildNode and dump functions that just called through to the base class.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): Moved form tag logic inside render object type check so that a table cell that happens to be a form element won't be affected by the special form tag logic. Removed unnecessary null check of section() at end of function.
  • rendering/RenderTableCol.h: Removed addChild because all it did was assert (incorrectly) and then call through to the base class. Changed _span to be m_span.
  • rendering/RenderTableCol.cpp: Removed addChild function. Updated for change in name of m_span field.
9:07 PM Changeset in webkit [12297] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQListBox.mm: (QListBox::QListBox): Call setCopiesOnScroll:NO.
  • kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Ditto.
8:39 PM Changeset in webkit [12296] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej
Compile fix for FreeBSD 5.4 from KDE

6:53 PM Changeset in webkit [12295] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added a few Radar bug numbers for future searching purposes.

6:47 PM Changeset in webkit [12294] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/button-white-space-expected.checksum: Added.
  • fast/forms/button-white-space-expected.png: Added.
  • fast/forms/button-white-space-expected.txt: Added.
  • fast/forms/button-white-space.html: Added.

WebCore:

Reviewed by Maciej.

  • css/html4.css: Remove default white-space value for <button> tag to allow it to be inherited.
  • rendering/render_theme_mac.mm: (khtml::RenderThemeMac::adjustButtonStyle): Fix misleading comment.
  • css/UserAgentStyleSheets.cpp: Touched this file to make the rebuild of html4.css work (shouldn't have to do this).
6:35 PM Changeset in webkit [12293] by darin
  • 2 edits in trunk/WebCore
  • css/make-css-file-arrays.pl: Fix typo that was resulting in a bunch of whitespace that was supposed to go into a derived source file going to the console instead.
3:53 PM Changeset in webkit [12292] by eseidel
  • 17 edits
    6 adds in trunk

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

SVG needs to support "evt" instead of "event" in event handlers.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5874

  • WebCore.xcodeproj/project.pbxproj: added new classes
  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_events.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::createHTMLEventHandler): simplified (WebCore::KJSProxyImpl::createSVGEventHandler): new
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/ecma/kjs_window.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::createHTMLEventListener): simplified (WebCore::DocumentImpl::createSVGEventListener): new
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): use RefPtr
  • ksvg2/events/JSSVGLazyEventListener.cpp: Added. (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): added. (WebCore::JSSVGLazyEventListener::eventParameterName): added.
  • ksvg2/events/JSSVGLazyEventListener.h: Added.
  • ksvg2/svg/SVGElementImpl.cpp: (SVGElementImpl::parseMappedAttribute): use new SVG event handler
  • ksvg2/svg/SVGSVGElementImpl.cpp: (SVGSVGElementImpl::parseMappedAttribute): use new SVG event handler
  • page/Frame.cpp: updated KJSProxyImpl namespace
  • page/Frame.h: updated KJSProxyImpl namespace
  • page/FramePrivate.h: updated KJSProxyImpl namespace
2:57 PM Changeset in webkit [12291] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders Carlsson.


Makes the Inspector's Style pane take !important into account
when marking overloaded properties.

2:32 PM Changeset in webkit [12290] by darin
  • 11 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/css/position-negative-top-margin.html: Added.
  • fast/css/position-negative-top-margin-expected.txt: Added.
  • fast/css/position-negative-top-margin-expected.png: Added.
  • fast/css/position-negative-top-margin-expected.checksum: Added.
  • fast/box-sizing/box-sizing-expected.txt: Updated, since absolute position box locations changed.
  • fast/box-sizing/box-sizing-expected.png: Ditto.
  • fast/box-sizing/box-sizing-expected.checksum: Ditto.
  • changed a few suitable tests to dump as text (in part to fix a failing pixel test in one)
  • fast/parser/entity-surrogate-pairs.html: Added a call to dumpAsText().
  • fast/parser/entity-surrogate-pairs-expected.txt: Now a plain text file instead of a render tree.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/head-comment.html Added a call to dumpAsText().
  • fast/parser/head-comment-expected.txt: Now a plain text file instead of a render tree.
  • fast/parser/head-comment-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.

WebCore:

Reviewed by Maciej.

Test: fast/css/position-negative-top-margin.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustPositionedBlock): Fixed two different problems that contributed to the bug: (1) Added a call to calcVerticalMargins otherwise the margin will always be 0. (2) Corrected logic for the negative margin case, which was comparing a negative margin-top to a number representing the absolute value of the margin.
1:27 PM Changeset in webkit [12289] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Maciej mentioned he reviewed the change George just landed, so updating the log to reflect that.

12:32 PM Changeset in webkit [12288] by ap
  • 5 edits
    12 adds in trunk

Reviewed by Darin.

Also replaced tabs with spaces in the changed files.

Test cases:

  • fast/table/append-cells.html
  • fast/table/append-cells2.html
  • fast/table/remove-td-display-none.html
  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Shrink columns and columnPos to the actual number of columns.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::numColumns): New function. (WebCore::RenderTableSection::dump): Use gridRows instead of grid.size() for row count, preventing crashes.
  • rendering/RenderTableSection.h: Added numColumns() and a comment about cCol/cRow.
12:20 PM Changeset in webkit [12287] by darin
  • 22 edits in trunk/WebCore

Reviewed by Anders.

Once we do the same with cloneNode, I believe we'll fix one of our P1 bugs,
but cloneNode was a little too much to do without doing this first pass.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::childNodes): Updated for parameter changes. (WebCore::NodeImpl::insertBefore): Ditto. (WebCore::NodeImpl::replaceChild): Ditto. (WebCore::NodeImpl::removeChild): Ditto. (WebCore::NodeImpl::appendChild): Ditto. (WebCore::NodeImpl::addChild): Ditto. (WebCore::NodeImpl::addEventListener): Ditto. (WebCore::NodeImpl::setHTMLEventListener): Ditto. (WebCore::NodeImpl::isDefaultNamespace): Updated for changed name of ancestorElement. (WebCore::NodeImpl::lookupPrefix): Ditto. (WebCore::NodeImpl::lookupNamespaceURI): Ditto. (WebCore::NodeImpl::lookupNamespacePrefix): Ditto. (WebCore::NodeImpl::ancestorElement): Changed name from getAncestorElement.
  • khtml/xml/NodeImpl.h: Changed most functions where it makes sense to take and return PassRefPtr instead of raw pointers. Even non-obvious cases like appendChild, where the return value has to be PassRefPtr only because it might be removed when the JavaScript triggered by the DOM mutation event runs (normally, there's no need to return an "owning" pointer because the tree now owns the newly-inserted node). Made the ancestorElement function private.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::ContainerNodeImpl): Updated for changes from _first to m_firstChild and _last to m_lastChild. (WebCore::ContainerNodeImpl::removeAllChildren): Ditto. (WebCore::ContainerNodeImpl::firstChild): Ditto. (WebCore::ContainerNodeImpl::lastChild): Ditto. (WebCore::ContainerNodeImpl::insertBefore): Updated for parameter changes. (WebCore::ContainerNodeImpl::replaceChild): Ditto. (WebCore::ContainerNodeImpl::willRemove): Updated for m_lastChild. (WebCore::ContainerNodeImpl::removeChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::removeChildren): Updated for m_first/lastChild. (WebCore::ContainerNodeImpl::appendChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::hasChildNodes): Updated for m_firstChild. (WebCore::ContainerNodeImpl::addChild): Updated for parameter changes. (WebCore::ContainerNodeImpl::attach): Updated for m_firstChild. (WebCore::ContainerNodeImpl::detach): Ditto. (WebCore::ContainerNodeImpl::insertedIntoDocument): Ditto. (WebCore::ContainerNodeImpl::removedFromDocument): Ditto. (WebCore::ContainerNodeImpl::insertedIntoTree): Ditto. (WebCore::ContainerNodeImpl::removedFromTree): Ditto.
  • khtml/xml/ContainerNodeImpl.h: Removed unused checkSameDocument and checkIsChild. Made more things private, updated parameters for NodeImpl functions.
  • khtml/html/HTMLSelectElementImpl.cpp: (DOM::HTMLSelectElementImpl::insertBefore): Ditto. (DOM::HTMLSelectElementImpl::replaceChild): Ditto. (DOM::HTMLSelectElementImpl::removeChild): Ditto. (DOM::HTMLSelectElementImpl::appendChild): Ditto. (DOM::HTMLSelectElementImpl::addChild): Ditto.
  • khtml/html/HTMLSelectElementImpl.h: Ditto.
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): Updated for parameter type change. Also changed to look at return value, not exception code, to check for success. (WebCore::HTMLOptGroupElementImpl::replaceChild): Ditto. (WebCore::HTMLOptGroupElementImpl::removeChild): Ditto. (WebCore::HTMLOptGroupElementImpl::appendChild): Ditto. (WebCore::HTMLOptGroupElementImpl::addChild): Ditto.
  • khtml/html/HTMLOptGroupElementImpl.h: Ditto.
  • WebCore+SVG/kdom.h: Renamed enum from ExceptionCode to ExceptionCodes to avoid conflict with a typedef ExceptionCode I added.
  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): Added get() call since return value is a PassRefPtr. (-[DOMNode replaceChild::]): Ditto. (-[DOMNode removeChild:]): Ditto. (-[DOMNode appendChild:]): Ditto.
  • khtml/ecma/kjs_dom.h: Changed getDOMNode to take PassRefPtr.
  • khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Changed to take PassRefPtr.
  • khtml/html/HTMLElementImpl.cpp: Added dom2_events.h include, now needed. Re-sorted includes.
  • ksvg2/svg/SVGElementImpl.cpp: Ditto.
  • khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::documentElement): Changed access to now-private data member _first to equivalent inline function fastFirstChild().
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle): Ditto.
  • khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::recalcStyle): Ditto.
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::setCaption): Updated to work with new replaceChild that returns PassRefPtr. (WebCore::HTMLTableElementImpl::setTHead): Ditto. (WebCore::HTMLTableElementImpl::setTFoot): Ditto. (WebCore::HTMLTableElementImpl::setTBody): Ditto. (WebCore::HTMLTableElementImpl::addChild): Updated for parameter type change. (WebCore::HTMLTableSectionElementImpl::addChild): Ditto. (WebCore::HTMLTableRowElementImpl::addChild): Ditto.
  • khtml/html/html_tableimpl.h: Ditto.
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): Removed an unneeded explicit call to removeChild. appendChild already takes care of removing the child from its own location. This avoids the fact that removeChild was removing the parent, the only thing keeping the node alive. This is sort of the "flip side" of our removeChild leaks -- code that depended on the behavior that caused the leaks.
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): Removed unneeded isHTMLElement() calls from before the "qualified name" change.
11:22 AM Changeset in webkit [12286] by darin
  • 1 add in trunk/WebCore/manual-tests/bugzilla-3509.html

Somehow this file didn't get checked in before (even though it was
mentioned in the change log).

11:18 AM Changeset in webkit [12285] by ap
  • 2 edits in trunk/WebKitTools

Fix by Mark Rowe . Reviewed by Anders.


Build fix. build-webkit dies with "invalid build action: (empty string)"

  • Scripts/build-webkit: Use svgOptions in an array context so xcodebuild doesn't choke on an empty argument.
6:41 AM Changeset in webkit [12284] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-22 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Fix --no-svg option to use XCode flags instead of gcc flags.

  • Scripts/build-webkit:
6:08 AM Changeset in webkit [12283] by eseidel
  • 341 edits in trunk

2006-01-22 Eric Seidel <​eseidel@apple.com

Rubber-stamped by anders.

Remove WebCore-no-SVG target and wrap files in #if SVG_SUPPORT
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6633

2:49 AM Changeset in webkit [12282] by ap
  • 8 edits
    2 copies
    2 moves
    1 add in trunk/WebCore

Reviewed by Maciej.

  • WebCore.xcodeproj/project.pbxproj: Adjusted for moved and renamed files. New group "xml" to match directory structure.
  • xml: Added.
  • khtml/ecma/JSXMLHttpRequest.cpp: Added.
  • khtml/ecma/JSXMLHttpRequest.h: Added.
  • khtml/ecma/xmlhttprequest.cpp: Removed.
  • khtml/ecma/xmlhttprequest.h: Removed.
  • xml/xmlhttprequest.cpp: Added.
  • xml/xmlhttprequest.h: Added.
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrUndefined): Moved from kjs_events.cpp.
  • khtml/ecma/kjs_binding.h: Added prototype for jsStringOrUndefined().
  • khtml/ecma/kjs_events.cpp: Removed jsStringOrUndefined().
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Use new class name for JSXMLHttpRequest.
  • kwq/KWQSlot.cpp: XMLHttpRequestQObject is now in WebCore, not KJS.
  • page/Frame.cpp: (Frame::stopLoading): XMLHttpRequest is now in WebCore, not KJS.
1:57 AM Changeset in webkit [12281] by eseidel
  • 119 edits
    1 delete in trunk

2006-01-22 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Add support for custom fill/strokes on text.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6448

  • kcanvas/RenderSVGText.cpp: (RenderSVGText::paint): use new painter setup/teardown infrastructure
  • kcanvas/device/KRenderingPaintServer.h: (KRenderingPaintServer::KRenderingPaintServer): (KRenderingPaintServer::setup): (KRenderingPaintServer::render): (KRenderingPaintServer::teardown): (KRenderingPaintServer::isPaintingText): (KRenderingPaintServer::setPaintingText):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (setupShadingWithStyle): (renderShadingWithStyle): (teardownShadingWithStyle): (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::render): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::render): (KRenderingPaintServerRadialGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerPatternQuartz::KRenderingPaintServerPatternQuartz):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerQuartzHelper::strokePath): (KRenderingPaintServerQuartzHelper::clipToStrokePath): (KRenderingPaintServerQuartzHelper::fillPath): (KRenderingPaintServerQuartzHelper::clipToFillPath): (KRenderingPaintServerSolidQuartz::draw): (KRenderingPaintServerSolidQuartz::setup): (KRenderingPaintServerSolidQuartz::render): (KRenderingPaintServerSolidQuartz::teardown): (KRenderingPaintServerPatternQuartz::draw): (KRenderingPaintServerPatternQuartz::setup): (KRenderingPaintServerPatternQuartz::render): (KRenderingPaintServerPatternQuartz::teardown):
  • kcanvas/device/quartz/QuartzSupport.h: fix prototype
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (KSVGPainterFactory::fillPaintServer): (KSVGPainterFactory::strokePaintServer): (KSVGPainterFactory::cssPrimitiveToLength): (KSVGPainterFactory::strokePainter): (KSVGPainterFactory::fillPainter):
  • ksvg2/misc/KCanvasRenderingStyle.h:

Jan 21, 2006:

10:20 PM Changeset in webkit [12280] by staikos
  • 5 edits in trunk/JavaScriptCore

Reviewed by Maciej

Merge some build fixes for various Perl and gcc versions from KDE SVN.

8:28 PM Changeset in webkit [12279] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.


  • manual-tests/bugzilla-3509.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Force repaint if the child didn't move but didn't repaint correctly during layout because it was not at its final position then.
4:25 PM Changeset in webkit [12278] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Anders Carlsson.

Make sure shorthand properties get striked-out if
all the properties they expand into are overloaded.

2:11 PM Changeset in webkit [12277] by eseidel
  • 4 edits in trunk/WebKitTools

2006-01-20 David Kilzer <​ddkilzer@kilzer.net>

Reviewed by eseidel.

  • Scripts/build-drawtest: Changed bareword 'true' to 1.
  • Scripts/run-drawtest: Changed bareword 'true' to 1.
1:58 PM Changeset in webkit [12276] by andersca
  • 7 edits
    7 adds in trunk

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3869
Should use HTML Image element instead of JS Image object

  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction): Don't check Image object. Instead, if the element passed in is an image element which isn't in any document, use its pixmap.


  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::imageGetter): Add complete.


(KJS::ImageConstructorImp::construct):
Take a QPixmap instead of an Image.


(KJS::KJS::Context2DFunction::callAsFunction):
Remove usage of Image and use HTMLImageElementImpl instead.

  • khtml/ecma/kjs_html.h: Remove Image class.


(KJS::HTMLElement::):
Add ImgComplete.


  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): If the element has no renderer but its image size is known return that instead.


(WebCore::HTMLImageElementImpl::complete):
New function, returns true if an image has finished loading.


  • khtml/html/html_imageimpl.h: Add complete.


  • manual-tests/drag-image.html: Added.
1:20 PM Changeset in webkit [12275] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-21 Anders Carlsson <​andersca@mac.com>

  • editing/editing.js: Fix typo which made editing test cases fail.
12:15 PM Changeset in webkit [12274] by andersca
  • 4 edits
    4 adds in trunk

2006-01-21 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


  • khtml/editing/jsediting.cpp: Add support for the "Strikethrough" command.


12:02 PM Changeset in webkit [12273] by darin
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/hovered-detach.html: Added.
  • fast/dynamic/hovered-detach-expected.txt: Added.

WebCore:

Test: fast/dynamic/hovered-detach.html

Reviewed by Darin.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Set m_hovered to false and set the document's hoverNode to an hovered ancestor that still has a renderer.
  • rendering/render_layer.cpp: Changed static method hoverAncestor() into a RenderObject instance method. (WebCore::commonAncestor): (WebCore::RenderLayer::updateHoverActiveState):
  • rendering/render_object.cpp: Ditto. (WebCore::RenderObject::hoverAncestor)
  • rendering/render_object.h: Ditto.
11:22 AM Changeset in webkit [12272] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

Adds computed style to the Web Inspector.
Adds a "mapped style" link to the mapped attributes.

Note: See TracTimeline for information about the timeline view.