⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 29, 2006:

11:27 PM Changeset in webkit [12474] by darin
  • 32 edits
    6 deletes in trunk/WebCore

Reviewed by Maciej.

  • killed more KWQ, KWinModule and QVariant
  • ForwardingHeaders/kwinmodule.h: Removed.
  • ForwardingHeaders/qvariant.h: Removed.
  • kwq/KWQKWinModule.h: Removed.
  • kwq/KWQKWinModule.mm: Removed.
  • kwq/KWQVariant.cpp: Removed.
  • kwq/KWQVariant.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removal.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_binding.cpp: Remove QVariant stuff.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
  • page/Frame.h:
  • page/Frame.cpp: (getString): (Frame::replaceContentsWithScriptResult): (Frame::executeScript): (Frame::executeScheduledScript): (Frame::changeLocation): (Frame::urlSelected): (Frame::submitForm): Changed to use JSValue instead of QVariant for result of executing JavaScript.
  • kwq/KWQObject.h: Removed a bunch of unneeded includes and forward declarations.
  • bridge/mac/MacFrame.mm:
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQObject.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextField.mm:
  • loader/CachedImage.h:
  • page/FrameView.h:
  • page/FrameView.cpp:
  • rendering/render_form.cpp: Updated includes, since KWQObject.h now includes less. Also updated callers to executeScript since one overload was removed.
11:18 PM Changeset in webkit [12473] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • properly define Vector assignment operator; the private version was accidentally left in, and the template version is not enough to replace the default
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator=):
11:13 PM Changeset in webkit [12472] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Added back #include <qvaluelist.h> to fix WIN32 build.

  • rendering/render_style.h:
10:06 PM Changeset in webkit [12471] by darin
  • 50 edits
    2 adds
    11 deletes in trunk/WebCore

Reviewed by Hyatt (drag image fix) and Maciej (the rest).

  • fixed just-introduced crash dragging images

I don't know how to make a layout test for this.

  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): Fixed crash on dragging by initializing m_dragImage to 0.
  • kwq/KWQApplication.h: Removed.
  • kwq/KWQApplication.mm: Removed.
  • kwq/KWQGlobal.cpp: Removed.
  • kwq/KWQKPartsEvent.cpp: Removed.
  • kwq/KWQKPartsEvent.h: Removed.
  • kwq/KWQPair.h: Removed.
  • kwq/KWQStyle.cpp: Removed.
  • kwq/KWQStyle.h: Removed.
  • ForwardingHeaders/kparts/event.h: Removed.
  • ForwardingHeaders/qapplication.h: Removed.
  • ForwardingHeaders/qstyle.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Screen.h: Added. Replaces the desktop widget stuff in KWQApplication.mm.
  • platform/mac/Screen.mm: Added.
  • kwq/KWQDef.h: Removed everything except for kMin and kMax from here. We should port to std::min and std::max, and then we can get rid of this header altogether.
  • kwq/KWQKCursor.h: Removed setAutoHideCursor.
  • kwq/KWQKCursor.mm: Ditto.
  • kwq/KWQWidget.h: Removed style() and setStyle() functions.
  • kwq/KWQWidget.mm: Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::Screen): Store a pointer to the Frame. (KJS::Screen::getValueProperty): Port to use the new Screen.h functions. (KJS::showModalDialog): Ditto. (KJS::Window::getValueProperty): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/khtml_events.h:
  • khtml/khtml_events.cpp: Removed much of the code here. This can be cut down even more.
  • khtml/misc/khtmllayout.h: Removed unused stuff and updated for KWQ changes.
  • kwq/KWQCString.cpp:
  • kwq/KWQKURL.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextCodec.cpp:
  • WebCore+SVG/KDOMSettings.cpp:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssparser.cpp:
  • kcanvas/KCanvasItem.cpp:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • page/Frame.h:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/IntPointArray.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderTable.cpp:
  • rendering/bidi.cpp:
  • rendering/bidi.h:
  • rendering/render_form.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
  • rendering/render_style.h:
  • rendering/table_layout.cpp: Updated for above KWQ changes. Changed tabs to spaces.
9:58 PM Changeset in webkit [12470] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix the build by applying a GCC-specific namespace hack.

  • kjs/lookup.h:
8:52 PM Changeset in webkit [12469] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
8:50 PM Changeset in webkit [12468] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build on Win32.

  • kjs/lookup.h: fixed ::cacheGlobalObject
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): use unsigned long
4:54 PM Changeset in webkit [12467] by hyatt
  • 15 edits in trunk/WebCore

Fix for bug 6910, don't let Image be assignable or copiable. It will soon represent the actual
original Image (including the data) and as such must remain unique.

Reviewed by darin

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEImage::~KCanvasFEImage): (KCanvasFEImage::setCachedImage):
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::KCanvasFEImage): (KCanvasFEImage::cachedImage):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::~ImagePattern): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::cachedImage):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::cachedImage):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::~SVGCursorElementImpl): (SVGCursorElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::cachedImage):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::~SVGFEImageElementImpl): (SVGFEImageElementImpl::parseMappedAttribute): (SVGFEImageElementImpl::notifyFinished):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement): (WebCore::KWQClipboard::imageChanged): (WebCore::KWQClipboard::dragNSImage):
  • platform/Image.h:
3:40 PM Changeset in webkit [12466] by darin
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • rendering/render_image.h: (WebCore::RenderImage::image): Return a null image when m_cachedImage is 0. (WebCore::RenderImage::errorOccurred): Return false when m_cachedImage is 0.
  • rendering/render_image.cpp: (WebCore::RenderImage::nullImage): Added. Returns a global null image for use when we have no cached image.
  • rendering/render_object.h: Renamed the old setImage to imageChanged, the new name for the same function.
  • rendering/render_object.cpp: (WebCore::RenderObject::imageChanged): Ditto.
  • rendering/render_list.cpp: (RenderListMarker::imageChanged): Changed the call to parent to call the new imageChanged instead of the old setImage.
  • fixed something else that was causing some layout test crashes
  • kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Rearrange so we won't ever dereference a null pointer here.
2:24 PM Changeset in webkit [12465] by darin
  • 15 edits
    3 adds in trunk/LayoutTests

Reviewed by Darin.

  • fixed some tests that were missing test images
  • fast/replaced/resources/sample.gif: Added.
  • fast/replaced/resources/1x1-green.png: Added.
  • fast/replaced/resources/1x1-red.png: Added.
  • fast/replaced/001.html: Changed images to point to actual images.
  • fast/replaced/002.html: Ditto.
  • fast/replaced/003.html: Ditto.
  • fast/replaced/004.html: Ditto.
  • fast/replaced/002-expected.txt: Updated.
  • fast/replaced/003-expected.txt: Updated.
  • fast/replaced/001-expected.png: Updated.
  • fast/replaced/001-expected.checksum: Updated.
  • fast/replaced/002-expected.png: Updated.
  • fast/replaced/002-expected.checksum: Updated.
  • fast/replaced/003-expected.png: Updated.
  • fast/replaced/003-expected.checksum: Updated.
  • fast/replaced/004-expected.png: Updated.
  • fast/replaced/004-expected.checksum: Updated.
1:12 PM Changeset in webkit [12464] by mjs
  • 17 edits
    7 deletes in trunk/WebCore

Reviewed by Darin.

  • ForwardingHeaders/q3valuevector.h: Removed.
  • ForwardingHeaders/qptrvector.h: Removed.
  • ForwardingHeaders/qvector.h: Removed.
  • WebCore+SVG/KDOMSettings.cpp: (KDOMSettings::init): (KDOMSettings::isAdFiltered):
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]): (-[WebCoreFrameBridge controlsInForm:]):
  • css/cssstyleselector.h:
  • khtml/html/HTMLCollectionImpl.cpp: (WebCore::HTMLCollectionImpl::updateNameCache): (WebCore::HTMLCollectionImpl::namedItems):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::HTMLFormCollectionImpl): (WebCore::HTMLFormCollectionImpl::calcLength): (WebCore::HTMLFormCollectionImpl::item): (WebCore::HTMLFormCollectionImpl::getNamedFormItem): (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::~HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::length): (WebCore::HTMLFormElementImpl::submitClick): (WebCore::HTMLFormElementImpl::formData): (WebCore::HTMLFormElementImpl::submit): (WebCore::HTMLFormElementImpl::reset): (WebCore::insertIntoVector): (WebCore::removeFromVector): (WebCore::HTMLFormElementImpl::formElementIndex): (WebCore::HTMLFormElementImpl::registerImgElement):
  • khtml/html/HTMLFormElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
  • kwq/KWQComboBox.h:
  • kwq/KWQListBox.h:
  • kwq/KWQPtrVector.h: Removed.
  • kwq/KWQRenderTreeDebug.cpp: (writeLayers):
  • kwq/KWQValueVector.h: Removed.
  • kwq/KWQVectorImpl.cpp: Removed.
  • kwq/KWQVectorImpl.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::compareZIndex): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/render_layer.h: (khtml::RenderLayer::posZOrderList): (khtml::RenderLayer::negZOrderList):
10:59 AM Changeset in webkit [12463] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/border-collapsing/rtl-border-collapsing.html: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.checksum: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.png: Added.
10:59 AM Changeset in webkit [12462] by darin
  • 5 edits in trunk/WebCore

Test: fast/table/border-collapsing/rtl-border-collapsing.html

Reviewed by Darin.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::cellBefore): Renamed cellLeft to this. (WebCore::RenderTable::cellAfter): Renamed cellRight to this.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): Added the RTL case. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::borderLeft): (WebCore::RenderTableCell::borderRight): (WebCore::RenderTableCell::collectBorders): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
10:19 AM Changeset in webkit [12461] by darin
  • 1 edit
    10 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • fast/dom/Window/resources: Added.
  • fast/dom/Window/resources/destination.html: Added.
  • fast/dom/Window/window-open-parent-expected.txt: Added.
  • fast/dom/Window/window-open-parent-no-parent-expected.txt: Added.
  • fast/dom/Window/window-open-self-expected.txt: Added.
  • fast/dom/Window/window-open-top-expected.txt: Added.
10:18 AM Changeset in webkit [12460] by darin
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Roll out file that was checked in by accident.

10:15 AM Changeset in webkit [12459] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fix check for special frame names. These special frame names are supposed to always be unaffected by pop-up blocking. But the code instead was saying that the special frame names are always blocked. Oops!
10:11 AM Changeset in webkit [12458] by darin
  • 2 edits
    5 adds in trunk/LayoutTests
  • added a test for the names of range exceptions, which were wrong in my last commit until I made the fix Alexey suggested
  • fast/dom/Range: Added.
  • fast/dom/Range/range-exceptions.html: Added.
  • fast/dom/Range/resources: Added.
  • fast/dom/Range/resources/range-exceptions.js: Added.
  • fast/dom/Range/resources/TEMPLATE.html: Added.
  • fast/js/resources/js-test-pre.js: Escape & and < characters in the output so you can have tests with HTML fragments as expected results.
10:10 AM Changeset in webkit [12457] by darin
  • 2 edits in trunk/WebCore

Suggested by Alexey.

  • fixed something Alexey noticed in the new exception names

Test: fast/dom/Range/range-exceptions.html

  • khtml/ecma/kjs_binding.cpp: Added 0 to fix an off-by-one error for the names of the two DOM range exceptions.
7:11 AM Changeset in webkit [12456] by harrison
  • 1 edit
    8 adds in trunk/LayoutTests

Adding test cases for:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

  • editing/selection/move-by-line-002-expected.png: Added.
  • editing/selection/move-by-line-002-expected.checksum: Added.
  • editing/selection/move-by-line-002-expected.txt: Added.
  • editing/selection/move-by-line-002.html: Added.
  • editing/deleting/delete-listitem-002-expected.checksum: Added.
  • editing/deleting/delete-listitem-002-expected.png: Added.
  • editing/deleting/delete-listitem-002-expected.txt: Added.
  • editing/deleting/delete-listitem-002.html: Added.
7:06 AM Changeset in webkit [12455] by harrison
  • 4 edits in trunk/WebCore

Reviewed by John.

Fix two problems with editing around empty list items:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

Added tests:

  • selection/move-by-line-002.html
  • deleting/delete-listitem-002.html


  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • special check for empty list item because list marker assures non-zero height()


  • khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent):
  • fix check wrt BRs because text box is not required


  • rendering/bidi.cpp: (khtml::RenderBlock::constructLine):
  • make sure that br by itself in a list item gets a text-style box


(khtml::RenderBlock::findNextLineBreak):

  • make sure that br by itself in a list item gets a box at all
6:40 AM Changeset in webkit [12454] by eseidel
  • 78 edits in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt & darin.

There are a few small, but intertwined fixes in this patch:

Remaining fixes for SVGTetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6905

Fix for CDF support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

Updated test: svg/custom/simpleCDF.xml

Fix for filter updating:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6849

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6904

Also, as a side effect of 6849, fixed double-apply of filters, improving:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6713

Results updated for most tests, pixel results improved for filter tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFilter::filterBBoxForItemBBox): moved into baseclass
  • kcanvas/KCanvasFilters.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): use relativeBBox (RenderSVGImage::relativeBBox): added (RenderSVGImage::imageChanged): added (RenderSVGImage::getAbsoluteRepaintRect): fixed
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::imageChanged): added.
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): use new baseclass method (KCanvasFEFloodQuartz::getCIFilter): fixed.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout): update width/height (KCanvasItemQuartz::getAbsoluteRepaintRect): fixed. (KCanvasItemQuartz::requiresLayer): moved to .cpp (KCanvasItemQuartz::lineHeight): added. (KCanvasItemQuartz::baselinePosition): added.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::canHaveChildren): moved to .cpp (KCanvasContainerQuartz::requiresLayer): moved to .cpp (KCanvasContainerQuartz::lineHeight): added. (KCanvasContainerQuartz::baselinePosition): added. (KCanvasContainerQuartz::paint): fixed. (KCanvasContainerQuartz::viewportTransform): fixed. (KCanvasContainerQuartz::getAbsoluteRepaintRect): fixed. (KCanvasContainerQuartz::absoluteTransform): fixed.
  • rendering/render_object.cpp: (WebCore::RenderObject::absoluteTransform): fixed apply order.
3:19 AM Changeset in webkit [12453] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave Hyatt.

  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): Add unsigned overload
1:40 AM Changeset in webkit [12452] by eseidel
  • 4 edits
    4 adds in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

First set of fixes for SVG Tetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Tests:

  • bridge/mac/MacFrame.mm: (MacFrame::keyEvent): pass key events to things other than HTML
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::parseMappedAttribute): update viewport
1:09 AM Changeset in webkit [12451] by darin
  • 1 delete in trunk/LayoutTests/dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt

Somehow this file was missed in the last commit. Since it's just a delete, do it without a new ChangeLog entry.

12:57 AM Changeset in webkit [12450] by darin
  • 21 edits
    10 deletes in trunk/LayoutTests
  • dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
  • dom/xhtml/level3/core/canonicalform06-expected.txt:
  • dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
  • dom/xhtml/level3/core/infoset06-expected.txt:
  • dom/xhtml/level3/core/infoset07-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore05-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode17-expected.txt:
  • dom/xhtml/level3/core/noderemovechild04-expected.txt:
  • dom/xhtml/level3/core/noderemovechild05-expected.txt:
  • dom/xhtml/level3/core/nodereplacechild13-expected.txt:
  • dom/xhtml/level3/core/wellformed01-expected.txt:
  • dom/xhtml/level3/core/wellformed02-expected.txt:
  • dom/xhtml/level3/core/wellformed03-expected.txt:
  • dom/xhtml/level3/core/wellformed04-expected.txt:
  • for these, also changed the tests to be dumpAsText at the same time
  • fast/dom/outerText-no-element.html:
  • fast/dom/outerText-no-element-expected.txt:
  • fast/dynamic/outerHTML-no-element.html:
  • fast/dynamic/outerHTML-no-element-expected.txt:
  • fast/dom/outerText-no-element-expected.checksum: Removed.
  • fast/dom/outerText-no-element-expected.png: Removed.
  • fast/dynamic/outerHTML-no-element-expected.checksum: Removed.
  • fast/dynamic/outerHTML-no-element-expected.png: Removed.
  • removed test results for tests that are either disabled or not checked in
  • dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: Removed.
  • dom/xhtml/level3/core/documentadoptnode22-expected.txt: Removed.
  • editing/execCommand/boldCharacter-expected.txt: Removed.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
  • fast/parser/remove-block-in-residual-style-expected.png: Removed.
  • fast/parser/remove-block-in-residual-style-expected.txt: Removed.
  • fast/plugins: Removed.
  • fast/plugins/netscape-back-forward-expected.txt: Removed.
  • fast/plugins/resources: Removed.
  • fast/plugins/resources/go-back.html: Removed.
12:26 AM Changeset in webkit [12449] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix SVG layout tests crash due to Vector change.

  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): check isEmpty, return 0
12:04 AM Changeset in webkit [12448] by eseidel
  • 2 edits in trunk/WebCore

2006-01-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove bogus IntRect operator.

  • platform/FloatRect.h:

Jan 28, 2006:

11:45 PM Changeset in webkit [12447] by hyatt
  • 27 edits in trunk

WebCore:

Cleanup of RenderImage. Eliminate unneeded members and methods.

Reviewed by darin

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern):
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::attach):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::attach):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::compositeOperator):
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::attach):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/WebCoreImageRenderer.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged):
  • platform/Image.h: (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::Image::Image): (WebCore::Image::resetAnimation): (WebCore::Image::operator=): (WebCore::Image::stopAnimations): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::cachedImage): (WebCore::RenderImage::image): (WebCore::RenderImage::errorOccurred):
  • rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:

WebKit:

Clean up RenderImage, eliminating unneeded members and methods.


Reviewed by darin

  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer size]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
11:42 PM Changeset in webkit [12446] by darin
  • 2 edits
    3 adds in trunk/LayoutTests

Reviewed by John Sullivan.

  • fast/js/date-constructor.html: Added.
  • fast/js/date-constructor-expected.txt: Added.
  • fast/js/resources/date-constructor.js: Added.
  • fast/js/resources/date-big-constructor.js: Formatting tweak.
11:42 PM Changeset in webkit [12445] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
11:38 PM Changeset in webkit [12444] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/events/dispatch-to-handle-event.html: Added.
  • fast/events/dispatch-to-handle-event-expected.txt: Added.

WebCore:

Reviewed by Eric.

Test: fast/events/dispatch-to-handle-event.html

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Remove boolean that is always false, and correct the one place that was checking it to check the correct pointer instead.
10:52 PM Changeset in webkit [12443] by mjs
  • 9 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • remove QPtrStack, replace with Vector or traverseNextNode as appropriate
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): (KRenderingDevice::popContext): (KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]):
  • kwq/KWQPainter.mm: (WebCore::QPainter::save): (WebCore::QPainter::restore):
  • kwq/KWQPtrStack.h: Removed.
  • ForwardingHeaders/qptrstack.h: Removed.
  • ForwardingHeaders/q3ptrstack.h: Removed.
10:47 PM Changeset in webkit [12442] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • miscellaneous Vector improvements
  • kxmlcore/Vector.h: (KXMLCore::Vector::at): Add range-checking asserts. (KXMLCore::Vector::first): Added as a convenience. (KXMLCore::Vector::last): Convenience for stack-style use. (KXMLCore::Vector::removeLast): ditto
10:25 PM Changeset in webkit [12441] by mjs
  • 1 edit
    1 add
    2 deletes in trunk/WebCore
  • added missing forwarding header to fix build.


  • ForwardingHeaders/kxmlcore/Vector.h: Added.
9:26 PM Changeset in webkit [12440] by darin
  • 2 edits in trunk/WebCore
  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Removed extra parameter to fix the build.
9:23 PM Changeset in webkit [12439] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • converted KWQKURL to use Vector :bugzilla.opendarwin.org/show_bug.cgi?id=6900

Use Vector in place of Array, and in place of the custom stack
buffers with overflow.


  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::decode_string): (KURL::parse): (KURL::encode_string): (findHostnamesInMailToURL): (encodeHostnames):
8:30 PM Changeset in webkit [12438] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
8:18 PM Changeset in webkit [12437] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/create_hash_table: Added missing license.
8:17 PM Changeset in webkit [12436] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dump): Dump the image if it's not already there, even if the checksum is correct.
8:12 PM Changeset in webkit [12435] by mjs
  • 6 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Dave Hyatt.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/internal.cpp: (KJS::Parser::saveNewNode): Apply Vector. (KJS::clearNewNodes): ditto
  • kjs/number_object.cpp: (integer_part_noexp): ditto (char_sequence): ditto
  • kjs/ustring.cpp: (KJS::UString::UTF8String): ditto
  • kxmlcore/HashMap.h: (KXMLCore::deleteAllValues): Tweaked this to only apply to HashMap, other versions are useful for other containers.
  • kxmlcore/Vector.h: Added. Implemented a Vector class, which should be usable for all Array/QVector style purposes, and also as a stack buffer with oversize handling. Also some helper classes to make vector operations as efficient as possible for POD types and for simple non-PODs like RefPtr. (KXMLCore::): (KXMLCore::VectorTypeOperations::destruct): (KXMLCore::VectorTypeOperations::initialize): (KXMLCore::VectorTypeOperations::move): (KXMLCore::VectorTypeOperations::uninitializedCopy): (KXMLCore::VectorTypeOperations::uninitializedFill): (KXMLCore::VectorBuffer::VectorBuffer): (KXMLCore::VectorBuffer::~VectorBuffer): (KXMLCore::VectorBuffer::deallocateBuffer): (KXMLCore::VectorBuffer::inlineBuffer): (KXMLCore::Vector::Vector): (KXMLCore::Vector::~Vector): (KXMLCore::Vector::size): (KXMLCore::Vector::capacity): (KXMLCore::Vector::isEmpty): (KXMLCore::Vector::at): (KXMLCore::Vector::operator[]): (KXMLCore::Vector::data): (KXMLCore::Vector::operator T*): (KXMLCore::Vector::operator const T*): (KXMLCore::Vector::begin): (KXMLCore::Vector::end): (KXMLCore::Vector::clear): (KXMLCore::Vector::fill): (KXMLCore::Vector::operator=): (KXMLCore::::Vector): (KXMLCore::::operator): (KXMLCore::::fill): (KXMLCore::::expandCapacity): (KXMLCore::::resize): (KXMLCore::::reserveCapacity): (KXMLCore::::append): (KXMLCore::deleteAllValues):
  • kxmlcore/VectorTraits.h: Added. (KXMLCore::VectorTraits): Traits to enable making Vector efficient for simple types.
5:50 PM Changeset in webkit [12434] by hyatt
  • 6 edits in trunk/WebCore

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:50 PM Changeset in webkit [12433] by hyatt
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebImageRenderer.m

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:32 PM Changeset in webkit [12432] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/add-before-anonymous-child.html: Added.
  • fast/table/add-before-anonymous-child-expected.txt: Added.
  • fast/table/add-before-anonymous-child-expected.png: Added.
  • fast/table/add-before-anonymous-child-expected.checksum: Added.
5:29 PM Changeset in webkit [12431] by darin
  • 3 edits in trunk/WebCore

Test: fast/table/add-before-anonymous-child.html

Reviewed by Darin.

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): If beforeChild is inside an anonymous cell, insert into the cell.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed comment.
4:58 PM Changeset in webkit [12430] by hyatt
  • 3 edits in trunk/WebCore

Eliminate the mask() method on Image. It's unused.

  • platform/Image.h:
  • platform/mac/Image.mm:
4:16 PM Changeset in webkit [12429] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix Changelog typo.

4:15 PM Changeset in webkit [12428] by hyatt
  • 7 edits in trunk/WebCore

Clean up the Image class. Eliminate the MIME type memebr variable.
Eliminate an unused constructor. Fix the constructor to take
a QString rather than an NSString so that it's portable. Rename
the receivedData method to decode. Move canRenderImageType into
the Image class as a static method.

Reviewed by mjs

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::isImageType):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQResponseMIMEType):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::supportsType): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::decode): (WebCore::Image::operator=):
2:18 AM Changeset in webkit [12427] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-28 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

SourceAlpha does not display until window is redrawn (resized)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6375

Test: svg/custom/filter-source-alpha.svg

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::inputImage):`
12:53 AM Changeset in webkit [12426] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fallback to kCFStringEncodingWindowsLatin1 if the passed buffer is not valid UTF-8, preventing crashes.
12:52 AM Changeset in webkit [12425] by hyatt
  • 13 edits
    2 deletes in trunk/WebCore

Fix CachedImage.h/.cpp up. Lots of cleanup. Eliminated
unused code and cleaned up method and member names.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::deref): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::decodedRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::clear): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify):
  • loader/CachedImage.h: (WebCore::CachedImage::isDecoded): (WebCore::CachedImage::isErrorImage): (WebCore::CachedImage::schedule): (WebCore::CachedImage::isImage):
  • loader/CachedImageCallback.cpp: Removed.
  • loader/CachedImageCallback.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::receivedData):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::setImage):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):
Note: See TracTimeline for information about the timeline view.