⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 2, 2006:

11:32 PM Changeset in webkit [12543] by hyatt
  • 5 edits
    1 add in trunk/WebCore

Move ImageAnimationObserver into its own file.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachedImage.h:
  • platform/Image.h:
  • platform/ImageAnimationObserver.h: Added. (WebCore::ImageAnimationObserver::~ImageAnimationObserver):
  • platform/mac/Image.mm:
11:18 PM Changeset in webkit [12542] by mjs
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Adele.

  • remove all use of the ChildFrame from outside Frame.cpp, in preparation for removing it
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::frameDetached): Factor out the ChildFrame manipulations into a base class method. (WebCore::MacFrame::objectContentType): factored out from createPart, calls the bridge to determine contents for an Object tag. (WebCore::MacFrame::createPlugin): factor out code from createPart that makes a Plugin. (WebCore::MacFrame::createFrame): ditto for code that makes a Frame. (WebCore::MacFrame::createEmptyDocument): factored out part into the superclass
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): Call new ownerElement method on Frame instead of mucking at Frame internals.
  • page/Frame.cpp: (WebCore::Frame::createPart): Moved here from MacFrame, but some of the guts were factored out. (WebCore::Frame::ownerElement): New method, logic moved from DocumentImpl. (WebCore::Frame::frameDetached): New virtual method, the part of this that pokes at ChildFrame structures. (WebCore::Frame::updateBaseURLForEmptyDocument): Helper that looks at the ChildFrame array for the benefit of createEmptyDocument.
  • page/Frame.h:
  • page/Page.h: Fix up modeline.
  • page/Plugin.h: Added. (WebCore::Plugin::Plugin): Moved here from MacFrame.mm, since it is now used by Frame. (WebCore::Plugin::view): ditto
9:47 PM Changeset in webkit [12541] by hyatt
  • 2 edits in trunk/WebCore

Avoid extra copies of all the decoded image bytes.

Reviewed by mjs

  • platform/mac/Image.mm: (WebCore::ImageData::setData):
5:16 PM Changeset in webkit [12540] by justing
  • 141 edits
    4 adds in trunk/LayoutTests

Reviewed by harrison


Turned on continuous spell checking to test the fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Added:

  • editing/selection/end-of-document.html

Pixel results for editing tests now include misspelling markers.
A few of them are incorrect, filed 7038 to cover this.

  • editing/deleting/delete-3928305-fix-expected.checksum:
  • editing/deleting/delete-3928305-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-and-undo-expected.checksum:
  • editing/deleting/delete-and-undo-expected.png:
  • editing/deleting/delete-block-contents-003-expected.checksum:
  • editing/deleting/delete-block-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • editing/deleting/delete-contiguous-ws-001-expected.png:
  • editing/deleting/delete-tab-002-expected.checksum:
  • editing/deleting/delete-tab-002-expected.png:
  • editing/deleting/delete-tab-003-expected.checksum:
  • editing/deleting/delete-tab-003-expected.png:
  • editing/deleting/delete-trailing-ws-002-expected.checksum:
  • editing/deleting/delete-trailing-ws-002-expected.png:
  • editing/deleting/delete-ws-fixup-001-expected.checksum:
  • editing/deleting/delete-ws-fixup-001-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/insert-3659587-fix-expected.checksum:
  • editing/inserting/insert-3659587-fix-expected.png:
  • editing/inserting/insert-br-004-expected.checksum:
  • editing/inserting/insert-br-004-expected.png:
  • editing/inserting/insert-br-005-expected.checksum:
  • editing/inserting/insert-br-005-expected.png:
  • editing/inserting/insert-br-007-expected.checksum:
  • editing/inserting/insert-br-007-expected.png:
  • editing/inserting/insert-div-007-expected.checksum:
  • editing/inserting/insert-div-007-expected.png:
  • editing/inserting/insert-div-012-expected.checksum:
  • editing/inserting/insert-div-012-expected.png:
  • editing/inserting/insert-div-013-expected.checksum:
  • editing/inserting/insert-div-013-expected.png:
  • editing/inserting/insert-div-014-expected.checksum:
  • editing/inserting/insert-div-014-expected.png:
  • editing/inserting/insert-div-015-expected.checksum:
  • editing/inserting/insert-div-015-expected.png:
  • editing/inserting/insert-div-016-expected.checksum:
  • editing/inserting/insert-div-016-expected.png:
  • editing/inserting/insert-div-017-expected.checksum:
  • editing/inserting/insert-div-017-expected.png:
  • editing/inserting/insert-div-018-expected.checksum:
  • editing/inserting/insert-div-018-expected.png:
  • editing/inserting/insert-div-019-expected.checksum:
  • editing/inserting/insert-div-019-expected.png:
  • editing/inserting/insert-div-020-expected.checksum:
  • editing/inserting/insert-div-020-expected.png:
  • editing/inserting/insert-div-021-expected.checksum:
  • editing/inserting/insert-div-021-expected.png:
  • editing/inserting/insert-div-022-expected.checksum:
  • editing/inserting/insert-div-022-expected.png:
  • editing/inserting/insert-div-025-expected.checksum:
  • editing/inserting/insert-div-025-expected.png:
  • editing/inserting/insert-div-027-expected.checksum:
  • editing/inserting/insert-div-027-expected.png:
  • editing/inserting/insert-tab-002-expected.checksum:
  • editing/inserting/insert-tab-002-expected.png:
  • editing/inserting/insert-tab-003-expected.checksum:
  • editing/inserting/insert-tab-003-expected.png:
  • editing/inserting/insert-text-with-newlines-expected.checksum:
  • editing/inserting/insert-text-with-newlines-expected.png:
  • editing/inserting/return-key-with-selection-001-expected.checksum:
  • editing/inserting/return-key-with-selection-001-expected.png:
  • editing/inserting/return-key-with-selection-002-expected.checksum:
  • editing/inserting/return-key-with-selection-002-expected.png:
  • editing/inserting/return-key-with-selection-003-expected.checksum:
  • editing/inserting/return-key-with-selection-003-expected.png:
  • editing/inserting/typing-002-expected.checksum:
  • editing/inserting/typing-002-expected.png:
  • editing/inserting/typing-around-br-001-expected.checksum:
  • editing/inserting/typing-around-br-001-expected.png:
  • editing/pasteboard/cut-text-001-expected.checksum:
  • editing/pasteboard/cut-text-001-expected.png:
  • editing/pasteboard/paste-list-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.png:
  • editing/pasteboard/paste-text-012-expected.checksum:
  • editing/pasteboard/paste-text-012-expected.png:
  • editing/pasteboard/paste-text-013-expected.checksum:
  • editing/pasteboard/paste-text-013-expected.png:
  • editing/pasteboard/paste-text-014-expected.checksum:
  • editing/pasteboard/paste-text-014-expected.png:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/extend-by-word-001-expected.checksum:
  • editing/selection/extend-by-word-001-expected.png:
  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/move-backwords-by-word-001-expected.checksum:
  • editing/selection/move-backwords-by-word-001-expected.png:
  • editing/selection/move-by-character-001-expected.checksum:
  • editing/selection/move-by-character-001-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
  • editing/selection/move-by-word-001-expected.checksum:
  • editing/selection/move-by-word-001-expected.png:
  • editing/selection/replaced-boundaries-1-expected.checksum:
  • editing/selection/replaced-boundaries-1-expected.png:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/style/block-styles-007-expected.checksum:
  • editing/style/block-styles-007-expected.png:
  • editing/style/create-block-for-style-002-expected.checksum:
  • editing/style/create-block-for-style-002-expected.png:
  • editing/style/create-block-for-style-003-expected.checksum:
  • editing/style/create-block-for-style-003-expected.png:
  • editing/style/create-block-for-style-004-expected.checksum:
  • editing/style/create-block-for-style-004-expected.png:
  • editing/style/create-block-for-style-006-expected.checksum:
  • editing/style/create-block-for-style-006-expected.png:
  • editing/style/create-block-for-style-008-expected.checksum:
  • editing/style/create-block-for-style-008-expected.png:
  • editing/style/create-block-for-style-009-expected.checksum:
  • editing/style/create-block-for-style-009-expected.png:
  • editing/style/create-block-for-style-011-expected.checksum:
  • editing/style/create-block-for-style-011-expected.png:
  • editing/style/create-block-for-style-012-expected.checksum:
  • editing/style/create-block-for-style-012-expected.png:
  • editing/style/create-block-for-style-013-expected.checksum:
  • editing/style/create-block-for-style-013-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • fast/dom/blur-contenteditable-expected.checksum:
  • fast/dom/blur-contenteditable-expected.png:
5:14 PM Changeset in webkit [12539] by justing
  • 2 edits in trunk/WebKitTools

Reviewed by thatcher


Enabled spell checking for layout tests.


  • DumpRenderTree/DumpRenderTree.m: (main):
5:14 PM Changeset in webkit [12538] by justing
  • 3 edits in trunk/WebCore

Reviewed by darin, harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Calling range() on a WordIterator destroyed its RangeImpl, use
RefPtr instead of PassRefPtr.
Turned on continuous spell checking to test the fix, found
a crasher caused by invalid positions created in
previousBoundary.

Added layout test:

  • editing/selection/end-of-document.html
  • khtml/editing/visible_text.h:
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary):
4:02 PM Changeset in webkit [12537] by hyatt
  • 2 edits in trunk/WebCore

Vectorize Image. Optimize so that we no longer throw away
all CGImageRefs. Now we just throw away the last frame.

Reviewed by mjs

  • platform/mac/Image.mm: (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::FrameData::clear): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex):
3:18 PM Changeset in webkit [12536] by ggaren
  • 6 edits in trunk/WebCore

Reviewed by mjs.

Cleaned up some stuff I came across when working with JS enabled/
disabled code:

(1) Renamed initScript to initScriptIfNeeded, because that's what it

does

(2) Removed dead or otherwise irrelevent code
(3) Fixed up comments
(4) Removed NULL checks for interpreter() since it never returns NULL,

replaced with single assert().

No test case because there's no change in behavior.

  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate): 1 (WebCore::KJSProxyImpl::createHTMLEventHandler): 1 (WebCore::KJSProxyImpl::createSVGEventHandler): 1 (WebCore::KJSProxyImpl::interpreter): 4 (WebCore::KJSProxyImpl::initScriptIfNeeded): 1
  • khtml/ecma/kjs_proxy.h: 1
  • page/Frame.cpp: (Frame::didOpenURL): 2, 3 (Frame::stopLoading): 2 (Frame::jScriptEnabled): 2 (Frame::jScript): changed method call to data member access to match

style of rest of class

(Frame::javaEnabled): 2
(Frame::pluginsEnabled): 2
(Frame::begin): 3
(Frame::userGestureHint): 4
(Frame::pauseTimeouts): collapsed a line
(Frame::resumeTimeouts): ditto
(Frame::saveInterpreterBuiltins): 4
(Frame::restoreInterpreterBuiltins): 4

  • page/Frame.h: 2
  • page/FramePrivate.h: 2 (FramePrivate::FramePrivate): 2
1:19 PM Changeset in webkit [12535] by hyatt
  • 2 edits in trunk/WebCore

Fix for PLT performance regression. Make sure that the document's load event timer
isn't started again if it's already active.

Reviewed by mjs

  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::dispatchImageLoadEventSoon):
1:00 PM Changeset in webkit [12534] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/lookup.h: Fix compile, merged from KDE.
9:32 AM Changeset in webkit [12533] by darin
  • 1 edit
    4 adds in trunk/LayoutTests
  • fast/events/onunload-body-property.html: Added.
  • fast/events/onunload-body-property-expected.txt: Added.
  • fast/events/onunload-window-property.html: Added.
  • fast/events/onunload-window-property-expected.txt: Added.
9:31 AM Changeset in webkit [12532] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/events/onunload-body-property.html
  • fast/events/onunload-window-property.html
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): Change onunload case to use unloadEvent, not scrollEvent. (KJS::DOMNode::putValueProperty): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::putValueProperty): Ditto.

Reviewed by Hyatt.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowQObject::installTimeout): When converting the timeout number from an integer ms to a double seconds, use a 10 ms minimum.
9:15 AM Changeset in webkit [12531] by darin
  • 2 edits in trunk/WebCore
  • added a FIXME about an incorrect change made to FloatRect to fix the Win32 compile
  • platform/FloatRect.cpp: (WebCore::enclosingIntRect): Added FIXME because this should do a ceil operation, not a round operation.
1:29 AM Changeset in webkit [12530] by hyatt
  • 3 edits in trunk/WebCore

Fix win32 bustage. #ifdef enclosingIntRect using. Remove floorf and ceilf from enclosingIntRect impl since it's not needed. Fix the bad #import in qmatrix.h

1:00 AM Changeset in webkit [12529] by darin
  • 2 deletes in trunk/WebCore/platform

Deleted these files, Dave checked them in by mistake.

12:52 AM Changeset in webkit [12528] by hyatt
  • 1 edit in trunk/LayoutTests/fast/text/whitespace/006-expected.txt

Check in revised results for 006.html test.

12:40 AM Changeset in webkit [12527] by hyatt
  • 33 edits
    2 copies in trunk/WebCore

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).


Reviewed by darin

  • WebCore.exp:
  • bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
  • bindings/objc/DOMPrivate.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::fileWrapperForElement):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::imageChanged):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_html.cpp: (KJS::drawPattern):
  • kwq/KWQClipboard.h: (WebCore::KWQClipboard::setDragHasStarted):
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor):
  • kwq/KWQPainter.h: (WebCore::QPainter::):
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/KWQScrollView.h:
  • kwq/KWQScrollView.mm: (QScrollView::inWindow):
  • kwq/WebCoreImageRendererFactory.h:
  • kwq/WebCoreImageRendererFactory.m:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::shouldStopAnimation): (WebCore::CachedImage::animationAdvanced):
  • loader/CachedImage.h: (WebCore::CachedImage::canRender):
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged): (WebCore::CachedObjectClient::willRenderImage):
  • platform/Image.h: (WebCore::ImageAnimationObserver::~ImageAnimationObserver): (WebCore::Image::animationObserver): (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame): (WebCore::m_PDFDoc): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setCFData): (WebCore::ImageData::imageSourceOptions): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation): (WebCore::ImageData::setCompositingOperation): (WebCore::ImageData::fillSolidColorInRect): (WebCore::ImageData::drawInRect): (WebCore::drawPattern): (WebCore::): (WebCore::ImageData::tileInRect): (WebCore::ImageData::scaleAndTileInRect): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::graphicsContext): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged):
  • rendering/render_image.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::willRenderImage):
  • rendering/render_object.h:
12:37 AM Changeset in webkit [12526] by hyatt
  • 10 edits in trunk/WebKit

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).

Reviewed by darin

  • Misc.subproj/WebNSPasteboardExtras.h:
  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): (-[NSPasteboard _web_declareAndWriteDragImage:element:URL:title:archive:source:]):
  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
  • WebCoreSupport.subproj/WebImageData.m: (-[WebImageData init]):
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (+[WebImageRendererFactory shouldUseThreadedDecoding]): (+[WebImageRendererFactory setShouldUseThreadedDecoding:]): (-[WebImageRendererFactory setPatternPhaseForContext:inUserSpace:]): (-[WebImageRendererFactory imageDataForName:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):
12:36 AM Changeset in webkit [12525] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/block/positioning/height-change-expected.checksum: Added.
  • fast/block/positioning/height-change-expected.png: Added.
  • fast/block/positioning/height-change-expected.txt: Added.
  • fast/block/positioning/height-change.html: Added.
12:35 AM Changeset in webkit [12524] by darin
  • 3 edits in trunk/WebCore

Test: LayoutTests/fast/block/positioning/height-change.html

Reviewed by Hyatt.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Relayout positioned children if the block's height changed during layout.
  • rendering/render_flexbox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
12:22 AM Changeset in webkit [12523] by darin
  • 10 edits
    3 adds in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/Noncopyable.h: Added.
  • kxmlcore/OwnArrayPtr.h: Added.
  • kxmlcore/OwnPtr.h: Added.
  • kjs/function.h:
  • kjs/function.cpp: Use OwnPtr for Parameter pointers.
  • kjs/internal.h: Use Noncopyable for LabelStack.
  • kjs/list.cpp: Use OwnArrayPtr for overflow.
  • kjs/property_map.h:
  • kjs/property_map.cpp: Use OwnArrayPtr for SavedProperties. Use Vector for some stack buffers.
  • kjs/regexp_object.h:
  • kjs/regexp_object.cpp: Use OwnArrayPtr for lastOvector.
12:07 AM Changeset in webkit [12522] by darin
  • 1 edit
    4 adds in trunk/JavaScriptGlue
  • added some forwarding headers to make new JavaScriptCore changes work
  • kxmlcore/Assertions.h: Added.
  • kxmlcore/Noncopyable.h: Added.
  • kxmlcore/OwnPtr.h: Added.
  • kxmlcore/OwnArrayPtr.h: Added.

Feb 1, 2006:

11:42 PM Changeset in webkit [12521] by mjs
  • 16 edits in trunk/WebCore

Reviewed by Darin.

  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::generateFrameName): (WebCore::MacFrame::submitForm): (WebCore::Frame::frameDetached): (WebCore::MacFrame::nextKeyViewInFrameHierarchy): (WebCore::MacFrame::createEmptyDocument):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): (WebCore::DocumentImpl::parentDocument):
  • page/Frame.cpp: (WebCore::Frame::checkCompleted): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::requestFrameName): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::handleFallbackContent): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • page/FrameTreeNode.cpp: (WebCore::FrameTreeNode::setName): (WebCore::FrameTreeNode::appendChild): (WebCore::FrameTreeNode::removeChild):
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent):
  • rendering/render_frames.cpp: (WebCore::isURLAllowed):
11:04 PM Changeset in webkit [12520] by hyatt
  • 1 edit in trunk/LayoutTests/fast/block/float/031.html

Back out the changes to 031.html's HTML because of the 4959 partial backout.

11:02 PM Changeset in webkit [12519] by hyatt
  • 4 deletes in trunk/LayoutTests/fast/parser

Remove residual style span form test case because of the backout.

10:45 PM Changeset in webkit [12518] by hyatt
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Back out half of the residual style fix for bug 4959, since treating <span> like residual style breaks fast/block/float/031.html (despite buildbot and people on the outside not seeing it... how weird is that).

9:16 PM Changeset in webkit [12517] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • fast/dom/Window/clear-timeout.html: Added.
  • fast/dom/Window/clear-timeout-expected.txt: Added.
9:15 PM Changeset in webkit [12516] by darin
  • 2 edits in trunk/WebCore

Checking in without review because I *just* broke this with my last check-in.

Test: fast/dom/Window/clear-timeout.html

  • khtml/ecma/kjs_window.cpp: (WindowQObject::clearTimeout): Fixed a != that should have been a ==.
6:51 PM Changeset in webkit [12515] by darin
  • 30 edits
    3 adds
    3 deletes in trunk/WebCore

Reviewed by Hyatt.

  • use Timer for everything, kill timer features of QObject, QTimer, QTimerEvent
  • ForwardingHeaders/kxmlcore/Noncopyable.h: Added.
  • ForwardingHeaders/kxmlcore/OwnArrayPtr.h: Added.
  • ForwardingHeaders/kxmlcore/OwnPtr.h: Added.
  • ForwardingHeaders/qtimer.h: Removed.
  • kwq/KWQTimer.cpp: Removed.
  • kwq/KWQTimer.h: Removed.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Remove timer-related features.
  • kwq/KWQEvent.h: Remove QTimerEvent.
  • WebCore.xcodeproj/project.pbxproj: Updated for file changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/Timer.h: Change to use nextFireInterval rather than nextFireTime. More convenient and also no need to define what the epoch is. Change TimerBase to use a virtual function rather than a function pointer. Added setDeferringTimers function to ensure timers don't fire while handling an event.
  • platform/mac/Timer.cpp: (WebCore::timerFired): Added deferral support. (WebCore::fireDeferred): Added. (WebCore::TimerBase::TimerBase): Simplify to remove function pointer. (WebCore::TimerBase::~TimerBase): Put in here, no longer inline. (WebCore::TimerBase::start): Change to use interval. (WebCore::TimerBase::startRepeating): Change since we use interval now. (WebCore::TimerBase::startOneShot): Ditto. (WebCore::TimerBase::stop): Added deferral support. (WebCore::TimerBase::nextFireInterval): Added. (WebCore::TimerBase::fire): Added. (WebCore::isDeferringTimers): Added. (WebCore::setDeferringTimers): Added.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Update for change to Timer class. (WebCore::MacFrame::passMouseDownEventToWidget): Update to use setDeferringTimers instead of QObject::setDefersTimers.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer): Added. Class for JavaScript "timeout". (KJS::WindowQObject::parentDestroyed): Update to use DOMWindowTimer. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerFired): Ditto. (KJS::DOMWindowTimer::fired): Added.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): Use Timer instead of timer ID. (WebCore::HTMLTokenizer::reset): Ditto. (WebCore::HTMLTokenizer::continueProcessing): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::stopParsing): Ditto. (WebCore::HTMLTokenizer::processingData): Ditto. (WebCore::HTMLTokenizer::timerFired): Ditto. (WebCore::HTMLTokenizer::end): Ditto. (WebCore::HTMLTokenizer::finish): Ditto.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Updated for changes to use RefPtr more cases, and not use it for m_svgExtensions. (WebCore::DocumentImpl::~DocumentImpl): Delete m_svgExtensions instead of just deref'ing it since it's no longer shared. (WebCore::DocumentImpl::implementation): Update for RefPtr. (WebCore::DocumentImpl::elementSheet): Ditto. (WebCore::DocumentImpl::styleSheets): Ditto. (WebCore::DocumentImpl::recalcStyleSelector): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventSoon): Update to use new style timer. (WebCore::DocumentImpl::removeImage): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventsNow): Ditto. (WebCore::DocumentImpl::imageLoadEventTimerFired): Ditto. (WebCore::DocumentImpl::svgExtensions): Update for RefPtr. (WebCore::DocumentImpl::accessSVGExtensions): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.h: (WebCore::TimeScheduler::document):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::downcast): (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::start): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify): (WebCore::TimeScheduler::TimeScheduler): (WebCore::TimeScheduler::~TimeScheduler): (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired): Rework to use new timer.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp: Make SVGDocumentExtensions no longer be shared, be solely owned by the document.
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::createStyleSelector): Update for RefPtr use.
  • kwq/KWQSlot.cpp: Remove endLifeSupport and timerNotify slots.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Update to use new style timer. (WebCore::Frame::caretBlinkTimerFired): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Update to use new style timer. (WebCore::FrameView::clear): Ditto. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::layoutTimerFired): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::layoutPending): Ditto. (WebCore::FrameView::haveDelayedLayoutScheduled): Ditto. (WebCore::FrameView::unscheduleRelayout): Ditto.
  • page/ObjectContents.h: Remove unneeded includes.
  • rendering/render_frames.cpp: Removed include of <qtimer.h>.
  • rendering/render_layer.h:
  • rendering/render_layer.cpp: (WebCore::Marquee::Marquee): Use new style timers. (WebCore::Marquee::start): Ditto. (WebCore::Marquee::suspend): Ditto. (WebCore::Marquee::stop): Ditto. (WebCore::Marquee::updateMarqueeStyle): Ditto. (WebCore::Marquee::timerFired): Ditto.
2:36 PM Changeset in webkit [12514] by bdakin
  • 3 edits in trunk/WebCore

Patch by Darin. Reviewed by Beth.

Fix for <rdar://problem/4424126> REGRESSION(412-420+): yellow
highlight fails to follow cursor when mousing over star rating
(6232)

Event coordinates cannot be calculated until there is a target.
This patch restructures the code so that the coordinates are
initialized when the mouse event is created but are not calculated
until the target is set.

Note: See TracTimeline for information about the timeline view.