Context Navigation

← Previous Period
Next Period →

Timeline

Feb 3, 2006:

8:57 PM Changeset in webkit [12554] by darin

1 edit
8 adds in trunk/LayoutTests

Reviewed by NOBODY (OOPS!).

Layout tests for bug 5776: Generated numbers of ordered lists (OL) are
not calculated right

fast/lists/ol-display-types-expected.checksum: Added.
fast/lists/ol-display-types-expected.png: Added.
fast/lists/ol-display-types-expected.txt: Added.
fast/lists/ol-display-types.html: Added.
fast/lists/olstart-expected.checksum: Added.
fast/lists/olstart-expected.png: Added.
fast/lists/olstart-expected.txt: Added.
fast/lists/olstart.html: Added.

8:56 PM Changeset in webkit [12553] by darin

2 edits in trunk/WebCore

Reviewed and tweaked by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5776 Generated numbers of ordered lists (OL) are not calculated right

Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

fast/lists/olstart.html
fast/lists/ol-display-types.html

khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly

6:54 PM Changeset in webkit [12552] by thatcher

1 edit in trunk/WebCore/ChangeLog

Correct the ChangeLog to credit Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>

6:14 PM Changeset in webkit [12551] by ggaren

1 edit in trunk/WebCore/ChangeLog

beth felt like the changelog was judging her

6:12 PM Changeset in webkit [12550] by ggaren

3 edits in trunk/WebCore

Reviewed beth.

Fixed <rdar://problem/4394868> window.open fails to parse "width=200px"

Cause: QString::toInt() is too aggressive; it parses letters as numbers.
The fix is to switch to DOMString. It's all the rage these days,
and its toInt() behavior matches what we want.

manual-tests/window-open-features-parsing.html: Added "px" case to giant evil string.

khtml/ecma/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::WindowFunc::callAsFunction):

6:01 PM Changeset in webkit [12549] by thatcher

17 edits
111 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt, Tim H.

Layout tests for:
Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

ChangeLog:
fast/media: Added.
fast/media/001-expected.checksum: Added.
fast/media/001-expected.png: Added.
fast/media/001-expected.txt: Added.
fast/media/001.html: Added.
fast/media/002-expected.checksum: Added.
fast/media/002-expected.png: Added.
fast/media/002-expected.txt: Added.
fast/media/002.html: Added.
fast/media/003-expected.checksum: Added.
fast/media/003-expected.png: Added.
fast/media/003-expected.txt: Added.
fast/media/003.html: Added.
fast/media/004-expected.checksum: Added.
fast/media/004-expected.png: Added.
fast/media/004-expected.txt: Added.
fast/media/004.html: Added.
fast/media/005-expected.checksum: Added.
fast/media/005-expected.png: Added.
fast/media/005-expected.txt: Added.
fast/media/005.html: Added.
fast/media/006-expected.checksum: Added.
fast/media/006-expected.png: Added.
fast/media/006-expected.txt: Added.
fast/media/006.html: Added.
fast/media/007-expected.checksum: Added.
fast/media/007-expected.png: Added.
fast/media/007-expected.txt: Added.
fast/media/007.html: Added.
fast/media/008-expected.checksum: Added.
fast/media/008-expected.png: Added.
fast/media/008-expected.txt: Added.
fast/media/008.html: Added.
fast/media/009-expected.checksum: Added.
fast/media/009-expected.png: Added.
fast/media/009-expected.txt: Added.
fast/media/009.html: Added.
fast/media/010-expected.checksum: Added.
fast/media/010-expected.png: Added.
fast/media/010-expected.txt: Added.
fast/media/010.html: Added.
fast/media/011-expected.checksum: Added.
fast/media/011-expected.png: Added.
fast/media/011-expected.txt: Added.
fast/media/011.html: Added.
fast/media/012-expected.checksum: Added.
fast/media/012-expected.png: Added.
fast/media/012-expected.txt: Added.
fast/media/012.html: Added.
fast/media/013-expected.checksum: Added.
fast/media/013-expected.png: Added.
fast/media/013-expected.txt: Added.
fast/media/013.html: Added.
fast/media/014-expected.checksum: Added.
fast/media/014-expected.png: Added.
fast/media/014-expected.txt: Added.
fast/media/014.html: Added.
fast/media/015-expected.checksum: Added.
fast/media/015-expected.png: Added.
fast/media/015-expected.txt: Added.
fast/media/015.html: Added.
fast/media/016-expected.checksum: Added.
fast/media/016-expected.png: Added.
fast/media/016-expected.txt: Added.
fast/media/016.html: Added.
fast/media/017-expected.checksum: Added.
fast/media/017-expected.png: Added.
fast/media/017-expected.txt: Added.
fast/media/017.html: Added.
fast/media/018-expected.checksum: Added.
fast/media/018-expected.png: Added.
fast/media/018-expected.txt: Added.
fast/media/018.html: Added.
fast/media/019-expected.checksum: Added.
fast/media/019-expected.png: Added.
fast/media/019-expected.txt: Added.
fast/media/019.html: Added.
fast/media/020-expected.checksum: Added.
fast/media/020-expected.png: Added.
fast/media/020-expected.txt: Added.
fast/media/020.html: Added.
fast/media/021-expected.checksum: Added.
fast/media/021-expected.png: Added.
fast/media/021-expected.txt: Added.
fast/media/021.html: Added.
fast/media/022-expected.checksum: Added.
fast/media/022-expected.png: Added.
fast/media/022-expected.txt: Added.
fast/media/022.html: Added.
fast/media/023-expected.checksum: Added.
fast/media/023-expected.png: Added.
fast/media/023-expected.txt: Added.
fast/media/023.html: Added.
fast/media/024-expected.checksum: Added.
fast/media/024-expected.png: Added.
fast/media/024-expected.txt: Added.
fast/media/024.html: Added.
fast/media/025-expected.checksum: Added.
fast/media/025-expected.png: Added.
fast/media/025-expected.txt: Added.
fast/media/025.html: Added.
fast/media/026-expected.checksum: Added.
fast/media/026-expected.png: Added.
fast/media/026.html: Added.
fast/media/import-p-green.css: Added.

WebCore:

Reviewed by Dave Hyatt and Tim H.

Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

http://www.w3.org/TR/css3-mediaqueries/

WebCore.xcodeproj/project.pbxproj:
css/css_grammar.y:
css/css_mediaqueryeval.cpp: Added. (MediaQueryEvaluator): (MediaQueryEvaluator::~MediaQueryEvaluator): (MediaQueryEvaluator::mediaTypeMatch): (applyRestrictor): (MediaQueryEvaluator::eval): (parseAspectRatio):
css/css_mediaqueryeval.h: Added.
css/css_mediaqueryimpl.cpp: Added. (MediaQueryExpImpl::MediaQueryExpImpl): (MediaQueryExpImpl::~MediaQueryExpImpl): (MediaQueryExpImpl::mediaFeature): (MediaQueryExpImpl::value): (MediaQueryImpl::MediaQueryImpl): (MediaQueryImpl::~MediaQueryImpl): (MediaQueryImpl::restrictor): (MediaQueryImpl::expressions): (MediaQueryImpl::mediaType): (MediaQueryImpl::operator==):
css/css_mediaqueryimpl.h: Added. (DOM::MediaQueryExpImpl::operator==): (DOM::MediaQueryExpListImpl::MediaQueryExpListImpl): (DOM::MediaQueryExpListImpl::append): (DOM::MediaQueryExpListImpl::list): (DOM::MediaQueryImpl::):
css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::deleteMedium): (mediaQueryAsDOMString): (MediaListImpl::mediaText): (MediaListImpl::setMediaText): (MediaListImpl::item): (MediaListImpl::appendMedium): (MediaListImpl::appendMediaQuery):
css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::mediaQueries):
css/css_valueimpl.h:
css/csshelper.h:
css/cssmediafeatures.in: Added.
css/cssparser.cpp: (CSSParser::parseMediaQuery):
css/cssparser.h:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::defaultStyleForRoot):
css/cssstyleselector.h:
css/makemediafeatures: Added.
css/maketokenizer:
css/tokenizer.flex:
khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
platform/Screen.h:
platform/mac/Screen.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):

5:48 PM Changeset in webkit [12548] by mjs

2 edits in trunk/WebKit

Reviewed by Darin.

change spellchecker preflighting to happen via class methods instead of object methods.

WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]): (+[WebView _preflightSpellCheckerNow:]): (+[WebView _preflightSpellChecker]):

3:34 PM Changeset in webkit [12547] by thatcher

14 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

DrawTest/DrawTest.xcodeproj/project.pbxproj:
DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Scripts/set-webkit-configuration:
Scripts/webkitdirs.pm:

2:46 PM Changeset in webkit [12546] by bdakin

2 edits in trunk/WebCore

Reviewed by Hyatt.

No test cases added because this is an unreproducible crash.

This is a speculative fix for <rdar://problem/4048026>
CrashTracer: [BOUNCE BACK] 1219 crashes in Safari at
com.apple.WebCore: KHTMLParser::popOneBlock + 36

It seems possible that current could be nil when this function is
called, so the speculative fix is to add a nil check.

3:22 AM Changeset in webkit [12545] by hyatt

4 edits
6 adds in trunk/WebCore

Refactoring of the image classes to make them even more
portable.

Reviewed by mjs

WebCore.xcodeproj/project.pbxproj:
platform/Image.cpp: (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::): (WebCore::Image::compositeOperatorFromString):
platform/ImageData.cpp: Added. (WebCore::FrameData::clear): (WebCore::ImageData::ImageData): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setNativeData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation):
platform/ImageData.h: Added. (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame):
platform/ImageDecoder.h:
platform/mac/Image.mm: (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::graphicsContext): (WebCore::setCompositingOperation): (WebCore::fillSolidColorInRect): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
platform/mac/ImageData.mm: Added. (WebCore::setCompositingOperation): (WebCore::ImageData::invalidateAppleSpecificData): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage):
platform/mac/PDFDocumentImage.h: Added.
platform/mac/PDFDocumentImage.mm: Added. (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw):

1:11 AM Changeset in webkit [12544] by hyatt

3 edits
2 adds in trunk/WebCore

Make a new class called ImageDecoder that wraps a CGImageSource.
This paves the way for ImageData to become portable as well.

Reviewed by mjs

WebCore.xcodeproj/project.pbxproj:
platform/ImageDecoder.h: Added.
platform/mac/Image.mm: (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::size): (WebCore::ImageData::setCFData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::drawInRect):
platform/mac/ImageDecoder.cpp: Added. (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::imageSourceOptions): (WebCore::ImageDecoder::initialized): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::createFrameAtIndex): (WebCore::ImageDecoder::frameDurationAtIndex):

Feb 2, 2006:

11:32 PM Changeset in webkit [12543] by hyatt

5 edits
1 add in trunk/WebCore

Move ImageAnimationObserver into its own file.

Reviewed by mjs

WebCore.xcodeproj/project.pbxproj:
loader/CachedImage.h:
platform/Image.h:
platform/ImageAnimationObserver.h: Added. (WebCore::ImageAnimationObserver::~ImageAnimationObserver):
platform/mac/Image.mm:

11:18 PM Changeset in webkit [12542] by mjs

8 edits
1 add in trunk/WebCore

Reviewed by Adele.

remove all use of the ChildFrame from outside Frame.cpp, in preparation for removing it

bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::frameDetached): Factor out the ChildFrame manipulations into a base class method. (WebCore::MacFrame::objectContentType): factored out from createPart, calls the bridge to determine contents for an Object tag. (WebCore::MacFrame::createPlugin): factor out code from createPart that makes a Plugin. (WebCore::MacFrame::createFrame): ditto for code that makes a Frame. (WebCore::MacFrame::createEmptyDocument): factored out part into the superclass
khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): Call new ownerElement method on Frame instead of mucking at Frame internals.
page/Frame.cpp: (WebCore::Frame::createPart): Moved here from MacFrame, but some of the guts were factored out. (WebCore::Frame::ownerElement): New method, logic moved from DocumentImpl. (WebCore::Frame::frameDetached): New virtual method, the part of this that pokes at ChildFrame structures. (WebCore::Frame::updateBaseURLForEmptyDocument): Helper that looks at the ChildFrame array for the benefit of createEmptyDocument.
page/Frame.h:
page/Page.h: Fix up modeline.
page/Plugin.h: Added. (WebCore::Plugin::Plugin): Moved here from MacFrame.mm, since it is now used by Frame. (WebCore::Plugin::view): ditto

9:47 PM Changeset in webkit [12541] by hyatt

2 edits in trunk/WebCore

Avoid extra copies of all the decoded image bytes.

Reviewed by mjs

platform/mac/Image.mm: (WebCore::ImageData::setData):

5:16 PM Changeset in webkit [12540] by justing

141 edits
4 adds in trunk/LayoutTests

Reviewed by harrison

Turned on continuous spell checking to test the fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Added:

editing/selection/end-of-document.html

Pixel results for editing tests now include misspelling markers.
A few of them are incorrect, filed 7038 to cover this.

editing/deleting/delete-3928305-fix-expected.checksum:
editing/deleting/delete-3928305-fix-expected.png:
editing/deleting/delete-3959464-fix-expected.checksum:
editing/deleting/delete-3959464-fix-expected.png:
editing/deleting/delete-after-span-ws-001-expected.checksum:
editing/deleting/delete-after-span-ws-001-expected.png:
editing/deleting/delete-after-span-ws-002-expected.checksum:
editing/deleting/delete-after-span-ws-002-expected.png:
editing/deleting/delete-after-span-ws-003-expected.checksum:
editing/deleting/delete-after-span-ws-003-expected.png:
editing/deleting/delete-and-undo-expected.checksum:
editing/deleting/delete-and-undo-expected.png:
editing/deleting/delete-block-contents-003-expected.checksum:
editing/deleting/delete-block-contents-003-expected.png:
editing/deleting/delete-block-merge-contents-010-expected.checksum:
editing/deleting/delete-block-merge-contents-010-expected.png:
editing/deleting/delete-contiguous-ws-001-expected.checksum:
editing/deleting/delete-contiguous-ws-001-expected.png:
editing/deleting/delete-tab-002-expected.checksum:
editing/deleting/delete-tab-002-expected.png:
editing/deleting/delete-tab-003-expected.checksum:
editing/deleting/delete-tab-003-expected.png:
editing/deleting/delete-trailing-ws-002-expected.checksum:
editing/deleting/delete-trailing-ws-002-expected.png:
editing/deleting/delete-ws-fixup-001-expected.checksum:
editing/deleting/delete-ws-fixup-001-expected.png:
editing/deleting/delete-ws-fixup-002-expected.checksum:
editing/deleting/delete-ws-fixup-002-expected.png:
editing/inserting/editing-empty-divs-expected.checksum:
editing/inserting/editing-empty-divs-expected.png:
editing/inserting/insert-3659587-fix-expected.checksum:
editing/inserting/insert-3659587-fix-expected.png:
editing/inserting/insert-br-004-expected.checksum:
editing/inserting/insert-br-004-expected.png:
editing/inserting/insert-br-005-expected.checksum:
editing/inserting/insert-br-005-expected.png:
editing/inserting/insert-br-007-expected.checksum:
editing/inserting/insert-br-007-expected.png:
editing/inserting/insert-div-007-expected.checksum:
editing/inserting/insert-div-007-expected.png:
editing/inserting/insert-div-012-expected.checksum:
editing/inserting/insert-div-012-expected.png:
editing/inserting/insert-div-013-expected.checksum:
editing/inserting/insert-div-013-expected.png:
editing/inserting/insert-div-014-expected.checksum:
editing/inserting/insert-div-014-expected.png:
editing/inserting/insert-div-015-expected.checksum:
editing/inserting/insert-div-015-expected.png:
editing/inserting/insert-div-016-expected.checksum:
editing/inserting/insert-div-016-expected.png:
editing/inserting/insert-div-017-expected.checksum:
editing/inserting/insert-div-017-expected.png:
editing/inserting/insert-div-018-expected.checksum:
editing/inserting/insert-div-018-expected.png:
editing/inserting/insert-div-019-expected.checksum:
editing/inserting/insert-div-019-expected.png:
editing/inserting/insert-div-020-expected.checksum:
editing/inserting/insert-div-020-expected.png:
editing/inserting/insert-div-021-expected.checksum:
editing/inserting/insert-div-021-expected.png:
editing/inserting/insert-div-022-expected.checksum:
editing/inserting/insert-div-022-expected.png:
editing/inserting/insert-div-025-expected.checksum:
editing/inserting/insert-div-025-expected.png:
editing/inserting/insert-div-027-expected.checksum:
editing/inserting/insert-div-027-expected.png:
editing/inserting/insert-tab-002-expected.checksum:
editing/inserting/insert-tab-002-expected.png:
editing/inserting/insert-tab-003-expected.checksum:
editing/inserting/insert-tab-003-expected.png:
editing/inserting/insert-text-with-newlines-expected.checksum:
editing/inserting/insert-text-with-newlines-expected.png:
editing/inserting/return-key-with-selection-001-expected.checksum:
editing/inserting/return-key-with-selection-001-expected.png:
editing/inserting/return-key-with-selection-002-expected.checksum:
editing/inserting/return-key-with-selection-002-expected.png:
editing/inserting/return-key-with-selection-003-expected.checksum:
editing/inserting/return-key-with-selection-003-expected.png:
editing/inserting/typing-002-expected.checksum:
editing/inserting/typing-002-expected.png:
editing/inserting/typing-around-br-001-expected.checksum:
editing/inserting/typing-around-br-001-expected.png:
editing/pasteboard/cut-text-001-expected.checksum:
editing/pasteboard/cut-text-001-expected.png:
editing/pasteboard/paste-list-001-expected.checksum:
editing/pasteboard/paste-text-001-expected.checksum:
editing/pasteboard/paste-text-001-expected.png:
editing/pasteboard/paste-text-012-expected.checksum:
editing/pasteboard/paste-text-012-expected.png:
editing/pasteboard/paste-text-013-expected.checksum:
editing/pasteboard/paste-text-013-expected.png:
editing/pasteboard/paste-text-014-expected.checksum:
editing/pasteboard/paste-text-014-expected.png:
editing/pasteboard/paste-text-019-expected.checksum:
editing/pasteboard/paste-text-019-expected.png:
editing/selection/3690703-2-expected.checksum:
editing/selection/3690703-expected.checksum:
editing/selection/3690719-expected.checksum:
editing/selection/extend-by-word-001-expected.checksum:
editing/selection/extend-by-word-001-expected.png:
editing/selection/iframe-expected.checksum:
editing/selection/iframe-expected.png:
editing/selection/move-backwords-by-word-001-expected.checksum:
editing/selection/move-backwords-by-word-001-expected.png:
editing/selection/move-by-character-001-expected.checksum:
editing/selection/move-by-character-001-expected.png:
editing/selection/move-by-line-001-expected.checksum:
editing/selection/move-by-line-001-expected.png:
editing/selection/move-by-word-001-expected.checksum:
editing/selection/move-by-word-001-expected.png:
editing/selection/replaced-boundaries-1-expected.checksum:
editing/selection/replaced-boundaries-1-expected.png:
editing/selection/unrendered-002-expected.checksum:
editing/selection/unrendered-002-expected.png:
editing/style/block-styles-007-expected.checksum:
editing/style/block-styles-007-expected.png:
editing/style/create-block-for-style-002-expected.checksum:
editing/style/create-block-for-style-002-expected.png:
editing/style/create-block-for-style-003-expected.checksum:
editing/style/create-block-for-style-003-expected.png:
editing/style/create-block-for-style-004-expected.checksum:
editing/style/create-block-for-style-004-expected.png:
editing/style/create-block-for-style-006-expected.checksum:
editing/style/create-block-for-style-006-expected.png:
editing/style/create-block-for-style-008-expected.checksum:
editing/style/create-block-for-style-008-expected.png:
editing/style/create-block-for-style-009-expected.checksum:
editing/style/create-block-for-style-009-expected.png:
editing/style/create-block-for-style-011-expected.checksum:
editing/style/create-block-for-style-011-expected.png:
editing/style/create-block-for-style-012-expected.checksum:
editing/style/create-block-for-style-012-expected.png:
editing/style/create-block-for-style-013-expected.checksum:
editing/style/create-block-for-style-013-expected.png:
editing/unsupported-content/list-type-after-expected.checksum:
editing/unsupported-content/list-type-before-expected.checksum:
editing/unsupported-content/table-type-after-expected.checksum:
editing/unsupported-content/table-type-before-expected.checksum:
fast/dom/blur-contenteditable-expected.checksum:
fast/dom/blur-contenteditable-expected.png:

5:14 PM Changeset in webkit [12539] by justing

2 edits in trunk/WebKitTools

Reviewed by thatcher

Enabled spell checking for layout tests.

DumpRenderTree/DumpRenderTree.m: (main):

5:14 PM Changeset in webkit [12538] by justing

3 edits in trunk/WebCore

Reviewed by darin, harrison

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6586>
REGRESSION: visible_text.cpp assertion failure in Mail.app

Calling range() on a WordIterator destroyed its RangeImpl, use
RefPtr instead of PassRefPtr.
Turned on continuous spell checking to test the fix, found
a crasher caused by invalid positions created in
previousBoundary.

Added layout test:

editing/selection/end-of-document.html

khtml/editing/visible_text.h:
khtml/editing/visible_units.cpp: (khtml::previousBoundary):

4:02 PM Changeset in webkit [12537] by hyatt

2 edits in trunk/WebCore

Vectorize Image. Optimize so that we no longer throw away
all CGImageRefs. Now we just throw away the last frame.

Reviewed by mjs

platform/mac/Image.mm: (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::FrameData::clear): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex):

3:18 PM Changeset in webkit [12536] by ggaren

6 edits in trunk/WebCore

Reviewed by mjs.

Cleaned up some stuff I came across when working with JS enabled/
disabled code:

(1) Renamed initScript to initScriptIfNeeded, because that's what it

does

(2) Removed dead or otherwise irrelevent code
(3) Fixed up comments
(4) Removed NULL checks for interpreter() since it never returns NULL,

replaced with single assert().

No test case because there's no change in behavior.

khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate): 1 (WebCore::KJSProxyImpl::createHTMLEventHandler): 1 (WebCore::KJSProxyImpl::createSVGEventHandler): 1 (WebCore::KJSProxyImpl::interpreter): 4 (WebCore::KJSProxyImpl::initScriptIfNeeded): 1
khtml/ecma/kjs_proxy.h: 1
page/Frame.cpp: (Frame::didOpenURL): 2, 3 (Frame::stopLoading): 2 (Frame::jScriptEnabled): 2 (Frame::jScript): changed method call to data member access to match

style of rest of class

(Frame::javaEnabled): 2
(Frame::pluginsEnabled): 2
(Frame::begin): 3
(Frame::userGestureHint): 4
(Frame::pauseTimeouts): collapsed a line
(Frame::resumeTimeouts): ditto
(Frame::saveInterpreterBuiltins): 4
(Frame::restoreInterpreterBuiltins): 4

page/Frame.h: 2
page/FramePrivate.h: 2 (FramePrivate::FramePrivate): 2

1:19 PM Changeset in webkit [12535] by hyatt

2 edits in trunk/WebCore

Fix for PLT performance regression. Make sure that the document's load event timer
isn't started again if it's already active.

Reviewed by mjs

khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::dispatchImageLoadEventSoon):

1:00 PM Changeset in webkit [12534] by staikos

2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

kjs/lookup.h: Fix compile, merged from KDE.

9:32 AM Changeset in webkit [12533] by darin

1 edit
4 adds in trunk/LayoutTests

tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7000 REGRESSION: Scrolling is triggering onunload in TOT

fast/events/onunload-body-property.html: Added.
fast/events/onunload-body-property-expected.txt: Added.
fast/events/onunload-window-property.html: Added.
fast/events/onunload-window-property-expected.txt: Added.

9:31 AM Changeset in webkit [12532] by darin

3 edits in trunk/WebCore

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7000 REGRESSION: Scrolling is triggering onunload in TOT

Tests:

fast/events/onunload-body-property.html
fast/events/onunload-window-property.html

khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::getValueProperty): Change onunload case to use unloadEvent, not scrollEvent. (KJS::DOMNode::putValueProperty): Ditto.
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::putValueProperty): Ditto.

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6998 setTimeout(0) tight loop uses almost all CPU (need 10ms minimum for timeout?)

khtml/ecma/kjs_window.cpp: (KJS::WindowQObject::installTimeout): When converting the timeout number from an integer ms to a double seconds, use a 10 ms minimum.

9:15 AM Changeset in webkit [12531] by darin

2 edits in trunk/WebCore

added a FIXME about an incorrect change made to FloatRect to fix the Win32 compile

platform/FloatRect.cpp: (WebCore::enclosingIntRect): Added FIXME because this should do a ceil operation, not a round operation.

1:29 AM Changeset in webkit [12530] by hyatt

3 edits in trunk/WebCore

Fix win32 bustage. #ifdef enclosingIntRect using. Remove floorf and ceilf from enclosingIntRect impl since it's not needed. Fix the bad #import in qmatrix.h

1:00 AM Changeset in webkit [12529] by darin

2 deletes in trunk/WebCore/platform

Deleted these files, Dave checked them in by mistake.

12:52 AM Changeset in webkit [12528] by hyatt

1 edit in trunk/LayoutTests/fast/text/whitespace/006-expected.txt

Check in revised results for 006.html test.

12:40 AM Changeset in webkit [12527] by hyatt

33 edits
2 copies in trunk/WebCore

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).

Reviewed by darin

WebCore.exp:
bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
bindings/objc/DOMPrivate.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent): (WebCore::MacFrame::fileWrapperForElement):
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
kcanvas/RenderSVGImage.cpp: (RenderSVGImage::imageChanged):
kcanvas/RenderSVGImage.h:
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
khtml/ecma/kjs_html.cpp: (KJS::drawPattern):
kwq/KWQClipboard.h: (WebCore::KWQClipboard::setDragHasStarted):
kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
kwq/KWQCursor.mm: (WebCore::createCustomCursor):
kwq/KWQPainter.h: (WebCore::QPainter::):
kwq/KWQPainter.mm: (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
kwq/KWQScrollView.h:
kwq/KWQScrollView.mm: (QScrollView::inWindow):
kwq/WebCoreImageRendererFactory.h:
kwq/WebCoreImageRendererFactory.m:
loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::imageRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::shouldStopAnimation): (WebCore::CachedImage::animationAdvanced):
loader/CachedImage.h: (WebCore::CachedImage::canRender):
loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged): (WebCore::CachedObjectClient::willRenderImage):
platform/Image.h: (WebCore::ImageAnimationObserver::~ImageAnimationObserver): (WebCore::Image::animationObserver): (WebCore::Image::):
platform/mac/Image.mm: (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame): (WebCore::m_PDFDoc): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setCFData): (WebCore::ImageData::imageSourceOptions): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation): (WebCore::ImageData::setCompositingOperation): (WebCore::ImageData::fillSolidColorInRect): (WebCore::ImageData::drawInRect): (WebCore::drawPattern): (WebCore::): (WebCore::ImageData::tileInRect): (WebCore::ImageData::scaleAndTileInRect): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::graphicsContext): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
rendering/render_image.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged):
rendering/render_image.h:
rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
rendering/render_list.cpp: (RenderListMarker::imageChanged):
rendering/render_list.h:
rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::imageChanged): (WebCore::RenderObject::willRenderImage):
rendering/render_object.h:

12:37 AM Changeset in webkit [12526] by hyatt

10 edits in trunk/WebKit

Fix for bug 6957, rewrite image rendering in C++ and move it to
WebCore. Animation now stops lazily and just uses the CachedObject
notification system to push updates so that rects no longer need to
be cached (or sets of animating renderers in specific views).

Reviewed by darin

Misc.subproj/WebNSPasteboardExtras.h:
Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): (-[NSPasteboard _web_declareAndWriteDragImage:element:URL:title:archive:source:]):
Misc.subproj/WebNSViewExtras.h:
Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
WebCoreSupport.subproj/WebImageData.m: (-[WebImageData init]):
WebCoreSupport.subproj/WebImageRendererFactory.m: (+[WebImageRendererFactory shouldUseThreadedDecoding]): (+[WebImageRendererFactory setShouldUseThreadedDecoding:]): (-[WebImageRendererFactory setPatternPhaseForContext:inUserSpace:]): (-[WebImageRendererFactory imageDataForName:]):
WebView.subproj/WebHTMLView.m: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
WebView.subproj/WebImageView.m: (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
WebView.subproj/WebView.m: (-[WebView _writeImageElement:withPasteboardTypes:toPasteboard:]):

12:36 AM Changeset in webkit [12525] by darin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6881 Block with position:absolute bottom:0 doesn't always move when height of containing block changes (affects Safari RSS)

fast/block/positioning/height-change-expected.checksum: Added.
fast/block/positioning/height-change-expected.png: Added.
fast/block/positioning/height-change-expected.txt: Added.
fast/block/positioning/height-change.html: Added.

12:35 AM Changeset in webkit [12524] by darin

3 edits in trunk/WebCore

Test: LayoutTests/fast/block/positioning/height-change.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6881 Block with position:absolute bottom:0 doesn't always move when height of containing block changes (affects Safari RSS)

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Relayout positioned children if the block's height changed during layout.
rendering/render_flexbox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.

12:22 AM Changeset in webkit [12523] by darin