⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 5, 2006:

11:49 PM Changeset in webkit [12593] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Anders.


  • kjs/internal.cpp: (KJS::Parser::noteNodeCycle): (KJS::Parser::removeNodeCycle): (KJS::clearNewNodes):
  • kjs/internal.h:
  • kjs/nodes.cpp: (ElementNode::breakCycle): (PropertyListNode::breakCycle): (ArgumentListNode::breakCycle): (StatListNode::StatListNode): (StatListNode::breakCycle): (VarDeclListNode::breakCycle): (BlockNode::BlockNode): (ClauseListNode::breakCycle): (CaseBlockNode::CaseBlockNode): (ParameterNode::breakCycle): (SourceElementsNode::SourceElementsNode): (SourceElementsNode::breakCycle):
  • kjs/nodes.h: (KJS::Node::breakCycle): (KJS::ElementNode::ElementNode): (KJS::ArrayNode::ArrayNode): (KJS::PropertyListNode::PropertyListNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarDeclListNode::VarDeclListNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ParameterNode::ParameterNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
11:25 PM Changeset in webkit [12592] by mjs
  • 11 edits in trunk/WebKit

Reviewed by Darin.


  • WebCoreSupport.subproj/WebFrameBridge.h:
  • WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:frameName:view:]): (-[WebFrameBridge page]): (-[WebFrameBridge mainFrame]): (-[WebFrameBridge webView]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge showWindow]): (-[WebFrameBridge areToolbarsVisible]): (-[WebFrameBridge setToolbarsVisible:]): (-[WebFrameBridge isStatusbarVisible]): (-[WebFrameBridge setStatusbarVisible:]): (-[WebFrameBridge setWindowFrame:]): (-[WebFrameBridge windowFrame]): (-[WebFrameBridge setWindowContentRect:]): (-[WebFrameBridge windowContentRect]): (-[WebFrameBridge setWindowIsResizable:]): (-[WebFrameBridge windowIsResizable]): (-[WebFrameBridge firstResponder]): (-[WebFrameBridge makeFirstResponder:]): (-[WebFrameBridge closeWindowSoon]): (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]): (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]): (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]): (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebFrameBridge addMessageToConsole:]): (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebFrameBridge setStatusText:]): (-[WebFrameBridge startLoadingResource:withURL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withURL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge focusWindow]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebFrameBridge userAgentForURL:]): (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge defersLoading]): (-[WebFrameBridge setDefersLoading:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge selectWordBeforeMenuEvent]): (-[WebFrameBridge historyLength]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge undoManager]): (-[WebFrameBridge issueCutCommand]): (-[WebFrameBridge issueCopyCommand]): (-[WebFrameBridge issuePasteCommand]): (-[WebFrameBridge issuePasteAndMatchStyleCommand]): (-[WebFrameBridge canPaste]): (-[WebFrameBridge overrideMediaType]): (-[WebFrameBridge isEditable]): (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebFrameBridge shouldBeginEditing:]): (-[WebFrameBridge shouldEndEditing:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge spellCheckerDocumentTag]): (-[WebFrameBridge isContinuousSpellCheckingEnabled]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge dashboardRegionsChanged:]): (-[WebFrameBridge createModalDialogWithURL:]): (-[WebFrameBridge canRunModal]): (-[WebFrameBridge runModal]):
  • WebCoreSupport.subproj/WebPageBridge.h:
  • WebCoreSupport.subproj/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): (-[WebPageBridge webView]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _webView]): (-[WebDataSource _setLoading:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _setWebFrame:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _traverseNextFrameStayWithin::]): (-[WebFrame _detachFromParent]): (-[WebFrame _setDataSource:]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame webView]):
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _webView]): (-[WebFrameView _goBack]): (-[WebFrameView _goForward]):
  • WebView.subproj/WebFrameViewInternal.h:
  • WebView.subproj/WebView.m: (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
11:06 PM Changeset in webkit [12591] by andersca
  • 5 edits
    6 adds in trunk/WebCore

2006-02-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • JSCore.cpp: Add new generated files.


  • bindings/scripts/CodeGeneratorJS.pm: Add "IsIndex" extended attribute for parameters. Any parameter that is "unsigned long" and has this attribute will be checked to make sure that it's not < 0. If it is, an index size error exception will be thrown.


  • khtml/ecma/kjs_dom.cpp: (KJS::toAttr): Use JSAttr::info.


(KJS::getDOMNode):
Use new constructors.


  • khtml/ecma/kjs_dom.h: Remove classes that are generated now.


  • khtml/xml/Attr.idl: Added.
  • khtml/xml/CharacterData.idl: Added.
  • khtml/xml/Entity.idl: Added.
  • khtml/xml/Notation.idl: Added.
  • khtml/xml/ProcessingInstruction.idl: Added.
  • khtml/xml/Text.idl: Added.
9:57 PM Changeset in webkit [12590] by eseidel
  • 2 edits in trunk/WebKitSite

2006-02-05 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

General update to SVG project page, also link to status page.

  • projects/svg/index.html:
9:36 PM Changeset in webkit [12589] by eseidel
  • 4 adds in trunk/WebKitSite

2006-02-05 Eric Seidel <​eseidel@apple.com>

Rubber stamped by darin.

  • projects/svg/status.xml: Added.
  • projects/svg/svg-status.css: Added.
  • projects/svg/svg-status.xsl: Added.

2006-02-05 Eric Seidel <​eseidel@apple.com>

Adding ChangeLog :)


  • ChangeLog: Added.
6:36 PM Changeset in webkit [12588] by darin
  • 4 edits in trunk/LayoutTests
  • converted three more files from UTF-16 to ASCII that had no reason to be UTF-16
  • fast/dom/resources/top.html: Just straight conversion to ASCII.
  • fast/events/updateLayoutForHitTest.html: Converted one character to an entity, and reformatted the file a bit.
  • fast/text/line-breaks.html: Just straight conversion to ASCII.
3:07 PM Changeset in webkit [12587] by mjs
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Re-landing test case for:

  • fast/events/iframe-object-onload-expected.txt: Added.
  • fast/events/iframe-object-onload.html: Added.


  • changed expected results and description for this test, unload should not fire in this case:


  • fast/events/onunload-body-property-expected.txt:
  • fast/events/onunload-body-property.html:


  • changed from UTF-16 to ASCII, there was no reason for this to be UTF-16.
  • fast/dom/attr_dead_doc.html:

WebCore:

Reviewed by Darin.


Re-landed the following with more fixes so it does not break tests:


Specific changes:


  • don't bother to nil-check the document, a node can never have a null document now
  • move temp event forgetting from dispatchEvent to dispatchGenericEvent
  • pass event down using RefPtr::release() to avoid ref thrashing
  • support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers
  • dispatch a whole separate load event to a frame document's containing frame
  • don't let propagationStopped prevent this new event
  • remove bogus security check for iframe onload
  • dispatch window events on the document, not the body, and also for non-html
  • set onload, onunload, onbeforeunload from frameset tags on the window object
  • don't restrict load/unload events to HTML
  • send default handler to the dispatch object as previously
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::parseMappedAttribute): (WebCore::HTMLFrameSetElementImpl::parseMappedAttribute):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent):
  • khtml/xml/NodeImpl.h:
  • page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::setWindowHasFocus):
12:31 PM Changeset in webkit [12586] by darin
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • fix <rdar://problem/4197997> -[DOMHTMLSelectElement options] always returns an empty list
  • khtml/html/HTMLOptionsCollectionImpl.h: Changed to be a subclass of HTMLCollectionImpl.
  • khtml/html/HTMLOptionsCollectionImpl.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added new source file.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLOptionsCollection setLength:]): Handle possible exception. (-[DOMHTMLSelectElement options]): Add get() since this is now a PassRefPtr.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::selectIndexGetter): Call options() instead of optionsHTMLCollection(). (KJS::HTMLElement::selectGetter): Ditto. (KJS::KJS::HTMLElement::put): Ditto. (KJS::HTMLElement::selectSetter): Ditto. (KJS::KJS::HTMLSelectCollection::put): Ditto.
  • khtml/html/HTMLSelectElementImpl.h: Tweaked formatting. Eliminated m_options. Changed m_minwidth and m_size to int instead of short. Removed optionsHTMLCollection(). Changed options() to return a PassRefPtr.
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl): Get rid of code to drop m_options. (WebCore::HTMLSelectElementImpl::remove): Remove unnecesssary RefPtr use, since that's handled fine by removeChild. (WebCore::HTMLSelectElementImpl::options): Change to create a new HTMLOptionsCollectionImpl each time, like other collection calls. Maybe we should change this eventually to use a HashMap so we can pass out the same collection over and over again, or could have a pointer stored in the select element that's managed by the collection itself.
11:34 AM Changeset in webkit [12585] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/forms/select-replace-option.html: Added.
  • fast/forms/select-replace-option-expected.txt: Added.
11:33 AM Changeset in webkit [12584] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to put reviewer name in.

11:33 AM Changeset in webkit [12583] by darin
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Test: fast/forms/select-replace-option.html

  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLSelectCollection::put): Use optionsHTMLCollection, because options isn't really implemented yet.
11:18 AM Changeset in webkit [12582] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Add check for nil in case the blur event causes the KWQLineEdit to be destroyed.
11:17 AM Changeset in webkit [12581] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/replaced/object-param-no-name.html: Added.
  • fast/replaced/object-param-no-name-expected.txt: Added.
  • fixed test that I landed incorrectly earlier
  • fast/overflow/onscroll-layer-self-destruct.html: Removed Subversion property junk.
  • fast/overflow/onscroll-layer-self-destruct-expected.txt: Ditto.
11:16 AM Changeset in webkit [12580] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: fast/replaced/object-param-no-name.html

  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Check for empty name, and skip processing the name/value of that <param> element.
11:00 AM Changeset in webkit [12579] by darin
  • 1 edit
    2 deletes in trunk/LayoutTests
  • rolled out Maciej's event cleanup patch, which is causing problems

I believe he has a fix, and he'll re-land the patch with the fix later.

Original fix was <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
Problems described in <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

11:00 AM Changeset in webkit [12578] by darin
  • 4 edits in trunk/WebCore
  • rolled out Maciej's event cleanup patch, which is causing problems

I believe he has a fix, and he'll re-land the patch with the fix later.

Original fix was <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
Problems described in <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

10:19 AM Changeset in webkit [12577] by darin
  • 2 edits in trunk/WebCore
  • ksvg2/css/KSVGCSSParser.cpp: Remove config.h, since this is included by another .cpp file -- oops!
10:16 AM Changeset in webkit [12576] by darin
  • 7 edits
    2 deletes in trunk/WebCore

Discussed with Anders (didn't get real review).

  • fix build
  • WebCore+SVG/SVGNamesWrapper.cpp: Touch file, not getting rebuilt even though it includes config.h which changed.
  • WebCore+SVG/XLinkNamesWrapper.cpp: Ditto.
  • ksvg2/css/KSVGCSSParser.cpp: Added include of config.h.
  • platform/mac/ImageDecoder.cpp: Ditto.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed IntPoint.cpp and IntSize.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/IntPoint.cpp: Removed. Was empty.
  • platform/IntSize.cpp: Removed. Was empty.
9:21 AM Changeset in webkit [12575] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Maciej.

  • fast/overflow/onscroll-layer-self-destruct.html: Added.
  • fast/overflow/onscroll-layer-self-destruct-expected.txt: Added.
3:48 AM Changeset in webkit [12574] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: onscroll-layer-self-destruct.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset): Don't send the scroll event until after we've done everything else we need to do.
2:37 AM Changeset in webkit [12573] by darin
  • 99 edits
    1 copy
    6 moves in trunk/WebCore

Rubber stamped by Maciej.

  • renamed DOMString and DOMStringImpl to String and StringImpl, and moved into platform
  • config.h: Put in transitional defines so old code can still refer to the classes as DOMString and DOMStringImpl.
  • platform/AtomicString.cpp: Added.
  • platform/AtomicString.h: Added.
  • platform/AtomicStringImpl.h: Added.
  • platform/PlatformString.h: Added.
  • platform/String.cpp: Added.
  • platform/StringImpl.cpp: Added.
  • platform/StringImpl.h: Added. Moved files here and renamed them. PlatformString.h would be named String.h except that conflicts with <string.h> on non-case-sensitive file systems.
  • khtml/xml/dom_atomicstring.cpp: Removed.
  • khtml/xml/dom_atomicstring.h: Removed.
  • khtml/xml/dom_stringimpl.cpp: Removed.
  • khtml/xml/dom_stringimpl.h: Removed.
  • khtml/dom/dom_string.cpp: Removed.
  • khtml/dom/dom_string.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for file adds and removes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/Namespace.h:
  • WebCore+SVG/kdom.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMInternal.mm:
  • bridge/BrowserExtension.h:
  • css/css_base.h:
  • css/css_computedstyle.cpp:
  • css/css_grammar.y:
  • css/css_ruleimpl.h:
  • css/css_stylesheetimpl.cpp:
  • css/css_stylesheetimpl.h:
  • css/css_valueimpl.cpp:
  • css/csshelper.cpp:
  • css/csshelper.h:
  • css/cssparser.h:
  • css/cssstyleselector.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/ecma/JSXMLHttpRequest.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/delete_from_text_node_command.h:
  • khtml/editing/insert_into_text_node_command.h:
  • khtml/editing/jsediting.h:
  • khtml/editing/rebalance_whitespace_command.h:
  • khtml/editing/remove_css_property_command.h:
  • khtml/editing/typing_command.h:
  • khtml/html/FormDataList.h:
  • khtml/html/HTMLNameCollectionImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/khtml_events.h:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • khtml/xbl/xbl_protoimplementation.h:
  • khtml/xml/DOMImplementationImpl.cpp:
  • khtml/xml/EventNames.h:
  • khtml/xml/NameNodeListImpl.h:
  • khtml/xml/NamedNodeMapImpl.h:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_atomicstringlist.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_qname.h:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/svg/SVGAngleImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp:
  • ksvg2/svg/SVGAnimatedStringImpl.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.h:
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.cpp:
  • ksvg2/svg/SVGPaintImpl.h:
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGScriptElementImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.h:
  • ksvg2/svg/SVGStylableImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGSymbolElementImpl.cpp:
  • ksvg2/svg/SVGViewElementImpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontFamily.mm:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • page/FrameTreeNode.h:
  • platform/SegmentedString.h:
  • rendering/render_image.h:
  • rendering/render_style.cpp:
  • xml/xmlhttprequest.cpp: Updated all includes to use new filenames.
1:53 AM Changeset in webkit [12572] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Hyatt.


  • fix default traits for classes to make sure default constructors get called
  • kxmlcore/VectorTraits.h: (KXMLCore::):
1:45 AM Changeset in webkit [12571] by mjs
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test case for:

  • fast/events/iframe-object-onload-expected.txt: Added.
  • fast/events/iframe-object-onload.html: Added.

WebCore:

Reviewed by Darin.


Specific changes:


  • don't bother to nil-check the document, a node can never have a null document now
  • move temp event forgetting from dispatchEvent to dispatchGenericEvent
  • pass event down using RefPtr::release() to avoid ref thrashing
  • support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers
  • dispatch a whole separate load event to a frame document's containing frame
  • don't let propagationStopped prevent this new event
  • remove bogus security check for iframe onload
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent):
  • khtml/xml/NodeImpl.h:
12:49 AM Changeset in webkit [12570] by andersca
  • 3 edits in trunk/WebCore

2006-02-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed and landed by Anders.


12:29 AM Changeset in webkit [12569] by ap
  • 2 edits in trunk/WebCore

Fix by David Kilzer, reviewed by Darin, landed by ap (with a tweak suggested by Darin).

  • kwq/KWQPainter.mm: Include "FloatRect.h".

Feb 4, 2006:

9:44 PM Changeset in webkit [12568] by mjs
  • 14 edits in trunk/WebCore

Reviewed by Darin.

  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): (WebCore::HTMLOptGroupElementImpl::replaceChild): (WebCore::HTMLOptGroupElementImpl::removeChild): (WebCore::HTMLOptGroupElementImpl::appendChild):
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::insertBefore): (WebCore::HTMLSelectElementImpl::replaceChild): (WebCore::HTMLSelectElementImpl::removeChild): (WebCore::HTMLSelectElementImpl::appendChild):
  • khtml/html/HTMLSelectElementImpl.h:
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::createTFoot):
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • khtml/xml/ContainerNodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::insertBefore): (WebCore::NodeImpl::replaceChild): (WebCore::NodeImpl::removeChild): (WebCore::NodeImpl::appendChild):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
9:24 PM Changeset in webkit [12567] by mjs
  • 17 edits
    110 deletes in trunk

LayoutTests:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • fast/media/001-expected.checksum: Removed.
  • fast/media/001-expected.png: Removed.
  • fast/media/001-expected.txt: Removed.
  • fast/media/001.html: Removed.
  • fast/media/002-expected.checksum: Removed.
  • fast/media/002-expected.png: Removed.
  • fast/media/002-expected.txt: Removed.
  • fast/media/002.html: Removed.
  • fast/media/003-expected.checksum: Removed.
  • fast/media/003-expected.png: Removed.
  • fast/media/003-expected.txt: Removed.
  • fast/media/003.html: Removed.
  • fast/media/004-expected.checksum: Removed.
  • fast/media/004-expected.png: Removed.
  • fast/media/004-expected.txt: Removed.
  • fast/media/004.html: Removed.
  • fast/media/005-expected.checksum: Removed.
  • fast/media/005-expected.png: Removed.
  • fast/media/005-expected.txt: Removed.
  • fast/media/005.html: Removed.
  • fast/media/006-expected.checksum: Removed.
  • fast/media/006-expected.png: Removed.
  • fast/media/006-expected.txt: Removed.
  • fast/media/006.html: Removed.
  • fast/media/007-expected.checksum: Removed.
  • fast/media/007-expected.png: Removed.
  • fast/media/007-expected.txt: Removed.
  • fast/media/007.html: Removed.
  • fast/media/008-expected.checksum: Removed.
  • fast/media/008-expected.png: Removed.
  • fast/media/008-expected.txt: Removed.
  • fast/media/008.html: Removed.
  • fast/media/009-expected.checksum: Removed.
  • fast/media/009-expected.png: Removed.
  • fast/media/009-expected.txt: Removed.
  • fast/media/009.html: Removed.
  • fast/media/010-expected.checksum: Removed.
  • fast/media/010-expected.png: Removed.
  • fast/media/010-expected.txt: Removed.
  • fast/media/010.html: Removed.
  • fast/media/011-expected.checksum: Removed.
  • fast/media/011-expected.png: Removed.
  • fast/media/011-expected.txt: Removed.
  • fast/media/011.html: Removed.
  • fast/media/012-expected.checksum: Removed.
  • fast/media/012-expected.png: Removed.
  • fast/media/012-expected.txt: Removed.
  • fast/media/012.html: Removed.
  • fast/media/013-expected.checksum: Removed.
  • fast/media/013-expected.png: Removed.
  • fast/media/013-expected.txt: Removed.
  • fast/media/013.html: Removed.
  • fast/media/014-expected.checksum: Removed.
  • fast/media/014-expected.png: Removed.
  • fast/media/014-expected.txt: Removed.
  • fast/media/014.html: Removed.
  • fast/media/015-expected.checksum: Removed.
  • fast/media/015-expected.png: Removed.
  • fast/media/015-expected.txt: Removed.
  • fast/media/015.html: Removed.
  • fast/media/016-expected.checksum: Removed.
  • fast/media/016-expected.png: Removed.
  • fast/media/016-expected.txt: Removed.
  • fast/media/016.html: Removed.
  • fast/media/017-expected.checksum: Removed.
  • fast/media/017-expected.png: Removed.
  • fast/media/017-expected.txt: Removed.
  • fast/media/017.html: Removed.
  • fast/media/018-expected.checksum: Removed.
  • fast/media/018-expected.png: Removed.
  • fast/media/018-expected.txt: Removed.
  • fast/media/018.html: Removed.
  • fast/media/019-expected.checksum: Removed.
  • fast/media/019-expected.png: Removed.
  • fast/media/019-expected.txt: Removed.
  • fast/media/019.html: Removed.
  • fast/media/020-expected.checksum: Removed.
  • fast/media/020-expected.png: Removed.
  • fast/media/020-expected.txt: Removed.
  • fast/media/020.html: Removed.
  • fast/media/021-expected.checksum: Removed.
  • fast/media/021-expected.png: Removed.
  • fast/media/021-expected.txt: Removed.
  • fast/media/021.html: Removed.
  • fast/media/022-expected.checksum: Removed.
  • fast/media/022-expected.png: Removed.
  • fast/media/022-expected.txt: Removed.
  • fast/media/022.html: Removed.
  • fast/media/023-expected.checksum: Removed.
  • fast/media/023-expected.png: Removed.
  • fast/media/023-expected.txt: Removed.
  • fast/media/023.html: Removed.
  • fast/media/024-expected.checksum: Removed.
  • fast/media/024-expected.png: Removed.
  • fast/media/024-expected.txt: Removed.
  • fast/media/024.html: Removed.
  • fast/media/025-expected.checksum: Removed.
  • fast/media/025-expected.png: Removed.
  • fast/media/025-expected.txt: Removed.
  • fast/media/025.html: Removed.
  • fast/media/026-expected.checksum: Removed.
  • fast/media/026-expected.png: Removed.
  • fast/media/026.html: Removed.
  • fast/media/import-p-green.css: Removed.

WebCore:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Removed.
  • css/css_mediaqueryeval.h: Removed.
  • css/css_mediaqueryimpl.cpp: Removed.
  • css/css_mediaqueryimpl.h: Removed.
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::contains): (MediaListImpl::deleteMedium): (MediaListImpl::mediaText): (MediaListImpl::setMediaText):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::item): (DOM::MediaListImpl::appendMedium):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Removed.
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Removed.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm:
5:48 PM Changeset in webkit [12566] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): javaScriptRootObjecTypeCounts -> javaScriptRootObjectTypeCounts
5:43 PM Changeset in webkit [12565] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • fast/js/for-in-var-scope.html: Added.
  • fast/js/resources/for-in-var-scope.js: Added.
  • fast/js/for-in-var-scope-expected.txt: Added.
5:43 PM Changeset in webkit [12564] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Test: fast/js/for-in-var-scope.html

  • kjs/nodes.cpp: (valueForReadModifyAssignment): Use ALWAYS_INLINE macro. (ForInNode::execute): Break out of the scope chain loop once we find and set the loop variable. We don't want to set multiple loop variables. (ForInNode::processVarDecls): Process the declaration of the loop variable.
  • other cleanup
  • kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
  • kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h instead of defining it here a second time.
5:09 PM Changeset in webkit [12563] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Oops, rolled out part that wasn't supposed to be here.

5:07 PM Changeset in webkit [12562] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result due to revised fix for <ol> number
  • fast/lists/olstart-expected.txt: Updated.
5:03 PM Changeset in webkit [12561] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Add a compatibilty hack for people with old Configuration files that say Development or Deployment in them.
4:49 PM Changeset in webkit [12560] by darin
  • 4 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • fixed regressions caused by fix for bug 5776 earlier today
  • rendering/render_list.h: Remove m_value from RenderListMarker, add it to RenderListItem. A few other tweaks, including getting rid of "friend" relationship.
  • rendering/render_list.cpp: (RenderListItem::RenderListItem): Initialize m_value. (RenderListItem::setStyle): Restore old behavior of making no marker for LNONE case. (RenderListItem::calcValue): Work on m_value, not m_marker->m_value. (RenderListItem::resetValue): Reset m_value, even if there's no marker. (RenderListMarker::RenderListMarker): Remove code to set up m_value. (RenderListMarker::calcMinMaxWidth): Get marker value from list item.
  • rendering/RenderContainer.cpp: (updateListMarkerNumbers): Call resetValue by its new name.
3:29 PM Changeset in webkit [12559] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Hyatt.



  • kjs/collector.cpp: (KJS::Collector::numProtectedObjects): renamed from numReferencedObjects (KJS::typeName): (KJS::Collector::rootObjectTypeCounts): renamed from rootObjectClasses, use HashSet
  • kjs/collector.h: (KJS::Collector::isOutOfMemory): Renamed from outOfMemory.
  • kjs/nodes.cpp:

WebCore:

Reviewed by Hyatt.

  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript protectedObjectCount]): Renamed from referencedObjectCounts (+[WebCoreJavaScript rootObjectTypeCounts]): Renamed from rootObjectClasses, changed from NSSet to NSCountedSet.

WebKit:

Reviewed by Hyatt.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptProtectedObjectsCount]): new (+[WebCoreStatistics javaScriptRootObjecTypeCounts]): new (+[WebCoreStatistics javaScriptRootObjectClasses]): deprecated (+[WebCoreStatistics javaScriptReferencedObjectsCount]): deprecated (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): Just return 0. Deprecated.
2:59 PM Changeset in webkit [12558] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj: reordered slightly.
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame): Don't take isObject parameter, just check tag name
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::prepareSubmit): remove obsolete hasOnlyLocalReferences check
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): remove obsolete hasOnlyLocalReferences check
  • loader/DocLoader.cpp: (khtml::DocLoader::requestImage): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestStyleSheet): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestScript): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestXSLStyleSheet): remove obsolete hasOnlyLocalReferences check
  • page/Frame.cpp: (WebCore::Frame::requestFrame): refactored and simplified (WebCore::Frame::requestObject): ditto (WebCore::Frame::shouldUsePlugin): ditto (WebCore::Frame::loadPlugin): ditto (WebCore::Frame::loadSubframe): ditto (WebCore::Frame::frameNames): remove obsolete m_bPreloaded check (WebCore::Frame::frames): ditto (WebCore::Frame::connectChild): check isFrame, not child type (WebCore::Frame::disconnectChild): ditto (WebCore::Frame::handleFallbackContent): greatly simplify using onwerElement (WebCore::Frame::updateBaseURLForEmptyDocument): use ownerElement, notChildFrame (WebCore::Frame::onlyLocalReferences): removed (WebCore::Frame::setOnlyLocalReferences): removed
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame::ChildFrame): remove most fields.
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Remove redundant setting of base URL for child document of iframe, Frame itself takes care of this already
10:51 AM Changeset in webkit [12557] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/make-js-test-wrappers: Don't create a wrapper if there's a disabled wrapper already in the directory.
  • Scripts/svn-apply: Handle additions and deletions properly -- I've been noticing these haven't been working at all.
  • Scripts/svn-unapply: Ditto.
10:30 AM Changeset in webkit [12556] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed reviewer name.

8:42 AM Changeset in webkit [12555] by darin
  • 1 edit in trunk/WebCore/khtml/html/html_listimpl.cpp

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly
Note: See TracTimeline for information about the timeline view.