⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 8, 2006:

11:59 PM Changeset in webkit [12713] by eseidel
  • 2 edits
    2 adds in trunk/WebKitTools

2006-02-08 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Adding new script for splitting multi-class files.
Also adding supporting perl module with space removing heuristics.

  • Scripts/SpacingHeuristics.pm: Added.
  • Scripts/build-drawtest: updated copyright header
  • Scripts/split-class: Added.
11:50 PM Changeset in webkit [12712] by thatcher
  • 3 edits
    7 adds in trunk

Test: fast/block/positioning/window-height-change.html

Reviewed by Hyatt.


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Always relayout positioned children of the root, since their positions may depend on the viewport's height which may have changed.
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): Ditto.
11:08 PM Changeset in webkit [12711] by justing
  • 180 edits in trunk/LayoutTests/editing
11:06 PM Changeset in webkit [12710] by justing
  • 165 edits in trunk/LayoutTests/editing/pasteboard
11:05 PM Changeset in webkit [12709] by justing
  • 227 edits in trunk/LayoutTests/editing
11:04 PM Changeset in webkit [12708] by justing
  • 342 edits in trunk/LayoutTests/editing
11:02 PM Changeset in webkit [12707] by justing
  • 5 edits in trunk/LayoutTests/fast/overflow
11:01 PM Changeset in webkit [12706] by justing
  • 1 edit in trunk/LayoutTests/fast/events/div-focus-expected.txt
11:00 PM Changeset in webkit [12705] by justing
  • 5 edits
    4 adds in trunk/LayoutTests/fast/dom
10:56 PM Changeset in webkit [12704] by justing
  • 3 edits in trunk/LayoutTests/fast/forms
10:56 PM Changeset in webkit [12703] by justing
  • 2 edits in trunk/LayoutTests/fast/selectors
10:55 PM Changeset in webkit [12702] by justing
  • 15 edits in trunk/LayoutTests/fast/text
10:54 PM Changeset in webkit [12701] by justing
  • 158 edits
    8 adds in trunk/LayoutTests/editing/selection
10:53 PM Changeset in webkit [12700] by mjs
  • 1 edit
    1 add in trunk/LayoutTests

Add missing file from earlier added svg test.

  • svg/custom/resources/link-target.html: Added.
10:45 PM Changeset in webkit [12699] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Add reviewer to an old check-in (remove forbidden OOPS).

10:43 PM Changeset in webkit [12698] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

OK, OOPS-prevention is working now.

10:39 PM Changeset in webkit [12697] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add libjpeg to the Win32 project.

10:38 PM Changeset in webkit [12696] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by thatcher


Changes to test fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowHasFocus:]): (-[LayoutTestController setDisplaysWithFocusAttributes:]):
10:37 PM Changeset in webkit [12695] by hyatt
  • 42 adds in trunk/WebCore/platform/image-decoders/jpeg

Add libjpeg to the tree.

10:34 PM Changeset in webkit [12694] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Can't the damn pre-commit work!

10:33 PM Changeset in webkit [12693] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

I should not be able to check this change in because it has OOPS in a ChangeLog file.

10:33 PM Changeset in webkit [12692] by hyatt
  • 4 edits in trunk/WebCore

Tiling of images on Win32 is supported now.

10:31 PM Changeset in webkit [12691] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Since there's OOPS in ChangeLog this should fail.

10:27 PM Changeset in webkit [12690] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Testing new OOPS pre-commit action.

10:20 PM Changeset in webkit [12689] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added mention of test for the last check-in.

10:16 PM Changeset in webkit [12688] by darin
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed and tweaked by Darin.

  • fast/dom/Element: Added.
  • fast/dom/Element/setAttribute-with-colon.html: Added.
  • fast/dom/Element/setAttribute-with-colon-expected.txt: Added.
10:16 PM Changeset in webkit [12687] by darin
  • 3 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • khtml/xml/dom_elementimpl.h: (ElementImpl::setAttribute): Removed body
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute): Changed code so that attribute is not parsed into prefix and local name.
9:51 PM Changeset in webkit [12686] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Fix win32 build bustage. Added libjpeg prematurely to the project.

9:25 PM Changeset in webkit [12685] by justing
  • 2 edits in trunk/WebKitTools

Reviewed by thatcher


Changes to test fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowHasFocus:]): (-[LayoutTestController setDisplaysWithFocusAttributes:]):
9:23 PM Changeset in webkit [12684] by justing
  • 4 edits in trunk/WebKit

Original patch by Graham Dennis, reviewed by me:


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate


Changes made by me, reviewed by thatcher:


Made _setWindowHasFocus: and _setDisplaysWithFocusAttributes: into private SPI to allow
for the testing of window.onFocus, window.onBlur, caret and focus halo painting, and
the focusing of content editable regions that happens as side effect of setting a selection,
but only if the window has focus (7128).

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didBeginEditing]): (-[WebFrameBridge didEndEditing]):
  • WebView/WebHTMLView.m: (-[WebHTMLView updateFocusState]): (-[WebHTMLView _setWindowHasFocus:]): (-[WebHTMLView _setDisplaysWithFocusAttributes:]):
  • WebView/WebHTMLViewPrivate.h:
9:18 PM Changeset in webkit [12683] by justing
  • 8 edits in trunk/WebCore

Original patch by Graham Dennis, reviewed by me
Changes made by me, reviewed by thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::didBeginEditing): (WebCore::MacFrame::didEndEditing):
  • bridge/mac/WebCoreFrameBridge.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::didBeginEditing): (WebCore::DocumentImpl::didEndEditing): (WebCore::DocumentImpl::setFocusNode):
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::focus):
  • page/Frame.h: (WebCore::Frame::didBeginEditing): (WebCore::Frame::didEndEditing):
8:44 PM Changeset in webkit [12682] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/positioning/relayout-on-position-change-expected.checksum: Added.
  • fast/block/positioning/relayout-on-position-change-expected.png: Added.
  • fast/block/positioning/relayout-on-position-change-expected.txt: Added.
  • fast/block/positioning/relayout-on-position-change.html: Added.
8:42 PM Changeset in webkit [12681] by darin
  • 2 edits in trunk/WebCore

Test: fast/block/positioning/relayout-on-position-change.html

Reviewed by Hyatt.

  • rendering/render_object.cpp: (WebCore::RenderObject::setStyle): The second call to setNeedsLayoutAndMinMaxRecalc did not mark containing blocks for relayout based on the new position value since the object itself was already marked as needing layout. Changed the first call to only mark the containing blocks (based on the old position value) and not the object itself.
8:09 PM Changeset in webkit [12680] by darin
  • 2 edits in trunk/WebKitSite

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4914
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4282

8:05 PM Changeset in webkit [12679] by darin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebPDFRepresentation.m: (+[WebPDFRepresentation postScriptMIMETypes]): Added. (+[WebPDFRepresentation supportedMIMETypes]): Include PostScript MIME types. (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Added. (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Handle PostScript conversion using new convertPostScriptDataSourceToPDF method.
7:50 PM Changeset in webkit [12678] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests
  • added SVG path hit testing test
  • svg/custom/hit-test-path-expected.checksum: Added.
  • svg/custom/hit-test-path-expected.png: Added.
  • svg/custom/hit-test-path-expected.txt: Added.
  • svg/custom/hit-test-path.svg: Added.
7:02 PM Changeset in webkit [12677] by mjs
  • 14 edits
    2 moves
    1 delete in trunk/WebCore

Reviewed by Eric.

RenderPath refactoring:


  • Rename the files to RenderPath
  • Push the portable code from KCanvasItemQuartz down to RenderPath
  • Move most of the unportable code from KCanvasItemQuartz to KCanvasPathQuartz


The only thing left in KCanvasItemQuartz is marker support. That should be factored to separate
iterating the path elements (KCanvasPathQuartz needs to provide that) and drawing the markers
(which should be done in portable code).

  • ForwardingHeaders/kcanvas/RenderPath.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasItem.cpp: Removed.
  • kcanvas/KCanvasItem.h: Removed.
  • kcanvas/KCanvasPath.h:
  • kcanvas/RenderPath.cpp: Added. (RenderPath::mapAbsolutePointToLocal): (RenderPath::fillContains): (RenderPath::strokeContains): (RenderPath::strokeBBox): (RenderPath::relativeBBox): (RenderPath::setPath): (RenderPath::layout): (RenderPath::getAbsoluteRepaintRect): (RenderPath::requiresLayer): (RenderPath::lineHeight): (RenderPath::baselinePosition): (RenderPath::paint): (RenderPath::nodeAtPoint):
  • kcanvas/RenderPath.h: Added.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasPathQuartz.h:
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: (KCanvasPathQuartz::boundingBox): (scratchContext): (KCanvasPathQuartz::strokeBoundingBox): (pathContainsPoint): (KCanvasPathQuartz::containsPoint): (KCanvasPathQuartz::strokeContainsPoint):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createItem):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::updateCanvasItem): (SVGStyledElementImpl::pushAttributeContext):
  • ksvg2/svg/SVGStyledLocatableElementImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
6:32 PM Changeset in webkit [12676] by adele
  • 2 edits in trunk/WebCore

Fix broken layout tests.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): iterator is null, so we have to reset it to the first node in the chain.
5:41 PM Changeset in webkit [12675] by adele
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)
  • fast/events/window-events-bubble-expected.txt: Added.
  • fast/events/window-events-bubble.html: Added.
  • fast/events/window-events-bubble2-expected.txt: Added.
  • fast/events/window-events-bubble2.html: Added.
  • fast/events/window-events-capture-expected.txt: Added.
  • fast/events/window-events-capture.html: Added.

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)

Tests:

  • fast/events/window-events-bubble.html
  • fast/events/window-events-bubble2.html
  • fast/events/window-events-capture.html
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
  • khtml/xml/DocumentImpl.h: Added handleWindowEvent.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.
5:35 PM Changeset in webkit [12674] by thatcher
  • 1 edit in tags/WebCore-521.6.3/WebCore/Info.plist

Versioning.

5:32 PM Changeset in webkit [12673] by thatcher
  • 1 copy in tags/WebCore-521.6.3/WebCore

New tag.

5:32 PM Changeset in webkit [12672] by thatcher
  • 1 add in tags/WebCore-521.6.3

New tag.

5:30 PM Changeset in webkit [12671] by thatcher
  • 2 edits in tags/Safari-521.6.2/WebCore/css

Build fix when using sh 3.1

5:27 PM Changeset in webkit [12670] by thatcher
  • 2 edits in trunk/WebCore/css

Build fix to not use echo -e. This failed to build with sh 3.1.

3:49 PM Changeset in webkit [12669] by hyatt
  • 8 edits in trunk/WebCore/WebCore.vcproj/Image Viewer

Undo my checking of red painting that I landed by accident.

2:46 PM Changeset in webkit [12668] by hyatt
  • 7 edits in trunk/WebCore

Improved Cairo image rendering by only building the surface from the portion of the buffer that has been decoded so far.

2:08 PM Changeset in webkit [12667] by thatcher
  • 1 delete in Safari-417.9

Removing a mistake copy.

2:06 PM Changeset in webkit [12666] by thatcher
  • 8 copies in tags/Safari-417.9

Tagging.

1:54 PM Changeset in webkit [12665] by thatcher
  • 8 copies in Safari-417.9

Tagging.

1:47 PM Changeset in webkit [12664] by thatcher
  • 3 edits in branches/Safari-2-0-branch

Versioning the CHangeLogs.

1:44 PM Changeset in webkit [12663] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/JavaScriptCore-3.3.exp

Adding the NPN_DeallocateObject symbol.

11:17 AM Changeset in webkit [12662] by thatcher
  • 3 edits in branches/Safari-2-0-branch

Versioning

3:53 AM Changeset in webkit [12661] by andersca
  • 3 edits
    2 moves in trunk/WebCore

2006-02-08 Anders Carlsson <​andersca@mac.com>

Rubber stamped by Maciej.

Move JSCore.cpp to bindings/js/JSDOMCore.cpp and
rename JSEvents.cpp to JSDOMEvents.cpp


  • JSCore.cpp: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMCore.cpp: Added.
  • bindings/js/JSDOMEvents.cpp: Added.
  • bindings/js/JSEvents.cpp: Removed.
3:48 AM Changeset in webkit [12660] by andersca
  • 7 edits
    1 add in trunk/WebCore

2006-02-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • JSCore.cpp: Add JSElement.cpp.


  • bindings/scripts/CodeGeneratorJS.pm: Handle a bunch of new types.


  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::getValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): Remove code that is autogenerated now.


(KJS::getDOMNode):
Create a JSElement instead of a DOMElement.


(KJS::getDOMNodeList):
Take a PassRefPtr like some of the other get methods.


  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Remove the now unused enums.


  • khtml/ecma/kjs_html.cpp: (KJS::): (KJS::HTMLElement::HTMLElement): (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElement::toString): (KJS::KJS::HTMLElement::put):
  • khtml/ecma/kjs_html.h: Have HTMLElement inherit from JSElement.
  • khtml/xml/Element.idl: Added.
3:46 AM Changeset in webkit [12659] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

I jumped the gun adding QString.cpp to the Win32 build. Still has some compile issues to work out. Removing it for now.

3:36 AM Changeset in webkit [12658] by hyatt
  • 1 delete in trunk/WebCore/ForwardingHeaders/qstring.h

Remove qstring.h forwarding header.

3:33 AM Changeset in webkit [12657] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Get the new string files added, but Win32 is still busted from the infinite include of qstring.h

2:50 AM Changeset in webkit [12656] by hyatt
  • 6 edits in trunk/WebCore

Land complete PNG support for Win32 (yay).

Feb 7, 2006:

9:31 PM Changeset in webkit [12655] by mjs
  • 57 edits
    2 moves
    1 add in trunk/WebCore

Rubber stamped by Hyatt.

  • move kwq/KWQString.mm to platform/QString.cpp, split out nonportable parts, speculative port of one remaining nonportable bit to windows.
  • ForwardingHeaders/qstring.h:
  • WebCore+SVG/KDOMSettings.h:
  • WebCore+SVG/kdom.h:
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.h:
  • css/cssstyleselector.cpp:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.h:
  • khtml/ecma/kjs_window.h:
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_text.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/FormDataList.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/misc/decoder.h:
  • khtml/misc/formdata.h:
  • khtml/xbl/xbl_protohandler.cpp:
  • khtml/xml/dom_position.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/svgpathparser.cpp:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQBuffer.h:
  • kwq/KWQEvent.h:
  • kwq/KWQFont.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKDebug.h:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKLocale.mm:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQKURL.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQRegExp.h:
  • kwq/KWQRenderTreeDebug.h:
  • kwq/KWQString.h: Removed.
  • kwq/KWQString.mm: Removed.
  • kwq/KWQStringList.h:
  • kwq/KWQTextCodec.h:
  • kwq/KWQTextStream.h:
  • kwq/KWQTextUtilities.mm:
  • kwq/WebCoreScriptDebugger.mm:
  • loader/Cache.h:
  • platform/Color.cpp:
  • platform/Color.h:
  • platform/QString.cpp: Added. (allocateHandle): (KWQStringData::KWQStringData): (QString::QString): (QString::insert): (QString::detach): (QString::remove): (QString::setLength): (QString::fill): (initializeHandleNodeBlock): (allocateNode): (freeHandle):
  • platform/QString.h: Added.
  • platform/SegmentedString.h:
  • platform/StringImpl.h:
  • platform/mac/Image.mm:
  • platform/mac/QString.mm: Added. (QString::setBufferFromCFString): (QString::fromCFString): (QString::fromNSString): (QString::getNSString): (QString::utf8): (QString::fromUtf8):
  • rendering/bidi.h:
  • rendering/break_lines.cpp:
7:05 PM Changeset in webkit [12654] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Update page directory in Win32 project to match what's there now.

7:01 PM Changeset in webkit [12653] by mjs
  • 12 edits
    1 delete in trunk/WebCore

Reviewed by Adele.

  • remove all remains of old-style frame tree, ChildFrame, ObjectContents and FrameList are all gone
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::indexGetter): (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::stopLoading): (WebCore::Frame::clear): (WebCore::Frame::stopAnimations): (WebCore::Frame::checkCompleted): (WebCore::Frame::checkEmitLoadEvent): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::findFrame): (WebCore::Frame::frameExists): (WebCore::Frame::setZoomFactor): (WebCore::Frame::frameNames): (WebCore::Frame::frames): (WebCore::Frame::childFrameNamed): (WebCore::Frame::slotPartRemoved): (WebCore::Frame::connectChild): (WebCore::Frame::disconnectChild): (WebCore::Frame::canCachePage): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::treeNode): (WebCore::Frame::frameDetached):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
  • page/ObjectContents.h: Removed.
  • page/Plugin.h: (WebCore::Plugin::view):
6:39 PM Changeset in webkit [12652] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

  • test for <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid
  • fast/encoding/decoder-allow-null-chars.html
  • fast/encoding/decoder-allow-null-chars-expected.txt

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid

Test: fast/encoding/decoder-allow-null-chars.html

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::convertLatin1): Removed stripping of null characters (unwanted): ditto.
4:46 PM Changeset in webkit [12651] by hyatt
  • 3 edits
    2 adds in trunk/WebCore

Land the skeleton of a PNG decoder for Win32.

4:14 PM Changeset in webkit [12650] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add bindings/js/JSEvents.cpp to the win32 build.

3:08 PM Changeset in webkit [12649] by eseidel
  • 6 edits
    1 delete in trunk/WebCore

2006-02-07 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Removed ImageSubset, making ImageViewer link directly to WebCore.

  • Viewer.vcproj:
  • WebCore.vcproj/ImageSubset: Removed.
  • WebCore.vcproj/ImageSubset/ImageSubset.vcproj: Removed.
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
1:36 PM Changeset in webkit [12648] by hyatt
  • 1 edit
    2 adds in trunk/WebCore/WebCore.vcproj

Add Image Subset of WebCore as a project to the win32 build for the Image Viewer app to link against.

1:32 PM Changeset in webkit [12647] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by darin.

  • Fixed <rdar://problem/4425269> REGRESSION: wrong size pop-up when downloading attachment at webmail.mac.com (6882)

The bug was that the feature string parser didn't always initialize the
*Set variables, so WebCore assumed a height was set when it wasn't,
and used a garbage height variable.

While there, I fixed two other bugs: (1) The parser wasn't chewing up
as many characters as I thought it was. (Chewing up extra characters
is necessary to match Win IE.) (2) We considered \t and \f to be
whitespace, but Win IE doesn't.

  • manual-tests/window-open-features-parsing.html: Added these cases, fixed up comments.
  • bridge/BrowserExtension.h: Cleaned up declaration order a bit.
  • khtml/ecma/kjs_window.cpp: (KJS::isSeparator): New function, tells you if a character is a separator (KJS::parseWindowFeatures): Always initialize *Set to false. Drive parsing based on invalid characters ('separators') rather than valid ones, to match Win IE.
1:27 PM Changeset in webkit [12646] by darin
  • 8 edits in trunk/WebKitSite

Set more MIME types.

1:17 PM Changeset in webkit [12645] by darin
  • 81 edits in trunk/WebKitSite

Set a bunch of MIME types.

9:01 AM Changeset in webkit [12644] by ap
  • 10 edits
    9 adds in trunk

2006-02-07 Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Timothy.

Convert JavaScript objects to appropriate AppleScript types, instead of only strings
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7012

WebKit:

  • WebView/WebView.m: (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added.
  • WebView/WebViewPrivate.h:

WebCore:

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Added.

WebKitTools:

  • DumpRenderTree/AppleScriptController.h: Added.
  • DumpRenderTree/AppleScriptController.m: Added.
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

LayoutTests:

  • fast/AppleScript: Added.
  • fast/AppleScript/001-expected.txt: Added.
  • fast/AppleScript/001.html: Added.
  • fast/AppleScript/array-expected.txt: Added.
  • fast/AppleScript/array.html: Added.
  • fast/AppleScript/date-expected.txt: Added.
  • fast/AppleScript/date.html: Added.
3:31 AM Changeset in webkit [12643] by hyatt
  • 47 adds in trunk/WebCore/platform/image-decoders

Add libpng and the zlib supporting library in preparation for iplementing PNG decoding.

3:07 AM Changeset in webkit [12642] by hyatt
  • 3 edits
    5 moves in trunk/WebCore

FInal image renaming for Win32 gif stuff.

2:47 AM Changeset in webkit [12641] by hyatt
  • 6 edits
    3 moves
    1 delete in trunk/WebCore

Rename ImageDecoder to ImageSource.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Image.cpp: (WebCore::Image::cacheFrame): (WebCore::Image::size): (WebCore::Image::setNativeData): (WebCore::Image::frameCount): (WebCore::Image::isSizeAvailable):
  • platform/Image.h:
  • platform/ImageDecoder.h: Removed.
  • platform/ImageSource.h: Added.
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawInRect):
  • platform/cairo/ImageDecoderCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Added. (WebCore::createDecoderPlugin): (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex):
  • platform/mac/Image.mm: (WebCore::Image::drawInRect):
  • platform/mac/ImageData.mm: Removed.
  • platform/mac/ImageDecoder.cpp: Removed.
  • platform/mac/ImageSource.cpp: Added. (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex):
2:17 AM Changeset in webkit [12640] by hyatt
  • 22 edits
    2 deletes in trunk/WebCore

Combine ImageData and Image (the result ends up in Image).

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::fileWrapperForElement):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor): (WebCore::QCursor::QCursor):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • loader/CachedImage.cpp: (WebCore::CachedImage::image):
  • loader/CachedImage.h:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::invalidateData): (WebCore::Image::cacheFrame): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::setData): (WebCore::Image::setNativeData): (WebCore::Image::frameCount): (WebCore::Image::isSizeAvailable): (WebCore::Image::frameAtIndex): (WebCore::Image::frameDurationAtIndex): (WebCore::Image::shouldAnimate): (WebCore::Image::startAnimation): (WebCore::Image::stopAnimation): (WebCore::Image::resetAnimation): (WebCore::Image::advanceAnimation): (WebCore::Image::rect):
  • platform/Image.h: (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::Image::currentFrame): (WebCore::Image::animationObserver): (WebCore::Image::setIsPDF):
  • platform/ImageData.cpp: Removed.
  • platform/ImageData.h: Removed.
  • platform/cairo/ImageCairo.cpp: (WebCore::FrameData::clear): (WebCore::Image::initNativeData): (WebCore::Image::destroyNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/Image.mm: (WebCore::FrameData::clear): (WebCore::Image::initNativeData): (WebCore::Image::destroyNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::checkForSolidColor): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::getNSImage): (WebCore::Image::getCGImageRef): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::nullImage):
  • rendering/render_image.h: (WebCore::RenderImage::image):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
1:29 AM Changeset in webkit [12639] by mjs
  • 6 edits in trunk/WebKitSite

Reviewed by Darin. Landed by Maciej.


  • blog/wp-content/themes/webkit/style.css:
  • index.html:
  • quality/bugwriting.html:
  • quality/reduction.html:
  • webkitdev.css:
1:21 AM Changeset in webkit [12638] by mjs
  • 18 edits
    2 adds
    2 deletes in trunk

LayoutTests:

Reviewed by Eric.


  • fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added.
  • fast/dom/HTMLObjectElement/object-as-frame.html: Added.


  • fast/events/event-targets-expected.checksum: Removed.
  • fast/events/event-targets-expected.png: Removed.
  • fast/events/event-targets-expected.txt:
  • fast/events/event-targets.html:

WebCore:

Reviewed by Eric.



  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): pass along renderer (WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge removeChild:]): don't mess with renderer (-[WebCoreFrameBridge init]): call new designated initializer (-[WebCoreFrameBridge initWithRenderer:]): new designated initializer (-[WebCoreFrameBridge dealloc]): don't mess with renderer (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge installInFrame:]): ditto
  • page/Frame.cpp: (WebCore::FrameList::find): get name from frame not ChildFrame (WebCore::Frame::init): take renderer parameter (WebCore::Frame::clear): clear m_plugins, not m_objects (WebCore::Frame::childBegin): updated comment (WebCore::Frame::stop): add check-completed for documentless case here (WebCore::Frame::checkCompleted): don't track separate completed flag in ChildFrame, use the sub Frame object's own (WebCore::Frame::checkEmitLoadEvent): ditto (WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame, instead pass them along (WebCore::Frame::requestObject): ditto above (WebCore::Frame::loadPlugin): expect renderer parameter (WebCore::Frame::loadSubframe): expect renderer and name parameters (WebCore::Frame::slotChildStarted): don't mess with ChildFrame (WebCore::Frame::slotChildCompleted): ditto (WebCore::Frame::childFrame): don't check m_objects (WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment (WebCore::Frame::frameNames): get name from frame (WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner renderer now (WebCore::Frame::ownerRenderer): added (WebCore::Frame::canCachePage): check m_plugins not m_objects
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame): Remove constructor, most fields. (WebCore::FramePrivate::FramePrivate): Pass ownerRenderer
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Make sure to pass name attr to requestObject.

WebKit:

Reviewed by Eric.


  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer. (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h:
Note: See TracTimeline for information about the timeline view.