⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 9, 2006:

10:42 PM Changeset in webkit [12728] by ggaren
  • 27 edits
    1 move
    2 adds in trunk/JavaScriptCore

Reviewed by mjs.

  • Fixed <rdar://problem/4343730> Should switch ConstantValues (null, undefined, true, false) from JS objects to immediate values similar to SimpleNumber

2.0% performance gain on my new super-accurate version of JS iBench.
(I promise to land a version of it soon.)

The gist of the change:
(1) The SimpleNumber class (simple_number.h) is now the JSImmediate
class (JSImmediate.h/.cpp), and it handles not only numbers but also
null, undefined, true, and false.
(2) JSImmediate provides convenience methods for the bit masking
necessary to encode and decode immediate values.
(3) ConstantValues, BooleanImp, NullImp, and UndefinedImp are gone.
(4) JSCell no longer implements functions like getBoolean, because
only a JSImmediate can be a boolean.
(5) JSImmediate no longer uses ALWAYS_INLINE because there's no need,
and ALWAYS_INLINE is a non-portable option of last resort.
(6) Type is now JSType, and it resides in its own file, JSType.h.
Since I was there, I did some header include sorting as part of this
change.

The rest pretty much explains itself.

  • JavaScriptCore.xcodeproj/project.pbxproj: Removed simple_number.h, added JSImmediate.h/.cpp.
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue):
  • bindings/c/c_instance.h:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]): Standardized calls to use getXXX instead of hand-rolling JSValue functionality.
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue):
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::type): (ObjcFallbackObjectImp::defaultValue):
  • bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h:
  • kjs/JSImmediate.h: Added. (KJS::JSImmediate::isImmediate): (KJS::JSImmediate::isNumber): (KJS::JSImmediate::isBoolean): (KJS::JSImmediate::isUndefinedOrNull): (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::toBoolean): (KJS::JSImmediate::trueImmediate): (KJS::JSImmediate::falseImmediate): (KJS::JSImmediate::NaNImmediate): (KJS::JSImmediate::undefinedImmediate): (KJS::JSImmediate::nullImmediate): (KJS::JSImmediate::tag): (KJS::JSImmediate::unTag): (KJS::JSImmediate::getTag): (KJS::JSImmediate::): (KJS::JSImmediate::isIEEE): (KJS::JSImmediate::is32bit): (KJS::JSImmediate::is64bit): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::zeroAsBits): (KJS::JSImmediate::oneAsBits):
  • kjs/JSLock.cpp: (KJS::JSLock::lock): Removed hack-o-rama to initialize ConstantValues.
  • kjs/JSType.h: Added.
  • kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::StringImp::toPrimitive): (KJS::NumberImp::toPrimitive): (KJS::NumberImp::toBoolean): (KJS::GetterSetterImp::toPrimitive):
  • kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
  • kjs/object.cpp: (KJS::JSObject::type): (KJS::tryGetAndCallProperty): Replaced "Are you one of the six things I'm looking for?" test with "Are you not the one thing I'm not looking for" test. (KJS::JSObject::defaultValue): (KJS::JSObject::toPrimitive):
  • kjs/object.h: (KJS::GetterSetterImp::type): (KJS::JSValue::isObject):
  • kjs/operations.cpp: (KJS::equal): (KJS::strictEqual): (KJS::add):
  • kjs/reference.cpp: (KJS::Reference::deleteValue):
  • kjs/simple_number.h: Removed.
  • kjs/string_object.cpp: (StringInstance::getOwnPropertySlot): fixed indentation
  • kjs/value.cpp: (KJS::JSValue::toObject): (KJS::jsNumberCell): New function to quarantine a PIC branch -- allows us to inline jsNumber without adding PIC branches to callers.
  • kjs/value.h: (KJS::jsUndefined): (KJS::jsNull): (KJS::jsNaN): (KJS::jsBoolean): (KJS::jsNumber): (KJS::JSValue::downcast): (KJS::JSValue::isUndefinedOrNull): (KJS::JSValue::isBoolean): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getBoolean): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): Replaced !JSImmediate::is() test with assertion, resulting in a slight performance gain. Callers should always check !marked() before calling mark(), so it's impossible to call mark on a JSImmediate. (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString):
5:30 PM Changeset in webkit [12727] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4153419> CrashTracer: 576 crashes in Safari at com.apple.WebKit: NPN_DestroyStream + 56

I never could reproduce this crasher, which seems to be caused by the Speed Download plugin. However,
I did find a way to make the affected code more bulletproof for those who are experiencing the crash.


  • Plugins/WebBaseNetscapePluginStream.h: Keep a WebBaseNetscapePluginView instead of the WebNetscapePluginPackage, since the plugin view could potentially be deallocated before the stream finishes loading.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream dealloc]): Assert that the plugin instance has been nulled out, since that's now part of the stream's teardown phase. Release pluginView instead of plugin. (-[WebBaseNetscapePluginStream setPluginPointer:]): Retain the plugin view instead of the plugin package, since the plugin view could be deallocated while the stream is running. This method now accepts a NULL argument so that we can easily clear out the pluginView backpointer (and other ivars derived from it). (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): ditto (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError]): Set the plugin instance to NULL, so that the pluginView backpointer is released. This method is called for every plugin view's stream when the plugin view is stopped/destroyed. (-[WebBaseNetscapePluginStream _deliverData]): Use pluginView instead of plugin.
5:20 PM Changeset in webkit [12726] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/4430614> RenderThemeMac crashes under GC
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize all the pointers. (WebCore::RenderThemeMac::setCheckboxCellState): Use KWQRetainNSRelease so we can retain a pointer to an ObjC object in a C++ class. (WebCore::RenderThemeMac::setRadioCellState): Ditto. (WebCore::RenderThemeMac::setButtonCellState): Ditto. (WebCore::RenderThemeMac::setTextFieldCellState): Ditto.
  • kwq/KWQResourceLoader.h: Remove unneeded forward declaration.
4:09 PM Changeset in webkit [12725] by darin
  • 33 edits in trunk/WebCore

Reviewed by Eric and Geoff.

  • changed basic DOM mutation calls to assert that "this" is not floating, then added more uses of RefPtr to prevent the assertion from firing (at least during my testing and layout tests)
  • removed use of PassRefPtr as the type of a local variable; after talking with Maciej and Eric, this type of use is now "deprecated"
  • bindings/js/JSDOMCore.cpp: Touched this file to get things to build.
  • bindings/objc/DOM.mm: (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange cloneRange]):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction):
  • khtml/editing/Selection.cpp: (WebCore::Selection::toRange):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
  • dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • dom/DocPtr.h: Removed uses of NULL and unused deprecated functions.
  • dom/dom2_rangeimpl.h:
  • dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::RangeImpl): (WebCore::RangeImpl::startContainer): (WebCore::RangeImpl::endContainer): (WebCore::RangeImpl::commonAncestorContainer): (WebCore::RangeImpl::setStart): (WebCore::RangeImpl::setEnd): (WebCore::RangeImpl::collapse): (WebCore::RangeImpl::compareBoundaryPoints): (WebCore::RangeImpl::boundaryPointsValid): (WebCore::RangeImpl::processContents): (WebCore::RangeImpl::extractContents): (WebCore::RangeImpl::cloneContents): (WebCore::RangeImpl::insertNode): (WebCore::RangeImpl::createContextualFragment): (WebCore::RangeImpl::detach): (WebCore::RangeImpl::cloneRange): (WebCore::RangeImpl::selectNodeContents): (WebCore::RangeImpl::surroundContents): (WebCore::RangeImpl::containedByReadOnly): (WebCore::RangeImpl::startPosition): (WebCore::RangeImpl::endPosition): (WebCore::RangeImpl::startNode): (WebCore::RangeImpl::editingStartPosition): (WebCore::rangeOfContents):
  • dom/dom_elementimpl.h:
  • dom/dom_elementimpl.cpp: (WebCore::AttrImpl::AttrImpl): (WebCore::AttrImpl::~AttrImpl): (WebCore::AttrImpl::setValue): (WebCore::AttrImpl::childTypeAllowed): (WebCore::AttrImpl::childrenChanged): (WebCore::ElementImpl::removeAttributeNode): (WebCore::NamedAttrMapImpl::clearAttributes): (WebCore::CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl): (WebCore::MappedAttributeImpl::clone):
  • dom/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode):
  • dom/dom_xmlimpl.cpp: (WebCore::EntityReferenceImpl::cloneNode): (WebCore::ProcessingInstructionImpl::ProcessingInstructionImpl): (WebCore::ProcessingInstructionImpl::checkStyleSheet): (WebCore::ProcessingInstructionImpl::setStyleSheet):
  • dom/dom_position.cpp:
  • khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::createBlockPlaceholderElement):
  • khtml/editing/delete_selection_command.cpp: (WebCore::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): (WebCore::nonBreakingSpaceString): (WebCore::createDefaultParagraphElement): (WebCore::createBreakElement): (WebCore::createTabSpanElement):
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::insertTab):
  • khtml/editing/markup.cpp: (khtml::createFragmentFromMarkup): (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText): (khtml::createFragmentFromNodeList):
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplaceSelectionCommand::doApply):
  • khtml/editing/visible_text.cpp: (khtml::CharacterIterator::range): (khtml::findPlainText):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer):
1:33 PM Changeset in webkit [12724] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Adding eol-style.

1:31 PM Changeset in webkit [12723] by thatcher
  • 1 copy
    1 add in trunk/WebKit

Rolling over the ChangeLog.

11:22 AM Changeset in webkit [12722] by ap
  • 3 edits in trunk/WebKitSite

Fixes by Mark Rowe and Joost de Valk. Reviewed by Darin. Landed by ap.



  • quality/reporting.html:
  • webkitdev.css: Added margin-bottom for li.
11:21 AM Changeset in webkit [12721] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4198378> Crash on a CFRelease when visiting ​http://www.akella.com/

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): The true source of this crash is that the URL string is sometimes not NULL-terminated, which is the Real Player plugin's fault. That has been filed as 4439591. However, we can be more bulletproof here by switching the URL string encoding from Windows Latin 1 to ISO Latin 1, so that any NULL-terminated string can be represented. (As Darin and I found out last night, Windows Latin 1 has "holes" in certain character ranges and thus cannot encode arbitrary C strings).
2:16 AM Changeset in webkit [12720] by mjs
  • 4 edits in trunk/WebCore

Reviewed and landed by Maciej.


Factor out common parts of Linear/Radial GradientQuartz
up into KRenderingPaintServerGradientQuartz.

Cleanup only, no layout tests needed or affected.

  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (KRenderingPaintServerGradientQuartz::draw): (KRenderingPaintServerGradientQuartz::setup): (KRenderingPaintServerGradientQuartz::renderPath): (KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerLinearGradientQuartz::renderPath): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::renderPath):
1:54 AM Changeset in webkit [12719] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • various Frame cleanup:


Make Frame-related classes Noncopyable.
Remove nearly all of Frame's friends.
Remove some unused stuff.
Remove unneeded class forward declarations from Frame.h

  • page/Frame.cpp:
  • page/Frame.h:
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
  • page/FrameView.cpp: (WebCore::FrameView::viewportMouseMoveEvent):
  • page/Page.h: (WebCore::Page::mainFrame):
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
1:36 AM Changeset in webkit [12718] by mjs
  • 2 edits
    14 moves
    1 add in trunk/WebKit

Rubber stamped by Anders.


  • Moved all the default delegate classes to their own directory.
  • DefaultDelegates: Added.
  • DefaultDelegates/WebDefaultContextMenuDelegate.h: Added.
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: Added.
  • DefaultDelegates/WebDefaultEditingDelegate.h: Added.
  • DefaultDelegates/WebDefaultEditingDelegate.m: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultPolicyDelegate.h: Added.
  • DefaultDelegates/WebDefaultPolicyDelegate.m: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.h: Added.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: Added.
  • DefaultDelegates/WebDefaultUIDelegate.h: Added.
  • DefaultDelegates/WebDefaultUIDelegate.m: Added.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDefaultContextMenuDelegate.h: Removed.
  • WebView/WebDefaultContextMenuDelegate.m: Removed.
  • WebView/WebDefaultEditingDelegate.h: Removed.
  • WebView/WebDefaultEditingDelegate.m: Removed.
  • WebView/WebDefaultFrameLoadDelegate.h: Removed.
  • WebView/WebDefaultFrameLoadDelegate.m: Removed.
  • WebView/WebDefaultPolicyDelegate.h: Removed.
  • WebView/WebDefaultPolicyDelegate.m: Removed.
  • WebView/WebDefaultResourceLoadDelegate.h: Removed.
  • WebView/WebDefaultResourceLoadDelegate.m: Removed.
  • WebView/WebDefaultScriptDebugDelegate.h: Removed.
  • WebView/WebDefaultScriptDebugDelegate.m: Removed.
  • WebView/WebDefaultUIDelegate.h: Removed.
  • WebView/WebDefaultUIDelegate.m: Removed.
1:09 AM Changeset in webkit [12717] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Minor image cleanup to the decoders. Doesn't affect Mac.

12:46 AM Changeset in webkit [12716] by hyatt
  • 2 edits in trunk/WebCore/WebCore.vcproj/WebCore

Update Win32 project to account for the khtml/xml to dom move.

12:26 AM Changeset in webkit [12715] by mjs
  • 50 edits
    1 move in trunk/WebCore

Rubber-stamped by Hyatt.


  • moved khtml/xml to dom
  • dom: moved from khtml/xml
  • WebCore.xcodeproj/project.pbxproj: Updated for new file locations.
  • WebCore+SVG/KDOMHeaders.h: Updated for new header locations.
  • dom/dom2_rangeimpl.cpp: ditto
  • dom/dom2_traversalimpl.cpp: ditto
  • dom/dom_textimpl.cpp: ditto
  • dom/dom_xmlimpl.cpp: ditto
  • khtml/dom/dom2_events.cpp: ditto
  • khtml/ecma/kjs_binding.cpp: ditto
  • khtml/ecma/kjs_dom.cpp: ditto
  • khtml/ecma/kjs_events.cpp: ditto
  • khtml/ecma/kjs_html.cpp: ditto
  • khtml/ecma/kjs_range.cpp: ditto
  • khtml/ecma/kjs_views.cpp: ditto
  • khtml/editing/Selection.cpp: ditto
  • khtml/editing/SelectionController.cpp: ditto
  • khtml/editing/delete_from_text_node_command.cpp: ditto
  • khtml/editing/edit_command.cpp: ditto
  • khtml/editing/insert_into_text_node_command.cpp: ditto
  • khtml/editing/insert_line_break_command.cpp: ditto
  • khtml/editing/insert_paragraph_separator_command.cpp: ditto
  • khtml/editing/insert_text_command.cpp: ditto
  • khtml/editing/join_text_nodes_command.cpp: ditto
  • khtml/editing/markup.cpp: ditto
  • khtml/editing/merge_identical_elements_command.cpp: ditto
  • khtml/editing/rebalance_whitespace_command.cpp: ditto
  • khtml/editing/remove_node_attribute_command.cpp: ditto
  • khtml/editing/set_node_attribute_command.cpp: ditto
  • khtml/editing/split_element_command.cpp: ditto
  • khtml/editing/split_text_node_command.cpp: ditto
  • khtml/editing/split_text_node_containing_element.cpp: ditto
  • khtml/editing/visible_position.cpp: ditto
  • khtml/editing/visible_position.h: ditto
  • khtml/editing/visible_text.cpp: ditto
  • khtml/editing/visible_text.h: ditto
  • khtml/editing/visible_units.cpp: ditto
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: ditto
  • khtml/html/HTMLElementImpl.h: ditto
  • khtml/html/html_documentimpl.cpp: ditto
  • khtml/html/html_headimpl.cpp: ditto
  • khtml/xbl/xbl_binding_manager.cpp: ditto
  • khtml/xbl/xbl_tokenizer.cpp: ditto
  • khtml/xbl/xbl_tokenizer.h: ditto
  • ksvg2/svg/SVGAElementImpl.cpp: ditto
  • rendering/InlineTextBox.cpp: ditto
  • rendering/RenderContainer.cpp: ditto
  • rendering/RenderText.h: ditto
  • rendering/RenderTextField.cpp: ditto
  • rendering/render_frames.cpp: ditto
  • rendering/render_layer.cpp: ditto
12:03 AM Changeset in webkit [12714] by eseidel
  • 2 edits
    1 move in trunk/WebKitTools

2006-02-09 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Renamed split-class to split-file-by-class.

  • Scripts/build-webkit: Updated copyright.
  • Scripts/split-class: Removed.
  • Scripts/split-file-by-class: Added.

Feb 8, 2006:

11:59 PM Changeset in webkit [12713] by eseidel
  • 2 edits
    2 adds in trunk/WebKitTools

2006-02-08 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Adding new script for splitting multi-class files.
Also adding supporting perl module with space removing heuristics.

  • Scripts/SpacingHeuristics.pm: Added.
  • Scripts/build-drawtest: updated copyright header
  • Scripts/split-class: Added.
11:50 PM Changeset in webkit [12712] by thatcher
  • 3 edits
    7 adds in trunk

Test: fast/block/positioning/window-height-change.html

Reviewed by Hyatt.


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Always relayout positioned children of the root, since their positions may depend on the viewport's height which may have changed.
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutBlock): Ditto.
11:08 PM Changeset in webkit [12711] by justing
  • 180 edits in trunk/LayoutTests/editing
11:06 PM Changeset in webkit [12710] by justing
  • 165 edits in trunk/LayoutTests/editing/pasteboard
11:05 PM Changeset in webkit [12709] by justing
  • 227 edits in trunk/LayoutTests/editing
11:04 PM Changeset in webkit [12708] by justing
  • 342 edits in trunk/LayoutTests/editing
11:02 PM Changeset in webkit [12707] by justing
  • 5 edits in trunk/LayoutTests/fast/overflow
11:01 PM Changeset in webkit [12706] by justing
  • 1 edit in trunk/LayoutTests/fast/events/div-focus-expected.txt
11:00 PM Changeset in webkit [12705] by justing
  • 5 edits
    4 adds in trunk/LayoutTests/fast/dom
10:56 PM Changeset in webkit [12704] by justing
  • 3 edits in trunk/LayoutTests/fast/forms
10:56 PM Changeset in webkit [12703] by justing
  • 2 edits in trunk/LayoutTests/fast/selectors
10:55 PM Changeset in webkit [12702] by justing
  • 15 edits in trunk/LayoutTests/fast/text
10:54 PM Changeset in webkit [12701] by justing
  • 158 edits
    8 adds in trunk/LayoutTests/editing/selection
10:53 PM Changeset in webkit [12700] by mjs
  • 1 edit
    1 add in trunk/LayoutTests

Add missing file from earlier added svg test.

  • svg/custom/resources/link-target.html: Added.
10:45 PM Changeset in webkit [12699] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Add reviewer to an old check-in (remove forbidden OOPS).

10:43 PM Changeset in webkit [12698] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

OK, OOPS-prevention is working now.

10:39 PM Changeset in webkit [12697] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add libjpeg to the Win32 project.

10:38 PM Changeset in webkit [12696] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by thatcher


Changes to test fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowHasFocus:]): (-[LayoutTestController setDisplaysWithFocusAttributes:]):
10:37 PM Changeset in webkit [12695] by hyatt
  • 42 adds in trunk/WebCore/platform/image-decoders/jpeg

Add libjpeg to the tree.

10:34 PM Changeset in webkit [12694] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

Can't the damn pre-commit work!

10:33 PM Changeset in webkit [12693] by darin
  • 1 edit in trunk/WebKitTools/ChangeLog

I should not be able to check this change in because it has OOPS in a ChangeLog file.

10:33 PM Changeset in webkit [12692] by hyatt
  • 4 edits in trunk/WebCore

Tiling of images on Win32 is supported now.

10:31 PM Changeset in webkit [12691] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Since there's OOPS in ChangeLog this should fail.

10:27 PM Changeset in webkit [12690] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Testing new OOPS pre-commit action.

10:20 PM Changeset in webkit [12689] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Added mention of test for the last check-in.

10:16 PM Changeset in webkit [12688] by darin
  • 1 edit
    3 adds in trunk/LayoutTests

Reviewed and tweaked by Darin.

  • fast/dom/Element: Added.
  • fast/dom/Element/setAttribute-with-colon.html: Added.
  • fast/dom/Element/setAttribute-with-colon-expected.txt: Added.
10:16 PM Changeset in webkit [12687] by darin
  • 3 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • khtml/xml/dom_elementimpl.h: (ElementImpl::setAttribute): Removed body
  • khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute): Changed code so that attribute is not parsed into prefix and local name.
9:51 PM Changeset in webkit [12686] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Fix win32 build bustage. Added libjpeg prematurely to the project.

9:25 PM Changeset in webkit [12685] by justing
  • 2 edits in trunk/WebKitTools

Reviewed by thatcher


Changes to test fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setWindowHasFocus:]): (-[LayoutTestController setDisplaysWithFocusAttributes:]):
9:23 PM Changeset in webkit [12684] by justing
  • 4 edits in trunk/WebKit

Original patch by Graham Dennis, reviewed by me:


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate


Changes made by me, reviewed by thatcher:


Made _setWindowHasFocus: and _setDisplaysWithFocusAttributes: into private SPI to allow
for the testing of window.onFocus, window.onBlur, caret and focus halo painting, and
the focusing of content editable regions that happens as side effect of setting a selection,
but only if the window has focus (7128).

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didBeginEditing]): (-[WebFrameBridge didEndEditing]):
  • WebView/WebHTMLView.m: (-[WebHTMLView updateFocusState]): (-[WebHTMLView _setWindowHasFocus:]): (-[WebHTMLView _setDisplaysWithFocusAttributes:]):
  • WebView/WebHTMLViewPrivate.h:
9:18 PM Changeset in webkit [12683] by justing
  • 8 edits in trunk/WebCore

Original patch by Graham Dennis, reviewed by me
Changes made by me, reviewed by thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::didBeginEditing): (WebCore::MacFrame::didEndEditing):
  • bridge/mac/WebCoreFrameBridge.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::didBeginEditing): (WebCore::DocumentImpl::didEndEditing): (WebCore::DocumentImpl::setFocusNode):
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::focus):
  • page/Frame.h: (WebCore::Frame::didBeginEditing): (WebCore::Frame::didEndEditing):
8:44 PM Changeset in webkit [12682] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/positioning/relayout-on-position-change-expected.checksum: Added.
  • fast/block/positioning/relayout-on-position-change-expected.png: Added.
  • fast/block/positioning/relayout-on-position-change-expected.txt: Added.
  • fast/block/positioning/relayout-on-position-change.html: Added.
8:42 PM Changeset in webkit [12681] by darin
  • 2 edits in trunk/WebCore

Test: fast/block/positioning/relayout-on-position-change.html

Reviewed by Hyatt.

  • rendering/render_object.cpp: (WebCore::RenderObject::setStyle): The second call to setNeedsLayoutAndMinMaxRecalc did not mark containing blocks for relayout based on the new position value since the object itself was already marked as needing layout. Changed the first call to only mark the containing blocks (based on the old position value) and not the object itself.
8:09 PM Changeset in webkit [12680] by darin
  • 2 edits in trunk/WebKitSite

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4914
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4282

8:05 PM Changeset in webkit [12679] by darin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebPDFRepresentation.m: (+[WebPDFRepresentation postScriptMIMETypes]): Added. (+[WebPDFRepresentation supportedMIMETypes]): Include PostScript MIME types. (-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Added. (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Handle PostScript conversion using new convertPostScriptDataSourceToPDF method.
7:50 PM Changeset in webkit [12678] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests
  • added SVG path hit testing test
  • svg/custom/hit-test-path-expected.checksum: Added.
  • svg/custom/hit-test-path-expected.png: Added.
  • svg/custom/hit-test-path-expected.txt: Added.
  • svg/custom/hit-test-path.svg: Added.
7:02 PM Changeset in webkit [12677] by mjs
  • 14 edits
    2 moves
    1 delete in trunk/WebCore

Reviewed by Eric.

RenderPath refactoring:


  • Rename the files to RenderPath
  • Push the portable code from KCanvasItemQuartz down to RenderPath
  • Move most of the unportable code from KCanvasItemQuartz to KCanvasPathQuartz


The only thing left in KCanvasItemQuartz is marker support. That should be factored to separate
iterating the path elements (KCanvasPathQuartz needs to provide that) and drawing the markers
(which should be done in portable code).

  • ForwardingHeaders/kcanvas/RenderPath.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasItem.cpp: Removed.
  • kcanvas/KCanvasItem.h: Removed.
  • kcanvas/KCanvasPath.h:
  • kcanvas/RenderPath.cpp: Added. (RenderPath::mapAbsolutePointToLocal): (RenderPath::fillContains): (RenderPath::strokeContains): (RenderPath::strokeBBox): (RenderPath::relativeBBox): (RenderPath::setPath): (RenderPath::layout): (RenderPath::getAbsoluteRepaintRect): (RenderPath::requiresLayer): (RenderPath::lineHeight): (RenderPath::baselinePosition): (RenderPath::paint): (RenderPath::nodeAtPoint):
  • kcanvas/RenderPath.h: Added.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasPathQuartz.h:
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: (KCanvasPathQuartz::boundingBox): (scratchContext): (KCanvasPathQuartz::strokeBoundingBox): (pathContainsPoint): (KCanvasPathQuartz::containsPoint): (KCanvasPathQuartz::strokeContainsPoint):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createItem):
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm: (applyStrokeStyleToContext):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::updateCanvasItem): (SVGStyledElementImpl::pushAttributeContext):
  • ksvg2/svg/SVGStyledLocatableElementImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
6:32 PM Changeset in webkit [12676] by adele
  • 2 edits in trunk/WebCore

Fix broken layout tests.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): iterator is null, so we have to reset it to the first node in the chain.
5:41 PM Changeset in webkit [12675] by adele
  • 6 edits
    6 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)
  • fast/events/window-events-bubble-expected.txt: Added.
  • fast/events/window-events-bubble.html: Added.
  • fast/events/window-events-bubble2-expected.txt: Added.
  • fast/events/window-events-bubble2.html: Added.
  • fast/events/window-events-capture-expected.txt: Added.
  • fast/events/window-events-capture.html: Added.

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)

Tests:

  • fast/events/window-events-bubble.html
  • fast/events/window-events-bubble2.html
  • fast/events/window-events-capture.html
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time. (WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
  • khtml/xml/DocumentImpl.h: Added handleWindowEvent.
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases. (WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.
5:35 PM Changeset in webkit [12674] by thatcher
  • 1 edit in tags/WebCore-521.6.3/WebCore/Info.plist

Versioning.

5:32 PM Changeset in webkit [12673] by thatcher
  • 1 copy in tags/WebCore-521.6.3/WebCore

New tag.

5:32 PM Changeset in webkit [12672] by thatcher
  • 1 add in tags/WebCore-521.6.3

New tag.

5:30 PM Changeset in webkit [12671] by thatcher
  • 2 edits in tags/Safari-521.6.2/WebCore/css

Build fix when using sh 3.1

5:27 PM Changeset in webkit [12670] by thatcher
  • 2 edits in trunk/WebCore/css

Build fix to not use echo -e. This failed to build with sh 3.1.

3:49 PM Changeset in webkit [12669] by hyatt
  • 8 edits in trunk/WebCore/WebCore.vcproj/Image Viewer

Undo my checking of red painting that I landed by accident.

2:46 PM Changeset in webkit [12668] by hyatt
  • 7 edits in trunk/WebCore

Improved Cairo image rendering by only building the surface from the portion of the buffer that has been decoded so far.

2:08 PM Changeset in webkit [12667] by thatcher
  • 1 delete in Safari-417.9

Removing a mistake copy.

2:06 PM Changeset in webkit [12666] by thatcher
  • 8 copies in tags/Safari-417.9

Tagging.

1:54 PM Changeset in webkit [12665] by thatcher
  • 8 copies in Safari-417.9

Tagging.

1:47 PM Changeset in webkit [12664] by thatcher
  • 3 edits in branches/Safari-2-0-branch

Versioning the CHangeLogs.

1:44 PM Changeset in webkit [12663] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/JavaScriptCore-3.3.exp

Adding the NPN_DeallocateObject symbol.

11:17 AM Changeset in webkit [12662] by thatcher
  • 3 edits in branches/Safari-2-0-branch

Versioning

3:53 AM Changeset in webkit [12661] by andersca
  • 3 edits
    2 moves in trunk/WebCore

2006-02-08 Anders Carlsson <​andersca@mac.com>

Rubber stamped by Maciej.

Move JSCore.cpp to bindings/js/JSDOMCore.cpp and
rename JSEvents.cpp to JSDOMEvents.cpp


  • JSCore.cpp: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMCore.cpp: Added.
  • bindings/js/JSDOMEvents.cpp: Added.
  • bindings/js/JSEvents.cpp: Removed.
3:48 AM Changeset in webkit [12660] by andersca
  • 7 edits
    1 add in trunk/WebCore

2006-02-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • JSCore.cpp: Add JSElement.cpp.


  • bindings/scripts/CodeGeneratorJS.pm: Handle a bunch of new types.


  • khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::getValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): Remove code that is autogenerated now.


(KJS::getDOMNode):
Create a JSElement instead of a DOMElement.


(KJS::getDOMNodeList):
Take a PassRefPtr like some of the other get methods.


  • khtml/ecma/kjs_dom.h: (KJS::DOMElement::): Remove the now unused enums.


  • khtml/ecma/kjs_html.cpp: (KJS::): (KJS::HTMLElement::HTMLElement): (KJS::HTMLElement::getOwnPropertySlot): (KJS::KJS::HTMLElement::toString): (KJS::KJS::HTMLElement::put):
  • khtml/ecma/kjs_html.h: Have HTMLElement inherit from JSElement.
  • khtml/xml/Element.idl: Added.
3:46 AM Changeset in webkit [12659] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

I jumped the gun adding QString.cpp to the Win32 build. Still has some compile issues to work out. Removing it for now.

3:36 AM Changeset in webkit [12658] by hyatt
  • 1 delete in trunk/WebCore/ForwardingHeaders/qstring.h

Remove qstring.h forwarding header.

3:33 AM Changeset in webkit [12657] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Get the new string files added, but Win32 is still busted from the infinite include of qstring.h

2:50 AM Changeset in webkit [12656] by hyatt
  • 6 edits in trunk/WebCore

Land complete PNG support for Win32 (yay).

Note: See TracTimeline for information about the timeline view.