⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 10, 2006:

11:35 PM Changeset in webkit [12749] by hyatt
  • 1 edit in trunk/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp

Make sure the GIF decoder behaves properly when the first frame of a GIF does not cover the entire image.

11:07 PM Changeset in webkit [12748] by hyatt
  • 14 edits in trunk/WebCore

Implement an optimization to detect whether or not an image has alpha and do a blit instead of a blend in that case. r=eric

6:16 PM Changeset in webkit [12747] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout test for <rdar://problem/4149655> Frequently reported crash,
repro at lastminute.se in khtml::RenderBlock::createLineBoxes

6:08 PM Changeset in webkit [12746] by bdakin
  • 6 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4149655> Frequently reported crash, repro
at lastminute.se in khtml::RenderBlock::createLineBoxes

Some crazy combination of an anonymous table, an inline form, and
generated content caused table objects to be added to a flow and
then split. This is very bad. Once the crash was fixed, there were
still some rendering issues that this patch also fixes. We needed
to make sure we only special case forms for non-CSS tables so that
the form and generated content render as expected.

5:36 PM Changeset in webkit [12745] by thatcher
  • 2 edits in tags/WebCore-417.21/WebCore/khtml/ecma

Build fix

5:34 PM Changeset in webkit [12744] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore/khtml/ecma

Build fix.

5:18 PM Changeset in webkit [12743] by thatcher
  • 3 copies in tags/WebCore-417.21/WebCore

New tag.

5:17 PM Changeset in webkit [12742] by thatcher
  • 1 add in tags/WebCore-417.21

New tag

5:13 PM Changeset in webkit [12741] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.21

5:09 PM Changeset in webkit [12740] by eseidel
  • 2 edits in branches/Safari-2-0-branch/WebCore

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4145813> hang in XMLHttpRequest::cancelRequests
No test case possible.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::removeFromRequestsByDocument): (KJS::XMLHttpRequest::removeFromRequestsByDocument): (KJS::XMLHttpRequest::cancelRequests):
2:57 PM Changeset in webkit [12739] by darin
  • 2 edits in trunk/WebKitSite
  • index.html: Fixed a typo in a link.
1:24 PM Changeset in webkit [12738] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim O.

Rolling out r11800 and reworked Tim's original fix
to call _NPN_DeallocateObject in the destructor.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::setView): (KWQKHTMLPart::cleanupPluginRootObjects):
10:47 AM Changeset in webkit [12737] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Inlined RefPtr assignment operators. .7% performance win on super-accurate JS iBench.
  • kxmlcore/RefPtr.h: (KXMLCore::::operator):
9:31 AM Changeset in webkit [12736] by darin
  • 2 edits in trunk/WebKitSite/coding

Some factual corrections and some updates to the coding style
document to reflect our current practices.

9:11 AM Changeset in webkit [12735] by darin
  • 2 edits in trunk/WebKitSite
  • building/checkout.html: Fixed a spelling mistake.
8:41 AM Changeset in webkit [12734] by darin
  • 4 edits in trunk/WebCore
  • fixed the build, this time for sure
  • bindings/js/JSDOMCore.cpp: Touch this file, since the project doesn't get the dependencies right.
  • bindings/js/JSDOMEvents.cpp: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Fix an uninitialized variable warning and also tightened the code for Boolean, String, and Number up a bit.
2:14 AM Changeset in webkit [12733] by andersca
  • 36 edits in trunk/WebKitSite

2006-02-10 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7164
Code cleanup

Changed <div id="banner" to <h1 id="banner"
global cleanup of CSS and code

  • building/build.html:
  • building/checkout.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • contact.html:
  • index.html:
  • projects/accessibility/index.html:
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/dom/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/layout/index.html:
  • projects/mathml/index.html:
  • projects/performance/index.html:
  • projects/plugins/index.html:
  • projects/portability/index.html:
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/webkit/index.html:
  • projects/xml/index.html:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/lifecycle.html:
  • quality/reduction.html:
  • quality/reporting.html:
  • quality/testing.html:
  • quality/testwriting.html:
  • webkitdev.css:
1:49 AM Changeset in webkit [12732] by hyatt
  • 2 edits in trunk/WebCore/WebCore.vcproj

Improve the double buffering of the image viewer test app on win32 to do a source composit op and not a source-over op.

1:47 AM Changeset in webkit [12731] by hyatt
  • 9 edits in trunk/WebCore/platform/cairo

Merge cairo fixes from Mozilla and one additional fix after discussion with vlad. Code is now smarter about knowing when to blt vs. alpha blend.

1:03 AM Changeset in webkit [12730] by ggaren
  • 2 edits in trunk/JavaScriptCore

No review needed, just a build fix. This time for sure.

  • kjs/JSType.h:
12:42 AM Changeset in webkit [12729] by ggaren
  • 13 edits in trunk

JavaScriptCore:

Reviewed by eric.


  • Fixed build. As it goes without saying, I will not mention that I blame Kevin.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSImmediate.cpp: (KJS::JSImmediate::toObject):

JavaScriptGlue:

Reviewed by eric.

  • Fixed build.
  • UserObjectImp.cpp: (UserObjectImp::toPrimitive):
  • UserObjectImp.h:

WebCore:

Reviewed by eric.

  • Fixed build.
  • bridge/mac/WebCoreFrameBridge.mm:
  • khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toPrimitive): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Location::toPrimitive): (KJS::Selection::toPrimitive):
  • khtml/ecma/kjs_window.h:

Feb 9, 2006:

10:42 PM Changeset in webkit [12728] by ggaren
  • 27 edits
    1 move
    2 adds in trunk/JavaScriptCore

Reviewed by mjs.

  • Fixed <rdar://problem/4343730> Should switch ConstantValues (null, undefined, true, false) from JS objects to immediate values similar to SimpleNumber

2.0% performance gain on my new super-accurate version of JS iBench.
(I promise to land a version of it soon.)

The gist of the change:
(1) The SimpleNumber class (simple_number.h) is now the JSImmediate
class (JSImmediate.h/.cpp), and it handles not only numbers but also
null, undefined, true, and false.
(2) JSImmediate provides convenience methods for the bit masking
necessary to encode and decode immediate values.
(3) ConstantValues, BooleanImp, NullImp, and UndefinedImp are gone.
(4) JSCell no longer implements functions like getBoolean, because
only a JSImmediate can be a boolean.
(5) JSImmediate no longer uses ALWAYS_INLINE because there's no need,
and ALWAYS_INLINE is a non-portable option of last resort.
(6) Type is now JSType, and it resides in its own file, JSType.h.
Since I was there, I did some header include sorting as part of this
change.

The rest pretty much explains itself.

  • JavaScriptCore.xcodeproj/project.pbxproj: Removed simple_number.h, added JSImmediate.h/.cpp.
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue):
  • bindings/c/c_instance.h:
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue):
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]): Standardized calls to use getXXX instead of hand-rolling JSValue functionality.
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue):
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::type): (ObjcFallbackObjectImp::defaultValue):
  • bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):
  • bindings/runtime_object.h:
  • kjs/JSImmediate.h: Added. (KJS::JSImmediate::isImmediate): (KJS::JSImmediate::isNumber): (KJS::JSImmediate::isBoolean): (KJS::JSImmediate::isUndefinedOrNull): (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::toBoolean): (KJS::JSImmediate::trueImmediate): (KJS::JSImmediate::falseImmediate): (KJS::JSImmediate::NaNImmediate): (KJS::JSImmediate::undefinedImmediate): (KJS::JSImmediate::nullImmediate): (KJS::JSImmediate::tag): (KJS::JSImmediate::unTag): (KJS::JSImmediate::getTag): (KJS::JSImmediate::): (KJS::JSImmediate::isIEEE): (KJS::JSImmediate::is32bit): (KJS::JSImmediate::is64bit): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::zeroAsBits): (KJS::JSImmediate::oneAsBits):
  • kjs/JSLock.cpp: (KJS::JSLock::lock): Removed hack-o-rama to initialize ConstantValues.
  • kjs/JSType.h: Added.
  • kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::StringImp::toPrimitive): (KJS::NumberImp::toPrimitive): (KJS::NumberImp::toBoolean): (KJS::GetterSetterImp::toPrimitive):
  • kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
  • kjs/object.cpp: (KJS::JSObject::type): (KJS::tryGetAndCallProperty): Replaced "Are you one of the six things I'm looking for?" test with "Are you not the one thing I'm not looking for" test. (KJS::JSObject::defaultValue): (KJS::JSObject::toPrimitive):
  • kjs/object.h: (KJS::GetterSetterImp::type): (KJS::JSValue::isObject):
  • kjs/operations.cpp: (KJS::equal): (KJS::strictEqual): (KJS::add):
  • kjs/reference.cpp: (KJS::Reference::deleteValue):
  • kjs/simple_number.h: Removed.
  • kjs/string_object.cpp: (StringInstance::getOwnPropertySlot): fixed indentation
  • kjs/value.cpp: (KJS::JSValue::toObject): (KJS::jsNumberCell): New function to quarantine a PIC branch -- allows us to inline jsNumber without adding PIC branches to callers.
  • kjs/value.h: (KJS::jsUndefined): (KJS::jsNull): (KJS::jsNaN): (KJS::jsBoolean): (KJS::jsNumber): (KJS::JSValue::downcast): (KJS::JSValue::isUndefinedOrNull): (KJS::JSValue::isBoolean): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getBoolean): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): Replaced !JSImmediate::is() test with assertion, resulting in a slight performance gain. Callers should always check !marked() before calling mark(), so it's impossible to call mark on a JSImmediate. (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString):
5:30 PM Changeset in webkit [12727] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4153419> CrashTracer: 576 crashes in Safari at com.apple.WebKit: NPN_DestroyStream + 56

I never could reproduce this crasher, which seems to be caused by the Speed Download plugin. However,
I did find a way to make the affected code more bulletproof for those who are experiencing the crash.


  • Plugins/WebBaseNetscapePluginStream.h: Keep a WebBaseNetscapePluginView instead of the WebNetscapePluginPackage, since the plugin view could potentially be deallocated before the stream finishes loading.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream dealloc]): Assert that the plugin instance has been nulled out, since that's now part of the stream's teardown phase. Release pluginView instead of plugin. (-[WebBaseNetscapePluginStream setPluginPointer:]): Retain the plugin view instead of the plugin package, since the plugin view could be deallocated while the stream is running. This method now accepts a NULL argument so that we can easily clear out the pluginView backpointer (and other ivars derived from it). (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): ditto (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError]): Set the plugin instance to NULL, so that the pluginView backpointer is released. This method is called for every plugin view's stream when the plugin view is stopped/destroyed. (-[WebBaseNetscapePluginStream _deliverData]): Use pluginView instead of plugin.
5:20 PM Changeset in webkit [12726] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/4430614> RenderThemeMac crashes under GC
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize all the pointers. (WebCore::RenderThemeMac::setCheckboxCellState): Use KWQRetainNSRelease so we can retain a pointer to an ObjC object in a C++ class. (WebCore::RenderThemeMac::setRadioCellState): Ditto. (WebCore::RenderThemeMac::setButtonCellState): Ditto. (WebCore::RenderThemeMac::setTextFieldCellState): Ditto.
  • kwq/KWQResourceLoader.h: Remove unneeded forward declaration.
4:09 PM Changeset in webkit [12725] by darin
  • 33 edits in trunk/WebCore

Reviewed by Eric and Geoff.

  • changed basic DOM mutation calls to assert that "this" is not floating, then added more uses of RefPtr to prevent the assertion from firing (at least during my testing and layout tests)
  • removed use of PassRefPtr as the type of a local variable; after talking with Maciej and Eric, this type of use is now "deprecated"
  • bindings/js/JSDOMCore.cpp: Touched this file to get things to build.
  • bindings/objc/DOM.mm: (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange cloneRange]):
  • khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction):
  • khtml/editing/Selection.cpp: (WebCore::Selection::toRange):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
  • dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • dom/DocPtr.h: Removed uses of NULL and unused deprecated functions.
  • dom/dom2_rangeimpl.h:
  • dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::RangeImpl): (WebCore::RangeImpl::startContainer): (WebCore::RangeImpl::endContainer): (WebCore::RangeImpl::commonAncestorContainer): (WebCore::RangeImpl::setStart): (WebCore::RangeImpl::setEnd): (WebCore::RangeImpl::collapse): (WebCore::RangeImpl::compareBoundaryPoints): (WebCore::RangeImpl::boundaryPointsValid): (WebCore::RangeImpl::processContents): (WebCore::RangeImpl::extractContents): (WebCore::RangeImpl::cloneContents): (WebCore::RangeImpl::insertNode): (WebCore::RangeImpl::createContextualFragment): (WebCore::RangeImpl::detach): (WebCore::RangeImpl::cloneRange): (WebCore::RangeImpl::selectNodeContents): (WebCore::RangeImpl::surroundContents): (WebCore::RangeImpl::containedByReadOnly): (WebCore::RangeImpl::startPosition): (WebCore::RangeImpl::endPosition): (WebCore::RangeImpl::startNode): (WebCore::RangeImpl::editingStartPosition): (WebCore::rangeOfContents):
  • dom/dom_elementimpl.h:
  • dom/dom_elementimpl.cpp: (WebCore::AttrImpl::AttrImpl): (WebCore::AttrImpl::~AttrImpl): (WebCore::AttrImpl::setValue): (WebCore::AttrImpl::childTypeAllowed): (WebCore::AttrImpl::childrenChanged): (WebCore::ElementImpl::removeAttributeNode): (WebCore::NamedAttrMapImpl::clearAttributes): (WebCore::CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl): (WebCore::MappedAttributeImpl::clone):
  • dom/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode):
  • dom/dom_xmlimpl.cpp: (WebCore::EntityReferenceImpl::cloneNode): (WebCore::ProcessingInstructionImpl::ProcessingInstructionImpl): (WebCore::ProcessingInstructionImpl::checkStyleSheet): (WebCore::ProcessingInstructionImpl::setStyleSheet):
  • dom/dom_position.cpp:
  • khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::createBlockPlaceholderElement):
  • khtml/editing/delete_selection_command.cpp: (WebCore::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): (WebCore::nonBreakingSpaceString): (WebCore::createDefaultParagraphElement): (WebCore::createBreakElement): (WebCore::createTabSpanElement):
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.h:
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::insertTab):
  • khtml/editing/markup.cpp: (khtml::createFragmentFromMarkup): (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText): (khtml::createFragmentFromNodeList):
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplaceSelectionCommand::doApply):
  • khtml/editing/visible_text.cpp: (khtml::CharacterIterator::range): (khtml::findPlainText):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
  • ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer):
1:33 PM Changeset in webkit [12724] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Adding eol-style.

1:31 PM Changeset in webkit [12723] by thatcher
  • 1 copy
    1 add in trunk/WebKit

Rolling over the ChangeLog.

11:22 AM Changeset in webkit [12722] by ap
  • 3 edits in trunk/WebKitSite

Fixes by Mark Rowe and Joost de Valk. Reviewed by Darin. Landed by ap.



  • quality/reporting.html:
  • webkitdev.css: Added margin-bottom for li.
11:21 AM Changeset in webkit [12721] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4198378> Crash on a CFRelease when visiting ​http://www.akella.com/

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): The true source of this crash is that the URL string is sometimes not NULL-terminated, which is the Real Player plugin's fault. That has been filed as 4439591. However, we can be more bulletproof here by switching the URL string encoding from Windows Latin 1 to ISO Latin 1, so that any NULL-terminated string can be represented. (As Darin and I found out last night, Windows Latin 1 has "holes" in certain character ranges and thus cannot encode arbitrary C strings).
2:16 AM Changeset in webkit [12720] by mjs
  • 4 edits in trunk/WebCore

Reviewed and landed by Maciej.


Factor out common parts of Linear/Radial GradientQuartz
up into KRenderingPaintServerGradientQuartz.

Cleanup only, no layout tests needed or affected.

  • kcanvas/device/KRenderingPaintServer.h:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (KRenderingPaintServerGradientQuartz::draw): (KRenderingPaintServerGradientQuartz::setup): (KRenderingPaintServerGradientQuartz::renderPath): (KRenderingPaintServerGradientQuartz::teardown):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerLinearGradientQuartz::renderPath): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::renderPath):
1:54 AM Changeset in webkit [12719] by mjs
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • various Frame cleanup:


Make Frame-related classes Noncopyable.
Remove nearly all of Frame's friends.
Remove some unused stuff.
Remove unneeded class forward declarations from Frame.h

  • page/Frame.cpp:
  • page/Frame.h:
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
  • page/FrameView.cpp: (WebCore::FrameView::viewportMouseMoveEvent):
  • page/Page.h: (WebCore::Page::mainFrame):
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
1:36 AM Changeset in webkit [12718] by mjs
  • 2 edits
    14 moves
    1 add in trunk/WebKit

Rubber stamped by Anders.


  • Moved all the default delegate classes to their own directory.
  • DefaultDelegates: Added.
  • DefaultDelegates/WebDefaultContextMenuDelegate.h: Added.
  • DefaultDelegates/WebDefaultContextMenuDelegate.m: Added.
  • DefaultDelegates/WebDefaultEditingDelegate.h: Added.
  • DefaultDelegates/WebDefaultEditingDelegate.m: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultPolicyDelegate.h: Added.
  • DefaultDelegates/WebDefaultPolicyDelegate.m: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.h: Added.
  • DefaultDelegates/WebDefaultScriptDebugDelegate.m: Added.
  • DefaultDelegates/WebDefaultUIDelegate.h: Added.
  • DefaultDelegates/WebDefaultUIDelegate.m: Added.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDefaultContextMenuDelegate.h: Removed.
  • WebView/WebDefaultContextMenuDelegate.m: Removed.
  • WebView/WebDefaultEditingDelegate.h: Removed.
  • WebView/WebDefaultEditingDelegate.m: Removed.
  • WebView/WebDefaultFrameLoadDelegate.h: Removed.
  • WebView/WebDefaultFrameLoadDelegate.m: Removed.
  • WebView/WebDefaultPolicyDelegate.h: Removed.
  • WebView/WebDefaultPolicyDelegate.m: Removed.
  • WebView/WebDefaultResourceLoadDelegate.h: Removed.
  • WebView/WebDefaultResourceLoadDelegate.m: Removed.
  • WebView/WebDefaultScriptDebugDelegate.h: Removed.
  • WebView/WebDefaultScriptDebugDelegate.m: Removed.
  • WebView/WebDefaultUIDelegate.h: Removed.
  • WebView/WebDefaultUIDelegate.m: Removed.
1:09 AM Changeset in webkit [12717] by hyatt
  • 8 edits
    1 add in trunk/WebCore

Minor image cleanup to the decoders. Doesn't affect Mac.

12:46 AM Changeset in webkit [12716] by hyatt
  • 2 edits in trunk/WebCore/WebCore.vcproj/WebCore

Update Win32 project to account for the khtml/xml to dom move.

12:26 AM Changeset in webkit [12715] by mjs
  • 50 edits
    1 move in trunk/WebCore

Rubber-stamped by Hyatt.


  • moved khtml/xml to dom
  • dom: moved from khtml/xml
  • WebCore.xcodeproj/project.pbxproj: Updated for new file locations.
  • WebCore+SVG/KDOMHeaders.h: Updated for new header locations.
  • dom/dom2_rangeimpl.cpp: ditto
  • dom/dom2_traversalimpl.cpp: ditto
  • dom/dom_textimpl.cpp: ditto
  • dom/dom_xmlimpl.cpp: ditto
  • khtml/dom/dom2_events.cpp: ditto
  • khtml/ecma/kjs_binding.cpp: ditto
  • khtml/ecma/kjs_dom.cpp: ditto
  • khtml/ecma/kjs_events.cpp: ditto
  • khtml/ecma/kjs_html.cpp: ditto
  • khtml/ecma/kjs_range.cpp: ditto
  • khtml/ecma/kjs_views.cpp: ditto
  • khtml/editing/Selection.cpp: ditto
  • khtml/editing/SelectionController.cpp: ditto
  • khtml/editing/delete_from_text_node_command.cpp: ditto
  • khtml/editing/edit_command.cpp: ditto
  • khtml/editing/insert_into_text_node_command.cpp: ditto
  • khtml/editing/insert_line_break_command.cpp: ditto
  • khtml/editing/insert_paragraph_separator_command.cpp: ditto
  • khtml/editing/insert_text_command.cpp: ditto
  • khtml/editing/join_text_nodes_command.cpp: ditto
  • khtml/editing/markup.cpp: ditto
  • khtml/editing/merge_identical_elements_command.cpp: ditto
  • khtml/editing/rebalance_whitespace_command.cpp: ditto
  • khtml/editing/remove_node_attribute_command.cpp: ditto
  • khtml/editing/set_node_attribute_command.cpp: ditto
  • khtml/editing/split_element_command.cpp: ditto
  • khtml/editing/split_text_node_command.cpp: ditto
  • khtml/editing/split_text_node_containing_element.cpp: ditto
  • khtml/editing/visible_position.cpp: ditto
  • khtml/editing/visible_position.h: ditto
  • khtml/editing/visible_text.cpp: ditto
  • khtml/editing/visible_text.h: ditto
  • khtml/editing/visible_units.cpp: ditto
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: ditto
  • khtml/html/HTMLElementImpl.h: ditto
  • khtml/html/html_documentimpl.cpp: ditto
  • khtml/html/html_headimpl.cpp: ditto
  • khtml/xbl/xbl_binding_manager.cpp: ditto
  • khtml/xbl/xbl_tokenizer.cpp: ditto
  • khtml/xbl/xbl_tokenizer.h: ditto
  • ksvg2/svg/SVGAElementImpl.cpp: ditto
  • rendering/InlineTextBox.cpp: ditto
  • rendering/RenderContainer.cpp: ditto
  • rendering/RenderText.h: ditto
  • rendering/RenderTextField.cpp: ditto
  • rendering/render_frames.cpp: ditto
  • rendering/render_layer.cpp: ditto
12:03 AM Changeset in webkit [12714] by eseidel
  • 2 edits
    1 move in trunk/WebKitTools

2006-02-09 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Renamed split-class to split-file-by-class.

  • Scripts/build-webkit: Updated copyright.
  • Scripts/split-class: Removed.
  • Scripts/split-file-by-class: Added.
Note: See TracTimeline for information about the timeline view.