⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 11, 2006:

7:10 PM Changeset in webkit [12766] by ggaren
  • 3 edits in trunk/WebCore
  • Fixed bad free resulting from 0 legnth StringImpl

No test case because currently this bug only has the effect of a bad
free on exit().

  • platform/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Factored varied approaches to initialization into two common routines: initWithChar and initWithQChar. The common rule is: if we're not going to allocate a string, make sure to set s to 0 so fastFree doesn't try to free it later. For speed, initWithQChar uses memcpy() -- that's the only difference between the two. (WebCore::StringImpl::initWithChar): (WebCore::StringImpl::initWithQChar):
  • platform/StringImpl.h:
5:18 PM Changeset in webkit [12765] by mjs
  • 40 edits
    8 copies
    2 moves in trunk/WebCore

Rubber stamped by Eric.

  • split dom_textimpl.{h,cpp} by class.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bridge/mac/MacFrame.mm:
  • dom/CDATASectionImpl.cpp: Added.
  • dom/CDATASectionImpl.h: Added.
  • dom/CharacterDataImpl.cpp: Added.
  • dom/CharacterDataImpl.h: Added.
  • dom/CommentImpl.cpp: Added.
  • dom/CommentImpl.h: Added.
  • dom/DocumentImpl.cpp:
  • dom/EditingTextImpl.cpp: Added.
  • dom/EditingTextImpl.h: Added.
  • dom/NodeImpl.cpp:
  • dom/TextImpl.cpp: Added.
  • dom/TextImpl.h: Added.
  • dom/dom2_rangeimpl.cpp:
  • dom/dom_elementimpl.cpp:
  • dom/dom_textimpl.cpp: Removed.
  • dom/dom_textimpl.h: Removed.
  • dom/xml_tokenizer.cpp:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/break_blockquote_command.cpp:
  • khtml/editing/composite_edit_command.cpp:
  • khtml/editing/delete_from_text_node_command.cpp:
  • khtml/editing/delete_selection_command.cpp:
  • khtml/editing/htmlediting.cpp:
  • khtml/editing/insert_into_text_node_command.cpp:
  • khtml/editing/insert_line_break_command.cpp:
  • khtml/editing/insert_paragraph_separator_command.cpp:
  • khtml/editing/insert_text_command.cpp:
  • khtml/editing/join_text_nodes_command.cpp:
  • khtml/editing/markup.cpp:
  • khtml/editing/rebalance_whitespace_command.cpp:
  • khtml/editing/replace_selection_command.cpp:
  • khtml/editing/split_text_node_command.cpp:
  • khtml/editing/split_text_node_containing_element.cpp:
  • khtml/editing/visible_position.cpp:
  • khtml/html/HTMLElementImpl.cpp:
  • khtml/html/HTMLKeygenElementImpl.cpp:
  • khtml/html/HTMLOptionElementImpl.cpp:
  • khtml/html/HTMLTextAreaElementImpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmlparser.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • page/Frame.cpp:
  • rendering/RenderText.h:
  • rendering/render_frames.cpp:
4:51 PM Changeset in webkit [12764] by eseidel
  • 15 edits
    4 adds in trunk

2006-02-11 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

  • Layout tests changes:

Fixed: svg/W3C-SVG-1.1/coords-units-03-b.svg
New: svg/custom/coords-relative-units-transforms.svg

4:21 PM Changeset in webkit [12763] by darin
  • 2 edits
    1 add in trunk/WebKitSite

Reviewed by Darin.

Added a Bugzilla page, which contains information about creating a Bugzilla account, what editbugs and canconfirm
bits are and how to get them.


Changed link in reporting page to link to Bugzilla page.


  • quality/bugzilla.html: Added.
  • quality/reporting.html:
4:09 PM Changeset in webkit [12762] by darin
  • 2 edits
    13 moves in trunk/WebCore

Rubber-stamped by Eric.

  • renamed all the platform/mac files to have a Mac suffix (Hyatt and I discussed this change recently)
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/Color.mm: Removed.
  • platform/mac/ColorMac.mm: Added.
  • platform/mac/FloatPoint.mm: Removed.
  • platform/mac/FloatPointMac.mm: Added.
  • platform/mac/FloatRect.mm: Removed.
  • platform/mac/FloatRectMac.mm: Added.
  • platform/mac/FloatSize.mm: Removed.
  • platform/mac/FloatSizeMac.mm: Added.
  • platform/mac/Image.mm: Removed.
  • platform/mac/ImageMac.mm: Added.
  • platform/mac/ImageSource.cpp: Removed.
  • platform/mac/ImageSourceMac.cpp: Added.
  • platform/mac/IntPoint.mm: Removed.
  • platform/mac/IntPointMac.mm: Added.
  • platform/mac/IntRect.mm: Removed.
  • platform/mac/IntRectMac.mm: Added.
  • platform/mac/IntSize.mm: Removed.
  • platform/mac/IntSizeMac.mm: Added.
  • platform/mac/QString.mm: Removed.
  • platform/mac/QStringMac.mm: Added.
  • platform/mac/Screen.mm: Removed.
  • platform/mac/ScreenMac.mm: Added.
  • platform/mac/SystemTime.cpp: Removed.
  • platform/mac/SystemTimeMac.cpp: Added.
  • platform/mac/Timer.cpp: Removed.
  • platform/mac/TimerMac.cpp: Added.
3:54 PM Changeset in webkit [12761] by eseidel
  • 327 edits in trunk/WebCore

2006-02-11 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Push kcanvas into WebCore namespace.
Fix KSVG2 to use WebCore namespace.

Remove all uses of khtml
and KDOM:: from SVG code. Too many files changed to bother showing here.
3:38 PM Changeset in webkit [12760] by darin
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

  • fast/events/event-targets.html: Fixed a small mistake in this test, noticed while checking that bug 3609 is fixed in tip of tree.
3:19 PM Changeset in webkit [12759] by eseidel
  • 2 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed by eseidel.

  • Changed 10.2 paragraph to say Mac OS X instead of just OS X
  • Detabified the file.
  • quality/reporting.html:
12:11 PM Changeset in webkit [12758] by adele
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.



  • fast/replaced/width100percent-expected.checksum: Updated.
  • fast/replaced/width100percent-expected.png: Updated.
  • fast/replaced/width100percent-expected.txt: Updated.
  • fast/table/edge-offsets-expected.checksum: Added.
  • fast/table/edge-offsets-expected.png: Added.
  • fast/table/edge-offsets-expected.txt: Added.
  • fast/table/edge-offsets.html: Added.

WebCore:

Test: fast/table/edge-offsets.html


Reviewed by Hyatt.



  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): Override the superclass implementation to return the lowest of all the cells' lowest positions and the section's. (WebCore::RenderTableSection::rightmostPosition): Ditto for rightmost. (WebCore::RenderTableSection::leftmostPosition): Ditto for leftmost.
  • rendering/RenderTableSection.h:
11:56 AM Changeset in webkit [12757] by adele
  • 3 edits in trunk/WebCore

No test until we figure out how to make one.

Reviewed by Darin.



  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Removed the call to setParsing(false) from here since it stopped parsing prematurely. Now the frame will call it when the tokenizer is finished.
  • page/Frame.cpp: (WebCore::Frame::clear): Disconnect the finishedParsing signal handler from the document. (WebCore::Frame::setDocument): Disconnect the signal handler from the old document and connect it to the new document.
11:39 AM Changeset in webkit [12756] by adele
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.



  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::hoveredNodeDetached): Added this method. Moved the hover logic from NodeImpl::detach here, modified to use the DOM tree instead of hoverAncestor, to handle the case that the hover node is a text node, and to schedule an update of hover state. (WebCore::DocumentImpl::activeChainNodeDetached): Added this method to trim the active chain above the node being detached.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Moved most of the hover logic out of here into DocumentImpl. Reset m_active and m_inActiveChain and call activeChainNodeDetached when detaching an active node.
  • manual-tests/bugzilla-6821.html: Added.
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added hover-state update timer. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::hoverTimerFired): Call DocumentImpl::prepareMouseEvent when the timer fires to cause hover state to update. (WebCore::FrameView::scheduleHoverStateUpdate): Added.
  • page/FrameView.h:
9:58 AM Changeset in webkit [12755] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated paths for recent changes in directory structure.
8:03 AM Changeset in webkit [12754] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

  • English.lproj/Localizable.strings: Added new UI_STRING().
  • Misc/WebKitErrors.m: Added #define for description. (registerErrors): Added dictionary entry.
2:48 AM Changeset in webkit [12753] by ap
  • 4 edits
    12 adds in trunk

Reviewed by Darin.

Test cases:

  • fast/frames/frame-set-same-location.html
  • fast/frames/frame-set-same-src.html
  • fast/frames/iframe-set-same-location.html
  • fast/frames/iframe-set-same-src.html
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::setLocation): Remove the check for the new URL being different from the current one. Moved updateForNewURL() code into setLocation().
  • khtml/html/html_baseimpl.h:
2:34 AM Changeset in webkit [12752] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use kCFStringEncodingISOLatin1 rather than kCFStringEncodingWindowsLatin1, because the latter encoding has holes, and conversion can still fail.
12:34 AM Changeset in webkit [12751] by eseidel
  • 1 edit
    9 adds in trunk/LayoutTests

2006-02-11 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • fast/parser/external-entities-expected.checksum: Added.
  • fast/parser/external-entities-expected.png: Added.
  • fast/parser/external-entities-expected.txt: Added.
  • fast/parser/external-entities-in-xslt-expected.txt: Added.
  • fast/parser/external-entities-in-xslt.xml: Added.
  • fast/parser/external-entities.xml: Added.
  • fast/parser/resources: Added.
  • fast/parser/resources/external-entities.dtd: Added.
  • fast/parser/resources/external-entities.xsl: Added.
12:15 AM Changeset in webkit [12750] by eseidel
  • 5 edits in trunk/WebCore

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): new support class (WebCore::OffsetBuffer::readOutBytes): read method (WebCore::shouldAllowExternalLoad): for preventing common urls (WebCore::openFunc): now does a synchronous data load (WebCore::readFunc): returns data from the offset buffer (WebCore::closeFunc): deletes offset buffer (WebCore::setLoaderForLibXMLCallbacks): helper function (WebCore::createQStringParser): cleanup (WebCore::XMLTokenizer::finish):
  • dom/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
  • khtml/xsl/xsl_stylesheetimpl.h:

Feb 10, 2006:

11:35 PM Changeset in webkit [12749] by hyatt
  • 1 edit in trunk/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp

Make sure the GIF decoder behaves properly when the first frame of a GIF does not cover the entire image.

11:07 PM Changeset in webkit [12748] by hyatt
  • 14 edits in trunk/WebCore

Implement an optimization to detect whether or not an image has alpha and do a blit instead of a blend in that case. r=eric

6:16 PM Changeset in webkit [12747] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout test for <rdar://problem/4149655> Frequently reported crash,
repro at lastminute.se in khtml::RenderBlock::createLineBoxes

6:08 PM Changeset in webkit [12746] by bdakin
  • 6 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4149655> Frequently reported crash, repro
at lastminute.se in khtml::RenderBlock::createLineBoxes

Some crazy combination of an anonymous table, an inline form, and
generated content caused table objects to be added to a flow and
then split. This is very bad. Once the crash was fixed, there were
still some rendering issues that this patch also fixes. We needed
to make sure we only special case forms for non-CSS tables so that
the form and generated content render as expected.

5:36 PM Changeset in webkit [12745] by thatcher
  • 2 edits in tags/WebCore-417.21/WebCore/khtml/ecma

Build fix

5:34 PM Changeset in webkit [12744] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore/khtml/ecma

Build fix.

5:18 PM Changeset in webkit [12743] by thatcher
  • 3 copies in tags/WebCore-417.21/WebCore

New tag.

5:17 PM Changeset in webkit [12742] by thatcher
  • 1 add in tags/WebCore-417.21

New tag

5:13 PM Changeset in webkit [12741] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.21

5:09 PM Changeset in webkit [12740] by eseidel
  • 2 edits in branches/Safari-2-0-branch/WebCore

2006-02-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4145813> hang in XMLHttpRequest::cancelRequests
No test case possible.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::removeFromRequestsByDocument): (KJS::XMLHttpRequest::removeFromRequestsByDocument): (KJS::XMLHttpRequest::cancelRequests):
2:57 PM Changeset in webkit [12739] by darin
  • 2 edits in trunk/WebKitSite
  • index.html: Fixed a typo in a link.
1:24 PM Changeset in webkit [12738] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim O.

Rolling out r11800 and reworked Tim's original fix
to call _NPN_DeallocateObject in the destructor.

  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::setView): (KWQKHTMLPart::cleanupPluginRootObjects):
10:47 AM Changeset in webkit [12737] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Inlined RefPtr assignment operators. .7% performance win on super-accurate JS iBench.
  • kxmlcore/RefPtr.h: (KXMLCore::::operator):
9:31 AM Changeset in webkit [12736] by darin
  • 2 edits in trunk/WebKitSite/coding

Some factual corrections and some updates to the coding style
document to reflect our current practices.

9:11 AM Changeset in webkit [12735] by darin
  • 2 edits in trunk/WebKitSite
  • building/checkout.html: Fixed a spelling mistake.
8:41 AM Changeset in webkit [12734] by darin
  • 4 edits in trunk/WebCore
  • fixed the build, this time for sure
  • bindings/js/JSDOMCore.cpp: Touch this file, since the project doesn't get the dependencies right.
  • bindings/js/JSDOMEvents.cpp: Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Fix an uninitialized variable warning and also tightened the code for Boolean, String, and Number up a bit.
2:14 AM Changeset in webkit [12733] by andersca
  • 36 edits in trunk/WebKitSite

2006-02-10 Joost de Valk <​jdevalk@opendarwin.org>

Reviewed and landed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7164
Code cleanup

Changed <div id="banner" to <h1 id="banner"
global cleanup of CSS and code

  • building/build.html:
  • building/checkout.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • contact.html:
  • index.html:
  • projects/accessibility/index.html:
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/dom/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/layout/index.html:
  • projects/mathml/index.html:
  • projects/performance/index.html:
  • projects/plugins/index.html:
  • projects/portability/index.html:
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/webkit/index.html:
  • projects/xml/index.html:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/lifecycle.html:
  • quality/reduction.html:
  • quality/reporting.html:
  • quality/testing.html:
  • quality/testwriting.html:
  • webkitdev.css:
1:49 AM Changeset in webkit [12732] by hyatt
  • 2 edits in trunk/WebCore/WebCore.vcproj

Improve the double buffering of the image viewer test app on win32 to do a source composit op and not a source-over op.

1:47 AM Changeset in webkit [12731] by hyatt
  • 9 edits in trunk/WebCore/platform/cairo

Merge cairo fixes from Mozilla and one additional fix after discussion with vlad. Code is now smarter about knowing when to blt vs. alpha blend.

1:03 AM Changeset in webkit [12730] by ggaren
  • 2 edits in trunk/JavaScriptCore

No review needed, just a build fix. This time for sure.

  • kjs/JSType.h:
12:42 AM Changeset in webkit [12729] by ggaren
  • 13 edits in trunk

JavaScriptCore:

Reviewed by eric.


  • Fixed build. As it goes without saying, I will not mention that I blame Kevin.
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/JSImmediate.cpp: (KJS::JSImmediate::toObject):

JavaScriptGlue:

Reviewed by eric.

  • Fixed build.
  • UserObjectImp.cpp: (UserObjectImp::toPrimitive):
  • UserObjectImp.h:

WebCore:

Reviewed by eric.

  • Fixed build.
  • bridge/mac/WebCoreFrameBridge.mm:
  • khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toPrimitive): (KJS::DOMNodeList::toPrimitive):
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Location::toPrimitive): (KJS::Selection::toPrimitive):
  • khtml/ecma/kjs_window.h:
Note: See TracTimeline for information about the timeline view.