⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 15, 2006:

10:34 PM Changeset in webkit [12840] by ggaren
  • 18 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.

  • bindings/jni/jni_instance.cpp: Made _instance a RefPtr (JavaInstance::~JavaInstance): (JObjectWrapper::JObjectWrapper):
  • bindings/jni/jni_instance.h: (KJS::Bindings::JObjectWrapper::ref): (KJS::Bindings::JObjectWrapper::deref):
  • bindings/jni/jni_runtime.cpp: Made _array a RefPtr (JavaArray::~JavaArray): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaArray::operator=):
  • bindings/objc/objc_runtime.h:
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::Instance): (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createRuntimeObject):
  • bindings/runtime.h: (KJS::Bindings::Instance::ref): (KJS::Bindings::Instance::deref):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::RuntimeObjectImp): (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::getOwnPropertySlot): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut):
  • bindings/runtime_object.h:
  • Removed ownsInstance data member because RefPtr takes care of instance lifetime now.
  • Prohibited copying because that would muss the ref count.
  • Prohibited construction without instance because an instance wrapper without an instance is almost certainly a bug. (KJS::RuntimeObjectImp::getInternalInstance):

LayoutTests:

Reviewed by Eric.

  • Layout test for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()
  • plugins: Added.
  • plugins/undefined-property-crash-expected.txt: Added.
  • plugins/undefined-property-crash.html: Added.

WebCore:

Reviewed by Maciej, Eric.

  • WebCore half of fix for <rdar://problem/4176077> CrashTracer: 6569 crashes in DashboardClient at com.apple.JavaScriptCore: KJS::Bindings::ObjcFallbackObjectImp::type()

WebCore and JavaScriptCore weren't sharing Instance objects very
nicely. I made them use RefPtrs, and sent them to bed without dessert.

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::HTMLAppletElementImpl): Made appletInstance a RefPtr (WebCore::HTMLAppletElementImpl::getAppletInstance): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::HTMLEmbedElementImpl): Made embedInstance a RefPtr (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::HTMLObjectElementImpl): Made objectInstance a RefPtr (WebCore::HTMLObjectElementImpl::getObjectInstance): (WebCore::HTMLObjectElementImpl::detach):
  • bindings/js/JSDOMCore.cpp:
  • khtml/ecma/kjs_dom.cpp: (KJS::getRuntimeObject):
  • khtml/html/html_objectimpl.h:

WebKitTools:

Reviewed by Eric.

  • DumpRenderTree/DumpRenderTree.m: (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]): Added a dummy method for the sake of LayoutTests/plugins/ undefined-property-crash.html. (It tests a crash due to fallback object use. WebCore won't create a fallback object if the method is not defined.)
10:11 PM Changeset in webkit [12839] by thatcher
  • 47 edits
    31 adds
    10 deletes in trunk/WebKitSite

Reviewed by Tim H.

Updated the site to use the new layout.

  • .htaccess: Added.
  • ChangeLog:
  • blog/wp-content/themes/classic: Removed.
  • blog/wp-content/themes/classic/comments-popup.php: Removed.
  • blog/wp-content/themes/classic/comments.php: Removed.
  • blog/wp-content/themes/classic/footer.php: Removed.
  • blog/wp-content/themes/classic/header.php: Removed.
  • blog/wp-content/themes/classic/index.php: Removed.
  • blog/wp-content/themes/classic/sidebar.php: Removed.
  • blog/wp-content/themes/classic/style.css: Removed.
  • blog/wp-content/themes/default: Removed.
  • blog/wp-content/themes/default/404.php: Removed.
  • blog/wp-content/themes/default/archive.php: Removed.
  • blog/wp-content/themes/default/archives.php: Removed.
  • blog/wp-content/themes/default/comments-popup.php: Removed.
  • blog/wp-content/themes/default/comments.php: Removed.
  • blog/wp-content/themes/default/footer.php: Removed.
  • blog/wp-content/themes/default/header.php: Removed.
  • blog/wp-content/themes/default/images: Removed.
  • blog/wp-content/themes/default/images/kubrickbg.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickbgcolor.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickbgwide.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickfooter.jpg: Removed.
  • blog/wp-content/themes/default/images/kubrickheader.jpg: Removed.
  • blog/wp-content/themes/default/index.php: Removed.
  • blog/wp-content/themes/default/links.php: Removed.
  • blog/wp-content/themes/default/page.php: Removed.
  • blog/wp-content/themes/default/search.php: Removed.
  • blog/wp-content/themes/default/searchform.php: Removed.
  • blog/wp-content/themes/default/sidebar.php: Removed.
  • blog/wp-content/themes/default/single.php: Removed.
  • blog/wp-content/themes/default/style.css: Removed.
  • blog/wp-content/themes/webkit/404.php:
  • blog/wp-content/themes/webkit/archive.php:
  • blog/wp-content/themes/webkit/archives.php:
  • blog/wp-content/themes/webkit/footer.php:
  • blog/wp-content/themes/webkit/header.php:
  • blog/wp-content/themes/webkit/images: Removed.
  • blog/wp-content/themes/webkit/images/bluebanner.png: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbg.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbgcolor.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickbgwide.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickfooter.jpg: Removed.
  • blog/wp-content/themes/webkit/images/kubrickheader.jpg: Removed.
  • blog/wp-content/themes/webkit/images/separator.png: Removed.
  • blog/wp-content/themes/webkit/images/webkit-background.png: Removed.
  • blog/wp-content/themes/webkit/index.php:
  • blog/wp-content/themes/webkit/page.php:
  • blog/wp-content/themes/webkit/search.php:
  • blog/wp-content/themes/webkit/sidebar.php:
  • blog/wp-content/themes/webkit/single.php:
  • blog/wp-content/themes/webkit/style.css:
  • building/build.html:
  • building/checkout.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • contact.html:
  • css: Added.
  • css/blue.css: Added.
  • css/gray.css: Added.
  • css/green.css: Added.
  • css/ie.css: Added.
  • css/main.css: Added.
  • css/pink.css: Added.
  • css/purple.css: Added.
  • css/yellow.css: Added.
  • footer.inc: Added.
  • header.inc: Added.
  • images/blue-background.png: Added.
  • images/blue-bullet.png: Added.
  • images/bluebanner.png: Removed.
  • images/download.png: Added.
  • images/end.png: Added.
  • images/gray-background.png: Added.
  • images/green-background.png: Added.
  • images/green-bullet.png: Added.
  • images/icon-gold.png: Added.
  • images/icon.png: Added.
  • images/ie-nav.png: Added.
  • images/middle.png: Added.
  • images/nav.png: Added.
  • images/pink-background.png: Added.
  • images/pink-bullet.png: Added.
  • images/purple-background.png: Added.
  • images/purple-bullet.png: Added.
  • images/separator.png: Removed.
  • images/webkit-background.png: Removed.
  • images/welcomeopen.gif: Removed.
  • images/yellow-background.png: Added.
  • images/yellow-bullet.png: Added.
  • index.html:
  • nav.inc: Added.
  • projects/accessibility/index.html:
  • projects/cleanup/index.html:
  • projects/compat/index.html:
  • projects/css/index.html:
  • projects/documentation/index.html:
  • projects/dom/index.html:
  • projects/editing/index.html:
  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/index.html:
  • projects/javascript/index.html:
  • projects/layout/index.html:
  • projects/mathml/index.html:
  • projects/performance/index.html:
  • projects/plugins/index.html:
  • projects/portability/index.html:
  • projects/printing/index.html:
  • projects/svg/index.html:
  • projects/webkit/index.html:
  • projects/xml/index.html:
  • projects/xslt/index.html:
  • quality/bugpriorities.html:
  • quality/bugwriting.html:
  • quality/bugzilla.html:
  • quality/lifecycle.html:
  • quality/reduction.html:
  • quality/reporting.html:
  • quality/testing.html:
  • quality/testwriting.html:
  • sidebar.css: Removed.
  • sidebar.html: Removed.
  • webkitdev.css: Removed.
8:21 PM Changeset in webkit [12838] by eseidel
  • 1 edit
    3 adds in trunk/LayoutTests

2006-02-15 Eric Seidel <​eseidel@apple.com>

Add files missing from previous commit.


  • svg/custom/feDisplacementMap-01-expected.checksum: Added.
  • svg/custom/feDisplacementMap-01-expected.png: Added.
  • svg/custom/feDisplacementMap-01-expected.txt: Added.
4:19 PM Changeset in webkit [12837] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Eric.

No test case because it requires manual mouse wheeling.

  • dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchWheelEvent): Use a RefPtr instead of just leaking the WheelEventImpl.
4:16 PM Changeset in webkit [12836] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by John.

  • Applied the 4330457 change to CClass and ObjcClass as well.

Once plugins work in DumpRenderTree, running run-webkit-tests --leaks
will catch this.

This change isn't as critical because CClass and ObjcClass objects get
cached globally and never deleted, but it's good practice, in case we
ever do decide to delete CClass and ObjcClass objects.

This change requires prohibiting copying, because we don't do any
intelligent ref-counting -- when a Class is destroyed, it destroys its
methods and fields unconditionally. (Java classes already prohibited
copying.)

  • bindings/c/c_class.cpp:
  • Merged _commonInit and _commonDelete into constructor and destructor. (CClass::CClass): (CClass::~CClass): (CClass::methodsNamed): Added delete callbacks (CClass::fieldNamed): Added delete callbacks
  • bindings/c/c_class.h: Prohibited copying
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::getClass): Changed to use the preferred class factory method, to take advantage of the global cache.

[ Repeated changes applied to CClass for ObjcClass: ]

  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::~ObjcClass): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::ObjcMethod): Initialized uninitialized variable to prevent bad CFRelease. (KJS::Bindings::ObjcMethod::~ObjcMethod): Removed erroneous ';' from if statement to prevent bad CFRelease.
  • bindings/objc/objc_runtime.cpp: Changed to use the preferred ObjectStructPtr, for clarity.
3:50 PM Changeset in webkit [12835] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by John.

  • Fixed <rdar://problem/4330457> CrashTracer: [REGRESSION] 3763 crashes in Safari at com.apple.JavaScriptCore: KJS::Bindings::JavaInstance:: getClass const + 56

This was a memory leak in the bindings code. The leak was so extreme
that it would cause Safari or the JVM to abort from lack of memory.
Upon construction, Class objects create field and method objects,
storing them in CFDictionaries. The bug was that upon destruction, the
class objects released the dictionaries but didn't destroy the stored
objects.

The fix is to supply CFDictionary callbacks for destroying the values
added to the dictionary. This also requires prohibiting copying,
because we don't do any intelligent ref-counting -- when a Class is
destroyed, it destroys its methods and fields unconditionally.

  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): Added delete callbacks
  • bindings/runtime.cpp: Added definitions for delete callbacks (KJS::Bindings::deleteMethodList): (KJS::Bindings::deleteMethod): (KJS::Bindings::deleteField):
  • bindings/runtime.h: Added declarations for delete callbacks
3:04 PM Changeset in webkit [12834] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

3:02 PM Changeset in webkit [12833] by thatcher
  • 2 edits in tags/WebCore-521.7.2/WebCore

Build fix.

2:58 PM Changeset in webkit [12832] by hyatt
  • 2 edits in trunk/WebCore/platform/image-decoders

Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.

2:57 PM Changeset in webkit [12831] by hyatt
  • 12 edits in trunk/WebCore

Make FontFamily compile on Win32. Fix image decoder issue with frameBufferAtIndex API.

2:55 PM Changeset in webkit [12830] by thatcher
  • 1 copy in tags/WebCore-521.7.2

New tag.

2:37 PM Changeset in webkit [12829] by hyatt
  • 6 edits
    2 moves
    1 add in trunk/WebCore

Make KWQFontFamily portable. Split it out into a cross-platform core and the Mac-specific version.
Move it to platform and rename it to FontFamily (and FontFamilyMac).

Reviewed by eric

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQFont.h: (QFont::firstFamily):
  • kwq/KWQFont.mm: (QFont::setFirstFamily):
  • kwq/KWQFontFamily.h: Removed.
  • kwq/KWQFontFamily.mm: Removed.
  • platform/FontFamily.cpp: Added. (WebCore::FontFamily::FontFamily): (WebCore::FontFamily::~FontFamily): (WebCore::FontFamily::operator=): (WebCore::FontFamily::setFamily): (WebCore::FontFamily::operator==):
  • platform/FontFamily.h: Added. (WebCore::FontFamily::family): (WebCore::FontFamily::familyIsEmpty): (WebCore::FontFamily::next): (WebCore::FontFamily::appendFamily): (WebCore::FontFamily::operator!=): (WebCore::FontFamily::ref): (WebCore::FontFamily::deref):
  • platform/mac/FontFamilyMac.mm: Added. (WebCore::retainDOMStringImpl): (WebCore::releaseDOMStringImpl): (WebCore::): (WebCore::FontFamily::getNSFamily):
  • rendering/font.h: (khtml::FontDef::firstFamily):
2:30 PM Changeset in webkit [12828] by thatcher
  • 3 edits in tags/WebCore-417.19.1/WebCore

Reviewed by Beth, Geoff, Maciej.

Removed #define MALLOC_FAILURE_ACTION abort() letting malloc return NULL

Fixes <rdar://problem/4365248> *SecUpd: Tiger* SureSec si#182 safari heap overflow.
<rdar://problem/4416122> *SecUpd: Chardonnay* SureSec si#182 safari heap overflow.

  • khtml/misc/main_thread_malloc.cpp:
2:26 PM Changeset in webkit [12827] by thatcher
  • 1 copy in tags/WebCore-417.19.1

New tag.

1:54 PM Changeset in webkit [12826] by thatcher
  • 4 copies in tags/WebCore-417.22/WebCore

Correct tag.

1:54 PM Changeset in webkit [12825] by thatcher
  • 1 delete in tags/WebCore-417.22/WebCore

Redoing this tag.

1:48 PM Changeset in webkit [12824] by thatcher
  • 1 copy in tags/WebCore-417.22

New tag.

1:46 PM Changeset in webkit [12823] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning.

1:44 PM Changeset in webkit [12822] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Beth, Geoff, Maciej.

Removed #define MALLOC_FAILURE_ACTION abort() letting malloc return NULL

Fixes <rdar://problem/4365248> *SecUpd: Tiger* SureSec si#182 safari heap overflow.
<rdar://problem/4416122> *SecUpd: Chardonnay* SureSec si#182 safari heap overflow.

  • khtml/misc/main_thread_malloc.cpp:
8:36 AM Changeset in webkit [12821] by darin
  • 2 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
6:47 AM Changeset in webkit [12820] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Tim H.

Updated page to show 10.4.4 or 10.4.5
Added support for recognizing Shiira.

  • quality/reporting.html:
2:30 AM Changeset in webkit [12819] by eseidel
  • 12 edits
    8 adds in trunk

2006-02-15 Oliver Hunt <​ojh16@student.canterbury.ac.nz>

Reviewed by eseidel. Landed by eseidel.


Implemented feDisplacementMap.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5862

Test: svg/custom/feDisplacementMap-01.svg

  • WebCore.xcodeproj/project.pbxproj: added files.
  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEDisplacementMap::xChannelSelector): (WebCore::KCanvasFEDisplacementMap::setXChannelSelector): (WebCore::KCanvasFEDisplacementMap::yChannelSelector): (WebCore::KCanvasFEDisplacementMap::setYChannelSelector): (WebCore::KCanvasFEDisplacementMap::scale): (WebCore::KCanvasFEDisplacementMap::setScale):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::getVectorForChannel): (WebCore::KCanvasFEDisplacementMapQuartz::getCIFilter):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::createFilterEffect):
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.cikernel: Added.
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.h: Added.
  • kcanvas/device/quartz/filters/WKDisplacementMapFilter.m: Added. (+[WKDisplacementMapFilter initialize]): (+[WKDisplacementMapFilter filterWithName:]): (-[WKDisplacementMapFilter init]): (-[WKDisplacementMapFilter outputImage]):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: Added. (SVGFEDisplacementMapElementImpl::SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::~SVGFEDisplacementMapElementImpl): (SVGFEDisplacementMapElementImpl::in1): (SVGFEDisplacementMapElementImpl::in2): (SVGFEDisplacementMapElementImpl::xChannelSelector): (SVGFEDisplacementMapElementImpl::yChannelSelector): (SVGFEDisplacementMapElementImpl::scale): (SVGFEDisplacementMapElementImpl::stringToChannel): (SVGFEDisplacementMapElementImpl::parseMappedAttribute): (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.h: Added.
  • ksvg2/svg/svgtags.in:
1:54 AM Changeset in webkit [12818] by eseidel
  • 2 edits in trunk/LayoutTests

2006-02-15 Eric Seidel <​eseidel@apple.com>

Update missing result from last commit.

  • fast/xsl/xslt-recursion-expected.txt:
1:44 AM Changeset in webkit [12817] by mjs
  • 1 edit
    1 delete in trunk/WebKit

Rubber stamped by Anders.

  • WebView/WebControllerPolicyHandlerDelegate.h: Removed.
1:20 AM Changeset in webkit [12816] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Anders.


  • remove some voodoo code
  • WebView/WebDataSource.m: (-[WebDataSource _setLoading:]): Removed useless ref/deref of self and WebView. A WebDataSource cannot be loading unless it is still connected to the WebView that owns it and retained by it, because getting disconnected stops loading.
1:16 AM Changeset in webkit [12815] by eseidel
  • 2 edits in trunk/WebCore

2006-02-15 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Commit change forgotten after editing directory move.

  • editing/markup.cpp: (khtml::startMarkup): add support for serializing DOCTYPEs in xml

Feb 14, 2006:

9:49 PM Changeset in webkit [12814] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Maciej.

Test case: fast/encoding/percent-escaping.html

  • kwq/KWQKURL.mm: (appendEscapingBadChars): Rather than adding support for %u, remove the existing "do what I mean" escaping of percent characters that do not look like a result of prior escaping.
7:30 PM Changeset in webkit [12813] by eseidel
  • 2 edits in trunk/WebCore

2006-02-14 Eric Seidel <​eseidel@apple.com>

Fix build failure from last minute edit.

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
7:01 PM Changeset in webkit [12812] by eseidel
  • 19 edits
    3 adds in trunk

2006-02-14 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add incremental parsing support to XMLTokenizer.
This patch also does a few other little things:

  • removes (unused) onHold support from Tokenizer
  • adds serialization of DOCTYPEs for xml documents
  • fixes xslt support to no longer depend on synchronous parsing
  • fixes css styling for pages where xsl recursion is blocked ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6057
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::createProcessingInstruction): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::recalcStyleSelector):
  • dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstructionImpl::checkStyleSheet):
  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer): (WebCore::XMLTokenizer::write): (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::error): (WebCore::XMLTokenizer::initializeParserContext): (WebCore::XMLTokenizer::finish): (WebCore::xmlDocPtrForString): (WebCore::parseAttributes):
  • dom/xml_tokenizer.h:
  • khtml/editing/markup.cpp: (khtml::startMarkup): DOCTYPE serialization
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): removed onHold (WebCore::HTMLTokenizer::reset): removed onHold (WebCore::HTMLTokenizer::begin): removed onHold (WebCore::HTMLTokenizer::write): removed onHold (WebCore::HTMLTokenizer::finish): removed onHold
  • khtml/html/htmltokenizer.h: removed onHold support
  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::~XSLStyleSheetImpl): (WebCore::XSLStyleSheetImpl::document): (WebCore::XSLStyleSheetImpl::setDocument): (WebCore::XSLStyleSheetImpl::parseString): (WebCore::XSLStyleSheetImpl::loadChildSheets): (WebCore::XSLStyleSheetImpl::compileStyleSheet): (WebCore::XSLStyleSheetImpl::locateStylesheetSubResource):
  • khtml/xsl/xsl_stylesheetimpl.h: moved functions to .cpp file
6:55 PM Changeset in webkit [12811] by mjs
  • 10 edits in trunk/WebKit

Reviewed by Anders.


Improvements to frame loading:


  • remove LayoutAcceptable state entirely
  • fix WebImageView to work right without LayoutAcceptable state
  • move guts of commitIfReady: to WebFrame
  • try to separate page cache loading from normal loading a bit more
  • English.lproj/StringsNotToBeLocalized.txt:
  • WebView/WebDataSource.m: (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _startLoading]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _setupForReplaceByMIMEType:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
  • WebView/WebFramePrivate.h:
  • WebView/WebImageRepresentation.h:
  • WebView/WebImageRepresentation.m:
  • WebView/WebImageView.m: (-[WebImageView dataSourceUpdated:]): (-[WebImageView setNeedsLayout:]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView mouseDragged:]):
  • WebView/WebView.m: (-[WebView _finishedLoadingResourceFromDataSource:]): (-[WebView _mainReceivedBytesSoFar:fromDataSource:complete:]):
6:35 PM Changeset in webkit [12810] by adele
  • 9 edits
    8 adds in trunk

LayoutTests:

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields

  • fast/forms/input-appearance-width.html: Added.
  • fast/forms/input-appearance-width-expected.txt: Added.
  • fast/forms/input-appearance-width-expected.png: Added.
  • fast/forms/input-appearance-width-expected.checksum: Added.
  • fast/forms/input-appearance-minWidth.html: Added.
  • fast/forms/input-appearance-minWidth-expected.txt: Added.
  • fast/forms/input-appearance-minWidth-expected.png: Added.
  • fast/forms/input-appearance-minWidth-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6815
Calculate correct width for new text fields

Tests:
fast/forms/input-appearance-width.html
fast/forms/input-appearance-minWidth.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Remove fixed width for text field. (WebCore::RenderTextField::calcMinMaxWidth): Added. This calls RenderBlock::calcMinMaxWidth and then uses the size attribute to determine what the maxWidth should be.
  • rendering/RenderTextField.h: Added calcMinMaxWidth.
  • rendering/render_theme_mac.h: Added adjustTextFieldStyle.
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustRepaintRect): Remove inflation of rect. This is no longer necessary. (WebCore::RenderThemeMac::paintTextField): ditto. (WebCore::RenderThemeMac::setTextFieldCellState): change true to YES. (WebCore::RenderThemeMac::adjustTextFieldStyle): Added. This is the temporary home of the code to set the right padding and margins. When we flip the switch, this will go in html4.css.
6:07 PM Changeset in webkit [12809] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-14 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: added --results-directory (-o) option
5:36 PM Changeset in webkit [12808] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

removed -[DOMHTMLSelectElement _optionLabels], formerly used only by Safari, now unused.

  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMPrivate.h:
4:15 PM Changeset in webkit [12807] by thatcher
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Fixed <rdar://problem/4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh

  • JavaScriptCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""

WebCore:

Reviewed by Justin.

Fixed <rdar://problem/4415050> STD: WebCore build steps use echo -n, which will change
behavior due to POSIX version of sh

  • WebCore.xcodeproj/project.pbxproj: removed the use of echo -n, replaced with printf ""
2:42 PM Changeset in webkit [12806] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

One more of the same (this one tests list boxes instead of pop-up menus)

  • fast/forms/HTMLOptionElement_label05-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label05-expected.png: Added.
  • fast/forms/HTMLOptionElement_label05-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label05.html: Added.
2:33 PM Changeset in webkit [12805] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

Added another option element label test at Dave Hyatt's suggestion

  • fast/forms/HTMLOptionElement_label04-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label04-expected.png: Added.
  • fast/forms/HTMLOptionElement_label04-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label04.html: Added.
2:14 PM Changeset in webkit [12804] by adele
  • 1 edit
    12 moves in trunk/LayoutTests

Reviewed by Eric.

Moving these tests to a better location.

  • dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label01.html: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label02.html: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.png: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Removed.
  • dom/html/level2/html/HTMLOptionElement_label03.html: Removed.
  • fast/forms/HTMLOptionElement_label01-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label01-expected.png: Added.
  • fast/forms/HTMLOptionElement_label01-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label01.html: Added.
  • fast/forms/HTMLOptionElement_label02-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label02-expected.png: Added.
  • fast/forms/HTMLOptionElement_label02-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label02.html: Added.
  • fast/forms/HTMLOptionElement_label03-expected.checksum: Added.
  • fast/forms/HTMLOptionElement_label03-expected.png: Added.
  • fast/forms/HTMLOptionElement_label03-expected.txt: Added.
  • fast/forms/HTMLOptionElement_label03.html: Added.
1:40 PM Changeset in webkit [12803] by darin
  • 27 edits
    58 copies
    1 move
    58 deletes in trunk/WebCore

Rubber-stamped by Eric.

  • moved editing sources from khtml/editing to editing, and renamed files with single classes
  • WebCore.xcodeproj/project.pbxproj: Added new, removed old.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • dom/DocumentImpl.cpp:
  • dom/dom2_rangeimpl.cpp:
  • dom/dom_position.cpp:
  • khtml/khtml_events.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.h:
  • kwq/KWQEditCommand.mm:
  • page/Frame.cpp:
  • page/FramePrivate.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderContainer.cpp:
  • rendering/RenderText.cpp:
  • rendering/render_br.cpp:
  • rendering/render_inline.cpp:
  • rendering/render_object.cpp:
  • rendering/render_replaced.cpp: Fixed up includes.
  • editing: Added.
  • editing/AppendNodeCommand.cpp: Added.
  • editing/AppendNodeCommand.h: Added.
  • editing/ApplyStyleCommand.cpp: Added.
  • editing/ApplyStyleCommand.h: Added.
  • editing/BreakBlockquoteCommand.cpp: Added.
  • editing/BreakBlockquoteCommand.h: Added.
  • editing/CompositeEditCommand.cpp: Added.
  • editing/CompositeEditCommand.h: Added.
  • editing/DeleteFromTextNodeCommand.cpp: Added.
  • editing/DeleteFromTextNodeCommand.h: Added.
  • editing/DeleteSelectionCommand.cpp: Added.
  • editing/DeleteSelectionCommand.h: Added.
  • editing/EditCommand.cpp: Added.
  • editing/EditCommand.h: Added.
  • editing/InsertIntoTextNodeCommand.cpp: Added.
  • editing/InsertIntoTextNodeCommand.h: Added.
  • editing/InsertLineBreakCommand.cpp: Added.
  • editing/InsertLineBreakCommand.h: Added.
  • editing/InsertNodeBeforeCommand.cpp: Added.
  • editing/InsertNodeBeforeCommand.h: Added.
  • editing/InsertParagraphSeparatorCommand.cpp: Added.
  • editing/InsertParagraphSeparatorCommand.h: Added.
  • editing/InsertTextCommand.cpp: Added.
  • editing/InsertTextCommand.h: Added.
  • editing/JoinTextNodesCommand.cpp: Added.
  • editing/JoinTextNodesCommand.h: Added.
  • editing/MergeIdenticalElementsCommand.cpp: Added.
  • editing/MergeIdenticalElementsCommand.h: Added.
  • editing/MoveSelectionCommand.cpp: Added.
  • editing/MoveSelectionCommand.h: Added.
  • editing/RebalanceWhitespaceCommand.cpp: Added.
  • editing/RebalanceWhitespaceCommand.h: Added.
  • editing/RemoveCSSPropertyCommand.cpp: Added.
  • editing/RemoveCSSPropertyCommand.h: Added.
  • editing/RemoveNodeAttributeCommand.cpp: Added.
  • editing/RemoveNodeAttributeCommand.h: Added.
  • editing/RemoveNodeCommand.cpp: Added.
  • editing/RemoveNodeCommand.h: Added.
  • editing/RemoveNodePreservingChildrenCommand.cpp: Added.
  • editing/RemoveNodePreservingChildrenCommand.h: Added.
  • editing/ReplaceSelectionCommand.cpp: Added.
  • editing/ReplaceSelectionCommand.h: Added.
  • editing/Selection.cpp:
  • editing/SelectionController.cpp:
  • editing/SetNodeAttributeCommand.cpp: Added.
  • editing/SetNodeAttributeCommand.h: Added.
  • editing/SplitElementCommand.cpp: Added.
  • editing/SplitElementCommand.h: Added.
  • editing/SplitTextNodeCommand.cpp: Added.
  • editing/SplitTextNodeCommand.h: Added.
  • editing/SplitTextNodeContainingElementCommand.cpp: Added.
  • editing/SplitTextNodeContainingElementCommand.h: Added.
  • editing/TypingCommand.cpp: Added.
  • editing/TypingCommand.h: Added.
  • editing/VisiblePosition.cpp: Added.
  • editing/VisiblePosition.h: Added.
  • editing/VisibleRange.cpp: Added.
  • editing/VisibleRange.h: Added.
  • editing/WrapContentsInDummySpanCommand.cpp: Added.
  • editing/WrapContentsInDummySpanCommand.h: Added.
  • editing/append_node_command.cpp: Removed.
  • editing/append_node_command.h: Removed.
  • editing/apply_style_command.cpp: Removed.
  • editing/apply_style_command.h: Removed.
  • editing/break_blockquote_command.cpp: Removed.
  • editing/break_blockquote_command.h: Removed.
  • editing/composite_edit_command.cpp: Removed.
  • editing/composite_edit_command.h: Removed.
  • editing/delete_from_text_node_command.cpp: Removed.
  • editing/delete_from_text_node_command.h: Removed.
  • editing/delete_selection_command.cpp: Removed.
  • editing/delete_selection_command.h: Removed.
  • editing/edit_command.cpp: Removed.
  • editing/edit_command.h: Removed.
  • editing/htmlediting.cpp:
  • editing/insert_into_text_node_command.cpp: Removed.
  • editing/insert_into_text_node_command.h: Removed.
  • editing/insert_line_break_command.cpp: Removed.
  • editing/insert_line_break_command.h: Removed.
  • editing/insert_node_before_command.cpp: Removed.
  • editing/insert_node_before_command.h: Removed.
  • editing/insert_paragraph_separator_command.cpp: Removed.
  • editing/insert_paragraph_separator_command.h: Removed.
  • editing/insert_text_command.cpp: Removed.
  • editing/insert_text_command.h: Removed.
  • editing/join_text_nodes_command.cpp: Removed.
  • editing/join_text_nodes_command.h: Removed.
  • editing/jsediting.cpp:
  • editing/markup.cpp:
  • editing/merge_identical_elements_command.cpp: Removed.
  • editing/merge_identical_elements_command.h: Removed.
  • editing/move_selection_command.cpp: Removed.
  • editing/move_selection_command.h: Removed.
  • editing/rebalance_whitespace_command.cpp: Removed.
  • editing/rebalance_whitespace_command.h: Removed.
  • editing/remove_css_property_command.cpp: Removed.
  • editing/remove_css_property_command.h: Removed.
  • editing/remove_node_attribute_command.cpp: Removed.
  • editing/remove_node_attribute_command.h: Removed.
  • editing/remove_node_command.cpp: Removed.
  • editing/remove_node_command.h: Removed.
  • editing/remove_node_preserving_children_command.cpp: Removed.
  • editing/remove_node_preserving_children_command.h: Removed.
  • editing/replace_selection_command.cpp: Removed.
  • editing/replace_selection_command.h: Removed.
  • editing/set_node_attribute_command.cpp: Removed.
  • editing/set_node_attribute_command.h: Removed.
  • editing/split_element_command.cpp: Removed.
  • editing/split_element_command.h: Removed.
  • editing/split_text_node_command.cpp: Removed.
  • editing/split_text_node_command.h: Removed.
  • editing/split_text_node_containing_element.cpp: Removed.
  • editing/split_text_node_containing_element_command.h: Removed.
  • editing/typing_command.cpp: Removed.
  • editing/typing_command.h: Removed.
  • editing/visible_position.cpp: Removed.
  • editing/visible_position.h: Removed.
  • editing/visible_range.cpp: Removed.
  • editing/visible_range.h: Removed.
  • editing/visible_units.cpp:
  • editing/wrap_contents_in_dummy_span_command.cpp: Removed.
  • editing/wrap_contents_in_dummy_span_command.h: Removed.
  • khtml/editing: Removed.
  • khtml/editing/Selection.cpp: Removed.
  • khtml/editing/Selection.h: Removed.
  • khtml/editing/SelectionController.cpp: Removed.
  • khtml/editing/SelectionController.h: Removed.
  • khtml/editing/append_node_command.cpp: Removed.
  • khtml/editing/append_node_command.h: Removed.
  • khtml/editing/apply_style_command.cpp: Removed.
  • khtml/editing/apply_style_command.h: Removed.
  • khtml/editing/break_blockquote_command.cpp: Removed.
  • khtml/editing/break_blockquote_command.h: Removed.
  • khtml/editing/composite_edit_command.cpp: Removed.
  • khtml/editing/composite_edit_command.h: Removed.
  • khtml/editing/delete_from_text_node_command.cpp: Removed.
  • khtml/editing/delete_from_text_node_command.h: Removed.
  • khtml/editing/delete_selection_command.cpp: Removed.
  • khtml/editing/delete_selection_command.h: Removed.
  • khtml/editing/edit_actions.h: Removed.
  • khtml/editing/edit_command.cpp: Removed.
  • khtml/editing/edit_command.h: Removed.
  • khtml/editing/html_interchange.cpp: Removed.
  • khtml/editing/html_interchange.h: Removed.
  • khtml/editing/htmlediting.cpp: Removed.
  • khtml/editing/htmlediting.h: Removed.
  • khtml/editing/insert_into_text_node_command.cpp: Removed.
  • khtml/editing/insert_into_text_node_command.h: Removed.
  • khtml/editing/insert_line_break_command.cpp: Removed.
  • khtml/editing/insert_line_break_command.h: Removed.
  • khtml/editing/insert_node_before_command.cpp: Removed.
  • khtml/editing/insert_node_before_command.h: Removed.
  • khtml/editing/insert_paragraph_separator_command.cpp: Removed.
  • khtml/editing/insert_paragraph_separator_command.h: Removed.
  • khtml/editing/insert_text_command.cpp: Removed.
  • khtml/editing/insert_text_command.h: Removed.
  • khtml/editing/join_text_nodes_command.cpp: Removed.
  • khtml/editing/join_text_nodes_command.h: Removed.
  • khtml/editing/jsediting.cpp: Removed.
  • khtml/editing/jsediting.h: Removed.
  • khtml/editing/markup.cpp: Removed.
  • khtml/editing/markup.h: Removed.
  • khtml/editing/merge_identical_elements_command.cpp: Removed.
  • khtml/editing/merge_identical_elements_command.h: Removed.
  • khtml/editing/move_selection_command.cpp: Removed.
  • khtml/editing/move_selection_command.h: Removed.
  • khtml/editing/rebalance_whitespace_command.cpp: Removed.
  • khtml/editing/rebalance_whitespace_command.h: Removed.
  • khtml/editing/remove_css_property_command.cpp: Removed.
  • khtml/editing/remove_css_property_command.h: Removed.
  • khtml/editing/remove_node_attribute_command.cpp: Removed.
  • khtml/editing/remove_node_attribute_command.h: Removed.
  • khtml/editing/remove_node_command.cpp: Removed.
  • khtml/editing/remove_node_command.h: Removed.
  • khtml/editing/remove_node_preserving_children_command.cpp: Removed.
  • khtml/editing/remove_node_preserving_children_command.h: Removed.
  • khtml/editing/replace_selection_command.cpp: Removed.
  • khtml/editing/replace_selection_command.h: Removed.
  • khtml/editing/set_node_attribute_command.cpp: Removed.
  • khtml/editing/set_node_attribute_command.h: Removed.
  • khtml/editing/split_element_command.cpp: Removed.
  • khtml/editing/split_element_command.h: Removed.
  • khtml/editing/split_text_node_command.cpp: Removed.
  • khtml/editing/split_text_node_command.h: Removed.
  • khtml/editing/split_text_node_containing_element.cpp: Removed.
  • khtml/editing/split_text_node_containing_element_command.h: Removed.
  • khtml/editing/text_affinity.h: Removed.
  • khtml/editing/text_granularity.h: Removed.
  • khtml/editing/typing_command.cpp: Removed.
  • khtml/editing/typing_command.h: Removed.
  • khtml/editing/visible_position.cpp: Removed.
  • khtml/editing/visible_position.h: Removed.
  • khtml/editing/visible_range.cpp: Removed.
  • khtml/editing/visible_range.h: Removed.
  • khtml/editing/visible_text.cpp: Removed.
  • khtml/editing/visible_text.h: Removed.
  • khtml/editing/visible_units.cpp: Removed.
  • khtml/editing/visible_units.h: Removed.
  • khtml/editing/wrap_contents_in_dummy_span_command.cpp: Removed.
  • khtml/editing/wrap_contents_in_dummy_span_command.h: Removed.
1:40 PM Changeset in webkit [12802] by sullivan
  • 1 edit
    12 adds in trunk/LayoutTests

Reviewed by Adele Peterson.


  • dom/html/level2/html/HTMLOptionElement_label01-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label01-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label01.html: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label02-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label02.html: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.checksum: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.png: Added.
  • dom/html/level2/html/HTMLOptionElement_label03-expected.txt: Added.
  • dom/html/level2/html/HTMLOptionElement_label03.html: Added.
1:39 PM Changeset in webkit [12801] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.



Test cases:

  • dom/html/level2/html/HTMLOptionElement_label01.html
  • dom/html/level2/html/HTMLOptionElement_label02.html
  • dom/html/level2/html/HTMLOptionElement_label03.html
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): use label attribute, if present, when setting text on the widget.
1:18 PM Changeset in webkit [12800] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Change formatting in this file to match the style guidelines. No spaces after
opening parentheses or before closing parentheses.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::createDocumentFragment): (WebCore::DocumentImpl::recalcStyle): (WebCore::DocumentImpl::attach): (WebCore::DocumentImpl::detach): (WebCore::DocumentImpl::open): (WebCore::DocumentImpl::write): (WebCore::DocumentImpl::writeln): (WebCore::DocumentImpl::setUserStyleSheet): (WebCore::DocumentImpl::determineParseMode): (WebCore::DocumentImpl::processHttpEquiv): (WebCore::DocumentImpl::childAllowed): (WebCore::DocumentImpl::childTypeAllowed): (WebCore::DocumentImpl::recalcStyleSelector): (WebCore::DocumentImpl::dispatchImageLoadEventsNow): (WebCore::DocumentImpl::domain): (WebCore::DocumentImpl::setDomain): (WebCore::DocumentImpl::parseQualifiedName): (WebCore::DocumentImpl::addMarker): (WebCore::DocumentImpl::removeMarkers):
11:13 AM Changeset in webkit [12799] by sullivan
  • 10 edits
    1 add in trunk/WebCore

Reviewed by Tim Hatcher.

Some cleanup from the previous checkin, inspired by Darin's comments


  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: moved highlightAllMatchesForString out of here


  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]): now converts NSString to QString here, rather than in Frame/MacFrame


  • dom/DocumentMarker.h: Added. (WebCore::DocumentMarker::): (WebCore::DocumentMarker::operator == ): (WebCore::DocumentMarker::operator != ): moved this struct to its own header file


  • dom/DocumentImpl.h: moved DocumentMarker out; now includes DocumentMarker.h


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): moved here from MacFrame.[h,mm]. I thought this used other code from MacFrame.mm but it doesn't.


  • rendering/InlineTextBox.h: removed unnecesssary variable names; use DocumentMarker::MarkerType in signature of paintAllMarkersOfType
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paintTextMatchMarker): better name for a variable, fixed bad indent (khtml::InlineTextBox::paintAllMarkersOfType): rewrote loop to bail out early if past end, for clarity; use DocumentMarker::MarkerType in signature


  • WebCore.xcodeproj/project.pbxproj: updated for new file
10:09 AM Changeset in webkit [12798] by thatcher
  • 5 edits in tags/WebCore-521.7.1/WebCore

Merge the build fixes for case-sensitive drives to the tag. The #include "String.h" does not fail on normal HFS+ drives. Bump version to 521.7.1.

10:04 AM Changeset in webkit [12797] by thatcher
  • 1 copy in tags/WebCore-521.7.1/WebCore

New tag.

10:04 AM Changeset in webkit [12796] by thatcher
  • 1 add in tags/WebCore-521.7.1

New tag.

10:01 AM Changeset in webkit [12795] by thatcher
  • 3 edits in trunk/WebCore

More build fixes for case-sensitive drives. The #include "String.h" does not fail on normal HFS+ drives.

9:55 AM Changeset in webkit [12794] by thatcher
  • 1 edit in trunk/WebCore/loader/DocLoader.h

Build fix for case-sensitive drives.

8:57 AM Changeset in webkit [12793] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Tim Omernick.

Support for highlighting multiple text matches.

  • WebView/WebHTMLViewPrivate.h:
  • WebView/WebHTMLView.m: (-[WebHTMLView highlightAllMatchesForString:caseSensitive:]): new method, calls through to bridge (-[WebHTMLView clearHighlightedMatches]): ditto
  • WebView/WebViewPrivate.h:
  • WebView/WebView.m: (-[WebView highlightAllMatchesForString:caseSensitive:]): new method, calls through to documentView. For now this is hardwired to only work with WebHTMLViews. (-[WebView clearHighlightedMatches]): ditto
8:57 AM Changeset in webkit [12792] by sullivan
  • 8 edits in trunk/WebCore

Reviewed by Tim Omernick.

Support for highlighting multiple text matches.

  • dom/DocumentImpl.h: (WebCore::DocumentMarker::): Added new marker type TextMatch
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]): new method, calls through to MacFrame implementation (-[WebCoreFrameBridge clearHighlightedMatches]): new method, removes all markers of type TextMatch
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::highlightAllMatchesForString): new method, adds a document marker for each range that matches the given string
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): Moved DocumentMarker loop into separate method paintAllMarkersOfType. We now call that method twice, once for spelling markers (after drawing text) and once for text match markers (before drawing text) (khtml::InlineTextBox::paintTextMatchMarker): new method, paints a color behind a text match marker (khtml::InlineTextBox::paintSpellingMarker): renamed from paintMarker (khtml::InlineTextBox::paintAllMarkersOfType): new method, loops through all DocumentMarkers of a particular type and calls the appropriate painting method for each one
Note: See TracTimeline for information about the timeline view.