⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 18, 2006:

7:37 PM Changeset in webkit [12892] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix win32 build
  • css/css_grammar.y:
  • khtml/html/html_objectimpl.cpp: #ifdef out all bindings code (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl): (WebCore::HTMLAppletElementImpl::detach): (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl): (WebCore::HTMLEmbedElementImpl::detach): (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl): (WebCore::HTMLObjectElementImpl::detach):
  • khtml/html/html_objectimpl.h:
5:34 PM Changeset in webkit [12891] by darin
  • 4 edits in trunk/WebKitSite

Reviewed by Darin.

Fixed Bugzilla URL's


  • projects/forms/index.html:
  • projects/html/index.html:
  • projects/xslt/index.html:
5:31 PM Changeset in webkit [12890] by darin
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Test: fast/js/toString-exception.html

Reviewed by Maciej.

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Remove the object from the visited elements set before returning an error.

LayoutTests:

Reviewed by Maciej.

  • fast/js/resources/toString-exception.js: Added.
  • fast/js/toString-exception-expected.txt: Added.
  • fast/js/toString-exception.html: Added.
5:24 PM Changeset in webkit [12889] by darin
  • 3 edits in trunk/WebKitSite

Reviewed by Darin.

Made line-height global instead of just for p

Editing:
fixed bugzilla link, added starting <p> to first paragraph
removed paragraph about tab-stops

  • css/main.css:
  • projects/editing/index.html:
4:21 PM Changeset in webkit [12888] by lypanov
  • 3 edits
    4 adds in trunk

2006-02-18 Alexander Kellett <​lypanov@kde.org>

Reviewed by Maciej.

Testcase:

svg/custom/text-gradient-no-content.svg

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::teardown):

2006-02-18 Alexander Kellett <​lypanov@kde.org>

Reviewed by Maciej.

  • svg/custom/text-gradient-no-content.svg: Added.
4:20 PM Changeset in webkit [12887] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/commit-log-editor: Added.
3:48 PM Changeset in webkit [12886] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kxmlcore/Vector.h: Added "moveOverlapping", which is used in both insert and remove to slide elements within the vector. Also added "insert" and "remove" functions.
10:55 AM Changeset in webkit [12885] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/4448212> _accessibilityTableCell please remove this.

Remove override of a defamed AX method.

  • kwq/KWQListBox.mm: Dump _accessibilityTableCell.
12:21 AM Changeset in webkit [12884] by mjs
  • 4 edits in trunk/WebKit

Not reviewed.


  • fix build broken by my last checkin, the remaining code was not doing anything.
  • WebView/WebDataSource.m:
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _createPageCacheForItem:]):

Feb 17, 2006:

9:47 PM Changeset in webkit [12883] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/ex-after-font-variant-expected.checksum: Added.
  • fast/css/ex-after-font-variant-expected.png: Added.
  • fast/css/ex-after-font-variant-expected.txt: Added.
  • fast/css/ex-after-font-variant.html: Added.

WebCore:

Test: fast/css/ex-after-font-variant.html

Reviewed by Darin.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): Added CSS_PROP_FONT_VARIANT to the properties that need to be applied first, since it dirties the font.
9:14 PM Changeset in webkit [12882] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Darin.


  • removed a few unused fields and methods of WebDataSource
  • WebView/WebDataSource.m:
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebView.m: (+[WebView _MIMETypeForFile:]): (-[WebView _updateWebCoreSettingsFromPreferences:]):
4:15 PM Changeset in webkit [12881] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Make Win32 have the same default "WebKitBuild" directory behavior.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
4:06 PM Changeset in webkit [12880] by darin
  • 2 edits in trunk/WebKitSite
  • coding/coding-style.html: Mention other non-function brace cases.
3:48 PM Changeset in webkit [12879] by justing
  • 1 edit
    1 add
    1 delete in trunk/LayoutTests

Reviewed by eric


This test appears to be occasionally hanging. Disabling it while
I figure out why.

  • editing/selection/drag-to-contenteditable-iframe.html: Removed.
  • editing/selection/drag-to-contenteditable-iframe.html-disabled: Added.
3:36 PM Changeset in webkit [12878] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by Beth.

  • Scripts/build-webkit: make win32 actually report errors
3:08 PM Changeset in webkit [12877] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: Ignore quicktime plugin leaks
2:49 PM Changeset in webkit [12876] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-17 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: Ignore flash leaks
2:18 PM Changeset in webkit [12875] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Tim H.

Added left position and margin-bottom to blog footer.

  • css/main.css:
11:15 AM Changeset in webkit [12874] by adele
  • 3 edits in trunk/WebCore

Reviewed by Beth.

Adding isEdited/setEdited hooks so onChange will fire for the new text fields.

  • rendering/RenderTextField.cpp: (WebCore::m_dirty): (WebCore::RenderTextField::updateFromElement): setEdited to false when value attribute has changed. (WebCore::RenderTextField::subtreeHasChanged): setEdited to true when anonymous editable div has changed.
  • rendering/RenderTextField.h: (WebCore::RenderTextField::isEdited): (WebCore::RenderTextField::setEdited): (WebCore::RenderTextField::isTextField):
10:31 AM Changeset in webkit [12873] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

  • Fixed <rdar://problem/4448534> TOT REGRESSION: crash in KJS:: Bindings::Instance::deref when leaving page @ gigaom.com
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::~CInstance): Since we cache the class object globally, we shouldn't delete it, so don't.
1:54 AM Changeset in webkit [12872] by vicki
  • 7 edits in trunk/WebCore

Reviewed by Justin.


Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
  • rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
  • rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
  • rendering/render_replaced.h: Remove handleFocusOut().
  • rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.
1:49 AM Changeset in webkit [12871] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders Carlsson.

  • fast/parser/nofoo-tags-inside-paragraph-expected.checksum: Added.
  • fast/parser/nofoo-tags-inside-paragraph-expected.png: Added.
  • fast/parser/nofoo-tags-inside-paragraph-expected.txt: Added.
  • fast/parser/nofoo-tags-inside-paragraph.html: Added.

WebCore:

Test: fast/parser/nofoo-tags-inside-paragraph.html

Reviewed by Anders Carlsson.

  • khtml/html/htmlparser.cpp: (HTMLParser::isInline): Treat noframes, nolayer, noembed and skipped noscript as inline elements.
1:43 AM Changeset in webkit [12870] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Hyatt.

  • manual-tests/bugzilla-7235.html: Added.
  • rendering/render_box.cpp: (WebCore::RenderBox::absolutePosition): Copied in here the logic for positioning relative to a relpositioned inline from RenderLayer::updateLayerPosition. (WebCore::RenderBox::computeAbsoluteRepaintRect): Ditto.
1:37 AM Changeset in webkit [12869] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/css/universal-hover-quirk-expected.checksum: Added.
  • fast/css/universal-hover-quirk-expected.png: Added.
  • fast/css/universal-hover-quirk-expected.txt: Added.
  • fast/css/universal-hover-quirk.html: Added.

WebCore:

Test: fast/css/universal-hover-quirk.html

Reviewed by Maciej.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Prevent *:hover and *:active from matching anything in quirks mode.
1:31 AM Changeset in webkit [12868] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline.html: Added.

WebCore:

Test: fast/text/whitespace/pre-wrap-spaces-after-newline.html

Reviewed by Dave Hyatt.

  • rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Use previousLineBrokeCleanly instead of resetBidiAtEnd now that the former is always correct. (khtml::RenderBlock::layoutInlineChildren): Use new skipTrailingNewline flag. (khtml::RenderBlock::findNextLineBreak): Set previousLineBrokeCleanly for line breaks caused by newlines as well. Added skipTrailingNewline flag.
12:02 AM Changeset in webkit [12867] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4193286> enabledPlugin returns a non-NULL object even when plugins are
disabled (4140)

  • khtml/ecma/kjs_navigator.cpp: (KJS::MimeType::getValueProperty): Only return a Plugin object for the "enabledPlugin" property if plugins are enabled. This matches what other browsers do.
Note: See TracTimeline for information about the timeline view.