Timeline
Feb 22, 2006:
- 11:09 PM Changeset in webkit [12942] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Eric.
- Scripts/run-webkit-tests: Put Apache log files in the right directory.
- 8:10 PM Changeset in webkit [12941] by
-
- 2 edits in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
Reviewed by Tim Hatcher.
Fix install-win-extras to not try to re-install setx if installed.
- Scripts/install-win-extras:
- 7:52 PM Changeset in webkit [12940] by
-
- 3 edits in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
One more file possibly missing from previous commit?
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb:
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
- 7:38 PM Changeset in webkit [12939] by
-
- 3 edits in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
Reviewed by justing.
Files missing from previous commit.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
- 7:27 PM Changeset in webkit [12938] by
-
- 2 edits in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
Rubber-stamped by justing.
Corrected path for DumpRenderTree.intermediate files
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
- 7:14 PM Changeset in webkit [12937] by
-
- 2 edits in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
Reviewed by justing.
Fixed build-dumprendertree to exit with correct error codes.
- Scripts/build-dumprendertree:
- 6:49 PM Changeset in webkit [12936] by
-
- 5 edits in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
Reviewed by justing.
Update build scripts to generalize building on Win32, and allow
building of DumpRenderTree on Win32 from build-dumprendertree.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main):
- Scripts/build-dumprendertree:
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
- 5:34 PM Changeset in webkit [12935] by
-
- 15 adds in branches/Safari-1-3-branch
Fixing binary files messed up by cvs2svn.
- 4:56 PM Changeset in webkit [12934] by
-
- 2 edits7 adds in trunk/WebKitTools
2006-02-22 Eric Seidel <eseidel@apple.com>
Reviewed by hyatt.
- DumpRenderTree/DumpRenderTree.vcproj: Added.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Added.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Added.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Added.
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (_tmain):
- DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
- Scripts/build-webkit: make build-webkit cleanup after itself
- 4:36 PM Changeset in webkit [12933] by
-
- 2 edits2 adds in trunk/WebCore
2006-02-22 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
Adding stub FrameWin class to expose link errors.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/FrameWin.cpp: Added.
- bridge/win/FrameWin.h: Added. (WebCore::Win):
- 4:33 PM Changeset in webkit [12932] by
-
- 37 edits2 moves1 add1 delete in trunk/WebCore
Reviewed by Geoff.
- move QStringList to platform, make it portable
- ForwardingHeaders/qstringlist.h: Removed.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/DocumentImpl.h:
- kcanvas/KCanvasFilters.h:
- khtml/xbl/xbl_protohandler.cpp:
- ksvg2/svg/SVGColorImpl.cpp:
- ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
- ksvg2/svg/SVGDOMImplementationImpl.h:
- ksvg2/svg/SVGFEBlendElementImpl.cpp:
- ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
- ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
- ksvg2/svg/SVGFECompositeElementImpl.cpp:
- ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
- ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
- ksvg2/svg/SVGFEFloodElementImpl.cpp:
- ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
- ksvg2/svg/SVGFELightElementImpl.cpp:
- ksvg2/svg/SVGFEMergeElementImpl.cpp:
- ksvg2/svg/SVGFEOffsetElementImpl.cpp:
- ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
- ksvg2/svg/SVGFETileElementImpl.cpp:
- ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
- ksvg2/svg/SVGFitToViewBoxImpl.cpp:
- ksvg2/svg/SVGLengthListImpl.cpp:
- ksvg2/svg/SVGNumberListImpl.cpp:
- ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
- ksvg2/svg/SVGStringListImpl.cpp:
- ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
- ksvg2/svg/SVGTransformableImpl.cpp:
- kwq/KWQClipboard.mm:
- kwq/KWQKConfigBase.mm:
- kwq/KWQKHTMLSettings.h:
- kwq/KWQKLocale.h:
- kwq/KWQKSSLKeyGen.h:
- kwq/KWQStringList.h: Removed.
- kwq/KWQStringList.mm: Removed.
- loader/DocLoader.h:
- page/Frame.h:
- platform/QStringList.cpp: Added. (QStringList::split): (QStringList::pop_front):
- platform/QStringList.h: Added.
- platform/mac/QStringListMac.mm: Added. (QStringList::getNSArray):
Feb 21, 2006:
- 10:10 PM Changeset in webkit [12931] by
-
- 7 edits1 add in trunk
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7409 Some minor fixes to http tests.
LayoutTests:
- http/conf/httpd.conf: don't define CustomLog and ErrorLog - these are now passed from run-webkit-tests.
- http/tests/favicon.ico: Added.
- http/tests/incremental/slow-utf8-text.text: Remove an unused variable,
- http/tests/incremental/split-hex-entities.html: Ditto.
- http/tests/xmlhttprequest/interactive-state.cgi: Ditto.
WebKitTools:
- Scripts/run-webkit-tests: Pass CustomLog and ErrorLog directives to httpd.
- 4:55 PM Changeset in webkit [12930] by
-
- 3 edits in trunk/WebKit
Reviewed by Darin.
Backed out my previous check in. Since these methods are internal to WebKit (and not private)
it's perfectly OK for them to remain as categories.
- ChangeLog:
- WebView/WebPreferences.m: (-[WebPreferences _integerValueForKey:]): (-[WebPreferences _setIntegerValue:forKey:]): (-[WebPreferences _floatValueForKey:]): (-[WebPreferences _setFloatValue:forKey:]): (-[WebPreferences _boolValueForKey:]): (-[WebPreferences _setBoolValue:forKey:]):
- WebView/WebPreferencesPrivate.h:
- 3:49 PM Changeset in webkit [12929] by
-
- 3 edits8 adds in trunk
Reviewed by Hyatt.
- Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7330 baselinePosition is wrong for new text field when empty
- fast/forms/input-baseline-expected.checksum: Added.
- fast/forms/input-baseline-expected.png: Added.
- fast/forms/input-baseline-expected.txt: Added.
- fast/forms/input-baseline.html: Added.
- fast/inline-block/contenteditable-baseline-expected.checksum: Added.
- fast/inline-block/contenteditable-baseline-expected.png: Added.
- fast/inline-block/contenteditable-baseline-expected.txt: Added.
- fast/inline-block/contenteditable-baseline.html: Added.
Reviewed by Hyatt.
Tests:
- fast/forms/input-baseline.html
- fast/inline-block/contenteditable-baseline.html
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7330 baselinePosition is wrong for new text field when empty
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): If we're dealing with an empty contenteditable block, then we've added height to the block to make room for the caret, and there are no children to give us the baseline. Instead, compute the baseline for the block itself, and factor in the border and the padding.
- 2:55 PM Changeset in webkit [12928] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7363 REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail
Add a nil check for the renderer, and refetch the renderer for the old focus node
after dispatching the event.
- dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode):
- 2:19 PM Changeset in webkit [12927] by
-
- 2 edits1 add in trunk/JavaScriptCore
2006-02-21 Eric Seidel <eseidel@apple.com>
Reviewed by ggaren.
Add grammarWrapper.cpp to work around visual studio bug plaguing buildbot.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Added.
- 1:51 PM Changeset in webkit [12926] by
-
- 3 edits in trunk/WebKit
Reviewed by Timo O.
Moved these (already private) methods into the private WebPreferences header.
Slightly better style than sprinkling the code with categories.
- WebView/WebPreferences.m: (-[WebPreferences _integerValueForKey:]): Moved to WebPreferences (WebPrivate). (-[WebPreferences _floatValueForKey:]): Ditto. (-[WebPreferences _boolValueForKey:]): Ditto. (-[WebPreferences _setBoolValue:forKey:]): Ditto. (-[WebPreferences _setFloatValue:forKey:]): Ditto. (-[WebPreferences _setIntegerValue:forKey:]): Ditto.
- WebView/WebPreferencesPrivate.h: Added the above methods.
- 11:34 AM Changeset in webkit [12925] by
-
- 2 edits in trunk/WebKitSite
Accidentally wrote "Release" instead of "Debug" in my last patch.
- quality/leakhunting.html:
- 11:17 AM Changeset in webkit [12924] by
-
- 2 edits in trunk/JavaScriptCore
2006-02-21 Eric Seidel <eseidel@apple.com>
Reviewed by ggaren.
- kjs/testkjs.cpp: #if out timeval code on win32
- 11:12 AM Changeset in webkit [12923] by
-
- 3 edits38 adds in trunk
Reviewed by Darin.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6197 Would like to use locally installed Apache for testing.
Added two run-webkit-tests options:
--http (--nohttp) - whether to launch Apache (defaults to yes);
--port - which port to listen on (defaults to 8000).
Tests in LayoutTests/http are not run directly, and Apache is used instead.
For example, http/tests/xmlhttprequest/post-content-type.html is loaded as
http://127.0.0.1:8000/xmlhttprequest/post-content-type.html.
Also added support for .shtml and .text files. Text files give an empty
*-expected.txt, but a correct image.
Apache only listens on the loopback interface. It writes logs to /tmp/WebKit.
- Scripts/run-webkit-tests:
- 9:04 AM Changeset in webkit [12922] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7397 TCPageMap.h would not compile for me because string.h was missing
- kxmlcore/TCPageMap.h: Added <string.h> include.
- 8:57 AM Changeset in webkit [12921] by
-
- 27 edits in trunk/JavaScriptCore
Reviewed by John Sullivan.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7404 remove a bunch of extra implementsCall overrides
- JavaScriptCore.xcodeproj/project.pbxproj: Sorted files.
- kjs/internal.h: Made InternalFunctionImp::callAsFunction pure virtual so that we'll get a compile error if some derived class neglects to implement it.
- kjs/function.cpp: (KJS::FunctionImp::FunctionImp): Remove unneeded initialization of param, which is an OwnPtr so it gets initialized by default.
- bindings/runtime_method.cpp:
- bindings/runtime_method.h:
- kjs/array_object.cpp:
- kjs/array_object.h:
- kjs/bool_object.cpp:
- kjs/bool_object.h:
- kjs/date_object.cpp:
- kjs/date_object.h:
- kjs/error_object.cpp:
- kjs/error_object.h:
- kjs/function.cpp:
- kjs/function.h:
- kjs/function_object.cpp:
- kjs/function_object.h:
- kjs/math_object.cpp:
- kjs/math_object.h:
- kjs/number_object.cpp:
- kjs/number_object.h:
- kjs/object_object.cpp:
- kjs/object_object.h:
- kjs/regexp_object.cpp:
- kjs/regexp_object.h:
- kjs/string_object.cpp:
- kjs/string_object.h: Removed many rendundant implementations of implementsCall from subclasses of InternalFunctionImp.
- 8:09 AM Changeset in webkit [12920] by
-
- 2 edits in trunk/WebKitTools
Suggested by Mark Rowe.
- Scripts/run-webkit-tests: Don't include the number of excluded leaks when reporting leak counts.
- 7:29 AM Changeset in webkit [12919] by
-
- 2 edits in trunk/JavaScriptCore
- fixed build
- kjs/internal.cpp: (KJS::InternalFunctionImp::implementsCall): Oops, fixed name.
- 7:19 AM Changeset in webkit [12918] by
-
- 3 edits in trunk/JavaScriptCore
Change suggested by Mitz.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7402 REGRESSION: Methods do not execute
- kjs/internal.h: Add implementsHasCall to InternalFunctionImp.
- kjs/internal.cpp: (KJS::InternalFunctionImp::implementsHasCall): Return true. All the classes derived from InternalFunctionImp need to return true from this -- later we can remove all the extra implementations too.
- 2:15 AM Changeset in webkit [12917] by
-
- 11 edits in trunk/WebCore
Rubber Stamped by Hyatt.
- renamed STATIC, FIXED, RELATIVE, ABSOLUTE to StaticPosition, FixedPosition, etc
This avoids conflicting with win32 headers.
- css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
- editing/htmlediting.cpp: (WebCore::isSpecialElement):
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
- rendering/render_box.cpp: (WebCore::RenderBox::setStyle): (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::computeAbsoluteRepaintRect):
- rendering/render_flow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect):
- rendering/render_layer.cpp: (WebCore::RenderLayer::convertToLayerCoords): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects):
- rendering/render_object.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::setStyle): (WebCore::RenderObject::container):
- rendering/render_style.cpp: (WebCore::RenderStyle::diff):
- rendering/render_style.h: (khtml::): (khtml::RenderStyle::initialPosition):
- 1:59 AM Changeset in webkit [12916] by
-
- 2 edits in trunk/WebCore
Rubber Stamped by Hyatt.
- remove KWQSignalStubs.cpp from project.
- WebCore.vcproj/WebCore/WebCore.vcproj:
- 1:23 AM Changeset in webkit [12915] by
-
- 2 edits in trunk/WebCore
Platform build fix, not reviewed.
- undef min and max, and include <algorithm> so std::min works
- rendering/font.h:
- 12:56 AM Changeset in webkit [12914] by
-
- 2 edits in trunk/JavaScriptCore
- fix build breakage caused by last-minute change to my patch
- kjs/lookup.h:
- 12:21 AM Changeset in webkit [12913] by
-
- 8 edits in trunk
LayoutTests:
Reviewed by Geoff and Darin.
Patch from Maks Orlovich, based on work by David Faure, hand-applied and
significantly reworked by me.
- Patch: give internal function names (KJS merge) http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
Updated test results, now showing correct function string.
- fast/dom/xmlhttprequest-get-expected.txt:
- fast/js/kde/function-expected.txt:
- fast/js/kde/inbuilt_function_tostring-expected.txt:
WebCore:
Reviewed by Geoff and Darin.
Patch from Maks Orlovich, based on work by David Faure, hand-applied and
significantly reworked by me.
- Patch: give internal function names (KJS merge) http://bugzilla.opendarwin.org/show_bug.cgi?id=6279
- khtml/ecma/kjs_binding.h:
- khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::HTMLElementFunction):
- kwq/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame functionName]):