⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 23, 2006:

11:16 PM Changeset in webkit [12962] by mjs
  • 6 edits in trunk/WebCore
  • fix build by making some pointless changes to files that Xcode doesn't rebuild otherwise
  • bindings/js/JSDOMCore.cpp:
  • bindings/js/JSDOMEvents.cpp:
  • dom/Element.idl:
  • dom/WheelEvent.idl:


  • add -Y 3 flag to linking; this makes the linker say what files reference unresolved symbols


  • WebCore.xcodeproj/project.pbxproj:
10:29 PM Changeset in webkit [12961] by darin
  • 2 edits in trunk/JavaScriptCore
  • try to fix buildbot failure
  • bindings/c/c_utility.cpp: Touch this file, which seems to not have been recompiled after additional inlining was introduced (Xcode bug?).
9:37 PM Changeset in webkit [12960] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.
9:32 PM Changeset in webkit [12959] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs
  • remove unused forwarding headers
  • ForwardingHeaders/kurl.h: Removed.
  • ForwardingHeaders/qlist.h: Removed.
  • ForwardingHeaders/qregion.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
9:23 PM Changeset in webkit [12958] by darin
  • 24 edits
    2 moves
    1 add
    4 deletes in trunk/WebCore

Reviewed by Maciej.

  • removed QPalette, QRegion, QPrinter
  • added Path to replace QRegion
  • removed unused QScrollView functions
  • ForwardingHeaders/qpalette.h: Removed.
  • kwq/KWQPalette.h: Removed.
  • kwq/KWQPalette.mm: Removed.
  • kwq/KWQPrinter.h: Removed.
  • kwq/KWQRegion.cpp: Removed.
  • kwq/KWQRegion.h: Removed.
  • platform/Path.h: Added. Replaces QRegion.
  • platform/cg: Added.
  • platform/cg/PathCG.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h. (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
  • bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path. (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
  • khtml/html/html_imageimpl.h: Ditto.
  • kwq/KWQPainter.mm: Removed use of QRegion.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Ditto. (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.
  • kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(), hasHorizontalScrollBar(), childX(), childY().
  • kwq/KWQScrollView.mm: Ditto.
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): Removed use of QPalette that always yields white.
  • rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations): Ditto.
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: Removed palette() and setPalette().
  • kwq/KWQLineEdit.h: Replaced setPalette with setColors.
  • kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette. (WebCore::RenderLineEdit::updateFromElement): Added call to setColors. (WebCore::RenderTextArea::updateFromElement): Ditto.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint): Removed use of childX and childY functions.
9:10 PM Changeset in webkit [12957] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/KURL.cpp:
9:01 PM Changeset in webkit [12956] by mjs
  • 2 edits in trunk/WebCore
  • fix build (header name changed)
  • platform/mac/KURLMac.mm:
8:34 PM Changeset in webkit [12955] by mjs
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Eric.

This gets rid of a couple hundred link errors.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQSignal.h: (KWQSignal::KWQSignal):
  • platform/win/TemporaryLinkStubs.cpp: Added. (notImplemented): (QLineEdit::selectAll): (WebCore::QPainter::save): (WebCore::Widget::enableFlushDrawing): (WebCore::QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (QLineEdit::cursorPosition): (WebCore::QPainter::setPen): (WebCore::QPainter::selectedTextBackgroundColor): (WebCore::QPainter::fontMetrics): (WebCore::Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (WebCore::iBeamCursor): (QComboBox::clear): (WebCore::QPainter::misspellingLineThickness): (QLineEdit::maxLength): (WebCore::westResizeCursor): (WebCore::Widget::isEnabled): (WebCore::northWestResizeCursor): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (WebCore::QPainter::drawEllipse): (WebCore::southWestResizeCursor): (QTextEdit::setReadOnly): (QListBox::appendItem): (WebCore::Widget::focusPolicy): (QTextEdit::selectAll): (WebCore::waitCursor): (WebCore::QPainter::endTransparencyLayer): (QScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (WebCore::Widget::~Widget): (QListBox::sizeForNumberOfLines): (QScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (WebCore::FrameView::updateBorder): (QLineEdit::hasSelectedText): (QListBox::doneAppendingItems): (QScrollView::inWindow): (QScrollBar::setValue): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (QScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (WebCore::QPainter::drawLineForText): (QObject::disconnect): (WebCore::QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::clearShadow): (QTextEdit::setLineHeight): (QMouseEvent::QMouseEvent): (WebCore::eastResizeCursor): (QScrollBar::setKnobProportion): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (WebCore::QPainter::beginTransparencyLayer): (WebCore::northEastResizeCursor): (WebCore::Widget::frameGeometry): (QListBox::setSelected): (WebCore::QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (WebCore::QPainter::restore): (QFontMetrics::width): (WebCore::Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (QScrollView::setStaticBackground): (WebCore::QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (WebCore::Widget::palette): (WebCore::QPainter::pen): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (WebCore::crossCursor): (WebCore::Widget::setIsSelected): (WebCore::handCursor): (QLineEdit::text): (WebCore::Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (WebCore::QPainter::paintingDisabled): (WebCore::northResizeCursor): (QComboBox::QComboBox): (QSlider::setMaxValue): (WebCore::Widget::lockDrawingFocus): (WebCore::QPainter::drawLine): (WebCore::QPainter::setBrush): (QTextEdit::setSelectionRange): (WebCore::QPainter::drawText): (QScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (WebCore::Cursor::~Cursor): (QFontMetrics::selectionRectForText): (WebCore::southResizeCursor): (QScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (WebCore::moveCursor): (WebCore::FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (QComboBox::baselinePosition): (QComboBox::appendItem): (WebCore::helpCursor): (QTextEdit::setWritingDirection): (WebCore::Widget::setDrawingAlpha): (QSlider::QSlider): (WebCore::southEastResizeCursor): (QScrollView::setVScrollBarMode): (WebCore::QPainter::drawScaledAndTiledImage): (QScrollView::scrollYOffset): (WebCore::QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (QScrollView::setScrollBarsMode): (QComboBox::sizeHint): (WebCore::QPainter::drawRect): (QFont::setPixelSize): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::clearFocusRing): (WebCore::Widget::Widget): (QTextEdit::text): (WebCore::QPainter::drawImageInRect): (WebCore::Widget::disableFlushDrawing): (WebCore::QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (WebCore::QPainter::drawLineForMisspelling): (QSlider::value): (QListBox::setSelectionMode): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (QScrollView::updateContents): (QFontMetrics::floatWidth): (QScrollView::setHScrollBarMode):
7:52 PM Changeset in webkit [12954] by mjs
  • 17 edits
    3 copies in trunk/WebCore

Reviewed by Eric.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_ruleimpl.cpp:
  • css/cssparser.cpp:
  • css/cssstyleselector.cpp:
  • dom/DocumentImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/xbl/xbl_binding.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • kwq/KWQTextCodec.cpp: (QTextCodec::codecForName): (QTextCodec::utf8Codec): (QTextCodec::codecForNameEightBitOnly): (QTextCodec::codecForLocale): (QTextCodec::name): (QTextCodec::makeDecoder):
  • kwq/KWQTextCodec.h:
  • loader/CachedObject.cpp:
  • loader/DocLoader.cpp:
  • page/Frame.h:
  • platform/KURL.cpp: Added. (KURL::decode_string): (encodeRelativeString):
  • platform/KURL.h: Added.
  • platform/mac/KURLMac.mm: Added. (KURL::getNSURL):
  • xml/xmlhttprequest.h:
7:08 PM Changeset in webkit [12953] by darin
  • 97 edits
    5 copies
    5 moves
    2 adds
    5 deletes in trunk/WebCore

Reviewed by John Sullivan.

  • moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras" from kwq to platform directory
  • moved history function from kwq to bridge directory
  • eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent, MoveReleaseEvent, and DrawContents classes
  • merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into a single class in the page directory
  • broke khtmllayout.h out into a file for the Length structure in the css directory and a file for the GapRects structure in the rendering directory
  • redid the Length structure to work more portably by not relying on bitfield layout and improve the names to no longer explicitly mention "width"
  • reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
  • ForwardingHeaders/kparts: Removed.
  • ForwardingHeaders/qevent.h: Removed.
  • khtml/khtml_events.cpp: Removed.
  • khtml/khtml_events.h: Removed.
  • khtml/misc/khtmllayout.h: Removed.
  • kwq/KWQEvent.h: Removed.
  • kwq/KWQEvent.mm: Removed.
  • kwq/KWQFoundationExtras.h: Removed.
  • kwq/KWQKHistoryProvider.mm: Removed.
  • kwq/KWQKPartsHistoryProvider.h: Removed.
  • bridge/History.h: Added.
  • bridge/mac/HistoryMac.mm: Added.
  • css/Length.h: Added.
  • page/MouseEventWithHitTestResults.h: Added.
  • platform/KeyEvent.h: Added.
  • platform/MouseEvent.h: Added.
  • platform/WheelEvent.h: Added.
  • platform/mac/FoundationExtras.h: Added.
  • platform/mac/KeyEventMac.mm: Added.
  • platform/mac/MouseEventMac.mm: Added.
  • platform/mac/WheelEventMac.mm: Added.
  • rendering/GapRects.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated for above changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions. Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent with MouseEventWithHitTestResults.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::urlSelected): Removed unused parameters. (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent. (WebCore::MacFrame::keyEvent): Changed to use KeyEvent. (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type. (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto. (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto. (WebCore::MacFrame::passSubframeEventToSubframe): Ditto. (WebCore::MacFrame::mouseDown): Changed to use MouseEvent. (WebCore::MacFrame::mouseDragged): Ditto. (WebCore::MacFrame::mouseUp): Ditto. (WebCore::MacFrame::mouseMoved): Ditto. (WebCore::MacFrame::sendContextMenuEvent): Ditto.
  • css/csshelper.h: Removed a bunch of unused declarations.
  • dom/DocumentImpl.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent and return a MouseEventWithHitTestResults. (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.
  • dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
  • dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and detail values from the caller, never from the event. Changed to use MouseEvent. (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent. (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.
  • dom/dom2_eventsimpl.h:
  • dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent. (WebCore::KeyboardEventImpl::charCode): Ditto.
  • dom/dom_elementimpl.h: Removed unused mouseEventHandler function.
  • khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference to the document.
  • khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For use in the Frame destructor so we can get an existing KJS::Window object without creating a new interpreter and window object.
  • khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the guarded pointers to Frame to use plain old pointers that are cleared by the Frame explicitly (by the function disconnectFrame). Made the pointers to all the sub-objects of KJS::Window be mutable so we don't have to const_cast in the functions to get (and lazily create) them.
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*. (KJS::History::disconnectFrame): Added. Clears m_frame. (KJS::FrameArray::disconnectFrame): Added. Clears m_frame. (KJS::Window::Window): Removed code to create a WindowQObject. (KJS::Window::~Window): Removed code to delete a WindowQObject. (KJS::Window::location): Remove now-unneeded const_cast. (KJS::Window::selection): Ditto. (KJS::Window::locationbar): Ditto. (KJS::Window::menubar): Ditto. (KJS::Window::personalbar): Ditto. (KJS::Window::statusbar): Ditto. (KJS::Window::toolbar): Ditto. (KJS::Window::scrollbars): Ditto. (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer. (KJS::Window::getOwnPropertySlot): Ditto. (KJS::Window::toBoolean): Ditto. (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null. (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer. (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call to clearAllTimeouts instead. (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject destructor. (KJS::Window::installTimeout): Moved to Window from WindowQObject. (KJS::Window::pauseTimeouts): Ditto. (KJS::Window::resumeTimeouts): Ditto. (KJS::Window::clearTimeout): Ditto. (KJS::Window::timerFired): Ditto. (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0. (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer. (KJS::Location::getOwnPropertySlot): Ditto. (KJS::Location::put): Ditto. (KJS::Selection::getOwnPropertySlot): Ditto. (KJS::BarInfo::getOwnPropertySlot): Ditto.
  • khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
  • khtml/html/html_imageimpl.h: Ditto.
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler): Changed to use KeyEvent and removed the code to extract the button and state from the DOM even to pass to urlSelected.
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use a RefPtr instead of a QGuardedPtr.
  • khtml/misc/helper.h:
  • khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent): Change to use KeyEvent.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusChanged):
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Updated to use new eventFilterFocusIn/Out instead of the general purpose eventFilter function. This allows us to remove QEvent and the focus events.
  • kwq/KWQNamespace.h: Removed ButtonState.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and eventFilterFocusOut, allowing us to remove QEvent. Removed event function.
  • kwq/KWQSlot.cpp: (KWQSlot::KWQSlot): Removed the parentDestroyed slot. (KWQSlot::call): Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a raw Frame pointer instead of a QGuardedPtr, and count on the Frame to delete us when it's being deleted. (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer a virtual function. This is not a polymorphic class. (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete ourselves -- that's now the frame's responsibility. (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and delete m_userStyleSheetLoader. (WebCore::Frame::changeLocation): Update since urlSelected no longer takes button and state parameters. (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load in progress before starting a new load. Store reference to loader. (WebCore::Frame::urlSelected): Remove button and state parameters and unused local variable hasTarget. (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent to MouseEvent. (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent to MouseEventWithHitTestResults. (WebCore::Frame::handleMousePressEventTripleClick): Ditto. (WebCore::Frame::handleMousePressEventSingleClick): Ditto. (WebCore::Frame::khtmlMousePressEvent): Ditto. (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent to MouseEventWithHitTestResults. (WebCore::Frame::khtmlMouseMoveEvent): Ditto. (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent to MouseEventWithHitTestResults. (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults. (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
  • page/FramePrivate.h: Added m_userStyleSheetLoader.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults. (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto. (WebCore::selectCursor): Ditto. (WebCore::FrameView::viewportMouseMoveEvent): Ditto. (WebCore::FrameView::viewportMouseReleaseEvent): Ditto. (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent. (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults. (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to WheelEvent. (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent parameters.
  • platform/Widget.h:
  • platform/Widget.cpp: Removed event function.
  • rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent. (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes to the Length class. (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of ComboBoxWidget. (WebCore::RenderSelect::slotSelected): Ditto. (WebCore::RenderSelect::createComboBox): Ditto.
  • rendering/render_replaced.h:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes a parameter. (WebCore::RenderWidget::setQWidget): Ditto. (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter. (WebCore::RenderWidget::eventFilterFocusOut): Ditto.
  • css/css_computedstyle.cpp: (WebCore::valueForLength): (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLAreaElementImpl::getRegion):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::getBPMWidth): (WebCore::RenderBlock::calcInlineMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::calcMinMaxWidth):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderText.h: (khtml::RenderText::marginLeft): (khtml::RenderText::marginRight):
  • rendering/bidi.cpp: (khtml::getBPMWidth):
  • rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::relativePositionOffset): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcHeightUsing): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcVerticalMargins): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth): (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth): (khtml::RenderFlexibleBox::calcMinMaxWidth): (khtml::RenderFlexibleBox::allowedChildFlex):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/render_image.cpp: (WebCore::RenderImage::isWidthSpecified): (WebCore::RenderImage::isHeightSpecified):
  • rendering/render_layer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start): (WebCore::Marquee::updateMarqueeStyle): (WebCore::Marquee::timerFired):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::addDashboardRegions):
  • rendering/render_style.h:
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::addIntrinsicMargins):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages): Updated for changes to the Length class. Also removed a check of the printpainter global, never used in WebCore.
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/csshelper.cpp:
  • editing/SelectionController.cpp:
  • khtml/ecma/kjs_html.h:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQClipboard.mm:
  • kwq/KWQFont.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQPainter.mm:
  • kwq/WebCoreSettings.mm:
  • platform/StringImpl.cpp:
  • platform/mac/CursorMac.mm:
  • platform/mac/WidgetMac.mm:
  • rendering/RenderBlock.h:
  • rendering/render_canvas.cpp:
  • rendering/render_line.h:
  • rendering/render_style.cpp:
  • rendering/table_layout.h: Updated includes.
  • bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this didn't rebuild.
  • bindings/js/JSDOMEvents.cpp: Ditto.
6:00 PM Changeset in webkit [12952] by thatcher
  • 2 edits in trunk/WebKitLibraries

New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)

  • libWebKitSystemInterface.a:
5:11 PM Changeset in webkit [12951] by eseidel
  • 10 edits
    1 add in trunk/WebCore

2006-02-23 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix linking of static constructed globals on win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
  • dom/EventNames.cpp: (WebCore::EventNames::init):
  • dom/EventNames.h:
  • dom/dom_qname.cpp: (WebCore::QualifiedName::init):
  • dom/dom_qname.h:
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init):
  • khtml/html/htmlnames.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init):
  • platform/StaticConstructors.h: Added.
4:20 PM Changeset in webkit [12950] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick.


  • fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

Check shouldClose() before actually scheduling a close.

shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
result based on whether the user clicks "OK" or "Cancel". In cases where the window is closed with cmd-w
or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method. Since
windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
closes a window even gets started.

  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
11:52 AM Changeset in webkit [12949] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Darin, Maciej.

  • Inline some functions suggested by Shark. 2.9% speedup on super accurate JS iBench.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
<rdar://problem/4448116>

  • kjs/nodes.h: (KJS::ArgumentsNode::evaluateList):
  • kjs/object.cpp:
  • kjs/object.h: (KJS::ScopeChain::release): (KJS::JSObject::toPrimitive):
  • kjs/scope_chain.cpp:
  • kjs/ustring.cpp:
  • kjs/ustring.h: (KJS::UString::toArrayIndex):
  • kjs/value.cpp:
  • kjs/value.h: (KJS::JSValue::toObject):
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_ThreadCache_FreeList::Push): (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):
11:46 AM Changeset in webkit [12948] by vicki
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.


  • fix <rdar://problem/4456004> onbeforeunload should cancel, and <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window event, so we should be using handleWindowEvent rather than dispatching a generic event on the body. It seems this only worked before because of incorrect code in other parts of the tree.
  • dom/dom2_eventsimpl.cpp: (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor, pass true for the cancel parameter
11:28 AM Changeset in webkit [12947] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Turn http tests back on by default.
  • Wait for Apache to actually start serving requests.
  • Get user id from a built-in variable rather than an external command; don't pass the group.
  • Scripts/run-webkit-tests:
9:25 AM Changeset in webkit [12946] by ap
  • 2 edits in trunk/WebKitTools

Suggested by Mitz Pettel, reviewed by Darin.

  • Scripts/run-webkit-tests: Pass User and Group directives, so that Apache can run CGIs even if the permissions are 700 or 600.
8:39 AM Changeset in webkit [12945] by darin
  • 2 edits in trunk/WebKitTools

Collaborating with Alexey.

  • turn off http tests by default until we figure out how to get them to run even when permissions on CGI files are 700 instead of 755
  • Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.
1:01 AM Changeset in webkit [12944] by eseidel
  • 6 edits in trunk

2006-02-23 Eric Seidel <eseidel@apple.com>

Add *.user to ignore list.

12:55 AM Changeset in webkit [12943] by eseidel
  • 2 edits
    2 deletes in trunk/WebKitTools

2006-02-23 Eric Seidel <eseidel@apple.com>

Remove binary file which shouldn't have been commited (and add to ignore list).

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Removed.

Feb 22, 2006:

11:09 PM Changeset in webkit [12942] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/run-webkit-tests: Put Apache log files in the right directory.
8:10 PM Changeset in webkit [12941] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by Tim Hatcher.

Fix install-win-extras to not try to re-install setx if installed.

  • Scripts/install-win-extras:
7:52 PM Changeset in webkit [12940] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

One more file possibly missing from previous commit?

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
7:38 PM Changeset in webkit [12939] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Files missing from previous commit.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
7:27 PM Changeset in webkit [12938] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Rubber-stamped by justing.

Corrected path for DumpRenderTree.intermediate files

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
7:14 PM Changeset in webkit [12937] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Fixed build-dumprendertree to exit with correct error codes.

  • Scripts/build-dumprendertree:
6:49 PM Changeset in webkit [12936] by eseidel
  • 5 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Update build scripts to generalize building on Win32, and allow
building of DumpRenderTree on Win32 from build-dumprendertree.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main):
  • Scripts/build-dumprendertree:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
5:34 PM Changeset in webkit [12935] by thatcher
  • 15 adds in branches/Safari-1-3-branch

Fixing binary files messed up by cvs2svn.

4:56 PM Changeset in webkit [12934] by eseidel
  • 2 edits
    7 adds in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

  • DumpRenderTree/DumpRenderTree.vcproj: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (_tmain):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
  • Scripts/build-webkit: make build-webkit cleanup after itself
4:36 PM Changeset in webkit [12933] by eseidel
  • 2 edits
    2 adds in trunk/WebCore

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Adding stub FrameWin class to expose link errors.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: Added.
  • bridge/win/FrameWin.h: Added. (WebCore::Win):
4:33 PM Changeset in webkit [12932] by mjs
  • 37 edits
    2 moves
    1 add
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • move QStringList to platform, make it portable
  • ForwardingHeaders/qstringlist.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentImpl.h:
  • kcanvas/KCanvasFilters.h:
  • khtml/xbl/xbl_protohandler.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
  • ksvg2/svg/SVGFELightElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
  • ksvg2/svg/SVGFETileElementImpl.cpp:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGLengthListImpl.cpp:
  • ksvg2/svg/SVGNumberListImpl.cpp:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • ksvg2/svg/SVGTransformableImpl.cpp:
  • kwq/KWQClipboard.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKLocale.h:
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQStringList.h: Removed.
  • kwq/KWQStringList.mm: Removed.
  • loader/DocLoader.h:
  • page/Frame.h:
  • platform/QStringList.cpp: Added. (QStringList::split): (QStringList::pop_front):
  • platform/QStringList.h: Added.
  • platform/mac/QStringListMac.mm: Added. (QStringList::getNSArray):
Note: See TracTimeline for information about the timeline view.