⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 25, 2006:

8:51 PM Changeset in webkit [12990] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added reviewer to an old change; I just noticed it was missing.

5:14 PM Changeset in webkit [12989] by ggaren
  • 9 edits
    18 adds in trunk/LayoutTests

RS by mjs.

-tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
Re-landing results after adding missing png's to the test.

  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.
  • fast/replaced/maxheight-percent-expected.checksum: Added.
  • fast/replaced/maxheight-percent-expected.png: Added.
  • fast/replaced/maxheight-percent-expected.txt:
  • fast/replaced/maxheight-pxs-expected.checksum: Added.
  • fast/replaced/maxheight-pxs-expected.png: Added.
  • fast/replaced/maxheight-pxs-expected.txt:
  • fast/replaced/maxwidth-percent-expected.checksum: Added.
  • fast/replaced/maxwidth-percent-expected.png: Added.
  • fast/replaced/maxwidth-percent-expected.txt:
  • fast/replaced/maxwidth-pxs-expected.checksum: Added.
  • fast/replaced/maxwidth-pxs-expected.png: Added.
  • fast/replaced/maxwidth-pxs-expected.txt:
  • fast/replaced/minheight-percent-expected.checksum: Added.
  • fast/replaced/minheight-percent-expected.png: Added.
  • fast/replaced/minheight-percent-expected.txt:
  • fast/replaced/minheight-pxs-expected.checksum: Added.
  • fast/replaced/minheight-pxs-expected.png: Added.
  • fast/replaced/minheight-pxs-expected.txt:
  • fast/replaced/minwidth-percent-expected.checksum: Added.
  • fast/replaced/minwidth-percent-expected.png: Added.
  • fast/replaced/minwidth-percent-expected.txt:
  • fast/replaced/minwidth-pxs-expected.checksum: Added.
  • fast/replaced/minwidth-pxs-expected.png: Added.
  • fast/replaced/minwidth-pxs-expected.txt:

Feb 24, 2006:

7:48 PM Changeset in webkit [12988] by antti
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/float/multiple-float-positioning-expected.checksum: Added.
  • fast/block/float/multiple-float-positioning-expected.png: Added.
  • fast/block/float/multiple-float-positioning-expected.txt: Added.
  • fast/block/float/multiple-float-positioning.html: Added.
7:46 PM Changeset in webkit [12987] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Test: fast/block/float/multiple-float-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list
6:57 PM Changeset in webkit [12986] by justing
  • 9 edits in trunk

LayoutTests:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:

WebCore:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

Reviewed by justin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their own selection gaps.
6:25 PM Changeset in webkit [12985] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
  • fast/dom/Window/redirect-with-timer.html: Added.
  • fast/dom/Window/redirect-with-timer-expected.txt: Added.

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)

Test: fast/dom/Window/redirect-with-timer.html

  • platform/Timer.h: Made isActive no longer inline. Added inHeap function.
  • platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are.
5:07 PM Changeset in webkit [12984] by justing
  • 58 edits in trunk

LayoutTests:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.txt:
  • editing/deleting/delete-line-end-ws-002-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/selection/extend-by-character-003-expected.txt:
  • editing/selection/extend-by-character-005-expected.txt:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-character-003-expected.txt:
  • editing/selection/move-by-character-005-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:
  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
  • fast/text/justified-text-rect-expected.txt:
  • fast/text/justified-text-rect.html:

WebCore:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::setContentEditable):
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement):
2:48 PM Changeset in webkit [12983] by eseidel
  • 11 edits
    3 moves in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/css_base.h:
  • dom/AtomicStringList.h: Added. (WebCore::AtomicStringList::AtomicStringList):
  • dom/QualifiedName.cpp: Added.
  • dom/QualifiedName.h: Added.
  • dom/dom_atomicstringlist.h: Removed.
  • dom/dom_elementimpl.h:
  • dom/dom_qname.cpp: Removed.
  • dom/dom_qname.h: Removed.
  • editing/RemoveNodeAttributeCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • khtml/html/htmlnames.h:
  • khtml/html/htmltokenizer.h:
  • ksvg2/scripts/make_names.pl: update for new headers
2:36 PM Changeset in webkit [12982] by eseidel
  • 6 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Made a few methods on frame pure virtual.
Added a bunch of stub functions for win32 linking.

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::print): (WebCore::MacFrame::canUndo): (WebCore::MacFrame::canRedo): (WebCore::MacFrame::canPaste):
  • bridge/win/FrameWin.h:
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (QLineEdit::maxLength): (QPainter::drawEllipse): (QTextEdit::setLineHeight): (QPainter::beginTransparencyLayer): (QLineEdit::selectedText): (Widget::setIsSelected): (QPainter::paintingDisabled): (QFontMetrics::selectionRectForText): (QTextEdit::getCursorPosition): (QSlider::QSlider): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
2:07 PM Changeset in webkit [12981] by ggaren
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by Hyatt.

-tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

  • fast/replaced/maxheight-percent.html: Added.
  • fast/replaced/maxheight-pxs.html: Added.
  • fast/replaced/maxwidth-percent.html: Added.
  • fast/replaced/maxwidth-pxs.html: Added.
  • fast/replaced/minheight-percent.html: Added.
  • fast/replaced/minheight-pxs.html: Added.
  • fast/replaced/minwidth-percent.html: Added.
  • fast/replaced/minwidth-pxs.html: Added.
  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.

WebCore:

Reviewed by Hyatt, tweaked and landed by ggaren.

This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
patch of ​http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
modifications to suit the Webcore tree. Makes images respect min/max
sizes and their intrinsic aspect ratios at the same time according to
CSS 2.1 (​http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).

Test: fast/replaced/maxheight-percent.html
Test: fast/replaced/maxheight-pxs.html
Test: fast/replaced/maxwidth-percent.html
Test: fast/replaced/maxwidth-pxs.html
Test: fast/replaced/minheight-percent.html
Test: fast/replaced/minheight-pxs.html
Test: fast/replaced/minwidth-percent.html
Test: fast/replaced/minwidth-pxs.html

  • rendering/render_box.cpp: (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
  • rendering/render_image.cpp: Respect aspect ratios and calculate max/min (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): Added (WebCore::RenderImage::calcAspectRatioHeight): Added (WebCore::RenderImage::calcMinMaxWidth): Added
  • rendering/render_image.h:
1:47 PM Changeset in webkit [12980] by vicki
  • 1 edit
    2 adds in trunk/WebCore
  • add missing resources for manual-tests/scrolling-nestedframesets.html
  • manual-tests/resources/testframe-link_text.html: Added.
  • manual-tests/resources/testframeset.html: Added.
1:31 PM Changeset in webkit [12979] by vicki
  • 1 edit
    1 add in trunk/WebCore
  • test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
  • manual-tests/onbeforeunload-close_with_javascript.html: Added.
1:25 PM Changeset in webkit [12978] by eseidel
  • 3 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add Path stubs for Win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (Path::Path): (Path::~Path): (Path::operator=): (Path::contains): (Path::translate): (Path::boundingRect):
1:13 PM Changeset in webkit [12977] by hyatt
  • 26 edits in trunk/WebCore

In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle. htmlFont() becomes simply
font(). The old font() method turns into qfont(). Also added a helper for obtaining the fontDescription() directly from
the RenderStyle (without first obtaining the htmlFont()).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::offsetForPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::shouldUseMonospaceCache): (WebCore::RenderText::font): (WebCore::RenderText::width): (WebCore::RenderText::htmlFont):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::font): (khtml::RenderStyle::fontDescription): (khtml::RenderStyle::qfont):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
11:49 AM Changeset in webkit [12976] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • add link stubs for symbols only referenced from the link stubs file
  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::focusPolicy): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar):
11:44 AM Changeset in webkit [12975] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • fix up font.h inclues to be Font.h to fix build.
  • css/css_computedstyle.cpp:
  • css/css_valueimpl.cpp:
  • platform/Font.cpp:
  • rendering/render_style.h:
11:28 AM Changeset in webkit [12974] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix mac build by changing constants to an enum.

  • khtml/dom/dom2_events.h: (DOM::KeyboardEvent::):
11:19 AM Changeset in webkit [12973] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against icu.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
11:15 AM Changeset in webkit [12972] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Move rendering/font to platform/Font.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp:
  • platform/Font.cpp: Added.
  • platform/Font.h: Added.
  • rendering/font.cpp: Removed.
  • rendering/font.h: Removed.
  • rendering/render_theme_mac.mm:
11:11 AM Changeset in webkit [12971] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove delcarations causing duplicate symbols on win32.

  • khtml/dom/dom2_events.cpp:
11:02 AM Changeset in webkit [12970] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

  • bridge/win/FrameWin.cpp: fix line endings
10:54 AM Changeset in webkit [12969] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against libxml, etc.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
10:36 AM Changeset in webkit [12968] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Removed WebCore
prefixes added using namespace WebCore, fixes win32 build.
  • platform/win/TemporaryLinkStubs.cpp: (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QTextEdit::textWithHardLineBreaks): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (iBeamCursor): (QPainter::misspellingLineThickness): (westResizeCursor): (Widget::isEnabled): (northWestResizeCursor): (QPainter::drawEllipse): (southWestResizeCursor): (Widget::focusPolicy): (waitCursor): (QPainter::endTransparencyLayer): (ScrollView::addChild): (Widget::~Widget): (QListBox::sizeForNumberOfLines): (FrameView::updateBorder): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (eastResizeCursor): (QFontMetrics::boundingRect): (QPainter::beginTransparencyLayer): (northEastResizeCursor): (Widget::frameGeometry): (QPainter::addFocusRingRect): (QPainter::restore): (Widget::setEnabled): (QPainter::font): (QPainter::pen): (crossCursor): (Widget::setIsSelected): (handCursor): (QLineEdit::text): (Widget::unlockDrawingFocus): (QPainter::paintingDisabled): (northResizeCursor): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QPainter::drawText): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (southResizeCursor): (moveCursor): (FrameView::isFrameView): (helpCursor): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (southEastResizeCursor): (QPainter::drawScaledAndTiledImage): (QPainter::drawImage): (QComboBox::setWritingDirection): (QComboBox::sizeHint): (QPainter::drawRect): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QPainter::drawLineForMisspelling): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (ScrollView::updateContents):
8:24 AM Changeset in webkit [12967] by darin
  • 20 edits
    1 copy
    2 moves in trunk/WebCore

Reviewed by Hyatt.

  • moved QScrollView from kwq to platform directory
  • kwq/KWQScrollView.h: Removed.
  • kwq/KWQScrollView.mm: Removed.
  • platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
  • platform/ScrollView.h: Added. The rest of the former QScrollView.
  • platform/mac/ScrollViewMac.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::init): (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::scrollbarsVisible): Changed scrolling constants to use new names.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter): Use FrameView instead of QScrollView for a local variable.
  • khtml/html/html_baseimpl.h: Use ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQListBox.h: Use WebCore::ScrollView instead of QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Ditto. (QTextEdit::focusPolicy): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode instead of QScrollView::ScrollBarMode. (WebCore::FrameView::FrameView): Remove mention of QScrollView. (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView. (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView. (WebCore::FrameView::setVScrollBarMode): Ditto. (WebCore::FrameView::setHScrollBarMode): Ditto. (WebCore::FrameView::restoreScrollBar): Ditto.
  • platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
  • platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle): Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to updateContents so we can remove the overload. (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView. (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto. (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
4:59 AM Changeset in webkit [12966] by andersca
  • 2 edits in trunk/WebKitTools

2006-02-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
getting called from the run loop, making the view render each test and thus slowing
down the tests.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the offscreen window to not autodisplay.
1:14 AM Changeset in webkit [12965] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Fix the win32 build.

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
1:10 AM Changeset in webkit [12964] by ap
  • 2 edits
    60 adds in trunk/LayoutTests

Reviewed by Darin.

  • http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
  • http/tests/xmlhttprequest/web-apps: Added (recursively).
12:01 AM Changeset in webkit [12963] by hyatt
  • 17 edits
    1 add in trunk/WebCore

Rename FontDef to FontDescription and move it into the platform directory.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::setFontSize):
  • css/cssstyleselector.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • platform/FontDescription.h: Added. (WebCore::FontDescription::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::operator!=): (WebCore::FontDescription::family): (WebCore::FontDescription::firstFamily): (WebCore::FontDescription::specifiedSize): (WebCore::FontDescription::computedSize): (WebCore::FontDescription::italic): (WebCore::FontDescription::computedPixelSize): (WebCore::FontDescription::smallCaps): (WebCore::FontDescription::isAbsoluteSize): (WebCore::FontDescription::weight): (WebCore::FontDescription::genericFamily): (WebCore::FontDescription::usePrinterFont): (WebCore::FontDescription::setFamily): (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize): (WebCore::FontDescription::setItalic): (WebCore::FontDescription::setSmallCaps): (WebCore::FontDescription::setIsAbsoluteSize): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::setGenericFamily): (WebCore::FontDescription::setUsePrinterFont): (WebCore::FontDescription::operator==):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
  • rendering/font.cpp: (khtml::Font::selectionRectForText): (khtml::Font::drawHighlightForText): (khtml::Font::drawText): (khtml::Font::update):
  • rendering/font.h: (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::fontDescription): (WebCore::Font::isSmallCaps): (WebCore::Font::wordSpacing): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint): (WebCore::Font::width):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect):
  • rendering/render_style.h: (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
Note: See TracTimeline for information about the timeline view.