Context Navigation

← Previous Period
Next Period →

Timeline

Feb 27, 2006:

11:56 PM Changeset in webkit [13052] by eseidel

1 edit in trunk/WebKitLibraries

Add svn:ignore property to ignore zip files

11:52 PM Changeset in webkit [13051] by justing

8 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped

fast/forms/textarea-hard-linewrap-expected.txt: Added.
fast/forms/textarea-hard-linewrap.html: Added.
fast/forms/textarea-setvalue-submit-expected.txt: Added.
fast/forms/textarea-setvalue-submit.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped

Canonicalize line endings in textareas to avoid the workarounds that were a source of bugs,
Also call textWithHardLineWraps inside appendFormData (and nowhere else) if wrap="hard".

khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (WebCore::HTMLTextAreaElementImpl::select): (WebCore::HTMLTextAreaElementImpl::appendFormData): (WebCore::HTMLTextAreaElementImpl::rendererWillBeDestroyed): (WebCore::HTMLTextAreaElementImpl::updateValue): (WebCore::HTMLTextAreaElementImpl::value): (WebCore::HTMLTextAreaElementImpl::setValue): (WebCore::HTMLTextAreaElementImpl::defaultValue):
khtml/html/HTMLTextAreaElementImpl.h: (DOM::HTMLTextAreaElementImpl::invalidateValue):
kwq/KWQTextArea.h:
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView text]): (-[KWQTextAreaTextView textWithHardLineBreaks]): (-[KWQTextAreaTextView setSelectedRange:]): (-[KWQTextAreaTextView selectedRange]): (-[KWQTextAreaTextView getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextAreaTextView textView:shouldChangeTextInRange:replacementString:]):
rendering/render_form.cpp: (WebCore::RenderTextArea::destroy): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks):
rendering/render_form.h:

11:06 PM Changeset in webkit [13050] by eseidel

2 edits in trunk/WebKitTools

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Scripts/install-win-extras: fix dll permissions & download zlib too.

11:05 PM Changeset in webkit [13049] by eseidel

5 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Copy missing dlls to build directory.

Viewer.cpp: fix line endings
Viewer/ImageView.cpp: fix line endings
Viewer/stdafx.cpp: fix line endings
WebCore.vcproj/WebCore/build-generated-files.sh:

10:39 PM Changeset in webkit [13048] by darin

7 edits in trunk

LayoutTests:

Reviewed by Darin.

added test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=7338 Incorrect selectorText for multiple subselectors

fast/dom/css-selectorText-expected.checksum: Updated.
fast/dom/css-selectorText-expected.png: Updated.
fast/dom/css-selectorText-expected.txt: Updated.
fast/dom/css-selectorText.html: Added a case with multiple subselectors.

WebCore:

Test: added to fast/dom/css-selectorText.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7338 Incorrect selectorText for multiple subselectors.

css/css_base.cpp: (CSSSelector::selectorText): Iterate over subselectors

10:27 PM Changeset in webkit [13047] by darin

1 edit in trunk/LayoutTests/editing/inserting/editing-empty-divs-expected.txt

Oops, this was in change log, but not committed.

10:17 PM Changeset in webkit [13046] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

write a portable ICU version of TextEncoding::fromUnicode for use on win32

platform/StreamingTextDecoder.h:
platform/TextEncoding.cpp: (WebCore::TextEncoding::fromUnicode): added (WebCore::getConverter): helper (WebCore::cacheConverter): ditto (WebCore::effectiveEncoding): ditto
platform/mac/TextEncodingMac.cpp: Add comment
platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode): remove

9:55 PM Changeset in webkit [13045] by darin

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7433 REGRESSION (r12789): Second RTL text run on a line cannot be selected

fast/text/in-rendered-text-rtl-expected.checksum: Added.
fast/text/in-rendered-text-rtl-expected.png: Added.
fast/text/in-rendered-text-rtl-expected.txt: Added.
fast/text/in-rendered-text-rtl.html: Added.

WebCore:

Test: fast/text/in-rendered-text-rtl.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7433 REGRESSION (r12789): Second RTL text run on a line cannot be selected

dom/dom_position.cpp: (WebCore::Position::inRenderedText): If the RenderText contains reversed text, the text boxes are not necessarily ordered by start position, so iterate through all of them. (WebCore::Position::isRenderedCharacter): Ditto.

9:44 PM Changeset in webkit [13044] by darin

3 edits
9 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321 REGRESSION: style tag in body causes two head elements to appear in the DOM

The head-check.html document uses an iframe as a laboratory for loading each
head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's
Live DOM Viewer: http://software.hixie.ch/utilities/js/live-dom-viewer/

Each of the four head-check-N.html files tests a different code path for
creating a document's head element in WebCore/khtml/html/htmlparser.cpp.

editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child index for <body> since the document previously had two <head> nodes.
fast/dom/HTMLHeadElement: Added.
fast/dom/HTMLHeadElement/head-check-expected.txt: Added.
fast/dom/HTMLHeadElement/head-check.html: Added.
fast/dom/HTMLHeadElement/resources: Added.
fast/dom/HTMLHeadElement/resources/head-check-1.html: Added.
fast/dom/HTMLHeadElement/resources/head-check-2.html: Added.
fast/dom/HTMLHeadElement/resources/head-check-3.html: Added.
fast/dom/HTMLHeadElement/resources/head-check-4.html: Added.
fast/dom/HTMLHeadElement/resources/head-check.js: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321 REGRESSION: style tag in body causes two head elements to appear in the DOM

khtml/html/htmlparser.cpp: Handle the head node like form and map nodes. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::headCreateErrorCheck):

9:38 PM Changeset in webkit [13043] by eseidel

3 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Add stub to make DRT link.
Make WebCore copy libxml.dll into build directory when building.

WebCore.vcproj/WebCore/build-generated-files.sh:
platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode):

9:03 PM Changeset in webkit [13042] by darin

2 edits in trunk/WebCore

Reviewed by Eric.

fix regression in layout tests

dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength): Fix some code that was not properly truncating. I broke it in my string change this morning.

9:02 PM Changeset in webkit [13041] by eseidel

2 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Rubber-stamped by darin.

Remove fpconst.cpp, unused on win32 and the cause of linker warnings.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

8:55 PM Changeset in webkit [13040] by mjs

3 edits in trunk/WebCore

Rubber stamped by Eric.

add stubs for FrameWin overrides of pure virtual Frame methods

platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::unfocusWindow): (WebCore::FrameWin::locationbarVisible): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::issueRedoCommand): (WebCore::FrameWin::canRedo): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::canUndo): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::print): (WebCore::FrameWin::issueCutCommand): (WebCore::FrameWin::issueCopyCommand): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::issueUndoCommand): (WebCore::FrameWin::clearRecordedFormValues): (WebCore::FrameWin::issuePasteCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::menubarVisible): (WebCore::FrameWin::personalbarVisible): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::statusbarVisible): (WebCore::FrameWin::toolbarVisible): (WebCore::FrameWin::issueTransposeCommand): (WebCore::FrameWin::userAgent): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::canGoBackOrForward): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::generateFrameName):

8:27 PM Changeset in webkit [13039] by eseidel

2 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add constructor and destructor.

bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):

8:23 PM Changeset in webkit [13038] by mjs

2 edits in trunk/WebCore

Rubber stamped by Eric (sorta).

add return values where needed

platform/win/TemporaryLinkStubs.cpp: (KWQServeRequest): (KWQServeSynchronousRequest):

8:13 PM Changeset in webkit [13037] by eseidel

3 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix Assertions.cpp to compile on win32.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kxmlcore/Assertions.cpp:

8:12 PM Changeset in webkit [13036] by eseidel

2 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add a couple more stubs to make Win32 link.

platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest): (WebCore::FrameView::topLevelWidget):

7:56 PM Changeset in webkit [13035] by eseidel

6 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Move mac-specific logging logic up into WebCore (from JavaScriptCore).
Remove KWQ prefixes from default log channels.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

bridge/mac/WebCorePageBridge.mm: (initializeLogChannel): (initializeLoggingChannelsIfNecessary): (-[WebCorePageBridge init]):
page/Frame.h:
platform/Logging.cpp:
platform/Logging.h:

7:51 PM Changeset in webkit [13034] by eseidel

3 edits
1 move in trunk/JavaScriptCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Made Assertions.cpp platform independent.
Moved mac-specific logging logic up into WebCore.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

JavaScriptCore.xcodeproj/project.pbxproj:
kxmlcore/Assertions.cpp: Added.
kxmlcore/Assertions.h:
kxmlcore/Assertions.mm: Removed.

7:41 PM Changeset in webkit [13033] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

fix <rdar://problem/4104575> hang due to slow saveDocumentState method

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]): Change code that iterates a QStringList with indices to use iterator instead.

7:38 PM Changeset in webkit [13032] by mjs

3 edits in trunk/WebCore

Reviewed by Eric.

portable version of QString::utf8

platform/QString.cpp: (QString::utf8): moved here, rewritten to use TextCodec
platform/mac/QStringMac.mm: (QString::utf8): removed from here

6:53 PM Changeset in webkit [13031] by eseidel

3 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Rubber-stamped by mjs.

Fix FrameWin.h to use consistant line endings.
Fix TemporaryLinkStubs to better match style guidelines.

bridge/win/FrameWin.h: (WebCore::Win):
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (Widget::mapFromGlobal): (QPainter::addClip): (QLineEdit::cursorPosition): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (QPainter::drawFocusRing): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (QComboBox::clear): (QPainter::misspellingLineThickness): (QComboBox::setFrameGeometry): (QLineEdit::maxLength): (Widget::isEnabled): (KWQServeRequest): (QTextEdit::setText): (Widget::paint): (QPainter::addRoundedRectClip): (FrameView::viewportToGlobal): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (QPainter::drawEllipse): (QTextEdit::setReadOnly): (QListBox::appendItem): (QLineEdit::setPlaceholderString): (Cursor::Cursor): (Widget::focusPolicy): (ScrollView::removeChild): (QTextEdit::selectAll): (QPainter::fillRect): (QPainter::endTransparencyLayer): (QFont::QFont): (ScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (Widget::~Widget): (QPainter::xForm): (QListBox::sizeForNumberOfLines): (ScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (FrameView::updateBorder): (QLineEdit::hasSelectedText): (QScrollBar::QScrollBar): (QListBox::doneAppendingItems): (QTextEdit::QTextEdit): (ScrollView::inWindow): (QScrollBar::setValue): (QFont::setFirstFamily): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (ScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (QTextEdit::setLineHeight): (QScrollBar::setKnobProportion): (KWQFileButton::KWQFileButton): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (QPainter::beginTransparencyLayer): (QFontMetrics::setFont): (QComboBox::setFont): (Widget::frameGeometry): (QListBox::setSelected): (QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (QPainter::restore): (QFontMetrics::width): (Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (ScrollView::setStaticBackground): (QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (QPainter::drawText): (QPainter::pen): (KJavaAppletWidget::KJavaAppletWidget): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (Widget::setIsSelected): (QLineEdit::text): (Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (QPainter::paintingDisabled): (QComboBox::QComboBox): (QPainter::drawConvexPolygon): (Widget::setFont): (QSlider::setMaxValue): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QTextEdit::setSelectionRange): (ScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (ScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (Widget::setCursor): (QLineEdit::setAutoSaveName): (QComboBox::baselinePosition): (QComboBox::appendItem): (QPainter::setShadow): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (QSlider::QSlider): (ScrollView::setVScrollBarMode): (QPainter::drawScaledAndTiledImage): (ScrollView::scrollYOffset): (QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (ScrollView::setScrollBarsMode): (QComboBox::sizeHint): (QPainter::drawRect): (QFont::setPixelSize): (Widget::setFrameGeometry): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (QFont::operator==): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (QPainter::setFont): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (QPainter::drawLineForMisspelling): (QLineEdit::setText): (QSlider::value): (QListBox::setSelectionMode): (KWQFileButton::setFilename): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (ScrollView::updateContents): (QFontMetrics::floatWidth): (ScrollView::setHScrollBarMode): (KWQFileButton::focusPolicy): (QListBox::setFont): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (KWQFileButton::setFrameGeometry): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (QTextEdit::setFont): (QLineEdit::setFont): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QSlider::setFont): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar): (Path::operator=): (QLineEdit::setColors): (QTextEdit::setColors): (searchableIndexIntroduction): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookie): (WebCore::screenRect): (WebCore::Widget::clearFocus): (WebCore::historyContains): (KWQFindNextSentenceFromIndex): (KWQFindSentenceBoundary): (KWQFindNextWordFromIndex): (KWQFindWordBoundary): (submitButtonDefaultLabel): (inputElementAltText): (resetButtonDefaultLabel): (KWQKCookieJar::cookieEnabled): (WebCore::Widget::setFocus): (WebCore::QPainter::fillRect): (WebCore::QPainter::~QPainter): (WebCore::ScrollView::viewportToContents): (WebCore::TransferJob::kill): (WebCore::TransferJob::addMetaData): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::error): (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::TransferJob::TransferJob): (WebCore::Widget::hide): (KLocale::language): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::screenDepth): (QFont::italic): (QFontMetrics::operator=): (QFontMetrics::xHeight): (WebCore::usableScreenRect): (QFont::operator=): (Widget::setActiveWindow): (KWQCheckIfReloading): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (KWQCheckCacheObjectStatus):

5:17 PM Changeset in webkit [13030] by tomernic

3 edits in trunk/WebKit

Reviewed by Adele.

<rdar://problem/4222043> Safari should reduce null events sent to invisible plugins

Plugins/WebBaseNetscapePluginView.h:
Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Check to see if the plugin view is completely obscured (scrolled out of view, for example). If it is obscured and it wasn't before, or the other way around, then restart the null event timer so it can fire at the appropriate rate. (-[WebBaseNetscapePluginView viewHasMoved:]): If a plugin is obscured, send it null events as if it were in an inactive window.

5:00 PM Changeset in webkit [13029] by eseidel

14 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Fix xcode project after previous KWQLogging move.

WebCore.xcodeproj/project.pbxproj:
platform/Logging.h:

4:41 PM Changeset in webkit [13028] by justing

5 edits
2 adds in trunk

LayoutTests:

Reviewed by darin

Test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

fast/events/onclick-list-marker-expected.txt: Added.
fast/events/onclick-list-marker.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

Consider the case of outside list markers in nodeAtPoint. Had to pull
the code out of RenderListMarker::paint that computed the position/size
of the list marker.

Added:

fast/events/onclick-list-marker.html

rendering/render_list.cpp: (RenderListItem::nodeAtPoint): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::nodeAtPoint): (RenderListMarker::getRelativeMarkerRect):
rendering/render_list.h:
rendering/render_object.h:

4:19 PM Changeset in webkit [13027] by eseidel

15 edits
2 moves in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Move KWQLogging to platform and rename as Logging.*, fix headers.
This will break the mac build, which I will fix on my next commit.

WebCore.vcproj/WebCore/WebCore.vcproj:
dom/DocumentImpl.cpp:
dom/dom_position.cpp:
editing/DeleteSelectionCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/InsertTextCommand.cpp:
editing/VisiblePosition.cpp:
editing/markup.cpp:
khtml/ecma/kjs_window.cpp:
kwq/KWQLogging.h: Removed.
kwq/KWQLogging.m: Removed.
kwq/KWQRegExp.cpp:
kwq/KWQTextStream.cpp:
platform/Logging.cpp: Added.
platform/Logging.h: Added.
platform/QString.cpp:
platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::vScrollBarMode): (WebCore::theme):

4:05 PM Changeset in webkit [13026] by eseidel

7 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix a bunch more link errors in the win32 build, mostly by adding stubs.

WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
platform/PlugInInfoStore.h:
platform/mac/PlugInInfoStoreMac.mm:
platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs. (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::Widget::hide): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (QFont::QFont): (QFont::~QFont): (QFont::italic): (QFont::weight): (QFontMetrics::QFontMetrics): (QFontMetrics::~QFontMetrics): (QFontMetrics::xHeight): (Widget::setActiveWindow): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode):

3:47 PM Changeset in webkit [13025] by thatcher

6 copies in tags/Safari-521.8

New tag.

3:43 PM Changeset in webkit [13024] by thatcher

4 edits in branches/Safari-Leo-branch

Versioning

3:23 PM Changeset in webkit [13023] by eseidel

2 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by timo.

Add missing include to fix build.

platform/win/TemporaryLinkStubs.cpp:

3:08 PM Changeset in webkit [13022] by eseidel

1 edit
2 adds in trunk/LayoutTests

2006-02-25 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Test new PlugInInfoStore class (used to be KConfig).

plugins/plugin-javascript-access-expected.txt: Added.
plugins/plugin-javascript-access.html: Added.

3:08 PM Changeset in webkit [13021] by eseidel

3 edits in trunk/WebKitTools

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Test new KConfig -> PlugInInfoStore change.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

DumpRenderTree/DumpRenderTree.m: (main): load test netscape plugin
Scripts/run-webkit-tests: style update

3:07 PM Changeset in webkit [13020] by eseidel

4 edits
2 moves
1 delete in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Move KConfig to platform/PlugInInfoStore and add test.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

Test: plugins/plugin-javascript-access.html

ForwardingHeaders/kconfig.h: Removed.
WebCore.xcodeproj/project.pbxproj:
khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase):
khtml/ecma/kjs_window.cpp:
kwq/KWQKConfigBase.h: Removed.
kwq/KWQKConfigBase.mm: Removed.
platform/PlugInInfoStore.h: Added.
platform/mac/PlugInInfoStoreMac.mm: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::refreshPlugins):

2:43 PM Changeset in webkit [13019] by darin

2 edits in trunk/WebCore

Reviewed by Eric.

platform/win/TemporaryLinkStubs.cpp: Added more stubs.

2:42 PM Changeset in webkit [13018] by thatcher

1 edit in trunk/WebCore/platform/mac/CursorMac.mm

Build fix for i386. Workaround for 4213314

1:55 PM Changeset in webkit [13017] by darin

3 edits in trunk/JavaScriptCore

fixed Mac Debug build, there was an unused parameter

kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread): Remove parameter name.

kjs/debugger.h: Fixed comment.

1:40 PM Changeset in webkit [13016] by eseidel

2 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

kxmlcore/Vector.h: (KXMLCore::deleteAllValues): fix unused variable warning

1:36 PM Changeset in webkit [13015] by mjs

44 edits
1 add in trunk/JavaScriptCore

Reviewed by Darin.

Turn off -Wno-unused-param for JavaScriptCore and get rid of unused params http://bugzilla.opendarwin.org/show_bug.cgi?id=7384

JavaScriptCore.xcodeproj/project.pbxproj:
bindings/NP_jsobject.cpp: (jsAllocate): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
bindings/c/c_class.h: (KJS::Bindings::CClass::constructorAt):
bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
bindings/jni/jni_class.cpp: (JavaClass::methodsNamed): (JavaClass::fieldNamed):
bindings/jni/jni_instance.cpp: (JavaInstance::invokeDefaultMethod):
bindings/jni/jni_jsobject.cpp:
bindings/jni/jni_objc.mm: (-[NSObject KJS::Bindings::]):
bindings/objc/WebScriptObject.mm: (+[WebUndefined allocWithZone:]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
bindings/objc/objc_class.h: (KJS::Bindings::ObjcClass::constructorAt):
bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fallbackObject):
bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField):
bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::getOwnPropertySlot): (ObjcFallbackObjectImp::put): (ObjcFallbackObjectImp::canPut): (ObjcFallbackObjectImp::deleteProperty): (ObjcFallbackObjectImp::toBoolean):
bindings/runtime.cpp: (KJS::Bindings::Instance::createLanguageInstanceForValue):
bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField):
bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter): (RuntimeArray::put): (RuntimeArray::deleteProperty):
bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::execute):
bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::deleteProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):
bindings/runtime_root.cpp: (performJavaScriptAccess):
kjs/array_object.cpp: (ArrayInstance::lengthGetter): (ArrayInstance::getOwnPropertySlot): (ArrayPrototype::ArrayPrototype): (ArrayPrototype::getOwnPropertySlot):
kjs/bool_object.cpp: (BooleanObjectImp::BooleanObjectImp):
kjs/date_object.cpp: (KJS::DateObjectFuncImp::DateObjectFuncImp): (KJS::DateObjectFuncImp::callAsFunction):
kjs/error_object.cpp: (ErrorObjectImp::ErrorObjectImp): (NativeErrorPrototype::NativeErrorPrototype): (NativeErrorImp::NativeErrorImp):
kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::put):
kjs/function_object.cpp: (FunctionObjectImp::FunctionObjectImp):
kjs/internal.cpp: (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean):
kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
kjs/lexer.cpp: (Lexer::makeIdentifier): (Lexer::makeUString):
kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter):
kjs/nodes.cpp: (StatementNode::processFuncDecl): (PropertyNode::evaluate): (PropertyNameNode::evaluate):
kjs/number_object.cpp: (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getOwnPropertySlot):
kjs/object.cpp: (KJS::JSObject::defineGetter): (KJS::JSObject::defineSetter): (KJS::JSObject::hasInstance): (KJS::JSObject::propertyIsEnumerable):
kjs/object_object.cpp: (ObjectObjectImp::ObjectObjectImp):
kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): (KJS::PropertySlot::functionGetter):
kjs/reference.cpp: (KJS::Reference::getPropertyName):
kjs/reference_list.cpp: (ReferenceListIterator::operator++):
kjs/regexp_object.cpp: (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter): (StringPrototype::StringPrototype):
kxmlcore/Assertions.mm:
kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_PageHeap::CheckList):
kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::checkValidity): (KXMLCore::IdentityHashTranslator::translate):
pcre/pcre_get.c: (pcre_get_stringnumber):

1:31 PM Changeset in webkit [13014] by eseidel

6 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Reworked KConfig and plugin architecture to be much more sane.
This is part one. Once this lands, I'll move it under platform with a better name.

Darin had several great suggested further improvements as part of:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
I'll make some of those when I move this to platform.

No layout test possible (no way to control which plugins DRT sees).

khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
khtml/ecma/kjs_navigator.h:
khtml/ecma/kjs_window.cpp:
kwq/KWQKConfigBase.h: (WebCore::PluginInfoStore::PluginInfoStore):
kwq/KWQKConfigBase.mm: (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PluginInfoStore::pluginCount): (WebCore::refreshPlugins):

1:01 PM Changeset in webkit [13013] by eseidel

2 edits in trunk/WebCore

2006-02-27 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Build fix: cast to unsigned from size_t.

platform/StreamingTextDecoder.cpp:

12:17 PM Changeset in webkit [13012] by mjs

2 edits in trunk/WebCore

Reviewed by Darin.

add Selection.cpp to win32 build http://bugzilla.opendarwin.org/show_bug.cgi?id=7490

WebCore.vcproj/WebCore/WebCore.vcproj:

12:11 PM Changeset in webkit [13011] by mjs

2 edits in trunk/WebCore

use proper header for std::min.

platform/StreamingTextDecoder.cpp:

11:30 AM Changeset in webkit [13010] by mjs

5 edits in trunk/WebCore

Reviewed by Darin.

add new TextEncoding stuff to win32 build http://bugzilla.opendarwin.org/show_bug.cgi?id=7491

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.vcproj/WebCore/build-generated-files.sh:
platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convertUTF16):
platform/TextEncoding.cpp:

9:58 AM Changeset in webkit [13009] by darin

2 edits in trunk/WebCore

try to fix Windows build

WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.

9:23 AM Changeset in webkit [13008] by darin

2 edits in trunk/WebCore

css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling back to that; apologies for the churn.

9:06 AM Changeset in webkit [13007] by darin

2 edits in trunk/WebCore

css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.

9:00 AM Changeset in webkit [13006] by darin

2 edits in trunk/WebCore

css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version of this file.

8:55 AM Changeset in webkit [13005] by darin

16 edits in trunk/WebCore

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7486 a first step in improving String/StringImpl API -- use "s" and "l" less

css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than manipulating the characters directly inside a StringImpl buffer.

css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse it rather than going out of our way to hack StringImpl to not copy the data. It would be better not to copy, but this is one-time work.

dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): (WebCore::QCharBufferTranslator::equal): (WebCore::AtomicString::add):
platform/StringImpl.h: (WebCore::StringImpl::unicode): Added. (KXMLCore::CaseInsensitiveHash::hash): (KXMLCore::CaseInsensitiveHash::equal):
rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
rendering/RenderText.cpp: (WebCore::getCharacterBreakIterator): (WebCore::RenderText::RenderText): (WebCore::RenderText::atLineWrap): (WebCore::RenderText::allAscii): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setSelectionState): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setText): (WebCore::RenderText::width): (WebCore::RenderText::selectionRect): (WebCore::RenderText::caretMaxOffset):
rendering/RenderTextFragment.cpp: (khtml::RenderTextFragment::RenderTextFragment): (khtml::RenderTextFragment::originalString): Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].

editing/visible_units.cpp: (WebCore::startOfParagraph): Use const. (WebCore::endOfParagraph): Ditto.

2:49 AM Changeset in webkit [13004] by mjs

2 edits in trunk/WebCore

fix problem with a prototype that broke win32 build

platform/StreamingTextDecoder.h: (WebCore::StreamingTextDecoder::convert):

2:02 AM Changeset in webkit [13003] by mjs

2 edits in trunk/WebCore

fix debug build (broken by my last commit)

platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::StreamingTextDecoder::convertUsingICU):

1:17 AM Changeset in webkit [13002] by mjs

27 edits
3 copies
8 moves
2 adds
1 delete in trunk/WebCore

Reviewed by Darin.

platformize KWQTextCodec http://bugzilla.opendarwin.org/show_bug.cgi?id=7487

I renamed QTextCodec to TextEncoding and QTextDecoder to
StreamingTextDecoder. I also made a bunch of other changes to make
the API more sensible.

ForwardingHeaders/qtextcodec.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bridge/mac/MacFrame.mm:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge textEncoding]): (+[WebCoreFrameBridge stringWithData:textEncoding:]): (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::completeURL):
khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
khtml/html/FormDataList.cpp: (DOM::FormDataList::FormDataList): (DOM::FormDataList::appendString):
khtml/html/FormDataList.h:
khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::formData):
khtml/html/htmltokenizer.cpp:
khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::encodingName): (Decoder::decode):
khtml/misc/decoder.h: (khtml::Decoder::): (khtml::Decoder::visuallyOrdered): (khtml::Decoder::encoding):
khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
kwq/KWQCharsets.cpp: Removed.
kwq/KWQCharsets.h: Removed.
kwq/KWQTextCodec.cpp: Removed.
kwq/KWQTextCodec.h: Removed.
kwq/WebCoreTextDecoder.h:
kwq/WebCoreTextDecoder.mm:
kwq/can-convert.mm: Removed.
kwq/character-sets.txt: Removed.
kwq/mac-encodings.txt: Removed.
kwq/make-charset-table.pl: Removed.
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
loader/CachedCSSStyleSheet.h:
loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setCharset): (WebCore::CachedScript::data):
loader/CachedScript.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setCharset):
page/Frame.cpp: (WebCore::Frame::write): (WebCore::Frame::gotoAnchor): (WebCore::Frame::encoding): (WebCore::Frame::backslashAsCurrencySymbol):
platform/CharsetNames.cpp: Added. (KXMLCore::): (WebCore::EncodingHash::equal): (WebCore::EncodingHash::hash): (WebCore::buildDictionaries): (WebCore::textEncodingIDFromCharsetName): (WebCore::charsetNameFromTextEncodingID):
platform/CharsetNames.h: Added.
platform/KURL.cpp: (KURL::KURL): (KURL::decode_string): (encodeRelativeString):
platform/KURL.h:
platform/QString.cpp: (QString::fromUtf8):
platform/StreamingTextDecoder.cpp: Added. (WebCore::StreamingTextDecoder::StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertLatin1): (WebCore::StreamingTextDecoder::~StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertUTF16): (WebCore::effectiveEncoding): (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::unwanted): (WebCore::StreamingTextDecoder::appendOmittingUnwanted): (WebCore::StreamingTextDecoder::convertUsingICU): (WebCore::StreamingTextDecoder::convert): (WebCore::StreamingTextDecoder::toUnicode):
platform/StreamingTextDecoder.h: Added. (WebCore::StreamingTextDecoder::convert):
platform/TextEncoding.cpp: Added. (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::name): (WebCore::effectiveEncoding): (WebCore::TextEncoding::backslashAsCurrencySymbol): (WebCore::TextEncoding::toUnicode):
platform/TextEncoding.h: Added. (WebCore::): (WebCore::TextEncoding::): (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::isValid): (WebCore::TextEncoding::usesVisualOrdering): (WebCore::TextEncoding::isJapanese): (WebCore::TextEncoding::encodingID): (WebCore::TextEncoding::flags): (WebCore::operator==): (WebCore::operator!=):
platform/character-sets.txt: Added.
platform/mac/ExtraCFEncodings.h: Added.
platform/mac/QStringMac.mm:
platform/mac/TextEncodingMac.cpp: Added. (WebCore::effectiveEncoding): (WebCore::TextEncoding::fromUnicode):
platform/mac/can-convert.mm: Added.
platform/mac/mac-encodings.txt: Added.
platform/make-charset-table.pl: Added.
platform/win/win-encodings.txt: Added.
rendering/render_object.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::slotData):

12:24 AM Changeset in webkit [13001] by darin

2 edits in trunk/WebCore

fix Windows build

platform/win/TemporaryLinkStubs.cpp: Change KIO::TransferJob to WebCore::TransferJob.

12:13 AM Changeset in webkit [13000] by darin

26 edits
1 add
1 delete in trunk/WebCore

Reviewed by Maciej.

merged Job and TransferJob into TransferJob and moved it to WebCore namespace
changed TransferJob to use a TransferJobClient object instead of signals

ForwardingHeaders/kio/job.h: Changed to point to "KWQKJobClasses.h".
kwq/KWQKJob.h: Removed.
kwq/TransferJobClient.h: Added.

WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
WebCore.xcodeproj/project.pbxproj: Ditto.

dom/xml_tokenizer.cpp: (WebCore::openFunc):
khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post".

kwq/KWQKJobClasses.h: Eliminate Job. Add a TransferJobClient* parameter to TransferJob. Eliminate the deliverAllData parameter to TransferJob constructor. Remove the signals from TransferJob.
kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): Store a client pointer. (WebCore::TransferJob::TransferJob): Store a client pointer, remove the deliverAllData boolean. (WebCore::TransferJob::receivedResponse): Added. Replaces the old emitReceivedResponse function; uses client instead of a signal. (WebCore::TransferJob::client): Added.

kwq/KWQLoader.h: Switched things to mention the WebCore namespace. Changed KIO::TransferJob to WebCore::TransferJob.
kwq/KWQLoader.mm: Ditto.

kwq/KWQObject.h:
kwq/KWQObject.cpp: Removed isKHTMLLoader.

kwq/KWQResourceLoader.h: Changed KIO::TransferJob to WebCore::TransferJob.
kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): Call receivedResponse function on the job instead of emitReceivedResponse. (-[KWQResourceLoader redirectedToURL:]): Call receivedRedirect function on the client directly instead of emitRedirection on the job. (-[KWQResourceLoader addData:]): Call receivedData function on the client directly instead of emitData on the job. (-[KWQResourceLoader finishJobAndHandle:]): Call receivedAllData function on the client directly instead of emitResult on the job. Also fixed a potential memory leak where the handle was not released if the job was 0.

kwq/KWQSignal.h:
kwq/KWQSignal.cpp:
kwq/KWQSlot.h:
kwq/KWQSlot.cpp: Removed the job-related signals and slots.

loader/CachedObject.h: Removed unneeded declaration of TransferJob.

loader/loader.h:
loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use "new TransferJob" instead of "KIO::get". Also don't connect signals. (WebCore::Loader::receivedAllData): New name for slotFinished. (WebCore::Loader::receivedResponse): New name for slotReceivedResponse. (WebCore::Loader::receivedData): New name for slotData. (WebCore::Loader::cancelRequests): Changed KIO::Job to TransferJob. (WebCore::Loader::jobForRequest): Ditto.

page/Frame.h:
page/Frame.cpp: (WebCore::Frame::didOpenURL): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::Frame::receivedAllData): Renamed from slotFinished. Also slightly cleaned up the logic. (WebCore::Frame::receivedRedirect): Renamed from slotRedirection.
page/FramePrivate.h: Changed KIO::TransferJob to WebCore::TransferJob.

xml/xmlhttprequest.h:
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Eliminate XMLHttpRequestQObject. (WebCore::XMLHttpRequest::send): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::XMLHttpRequest::processSyncLoadResults): Change to call the functions by their new names (names changed to use with TransferJobClient). (WebCore::XMLHttpRequest::receivedAllData): Renamed from slotFinished. (WebCore::XMLHttpRequest::receivedRedirect): Renamed from slotRedirection. (WebCore::XMLHttpRequest::receivedData): Renamed from slotData.

Feb 26, 2006:

10:34 PM Changeset in webkit [12999] by ggaren

2 edits in trunk/WebKitSite

Reviewed by Maciej, landed by Geoff.

Change "Deployment" to "Release" and "Development" to "Debug".
Update latest Xcode version from 2.2 to 2.2.1.

building/build.html

10:30 PM Changeset in webkit [12998] by ggaren

1 edit
4 adds in trunk/LayoutTests

Reviewed by Maciej, landed by Geoff.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=4977 <form> not being displayed at all.

fast/forms/form-hides-table-expected.checksum: Added.
fast/forms/form-hides-table-expected.png: Added.
fast/forms/form-hides-table-expected.txt: Added.
fast/forms/form-hides-table.html: Added.

10:22 PM Changeset in webkit [12997] by ggaren

3 edits
2 adds in trunk

LayoutTests:

Test by Geoff, automated by me, reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7293 REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit

fast/frames/empty-frame-document-expected.txt: Added.
fast/frames/empty-frame-document.html: Added.

WebKit:

Test: fast/frames/empty-frame-document.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7293 REGRESSION: Using Javascript Bookmarklets that reference location.href on a blank tab crashes WebKit

The crash happened because an empty frame did not have a document.

WebView/WebFrame.m: (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty frames. This causes a document to be created for the frame.

8:08 PM Changeset in webkit [12996] by darin

3 edits in trunk/WebCore

try again after seeing errors from buildbot

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/CachedImage.cpp: (WebCore::CachedImage::data): Add APPLE ifdefs to two more uses of response.

7:50 PM Changeset in webkit [12995] by darin