Context Navigation

Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
Spinneret/Spinneret/WebView.h:

1:45 PM Changeset in webkit [13100] by justing

3 edits
4 adds in trunk

LayoutTests:

Patch reviewed by sullivan
Test written by mitz

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

fast/lists/scrolled-marker-paint-expected.checksum: Added.
fast/lists/scrolled-marker-paint-expected.png: Added.
fast/lists/scrolled-marker-paint-expected.txt: Added.
fast/lists/scrolled-marker-paint.html: Added.

WebCore:

Reviewed by sullivan

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7542>
REGRESSION: (r13028) Scrolling causes incomplete drawing of <ul> bullets

rendering/render_list.cpp: (WebCore::RenderListMarker::paint):

1:41 PM Changeset in webkit [13099] by eseidel

6 edits
2 adds in trunk/WebCore

2006-03-02 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Add (partially stubbed out) mouse event handling for Win32.

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/IntPoint.h:
platform/MouseEvent.h:
platform/win/IntPointWin.cpp: Added. (WebCore::IntPoint::IntPoint): (WebCore::IntPoint::operator POINT):
platform/win/MouseEventWin.cpp: Added. (WebCore::MouseEvent::MouseEvent):
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setMaxLength): (ScrollView::scrollBy): (WebCore::Widget::setFocus): (FrameWin::respondToChangedSelection): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::registerCommandForUndo): (FrameWin::addMessageToConsole): (FrameWin::mimeTypeForFileName): (FrameWin::shouldChangeSelection): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::personalbarVisible): (FrameWin::objectContentType): (FrameWin::createFrame): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (FrameWin::passSubframeEventToSubframe): (FrameWin::lastEventIsMouseUp): (BrowserExtensionWin::BrowserExtensionWin): (Widget::setCursor): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents): (TransferJob::TransferJob): (TransferJob::addMetaData):

11:40 AM Changeset in webkit [13098] by justing

3 edits
2 adds in trunk

LayoutTests:

Reviewed by mjs

<http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

editing/undo/undo-iframe-location-change-expected.txt: Added.
editing/undo/undo-iframe-location-change.html: Added.

WebCore:

Reviewed by mjs

<http://tinymce.moxiecode.com/example_full.php?example=true>
TinyMCE: Undo still enabled after a location change, crashes if performed

Can't clear undo/redo operations registered by subframes in didOpenURL,
because subframes have already been detached.

page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::closeURL):

11:37 AM Changeset in webkit [13097] by thatcher

1 copy in tags/WebCore-417.23/WebCore

New tag part two).

11:37 AM Changeset in webkit [13096] by thatcher

1 add in tags/WebCore-417.23

New tag.

11:35 AM Changeset in webkit [13095] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.23

11:32 AM Changeset in webkit [13094] by thatcher

7 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch
This also includes the http://bugzilla.opendarwin.org/show_bug.cgi?id=7363 fix
<rdar://problem/4462712> REGRESSION (r12872): Repro crash when clicking the Quick Reply box in Gmail

2006-02-17 Vicki Murley <vicki@apple.com>

Reviewed by Justin.

Get rid of handleFocusOut on text fields and textareas - move this functionality to the place
where we resign focus on the previous node in setFocusNode. Add isTextField on RenderObject
as one way to distinguish from contenteditable elements - Win IE does not fire onChange for
contenteditable elements, so we won't either. Also, expose the dirty bit variables previously
checked in handleFocusOut methods in isEdited() and setEdited().

Fixes the following bugs:
<rdar://problem/4315673> REGRESSION (1.2.2 - 1.3): onChange and onFocus events firing order differs for mouse click and tab (7227)
<rdar://problem/4447009> for text fields, onChange should fire before onBlur to match Win IE

Test case is on the way.

dom/DocumentImpl.cpp: (WebCore::DocumentImpl::setFocusNode): For textareas and text fields, fire a change event on the node that is resigning focus. Make sure the blur event fires after the change event - 4447009.
rendering/render_form.cpp: (WebCore::RenderLineEdit::slotReturnPressed): Replace call to handleFocusOut with equivalent code. (WebCore::RenderLineEdit::isEdited): Added. (WebCore::RenderLineEdit::setEdited): Added. (WebCore::RenderTextArea::setEdited): Added.
rendering/render_form.h: (WebCore::RenderLineEdit::isTextField): Added. (WebCore::RenderTextArea::isTextArea): Make this non-virtual. (WebCore::RenderTextArea::isEdited): Added.
rendering/render_object.h: (WebCore::RenderObject::isEdited): Added. (WebCore::RenderObject::setEdited): Added. (WebCore::RenderObject::isTextField): Added.
rendering/render_replaced.h: Remove handleFocusOut().
rendering/render_replaced.cpp: Ditto. (WebCore::RenderWidget::eventFilter): Remove call to handleFocusOut(). Safe to do here, since we call setFocusNode immediately beforehand.

2:35 AM Changeset in webkit [13093] by mjs

2 edits in trunk/JavaScriptCore

now fix mac build again

kjs/identifier.cpp:

2:20 AM Changeset in webkit [13092] by mjs

3 edits in trunk/JavaScriptCore

Rubber stamped by Anders and Eric.

add fpconst.cpp to win32 build, it is now needed

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
kjs/fpconst.cpp:

2:10 AM Changeset in webkit [13091] by mjs

5 edits in trunk/JavaScriptCore

Reviewed by Eric.

fix windows build, broken by my last patch

kjs/JSImmediate.cpp:
kjs/identifier.cpp:
kxmlcore/FastMalloc.cpp:
kxmlcore/Platform.h:

1:21 AM Changeset in webkit [13090] by eseidel

52 edits in trunk

Add svn:eol-style=native, and fix line endings.

1:12 AM Changeset in webkit [13089] by mjs

62 edits
4 adds in trunk

JavaScriptCore:

Reviewed by Darin.

Set up new prototype macros and avoid using #if without defined() in JSC

Added new PLATFORM macros and related, to make sure #if's all check if relevant macros
are defined, and to separate core OS-level dependencies from operating environment
dependencies so you can, e.g., build KDE on Mac or Windows.

kxmlcore/Platform.h: Added.

deploy them everywhere in JavaScriptCore

JavaScriptCore.xcodeproj/project.pbxproj:
bindings/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
bindings/objc/WebScriptObject.mm:
bindings/objc/objc_instance.mm: (ObjcInstance::end):
bindings/softlinking.h:
bindings/testbindings.mm: (main):
kjs/JSLock.cpp:
kjs/collector.cpp: (KJS::Collector::markCurrentThreadConservatively): (KJS::Collector::markOtherThreadConservatively): (KJS::Collector::markStackObjectsConservatively):
kjs/config.h:
kjs/date_object.cpp: (gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::makeTime):
kjs/dtoa.cpp:
kjs/fpconst.cpp: (KJS::sizeof): (KJS::):
kjs/grammar.y:
kjs/identifier.cpp:
kjs/internal.cpp:
kjs/interpreter.cpp: (KJS::Interpreter::evaluate): (KJS::Interpreter::createLanguageInstanceForValue):
kjs/interpreter.h:
kjs/lookup.cpp:
kjs/lookup.h:
kjs/math_object.cpp:
kjs/object.cpp:
kjs/object.h:
kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf):
kjs/operations.h:
kjs/regexp.cpp: (KJS::RegExp::RegExp): (KJS::RegExp::~RegExp): (KJS::RegExp::match):
kjs/regexp.h:
kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS):
kjs/ustring.cpp:
kjs/ustring.h:
kxmlcore/AlwaysInline.h:
kxmlcore/Assertions.cpp:
kxmlcore/Assertions.h:
kxmlcore/FastMalloc.cpp: (KXMLCore::):
kxmlcore/FastMalloc.h:
kxmlcore/FastMallocInternal.h:
kxmlcore/HashTable.h:
kxmlcore/TCPageMap.h:
kxmlcore/TCSpinLock.h: (TCMalloc_SpinLock::Lock): (TCMalloc_SpinLock::Unlock): (TCMalloc_SlowLock):
kxmlcore/TCSystemAlloc.cpp: (TCMalloc_SystemAlloc):
os-win32/stdint.h:

JavaScriptGlue:

Not reviewed, but I noticed these trivial extra changes were needed to avoid
breaking the build with my reviewed patch for:

http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

Add config.h, includes of it, and Platform.h forwarding header.

JSBase.cpp:
JSObject.cpp:
JSRun.cpp:
JSUtils.cpp:
JSValueWrapper.cpp:
JavaScriptGlue.cpp:
UserObjectImp.cpp:
config.h: Added.
kxmlcore/Platform.h: Added.

WebCore:

Reviewed by Darin.

WebCore updates for "Set up new prototype macros and avoid using #if without defined() in JSC" http://bugzilla.opendarwin.org/show_bug.cgi?id=7387

Add Platform.h

ForwardingHeaders/kxmlcore/Platform.h: Added.
bridge/mac/WebCoreFrameNamespaces.m:
bridge/mac/WebCoreViewFactory.m:
bridge/mac/WebDashboardRegion.m:
config.h:
platform/Logging.cpp:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::addChild):
platform/mac/WebCoreCookieAdapter.m:
platform/mac/WebCoreGraphicsBridge.m:
platform/mac/WebCoreHistory.m:
platform/mac/WebCoreImageRendererFactory.m:
platform/mac/WebCoreKeyGenerator.m:
platform/mac/WebCoreView.m:

12:39 AM Changeset in webkit [13088] by eseidel

2 edits in trunk/WebCore

2006-03-02 Eric Seidel <eseidel@apple.com>

WebCore.xcodeproj/project.pbxproj: update GraphicsContext.cpp path to fix build

12:21 AM Changeset in webkit [13087] by eseidel

6 edits in trunk/WebKitTools

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

Make spinneret take advantage of the new GraphicsContextCairo.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): updated to match style guidelines.
Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WndProc):
Spinneret/Spinneret/WebView.h:

12:20 AM Changeset in webkit [13086] by eseidel

6 edits
1 move in trunk/WebCore

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Add first-stab GraphicsContextCairo.

Shuffle a few more link stubs around, remove uncessary WebCore

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/GraphicsContext.cpp: Added.
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::setColor): (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::adjustLineToPixelBounderies): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled):
platform/cairo/ImageCairo.cpp:
platform/cg/GraphicsContextCG.cpp: Removed.
platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (Widget::mapFromGlobal): (QLineEdit::cursorPosition): (QTextEdit::setScrollBarModes): (QTextEdit::selectAll): (QComboBox::focusPolicy): (GraphicsContext::clearShadow): (QTextEdit::setCursorPosition): (GraphicsContext::drawText): (QLineEdit::setLiveSearch): (QComboBox::QComboBox): (Widget::lockDrawingFocus): (QTextEdit::setSelectionRange): (QSlider::QSlider): (ScrollView::scrollYOffset): (QComboBox::sizeHint): (QLineEdit::edited): (QTextEdit::text): (QSlider::value): (WebCore::Widget::setFocus): (WebCore::TransferJob::addMetaData): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::respondToChangedSelection): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::runJavaScriptPrompt): (FrameWin::recordFormValue): (FrameWin::registerCommandForRedo): (FrameWin::runJavaScriptAlert): (FrameWin::runJavaScriptConfirm): (FrameWin::openURL): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::registerCommandForUndo): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::addMessageToConsole): (FrameWin::passWheelEventToChildWidget): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::shouldChangeSelection): (FrameWin::scheduleClose): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::markMisspellings): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::lastEventIsMouseUp): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::userAgent): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::objectContentType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (FrameWin::generateFrameName): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (GraphicsContext::GraphicsContext): (QFontMetrics::isFixedPitch): (FrameWin::restoreDocumentState): (FrameWin::partClearedInBegin): (FrameWin::createEmptyDocument): (FrameWin::overrideMediaType): (FrameWin::setTitle): (FrameWin::handledOnloadEvents): (FrameWin::markedTextRange): (GraphicsContext::font): (GraphicsContext::setFont):

Mar 1, 2006:

10:24 PM Changeset in webkit [13085] by ap

3 edits in trunk/WebKit

Fixed a typo in the comments added in the previous checkin.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

9:58 PM Changeset in webkit [13084] by ap

3 edits in trunk/WebKit

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7540 REGRESSION: frequent cache-related crashes

http://bugzilla.opendarwin.org/show_bug.cgi?id=7393 A stale comment about XMLHttpRequest responses being never cached

WebCoreSupport/WebFrameBridge.m: Don't call setHTTPHeader if the method is GET. (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
WebCoreSupport/WebSubresourceLoader.m: Ditto. Also removed a stale comment about XMLHTTPRequests. (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

9:55 PM Changeset in webkit [13083] by ap

2 edits in trunk/WebCore

Reviewed by Darin.

Changed an Objective-C forward declaration from "class" to "@class".
This doesn't appear to fix any problems, though.

platform/StringImpl.h:

9:24 PM Changeset in webkit [13082] by justing

2 edits in trunk/LayoutTests/editing/unsupported-content

harrison forgot to update these pixel results. We should probably move this test out of unsupported-content, since lists are no longer unsupported, but i'll let him do that when he gets back.

9:12 PM Changeset in webkit [13081] by justing

5 edits
5 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

editing/resources/select-all-iframe-src.html: Added.
editing/selection/select-all-iframe-expected.checksum: Added.
editing/selection/select-all-iframe-expected.png: Added.
editing/selection/select-all-iframe-expected.txt: Added.
editing/selection/select-all-iframe.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7059>
TinyMCE: Select All + delete sends you Back intsead of deleting

page/Frame.cpp: (WebCore::Frame::selectFrameElementInParentIfFullySelected):

WebKitTools:

Reviewed by darin

Give the events that eventSender sends a unique eventNumber

DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):

7:33 PM Changeset in webkit [13080] by harrison

3 edits in trunk/WebKit

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".

WebView/WebHTMLView.m: (-[WebHTMLView _canIncreaseSelectionListLevel]): (-[WebHTMLView _canDecreaseSelectionListLevel]): (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _decreaseSelectionListLevel]):
WebView/WebHTMLViewPrivate.h:

7:32 PM Changeset in webkit [13079] by harrison

3 edits in trunk/WebCore

Reviewed by Justin.
(missed these in my earlier commit for <rdar://problem/4359736>)

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):

6:43 PM Changeset in webkit [13078] by eseidel

1 edit
14 adds in trunk/WebKitTools

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Add a stub win32 application to test WebCore drawing on windows.

Spinneret: Added.
Spinneret/Spinneret: Added.
Spinneret/Spinneret.sln: Added.
Spinneret/Spinneret/Resource.h: Added.
Spinneret/Spinneret/Spinneret.cpp: Added. (_tWinMain): (MyRegisterClass): (InitInstance): (WndProc): (About):
Spinneret/Spinneret/Spinneret.h: Added.
Spinneret/Spinneret/Spinneret.ico: Added.
Spinneret/Spinneret/Spinneret.rc: Added.
Spinneret/Spinneret/Spinneret.vcproj: Added.
Spinneret/Spinneret/WebView.cpp: Added. (WebKit::WebView::WebViewPrivate::WebViewPrivate): (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebView::WebView): (WebKit::WebView::~WebView): (WebKit::WebView::drawRect): (WebKit::WebView::windowHandle): (WebKit::WndProc):
Spinneret/Spinneret/WebView.h: Added.
Spinneret/Spinneret/small.ico: Added.
Spinneret/Spinneret/stdafx.cpp: Added.
Spinneret/Spinneret/stdafx.h: Added.

6:17 PM Changeset in webkit [13077] by eseidel

6 edits
2 adds in trunk/WebCore

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix win32 build, add IntRectWin and GraphicsContextCairo stub.

Viewer/ImageDocument.cpp:
Viewer/ImageMainFrame.cpp:
WebCore.vcproj/WebCore/WebCore.vcproj:
platform/IntRect.h:
platform/cairo/GraphicsContextCairo.cpp: Added.
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForText): (WebCore::GraphicsContext::fillRect): (WebCore::TransferJob::TransferJob): (GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext):

6:12 PM Changeset in webkit [13076] by harrison

3 edits in trunk/LayoutTests

Updated test case after improving list deletion.

<rdar://problem/4359736> Support outlining ability with lists

unsupported-content/list-delete-002-expected.txt: Updated.
unsupported-content/list-delete-002.html: Updated.

6:05 PM Changeset in webkit [13075] by harrison

8 edits
2 adds in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4359736> Support outlining ability with lists

Added Mail SPI for list level changes. It is SPI because it is not complete support
for outlining. See <rdar://problem/4457070> "API for html lists as note outlines".
Additional support is to end a list when return is typed on empty list item.

WebCore.vcproj/WebCore/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj: Added ModifySelectionListLevelCommand.cpp and ModifySelectionListLevelCommand.h

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): Supply list level calls in the bridge.

editing/InsertParagraphSeparatorCommand.cpp: (WebCore::createListItemElement): New. Creates an li.

(WebCore::InsertParagraphSeparatorCommand::doApply):

slight logic cleanup
on empty list item, end the list

editing/ModifySelectionListLevelCommand.cpp: Added. (WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand): (WebCore::ModifySelectionListLevelCommand::preservesTypingStyle): (WebCore::ModifySelectionListLevelCommand::doApply): (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore): (WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeAfter): (WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
editing/ModifySelectionListLevelCommand.h: Added. New editing command for adjusting the list level.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Slight logic cleanup

editing/htmlediting.cpp: (WebCore::isListElement): (WebCore::enclosingListChild): New helpers.

(WebCore::isTableElement):
Allow caller to pass 0... return false in that case.

editing/htmlediting.h: New helpers.

rendering/RenderContainer.cpp: (WebCore::updateListMarkerNumbers): Allow for list children that are not li nodes. Ignore and continue rather than stopping.

(WebCore::RenderContainer::addChild):
Allow for nil beforeChild, meaning "add at end".

6:00 PM Changeset in webkit [13074] by eseidel

8 edits in trunk/WebCore

2006-03-01 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Update ESelectionGranulartiy enum to use newer CamelCase styling.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
editing/Selection.cpp: (WebCore::Selection::Selection): (WebCore::Selection::validate):
editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify):
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
editing/jsediting.cpp:
editing/text_granularity.h: (WebCore::):
page/Frame.cpp: (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventSelection):

12:55 PM Changeset in webkit [13073] by lypanov

7 edits in trunk

2006-03-01 Alexander Kellett <lypanov@kde.org>

Reviewed by Maciej.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5966

Fixes already existing test:

svg/W3C-SVG-1.1/coords-viewattr-02-b.svg

kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
kcanvas/RenderSVGImage.h:

2006-03-01 Alexander Kellett <lypanov@kde.org>

http://bugzilla.opendarwin.org/show_bug.cgi?id=5966 Update expected results

svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:

9:56 AM Changeset in webkit [13072] by thatcher

2 edits in trunk

Forgot to add the radar to my changelog entries.

9:54 AM Changeset in webkit [13071] by ap

16 edits
5 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=3812 XMLHttpRequest: PUT, DELETE, HEAD and all other methods but POST actually do a GET.

HEAD is currently unimplemented because of what seems to be a bug in NSURLConnection,
and does a GET instead.

WebCore:

kwq/KWQKJobClasses.h: Add a method parameter to TransferJob.
kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::method):
bridge/mac/WebCoreFrameBridge.h: URL loading functions now take a method parameter.
dom/xml_tokenizer.cpp: (WebCore::openFunc):
khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc):
kwq/KWQLoader.mm: (KWQServeRequest): (KWQServeSynchronousRequest):
loader/loader.cpp: (WebCore::Loader::servePendingRequests):
page/Frame.cpp: (WebCore::Frame::didOpenURL):
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Honor the method passed in open().
khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Don't serialize null as "null".

WebKit:

All WebKit changes are to use the method parameter passed from WebCore.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
WebCoreSupport/WebSubresourceLoader.h:
WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forDataSource:]): (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forDataSource:]):

LayoutTests:

http/tests/xmlhttprequest/methods-async-expected.txt: Added.
http/tests/xmlhttprequest/methods-async.html: Added.
http/tests/xmlhttprequest/methods-expected.txt: Added.
http/tests/xmlhttprequest/methods.cgi: Added.
http/tests/xmlhttprequest/methods.html: Added.

9:49 AM Changeset in webkit [13070] by thatcher

17 edits
2 adds in trunk

WebCore:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary

Support for WebKit. This removes the old elementAtPoint: on the bridge.
WebKit now uses the bridge method getInnerNonSharedNode:innerNode:URLElement:atPoint:

WebCore.exp: removes the WebCore* dictionary keys
bindings/objc/DOM.mm: (-[DOMElement image]): new method to get an NSImage if the element has an image renderer
bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): new method that returns the title after doing the backslash as currency symbol conversion (-[DOMHTMLInputElement altDisplayString]): ditto for alt (-[DOMHTMLImageElement altDisplayString]): ditto (-[DOMHTMLAppletElement altDisplayString]): ditto (-[DOMHTMLAreaElement altDisplayString]): ditto (-[DOMHTMLAnchorElement absoluteLinkURL]): new method to get the absolute NSURL (-[DOMHTMLAreaElement absoluteLinkURL]): ditto (-[DOMHTMLLinkElement absoluteLinkURL]): ditto (-[DOMHTMLInputElement absoluteImageURL]): new method to get the absolute image location as an NSURL (-[DOMHTMLImageElement absoluteImageURL]): ditto (-[DOMHTMLObjectElement absoluteImageURL]): ditto
bindings/objc/DOMPrivate.h:
bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:]): (-[WebCoreFrameBridge isPointInsideSelection:]):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): (WebCore::DocumentImpl::backslashAsCurrencySymbol):
dom/DocumentImpl.h:
rendering/render_layer.cpp: (WebCore::RenderLayer::hitTest):
rendering/render_object.h: (WebCore::RenderObject::NodeInfo::URLElement): (WebCore::RenderObject::NodeInfo::setURLElement):

WebKit:

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7450
elementAtPoint is expensive and should return a smart dictionary

elementAtPoint for WebHTMLView now returns a WebElementDictionary,
when objectForKey is called it will lookup in the DOM, cache and return the value

Misc/WebElementDictionary.h: Added.
Misc/WebElementDictionary.m: Added. (addLookupKey): (cacheValueForKey): (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary initWithInnerNonSharedNode:innerNode:URLElement:andPoint:]): (-[WebElementDictionary dealloc]): (-[WebElementDictionary _fillCache]): (-[WebElementDictionary count]): (-[WebElementDictionary keyEnumerator]): (-[WebElementDictionary objectForKey:]): (-[WebElementDictionary _domNode]): (-[WebElementDictionary _webFrame]): (-[WebElementDictionary _targetWebFrame]): (-[WebElementDictionary _title]): (-[WebElementDictionary _imageRect]): (-[WebElementDictionary _isSelected]):
Misc/WebNSViewExtras.m: (-[NSView _web_dragImage:element:rect:event:pasteboard:source:offset:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[NSArray elementAtPoint:]):
WebView/WebView.m:
WebView/WebViewPrivate.h:

8:33 AM Changeset in webkit [13069] by darin

4 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7327 REGRESSION (r12869): :hover subselector does not work in quirks mode

fast/css/hover-subselector-expected.checksum: Added.
fast/css/hover-subselector-expected.png: Added.
fast/css/hover-subselector-expected.txt: Added.
fast/css/hover-subselector.html: Added.

WebCore:

Test: fast/css/hover-subselector.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7327 REGRESSION (r12869): :hover subselector does not work in quirks mode

css/cssstyleselector.h:
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Pass flag to indicate sub-selector. (WebCore::CSSStyleSelector::checkOneSelector): Apply the *:hover and *:active quirks only when there are no sub-selectors.

1:12 AM Changeset in webkit [13068] by mjs

3 edits in trunk/WebCore

Rubber stamped by Hyatt.

fix win32 build (and make dumprendertree run)

kwq/KWQComboBox.h:
platform/win/TemporaryLinkStubs.cpp: (QTextEdit::selectionEnd): (Widget::~Widget): (GraphicsContext::beginTransparencyLayer): (QComboBox::populate): (GraphicsContext::drawConvexPolygon): (QFontMetrics::selectionRectForText): (GraphicsContext::setShadow): (GraphicsContext::clearFocusRing): (GraphicsContext::drawImageInRect): (KWQFileButton::setFilename): (KWQFileButton::focusPolicy): (KWQFileButton::frameGeometry): (QSlider::focusPolicy): (WebCore::GraphicsContext::font): (QTextEdit::setWritingDirection): (QFontMetrics::checkSelectionPoint): (QFontMetrics::isFixedPitch): (WebCore::TransferJob::addMetaData):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed