⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 4, 2006:

9:51 PM Changeset in webkit [13134] by hyatt
  • 23 edits
    2 adds
    2 deletes in trunk/WebCore

Fix for bug 7586, eliminate QFontMetrics.

Reviewed by eric

  • WebCore.xcodeproj/project.pbxproj:
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQFontMetrics.h: Removed.
  • kwq/KWQFontMetrics.mm: Removed.
  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::~Font): (WebCore::Font::update): (WebCore::Font::width):
  • platform/Font.h: (WebCore::Font::operator==): (WebCore::Font::width): (WebCore::Font::height):
  • platform/FontRenderer.h: Added. (WebCore::FontRenderer::isFixedPitch):
  • platform/GraphicsContext.h:
  • platform/mac/FontMac.mm: Added. (WebCore::m_renderer): (WebCore::FontRenderer::getWebCoreFont): (WebCore::FontRenderer::getRenderer): (WebCore::FontRenderer::determinePitch): (WebCore::FontRenderer::update): (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/mac/GraphicsContextMac.mm:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/RenderText.h:
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_box.cpp: (WebCore::RenderBox::caretRect):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight): (WebCore::RenderFlow::caretRect):
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
  • rendering/render_list.cpp: (WebCore::toHebrew): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::baselinePosition): (WebCore::RenderListMarker::getRelativeMarkerRect):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::baselinePosition):
  • rendering/render_object.h:
  • rendering/render_style.h:
4:33 PM Changeset in webkit [13133] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Hang WebView pointer off of HWND (gets rid of global hack).
Remove MessageBox displayed on url change.

  • Spinneret/Spinneret/Spinneret.cpp: (WndProc): (MyEditProc):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebViewWndProc):
4:28 PM Changeset in webkit [13132] by eseidel
  • 2 edits in trunk/WebCore

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add urlSelected stub, adjust font metrics, and fix view size/move bug.

  • platform/win/TemporaryLinkStubs.cpp: (MouseEvent::MouseEvent): (FrameWin::urlSelected): (QFontMetrics::height): (QFontMetrics::xHeight): (QFontMetrics::ascent): (QFontMetrics::descent): (ScrollView::resizeContents): (ScrollView::setContentsPos):
3:07 PM Changeset in webkit [13131] by thatcher
  • 2 edits in trunk/WebKit/WebInspector

Forgot to save these files before I commited my last change.

3:07 PM Changeset in webkit [13130] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Automatically kill httpd if it appears to be already running.

  • Scripts/run-webkit-tests:
3:05 PM Changeset in webkit [13129] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • stop background image loads from crashing
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage):
  • fix termination condition on file load loop
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):
2:57 PM Changeset in webkit [13128] by thatcher
  • 9 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.

12:37 PM Changeset in webkit [13127] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • Fixed <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

No test case yet because this is a preliminary step toward enabling my
uber test case for DOM support, which will cover this.

  • khtml/ecma/kjs_dom.cpp: (KJS::): Make DOMNode's classinfo reflect inheritance from DOMNodeProto, so a for in enumeration can properly walk the inheritance chain.
  • khtml/ecma/kjs_html.cpp: (KJS::): Used a script to sort classInfo data alphbetically. (KJS::KJS::HTMLElement::classInfo): Ditto.
3:02 AM Changeset in webkit [13126] by mjs
  • 3 edits in trunk/WebKitTools

Reviewed by Eric.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Improved local file loading.
2:58 AM Changeset in webkit [13125] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix mistake in TransferJob::start that made it cause a crash

on non-file URLs

  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):
2:26 AM Changeset in webkit [13124] by mjs
  • 10 edits in trunk/WebCore

Reviewed by Eric.

  • WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin to build.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
  • platform/TransferJob.cpp: (WebCore::TransferJob::TransferJob): Pass this to internal constructor, so windows version can initialize timer
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): On windows, prepare a timer for file loads.
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFloatImage): If passed-in context is null, use our built-in context (this is probably not the best, but should work for now).
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::issueRedoCommand): Don't break. (WebCore::TransferJob::assembleResponseHeaders): ditto (FrameWin::saveDocumentState): ditto (FrameWin::clearUndoRedoOperations): ditto
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobInternal::~TransferJobInternal): Close file handle if we have one. (WebCore::TransferJob::~TransferJob): Empty. (WebCore::TransferJob::start): Open a windows file handle. (WebCore::TransferJob::fileLoadTimer): Load from windows file handle. (WebCore::TransferJob::cancel): Stop timer and close windows file handle if present.

Mar 3, 2006:

11:42 PM Changeset in webkit [13123] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix QString crasher on Win32, also remove c-style casts from file.
Add a few more stubs to allow more layout tests to not crash.
Make dlls only copy when changed.
Add RenderThemeWin stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/QString.cpp: (QString::stripWhiteSpace): (QString::simplifyWhiteSpace): (QString::setLatin1): (QString::sprintf): (QString::insert): (QString::fill):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::usableScreenRect): (FrameWin::respondToChangedContents): (FrameWin::unfocusWindow): (FrameWin::locationbarVisible): (FrameWin::clearUndoRedoOperations): (FrameWin::issueRedoCommand): (FrameWin::canRedo): (FrameWin::canUndo): (FrameWin::saveDocumentState): (FrameWin::print): (FrameWin::issueCutCommand): (FrameWin::issueCopyCommand): (FrameWin::issueUndoCommand): (FrameWin::mimeTypeForFileName): (FrameWin::clearRecordedFormValues): (FrameWin::issuePasteCommand): (FrameWin::scheduleClose): (FrameWin::menubarVisible): (FrameWin::personalbarVisible): (FrameWin::statusbarVisible): (FrameWin::toolbarVisible): (FrameWin::issueTransposeCommand): (FrameWin::canPaste): (FrameWin::incomingReferrer): (FrameWin::canGoBackOrForward): (FrameWin::issuePasteAndMatchStyleCommand): (FrameWin::createPlugin): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::openURLNotify): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (QListBox::setFont): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QFontMetrics::xHeight): (QFontMetrics::ascent): (FrameWin::shouldChangeSelection): (FrameWin::generateFrameName): (FrameWin::createFrame): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField):
  • rendering/RenderThemeWin.cpp: Added. (WebCore::theme):
  • rendering/RenderThemeWin.h: Added.
11:29 PM Changeset in webkit [13122] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by NOBODY (OOPS!).

A few more fixes to make run-webkit-tests really work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest):
  • Scripts/run-webkit-tests:
5:35 PM Changeset in webkit [13121] by eseidel
  • 5 edits in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make run-webkit-tests work on win32.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView):
3:33 PM Changeset in webkit [13120] by ggaren
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Darin.

This regression was caused by my fix for 4448098. I failed to account for the
deleted entry sentinel in the mehtod that saves the contents of a property map to
the back/forward cache.

Manual test in WebCore/manual-tests/property-map-save-crash.html

  • kjs/property_map.cpp: (KJS::deletedSentinel): Use 1 instead of -1 to facilitate an easy bit mask (KJS::isValid): New function: checks if a key is null or the deleted sentinel (KJS::PropertyMap::~PropertyMap): Fixed up the branch logic here for readability and a slight performance win (KJS::PropertyMap::clear): (KJS::PropertyMap::rehash): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::save): Check keys with isValid()

WebCore:

Test case for <rdar://problem/4465598> REGRESSION (TOT): Crash occurs at
​http://maps.google.com/?output=html ( KJS::Identifier::add(KJS::UString::Rep*)

  • manual-tests/property-map-save-crash.html: Added.
2:10 PM Changeset in webkit [13119] by lypanov
  • 2 edits in trunk/LayoutTests

2006-03-03 Alexander Kellett <​lypanov@kde.org>

  • local machine unfortunately shows slightly differing results to the build bots, reverting to fix the built bot.
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
11:43 AM Changeset in webkit [13118] by eseidel
  • 3 edits in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Fix clearly bogus cairo elipse drawing code.
Make QFontMetrics stubs slightly more sane.

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawEllipse):
  • platform/win/TemporaryLinkStubs.cpp: (QFontMetrics::floatWidth): (QFontMetrics::height): (QFontMetrics::width): (QFontMetrics::isFixedPitch):
7:59 AM Changeset in webkit [13117] by darin
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/innerHTML/innerHTML-custom-tag.html: Added.
  • fast/innerHTML/innerHTML-custom-tag-expected.txt: Added.
  • fast/innerHTML/005-expected.txt: Updated. Now matches the original document as expected. Old result had the <div> after a <pre> put on the same line.
  • editing/inserting/4278698-expected.txt: Updated because offset of node changed since we have one more text node (from after a /pre).
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Ditto.

WebCore:

Reviewed by Eric.

Test: fast/innerHTML/innerHTML-custom-tag.html

  • editing/markup.cpp: (WebCore::shouldSelfClose): Refined rule so that it doesn't try to do any self-closing tags in HTML documents at all; updated comment.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Added a check of beginTag in the <pre> tag case. We were accidentally discarding a newline after a </pre> tag.
1:54 AM Changeset in webkit [13116] by eseidel
  • 5 edits
    2 adds in trunk/WebKitTools

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add WebFrame class (to hold Frame and FrameView).
Add Location bar support to Spinneret.

  • Spinneret/Spinneret/Spinneret.cpp: (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc):
  • Spinneret/Spinneret/Spinneret.vcproj:
  • Spinneret/Spinneret/WebFrame.cpp: Added. (WebKit::WebFrame::WebFramePrivate::WebFramePrivate): (WebKit::WebFrame::WebFramePrivate::~WebFramePrivate): (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::loadHTMLString): (WebKit::WebFrame::paint): (WebKit::WebFrame::impl): (WebKit::WebFrame::viewImpl):
  • Spinneret/Spinneret/WebFrame.h: Added.
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebViewPrivate::~WebViewPrivate): (WebKit::WebView::WebView): (WebKit::WebView::windowHandle): (WebKit::WebView::mainFrame): (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):
  • Spinneret/Spinneret/WebView.h:
1:44 AM Changeset in webkit [13115] by mjs
  • 3 edits
    1 copy in trunk/WebCore

Rubber stamped by Eric.

  • add new files to build, fix link stubs.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::~TransferJob):
  • platform/win/TransferJobWin.cpp: Added.
1:31 AM Changeset in webkit [13114] by mjs
  • 1 edit
    1 add in trunk/WebCore
  • add file I forgot in my last commit.
  • platform/TransferJobInternal.h: Added. (WebCore::TransferJobInternal::TransferJobInternal):
1:30 AM Changeset in webkit [13113] by eseidel
  • 10 edits
    2 adds in trunk/WebCore

2006-03-03 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Wire up WidgetWin, CursorWin, ScrollViewWin.
Stub out methods for selection and cursors.

  • Viewer/ImageDocument.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::initScriptIfNeeded):
  • platform/IntRect.h: (WebCore::IntRect::IntRect):
  • platform/Widget.h:
  • platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
  • platform/win/IntRectWin.cpp: (WebCore::IntRect::IntRect): (WebCore::IntRect::operator RECT):
  • platform/win/MouseEventWin.cpp:
  • platform/win/ScrollViewWin.cpp: Added. (WebCore::ScrollView::updateContents):
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (QLineEdit::setPlaceholderString): (QScrollBar::scroll): (GraphicsContext::beginTransparencyLayer): (Widget::setIsSelected): (QLineEdit::selectedText): (QComboBox::sizeHint): (KWQFileButton::focusPolicy): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::focusPolicy): (QLineEdit::focusPolicy): (WebCore::moveCursor): (ScrollView::scrollBy): (KWQKCookieJar::cookieEnabled): (WebCore::TransferJob::TransferJob): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::issuePasteCommand): (FrameWin::issueTransposeCommand): (QSlider::setFont): (QLineEdit::setFont): (QListBox::setFont): (QFontMetrics::QFontMetrics): (QComboBox::setFont): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QFontMetrics::setFontDescription): (QFontMetrics::checkSelectionPoint): (FrameWin::addMessageToConsole): (FrameWin::shouldChangeSelection): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsX): (ScrollView::contentsY): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::viewportToContents):
  • platform/win/WidgetWin.cpp: Added. (WebCore::Widget::Widget): (WebCore::Widget::~Widget): (WebCore::Widget::windowHandle): (WebCore::Widget::setWindowHandle): (WebCore::Widget::setActiveWindow): (WebCore::Widget::frameGeometry): (WebCore::Widget::hasFocus): (WebCore::Widget::setFocus): (WebCore::Widget::clearFocus): (WebCore::Widget::font): (WebCore::Widget::setFont): (WebCore::Widget::setCursor): (WebCore::Widget::show): (WebCore::Widget::hide): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::mapFromGlobal):
1:19 AM Changeset in webkit [13112] by mjs
  • 11 edits
    1 copy
    3 moves
    2 deletes in trunk/WebCore

Reviewed by Eric.

  • move TransferJob from kwq to platform, separate platform from non-platform bits
  • ForwardingHeaders/kio/job.h: Removed.
  • ForwardingHeaders/kio/jobclasses.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • dom/xml_tokenizer.cpp:
  • khtml/xsl/xslt_processorimpl.cpp:
  • kwq/KWQKJobClasses.h: Removed.
  • kwq/KWQKJobClasses.mm: Removed.
  • kwq/KWQLoader.mm:
  • kwq/KWQResourceLoader.mm:
  • kwq/TransferJobClient.h: Removed.
  • loader/Cache.cpp:
  • loader/loader.cpp:
  • page/Frame.cpp:
  • platform/TransferJob.cpp: Added. (WebCore::TransferJob::TransferJob): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::addMetaData):
  • platform/TransferJob.h: Added.
  • platform/TransferJobClient.h: Added.
  • platform/mac/TransferJobMac.mm: Added. (WebCore::TransferJobInternal::~TransferJobInternal): (WebCore::TransferJob::retrieveCharset): (WebCore::TransferJob::cancel):
  • xml/xmlhttprequest.cpp:
1:18 AM Changeset in webkit [13111] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • enough link stubs to "display" local copy of WebKit site w/o hitting breakpoint
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::setReadOnly): (QTextEdit::setCursorPosition): (QLineEdit::setCursorPosition): (QFontMetrics::width): (GraphicsContext::drawText): (GraphicsContext::drawLineForText):
Note: See TracTimeline for information about the timeline view.