Timeline

Mar 5, 2006:

11:38 PM Changeset in webkit [13163] by ggaren

• 2 edits in trunk/LayoutTests

• Checked in new results for the test I just landed. Looks like I landed an old copy.

• fast/dom/prototype-chain-expected.txt:

11:23 PM Changeset in webkit [13162] by darin

• 1 edit in trunk/WebCore/ChangeLog

Fix typo.

11:22 PM Changeset in webkit [13161] by darin

• 2 edits in trunk/WebCore

Reviewed by Maciej.

• fix failure seen running editing layout tests

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Use selectNodeContents instead of rolling our own. It handles the "nothing at all" edget case properly.

11:18 PM Changeset in webkit [13160] by eseidel

• 3 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Make updateContents invalidate entire window for now.
Fix indentation in fileLoadTimer.

• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents):
• platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):

10:26 PM Changeset in webkit [13159] by eseidel

• 17 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Add missing files to vcproj (fix win32 build).
Also add svn:eol-style=native to new files.

• WebCore.vcproj/WebCore/WebCore.vcproj:

10:06 PM Changeset in webkit [13158] by darin

• 2 edits in trunk/JavaScriptCore

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Updated.

9:55 PM Changeset in webkit [13157] by darin

• 2 edits in trunk/WebCore

• fix build

• rendering/render_style.h: (compareEqual): Made it inline, fixed variable name.

9:52 PM Changeset in webkit [13156] by adele

• 12 edits
  6 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6987
Implement maxlength for new text fields

• fast/forms/input-appearance-maxlength-expected.txt: Added.
• fast/forms/input-appearance-maxlength.html: Added.

WebCore:

Reviewed by Darin.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6987 Implement maxlength for new text fields

Test added:

• fast/forms/input-appearance-maxlength.html

• WebCore.xcodeproj/project.pbxproj: Added BeforeTextInsertedEventImpl.h, BeforeTextInsertedEventImpl.cpp, HTMLTextFieldInnerElementImpl.h, and HTMLTextFieldInnerElementImpl.cpp

• khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::init): initialize max length to 1024. (WebCore::HTMLInputElementImpl::defaultEventHandler): Added case to use the khtmlBeforeTextInsertedEvent to check for maxlength. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Makes sure that maxlength is between 0 and 1024.

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): After doing a test insert of the fragment, Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text, and we can update the fragment.
• editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): Send khtmlBeforeTextInsertedEvent to the root editable element so the event handler can update the text if necessary.
• editing/EditCommand.cpp: (WebCore::EditCommand::apply): If we've just applied a command, send the khtmlTextInsertedEvent to the root editable element. (WebCore::EditCommand::unapply): ditto. (WebCore::EditCommand::reapply): ditto.

• khtml/html/HTMLTextFieldInnerElementImpl.h: Added this class to store a pointer to the input element for the text field and to handle default events. (DOM::HTMLTextFieldInnerElementImpl::shadowParentNode): Added. (DOM::HTMLTextFieldInnerElementImpl::setShadowParentNode): Added.
• khtml/html/HTMLTextFieldInnerElementImpl.cpp: Added. (WebCore::HTMLTextFieldInnerElementImpl::HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::~HTMLTextFieldInnerElementImpl): (WebCore::HTMLTextFieldInnerElementImpl::defaultEventHandler): Sends khtmlBeforeTextInsertedEvents to the shadowParentNode, and handles khtmlTextInsertedEvents by telling the renderer that the subtree has changed.

• rendering/RenderTextField.cpp: Removed InputMutationListener since subtreeHasChanged is now called from the editing code. (WebCore::RenderTextField::~RenderTextField): removed event listener code. (WebCore::RenderTextField::updateFromElement): ditto. And creates HTMLTextFieldInnerElementImpl. (WebCore::RenderTextField::subtreeHasChanged): calls new text() method. (WebCore::RenderTextField::text): created to get a String of all text in the RenderTextField.
• rendering/RenderTextField.h: Removed InputMutationListener class.

• dom/EventNames.h: Added khtmlTextInserted and khtmlBeforeTextInserted.
• dom/BeforeTextInsertedEventImpl.cpp: Added. (WebCore::BeforeTextInsertedEventImpl::BeforeTextInsertedEventImpl):
• dom/BeforeTextInsertedEventImpl.h: Added. (WebCore::BeforeTextInsertedEventImpl::isBeforeTextInsertedEvent): (WebCore::BeforeTextInsertedEventImpl::text):
• dom/dom2_eventsimpl.cpp: (WebCore::EventImpl::isBeforeTextInsertedEvent): Added.
• dom/dom2_eventsimpl.h: Added isBeforeTextInsertedEvent.

9:47 PM Changeset in webkit [13155] by mjs

• 2 edits in trunk/WebCore

• fix build, give this a return type.

• rendering/render_style.h: (compareEqual):

9:32 PM Changeset in webkit [13154] by ap

• 2 edits in trunk/JavaScriptCore

Fix by Mitz Pettel and Alexey Proskuryakov, reviewed by Maciej and Hyatt.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7601 REGRESSION (r13089): Reproducible crash dereferencing a deallocated element on google image search

• kxmlcore/Platform.h: Corrected the define to enable USE(MULTIPLE_THREADS) on Mac OS X.

9:29 PM Changeset in webkit [13153] by darin

• 6 edits
  2 copies in trunk/JavaScriptCore

Reviewed by Maciej.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7616 get all references to KJS::Node out of internal.h

• JavaScriptCore.xcodeproj/project.pbxproj: Updated for file changes.

• kjs/Parser.cpp: Added.
• kjs/Parser.h: Added.

• kjs/internal.cpp: Removed the Parser class.
• kjs/internal.h: Ditto. Also removed unnecessary declarations of classes not used in this header.

• kjs/nodes.h: Added an include of "Parser.h".
• kjs/function.h: Added a declaration of FunctionBodyNode.

8:56 PM Changeset in webkit [13152] by eseidel

• 2 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Add "Font.h" to (try to) fix the no-svg build.

• platform/mac/GraphicsContextMac.mm:

8:55 PM Changeset in webkit [13151] by mjs

• 2 edits in trunk/WebCore

Rubber stamped by Darin.

• fix win32 build by avoiding use of typeof

• rendering/render_style.h: (compareEqual):

7:58 PM Changeset in webkit [13150] by ggaren

• 21 edits
  2 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

• JSC support for the fix for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

• kjs/lookup.h: (1) Added the KJS_DEFINE_PROTOTYPE_WITH_PROTOTYPE macro. The class definiton macro needs to know about the prototype's prototype so that the class constructor properly sets it. (2) Removed the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro. The class implementation macro does not need to know about the prototype's prototype, since getOwnPropertySlot should only look in the current object's property map, and not its prototype's.

LayoutTests:

Reviewed by Maciej.

• Layout test for <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

• fast/dom/prototype-chain-expected.txt: Added.
• fast/dom/prototype-chain.html: Added.

WebCore:

Reviewed by Maciej.

• Second cut at fixing <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

The approach here is for prototypes, in their constructor methods,
to set their own prototypes, preserving the prototype
chain in cases of multiple levels of inheritance. (Previously, our
code assumed that a prototype never had a prototype of its own,
and always used an empty object as a prototype's prototype).

• bindings/scripts/CodeGeneratorJS.pm: Use the new DEFINE_PROTOTYPE_WITH_PROTOTYPE macro in place of the KJS_IMPLEMENT_PROTOTYPE_WITH_PARENT macro.
• khtml/ecma/kjs_dom.cpp: Ditto.
• khtml/ecma/kjs_dom.h: Ditto.
• khtml/ecma/kjs_events.cpp: Ditto.

Touched these files to force a rebuild:

• bindings/js/JSDOMCore.cpp:
• bindings/js/JSDOMEvents.cpp:
• dom/Attr.idl:
• dom/CharacterData.idl:
• dom/DOMImplementation.idl:
• dom/DocumentType.idl:
• dom/Element.idl:
• dom/Entity.idl:
• dom/MutationEvent.idl:
• dom/Notation.idl:
• dom/ProcessingInstruction.idl:
• dom/Text.idl:
• dom/WheelEvent.idl:

6:53 PM Changeset in webkit [13149] by mjs

• 40 edits in trunk/WebCore

Reviewed by Darin.

• use unsigned bitfields when storing enums in them, to avoid mangling on win32 (was causing all layout to be RTL) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7618

• css/css_base.cpp: (WebCore::CSSSelector::operator == ): (WebCore::CSSSelector::selectorText):
• css/css_base.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::pseudoType): (WebCore::CSSSelector::relation):
• css/css_grammar.y:
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector):
• kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
• kcanvas/KCanvasPath.h: (WebCore::KCClipData::windRule): (WebCore::KCClipDataList::addPath):
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasClipperQuartz::applyClip):
• khtml/ecma/kjs_html.h:
• khtml/html/HTMLButtonElementImpl.h:
• khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setInputType):
• khtml/html/HTMLInputElementImpl.h: (DOM::HTMLInputElementImpl::inputType):
• khtml/html/html_tableimpl.h:
• khtml/xbl/xbl_protohandler.cpp: (XBL::m_button):
• khtml/xbl/xbl_protohandler.h:
• ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::): (WebCore::SVGRenderStyle::setBitDefaults):
• ksvg2/svg/SVGAnimateTransformElementImpl.h:
• ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::targetAttribute): (SVGAnimationElementImpl::setTargetAttribute):
• ksvg2/svg/SVGAnimationElementImpl.h:
• ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
• ksvg2/svg/SVGLengthImpl.h:
• kwq/KWQKHTMLSettings.h:
• loader/CachedImage.h:
• loader/DocLoader.cpp: (WebCore::DocLoader::setCachePolicy): (WebCore::DocLoader::setShowAnimations):
• loader/DocLoader.h: (WebCore::DocLoader::showAnimations):
• platform/FontDescription.h: (WebCore::FontDescription::genericFamily):
• platform/QString.cpp: (HandleNode::):
• platform/QString.h:
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::setSelectionState): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::leftBottom): (WebCore::RenderBlock::rightBottom): (WebCore::RenderBlock::addOverhangingFloats): (WebCore::RenderBlock::addIntrudingFloats):
• rendering/RenderBlock.h: (WebCore::RenderBlock::selectionState): (WebCore::RenderBlock::FloatingObject::FloatingObject): (WebCore::RenderBlock::FloatingObject::type):
• rendering/RenderTable.h: (WebCore::RenderTable::getRules):
• rendering/bidi.cpp: (khtml::BidiContext::BidiContext): (khtml::operator==): (khtml::embed): (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::bidiReorderLine): (khtml::RenderBlock::layoutInlineChildren):
• rendering/bidi.h: (khtml::BidiContext::dir): (khtml::BidiContext::basicDir): (khtml::BidiRun::BidiRun):
• rendering/render_canvasimage.h:
• rendering/render_layer.h: (WebCore::Marquee::whiteSpace):
• rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
• rendering/render_replaced.cpp: (WebCore::RenderWidget::setSelectionState):
• rendering/render_replaced.h: (WebCore::RenderReplaced::selectionState):
• rendering/render_style.cpp: (WebCore::RenderStyle::getPseudoStyle):
• rendering/render_style.h: (khtml::BorderValue::BorderValue): (khtml::BorderValue::style): (khtml::BorderValue::nonZero): (khtml::BorderValue::operator==): (khtml::OutlineValue::operator==): (khtml::CollapsedBorderValue::style): (khtml::BorderImage::horizontalRule): (khtml::BorderImage::verticalRule): (khtml::BorderData::borderLeftWidth): (khtml::BorderData::borderRightWidth): (khtml::BorderData::borderTopWidth): (khtml::BorderData::borderBottomWidth): (khtml::BackgroundLayer::backgroundClip): (khtml::BackgroundLayer::backgroundOrigin): (khtml::BackgroundLayer::backgroundRepeat): (khtml::RenderStyle::styleType): (khtml::RenderStyle::display): (khtml::RenderStyle::originalDisplay): (khtml::RenderStyle::position): (khtml::RenderStyle::floating): (khtml::RenderStyle::borderLeftStyle): (khtml::RenderStyle::borderLeftColor): (khtml::RenderStyle::borderRightStyle): (khtml::RenderStyle::borderRightColor): (khtml::RenderStyle::borderTopStyle): (khtml::RenderStyle::borderTopColor): (khtml::RenderStyle::borderBottomStyle): (khtml::RenderStyle::borderBottomColor): (khtml::RenderStyle::outlineWidth): (khtml::RenderStyle::outlineStyle): (khtml::RenderStyle::overflow): (khtml::RenderStyle::visibility): (khtml::RenderStyle::verticalAlign): (khtml::RenderStyle::unicodeBidi): (khtml::RenderStyle::clear): (khtml::RenderStyle::tableLayout): (khtml::RenderStyle::textAlign): (khtml::RenderStyle::textTransform): (khtml::RenderStyle::direction): (khtml::RenderStyle::whiteSpace): (khtml::RenderStyle::backgroundRepeat): (khtml::RenderStyle::backgroundClip): (khtml::RenderStyle::backgroundOrigin): (khtml::RenderStyle::emptyCells): (khtml::RenderStyle::captionSide): (khtml::RenderStyle::listStyleType): (khtml::RenderStyle::listStylePosition): (khtml::RenderStyle::cursor): (khtml::RenderStyle::pageBreakInside): (khtml::RenderStyle::pageBreakBefore): (khtml::RenderStyle::pageBreakAfter): (khtml::RenderStyle::outlineOffset): (khtml::RenderStyle::appearance): (khtml::RenderStyle::boxAlign): (khtml::RenderStyle::boxDirection): (khtml::RenderStyle::boxLines): (khtml::RenderStyle::boxOrient): (khtml::RenderStyle::boxPack): (khtml::RenderStyle::boxSizing): (khtml::RenderStyle::marqueeBehavior): (khtml::RenderStyle::marqueeDirection): (khtml::RenderStyle::userModify): (khtml::RenderStyle::userDrag): (khtml::RenderStyle::userSelect): (khtml::RenderStyle::marginTopCollapse): (khtml::RenderStyle::marginBottomCollapse): (khtml::RenderStyle::wordWrap): (khtml::RenderStyle::nbspMode): (khtml::RenderStyle::khtmlLineBreak): (khtml::RenderStyle::matchNearestMailBlockquoteColor): (khtml::RenderStyle::setBorderLeftWidth): (khtml::RenderStyle::setBorderLeftStyle): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightWidth): (khtml::RenderStyle::setBorderRightStyle): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopWidth): (khtml::RenderStyle::setBorderTopStyle): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomWidth): (khtml::RenderStyle::setBorderBottomStyle): (khtml::RenderStyle::setBorderBottomColor): (khtml::RenderStyle::setOutlineWidth): (khtml::RenderStyle::setOutlineStyle): (khtml::RenderStyle::pseudoState):

12:36 PM Changeset in webkit [13148] by darin

• 2 edits in trunk/WebKitTools

• Scripts/do-webcore-rename: Fix a couple of things found while testing. Script now works (after landing my two pending patches).

12:25 PM Changeset in webkit [13147] by ggaren

• 2 edits in trunk/WebCore

• Rolled out the fix for <rdar://problem/4467143> because it's the wrong approach. Maciej and I discussed this on IRC.

• khtml/ecma/kjs_dom.cpp: (KJS::): Don't use classInfo to express prototype inheritance. classInfo is only for representing a c++ superclass relationship.

11:59 AM Changeset in webkit [13146] by darin

• 1 edit
  1 add in trunk/WebKitTools

• check in a script to do a "big" rename in WebCore (can be run whenever we're ready to do it)

• Scripts/do-webcore-rename: Added.

9:11 AM Changeset in webkit [13145] by eseidel

• 2 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Move improperly placed #endif causing no-svg build to fail.

• kcanvas/device/quartz/KRenderingDeviceQuartz.h:

6:36 AM Changeset in webkit [13144] by lypanov

• 1 edit
  6 adds in trunk/LayoutTests

2006-03-05 Alexander Kellett <​lypanov@kde.org>

Reviewed by Eric.

• missing results from previous commit

• svg/custom/polyline-invalid-points-expected.checksum: Added.
• svg/custom/polyline-invalid-points-expected.png: Added.
• svg/custom/polyline-invalid-points-expected.txt: Added.
• svg/custom/polyline-setattribute-points-null-expected.checksum: Added.
• svg/custom/polyline-setattribute-points-null-expected.png: Added.
• svg/custom/polyline-setattribute-points-null-expected.txt: Added.

6:33 AM Changeset in webkit [13143] by lypanov

• 3 edits
  2 adds in trunk

2006-03-05 Alexander Kellett <​lypanov@kde.org>

Reviewed by Eric.

• new reduced testcases for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6951 ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6890

• svg/custom/polyline-invalid-points.svg: Added.
• svg/custom/polyline-setattribute-points-null.svg: Added.

2006-03-05 Alexander Kellett <​lypanov@kde.org>

Reviewed by Eric.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6890 and ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6951 by being more tolerant towards invalid points data

• new tests: svg/custom/polyline-setattribute-points-null.svg svg/custom/polyline-invalid-points.svg

• ksvg2/svg/svgpathparser.cpp: (SVGPolyParser::parsePoints):

3:27 AM Changeset in webkit [13142] by mjs

• 3 edits
  3 deletes in trunk/WebCore

Rubber stamped by Eric.

• remove no longer used KDOMSettings and KSVGSettings

• WebCore+SVG/KDOMSettings.cpp: Removed.
• WebCore+SVG/KDOMSettings.h: Removed.
• WebCore.xcodeproj/project.pbxproj:
• ksvg2/KSVGSettings.h: Removed.
• ksvg2/svg/SVGStyledElementImpl.cpp:

3:12 AM Changeset in webkit [13141] by mjs

• 2 edits in trunk/WebKitTools

Reviewed by Eric.

• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Close file when done.

2:30 AM Changeset in webkit [13140] by eseidel

• 2 edits in trunk/WebCore

2006-03-05 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

• platform/Font.cpp: (WebCore::Font::update): remove extra ref causing large leak.

2:10 AM Changeset in webkit [13139] by ap

• 5 edits
  4 adds in trunk

Fix by Mitz Pettel, reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7589 Mouse moved events do not work in DumpRenderTree

WebKitTools:

• DumpRenderTree/DumpRenderTree.m: (-[EventSendingController mouseMoveToX:Y:]): Pass the correct windowNumber in the event.

LayoutTests:

• fast/css/hover-subselector-expected.txt: Updated results.
• fast/css/hover-subselector.html: Changed to work with the new mechanism.
• fast/events/event-sender-mouse-moved-expected.checksum: Added.
• fast/events/event-sender-mouse-moved-expected.png: Added.
• fast/events/event-sender-mouse-moved-expected.txt: Added.
• fast/events/event-sender-mouse-moved.html: Added.

1:43 AM Changeset in webkit [13138] by ap

• 3 edits in trunk/JavaScriptCore

Patch by Andrew Wellington, reviewed by Eric.

• Remove unused breakpoint bool from StatementNodes. No test provided as there is no functionality change.

• kjs/nodes.cpp: (StatementNode::StatementNode):
• kjs/nodes.h:

1:42 AM Changeset in webkit [13137] by eseidel

• 5 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Take advantage of new GraphicsContext constructor to implement double buffering to avoid tearing.
Disable background erase to avoid tearing.
Fix potential memory smasher from extra long urls.

• Spinneret/Spinneret/Spinneret.cpp: (MyRegisterClass):
• Spinneret/Spinneret/Spinneret.vcproj:
• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): (WebKit::WebFrame::paint):
• Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance):

1:41 AM Changeset in webkit [13136] by eseidel

• 9 edits in trunk/WebCore

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Re-work ImageViewer to use GraphicsContext.
Add GraphicsContext(cairo_t*) constructor to make double-buffering easier.
Add one more stub to prevent slashdot from crashing.
Also fixed win32 build after Font change.

• Viewer.vcproj:
• Viewer/ImageView.cpp:
• platform/Color.h:
• platform/GraphicsContext.h:
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::GraphicsContext):
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

1:35 AM Changeset in webkit [13135] by ap

• 6 edits
  1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4840 Frames only resize wider, can't make them narrower

• khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameSetElementImpl::HTMLFrameSetElementImpl): Removed unused m_resizing flag.
• khtml/html/html_baseimpl.h:
• manual-tests/bugzilla-4840.html: Added.
• page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::viewportMouseReleaseEvent): (WebCore::FrameView::setResizingFrameSet): New method. When a resizing frameset is set, mouse move and mouse release events target it instead of hit-testing.
• page/FrameView.h:
• rendering/render_frames.cpp: (WebCore::RenderFrameSet::setResizing): Inform the FrameView that we are resizing (or not).

Mar 4, 2006:

9:51 PM Changeset in webkit [13134] by hyatt

• 23 edits
  2 adds
  2 deletes in trunk/WebCore

Fix for bug 7586, eliminate QFontMetrics.

Reviewed by eric

• WebCore.xcodeproj/project.pbxproj:
• css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
• ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
• kwq/KWQFontMetrics.h: Removed.
• kwq/KWQFontMetrics.mm: Removed.
• platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::~Font): (WebCore::Font::update): (WebCore::Font::width):
• platform/Font.h: (WebCore::Font::operator==): (WebCore::Font::width): (WebCore::Font::height):
• platform/FontRenderer.h: Added. (WebCore::FontRenderer::isFixedPitch):
• platform/GraphicsContext.h:
• platform/mac/FontMac.mm: Added. (WebCore::m_renderer): (WebCore::FontRenderer::getWebCoreFont): (WebCore::FontRenderer::getRenderer): (WebCore::FontRenderer::determinePitch): (WebCore::FontRenderer::update): (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
• platform/mac/GraphicsContextMac.mm:
• rendering/InlineTextBox.h:
• rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
• rendering/RenderText.cpp: (WebCore::RenderText::trimmedMinMaxWidth):
• rendering/RenderText.h:
• rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
• rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
• rendering/render_box.cpp: (WebCore::RenderBox::caretRect):
• rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
• rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight): (WebCore::RenderFlow::caretRect):
• rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint):
• rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically):
• rendering/render_list.cpp: (WebCore::toHebrew): (WebCore::RenderListMarker::paint): (WebCore::RenderListMarker::calcMinMaxWidth): (WebCore::RenderListMarker::baselinePosition): (WebCore::RenderListMarker::getRelativeMarkerRect):
• rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::baselinePosition):
• rendering/render_object.h:
• rendering/render_style.h:

4:33 PM Changeset in webkit [13133] by eseidel

• 3 edits in trunk/WebKitTools

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Hang WebView pointer off of HWND (gets rid of global hack).
Remove MessageBox displayed on url change.

• Spinneret/Spinneret/Spinneret.cpp: (WndProc): (MyEditProc):
• Spinneret/Spinneret/WebView.cpp: (WebKit::registerWebViewWithInstance): (WebKit::WebView::createWebView): (WebKit::WebViewWndProc):

4:28 PM Changeset in webkit [13132] by eseidel

• 2 edits in trunk/WebCore

2006-03-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Add urlSelected stub, adjust font metrics, and fix view size/move bug.

• platform/win/TemporaryLinkStubs.cpp: (MouseEvent::MouseEvent): (FrameWin::urlSelected): (QFontMetrics::height): (QFontMetrics::xHeight): (QFontMetrics::ascent): (QFontMetrics::descent): (ScrollView::resizeContents): (ScrollView::setContentsPos):

3:07 PM Changeset in webkit [13131] by thatcher

• 2 edits in trunk/WebKit/WebInspector

Forgot to save these files before I commited my last change.

3:07 PM Changeset in webkit [13130] by ap

• 2 edits in trunk/WebKitTools

Reviewed by Eric.

Automatically kill httpd if it appears to be already running.

• Scripts/run-webkit-tests:

3:05 PM Changeset in webkit [13129] by mjs

• 3 edits in trunk/WebCore

Reviewed by Eric.

• stop background image loads from crashing

• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage):

• fix termination condition on file load loop

• platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer):

2:57 PM Changeset in webkit [13128] by thatcher

• 9 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4411822> wrong element shown in Inspector inspecting main image at apple.com
<rdar://problem/4411908> in the Web Inspector, state of disclosure triangles should be preserved after search
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6616
Bug 6616: Double-clicking on a search result seems broken
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6709
Bug 6709: TypeError: Value undefined (result of expression treeScrollbar.refresh) is not object.

Code clean up and move more code into JavaScript.
Removes a few unused ObjC methods.
Many search fixes. Reveals the focused node when exiting the search.
Shows a "No Selection" screen when there are no search results.
Shows a node count for the number of results.
Fixes a couple of TypeErrors that show on the console.
Uses the system selection color in the Style pane tables.

• English.lproj/Localizable.strings: removed localized strings
• WebInspector.subproj/WebInspector.m: (-init): (-dealloc): (-window): (-setSearchQuery:): (-resizeTopArea): (-searchPerformed:): called from JavaScript when a search happens (-_toggleIgnoreWhitespace:): (-_exitSearch:): exit search results on double click (-_focusRootNode:): (-_revealAndSelectNodeInTree:): (-_refreshSearch): (-_update): (-_updateTraversalButtons): (-_updateRoot): (-_updateTreeScrollbar): (-_updateSystemColors): update CSS with system colors (-webView:didFinishLoadForFrame:): (-webView:plugInViewWithArguments:): (-outlineViewSelectionDidChange:): test for webViewLoaded (-[WebInspectorPrivate init]): alloc rightArrowImage and downArrowImage (-[WebInspectorPrivate dealloc]): no more matchedRules (-[DOMNode _displayName]): removed localization UI_STRING calls.
• WebInspector.subproj/WebInspectorInternal.h:
• WebInspector.subproj/webInspector/inspector.css:
• WebInspector.subproj/webInspector/inspector.html:
• WebInspector.subproj/webInspector/inspector.js:

12:37 PM Changeset in webkit [13127] by ggaren

• 3 edits in trunk/WebCore

Reviewed by Darin.

• Fixed <rdar://problem/4467143> JavaScript enumeration of HTML element properties skips DOM node properties

No test case yet because this is a preliminary step toward enabling my
uber test case for DOM support, which will cover this.

• khtml/ecma/kjs_dom.cpp: (KJS::): Make DOMNode's classinfo reflect inheritance from DOMNodeProto, so a for in enumeration can properly walk the inheritance chain.
• khtml/ecma/kjs_html.cpp: (KJS::): Used a script to sort classInfo data alphbetically. (KJS::KJS::HTMLElement::classInfo): Ditto.

3:02 AM Changeset in webkit [13126] by mjs

• 3 edits in trunk/WebKitTools

Reviewed by Eric.

• Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::loadFilePath): Improved local file loading.

2:58 AM Changeset in webkit [13125] by mjs

• 2 edits in trunk/WebCore

Reviewed by Eric.

• fix mistake in TransferJob::start that made it cause a crash

on non-file URLs

• platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

2:26 AM Changeset in webkit [13124] by mjs

• 10 edits in trunk/WebCore

Reviewed by Eric.

• make TransferJobWin handle file: URLs, and fix other bugs as needed to make local file image loads work ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7587

• WebCore.vcproj/WebCore/WebCore.vcproj: add TransferJobWin to build.
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Set autoLoadImages to true.
• platform/TransferJob.cpp: (WebCore::TransferJob::TransferJob): Pass this to internal constructor, so windows version can initialize timer
• platform/TransferJob.h:
• platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal): On windows, prepare a timer for file loads.
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawFloatImage): If passed-in context is null, use our built-in context (this is probably not the best, but should work for now).
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::issueRedoCommand): Don't break. (WebCore::TransferJob::assembleResponseHeaders): ditto (FrameWin::saveDocumentState): ditto (FrameWin::clearUndoRedoOperations): ditto
• platform/win/TransferJobWin.cpp: (WebCore::TransferJobInternal::~TransferJobInternal): Close file handle if we have one. (WebCore::TransferJob::~TransferJob): Empty. (WebCore::TransferJob::start): Open a windows file handle. (WebCore::TransferJob::fileLoadTimer): Load from windows file handle. (WebCore::TransferJob::cancel): Stop timer and close windows file handle if present.