Context Navigation

WebCore.vcproj/WebCore/WebCore.vcproj:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::drawText):
platform/win/FontWin.cpp: Added. (WebCore::Font::drawText):
platform/win/TemporaryLinkStubs.cpp: (QComboBox::focusPolicy): (ScrollView::scrollXOffset): (Font::isFixedPitch): (Path::boundingRect):

12:48 PM Changeset in webkit [13193] by adele

3 edits in trunk/LayoutTests

Updating tests for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=7319
Can't see caret at the end of a contenteditable div with overflow:hidden

fast/clip/outline-overflowClip-expected.txt:
fast/overflow/overflow-focus-ring-expected.txt:

11:54 AM Changeset in webkit [13192] by adele

2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7319 Can't see caret at the end of a contenteditable div with overflow:hidden

No tests added since I don't think the blinking caret will show up in our tests.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::rightmostPosition): When calculating the rightmostPosition for editable blocks, we need to account for the caret that can be drawn 1 px past the last child inline box.

9:36 AM Changeset in webkit [13191] by darin

7 edits
14 adds
5 deletes in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

fast/js/exception-linenums-in-html-1-expected.txt: Added.
fast/js/exception-linenums-in-html-1.html: Added.

Tests line numbers from HTML source files instead of JavaScript source files
which is tested by fast/js/exception-linenums.html. This test does not test
changes made for Bug 3905, but was added for better coverage.

fast/js/exception-linenums-in-html-2-expected.txt: Added.
fast/js/exception-linenums-in-html-2.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <title> tag, which causes the code path for Bug 3905 to be tested.

fast/js/missing-title-end-tag-js-expected.txt: Added.
fast/js/missing-title-end-tag-js.html: Added.

While developing a fix for Bug 3905, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

fast/tokenizer/missing-title-end-tag-1-expected.checksum: Added.
fast/tokenizer/missing-title-end-tag-1-expected.png: Added.
fast/tokenizer/missing-title-end-tag-1-expected.txt: Added.
fast/tokenizer/missing-title-end-tag-1.html: Added.
fast/tokenizer/missing-title-end-tag-2-expected.checksum: Added.
fast/tokenizer/missing-title-end-tag-2-expected.png: Added.
fast/tokenizer/missing-title-end-tag-2-expected.txt: Added.
fast/tokenizer/missing-title-end-tag-2.html: Added.

The first test case contains an unclosed <title> tag in <head>, while the
second test case contains an unclosed <title> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3905 Missing </title> makes page blank

Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/missing-title-end-tag-js.html
Test: fast/tokenizer/missing-title-end-tag-1.html
Test: fast/tokenizer/missing-title-end-tag-2.html

khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </title> tag and handle this condition if identified.
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </title> tag, reset the state of the tokenizer and retokenize with no special handling for <title>. The parser will handle the missing </title> tag in HTMLParser::handleError().
platform/SegmentedString.cpp: (WebCore::SegmentedString::SegmentedString): Added copy constructor. (WebCore::SegmentedString::operator=): Added assignment operator. Previously the compiler was generating a default method for the assignment operator, but it did not handle m_currentChar properly.
platform/SegmentedString.h: Added prototypes for copy constructor and assignment operator.

9:33 AM Changeset in webkit [13190] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming ideas.

1:28 AM Changeset in webkit [13189] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Fix win32 link stubs.

platform/win/TemporaryLinkStubs.cpp: (WebCore::searchableIndexIntroduction): (WebCore::setCookies): (WebCore::cookies): (WebCore::cookiesEnabled): (WebCore::findNextSentenceFromIndex): (WebCore::findSentenceBoundary): (WebCore::findNextWordFromIndex): (WebCore::findWordBoundary): (WebCore::submitButtonDefaultLabel): (WebCore::inputElementAltText): (WebCore::resetButtonDefaultLabel): (WebCore::defaultLanguage):

1:21 AM Changeset in webkit [13188] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Still more tweaks to renaming.

1:03 AM Changeset in webkit [13187] by darin

43 edits
2 copies
7 moves
6 deletes in trunk/WebCore

Reviewed by Adele, except for the first change listed.

fix recently-introduced bug that GuardMalloc found while I was debugging my other change

rendering/render_frames.cpp: (WebCore::RenderPart::~RenderPart): Set m_widget to 0 before calling deref so we don't end up trying to do unwanted work.

removed 10 more files from KWQ

ForwardingHeaders/klocale.h: Removed.

khtml/misc/helper.cpp: Removed.
khtml/misc/helper.h: Removed.

kwq/KWQCollection.h: Removed.
kwq/KWQKCookieJar.h: Removed.
kwq/KWQKCookieJar.mm: Removed.
kwq/KWQKLocale.h: Removed.
kwq/KWQKLocale.mm: Removed.
kwq/KWQKURL.h: Removed.
kwq/KWQKURL.mm: Removed.
kwq/KWQTextUtilities.h: Removed.
kwq/KWQTextUtilities.mm: Removed.
kwq/KWQView.h: Removed.

platform/CookieJar.h: Added.
platform/Language.h: Added.
platform/LocalizedStrings.h: Added.
platform/TextBoundaries.h: Added.
platform/mac/CookieJar.mm: Added.
platform/mac/Language.mm: Added.
platform/mac/LocalizedStringsMac.mm: Added.
platform/mac/TextBoundaries.mm: Added.
platform/mac/WebCoreWidgetHolder.h: Added.

WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removed and added files.

bridge/mac/WebCoreFrameBridge.mm: Updated includes. (-[WebCoreFrameBridge elementForView:]): Changed KWQWidgetHolder to WebCoreWidgetHolder.

editing/visible_units.cpp: (WebCore::previousWordPositionBoundary): (WebCore::nextWordPositionBoundary): (WebCore::previousSentencePositionBoundary): (WebCore::nextSentencePositionBoundary): Call TextBoundaries.h functions instead of helper.h ones.

khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
ksvg2/svg/SVGTestsImpl.cpp: (WebCore::SVGTestsImpl::isValid): Changed to call defaultLanguage; cleaned up formatting.

khtml/html/HTMLFormElementImpl.cpp: Removed stray comment.

khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::cookie): (WebCore::HTMLDocumentImpl::setCookie): Call CookieJar.h functions.

css/css_valueimpl.cpp:
css/cssparser.cpp:
css/cssstyleselector.cpp:
dom/DocumentImpl.cpp:
dom/dom_position.cpp:
khtml/ecma/kjs_window.cpp:
khtml/html/HTMLInputElementImpl.cpp:
khtml/html/html_headimpl.cpp:
khtml/html/htmlparser.cpp:
khtml/misc/decoder.cpp:
ksvg2/svg/SVGDocumentImpl.cpp:
kwq/KWQComboBox.mm:
kwq/KWQKSSLKeyGen.mm:
kwq/KWQListBox.mm:
kwq/KWQListImpl.cpp:
kwq/KWQListImpl.h:
kwq/KWQScrollBar.mm:
kwq/KWQSlider.mm:
kwq/KWQTextField.mm:
kwq/KWQValueList.h:
loader/DocLoader.cpp:
page/Frame.cpp:
page/FrameView.cpp:
platform/mac/WidgetMac.mm: (WebCore::Widget::beforeMouseDown): (WebCore::Widget::afterMouseDown):
rendering/render_applet.cpp:
rendering/render_form.cpp:
rendering/render_image.cpp:
rendering/render_list.cpp: Updated includes and protocol names.

khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::write): Remove QT_VERSION code.
platform/QString.h: Remove QT_VERSION.

kwq/KWQPtrList.h: Change to no longer use QPtrCollection.

kwq/KWQRenderTreeDebug.h:
kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Remove unused debuggingRenderTree boolean.

12:21 AM Changeset in webkit [13186] by eseidel

2 edits in trunk/WebCore

2006-03-07 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

platform/mac/GraphicsContextMac.mm: Add Widget.h to fix no-svg build.

Mar 6, 2006:

11:35 PM Changeset in webkit [13185] by darin

1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

More renaming tweaks.

10:54 PM Changeset in webkit [13184] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Add some more planned renaming.

6:05 PM Changeset in webkit [13183] by tomernic

2 edits in trunk/WebKit

Reviewed by Kevin Decker.

<rdar://problem/4457574> assertion failure watching trailers at netflix.com -[WebNetscapePluginRepresentation
receivedData:withDataSource:] + 684

Plugins/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): Moved the ASSERT(instance) to the block that actually requires an assertion -- the plugin view should never have a NULL instance by the time we start the NPStream (by calling -startStreamWithResponse:). Some stream teardown logic changed with my fix to 4153419: when a WebBaseNetscapePluginStream is destroyed, it now clears its NPP instance backpointer. The WebBaseNetscapePluginStream may be destroyed from within -startStreamWithResponse: if NPP_NewStream() returns an error. We can handle this gracefully by changing the assertion before -receivedData: to a simple NULL check. This is unrelated to the Radar, but prior to this fix, we would attempt an NPP_Write() with the initial stream data even if NPP_NewStream() returned an error. Seems like that alone could cause issues, though I'm guessing that plugins handle this in practice.

4:38 PM Changeset in webkit [13182] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Make spinneret run again, fix webview to support dynamic resize.

platform/win/TemporaryLinkStubs.cpp: (Widget::setDrawingAlpha):
platform/win/WidgetWin.cpp: (WebCore::Widget::Widget): (WebCore::Widget::setClient): (WebCore::Widget::client): (WebCore::Widget::frameGeometry):

3:41 PM Changeset in webkit [13181] by bdakin

1 edit
4 adds in trunk/LayoutTests

Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7566

3:36 PM Changeset in webkit [13180] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix win32 build.

platform/win/TemporaryLinkStubs.cpp: (QScrollBar::QScrollBar): (QTextEdit::setAlignment): (Widget::client): (Widget::setClient): (QLineEdit::setAlignment):

3:32 PM Changeset in webkit [13179] by bdakin

2 edits in trunk/WebCore

Reviewed by Darin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7566 (also
<rdar://problem/4467128> ). Must call update() on a Font before
attempting to use it because the FontRenderer is not created until
update() is called.

3:17 PM Changeset in webkit [13178] by eseidel

2 edits in trunk/WebKitTools

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint): force layout before painting

3:10 PM Changeset in webkit [13177] by darin

3 edits in trunk/WebKitSite

Reviewed by Darin.

Change "Mail.app" to "Mail".

index.html:
projects/editing/index.html:

3:09 PM Changeset in webkit [13176] by darin

58 edits
1 add
11 deletes in trunk/WebCore

Reviewed by Adele.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7564 remove QObject, QGuardedPtr, slots, and signals

I had written a detailed change log entry, but I lost it!
I'm too annoyed to write one all over again.

ForwardingHeaders/qguardedptr.h: Removed.
ForwardingHeaders/qobject.h: Removed.

kwq/KWQGuardedPtr.cpp: Removed.
kwq/KWQGuardedPtr.h: Removed.
kwq/KWQNamespace.h: Removed.
kwq/KWQObject.cpp: Removed.
kwq/KWQObject.h: Removed.
kwq/KWQSignal.cpp: Removed.
kwq/KWQSignal.h: Removed.
kwq/KWQSlot.cpp: Removed.
kwq/KWQSlot.h: Removed.

platform/WidgetClient.h: Added.

WebCore.xcodeproj/project.pbxproj: Updated for removed and added files.
WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

bindings/js/JSDOMCore.cpp: Touched.
bindings/js/JSDOMEvents.cpp: Ditto.

bridge/BrowserExtension.h: (WebCore::BrowserExtension::~BrowserExtension):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementForView:]):
dom/CDATASectionImpl.cpp: (WebCore::CDATASectionImpl::cloneNode):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl):
dom/DocumentImpl.h:
kcanvas/device/KRenderingDevice.h:
khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
khtml/ecma/kjs_window.cpp: (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter):
khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::createTokenizer):
khtml/html/htmlparser.cpp: (WebCore::HTMLParser::HTMLParser): (WebCore::HTMLParser::insertNode): (WebCore::HTMLParser::handleError): (WebCore::HTMLParser::commentCreateErrorCheck): (WebCore::HTMLParser::noscriptCreateErrorCheck): (WebCore::HTMLParser::isInline): (WebCore::HTMLParser::finished):
khtml/html/htmlparser.h:
khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::scriptHandler): (WebCore::HTMLTokenizer::scriptExecution): (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::stopParsing): (WebCore::HTMLTokenizer::timerFired): (WebCore::HTMLTokenizer::processToken): (WebCore::parseHTMLDocumentFragment):
khtml/html/htmltokenizer.h:
kwq/KWQComboBox.h:
kwq/KWQComboBox.mm: (-[KWQPopUpButton setPopulatingMenu:QComboBox:::]): (QComboBox::itemSelected): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
kwq/KWQFileButton.h: (KWQFileButton::filename):
kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): (KWQFileButton::filenameChanged): (-[KWQFileButtonAdapter filenameChanged:]): (-[KWQFileButtonAdapter focusChanged:]): (-[KWQFileButtonAdapter clicked]):
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::QLineEdit): (QLineEdit::setAlignment): (KWQNSTextAlignment):
kwq/KWQListBox.h: (QListBox::changingSelection):
kwq/KWQListBox.mm: (QListBox::QListBox): (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]): (-[KWQTableView tableViewSelectionDidChange:]):
kwq/KWQScrollBar.h: (WebCore::): (QScrollBar::orientation):
kwq/KWQScrollBar.mm: (-[KWQScrollBar initWithQScrollBar:]): (QScrollBar::QScrollBar): (QScrollBar::valueChanged): (QScrollBar::scroll):
kwq/KWQSlider.h:
kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider slide:]): (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]): (QSlider::QSlider): (QSlider::sliderValueChanged): (QSlider::dimensions):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textViewDidChangeSelection:]): (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]): (-[KWQTextAreaTextView mouseDown:]): (-[KWQTextAreaTextView dispatchHTMLEvent:]):
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setAlignment):
kwq/KWQTextField.mm: (-[KWQTextFieldController action:]): (-[KWQTextFieldController controlTextDidEndEditing:]): (-[KWQTextFieldController controlTextDidChange:]): (-[KWQTextFieldController textChanged]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextFieldController setHasFocus:]): (-[KWQTextFieldController textViewDidChangeSelection:]):
loader/CachedObject.h:
page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::setOpener): (WebCore::Frame::nodeForWidget): (WebCore::Frame::disconnectOwnerRenderer):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
page/FrameView.cpp: (WebCore::FrameView::~FrameView):
platform/Brush.h:
platform/Pen.h:
platform/Widget.cpp: (WebCore::Widget::isFrameView):
platform/Widget.h: (WebCore::):
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawText):
platform/mac/WidgetMac.mm: (WebCore::Widget::Widget): (WebCore::Widget::focusPolicy): (WebCore::Widget::sendConsumedMouseUp): (WebCore::Widget::setClient): (WebCore::Widget::client):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::operator delete):
rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
rendering/render_form.cpp: (WebCore::RenderFormElement::clicked): (WebCore::RenderFormElement::textAlignment): (WebCore::RenderLineEdit::RenderLineEdit): (WebCore::RenderLineEdit::selectionChanged): (WebCore::RenderLineEdit::returnPressed): (WebCore::RenderLineEdit::performSearch): (WebCore::RenderLineEdit::valueChanged): (WebCore::RenderFileButton::RenderFileButton): (WebCore::RenderFileButton::returnPressed): (WebCore::RenderFileButton::valueChanged): (WebCore::RenderLegend::RenderLegend): (WebCore::RenderSelect::RenderSelect): (WebCore::RenderSelect::updateFromElement): (WebCore::RenderSelect::valueChanged): (WebCore::RenderSelect::selectionChanged): (WebCore::RenderSelect::createListBox): (WebCore::RenderTextArea::RenderTextArea): (WebCore::RenderTextArea::valueChanged): (WebCore::RenderTextArea::selectionChanged): (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::valueChanged):
rendering/render_form.h: (WebCore::RenderFormElement::element): (WebCore::RenderLineEdit::element): (WebCore::RenderFileButton::element): (WebCore::RenderFileButton::isEditable): (WebCore::RenderSelect::element): (WebCore::RenderTextArea::element): (WebCore::RenderSlider::element):
rendering/render_frames.cpp: (WebCore::RenderPart::RenderPart): (WebCore::RenderPart::~RenderPart): (WebCore::RenderPart::setFrame): (WebCore::RenderPart::setWidget): (WebCore::RenderPart::deleteWidget): (WebCore::RenderFrame::RenderFrame): (WebCore::RenderPartObject::RenderPartObject): (WebCore::RenderPartObject::layout):
rendering/render_frames.h:
rendering/render_layer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::hitTest):
rendering/render_layer.h: (WebCore::RenderLayer::parent): (WebCore::RenderLayer::previousSibling): (WebCore::RenderLayer::nextSibling): (WebCore::RenderLayer::firstChild): (WebCore::RenderLayer::lastChild):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::~RenderWidget): (WebCore::RenderWidget::setWidget): (WebCore::RenderWidget::layout): (WebCore::RenderWidget::sendConsumedMouseUp): (WebCore::RenderWidget::focusIn): (WebCore::RenderWidget::focusOut): (WebCore::RenderWidget::scrollToVisible): (WebCore::RenderWidget::isVisible): (WebCore::RenderWidget::element): (WebCore::RenderWidget::deleteWidget):
rendering/render_replaced.h:
xml/xmlhttprequest.cpp: (WebCore::requestsByDocument): (WebCore::addToRequestsByDocument): (WebCore::removeFromRequestsByDocument): (WebCore::XMLHttpRequest::getResponseText): (WebCore::XMLHttpRequest::getResponseXML): (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::callReadyStateChangeListener): (WebCore::XMLHttpRequest::urlMatchesDocumentDomain): (WebCore::XMLHttpRequest::open): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::abort): (WebCore::XMLHttpRequest::overrideMIMEType): (WebCore::XMLHttpRequest::setRequestHeader): (WebCore::XMLHttpRequest::getRequestHeader): (WebCore::XMLHttpRequest::getAllResponseHeaders): (WebCore::XMLHttpRequest::getResponseHeader): (WebCore::XMLHttpRequest::getSpecificHeader): (WebCore::XMLHttpRequest::responseIsXML): (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData): (WebCore::XMLHttpRequest::cancelRequests): (WebCore::XMLHttpRequest::detachRequests):
xml/xmlhttprequest.h:

3:05 PM Changeset in webkit [13175] by ggaren

2 edits in trunk/WebKitSite

Oops, accidentally deleted the archives links.

blog/wp-content/themes/webkit/sidebar.php: Bring them back.

3:04 PM Changeset in webkit [13174] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Reorganize link stubs (alphabetically).
Stub out Path methods to make cnn.com work.

platform/win/TemporaryLinkStubs.cpp: (FrameView::viewportToGlobal): (FrameView::updateBorder): (FrameView::isFrameView): (FrameView::topLevelWidget): (QScrollBar::~QScrollBar): (QScrollBar::setSteps): (QScrollBar::scroll): (QScrollBar::QScrollBar): (QScrollBar::setValue): (QScrollBar::setKnobProportion): (QListBox::QListBox): (QListBox::setSelected): (QListBox::sizeForNumberOfLines): (QListBox::isSelected): (QListBox::appendItem): (QListBox::doneAppendingItems): (ScrollView::scrollXOffset): (QComboBox::focusPolicy): (QTextEdit::QTextEdit): (QTextEdit::~QTextEdit): (QTextEdit::textWithHardLineBreaks): (QTextEdit::sizeWithColumnsAndRows): (QTextEdit::setColors): (QTextEdit::setFont): (QTextEdit::setWritingDirection): (QTextEdit::checksDescendantsForFocus): (QTextEdit::selectionStart): (QTextEdit::hasSelectedText): (QTextEdit::setReadOnly): (QTextEdit::setDisabled): (QTextEdit::setLineHeight): (QTextEdit::setSelectionStart): (QTextEdit::text): (QTextEdit::setWordWrap): (QTextEdit::setAlignment): (QTextEdit::getCursorPosition): (QTextEdit::setSelectionRange): (Widget::enableFlushDrawing): (Widget::isEnabled): (Widget::focusPolicy): (Widget::disableFlushDrawing): (Widget::setIsSelected): (Widget::unlockDrawingFocus): (KJavaAppletWidget::KJavaAppletWidget): (ScrollView::scrollPointRecursively): (ScrollView::scrollBy): (QLineEdit::selectAll): (QLineEdit::addSearchResult): (QLineEdit::selectionStart): (QLineEdit::hasSelectedText): (QLineEdit::selectedText): (QLineEdit::setAutoSaveName): (QLineEdit::checksDescendantsForFocus): (QLineEdit::setMaxResults): (GraphicsContext::GraphicsContext): (GraphicsContext::addFocusRingRect): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::drawFocusRing): (GraphicsContext::selectedTextBackgroundColor): (GraphicsContext::drawHighlightForText): (GraphicsContext::misspellingLineThickness): (GraphicsContext::addRoundedRectClip): (QSlider::QSlider): (QSlider::sizeHint): (QSlider::setValue): (QSlider::setMaxValue): (QSlider::~QSlider): (QSlider::setFont): (QListBox::setFont): (QListBox::~QListBox): (QListBox::setSelectionMode): (QListBox::setEnabled): (QListBox::clear): (QListBox::checksDescendantsForFocus): (KWQFileButton::KWQFileButton): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFilename): (KWQFileButton::baselinePosition): (KWQFileButton::setFrameGeometry): (QSlider::focusPolicy): (QListBox::focusPolicy): (Cursor::Cursor): (MouseEvent::MouseEvent): (KWQKCookieJar::cookieEnabled): (WebCore::screenDepth): (WebCore::usableScreenRect): (FrameWin::createPlugin): (ScrollView::resizeContents): (ScrollView::visibleHeight): (ScrollView::visibleWidth): (ScrollView::setContentsPos): (ScrollView::contentsHeight): (ScrollView::contentsWidth): (ScrollView::inWindow): (Path::~Path): (Path::Path): (Path::contains): (Path::translate): (Path::boundingRect): (Path::operator=):

2:57 PM Changeset in webkit [13173] by ggaren

3 edits in trunk/WebKitSite

Reviewed by Beth.

Some site cleanup.

blog/wp-content/themes/webkit/sidebar.php: sync with the sidebar for the rest of the site.
quality/lifecycle.html: add Joost's homepage to his contact info.

2:39 PM Changeset in webkit [13172] by ggaren

2 edits in trunk/WebKitSite

Doing penance after being set straight by Joost.

projects/compat/hitlist.html: Remove slur against QA. My humblest apologies.

2:33 PM Changeset in webkit [13171] by ggaren

3 edits
1 add in trunk/WebKitSite

Reviewed by Maciej, Darin.

Added Safari Compatibility Hit List.

nav.inc: Link to the hit list.
projects/compat/hitlist.html: Added.
projects/compat/index.html: Link to the hit list.

11:59 AM Changeset in webkit [13170] by ap

2 edits
3 copies in trunk/JavaScriptCore

Patch by David Carson, reviewed by Darin.

Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=7582 c_utility.cpp contains CFString OS X platform-dependent code; should use ICU

Tested with test case from:
http://bugzilla.opendarwin.org/show_bug.cgi?id=5163

bindings/c_utility.cpp (convertUTF8ToUTF16): Changed to using Unicode converter from ICU, and manual Latin-1 conversion.
icu/unicode/ucnv.h: Copied from WebCore.
icu/unicode/ucnv_err.h: Ditto.
icu/unicode/uenum.h: Ditto.

11:43 AM Changeset in webkit [13169] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

fast/lists/drag-into-marker-expected.checksum: Added.
fast/lists/drag-into-marker-expected.png: Added.
fast/lists/drag-into-marker-expected.txt: Added.
fast/lists/drag-into-marker.html: Added.

WebCore:

Reviewed by darin

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

Call RenderObject::setInnerNode(), which sets both the
innerNode and the innerNonSharedNode.

rendering/render_list.cpp: (WebCore::RenderListItem::nodeAtPoint):
rendering/render_list.h:

WebKitTools:

Reviewed by darin

Sent the windowNumber when sending events.
Added leapForward so that we don't have to spend time waiting
in layout tests that do mouse operations that require delays.

DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController currentEventTime]): (-[EventSendingController leapForward:]): (-[EventSendingController mouseDown]): (-[EventSendingController mouseUp]): (-[EventSendingController mouseMoveToX:Y:]):

9:11 AM Changeset in webkit [13168] by darin

2 edits in trunk/WebCore

WebCore.vcproj/WebCore/WebCore.vcproj: Removed a lot of long-ago-deleted files from the kwq directory.

8:50 AM Changeset in webkit [13167] by darin

147 edits
2 adds
2 deletes in trunk/WebCore

Reviewed by Maciej.

moved all the remnants of the public C++ DOM API out of khtml/dom
changed from "int" to "ExceptionCode" for DOM exceptions
removed unused CSS_HTML_RELATIVE
changed offsetInCharacters to be a member function of NodeImpl
changed DOM functions that take a NodeType to use NodeType instead of unsigned short for clarity (will still be unsigned short in bindings)
changed exception constants so they can be used directly in the implementation code (added in the offsets for different types of exceptions)
replaced the eventListenerType function with an isHTMLEventListener function
got rid of EventListenerEvent, which is a synonym for EventImpl*
eliminated handleEventImpl, whish is now the same as handleEvent

did other preparation for the "remove Impl suffix" renaming (tested by using a script that does the renaming)

khtml/dom/css_rule.h: Removed.
khtml/dom/css_stylesheet.h: Removed.
khtml/dom/css_value.h: Removed.
khtml/dom/dom2_events.cpp: Removed.
khtml/dom/dom2_events.h: Removed.
khtml/dom/dom2_range.h: Removed.
khtml/dom/dom2_traversal.cpp: Removed.
khtml/dom/dom2_traversal.h: Removed.
khtml/dom/dom_exception.h: Removed.
khtml/dom/dom_node.h: Removed.

dom/EventListener.h: Added.
dom/ExceptionCode.h: Added.

WebCore+SVG/kdom.h: Removed NodeType and ExceptionCodes
WebCore+SVG/kdomevents.h: Removed.

WebCore.xcodeproj/project.pbxproj: Updated for file changes.
WebCore.xcodeproj/project.pbxproj: Updated for file changes.

bindings/scripts/CodeGeneratorJS.pm: Removed unneeded DOM:: prefix. Updated file names and exception prefix for changes in DOM exceptions.

bindings/js/JSDOMCore.cpp: Touched to cause auto-generated code to be recompiled. We need to get this fixed!
bindings/js/JSDOMEvents.cpp: Ditto.

dom/Attr.idl:
dom/CharacterData.idl:
dom/DOMImplementation.idl:
dom/DocumentType.idl:
dom/Element.idl:
dom/Entity.idl:
dom/MutationEvent.idl:
dom/Notation.idl:
dom/ProcessingInstruction.idl:
dom/Text.idl:
dom/WheelEvent.idl: Touched all IDL files so that changes in CodeGeneratorJS.pm would take effect. Added license headers.

bindings/objc/DOM.mm: Fixed garbled license agreement. Updated includes. Changed from a single "using namespace WebCore" to individual using statements because of the imminent conflict between DOMImplementation in Objective C and WebCore::DOMImplementation (currently has an Impl suffix). Added a typedef for WebCore::DOMImplementationImpl. Changed to use ExceptionCode instead of int.

bindings/objc/DOMCSS.h: Removed DOMCSSException and the special CSS exception codes. This is a feature of DOM Level 1 only. In DOM Level 2 these were eliminated and use basic DOM exception codes instead. We might have to do something for binary compatibility eventually, but perhaps not.

bindings/objc/DOMCSS.mm:
bindings/objc/DOMEvents.mm:
bindings/objc/DOMEventsInternal.h:
bindings/objc/DOMHTML.mm:
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMViews.mm:
bindings/objc/DOMViewsInternal.h: Fixed garbled license agreements. Changed to use ExceptionCode instead of int and name the variable "ec".

bindings/objc/DOMInternal.h: Changed addDOMWrapperImpl to take NSObject* instead of id. This helps with overload resolution when addDOMWrapperImpl is renamed to be addDOMWrapper. Changed ALLOW_DOM_CAST to always use "class" in from of the type name of the WebCore class. This helps work around what seems like a bug in namespace support in Objective-C mode, although the bug only happens after the "remove Impl" renaming.
bindings/objc/DOMInternal.mm: (getDOMWrapperImpl): Changed to use HashMap. (addDOMWrapperImpl): Ditto. (removeDOMWrapper): Ditto. (raiseDOMException): Update to use new names for exception number ranges.

bridge/mac/WebCoreFrameBridge.mm:
khtml/ecma/xmlserializer.cpp:
kwq/KWQAccObject.mm: Removed unneeded includes.

css/css_ruleimpl.h: Moved "rule type" into this header.

dom/CommentImpl.h:
dom/CommentImpl.cpp: (WebCore::CommentImpl::offsetInCharacters): Added. Returns true.

khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction): Changed this around so we don't have a local variable named docImpl.

khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Updated for new form of exception constants.

khtml/ecma/kjs_events.h:
khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Changed to no longer use EventListenerEvent. (KJS::JSAbstractEventListener::isHTMLEventListener): Added.

rendering/RenderTextField.h: Updated includes. Tweaked the code formatting of InputMutationListener. (Might be unnecessary since this class might be deleted soon.)

bridge/mac/MacFrame.mm:
css/css_computedstyle.cpp:
css/css_computedstyle.h:
css/css_ruleimpl.cpp:
css/css_stylesheetimpl.cpp:
css/css_stylesheetimpl.h:
css/css_valueimpl.cpp:
css/css_valueimpl.cpp:
css/css_valueimpl.h:
css/css_valueimpl.h:
css/cssparser.cpp:
css/cssstyleselector.cpp:
dom/CDATASectionImpl.cpp:
dom/CDATASectionImpl.h:
dom/CharacterDataImpl.cpp:
dom/CharacterDataImpl.h:
dom/ContainerNodeImpl.cpp:
dom/DOMImplementationImpl.cpp:
dom/DocumentFragmentImpl.cpp:
dom/DocumentFragmentImpl.h:
dom/DocumentImpl.cpp:
dom/DocumentImpl.h:
dom/DocumentTypeImpl.cpp:
dom/DocumentTypeImpl.h:
dom/NamedNodeMapImpl.h:
dom/NodeImpl.cpp:
dom/NodeImpl.h:
dom/NodeListImpl.cpp:
dom/TextImpl.cpp:
dom/TextImpl.h:
dom/dom2_eventsimpl.cpp:
dom/dom2_eventsimpl.h:
dom/dom2_rangeimpl.cpp:
dom/dom2_rangeimpl.h:
dom/dom2_traversalimpl.cpp:
dom/dom2_traversalimpl.h:
dom/dom_elementimpl.cpp:
dom/dom_elementimpl.h:
dom/dom_position.cpp:
dom/dom_xmlimpl.cpp:
dom/dom_xmlimpl.h:
dom/xml_tokenizer.cpp:
editing/AppendNodeCommand.cpp:
editing/ApplyStyleCommand.cpp:
editing/CompositeEditCommand.cpp:
editing/DeleteFromTextNodeCommand.cpp:
editing/InsertIntoTextNodeCommand.cpp:
editing/InsertLineBreakCommand.cpp:
editing/InsertNodeBeforeCommand.cpp:
editing/InsertParagraphSeparatorCommand.cpp:
editing/JoinTextNodesCommand.cpp:
editing/MergeIdenticalElementsCommand.cpp:
editing/RemoveNodeAttributeCommand.cpp:
editing/RemoveNodeCommand.cpp:
editing/ReplaceSelectionCommand.cpp:
editing/Selection.cpp:
editing/SelectionController.cpp:
editing/SelectionController.h:
editing/SetNodeAttributeCommand.cpp:
editing/SplitElementCommand.cpp:
editing/SplitTextNodeCommand.cpp:
editing/VisiblePosition.cpp:
editing/WrapContentsInDummySpanCommand.cpp:
editing/htmlediting.cpp:
editing/markup.cpp:
editing/visible_text.cpp:
khtml/ecma/kjs_binding.h:
khtml/ecma/kjs_css.cpp:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_html.cpp:
khtml/ecma/kjs_range.cpp:
khtml/ecma/kjs_traversal.cpp:
khtml/ecma/kjs_traversal.h:
khtml/ecma/kjs_window.cpp:
khtml/html/HTMLElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.h:
khtml/html/HTMLOptionsCollectionImpl.cpp:
khtml/html/HTMLSelectElementImpl.cpp:
khtml/html/HTMLTextAreaElementImpl.cpp:
khtml/html/html_documentimpl.cpp:
khtml/html/html_documentimpl.h:
khtml/html/html_headimpl.cpp:
khtml/html/html_tableimpl.cpp:
khtml/html/html_tableimpl.h:
khtml/html/htmlparser.cpp:
khtml/xbl/xbl_tokenizer.cpp:
khtml/xsl/xsl_stylesheetimpl.cpp:
ksvg2/misc/SVGDocumentExtensions.cpp:
ksvg2/svg/SVGAnimationElementImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.cpp:
ksvg2/svg/SVGDOMImplementationImpl.h:
ksvg2/svg/SVGDocumentImpl.cpp:
ksvg2/svg/SVGDocumentImpl.h:
ksvg2/svg/SVGElementImpl.cpp:
ksvg2/svg/SVGLengthImpl.cpp:
ksvg2/svg/SVGLocatableImpl.cpp:
ksvg2/svg/SVGPolyElementImpl.cpp:
ksvg2/svg/SVGSVGElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.cpp:
ksvg2/svg/SVGStyleElementImpl.h:
ksvg2/svg/SVGUseElementImpl.cpp:
page/Frame.cpp:
page/FrameView.cpp:
rendering/render_object.cpp:
xml/xmlhttprequest.cpp: Changed to use ExceptionCode instead of int and name the variable "ec". Also updated use of exception codes and other constants to get them from their new locations.

2:12 AM Changeset in webkit [13166] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix more pages (apple.com, yahoo.com) by returning empty error image.
Empty a couple more stubs and clean up stub style a little.

platform/cairo/ImageCairo.cpp: (WebCore::Image::loadResource):
platform/win/TemporaryLinkStubs.cpp: (QListBox::isSelected): (QSlider::sizeHint): (QScrollBar::~QScrollBar): (FrameWin::getObjectInstanceForWidget): (FrameWin::getEmbedInstanceForWidget): (FrameWin::recordFormValue): (FrameWin::getAppletInstanceForWidget): (FrameWin::passMouseDownEventToWidget): (FrameWin::passWheelEventToChildWidget): (FrameWin::createPlugin): (BrowserExtensionWin::createNewWindow): (Path::Path): (QLineEdit::~QLineEdit): (QLineEdit::setLiveSearch): (QComboBox::~QComboBox):

1:15 AM Changeset in webkit [13165] by eseidel

2 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by andersca.

Empty enough stubs to make apple.com load.

platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (GraphicsContext::misspellingLineThickness): (QTextEdit::selectAll): (QTextEdit::setSelectionStart): (Widget::unlockDrawingFocus): (QLineEdit::setAutoSaveName): (ScrollView::scrollYOffset): (KWQFileButton::setFilename): (QListBox::setFont): (GraphicsContext::beginTransparencyLayer): (GraphicsContext::endTransparencyLayer): (QComboBox::QComboBox): (QComboBox::setFont): (QComboBox::baselinePosition): (QComboBox::setWritingDirection): (QComboBox::clear): (QComboBox::appendItem): (QComboBox::setCurrentItem): (QComboBox::sizeHint): (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QLineEdit::setLiveSearch):

12:39 AM Changeset in webkit [13164] by eseidel

3 edits in trunk/WebCore

2006-03-06 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix external resource loading.
Make a bunch of stubs not abort (to fix slashdot).

platform/win/TemporaryLinkStubs.cpp: (QTextEdit::textWithHardLineBreaks): (KWQFileButton::click): (QComboBox::setFrameGeometry): (QTextEdit::setText): (QListBox::appendItem): (GraphicsContext::endTransparencyLayer): (QLineEdit::selectionStart): (QTextEdit::QTextEdit): (QListBox::isSelected): (QComboBox::focusPolicy): (QTextEdit::setCursorPosition): (QTextEdit::setAlignment): (QLineEdit::selectedText): (ScrollView::scrollPointRecursively): (QScrollBar::setSteps): (QComboBox::appendItem): (GraphicsContext::drawLineForMisspelling): (KWQFileButton::setFilename): (QListBox::setWritingDirection): (QListBox::focusPolicy): (MouseEvent::MouseEvent): (QSlider::setFont): (Widget::setEnabled): (Widget::paint): (ScrollView::addChild): (ScrollView::inWindow): (GraphicsContext::setShadow): (GraphicsContext::clearShadow): (RenderThemeWin::paintCheckbox): (RenderThemeWin::paintRadio): (RenderThemeWin::paintButton): (RenderThemeWin::paintTextField): (QLineEdit::QLineEdit): (QLineEdit::setFont): (QLineEdit::setAlignment): (QLineEdit::setWritingDirection): (QLineEdit::maxLength): (QLineEdit::setMaxLength): (QLineEdit::text): (QLineEdit::setText): (QLineEdit::cursorPosition): (QLineEdit::setCursorPosition): (QLineEdit::setEdited): (QLineEdit::setReadOnly): (QLineEdit::setPlaceholderString): (QLineEdit::setColors): (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed