⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 10, 2006:

7:32 PM Changeset in webkit [13261] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • bridge/win/FrameWin.h: Removed declaration of generateFrameName.
7:30 PM Changeset in webkit [13260] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Adele.

  • removed some unused stuff from Frame and MacFrame
  • page/Frame.h: Removed autoloadImages (the setter), enableMetaRefresh, setCharset, backgroundURL, findTextBegin, findTextNext, preloadStyleSheet, preloadScript, restored, onURL, selectionChanged, htmlError, openFile, updateActions, openURLInFrame, overURL, checkLinkSecurity, and cacheId.
  • page/FramePrivate.h: Removed m_restored, m_frameNameId, m_strSelectedURL, m_strSelectedURLTarget, m_bDnd, m_bClearing, m_bSecurityInQuestion, m_focusNodeRestored, m_focusNodeNumber, and m_newJSInterpreterExists.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Removed use of m_restored, code to set m_bClearing. (WebCore::Frame::clear): Removed code to set m_bClearing and m_frameNameId. (WebCore::Frame::khtmlMousePressEvent): Removed code to set m_strSelectedURL and m_strSelectedURLTarget.
  • bridge/mac/MacFrame.h: Removed scheduleHistoryNavigation and requestedURLString.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLFromPageCache): Removed use of m_restored. Removed unused requestedURLString.
  • bridge/mac/WebCoreFrameBridge.h: Removed requestedURLString.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebFrameBridge.m: Remove unused requestedURLString method.
7:25 PM Changeset in webkit [13259] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • page/FrameTree.cpp: Add include of <stdarg.h>.
7:21 PM Changeset in webkit [13258] by darin
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

  • change how frame namespacing works to be more completely on the WebCore side
  • WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
  • WebView/WebFrame.m: Ditto.
  • WebView/WebView.m: (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:]. (-[WebView groupName]): Call -[WebCorePageBridge groupName].
7:17 PM Changeset in webkit [13257] by darin
  • 23 edits
    1 move
    8 adds in trunk

LayoutTests:

Reviewed by Geoff, except for frame-name-reset, which was done by Alexey.

  • fast/dom/Window/open-existing-pop-up-blocking-expected.checksum: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.png: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.txt: Added.
  • fast/dom/Window/open-existing-pop-up-blocking.html: Added.
  • fast/dom/Window/resources/open-sibling-subframe.html: Added.
  • fast/dom/Window/resources/sibling-subframe-content.html: Added.
  • fast/frames/frame-name-reset.html: Added.
  • fast/frames/frame-name-reset-expected.txt: Added.

WebCore:

Reviewed by Geoff.

  • refactor frame-name-related functions into the FrameTree object
  • WebCore.xcodeproj/project.pbxproj: Update for rename.
  • bridge/mac/MacFrame.h: Remove generateFrameName.
  • bridge/mac/MacFrame.mm: Ditto.
  • bridge/mac/PageMac.h: Added a declaration for WebCorePageBridge.
  • bridge/mac/WebCoreFrameBridge.h: Remove _frameNamespace, generateFrameName, setFrameNamespace, frameNamespace.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge childFrameNamed:]): Change to call the new child function on the FrameTree. (-[WebCoreFrameBridge findFrameNamed:]): Change to call the new find function on the FrameTree. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Change since the contentPart function has been renamed to contentFrame.
  • bridge/mac/WebCoreFrameNamespaces.h: Removed everything except for the one method still used on the WebKit side, framesInNamespace:.
  • bridge/mac/WebCoreFrameNamespaces.m: Renamed.
  • bridge/mac/WebCoreFrameNamespaces.mm: Added. Reimplemented the framesInNamespace method to use the namespace in WebCore::Page.
  • bridge/mac/WebCorePageBridge.h: Added setGroupName and groupName.
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setGroupName:]): Added. Calls through to Page. (-[WebCorePageBridge groupName]): Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): Changed to call contentFrame by its new name. (KJS::HTMLElement::frameGetter): Ditto. (KJS::HTMLElement::iFrameGetter): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::Window::childFrameGetter): Changed to call FrameTree::child instead of Frame::childFrameNamed. (KJS::Window::namedFrameGetter): Changed to call FrameTree::find instead of Frame::findFrame. (KJS::Window::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::Window::getOwnPropertySlot): Changed to call FrameTree::child, FrameTree::find, and FrameTree::childCount instead of Frame::childFrameNamed, and Frame::findFrame, and Frame::frames. (KJS::WindowFunc::callAsFunction): Call FrameTree::find to check if the window is already open when considering whether to block a pop-up. (KJS::FrameArray::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::FrameArray::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::FrameArray::nameGetter): Changed to call FrameTree::child instead of Frame::findFrame. (KJS::FrameArray::getOwnPropertySlot): Changed to call FrameTree::child, and FrameTree::childCount instead of Frame::findFrame and Frame::frames.
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount. (WebCore::HTMLFrameElementImpl::openURL): Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName. (WebCore::HTMLFrameElementImpl::close): Changed to call Page::decrementFrameCount instead of Frame::decrementFrameCount. Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentFrame): Renamed from contentPart. Also changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentDocument): Updated for name change of contentFrame from contentPart. (WebCore::HTMLIFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName.
  • rendering/render_frames.cpp: (WebCore::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount.
  • page/Frame.h: Removed frameNames, frames, childFrameNamed, findFrame, currentFrame, frameExists, incrementFrameCount, decrementFrameCount, topLevelFrameCount, generateFrameName, and requestFrameName functions.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): Changed to use FrameTree::child instead of Frame::childFrameNamed.
  • page/FrameTree.h: Changed name to an atomic string. Changed childCount to unsigned. Added isDescendantOf, traverseNext, child, find, uniqueChildName.
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): Changed to call uniqueChildName to handle name duplication logic. (WebCore::FrameTree::uniqueChildName): Added. Checks for duplication and generates an appropriate frame name if there is a duplicate. (WebCore::FrameTree::child): Added. (WebCore::FrameTree::find): Added. (WebCore::FrameTree::isDescendantOf): Added. (WebCore::FrameTree::traverseNext): Added.
  • page/Page.h: Added setGroupName, groupName, frameNamespace, incrementFrameCount, decrementFrameCount, and frameCount.
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_frameCount to 0. (WebCore::Page::~Page): Call setGroupName to remove the page from any group it's in. (WebCore::Page::setGroupName): Added. (WebCore::Page::frameNamespace): Added.
  • platform/win/TemporaryLinkStubs.cpp: Removed FrameWin::generateFrameName.
5:35 PM Changeset in webkit [13256] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin, harrison


~3x speedup pasting plain text from the console

  • dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):
4:19 PM Changeset in webkit [13255] by hyatt
  • 3 edits
    3 adds in trunk/WebCore

Font refactoring on win32.

3:49 PM Changeset in webkit [13254] by thatcher
  • 5 copies in tags/Safari-521.9

New tag.

3:46 PM Changeset in webkit [13253] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning.

3:20 PM Changeset in webkit [13252] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix win32 networking to properly use async load API
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start):
1:15 PM Changeset in webkit [13251] by eseidel
  • 3 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Fix build.

  • platform/win/FontWin.cpp: (WebCore::getFontData):
  • platform/win/TemporaryLinkStubs.cpp:
1:13 PM Changeset in webkit [13250] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute
  • fast/forms/radio-attr-order-expected.checksum: Added.
  • fast/forms/radio-attr-order-expected.png: Added.
  • fast/forms/radio-attr-order-expected.txt: Added.
  • fast/forms/radio-attr-order.html: Added.

WebCore:

Reviewed by Tim Hatcher.

  • fix for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

Test: fast/forms/radio-attr-order.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::parseMappedAttribute): When the name attribute gets parsed for radio buttons, if its supposed to be checked by default, call setChecked. Also, when the name changes on a checked button, we don't need to check that there's a form before removing it as the checked button for that group. That was an old check from when we required a form to keep track of checked buttons.
1:05 PM Changeset in webkit [13249] by eseidel
  • 24 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add real ScrollViewWin implementation (fixes redraw bugs, adds ScrollBar support.)

  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): Fix crasher.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::setContentsPos): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setHScrollBarMode): (WebCore::ScrollView::setVScrollBarMode): (WebCore::ScrollView::setScrollBarsMode): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (ScrollView::scrollPointRecursively):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::windowHandle): mark as const
11:28 AM Changeset in webkit [13248] by hyatt
  • 6 edits in trunk/WebCore

Rename the m_renderer variable to m_dataSet now that the class name
has changed.

Reviewed by adele

  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h:
  • platform/mac/FontMac.mm: (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::FontData::FontData): (WebCore::FontData::~FontData): (WebCore::getFontData): (WebCore::FontDataSet::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::xHeight): (WebCore::Font::lineSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::drawText):
10:58 AM Changeset in webkit [13247] by hyatt
  • 6 edits
    1 move in trunk/WebCore

Rename FontRenderer to FontDataSet.

Reviewed by adele

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h: Added.
  • platform/FontRenderer.h: Removed.
  • platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate):
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate): (WebCore::FontDataSet::primaryCairoFont):
10:40 AM Changeset in webkit [13246] by hyatt
  • 2 edits in trunk/WebCore/platform/win

FIx a couple of font crashers.

Note: See TracTimeline for information about the timeline view.