⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 18, 2006:

10:51 PM Changeset in webkit [13387] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

One more time.

10:48 PM Changeset in webkit [13386] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more fixes for things found during dry runs.

10:31 PM Changeset in webkit [13385] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Did another dry run of the renaming and had to fix a couple of things.

10:05 PM Changeset in webkit [13384] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/canvas/patternfill-repeat-expected.checksum: Added.
  • fast/canvas/patternfill-repeat-expected.png: Added.
  • fast/canvas/patternfill-repeat-expected.txt: Added.
  • fast/canvas/patternfill-repeat.html: Added.

WebCore:

Test: fast/canvas/patternfill-repeat.html

Reviewed by Darin.

  • CanvasPattern.cpp (CanvasPattern::createPattern) Change stepping so that repeat-x, repeat-y, and no-repeat repeat outside the view area by using large values for repeat interval.
10:00 PM Changeset in webkit [13383] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/Element/class-attribute-whitespace-expected.checksum: Added.
  • fast/dom/Element/class-attribute-whitespace-expected.png: Added.
  • fast/dom/Element/class-attribute-whitespace-expected.txt: Added.
  • fast/dom/Element/class-attribute-whitespace.html: Added. NOTE: This test will get broken if "eol-style" processing is done on it.

WebCore:

Test: fast/dom/Element/class-attribute-whitespace.html

Reviewed by Darin.

  • dom/dom_elementimpl.cpp: (WebCore::isClassWhitespace): Helper function to check if a character in the class attribute should be treated as whitespace. Added \r and \t. (WebCore::NamedMappedAttrMapImpl::parseClassAttribute): Instead of creating a QStringList and iterating it, do everything in one pass over the string.
9:49 PM Changeset in webkit [13382] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/block/float/vertical-move-relayout-expected.checksum: Added.
  • fast/block/float/vertical-move-relayout-expected.png: Added.
  • fast/block/float/vertical-move-relayout-expected.txt: Added.
  • fast/block/float/vertical-move-relayout.html: Added.

WebCore:

Test: fast/block/float/vertical-move-relayout.html

Reviewed by Hyatt.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Call markAllDescendantsWithFloatsForLayout when the child's vertical position changes.
9:47 PM Changeset in webkit [13381] by darin
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/js/exception-linenums-in-html-3-expected.txt: Added.
  • fast/js/exception-linenums-in-html-3.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <style> tag, which causes the code path for Bug 6314 to be tested.

  • fast/js/missing-style-end-tag-js-expected.txt: Added.
  • fast/js/missing-style-end-tag-js.html: Added.

While developing a fix for Bug 6314, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

  • fast/tokenizer/missing-style-end-tag-1-expected.checksum: Added.
  • fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
  • fast/tokenizer/missing-style-end-tag-1-expected.txt: Added.
  • fast/tokenizer/missing-style-end-tag-1.html: Added.
  • fast/tokenizer/missing-style-end-tag-2-expected.checksum: Added.
  • fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
  • fast/tokenizer/missing-style-end-tag-2-expected.txt: Added.
  • fast/tokenizer/missing-style-end-tag-2.html: Added.

The first test case contains an unclosed <style> tag in <head>, while the
second test case contains an unclosed <style> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Test: fast/js/exception-linenums-in-html-3.html
Test: fast/js/missing-style-end-tag-js.html
Test: fast/tokenizer/missing-style-end-tag-1.html
Test: fast/tokenizer/missing-style-end-tag-2.html

  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </style> tag and handle this condition if identified.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </style> tag, reset the state of the tokenizer and retokenize with no special handling for <style>. The parser will handle the missing </style> tag in HTMLParser::handleError().
9:36 PM Changeset in webkit [13380] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5351:
SVG: Safari ignores <title> elements

Make SVGTitleElementImpl act the same as HTMLTitleElementImpl,
in the process setting the title on the right triggers.

  • ksvg2/svg/SVGTitleElementImpl.cpp: (SVGTitleElementImpl::SVGTitleElementImpl): (SVGTitleElementImpl::title): (SVGTitleElementImpl::closeRenderer): (SVGTitleElementImpl::insertedIntoDocument): (SVGTitleElementImpl::removedFromDocument): (SVGTitleElementImpl::childrenChanged):
  • ksvg2/svg/SVGTitleElementImpl.h:
9:28 PM Changeset in webkit [13379] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/replaced/img-1x1-expected.checksum: Added.
  • fast/replaced/img-1x1-expected.txt: Added.
  • fast/replaced/img-1x1.html: Added.
  • fast/replaced/img-1x1-expected.png: Added.
9:25 PM Changeset in webkit [13378] by darin
  • 17 edits in trunk/LayoutTests
  • updated test results for tests affected by Hyatt's latest table fix
  • tables/mozilla/bugs/bug44505-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
8:49 PM Changeset in webkit [13377] by darin
  • 2 edits in trunk/WebCore
  • another try at fixing Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added EventTargetNodeImpl.h and .cpp.
8:34 PM Changeset in webkit [13376] by darin
  • 2 edits in trunk/WebCore
  • another try at fixing Windows build
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Added EventTargetNodeCast.
8:21 PM Changeset in webkit [13375] by darin
  • 4 edits in trunk/WebCore
  • try to fix Windows build
  • bridge/win/FrameWin.h: Remove KURL parameter.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::canRunModal): Ditto.
8:19 PM Changeset in webkit [13374] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • fix leaks caused by the fix for Bugzilla bug 3560
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Text renderers with first-letter pseudo style are children of an existing first-letter inline that has been updated, and should be destroyed.
8:12 PM Changeset in webkit [13373] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more renaming refinements.

1:39 AM Changeset in webkit [13372] by hyatt
  • 8 edits in trunk/WebCore

Fix for bug 7841, tables, table rows, and table row groups should
all support overflow:hidden.

Reviewed by eric

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getOverflowClipRect):
  • rendering/RenderTable.h:
  • rendering/RenderTableCol.h: (WebCore::RenderTableCol::requiresLayer):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
  • rendering/render_box.cpp: (WebCore::RenderBox::setStyle):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer):

Mar 17, 2006:

7:22 PM Changeset in webkit [13371] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

dynamically"

  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • dynamically added link-tags for stylesheets were messing up the counting of pending stylesheets. If a head link element specifies a new stylesheet but the previously specified stylesheet is still loading, tell the document that stylesheets are loaded so that there are no remaining requests for it to be loaded.
7:19 PM Changeset in webkit [13370] by aliceli1
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Justin.

  • fast/dom/HTMLHeadElement/head-link-style-href-check-expected.checksum: Added.
  • fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png: Added.
  • fast/dom/HTMLHeadElement/head-link-style-href-check-expected.txt: Added.
  • fast/dom/HTMLHeadElement/head-link-style-href-check.html: Added.
6:04 PM Changeset in webkit [13369] by ggaren
  • 62 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/prototype-chain-expected.txt: Updated to reflect new prototype chain.

WebCore:

Reviewed by Darin.

  • Fixed some crashes in event dispatch and settled the question of when getDocument() can return NULL, removing superfluous NULL checks.

I promise to check in a test case soon, but I need to land this before
the global rename happens, and I left the test file on my other machine.

Here's what I did:

(1) Removed NULL checks for getDocument() in cases where we know it
should not return NULL (which turned out to be all but one). Replaced
with ASSERT inside getDocument(). Tested to ensure there was no
regression @ albertsons.com.

(2) Added the EventTargetNode class, which represents Nodes that
implement the DOM EventTarget interface. Discussed this design with
Maciej and Hyatt. The previous dsign -- assuming that all Nodes were
EventTargets -- made it possible to crash WebKit by, for example,
dispatching a mouse event to a documentType node that was not
associated with a document.

(3) Reflected (2) into the JS bindings and touched JSDOMCore.cpp to
force a re-build.

(4) Using classInfo checking, strengthened type constraints on
JavaScript method dispatch so that you can't finagle JavaScript into,
for example, invoking a document-dependent method belonging to a
node type that's guaranteed to have a document on a node type that may
not have one.

(5) Pushed some IE-specific JS bindings that depend on a node having a
document down from DOMNode to DOMElement. (An element always has a
document.) Tested that Firefox's behavior matched. Confirmed with MSDN.

(6) Updated Objc bindigns to throw an exception if you try to use
the event interface on a node that doesn't support it. Discussed this
design with Maciej and TimH.

(7) Consolidated repeated documentElement-finding code in the Position
class into the Position::documentElement() method. Did the same for
repeated top-level document finding and DocumentImpl::topDocument().


  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMCore.cpp:
  • bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMNode KJS::Bindings::]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::keyEvent): (WebCore::MacFrame::dispatchCPPEvent):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
  • css/css_base.cpp: (WebCore::StyleBaseImpl::baseURL):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSMutableStyleDeclarationImpl::removeProperty): (WebCore::CSSMutableStyleDeclarationImpl::setProperty):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Attr.idl:
  • dom/CharacterData.idl:
  • dom/CharacterDataImpl.cpp: (WebCore::CharacterDataImpl::CharacterDataImpl): (WebCore::CharacterDataImpl::rendererIsNeeded): (WebCore::CharacterDataImpl::dump):
  • dom/CharacterDataImpl.h:
  • dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::ContainerNodeImpl): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::attach): (WebCore::ContainerNodeImpl::detach): (WebCore::ContainerNodeImpl::insertedIntoDocument): (WebCore::ContainerNodeImpl::removedFromDocument): (WebCore::ContainerNodeImpl::insertedIntoTree): (WebCore::ContainerNodeImpl::removedFromTree): (WebCore::ContainerNodeImpl::setFocus): (WebCore::ContainerNodeImpl::setActive): (WebCore::ContainerNodeImpl::setHovered): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
  • dom/ContainerNodeImpl.h:
  • dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::removeAllEventListenersFromAllNodes): (WebCore::DocumentImpl::removeAllDisconnectedNodeEventListeners): (WebCore::DocumentImpl::getAccObjectCache): (WebCore::DocumentImpl::setFocusNode): (WebCore::DocumentImpl::topDocument):
  • dom/Element.idl:
  • dom/EventTargetNodeImpl.cpp: Added. (WebCore::EventTargetNodeImpl::EventTargetNodeImpl): (WebCore::EventTargetNodeImpl::~EventTargetNodeImpl): (WebCore::EventTargetNodeImpl::insertedIntoDocument): (WebCore::EventTargetNodeImpl::removedFromDocument): (WebCore::EventTargetNodeImpl::addEventListener): (WebCore::EventTargetNodeImpl::removeEventListener): (WebCore::EventTargetNodeImpl::removeAllEventListeners): (WebCore::EventTargetNodeImpl::handleLocalEvents): (WebCore::EventTargetNodeImpl::dispatchGenericEvent): (WebCore::EventTargetNodeImpl::dispatchEvent): (WebCore::EventTargetNodeImpl::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNodeImpl::dispatchWindowEvent): (WebCore::EventTargetNodeImpl::dispatchUIEvent): (WebCore::EventTargetNodeImpl::dispatchKeyEvent): (WebCore::EventTargetNodeImpl::dispatchMouseEvent): (WebCore::EventTargetNodeImpl::dispatchSimulatedMouseEvent): (WebCore::EventTargetNodeImpl::dispatchWheelEvent): (WebCore::EventTargetNodeImpl::dispatchHTMLEvent): (WebCore::EventTargetNodeImpl::removeHTMLEventListener): (WebCore::EventTargetNodeImpl::setHTMLEventListener): (WebCore::EventTargetNodeImpl::getHTMLEventListener): (WebCore::EventTargetNodeImpl::disabled): (WebCore::EventTargetNodeImpl::defaultEventHandler): (WebCore::EventTargetNodeImpl::dump):
  • dom/EventTargetNodeImpl.h: Added. (WebCore::EventTargetNodeImpl::isEventTargetNode): (WebCore::EventTargetNodeImpl::preDispatchEventHandler): (WebCore::EventTargetNodeImpl::postDispatchEventHandler): (WebCore::EventTarget): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
  • dom/NodeImpl.cpp: (WebCore::NodeImpl::NodeImpl): (WebCore::NodeImpl::~NodeImpl): (WebCore::NodeImpl::dump): (WebCore::NodeImpl::detach): (WebCore::NodeImpl::insertedIntoDocument): (WebCore::NodeImpl::removedFromDocument):
  • dom/NodeImpl.h: (WebCore::NodeImpl::isEventTargetNode): (WebCore::NodeImpl::isLink): (WebCore::NodeImpl::getDocument): (WebCore::NodeImpl::inDocument):
  • dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEventImpl::receivedTarget):
  • dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::commonAncestorContainer):
  • dom/dom_elementimpl.cpp: (WebCore::inHTMLDocument): (WebCore::ElementImpl::focus): (WebCore::ElementImpl::blur): (WebCore::StyledElementImpl::parseMappedAttribute):
  • dom/dom_position.cpp: (WebCore::Position::documentElement):
  • dom/dom_position.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::computeAndStoreNodeDesiredStyle):
  • editing/SelectionController.cpp: (WebCore::SelectionController::needsCaretRepaint):
  • editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfDocument): (WebCore::endOfDocument):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMEventTargetNode::getOwnPropertySlot): (KJS::DOMEventTargetNode::getValueProperty): (KJS::DOMEventTargetNode::put): (KJS::DOMEventTargetNode::putValueProperty): (KJS::DOMEventTargetNode::setListener): (KJS::DOMEventTargetNode::getListener): (KJS::DOMEventTargetNode::pushEventHandlerScope): (KJS::DOMEventTargetNodeProtoFunc::callAsFunction): (KJS::): (KJS::DOMDocument::DOMDocument): (KJS::DOMDocument::getOwnPropertySlot): (KJS::DOMDocument::put): (KJS::DOMDocument::putValueProperty): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::DOMElement): (KJS::DOMElement::getValueProperty): (KJS::DOMElement::put): (KJS::DOMElement::putValueProperty): (KJS::DOMElement::getOwnPropertySlot): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity):
  • khtml/ecma/kjs_dom.h: (KJS::DOMNode::): (KJS::DOMEventTargetNode::): (KJS::DOMElement::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode): (KJS::getNodeEventListener):
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodyGetter): (KJS::HTMLElement::anchorGetter): (KJS::HTMLElement::getValueProperty): (KJS::HTMLElement::bodySetter):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::registerFormElement): (WebCore::HTMLFormElementImpl::removeFormElement):
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::insertedIntoTree):
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::~HTMLInputElementImpl): (WebCore::HTMLInputElementImpl::focus):
  • khtml/html/HTMLOptionElementImpl.cpp: (WebCore::HTMLOptionElementImpl::text):
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl):
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::~HTMLTextAreaElementImpl):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::insertedIntoDocument): (WebCore::HTMLFrameElementImpl::isURLAllowed): (WebCore::HTMLFrameElementImpl::openURL): (WebCore::HTMLFrameElementImpl::frameWidth): (WebCore::HTMLFrameElementImpl::frameHeight):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height): (WebCore::HTMLMapElementImpl::~HTMLMapElementImpl):
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimateTransformElementImpl.cpp: (SVGAnimateTransformElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGAnimationElementImpl.cpp: (SVGAnimationElementImpl::closeRenderer):
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchRecursiveEvent):
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGImageElementImpl.cpp:
  • ksvg2/svg/SVGSetElementImpl.cpp: (SVGSetElementImpl::handleTimerEvent):
  • kwq/KWQAccObject.mm: (-[KWQAccObject mouseButtonListener]): (-[KWQAccObject accessibilityPerformAction:]):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView dispatchHTMLEvent:]):
  • page/Frame.cpp: (WebCore::dispatchKHTMLEditableContentChanged):
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::viewportWheelEvent):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/render_object.cpp: (WebCore::RenderObject::shouldSelect): (WebCore::RenderObject::backslashAsCurrencySymbol):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::sendConsumedMouseUp):
5:24 PM Changeset in webkit [13368] by bdakin
  • 1 edit
    4 moves in trunk/LayoutTests

Reviewed by hyatt

This test should actually be in the failures folder. Moving.

5:05 PM Changeset in webkit [13367] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla/marvin/backgr_layers-opacity-expected.txt

Update the table opacity test case to reflect the now-correct results.

5:01 PM Changeset in webkit [13366] by hyatt
  • 9 edits in trunk/WebCore

Fix for 7837, make opacity work with table rows. Make transparent backgrounds
stack properly in cells (so that the layers behind can show through like they
should).

Reviewed by beth

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer): (WebCore::RenderTableCell::paintBackgroundsBehindCell): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::paint):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::updateLayerPosition): (WebCore::RenderLayer::isTransparent): (WebCore::RenderLayer::transparentAncestor): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/render_object.cpp: (WebCore::RenderObject::requiresLayer):
  • rendering/render_object.h: (WebCore::RenderObject::isTransparent): (WebCore::RenderObject::opacity):
2:03 PM Changeset in webkit [13365] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • kjs/ustring.cpp: (KJS::UString::from): Use "NaN" for all NaN values, regardless of sign.
1:58 PM Changeset in webkit [13364] by mjs
  • 13 edits in trunk/WebCore

Reviewed by Adele.

  • clean up ResourceRequest to be closer to a proper request interface
  • page/ResourceRequest.h: folded URL into ResourceRequest, other cleanup (WebCore::ResourceRequest::ResourceRequest): Add new explicit constructor that takes a KURL. (WebCore::ResourceRequest::url): getter for KURL (WebCore::ResourceRequest::setURL): corresponding setter (WebCore::ResourceRequest::referrer): new getter for referrer, instead of storing it in m_metaData (it was the only remaining real use of it) (WebCore::ResourceRequest::setReferrer): corresponding setter
  • bridge/BrowserExtension.h:
  • removed unused openURLRequest and openURLNotify methods
  • folded KURL parameter into ResourceRequest
  • bridge/mac/BrowserExtensionMac.h: remove KURL args from methods that also take a ResourceRequest
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow): adjust for ResourceRequest changes.
  • bridge/mac/MacFrame.h: remove KURL args from methods that also take a ResourceRequest
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLRequest): adjust for ResourceRequest changes (WebCore::MacFrame::submitForm): ditto (WebCore::MacFrame::urlSelected): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): adjust for ResourceRequest changes
  • bridge/win/BrowserExtensionWin.h:
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): adjust for ResourceRequest changes (KJS::WindowFunc::callAsFunction): ditto
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): adjust for ResourceRequest changes (WebCore::Frame::receivedFirstData): ditto (WebCore::Frame::begin): ditto (WebCore::Frame::completeURL): ditto (WebCore::Frame::changeLocation): ditto (WebCore::Frame::urlSelected): ditto (WebCore::Frame::requestFrame): ditto (WebCore::Frame::submitForm): ditto
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): ditto
12:32 PM Changeset in webkit [13363] by bdakin
  • 5 edits
    2 adds in trunk

Reviewed by Darin, landed by Beth.

12:11 PM Changeset in webkit [13362] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Beth Dakin


  • fixed <rdar://problem/4239051> Sometimes "Copy Link" in Safari results in a URL on the pasteboard with no usable "title"
  • History/WebURLsWithTitles.m: (+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): trim whitespace from titles that are put on pasteboard. This leaves an empty string for the title in cases where there's no displayed text, like an image in an <a> element that happens to have whitespace in the source, e.g. <a href="foo"> <img whatever></a>
12:02 PM Changeset in webkit [13361] by adele
  • 7 edits in trunk/LayoutTests

Updated results for background color change.

  • fast/forms/input-appearance-focus-expected.txt:
  • fast/forms/input-appearance-minWidth-expected.txt:
  • fast/forms/input-appearance-selection-expected.txt:
  • fast/forms/input-appearance-visibility-expected.txt:
  • fast/forms/input-appearance-width-expected.txt:
  • fast/forms/input-baseline-expected.txt:
11:42 AM Changeset in webkit [13360] by bdakin
  • 1 edit
    62 adds in trunk/LayoutTests

Reviewed by Geoff

A few more mozilla table tests.

11:20 AM Changeset in webkit [13359] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Tim Hatcher.

  • fast/forms/input-appearance-default-bkcolor-expected.checksum: Added.
  • fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • fast/forms/input-appearance-default-bkcolor-expected.txt: Added.
  • fast/forms/input-appearance-default-bkcolor.html: Added.

WebCore:

Reviewed by Tim H.

Make default backgrounds for new text fields white
instead of transparent. This will move to html4.css
when we flip the switch.

Test added:

  • fast/forms/input-appearance-default-bkcolor.html
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::adjustTextFieldStyle):
11:06 AM Changeset in webkit [13358] by hyatt
  • 2 edits in trunk/WebCore

Make table sections and table captions support opacity.

Reviewed by darin

Covered by some of the new Mozilla table tests.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
10:39 AM Changeset in webkit [13357] by hyatt
  • 2 adds
    4 deletes in trunk/LayoutTests/tables

Fix table test that now passes.

9:47 AM Changeset in webkit [13356] by bdakin
  • 6 edits
    4 adds in trunk

Reviewed by Maciej, landed by Beth.

fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3560
page with use of first-letter crashes reproducibly in
RenderObject::renderArena()

9:42 AM Changeset in webkit [13355] by darin
  • 2 edits in trunk/WebKit
  • missing bit of my check-in yesterday

Maciej moved setWindowFrame for me, but I also had removed
setWindowContentRect.

  • WebCoreSupport/WebFrameBridge.m: Removed unused setWindowContextRect and windowContentRect methods.
6:06 AM Changeset in webkit [13354] by eseidel
  • 2 edits in trunk/WebKitLibraries

2006-03-17 Eric Seidel <​eseidel@apple.com>

  • libWebKitSystemInterface.a: commit a universal binary.
4:36 AM Changeset in webkit [13353] by andersca
  • 2 edits in trunk/WebKitTools

2006-03-17 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.


  • Scripts/install-win-extras: Fetch "Program Files" location from the environment.
3:06 AM Changeset in webkit [13352] by adele
  • 24 edits in trunk

LayoutTests:

Reviewed by Eric.

Updating test results for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7798
New text fields are much wider than they should be for a specified size

  • fast/forms/input-appearance-bkcolor-expected.checksum:
  • fast/forms/input-appearance-bkcolor-expected.png:
  • fast/forms/input-appearance-bkcolor-expected.txt:
  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-focus-expected.png:
  • fast/forms/input-appearance-focus-expected.txt:
  • fast/forms/input-appearance-minWidth-expected.checksum:
  • fast/forms/input-appearance-minWidth-expected.png:
  • fast/forms/input-appearance-minWidth-expected.txt:
  • fast/forms/input-appearance-selection-expected.checksum:
  • fast/forms/input-appearance-selection-expected.png:
  • fast/forms/input-appearance-selection-expected.txt:
  • fast/forms/input-appearance-visibility-expected.checksum:
  • fast/forms/input-appearance-visibility-expected.png:
  • fast/forms/input-appearance-visibility-expected.txt:
  • fast/forms/input-appearance-width-expected.checksum:
  • fast/forms/input-appearance-width-expected.png:
  • fast/forms/input-appearance-width-expected.txt:
  • fast/forms/input-baseline-expected.checksum:
  • fast/forms/input-baseline-expected.png:
  • fast/forms/input-baseline-expected.txt:

WebCore:

Reviewed by Eric.

I changed the character we use to calculate the width from "w" back to "0",
which matches our old behavior. The original change was intentional, to try
to better match other browsers, but "w" is a little too wide. For now, lets
go back to the old behavior.

I also set the minWidth = maxWidth. We were trying to match a WinIE quirk,
but that caused some odd behavior with growth of the text field in table cells.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
3:00 AM Changeset in webkit [13351] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-17 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix Spinneret to pass Events as const & not as pointers.

  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebView::keyPress):
2:47 AM Changeset in webkit [13350] by eseidel
  • 8 edits
    2 adds in trunk/WebCore

2006-03-17 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Fix win32 build.
Add PageWin class.
Add previously forgotten KeyEventWin class.
Pass MouseEvent() instead of 0 in a couple places to make compiler happy.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.h:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::keyPress):
  • bridge/win/FrameWin.h:
  • bridge/win/PageWin.cpp: Added. (WebCore::rootWindowForFrame): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):
  • page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): (WebCore::FrameView::hoverTimerFired):
  • page/Page.h: (WebCore::Page::mainFrame):
  • platform/win/KeyEventWin.cpp: Added. (WebCore::KeyEvent::KeyEvent):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::findNextWordFromIndex): (FrameWin::passMouseDownEventToWidget): (FrameWin::scheduleClose): (BrowserExtensionWin::createNewWindow): (WebCore::findWordBoundary): (FrameWin::registerCommandForUndo): (FrameWin::markMisspellingsInAdjacentWords): (FrameWin::respondToChangedContents):
2:40 AM Changeset in webkit [13349] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-17 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

Add support for basic HTML editing.

  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::keyPress):
2:28 AM Changeset in webkit [13348] by adele
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Added WKDrawBezeledTextFieldCell()
  • libWebKitSystemInterface.a: ditto
2:16 AM Changeset in webkit [13347] by hyatt
  • 2 edits in trunk/WebCore

Fix pixel test regression in fast/table/overflowHidden.html. There was
a borderTopExtra error made in the new boundingBox code for layers that
caused the bottom half of cells with opacity set to be clipped out.

Reviewed by andersca

  • rendering/render_layer.cpp: (WebCore::RenderLayer::absoluteBoundingBox):
1:50 AM Changeset in webkit [13346] by hyatt
  • 25 edits in trunk/WebCore

Give table rows and sections accurate dimensions. Fix absolutePosition
to work for table cells properly. Add an absolutePositionForContent method
to make sure callers that want to deal with the content of a cell handle
the cell's extra space correctly.

Reviewed by darin

Existing layout tests cover this change.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge copyRenderNode:copier:]):
  • dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): (WebCore::ContainerNodeImpl::getLowerRightCorner):
  • dom/NodeImpl.cpp: (WebCore::NodeImpl::getRect):
  • editing/SelectionController.cpp: (WebCore::SelectionController::layout): (WebCore::SelectionController::caretRect):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition):
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::defaultEventHandler):
  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects): (WebCore::RenderBlock::positionForCoordinates):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): (WebCore::RenderContainer::lineBoxRects):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeAbsoluteRepaintRect): (WebCore::RenderTableCell::absolutePosition):
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): (WebCore::RenderTableRow::getAbsoluteRepaintRect): (WebCore::RenderTableRow::nodeAtPoint):
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::recalcCells): (WebCore::RenderTableSection::nodeAtPoint):
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::lineBoxRects): (WebCore::RenderText::positionForCoordinates): (WebCore::RenderText::caretRect): (WebCore::RenderText::posOfChar): (WebCore::RenderText::selectionRect):
  • rendering/render_box.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::caretRect):
  • rendering/render_br.cpp: (WebCore::RenderBR::caretRect):
  • rendering/render_canvas.h:
  • rendering/render_flow.cpp: (WebCore::RenderFlow::caretRect):
  • rendering/render_frames.cpp: (WebCore::RenderPart::updateWidgetPosition):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::updateLayerPosition):
  • rendering/render_object.cpp: (WebCore::RenderObject::absoluteRects): (WebCore::RenderObject::absoluteBoundingBoxRect): (WebCore::RenderObject::absolutePosition):
  • rendering/render_object.h: (WebCore::RenderObject::absolutePositionForContent): (WebCore::RenderObject::offsetHeight):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::updateWidgetPosition):
1:13 AM Changeset in webkit [13345] by eseidel
  • 5 edits
    6 copies
    1 add in trunk/WebKitTools

2006-03-17 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by ggaren.

Break DumpRenderTree.m up into several files to make the code more readable.

  • DumpRenderTree/DumpRenderTree.h: Added.
  • DumpRenderTree/DumpRenderTree.m: (doneLoading): new accessor function for "done" global.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTreeDraggingInfo.h: Added.
  • DumpRenderTree/DumpRenderTreeDraggingInfo.m: Added.
  • DumpRenderTree/EditingDelegate.h: Added.
  • DumpRenderTree/EditingDelegate.m: Added. (-[EditingDelegate webViewDidChangeSelection:]):
  • DumpRenderTree/EventSendingController.h: Added.
  • DumpRenderTree/EventSendingController.m: Added.
1:10 AM Changeset in webkit [13344] by adele
  • 10 edits
    6 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

  • fast/forms/input-appearance-bkcolor-expected.checksum: Added.
  • fast/forms/input-appearance-bkcolor-expected.png: Added.
  • fast/forms/input-appearance-bkcolor-expected.txt: Added.
  • fast/forms/input-appearance-bkcolor.html: Added.
  • fast/forms/resources
  • fast/forms/resources/apple.gif

WebCore:

Reviewed by Hyatt.

WebCore part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

Bezeled NSTextFieldCells always draw a background, so instead we'll use a new
WebKitSystemInterface function to just draw the border of the cell.

Since the theme is drawing the border and the engine is drawing the background
(which is different from the other form controls), we have to make sure we let the
theme paint the border after the engine paints the background.

  • platform/mac/WebCoreGraphicsBridge.h:
  • platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawBezeledTextFieldCell:enabled:]):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBoxDecorations):
  • rendering/render_theme.cpp: (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorder): (WebCore::RenderTheme::shouldPaintBorder):
  • rendering/render_theme.h:
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::setTextFieldCellState):

WebKit:

Reviewed by Hyatt.

WebKit part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7797
Can't set background color on new text fields

Added function to draw bezeled text field without drawing background.

  • WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawBezeledTextFieldCell:enabled:]): Added.
Note: See TracTimeline for information about the timeline view.