⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 19, 2006:

11:30 PM Changeset in webkit [13396] by eseidel
  • 18 edits in trunk/WebCore

2006-03-17 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Move Form code from MacFrame to Frame.
Move GraphicsContext code from GraphicsContextMac to GraphicsContext.
Use IntRect, FloatRect in more places throughout the code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7824

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): (WebCore::MacFrame::searchForLabelsAboveCell): (WebCore::MacFrame::searchForLabelsBeforeElement): (WebCore::dictionaryFromHashMap): (WebCore::MacFrame::submitForm): (WebCore::MacFrame::setView): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::currentEventIsKeyboardOptionTab): (WebCore::MacFrame::handleKeyboardOptionTabInView): (WebCore::MacFrame::tabsToAllControls): (WebCore::MacFrame::shouldDragAutoNode): (WebCore::MacFrame::selectionImage): (WebCore::MacFrame::snapshotDragImage):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::clearRecordedFormValues): (WebCore::Frame::recordFormValue): (WebCore::Frame::didNotOpenURL): (WebCore::scanForForm): (WebCore::Frame::paint): (WebCore::Frame::prepareForUserAction):
  • page/Frame.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContextPrivate::GraphicsContextPrivate): (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate): (WebCore::GraphicsContext::save): (WebCore::GraphicsContext::restore): (WebCore::GraphicsContext::font): (WebCore::GraphicsContext::setFont): (WebCore::GraphicsContext::pen): (WebCore::GraphicsContext::setPen): (WebCore::GraphicsContext::setBrush): (WebCore::GraphicsContext::brush): (WebCore::GraphicsContext::setUsesInactiveTextBackgroundColor): (WebCore::GraphicsContext::usesInactiveTextBackgroundColor): (WebCore::GraphicsContext::updatingControlTints): (WebCore::GraphicsContext::setUpdatingControlTints): (WebCore::GraphicsContext::setPaintingDisabled): (WebCore::GraphicsContext::paintingDisabled): (WebCore::GraphicsContext::printing): (WebCore::GraphicsContext::drawImageAtPoint): (WebCore::GraphicsContext::drawImageInRect): (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::initFocusRing): (WebCore::GraphicsContext::clearFocusRing): (WebCore::GraphicsContext::addFocusRingRect): (WebCore::GraphicsContext::focusRingWidth): (WebCore::GraphicsContext::focusRingOffset): (WebCore::GraphicsContext::focusRingRects):
  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::fillRectSourceOver): (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::setColorFromBrush): (WebCore::GraphicsContext::setColorFromPen): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawFloatImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawScaledAndTiledImage): (WebCore::GraphicsContext::selectedTextBackgroundColor): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::addClip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::drawFocusRing):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage):
11:25 PM Changeset in webkit [13395] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • html/CanvasGradient.cpp: (WebCore::CanvasGradient::platformShading): Don't make the CG shading object keep a reference to the DOM gradient object. I got confused because in the case of a CanvasPattern, the pattern does need to keep a reference to the DOM pattern object, but the object lifetime is handled differently here. The CG shading object is used right away, not set in a graphics context.
11:20 PM Changeset in webkit [13394] by darin
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Eric.

  • attempt to fix the buildbot by handling DOMImplementation another way
  • WebCore.xcodeproj/project.pbxproj: Added DOMImplementationFront.h/cpp.
  • bindings/objc/DOMImplementationFront.cpp: Added.
  • bindings/objc/DOMImplementationFront.h: Added.
  • bindings/objc/DOMInternal.h: Use DOMImplementationFront, not DOMImplementation.
  • bindings/objc/DOM.mm: (-[DOMImplementation dealloc]): Ditto. (-[DOMImplementation finalize]): Ditto. (-[DOMImplementation _initWithDOMImplementation:]): Ditto. (+[DOMImplementation _DOMImplementationWith:]): Ditto. (-[DOMImplementation _DOMImplementation]): Ditto. (-[DOMDocument implementation]): Call implementationFront from the DOMImplementationFront header instead of using the real implementation function on the Document.
6:57 PM Changeset in webkit [13393] by darin
  • 453 edits
    446 moves in trunk/WebCore
  • global rename, done by script
  • <lots of files>: Renamed XXXImpl to XXX, and a number of other renames. See WebKitTools/Scripts/do-webcore-rename version 13392 for details.
5:01 PM Changeset in webkit [13392] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of refinement. Ready to go now, but looks like I'm going to have to wait and do this next week.

10:55 AM Changeset in webkit [13391] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Anders.

  • DumpRenderTree/DumpRenderTree.m: (main): Turn on pop-up blocking so that we can test it in layout tests. We don't really need tests that run with pop-up blocking off at the moment. If we do some day, we can add some API for turning it off in the layout test controller.
  • Scripts/run-webkit-tests: Since we don't use NSLanguage at all any more, don't ignore the leak; it should no longer show up.
10:40 AM Changeset in webkit [13390] by darin
  • 11 edits
    8 adds in trunk

LayoutTests:

  • fast/js/exception-linenums-in-html-3-expected.txt:
  • fast/js/exception-linenums-in-html-3-expected.png: Added.
  • fast/js/exception-linenums-in-html-3-expected.checksum: Added.
  • fast/js/missing-style-end-tag-js-expected.txt:
  • fast/js/missing-style-end-tag-js-expected.png: Added.
  • fast/js/missing-style-end-tag-js-expected.checksum: Added.
  • fast/tokenizer/missing-style-end-tag-1-expected.checksum:
  • fast/tokenizer/missing-style-end-tag-1-expected.png:
  • fast/tokenizer/missing-style-end-tag-1-expected.txt:
  • fast/tokenizer/missing-style-end-tag-2-expected.checksum:
  • fast/tokenizer/missing-style-end-tag-2-expected.png:
  • fast/tokenizer/missing-style-end-tag-2-expected.txt:
  • added some missing pixel-test results
  • tables/mozilla/marvin/backgr_layers-opacity-expected.checksum: Added.
  • tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
  • fast/dom/Element/class-attribute-whitespace-expected.png: Added.
  • fast/canvas/patternfill-repeat-expected.png: Added.

WebCore:

This fix was breaking major sites -- details in the bug report.

  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Removed the bug fix, added a FIXME about the <title> code that has the same problem.
10:13 AM Changeset in webkit [13389] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round, believe it or not. About ready to go.

8:56 AM Changeset in webkit [13388] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Another round of tweaks after another dry run.

Mar 18, 2006:

10:51 PM Changeset in webkit [13387] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

One more time.

10:48 PM Changeset in webkit [13386] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more fixes for things found during dry runs.

10:31 PM Changeset in webkit [13385] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Did another dry run of the renaming and had to fix a couple of things.

10:05 PM Changeset in webkit [13384] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/canvas/patternfill-repeat-expected.checksum: Added.
  • fast/canvas/patternfill-repeat-expected.png: Added.
  • fast/canvas/patternfill-repeat-expected.txt: Added.
  • fast/canvas/patternfill-repeat.html: Added.

WebCore:

Test: fast/canvas/patternfill-repeat.html

Reviewed by Darin.

  • CanvasPattern.cpp (CanvasPattern::createPattern) Change stepping so that repeat-x, repeat-y, and no-repeat repeat outside the view area by using large values for repeat interval.
10:00 PM Changeset in webkit [13383] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/Element/class-attribute-whitespace-expected.checksum: Added.
  • fast/dom/Element/class-attribute-whitespace-expected.png: Added.
  • fast/dom/Element/class-attribute-whitespace-expected.txt: Added.
  • fast/dom/Element/class-attribute-whitespace.html: Added. NOTE: This test will get broken if "eol-style" processing is done on it.

WebCore:

Test: fast/dom/Element/class-attribute-whitespace.html

Reviewed by Darin.

  • dom/dom_elementimpl.cpp: (WebCore::isClassWhitespace): Helper function to check if a character in the class attribute should be treated as whitespace. Added \r and \t. (WebCore::NamedMappedAttrMapImpl::parseClassAttribute): Instead of creating a QStringList and iterating it, do everything in one pass over the string.
9:49 PM Changeset in webkit [13382] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/block/float/vertical-move-relayout-expected.checksum: Added.
  • fast/block/float/vertical-move-relayout-expected.png: Added.
  • fast/block/float/vertical-move-relayout-expected.txt: Added.
  • fast/block/float/vertical-move-relayout.html: Added.

WebCore:

Test: fast/block/float/vertical-move-relayout.html

Reviewed by Hyatt.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): Call markAllDescendantsWithFloatsForLayout when the child's vertical position changes.
9:47 PM Changeset in webkit [13381] by darin
  • 4 edits
    12 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/js/exception-linenums-in-html-3-expected.txt: Added.
  • fast/js/exception-linenums-in-html-3.html: Added.

Identical to fast/js/exception-linenums-in-html-1.html except that it contains
an unclosed <style> tag, which causes the code path for Bug 6314 to be tested.

  • fast/js/missing-style-end-tag-js-expected.txt: Added.
  • fast/js/missing-style-end-tag-js.html: Added.

While developing a fix for Bug 6314, a state variable (scriptCodeSize) was not
reset in the tokenizer causing the next <script></script> tags to contain the
entire contents of the document after the open <title> tag. This test case
tests for that condition.

  • fast/tokenizer/missing-style-end-tag-1-expected.checksum: Added.
  • fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
  • fast/tokenizer/missing-style-end-tag-1-expected.txt: Added.
  • fast/tokenizer/missing-style-end-tag-1.html: Added.
  • fast/tokenizer/missing-style-end-tag-2-expected.checksum: Added.
  • fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
  • fast/tokenizer/missing-style-end-tag-2-expected.txt: Added.
  • fast/tokenizer/missing-style-end-tag-2.html: Added.

The first test case contains an unclosed <style> tag in <head>, while the
second test case contains an unclosed <style> tag in <body>. These two test
cases result in different code paths being taken.

WebCore:

Reviewed by Darin.

Test: fast/js/exception-linenums-in-html-3.html
Test: fast/js/missing-style-end-tag-js.html
Test: fast/tokenizer/missing-style-end-tag-1.html
Test: fast/tokenizer/missing-style-end-tag-2.html

  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Add check for missing </style> tag and handle this condition if identified.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): If parseSpecial() consumes the rest of the document looking for a </style> tag, reset the state of the tokenizer and retokenize with no special handling for <style>. The parser will handle the missing </style> tag in HTMLParser::handleError().
9:36 PM Changeset in webkit [13380] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5351:
SVG: Safari ignores <title> elements

Make SVGTitleElementImpl act the same as HTMLTitleElementImpl,
in the process setting the title on the right triggers.

  • ksvg2/svg/SVGTitleElementImpl.cpp: (SVGTitleElementImpl::SVGTitleElementImpl): (SVGTitleElementImpl::title): (SVGTitleElementImpl::closeRenderer): (SVGTitleElementImpl::insertedIntoDocument): (SVGTitleElementImpl::removedFromDocument): (SVGTitleElementImpl::childrenChanged):
  • ksvg2/svg/SVGTitleElementImpl.h:
9:28 PM Changeset in webkit [13379] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/replaced/img-1x1-expected.checksum: Added.
  • fast/replaced/img-1x1-expected.txt: Added.
  • fast/replaced/img-1x1.html: Added.
  • fast/replaced/img-1x1-expected.png: Added.
9:25 PM Changeset in webkit [13378] by darin
  • 17 edits in trunk/LayoutTests
  • updated test results for tests affected by Hyatt's latest table fix
  • tables/mozilla/bugs/bug44505-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug106966-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug106966-expected.png:
  • tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
8:49 PM Changeset in webkit [13377] by darin
  • 2 edits in trunk/WebCore
  • another try at fixing Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added EventTargetNodeImpl.h and .cpp.
8:34 PM Changeset in webkit [13376] by darin
  • 2 edits in trunk/WebCore
  • another try at fixing Windows build
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress): Added EventTargetNodeCast.
8:21 PM Changeset in webkit [13375] by darin
  • 4 edits in trunk/WebCore
  • try to fix Windows build
  • bridge/win/FrameWin.h: Remove KURL parameter.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::canRunModal): Ditto.
8:19 PM Changeset in webkit [13374] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • fix leaks caused by the fix for Bugzilla bug 3560
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Text renderers with first-letter pseudo style are children of an existing first-letter inline that has been updated, and should be destroyed.
8:12 PM Changeset in webkit [13373] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

A couple more renaming refinements.

1:39 AM Changeset in webkit [13372] by hyatt
  • 8 edits in trunk/WebCore

Fix for bug 7841, tables, table rows, and table row groups should
all support overflow:hidden.

Reviewed by eric

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): (WebCore::RenderTable::paint): (WebCore::RenderTable::getOverflowClipRect):
  • rendering/RenderTable.h:
  • rendering/RenderTableCol.h: (WebCore::RenderTableCol::requiresLayer):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
  • rendering/render_box.cpp: (WebCore::RenderBox::setStyle):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer):
Note: See TracTimeline for information about the timeline view.