Timeline

Mar 22, 2006:

10:30 PM Changeset in webkit [13451] by mjs

• 2 edits in trunk/WebCore

Reviewed by Eric.

• generate-derived-sources: Suppress warning.

10:13 PM Changeset in webkit [13450] by mjs

• 2 edits in trunk/WebCore

• generate-derived-sources: Added.

10:03 PM Changeset in webkit [13449] by mjs

• 9 edits
  1 add
  4 deletes in trunk/WebCore

Reviewed by Eric.

Handle dependencies for derived sources properly.

• Made a new generate-derived-sources script that does all the depedency checking and source generation.
• Put this script in a subtarget instead of a phase.
• Made derived sources go in the build root, not a source root.
• Added derived sources to the project.
• Removed files whose sole purpose was to include and compile derived sources, just compile those directly for now.
• Tweaked the IDL code generator so it can handle one IDL at a time, to make it easier to get the dependencies right.

• generate-derived-sources: Added.
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDOMCore.cpp: Removed.
• bindings/js/JSDOMEvents.cpp: Removed.
• bindings/js/JSDOMHTML.cpp: Removed.
• bindings/scripts/CodeGenerator.pm:
• bindings/scripts/CodeGeneratorJS.pm:
• bindings/scripts/generate-bindings.pl:
• css/UserAgentStyleSheets.cpp: Removed.
• dom/Range.cpp: (WebCore::Range::~Range):
• dom/Range.h:
• khtml/ecma/kjs_css.cpp: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMCSSRuleList::DOMCSSRuleList): (KJS::DOMCSSRule::DOMCSSRule):
• khtml/ecma/kjs_css.h:

9:46 PM Changeset in webkit [13448] by mjs

• 2 edits in trunk/JavaScriptCore

Reviewed and landed by Maciej.

• WebKit no longer builds with bison 2.1 ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7923

• generate-derived-sources: Handle generated header named either grammar.cpp.h or grammar.hpp.

5:37 PM Changeset in webkit [13447] by justing

• 4 edits
  5 adds
  1 delete in trunk

LayoutTests:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

Added:

• editing/pasteboard/display-block-on-spans-expected.txt: Added.
• editing/pasteboard/display-block-on-spans-expected.png: Added.
• editing/pasteboard/display-block-on-spans-expected.checksum: Added.
• editing/pasteboard/display-block-on-spans.html: Added.

I'm disabling this layout test because of 7899:

• editing/pasteboard/paste-empty-startcontainer.html

WebCore:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7904>
Avoid a layout after test insertion and remove isProbablyBlock

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::computeAndStoreNodeStyles): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
• editing/ReplaceSelectionCommand.h: (WebCore::ReplacementFragment::root):

5:31 PM Changeset in webkit [13446] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Kevin Decker.

Even better fix for <rdar://problem/4432562>. We need to notify the frame delegate of a finished redirect for both
"fast" and "slow" redirects, after committing the load. My previous change only notified for "fast", history-locking
redirects. Now we notify the frame delegate after committing any kind of provisional load, not just in the case of
a fast redirect.

• WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]):

5:21 PM Changeset in webkit [13445] by eseidel

• 3 edits
  2 adds in trunk

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix attribute mutation events to not fire for "style" attributes.
We lazily update style attributes, so sending mutation events for them makes no sense anymore.
<rdar://problem/4474910> repro assertion failure @ apple.com/store: !eventDispatchForbidden()

Test: fast/events/delayed-style-mutation-event-crash.html

• dom/dom_elementimpl.cpp: (WebCore::Element::dispatchAttrRemovalEvent): add assert (WebCore::Element::dispatchAttrAdditionEvent): add assert (WebCore::NamedAttrMap::addAttribute):

3:37 PM Changeset in webkit [13444] by eseidel

• 18 edits in trunk/WebCore

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove more DeprecatedString usage.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7882

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): (WebCore::FrameMac::fontForSelection): (WebCore::FrameMac::tokenizerProcessedData): (WebCore::FrameMac::registerCommandForUndoOrRedo): (WebCore::FrameMac::markMisspellings): (WebCore::FrameMac::respondToChangedSelection): (WebCore::FrameMac::dashboardRegionsDictionary): (WebCore::FrameMac::dragSourceMovedTo):
• css/CSSGrammar.y:
• css/css_valueimpl.h:
• css/cssparser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseShorthand): (WebCore::CSSParser::parseContent): (WebCore::skipCommaInDashboardRegion): (WebCore::CSSParser::parseDashboardRegions): (WebCore::CSSParser::parseShape): (WebCore::CSSParser::parseFont): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseColorFromValue): (WebCore::yyerror): (WebCore::CSSParser::lex): (WebCore::CSSParser::text):
• css/cssparser.h: (WebCore::deprecatedString):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
• khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty):
• ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
• ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::parseMappedAttribute):
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::newLine):
• rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::absolutePosition): (WebCore::RenderCanvas::paint):
• rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock):
• rendering/RenderObject.h:
• rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderLine): (WebCore::RenderBlock::layoutInlineChildren):
• rendering/render_form.cpp: (WebCore::RenderFieldset::paintBoxDecorations):
• rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
• rendering/table_layout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::insertSpanCell): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages):

3:33 PM Changeset in webkit [13443] by bdakin

• 1 edit
  4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout text for <rdar://problem/4471984> repro crash CSS position
for html/table=relative causes crash when hiding table

2:42 PM Changeset in webkit [13442] by mjs

• 2 edits in trunk/JavaScriptCore

• fix the build

• JavaScriptCore.xcodeproj/project.pbxproj:

2:30 PM Changeset in webkit [13441] by tomernic

• 5 edits
  4 adds in trunk

WebCore:

Reviewed by Kevin Decker.

Part of <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)
This also fixes <rdar://problem/4477821> REGRESSION (10.4.5-TOT): meta tag specifying refresh is being added to history.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: Removed redirectionTimerFired(). This was added as attempt to fix <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7058>. The aim was to cause Safari and WebKit to update their loading status after a redirect. Unfortunately, the fix had a bad side effect. Calling -reportClientRedirectCancelled: on a successful redirect causes WebKit to forget that the redirect was supposed to lock history (i.e. reuse the current back/forward entry for the new page). The end result was that intermediate "quick" redirects were creating back/forward entries when they should not have been. See 4351664. That fix was almost correct, in that we do need to notify the frame load delegate when a redirect ends, either because it succeeded or because it was cancelled. However, this is the wrong place to do it. WebCore's redirect notification logic did not need to change to fix 7058. The never-ending spinning indicators problem was actually caused by a bug at the WebKit level.

• manual-tests/redirectHistory: Added.
• manual-tests/redirectHistory/redir-1.html: Added.
• manual-tests/redirectHistory/redir-2.html: Added.
• manual-tests/redirectHistory/redir-3.html: Added. Manual test case. I couldn't figure out how to create a layout test for this, because it involves navigation through history and it was unclear how/when to tell DumpRenderTree to dump its output.

WebKit:

Reviewed by Kevin Decker.

Better fix for <rdar://problem/4432562> REGRESSION (TOT): Safari's "stop loading" active, "view source" inactive after page load [7058]

• WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): Cancel the client redirect when we commit the provisional load, if we were waiting for a redirect. This is a better fix for 7058 (<rdar://problem/4432562>). The original fix for 7058 changed the timing of the redirect cancel in such a way that WebKit was precluded from ever reusing back/forward list entries for redirects. Clearing the redirect state here actually makes logical sense, as the redirect's target page is being committed at this point.

2:27 PM Changeset in webkit [13440] by eseidel

• 57 edits in trunk/WebCore

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Replace more DeprecatedString with String.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7907

• WebCore+SVG/kdom.h:
• bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
• bridge/BrowserExtension.h:
• bridge/mac/BrowserExtensionMac.h:
• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::setTypedIconURL):
• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::searchForLabelsBeforeElement): (WebCore::nsArray): (WebCore::FrameMac::createPlugin): (WebCore::FrameMac::bindingRootObject): (WebCore::FrameMac::windowScriptObject): (WebCore::FrameMac::windowScriptNPObject): (WebCore::FrameMac::partClearedInBegin): (WebCore::FrameMac::openURLFromPageCache):
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): (-[WebCoreFrameBridge scrollToAnchor:]): (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge highlightAllMatchesForString:caseSensitive:]):
• bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
• bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]): (-[WebCoreSettings setStandardFontFamily:]): (-[WebCoreSettings setMinimumFontSize:]): (-[WebCoreSettings setMinimumLogicalFontSize:]): (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings setDefaultFixedFontSize:]): (-[WebCoreSettings setUserStyleSheetLocation:]):
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/CSSGrammar.y:
• css/css_stylesheetimpl.cpp: (WebCore::MediaList::setMediaText):
• css/css_valueimpl.cpp: (WebCore::quoteStringIfNeeded):
• css/cssparser.cpp: (WebCore::CSSParser::parseColor):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector):
• css/cssstyleselector.h:
• dom/Document.cpp: (WebCore::Document::resetActiveLinkColor): (WebCore::Document::nextState): (WebCore::Document::setUserStyleSheet): (WebCore::Document::processHttpEquiv): (WebCore::Document::recalcStyleSelector):
• dom/Document.h: (WebCore::Document::userStyleSheet): (WebCore::Document::setPrintStyleSheet): (WebCore::Document::printStyleSheet):
• editing/markup.cpp: (WebCore::createMarkup): (WebCore::createFragmentFromMarkup): (WebCore::createFragmentFromText):
• editing/markup.h:
• html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setGlobalCompositeOperation):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler):
• html/html_baseimpl.cpp: (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach):
• html/html_headimpl.cpp: (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet):
• html/html_headimpl.h:
• html/html_imageimpl.cpp: (WebCore::HTMLImageElement::parseMappedAttribute):
• html/html_imageimpl.h: (WebCore::HTMLImageElement::compositeOperator):
• html/html_objectimpl.cpp: (WebCore::HTMLAppletElement::createRenderer):
• ksvg2/svg/SVGStringList.cpp: (SVGStringList::reset):
• kwq/AccessibilityObjectCache.h:
• kwq/AccessibilityObjectCache.mm: (AccessibilityObjectCache::textMarkerForVisiblePosition): (AccessibilityObjectCache::postNotificationToTopWebArea): (AccessibilityObjectCache::postNotification):
• kwq/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
• kwq/KWQKHTMLSettings.h: (KHTMLSettings::userStyleSheetLocation): (KHTMLSettings::setUserStyleSheetLocation):
• kwq/KWQLineEdit.h:
• kwq/KWQLineEdit.mm: (QLineEdit::selectedText):
• loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::ref):
• page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): (WebCore::Frame::jScriptEnabled): (WebCore::Frame::javaEnabled): (WebCore::Frame::pluginsEnabled): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheet): (WebCore::Frame::requestObject): (WebCore::Frame::loadPlugin): (WebCore::Frame::referrer): (WebCore::Frame::lastModified): (WebCore::Frame::reparseConfiguration): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing):
• page/Frame.h:
• page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
• platform/AtomicString.h: (WebCore::AtomicString::AtomicString):
• platform/DeprecatedString.cpp: (DeprecatedString::replace):
• platform/GraphicsContext.h:
• platform/Image.h:
• platform/KURL.cpp:
• platform/KURL.h:
• platform/PlatformString.h: (WebCore::String::String): (WebCore::String::replace):
• platform/String.cpp: (WebCore::operator+):
• platform/StringImpl.cpp: (WebCore::StringImpl::remove): (WebCore::parseLength): (WebCore::StringImpl::replace):
• platform/StringImpl.h:
• platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::setCompositeOperation):
• rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::paint):
• rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement):
• rendering/render_frames.cpp: (WebCore::isURLAllowed): (WebCore::mapClassIdToServiceType): (WebCore::RenderPartObject::updateWidget):
• rendering/render_style.h: (WebCore::RenderStyle::setDashboardRegion):
• xml/xmlhttprequest.cpp: (WebCore::getCharset): (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::overrideMIMEType):

2:21 PM Changeset in webkit [13439] by bdakin

• 3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4471984> repro crash CSS position for html/
table=relative causes crash when hiding table

2:10 PM Changeset in webkit [13438] by mjs

• 2 edits in trunk/JavaScriptCore

• kjs/generate-derived-sources: Set executable property.

2:10 PM Changeset in webkit [13437] by hyatt

• 5 edits in trunk/WebCore

Fix for residual style problem where form elements lose their connection
to a degenerate table form because of a residual style fixup. This is
Radar bug #4330765.

Reviewed by eric

• khtml/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
• khtml/html/HTMLFormElement.h: (WebCore::HTMLFormElement::setPreserveFormConnectionAcrossRemove): (WebCore::HTMLFormElement::preserveFormConnectionAcrossRemove):
• khtml/html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removedFromTree):
• khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):

2:09 PM Changeset in webkit [13436] by adele

• 2 edits
  4 adds in trunk/WebCore

Reviewed by Adele.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7747 REGRESSION: Background tab/window auto-refresh in GMail will take focus.

• manual-tests/named-window-blank-target.html: Added.
• manual-tests/resources/named-window-blank-target-step2.html: Added.
• manual-tests/resources/named-window-blank-target-step3.html: Added.
• manual-tests/resources/named-window-blank-target-step4.html: Added.
• page/FrameTree.cpp: (WebCore::FrameTree::find): If the given name is empty, just return our frame, even if it has a name.

1:31 PM Changeset in webkit [13435] by mjs

• 2 edits
  1 add in trunk/JavaScriptCore

Reviewed by Darin.

Ensure that generated source dependencies are handled properly, as follows:

• Made an external script that generates the sources into a DerivedSources dir in the build products directory.
• Added a new build target that builds all the generated sources if needed. Sadly it has to be a target, not a phase for Xcode to notice changes.
• Added the DerivedSources dir in question to the include path.
• Added the new DerivedSources dir and its contents to the project as build-relative.

• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/generate-derived-sources: Added. Based on the windows version - maybe someday they can share more.

12:18 PM Changeset in webkit [13434] by darin

• 1 edit in trunk/WebCore/ChangeLog

Added Bugzilla bug number.

12:16 PM Changeset in webkit [13433] by darin

• 3 edits
  2 adds in trunk

LayoutTests:

Reviewed by Adele.

• test for <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

• fast/dom/Element/onclick-case-expected.txt: Added.
• fast/dom/Element/onclick-case.html: Added.

WebCore:

Reviewed by Adele.

• fix <rdar://problem/4483856> REGRESSION (417.8-TOT): onclick handler cannot call a function named OnClick (7143)

Test: fast/dom/Element/onclick-case.html

We discussed this with Maciej. In the long run we may need to remove the "all attributes
show up as properties in JavaScript" feature entirely. Gecko does not do it, and it's
not really the same thing IE does either.

• khtml/ecma/kjs_dom.cpp: (KJS::DOMElement::attributeGetter): Use getAttributeNS so we're case sensitive. (KJS::DOMElement::getOwnPropertySlot): Ditto.

12:02 PM Changeset in webkit [13432] by eseidel

• 2 edits in trunk/WebCore

2006-03-22 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

<rdar://problem/4486417> REGRESSION: Mail linked against TOT WebKit crashes when composing a message

No test possible.

• bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings init]): call AtomicString::init()

Mar 21, 2006:

8:59 PM Changeset in webkit [13431] by darin

• 2 edits in trunk/WebKit

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=3784 <rdar://problem/4483827> JavaScript save dialog disappears right away (sheet triggers blur event) (3784)

• WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState]): Treat window as having focus if its sheet is key. (-[WebHTMLView addWindowObservers]): Observe all focus notifications, not just the ones involving this window. (-[WebHTMLView removeWindowObservers]): Ditto. (-[WebHTMLView windowDidBecomeKey:]): Add checks so that we call the methods only when appropriate, since this will now be called for all windows. (-[WebHTMLView windowDidResignKey:]): Ditto.

8:44 PM Changeset in webkit [13430] by darin

• 4 edits in trunk/WebCore

• fix buildbot (and everyone else)

• bindings/js/JSDOMCore.cpp: Touch, because Adele's change adds a virtual function, and Xcode doesn't know this needs recompiling.
• bindings/js/JSDOMEvents.cpp: Ditto.
• bindings/js/JSDOMHTML.cpp: Ditto.

8:38 PM Changeset in webkit [13429] by darin

• 7 edits in trunk/WebCore

Reviewed by Eric and Darin.

• get Windows building again

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::userAgent):
• bridge/win/FrameWin.h:
• platform/GraphicsContext.h:
• platform/cairo/ImageCairo.cpp: (WebCore::Image::supportsType):
• platform/win/TemporaryLinkStubs.cpp: (FrameWin::mimeTypeForFileName): (FrameWin::objectContentType): (FrameWin::createPlugin): (FrameWin::overrideMediaType): (FrameWin::passSubframeEventToSubframe): (FrameWin::createFrame): (FrameWin::incomingReferrer):

7:42 PM Changeset in webkit [13428] by darin

• 3 edits in trunk/WebCore

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7884 REGRESSION: Selecting a custom style sheet crashes 20/3 nightly

• page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): This was calling the function that sets the stylesheet URL, passing it the actual stylesheet. (WebCore::Frame::begin): (WebCore::Frame::setUserStyleSheetLocation): Renamed the version of setUserStyleSheet() that takes a URL to this. (WebCore::Frame::reparseConfiguration):
• page/Frame.h:

5:08 PM Changeset in webkit [13427] by adele

• 19 edits
  10 adds in trunk

LayoutTests:

Tests for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6813
elementAtPoint needs to return input element when clicking on new text field
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7799
New text fields don't respect the disabled attribute

• fast/forms/input-appearance-disabled-expected.checksum: Added.
• fast/forms/input-appearance-disabled-expected.png: Added.
• fast/forms/input-appearance-disabled-expected.txt: Added.
• fast/forms/input-appearance-disabled.html: Added.
• fast/forms/input-appearance-elementFromPoint-expected.txt: Added.
• fast/forms/input-appearance-elementFromPoint.html: Added.
• fast/forms/input-appearance-preventDefault-expected.checksum: Added.
• fast/forms/input-appearance-preventDefault-expected.png: Added.
• fast/forms/input-appearance-preventDefault-expected.txt: Added.
• fast/forms/input-appearance-preventDefault.html: Added.

WebCore:

Reviewed by Darin.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6813 elementAtPoint needs to return input element when clicking on new text field ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7799 New text fields don't respect the disabled attribute

• Tests: fast/forms/input-appearance-disabled.html fast/forms/input-appearance-elementFromPoint.html fast/forms/input-appearance-preventDefault.html

• bridge/mac/WebCoreFrameBridge.h: Added allowShadowContent parameter to getInnerNonSharedNode so new elementAtPoint method in WebKit can call this.
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge getInnerNonSharedNode:innerNode:URLElement:atPoint:allowShadowContent:]): Passes allowShadowContent parameter to nodeInfoAtPoint. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Updated to call nodeInfoAtPoint allowing shadow content. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]): Added allowShadowContent parameter.

• dom/Node.h: (WebCore::Node::isShadowNode): Added. (WebCore::Node::shadowParentNode): Added.
• dom/Node.cpp: (WebCore::Node::shadowAncestorNode): Added. If an ancestor is a shadow node, return its shadow parent node.
• html/HTMLTextFieldInnerElement.h: (WebCore::HTMLTextFieldInnerElement::isShadowNode): Added.

• dom/Document.cpp: (WebCore::Document::elementFromPoint): Gets the shadowAncestorNode (so we get the input element, and not the inner div).
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): If text fields are focusable, then they should be keyboard focusable. This works for the old text fields because HTMLGenericFormElement::isKeyboardFocusable does the right thing for RenderWidgets. That's not needed for the new form elements. (WebCore::HTMLInputElement::defaultEventHandler): let the renderer forward drag, mouse, and wheel events.

• page/FrameView.cpp: (WebCore::FrameView::updateDragAndDrop): Send drag events to the shadowAncestorNode. (WebCore::FrameView::dispatchMouseEvent): Send mouse events to the shadowAncestorNode. (WebCore::FrameView::handleWheelEvent): Send wheel events to the shadowAncestorNode.

• rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): forwards events to the inner div element.
• rendering/RenderTextField.h: Added forwardEvent method.

• kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityHitTest:]): Gets the shadowAncestorNode (so we get the input element, and not the inner div). (-[WebCoreAXObject role]): Gets the right role for text fields, since we no longer get that from AppKit. (-[WebCoreAXObject roleDescription]): Gets the right description for text fields.

WebKit:

Reviewed by Darin.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6813 elementAtPoint needs to return input element when clicking on new text field

• WebView/WebDocumentInternal.h: Added elementAtPoint:allowShadowContent:
• WebView/WebHTMLView.m: (-[NSArray elementAtPoint:]): Does not allow shadow content. This way, by default, callers would get the input element instead of the inner div. (-[NSArray elementAtPoint:allowShadowContent:]): Allows callers to specify whether or not the element can be a shadow node. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Allows shadow content when getting element. (-[WebHTMLView _mayStartDragAtEventLocation:]): ditto. (-[NSArray _isSelectionEvent:]): ditto. (-[NSArray _canProcessDragWithDraggingInfo:]): ditto.
• WebView/WebFrame.m: (-[WebFrame _actionInformationForNavigationType:event:originalURL:]): Does not allow shadow content when getting element.
• WebView/WebImageView.m: (-[WebImageView elementAtPoint:allowShadowContent:]): Added to conform to the WebDocumentElement protocol.
• WebView/WebPDFView.m: (-[WebPDFView elementAtPoint:allowShadowContent:]): ditto.
• WebView/WebTextView.m: (-[WebTextView elementAtPoint:allowShadowContent:]): ditto.

3:52 PM Changeset in webkit [13426] by darin

• 14 edits
  5 adds in trunk

LayoutTests:

• test for <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

• fast/html: Added.
• fast/html/listing-expected.checksum: Added.
• fast/html/listing-expected.png: Added.
• fast/html/listing-expected.txt: Added.
• fast/html/listing.html: Added.

WebCore:

Reviewed by Tim O.

• fixed <rdar://problem/4251515> REGRESSION: listing tag broken in TOT

Test: fast/html/listing.html

• html/HTMLNames.h: Add listing tag.

• bindings/objc/DOM.mm: (+[DOMNode _nodeWith:]):
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
• css/html4.css:
• editing/ReplaceSelectionCommand.cpp: (WebCore::isProbablyBlock):
• editing/TextIterator.cpp: (WebCore::TextIterator::handleNonTextNode): (WebCore::TextIterator::exitNode): (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
• editing/markup.cpp: (WebCore::startMarkup): (WebCore::createMarkup):
• html/HTMLElement.cpp: (WebCore::blockTagList):
• html/HTMLElementFactory.cpp: (WebCore::addTag): (WebCore::createFunctionMap): (WebCore::HTMLElementFactory::createHTMLElement):
• html/HTMLParser.cpp: (WebCore::HTMLParser::isAffectedByResidualStyle):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
• khtml/ecma/kjs_html.cpp: (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): Add listing tags everywhere pre tags are listed.

3:41 PM Changeset in webkit [13425] by thatcher

• 12 edits in trunk/WebCore/dom

Touching the idl files to force a build after Maciej's change.

3:36 PM Changeset in webkit [13424] by mjs

• 6 edits in trunk/WebCore

Reviewed by Darin.

• fix horrible build fallout from my attr fix

• bindings/js/JSCanvasRenderingContext2DBase.cpp:
• bindings/js/JSDOMCore.cpp:
• bindings/js/JSDOMEvents.cpp:
• bindings/js/JSDOMHTML.cpp:
• bindings/scripts/CodeGeneratorJS.pm:

2:49 PM Changeset in webkit [13423] by tomernic

• 4 edits
  2 adds in trunk/WebKit

Reviewed by Tim Hatcher and Darin.

<rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment deprecated, used in Netscape
plugin code

• Plugins/WebNetscapeDeprecatedFunctions.h: Added.
• Plugins/WebNetscapeDeprecatedFunctions.c: Added. Added wrappers for deprecated CFM and LowMem functions. These exist in a separate file so that we can set -Wno-deprecated-declarations on this one file without ignoring other deprecated function usage elsewhere. (WebGetDiskFragment): (WebCloseConnection): (WebLMGetCurApRefNum): (WebLMSetCurApRefNum):

• Plugins/WebNetscapePluginPackage.h: Don't include connID ivar in 64-bit, since CFM is not supported in 64-bit.
• Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Don't bother setting the resource refNum in 64-bit, because the API to get and set it does not exist. A theoretical 64-bit plugin couldn't possibly rely this, since there is no API. (-[WebNetscapePluginPackage unloadWithoutShutdown]): No need to close the connID in 64-bit. (-[WebNetscapePluginPackage load]): Don't load CFM bundles in 64-bit, because CFM is not supported.

• WebKit.xcodeproj/project.pbxproj: Added WebNetscapeDeprecatedFunctions.[hm].

11:36 AM Changeset in webkit [13422] by sullivan

• 5 edits in trunk/WebKit

Reviewed by Kevin Decker.

• fixed <rdar://problem/4485637> Implementors of searchFor:direction:caseSensitive:wrap: should bail out early if search string is empty

This doesn't change any existing behavior, but avoids unnecessary work.

• Misc/WebSearchableTextView.m: (-[WebSearchableTextView searchFor:direction:caseSensitive:wrap:]): bail out immediately (returning NO) if search string is empty

• WebView/WebHTMLView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto

• WebView/WebPDFView.m: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): ditto

• WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): ditto

10:12 AM Changeset in webkit [13421] by bdakin

• 2 edits in trunk/LayoutTests

Reducing the amount of time this test waits for the frame to fully
load per Justin's request.

9:36 AM Changeset in webkit [13420] by bdakin

• 6 edits
  5 adds in trunk

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7223
Reproducible crash when tabbing to a frame that has not been loaded
Also adds support for keyDown() to DumpRenderTree.

2:53 AM Changeset in webkit [13419] by eseidel

• 3 edits
  3 adds in trunk

2006-03-20 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix a unsafe static cast causing intermittent crashes.
<rdar://problem/4411663> crash at KXMLCore::RefPtr<WebCore::DOMStringImpl>::get() const + 20 (RefPtr.h:45)

Test: fast/dom/NodeList/item-by-id-with-no-document.html

• dom/NodeList.cpp: (WebCore::NodeList::itemById): fix unsafe static cast.