⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 24, 2006:

7:34 PM Changeset in webkit [13476] by justing
  • 1 edit in trunk/WebCore/ChangeLog
7:28 PM Changeset in webkit [13475] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document


  • editing/pasteboard/7955-expected.checksum: Added.
  • editing/pasteboard/7955-expected.png: Added.
  • editing/pasteboard/7955-expected.txt: Added.
  • editing/pasteboard/7955.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document


There's no safe place in the document to keep the fragment while pasting, so I avoid
isProbablyBlock by saving whether or not something was blockFlow during the test
insertion.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): (WebCore::ReplacementFragment::isBlockFlow): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::isBlockFlow): (WebCore::ReplacementFragment::renderingInfo): (WebCore::ReplacementFragment::nodes):
7:11 PM Changeset in webkit [13474] by eseidel
  • 3 edits in trunk/WebCore

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

  • generate-derived-sources: fix clean builds on mac.
5:47 PM Changeset in webkit [13473] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dave Harrison.

  • fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
  • fast/dom/Range/create-contextual-fragment-expected.png: Added.
  • fast/dom/Range/create-contextual-fragment-expected.txt: Added.
  • fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

Reviewed by Dave Harrison.

Test: fast/dom/Range/create-contextual-fragment.html

  • dom/Range.idl: Add createContextualFragment.
2:42 AM Changeset in webkit [13472] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo

2:41 AM Changeset in webkit [13471] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Build fix.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::openURL): replace QString with DeprecatedString
2:40 AM Changeset in webkit [13470] by eseidel
  • 13 edits in trunk/WebCore

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.
Uninify mac/win dependency handling.
Fix class vs. struct linker problem for win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • bridge/win/BrowserExtensionWin.h:
  • bridge/win/FrameWin.h:
  • generate-derived-sources:
  • kwq/AccessibilityObjectCache.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/mac/GraphicsContextMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectedText): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

Mar 23, 2006:

11:17 PM Changeset in webkit [13469] by darin
  • 2 edits in trunk/WebKitSite

Reviewed by Darin.

  • coding/coding-style.html: Changed &emdash; to &mdash;.
11:15 PM Changeset in webkit [13468] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • bindings/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base class, and the GetFieldID was using the wrong signature.
11:07 PM Changeset in webkit [13467] by darin
  • 10 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4484787> KWQAccObject dangles under GC
  • kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change from CF dictionaries to HashMap and HashSet.
  • kwq/AccessibilityObjectCache.mm: (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects and call CFRelease on all of them. (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting them in the HashMap, rather than assuming that retain == CFRetain. This is what fixes the GC issue. (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing. (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before. (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet. (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes. (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto. (WebCore::AccessibilityObjectCache::childrenChanged): Ditto. (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto. (WebCore::AccessibilityObjectCache::postNotification): Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]): Change to use functions by new names.
  • dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace. getAccObjectCache and ownerElement are const member functions, and m_accCache is a mutable data member.
  • dom/Document.cpp: (WebCore::Document::getAccObjectCache): Make const. (WebCore::Document::ownerElement): Make const.
  • kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject anchorElement]): Update for function name change. (-[WebCoreAXObject firstChild]): Ditto. (-[WebCoreAXObject lastChild]): Ditto. (-[WebCoreAXObject previousSibling]): Ditto. (-[WebCoreAXObject nextSibling]): Ditto. (-[WebCoreAXObject parentObject]): Ditto. (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto. (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto. (AXLinkElementForNode): Ditto. (AXAttributedStringAppendReplaced): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto. (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto. (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto. (-[WebCoreAXObject axObjectID]): Change field name to m_id. (-[WebCoreAXObject setAXObjectID:]): Ditto. (-[WebCoreAXObject removeAXObjectID]): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Remove ifdefs. (WebCore::RenderContainer::appendChildNode): Ditto. (WebCore::RenderContainer::insertChildNode): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.
11:05 PM Changeset in webkit [13466] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix buildbot
10:28 PM Changeset in webkit [13465] by darin
  • 23 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • kjs/object.h: Take function name, as well as source URL and line number, when using the special overloaded construct for making functions.
  • kjs/object.cpp: (KJS::JSObject::construct): Ditto.
  • kjs/function_object.h: Ditto.
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when constructing the function rather than null. Use "anonymous" when making a function using the default function constructor.
  • kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before a function declaration.
  • unrelated fix
  • kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

  • fast/js/resources/function-names.js: Added.
  • fast/js/function-names.html: Generated.
  • fast/js/function-names-expected.txt: Generated.

WebCore:

Reviewed by Maciej.

Test: fast/js/function-names.html

  • dom/Document.h: Add function name parameter to createHTMLEventListener.
  • dom/Document.cpp: (WebCore::Document::createHTMLEventListener): Pass function name when calling createHTMLEventHandler. (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name when calling createHTMLEventListener.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute name as function name when calling createHTMLEventListener.
  • khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name. (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.
  • khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and createSVGEventHandler.
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating a JSLazyEventListener. (WebCore::KJSProxy::createSVGEventHandler): Ditto.
  • ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to JSSVGLazyEventListener.
  • ksvg2/events/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name on to the base class constructor.
  • ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when calling createSVGEventHandler.
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner): Pass attribute name as function name when calling createSVGEventListener.
  • WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.
5:51 PM Changeset in webkit [13464] by tomernic
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Layout test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

  • fast/forms/button-default-title-expected.checksum: Added.
  • fast/forms/button-default-title-expected.png: Added.
  • fast/forms/button-default-title-expected.txt: Added.
  • fast/forms/button-default-title.html: Added.

WebCore:

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueWithDefault): Only use the default button title if no title was specified; previously we'd use the default button title if the specified title was empty, which is not what Firefox does.
5:20 PM Changeset in webkit [13463] by darin
  • 14 edits in trunk/LayoutTests
  • removed merge artifacts from .checksum files
  • fast/block/float/vertical-move-relayout-expected.checksum:
  • fast/css/first-letter-detach-expected.checksum:
  • fast/css/hover-subselector-expected.checksum:
  • fast/dom/Element/class-attribute-whitespace-expected.checksum:
  • fast/events/event-sender-mouse-moved-expected.checksum:
  • fast/forms/form-hides-table-expected.checksum:
  • fast/invalid/missing-address-end-tag-expected.checksum:
  • fast/invalid/missing-dl-end-tag-expected.checksum:
  • fast/invalid/missing-dt-end-tag-expected.checksum:
  • fast/invalid/missing-font-end-tag-expected.checksum:
  • fast/text/in-rendered-text-rtl-expected.checksum:
  • fast/tokenizer/missing-title-end-tag-1-expected.checksum:
  • fast/tokenizer/missing-title-end-tag-2-expected.checksum:
5:08 PM Changeset in webkit [13462] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Beth.

  • test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • fast/css/max-height-none-expected.checksum: Added.
  • fast/css/max-height-none-expected.txt: Added.
  • fast/css/max-height-none.html: Added.
  • fast/css/max-height-none-expected.png: Added.

WebCore:

Reviewed by Beth.

  • fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-height of none, set it to Length(undefinedLength, Fixed), which is the correct value (same as the default). Also did some formatting fixes to the height section.
2:44 PM Changeset in webkit [13461] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed, tweaked, and landed by Beth.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

2:27 PM Changeset in webkit [13460] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
REGRESSION: style change where :hover changes only an :after style
doesn't work

  • dom/Node.cpp: (WebCore::Node::diff): Need to call diff() on the before and after styles if we have them.
2:07 PM Changeset in webkit [13459] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

  • WebView/WebFramePrivate.h: Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is cancelled and when a redirect is successfully committed.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge reportClientRedirectCancelled:]): Call renamed WebFrame method.
  • WebView/WebFrame.m: Added sentRedirectNotification flag to WebFramePrivate. This flag is set when we notify the frame load delegate that a redirect will occur. We check this flag when committing a provisional load to ensure that the frame load delegate is notified that the redirect finished. (-[WebFrame _commitProvisionalLoad:]): After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending redirect. (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Set the new sentRedirectNotification flag. (-[WebFrame _clientRedirectCancelledOrFinished:]): Renamed method. Clear the sentRedirectNotification flag. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Call renamed method.
1:58 PM Changeset in webkit [13458] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added:

  • fast/forms/button-table-styles.txt: Added.
  • fast/forms/button-table-styles.png: Added.
  • fast/forms/button-table-styles.checksum: Added.
  • fast/forms/button-table-styles.html: Added.

WebCore:

Reviewed by Hyatt.

Test:
fast/forms/button-table-styles.html

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): The theme should disallow table display styles form elements.
1:28 PM Changeset in webkit [13457] by tomernic
  • 1 edit in trunk/WebKit/ChangeLog

Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

1:17 PM Changeset in webkit [13456] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu
  • WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.
8:31 AM Changeset in webkit [13455] by darin
  • 12 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT, BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in one case and remove a _NPN_ReleaseObject in another because this should return a retained value. (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN, NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.
  • bindings/c/c_runtime.h: Removed implementations of CMethod::name and CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
  • bindings/c/c_runtime.cpp: (KJS::Bindings::CMethod::name): Added. Returns the string from inside the method object. (KJS::Bindings::CField::name): Added. Returns the string from inside the field object. (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue on the result of getProperty after using it to fix a storage leak. (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue after pasing a value to setProperty now that the conversion function does a retain.
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local stack buffer. Removed special case for NPVARIANT_IS_VOID because the convertNPVariantToValue function handles that properly. (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.
  • bindings/NP_jsobject.h: Formatting changes only.
  • bindings/NP_jsobject.cpp: (jsDeallocate): Changed parameter type so we don't need a function cast. (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT. (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT. (_NPN_Evaluate): Use VOID_TO_NPVARIANT. (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.
  • bindings/c/c_class.cpp: Formatting changes only.
  • bindings/c/c_class.h: Formatting changes only.
  • bindings/npruntime_priv.h: Removed obsolete and now-unused functions: NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined, NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble, NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool, NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString, NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid, NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined, NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32, NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString, NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
  • bindings/npruntime.cpp: (getIntIdentifierDictionary): Don't bother creating custom callbacks for the integer dictionary since the default behavior is fine for integers.
8:08 AM Changeset in webkit [13454] by darin
  • 2 edits in trunk/WebCore
  • generate-derived-sources: Tweaked formatting a tiny bit and removed a stray touch that was left in here.
7:36 AM Changeset in webkit [13453] by darin
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu
  • WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.
12:21 AM Changeset in webkit [13452] by eseidel
  • 3 edits in trunk/WebCore

2006-03-23 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

REGRESSION: Dashed borders paint with the wrong phase
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7879

Test: Already covered by css1/box_properties/border_style.html

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLine):
Note: See TracTimeline for information about the timeline view.