⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 25, 2006:

3:52 PM Changeset in webkit [13482] by eseidel
  • 2 edits in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Build fix.

  • bindings/scripts/CodeGeneratorJS.pm: include Element.h
2:24 PM Changeset in webkit [13481] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

  • DumpRenderTree/DumpRenderTree.m: (main): Added --repaint and --horizontal-sweep options. (dump): Repaint line-by-line or column-by-column when the appropriate option is selected. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint() and repaintSweepHorizontally() methods to layoutTestController. (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (dumpRenderTree):
  • Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options to force these settings on tests that do not ask for them.
2:20 PM Changeset in webkit [13480] by eseidel
  • 111 edits
    15 copies
    2 moves
    3 deletes in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Split dom_elementimpl.* into multiple files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

  • ForwardingHeaders/kdom/core/Attr.h: Removed.
  • ForwardingHeaders/kdom/core/Element.h: Removed.
  • ForwardingHeaders/kdom/core/XMLElement.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/AbstractView.cpp:
  • dom/Attr.cpp: Added.
  • dom/Attr.h: Added.
  • dom/Attribute.cpp: Added.
  • dom/Attribute.h: Added.
  • dom/CSSMappedAttributeDeclaration.cpp: Added.
  • dom/CSSMappedAttributeDeclaration.h: Added.
  • dom/DOMImplementation.cpp:
  • dom/Document.h:
  • dom/DocumentType.cpp:
  • dom/Element.cpp: Added. (WebCore::Element::Element): (WebCore::Element::~Element):
  • dom/Element.h: Added.
  • dom/EventNames.cpp:
  • dom/EventTargetNode.cpp:
  • dom/MappedAttribute.cpp: Added.
  • dom/MappedAttribute.h: Added.
  • dom/MappedAttributeEntry.h: Added. (WebCore::):
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
  • dom/NamedAttrMap.cpp: Added.
  • dom/NamedAttrMap.h: Added.
  • dom/NamedMappedAttrMap.cpp: Added. (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
  • dom/NamedMappedAttrMap.h: Added.
  • dom/Node.cpp:
  • dom/NodeList.cpp:
  • dom/Position.cpp:
  • dom/StyledElement.cpp: Added.
  • dom/StyledElement.h: Added.
  • dom/dom_elementimpl.cpp: Removed.
  • dom/dom_elementimpl.h: Removed.
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/MergeIdenticalElementsCommand.cpp:
  • editing/ModifySelectionListLevelCommand.cpp:
  • editing/MoveSelectionCommand.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:
  • editing/RemoveNodeAttributeCommand.cpp:
  • editing/Selection.cpp:
  • editing/SelectionController.cpp:
  • editing/SetNodeAttributeCommand.cpp:
  • editing/SplitElementCommand.cpp:
  • editing/SplitTextNodeContainingElementCommand.cpp:
  • editing/TextIterator.cpp:
  • editing/TypingCommand.cpp:
  • editing/VisiblePosition.cpp:
  • editing/visible_units.cpp:
  • html/HTMLElement.h:
  • html/HTMLTokenizer.h:
  • html/html_baseimpl.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/xbl/xbl_binding_manager.cpp:
  • khtml/xbl/xbl_tokenizer.cpp:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.cpp:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEFloodElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEMergeNodeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLangSpace.cpp:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGPathElement.cpp:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGPolyElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGScriptElement.cpp:
  • ksvg2/svg/SVGStopElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGSwitchElement.cpp:
  • ksvg2/svg/SVGTests.cpp:
  • ksvg2/svg/SVGTextContentElement.cpp:
  • ksvg2/svg/SVGTextPositioningElement.cpp:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGURIReference.cpp:
  • ksvg2/svg/SVGUseElement.cpp:
  • ksvg2/svg/SVGViewElement.cpp:
  • ksvg2/svg/SVGZoomAndPan.cpp:
  • kwq/WebCoreTextArea.mm:
  • platform/Widget.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderCanvas.cpp:
  • rendering/RenderContainer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTextField.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/bidi.cpp:
  • rendering/render_replaced.cpp:
3:22 AM Changeset in webkit [13479] by eseidel
  • 11 edits in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix RenderStyle creation to avoid floating RenderStyle objects.
This also fixes a bug, were SVG to ever start sharing RenderStyles
between elements, code would have crashed as there were improperly
paired style->deref() statements in SVG code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

No test possible (no functionality change).

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
  • css/cssstyleselector.h:
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::createStyleForRenderer):
  • dom/Node.h:
  • dom/dom_elementimpl.cpp: (WebCore::Element::createStyleForRenderer): (WebCore::Element::recalcStyle):
  • dom/dom_elementimpl.h:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::selectStartNode): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::getPseudoStyle):
2:46 AM Changeset in webkit [13478] by eseidel
  • 3 edits
    2 adds in trunk

2006-03-23 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Shave .2% on PLT by removing bogus strcmp.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

Test: fast/parser/tag-with-exclamation-point.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp
2:17 AM Changeset in webkit [13477] by justing
  • 16 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

  • editing/editing.js:
  • editing/execCommand/createLink-expected.checksum: Removed.
  • editing/execCommand/createLink-expected.png: Removed.
  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/createLink.html:
  • editing/execCommand/unlink-expected.txt: Added.
  • editing/execCommand/unlink.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented


Added code to push partially selected anchor elements down before
creating or removing links to create fully selected chunks that can be removed.
Changed create_link_command_h to CreateLinkCommand_h
Gave styled element application/removal its own ApplyStyleCommand constructor.
Still need to add new EditActions (7974).


  • WebCore.xcodeproj/project.pbxproj:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::enclosingAnchorElement): (WebCore::CompositeEditCommand::pushAnchorElementDown): (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
  • editing/CompositeEditCommand.h:
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
  • editing/CreateLinkCommand.h:
  • editing/JSEditor.cpp:
  • editing/Selection.cpp: (WebCore::Selection::selectionFromContentsOfNode):
  • editing/Selection.h:
  • editing/UnlinkCommand.cpp: Added. (WebCore::UnlinkCommand::UnlinkCommand): (WebCore::UnlinkCommand::doApply):
  • editing/UnlinkCommand.h: Added.
  • page/Frame.cpp: (WebCore::Frame::selectContentsOfNode): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):

Mar 24, 2006:

7:34 PM Changeset in webkit [13476] by justing
  • 1 edit in trunk/WebCore/ChangeLog
7:28 PM Changeset in webkit [13475] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document


  • editing/pasteboard/7955-expected.checksum: Added.
  • editing/pasteboard/7955-expected.png: Added.
  • editing/pasteboard/7955-expected.txt: Added.
  • editing/pasteboard/7955.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document


There's no safe place in the document to keep the fragment while pasting, so I avoid
isProbablyBlock by saving whether or not something was blockFlow during the test
insertion.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): (WebCore::ReplacementFragment::isBlockFlow): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::isBlockFlow): (WebCore::ReplacementFragment::renderingInfo): (WebCore::ReplacementFragment::nodes):
7:11 PM Changeset in webkit [13474] by eseidel
  • 3 edits in trunk/WebCore

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

  • generate-derived-sources: fix clean builds on mac.
5:47 PM Changeset in webkit [13473] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dave Harrison.

  • fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
  • fast/dom/Range/create-contextual-fragment-expected.png: Added.
  • fast/dom/Range/create-contextual-fragment-expected.txt: Added.
  • fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

Reviewed by Dave Harrison.

Test: fast/dom/Range/create-contextual-fragment.html

  • dom/Range.idl: Add createContextualFragment.
2:42 AM Changeset in webkit [13472] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo

2:41 AM Changeset in webkit [13471] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Build fix.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::openURL): replace QString with DeprecatedString
2:40 AM Changeset in webkit [13470] by eseidel
  • 13 edits in trunk/WebCore

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.
Uninify mac/win dependency handling.
Fix class vs. struct linker problem for win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • bridge/win/BrowserExtensionWin.h:
  • bridge/win/FrameWin.h:
  • generate-derived-sources:
  • kwq/AccessibilityObjectCache.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/mac/GraphicsContextMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectedText): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):
Note: See TracTimeline for information about the timeline view.