⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 27, 2006:

10:32 PM Changeset in webkit [13527] by eseidel
  • 14 edits in trunk/WebCore

2006-03-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Give StringImpl a little privacy.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8022

  • dom/CharacterData.cpp: (WebCore::CharacterData::length): (WebCore::CharacterData::appendData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::rendererIsNeeded):
  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints):
  • dom/Text.cpp: (WebCore::Text::splitText):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken):
  • platform/AtomicString.cpp: (WebCore::operator==):
  • platform/String.cpp: (WebCore::String::operator[]): (WebCore::String::length): (WebCore::String::percentage): (WebCore::String::unicode): (WebCore::String::deprecatedString): (WebCore::String::isEmpty):
  • platform/StringImpl.cpp: (WebCore::equal): (WebCore::equalIgnoringCase):
  • platform/StringImpl.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
10:30 PM Changeset in webkit [13526] by mjs
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by Beth.


  • test cases for <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)
  • fast/block/float/float-in-float-hit-testing-expected.checksum: Added.
  • fast/block/float/float-in-float-hit-testing-expected.png: Added.
  • fast/block/float/float-in-float-hit-testing-expected.txt: Added.
  • fast/block/float/float-in-float-hit-testing.html: Added.
  • fast/block/float/float-in-float-painting-expected.checksum: Added.
  • fast/block/float/float-in-float-painting-expected.png: Added.
  • fast/block/float/float-in-float-painting-expected.txt: Added.
  • fast/block/float/float-in-float-painting.html: Added.
  • fast/events/capture-on-target.html:

WebCore:

Reviewed by Beth.

  • fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects as well as their overflowRects.
  • platform/IntRect.h: (WebCore::unionRect): useful helper
  • platform/FloatRect.h: (WebCore::unionRect): added same for FloatRect just because
8:26 PM Changeset in webkit [13525] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

  • ChangeLog:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Instead of calling -stop, assert that the plugin is not running. A plugin view cannot be deallocated until it is removed from its window. When a plugin view is removed from its window, it calls -stop on itself. Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the assertion will help catch any edge cases. (-[WebBaseNetscapePluginView finalize]): ditto
8:15 PM Changeset in webkit [13524] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694086> -[WebBaseNetscapePluginStream finalize] is incorrect; design change needed

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that the stream file path either never existed, or was deleted and NULL-ed out. The stream file is now deleted immediately after calling NPP_StreamAsFile(). (-[WebBaseNetscapePluginStream finalize]): ditto (-[WebBaseNetscapePluginStream _destroyStream]): Delete the file after calling NPP_StreamAsFile(), instead of in -dealloc/-finalize. It should be OK to delete the file here -- NPP_StreamAsFile() is always called immediately before NPP_DestroyStream() (the stream destruction function), so there can be no expectation that a plugin will read the stream file asynchronously after NPP_StreamAsFile() is called.
8:13 PM Changeset in webkit [13523] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694093> -[WebBasePluginPackage finalize] is incorrect; design change needed

Call -unload on plug-in packages instead of relying on -dealloc/-finalize to do it. Currently
the only place plug-in packages are deallocated is when refreshing the set of plugins, as when
handling JavaScript's navigator.plugins.refresh().

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that the plug-in has been unloaded by the time -dealloc is called. (-[WebBasePluginPackage finalize]): ditto
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -unload on the plug-in packages before releasing them.
5:07 PM Changeset in webkit [13522] by darin
  • 2 edits in trunk/WebCore

Based on a patch by Michael Emmel <​mike.emmel@gmail.com>.

  • platform/TransferJob.cpp: Remove unneeded include of "String.h".
4:57 PM Changeset in webkit [13521] by harrison
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

  • editing/deleting/delete-block-merge-contents-022.html: Added.
  • editing/deleting/delete-block-merge-contents-023.html: Added.
  • editing/selection/selectNode-expected.checksum: Added.
  • editing/selection/selectNode-expected.png: Added.
  • editing/selection/selectNode-expected.txt: Added.
  • editing/selection/selectNode.html: Added.
  • editing/selection/selectNodeContents-expected.checksum: Added.
  • editing/selection/selectNodeContents-expected.png: Added.
  • editing/selection/selectNodeContents-expected.txt: Added.
  • editing/selection/selectNodeContents.html: Added.
4:54 PM Changeset in webkit [13520] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Better fix than previous checkin, since maxDeepOffset is really an editing hack.

  • editing/selection/selectNodeContents-textNode.html: Added.
  • dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxOffset if offsetInCharacters, otherwise use childNodeCount.
4:07 PM Changeset in webkit [13519] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebKit

Release tag for Mac OS X Update 10.4.3.

4:07 PM Changeset in webkit [13518] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebCore

Release tag for Mac OS X Update 10.4.3.

4:05 PM Changeset in webkit [13517] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/JavaScriptCore

Release tag for Mac OS X Update 10.4.3.

3:34 PM Changeset in webkit [13516] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13515] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebKit

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13514] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptGlue

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13513] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13512] by thatcher
  • 2 adds in releases/Apple/Tiger

New release directories.

3:29 PM Changeset in webkit [13511] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebKit

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13510] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebCore

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13509] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptGlue

Release tag for Mac OS X Update 10.4.5.

3:28 PM Changeset in webkit [13508] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptCore

Release tag for Mac OS X Update 10.4.5.

3:24 PM Changeset in webkit [13507] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/WebKit

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13506] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/WebCore

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13505] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptGlue

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13504] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptCore

Release tag for Security Update 2006-001.

3:15 PM Changeset in webkit [13503] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/WebKit

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13502] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/WebCore

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13501] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptGlue

Release tag for Security Update 2006-002.

3:14 PM Changeset in webkit [13500] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptCore

Release tag for Security Update 2006-002.

3:01 PM Changeset in webkit [13499] by thatcher
  • 5 adds in releases/Apple

New release directories. Will do server copies for the actual files.

2:21 PM Changeset in webkit [13498] by darin
  • 2 edits in trunk/WebCore

At the request of Michael Emmel <​mike.emmel@gmail.com>.

  • rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked
formatting a bit and removed some extraneous WebCore
prefixes.
2:09 PM Changeset in webkit [13497] by thatcher
  • 1 add in releases

New releases folder to hold tags of all WebKit versions released to the public. Reviewed by Darin.

2:07 PM Changeset in webkit [13496] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Part of <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore,
WebKit and WebBrowser

  • Carbon/HIViewAdapter.h: HIViewAdapter is no longer an NSView subclass, since we no longer pose it as NSView.
  • Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): Replace individual NSView methods instead of posing as NSView. (_webkit_NSView_setNeedsDisplay): Replacement implementation of -[NSView setNeedsDisplay:]. (_webkit_NSView_setNeedsDisplayInRect): Replacement implementation of -[NSView setNeedsDisplayInRect:] (_webkit_NSView_nextValidKeyView): Replacement implementation of -[NSView nextValidKeyView]
1:44 PM Changeset in webkit [13495] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler and Tim Omernick


  • fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly confirmed while typing on Safari.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _displayedValue]): Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but for now it fixes this regression.
1:33 PM Changeset in webkit [13494] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.


Removed two overzealous assertions that the steps to reproduce 4451831 were running into.
Improved comments to match.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): Remove assertion that _inNextKeyViewOutsideWebFrameViews should always be false here.


  • WebView/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assertion that the frame should never be the main frame here.
1:20 PM Changeset in webkit [13493] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Removed tabs & reformatted code.


  • Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): (+[NSView getHIViewForNSView:]): (+[NSView unbindNSView:]): (-[NSView setNeedsDisplay:]): (-[NSView setNeedsDisplayInRect:]): (-[NSView nextValidKeyView]): (SetViewNeedsDisplay):
1:10 PM Changeset in webkit [13492] by lypanov
  • 6 edits
    2 adds in trunk

2006-03-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by darin

  • fast/dynamic/insertAdjacentElement.html: Added.

2006-03-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by darin

Implement the IE extension insertAdjacentElement
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6520

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Element.cpp: (WebCore::ElementImpl::insertAdjacentElement):
  • dom/Element.h:
  • dom/Element.idl:
9:34 AM Changeset in webkit [13491] by justing
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by beth and geoff

  • editing/selection/6476-expected.checksum: Added.
  • editing/selection/6476-expected.png: Added.
  • editing/selection/6476-expected.txt: Added.
  • editing/selection/6476.html: Added.
8:23 AM Changeset in webkit [13490] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
nodes. Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
selectNodeContents on a text node.

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxDeepOffset instead of childNodeCount, so that text node content is selected.
5:17 AM Changeset in webkit [13489] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page


  • fast/css/outline-auto-empty-rects-expected.checksum: Added.
  • fast/css/outline-auto-empty-rects-expected.png: Added.
  • fast/css/outline-auto-empty-rects-expected.txt: Added.
  • fast/css/outline-auto-empty-rects.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page


  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.
3:29 AM Changeset in webkit [13488] by mjs
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Anders.


  • kjs/nodes.cpp: (Node::deref): take into account the case where the extra refcount table was never created

WebCore:

Reviewed by Anders.


  • manual-tests/empty-script-crash.html: Added.
1:32 AM Changeset in webkit [13487] by mjs
  • 2 edits in trunk/WebCore

Build fix:


  • reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node It turns out that the behavior we had was standards-compliant and Moz will be changing to match.


Also added a note so this doesn't get reverted again.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
12:34 AM Changeset in webkit [13486] by justing
  • 8 edits in trunk

WebCore:

Reviewed by darn


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

  • bridge/mac/WebCoreFrameBridge.h:
  • editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::editingAction):
  • editing/EditAction.h:
  • editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):

WebKit:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):

Mar 26, 2006:

7:29 PM Changeset in webkit [13485] by eseidel
  • 5 edits in trunk/WebCore

2006-03-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • editing/CompositeEditCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • generate-derived-sources:
5:30 PM Changeset in webkit [13484] by eseidel
  • 2 edits in trunk/WebCore

2006-03-26 Eric Seidel <​eseidel@apple.com>

  • dom/Element.cpp: fix include case, fixing build.
2:58 PM Changeset in webkit [13483] by eseidel
  • 9 edits
    1 add in trunk/WebCore

2006-03-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

  • manual-tests/left-overflow-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
  • rendering/RenderTableCell.cpp: Removed subclass implementation of getAbsoluteRepaintRect().
  • rendering/RenderTableCell.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.
Note: See TracTimeline for information about the timeline view.