Context Navigation

← Previous Period
Next Period →

Timeline

Mar 31, 2006:

4:40 PM Changeset in webkit [13623] by thatcher

1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Knocking the number of PLTs we run down to 3 to see if we come in under the BuildBot timeout.

4:12 PM Changeset in webkit [13622] by thatcher

1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Knocking the number of PLTs we run down to 4 to see if we come in under the BuildBot timeout.

3:14 PM Changeset in webkit [13621] by sullivan

2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word doesn't select it or offer corrections (first click only)

bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Rolled in this one-line change that Hyatt wrote ages ago.

2:39 PM Changeset in webkit [13620] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

We need to set reachedTerminalState to YES before we release
the resources to prevent a double dealloc of WebView

Fixes <rdar://problem/4372628> crash deallocating a WebView in -[WebFrame stopLoading]

WebView/WebLoader.m: (-[NSURLProtocol releaseResources]): set reachedTerminalState earlier

1:50 PM Changeset in webkit [13619] by bdakin

3 edits
4 adds in trunk

Reviewed by John.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8108
REGRESSION (r13590-r13593): Floating table's cells don't paint
their background

This is a regression from my painting patch yesterday. Just a silly
error I didn't catch.

rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Change the phase of our new PaintInfo, not our old one.

1:36 PM Changeset in webkit [13618] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim Omernick.

Some cleanup in the WebIconDatabase code in a fruitless search for the cause
of the mysterious -[WebFileDatabase performSetObject:forKey] crash

Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): removed obsolete comment (-[WebIconDatabase _loadIconDictionaries]): Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until the end of the method where they are retained, so that the early returns don't leak; added ASSERTs that the _private->dictionary values aren't being leaked. (-[WebIconDatabase _updateFileDatabase]): Added an ERROR for an unexpected early return, and made a trivial style fix.

12:58 PM Changeset in webkit [13617] by tomernic

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adele.

Layout test for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
<rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

fast/forms/input-appearance-readonly-expected.txt: Added.
fast/forms/input-appearance-readonly.html: Added.

WebCore:

Reviewed by Adele.

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
<rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Set user modify based on the form element's readOnly(). (WebCore::RenderTextField::updateFromElement): ditto

12:44 PM Changeset in webkit [13616] by adele

3 edits in trunk/WebCore

Reviewed by Tim Omernick.

Updating shadowAncestorNode so it doesn't check for rootEditableElement. Now we just walk
up the tree to look for a shadowNode, and then we find the shadowParent.

dom/Node.cpp: (WebCore::Node::shadowAncestorNode):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Updated assertion to check for shadowAncestorNode instead of rootEditableElement.

12:30 PM Changeset in webkit [13615] by ap

3 edits
2 copies
7 adds in trunk

Fix by Trey Matteson, reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

Tests: http/tests/misc/acid2.html, http/tests/misc/acid2-pixel.html

The gist of this change is that we must cancel the load from the Webkit side when we
realize we're switching to the fallback content. This is somewhat a temp workaround
since control of loading will be moving to WebCore.

WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):

12:12 PM Changeset in webkit [13614] by adele

3 edits in trunk/WebCore

Reviewed by John Sullivan.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8101 REGSRESSION: Fix for bug 7031 causes 30 layout tests to fail

rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): Change top and bottom positions only if childAffectsTopBottomPos is true.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Redo a part of the patch for bug 7031 that wasn't committed with the rest of the patch.

11:16 AM Changeset in webkit [13613] by bdakin

3 edits
4 adds in trunk

Reviewed by Darin, landed by Beth.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8081
REGRESSION: Drop-down menu has gap at top

rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVerticalValues): When calculating the hypothetical vertical position in normal flow, skip table rows in the ancestor chain, since a table cell's Y position is relative to the table section, not the row.

11:03 AM Changeset in webkit [13612] by hyatt

4 edits in trunk/WebCore

FIx theme borders on win32.

10:51 AM Changeset in webkit [13611] by darin

14 edits
2 adds in trunk

LayoutTests:

updated results for tests that involve scrolling

editing/selection/focus_editable_html-expected.txt: Added expected scroll position.
fast/dom/focus-contenteditable-expected.txt: Ditto.
fast/overflow/scrollRevealButton.html: Ditto.

updated results for tests that involve new exception names

fast/dom/Element/attr-param-typechecking-expected.txt: Updated.

fast/dynamic/insertAdjacentElement-expected.txt: Updated.
fast/dynamic/insertAdjacentElement-expected.png: Added.
fast/dynamic/insertAdjacentElement-expected.checksum: Added.

WebCore:

Reviewed by John Sullivan.

khtml/ecma/kjs_binding.cpp: Added names for VALIDATION_ERR and TYPE_MISMATCH_ERR; new DOM Level 3 errors that need to be listed in the mapping from error code to error name.

dom/Element.idl: Removed comment from bad old days where we had to touch these files to make them rebuild.

WebKitTools:

Reviewed by John Sullivan.

added a "--reset-results" option to run-webkit-tests so you can reset the results without first deleting expected results
<rdar://problem/4185878> add scroll position to dumpRenderTree

Scripts/run-webkit-tests: Rearranged the code a bit to make the sequence more logical. Moved all the subroutines to the end of the file. Added a "--force" option.

DumpRenderTree/DumpRenderTree.m: (main): Added a new --dump-all-pixels option, used when forcing run-webkit-tests to generate new output for all tests it runs. (dump): Dump the scroll position if it's non-zero. Always dump the image when the --dump-all-pixels option is passed. Also tightened up the image dumping code and replaced the incorrect use of +[NSGraphicsContext saveGraphicsState] with code to save and restore the context.

DumpRenderTree/DumpRenderTree.h: Tweaked includes a bit and added (void).
DumpRenderTree/EventSendingController.m: Added now-needed include.

10:02 AM Changeset in webkit [13610] by darin

2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

<rdar://problem/4395622> API: WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript returns NO by default

bindings/objc/WebScriptObject.h: Fixed comment.

9:40 AM Changeset in webkit [13609] by bdakin

1 edit
4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
Focus ring around link in overflow:auto div isn't clipped to div

8:39 AM Changeset in webkit [13608] by darin

1 edit in trunk/JavaScriptCore/ChangeLog

Removed all the tabs and cleared the "allow tabs" bit.

3:45 AM Changeset in webkit [13607] by hyatt

1 edit in trunk/WebCore/rendering/RenderTheme.cpp

Fix my build bustage with themes.

3:32 AM Changeset in webkit [13606] by mjs

4 edits in trunk/WebCore

fixed Windows build breakage from previous change

platform/ScrollView.h:
platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollBy):

3:24 AM Changeset in webkit [13605] by mjs

22 edits in trunk/WebCore

Reviewed by Eric.

various Point / Size related cleanup

First, I clarified the semantics of some operations to keep a
better distinction between IntPoint and IntSize:

platform/IntPoint.h: (WebCore::IntPoint::move): new convenience to move a point by separate x and y deltas. (WebCore::operator+=): You can't add a point to a point, you can only add a size to a point. (WebCore::operator+): ditto (WebCore::operator-): point - point = size; point - size = point (WebCore::operator-=): only allow subtracting a size for the mutating version
platform/IntRect.h: (WebCore::IntRect::move): tweaked to use IntPoint::move, also, move by an IntSize, not an IntPoint.
platform/IntSize.h: (WebCore::IntSize::shrunkTo): analog to expandedTo (WebCore::IntSize::clampNegativeToZero): a handy helper (WebCore::operator-): Added unary minus operator

Made the same changes for FloatPoint:

platform/FloatPoint.h: (WebCore::FloatPoint::move): (WebCore::operator+=): (WebCore::operator-=): (WebCore::operator+): (WebCore::operator-):
platform/FloatRect.h: (WebCore::FloatRect::move):
platform/FloatSize.h: (WebCore::operator-):

Then I changed a bunch of stuff to pass around IntPoint instead of separate x and y
coordinates. The main one was:

platform/ScrollView.h:
platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollOffset): new method, return an IntSize (WebCore::ScrollView::contentsToViewport): take and return an IntPoint (WebCore::ScrollView::viewportToContents): take and return an IntPoint
platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents): handle things in terms of scrollOffset, not scrollPoint (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::updateScrollBars):

The rest is mainly updates for these changes.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::shouldDragAutoNode): (WebCore::FrameMac::sendContextMenuEvent):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isPointInsideSelection:]):
dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent):
khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
page/Frame.cpp: (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::isPointInsideSelection): (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventDoubleClick): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventPart2): (WebCore::Frame::handleMouseReleaseEvent):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::prepareMouseEvent): (WebCore::FrameView::handleWheelEvent):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode):
rendering/RenderObject.h: (WebCore::RenderObject::positionForPoint):
rendering/render_list.cpp: (WebCore::RenderListMarker::paint):

3:18 AM Changeset in webkit [13604] by mjs

2 edits in trunk/WebCore

fixed windows build

platform/win/TemporaryLinkStubs.cpp: (Widget::unlockDrawingFocus):

1:15 AM Changeset in webkit [13603] by eseidel

8 edits in trunk/JavaScriptCore

2006-03-31 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

A bit more code cleanup.

bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
kjs/interpreter.cpp: (KJS::ExecState::lexicalInterpreter):
kjs/interpreter.h:
kjs/operations.cpp: (KJS::equal):

1:14 AM Changeset in webkit [13602] by eseidel

9 edits in trunk/WebCore

2006-03-31 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

A bit more code cleanup.

bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
kwq/WebCoreTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQSecureTextField selectText:]):
page/Frame.cpp: (WebCore::Frame::submitForm):
platform/Widget.h:
platform/mac/WidgetMac.mm:
rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):

Mar 30, 2006:

11:39 PM Changeset in webkit [13601] by mjs

11 edits
3 adds in trunk/WebCore

Reviewed by Eric.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::wheelEvent): (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::sendContextMenuEvent):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
dom/Document.cpp: (WebCore::Document::elementFromPoint): (WebCore::Document::prepareMouseEvent):
dom/Document.h:
kwq/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): (-[WebCoreAXObject accessibilityHitTest:]):
manual-tests/frame-hover.html: Added.
manual-tests/resources/hover-subframe-1.html: Added.
manual-tests/resources/hover-subframe-2.html: Added.
page/Frame.cpp: (WebCore::Frame::isPointInsideSelection):
page/FrameView.cpp: (WebCore::FrameView::prepareMouseEvent): (WebCore::FrameView::handleWheelEvent):
platform/IntRect.h: (WebCore::IntRect::contains):
rendering/RenderLayer.cpp: (WebCore::isSubframeCanvas): (WebCore::frameVisibleRect): (WebCore::RenderLayer::hitTest): (WebCore::shouldApplyImplicitCapture): (WebCore::RenderLayer::hitTestLayer):
rendering/RenderLayer.h:

11:37 PM Changeset in webkit [13600] by andersca

1 edit
3 adds in trunk/LayoutTests

2006-03-31 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

Add getter/setter GC tests.

fast/js/getter-setter-gc-expected.txt: Added.
fast/js/getter-setter-gc.html: Added.
fast/js/resources/getter-setter-gc.js: Added.

11:25 PM Changeset in webkit [13599] by darin

185 edits in trunk/LayoutTests

2006-03-30 Darin Adler <Darin Adler>

updated pixel results to create a new baseline (on a 10.4.5 system)

10:52 PM Changeset in webkit [13598] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by anders.

Small code-style update.

kjs/operations.cpp: (KJS::isNaN): (KJS::isInf): (KJS::isPosInf): (KJS::isNegInf): (KJS::equal): (KJS::strictEqual): (KJS::relation): (KJS::maxInt): (KJS::minInt): (KJS::add): (KJS::mult):

10:48 PM Changeset in webkit [13597] by andersca

2 edits in trunk/JavaScriptCore

2006-03-31 Anders Carlsson <andersca@mac.com>

Reviewed by Maciej.

Make sure the GetterSetterImp objects are marked as well.

kjs/internal.cpp: (KJS::GetterSetterImp::mark): Call JSCell::mark().

9:49 PM Changeset in webkit [13596] by adele

4 edits
8 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8056 Flexible boxes do not repaint their top, left and children's overflows

fast/repaint/flexible-box-overflow-expected.checksum: Added.
fast/repaint/flexible-box-overflow-expected.png: Added.
fast/repaint/flexible-box-overflow-expected.txt: Added.
fast/repaint/flexible-box-overflow-horizontal-expected.checksum: Added.
fast/repaint/flexible-box-overflow-horizontal-expected.png: Added.
fast/repaint/flexible-box-overflow-horizontal-expected.txt: Added.
fast/repaint/flexible-box-overflow-horizontal.html: Added.
fast/repaint/flexible-box-overflow.html: Added.

WebCore:

Tests: fast/repaint/flexible-box-overflow.html fast/repaint/flexible-box-overflow-horizontal.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8056 Flexible boxes do not repaint their top, left and children's overflows

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren):
rendering/RenderFlexibleBox.cpp: (WebCore::FlexBoxIterator::next): (WebCore::RenderFlexibleBox::layoutHorizontalBox): Update top overflow when determining vertical positions. Update horizontal overflows after horizontal positions are determined. (WebCore::RenderFlexibleBox::layoutVerticalBox): Update left overflow when determining horizontal positions. Update vertical overflows after vertical positions are determined. (WebCore::RenderFlexibleBox::allowedChildFlex):

9:23 PM Changeset in webkit [13595] by adele

7 edits
13 adds in trunk

LayoutTests:

Reviewed by Darin.

Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7301 Text shadow does not repaint correctly

fast/repaint: Added.
fast/repaint/inline-block-overflow-expected.checksum: Added.
fast/repaint/inline-block-overflow-expected.png: Added.
fast/repaint/inline-block-overflow-expected.txt: Added.
fast/repaint/inline-block-overflow.html: Added.
fast/repaint/text-shadow-expected.checksum: Added.
fast/repaint/text-shadow-expected.png: Added.
fast/repaint/text-shadow-expected.txt: Added.
fast/repaint/text-shadow-horizontal-expected.checksum: Added.
fast/repaint/text-shadow-horizontal-expected.png: Added.
fast/repaint/text-shadow-horizontal-expected.txt: Added.
fast/repaint/text-shadow-horizontal.html: Added.
fast/repaint/text-shadow.html: Added.

WebCore:

Tests: fast/repaint/text-shadow.html fast/repaint/text-shadow-horizontal.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7301 Text shadow does not repaint correctly

rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Paint the text box if it is within the maximum possible horizontal shadow overflow of the damage rect.
rendering/InlineTextBox.h: Removed unused function checkVerticalPoint().
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Use the vertical overflows instead of the selection vertical bounds. (WebCore::RenderFlow::hitTestLines):
rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include overflow due to text shadow in leftPosition and rightPosition and keep track of the maximum horizontal shadow on the inline. (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::placeBoxesVertically): Include overflow due to shadow and inline-blocks' overflow in topPosition and bottomPosition but not in the selection vertical bounds. (WebCore::RootInlineBox::selectionTop):
rendering/render_line.h: (WebCore::InlineFlowBox:::InlineRunBox): (WebCore::InlineFlowBox::setVerticalSelectionPositions): (WebCore::InlineFlowBox::maxHorizontalShadow): (WebCore::RootInlineBox::setVerticalSelectionPositions): (WebCore::RootInlineBox::selectionBottom): (WebCore::RootInlineBox::selectionHeight):

7:12 PM Changeset in webkit [13594] by hyatt

6 edits in trunk/WebCore

Land focus ring bug fix and win theme improvements.

5:21 PM Changeset in webkit [13593] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

kjs/nodes.h: Some various small style fixes.

5:19 PM Changeset in webkit [13592] by bdakin

25 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4472371> REGRESSION(417.9-TOT): Focus ring
around link in overflow:auto div isn't clipped to div

Focus rings around the children off overflow:auto divs were not
being appropriately clipped because they were being painted with
the div's outlineRect, when they should be painted separately. This
patch adds two new PaintPhases -- PaintPhaseSelfOutline and
PaintPhaseChildOutlines -- to address this problem.

This patch also changes the name of PaintAction back to PaintPhase.
Because Hyatt said so.

5:13 PM Changeset in webkit [13591] by eseidel

2 edits in trunk/JavaScriptCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Clean-up style issues in node.h, remove redundant initializations.

kjs/nodes.h: (KJS::StatementNode::evaluate): (KJS::ArrayNode::ArrayNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::NewExprNode::NewExprNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::FuncDeclNode::FuncDeclNode):

4:44 PM Changeset in webkit [13590] by tomernic

1 edit
3 adds in trunk/WebCore

Manual test case for the Java aspect of <rdar://problem/4212626> REGRESSION: LIVECONNECT:
JavaScript type for Java Strings is function, not object

manual-tests/java-string-object-type.html: Added.
manual-tests/resources/StringTypeTest.class: Added.
manual-tests/resources/StringTypeTest.java: Added.

4:15 PM Changeset in webkit [13589] by tomernic

9 edits in trunk/JavaScriptCore

Reviewed by Geoff.

<rdar://problem/4212626> REGRESSION: LIVECONNECT: JavaScript type for Java Strings is function,
not object

bindings/runtime.h: (KJS::Bindings::Instance::implementsCall): New method. Returns false by default. Concrete subclasses can override this return true when the bound object may be called as a function. (KJS::Bindings::Instance::invokeDefaultMethod): Since bound objects are no longer treated as functions by default, we can return jsUndefined() here instead of in concrete subclasses that decide not to implement the default method functionality.

bindings/runtime_object.cpp: (RuntimeObjectImp::implementsCall): Don't assume that the bound object is a function; instead, let the object instance decide whether it is callable.

bindings/c/c_instance.h:
bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::implementsCall): The object is callable if its class has an invokeDefault function.

bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm: (ObjcInstance::implementsCall): The object is callable if the ObjC instance responds to -invokeDefaultMethodWithArguments:.

bindings/jni/jni_instance.h:
bindings/jni/jni_instance.cpp: Moved bogus invokeDefaultMethod() to superclass.

4:13 PM Changeset in webkit [13588] by tomernic

1 edit
2 adds in trunk/LayoutTests

Reviewed by Geoff.

Test case for issues surrounding <rdar://problem/4212626> REGRESSION: LIVECONNECT:
JavaScript type for Java Strings is function, not object

Unfortunately, I can only test C and ObjC instances; Java does not run correctly
in DumpRenderTree.

plugins/bindings-test/bindings-test.html: Added.
plugins/bindings-test/bindings-test-expected.txt: Added.

3:48 PM Changeset in webkit [13587] by tomernic

5 edits in trunk/WebKitTools

Reviewed by NOBODY (just fixing copyrights)

DumpRenderTree/ObjCPlugin.h: Fixed copyright.
DumpRenderTree/ObjCPlugin.m: ditto
DumpRenderTree/ObjCPluginFunction.h: ditto
DumpRenderTree/ObjCPluginFunction.m: ditto

3:30 PM Changeset in webkit [13586] by tomernic

4 edits
4 adds in trunk/WebKitTools

Reviewed by Geoff.

DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]): Add "objCPlugin", "objCPluginFunction" properties to the window. objCPlugin simulates an Objective C object exposed to JS; objCPluginFunction simulates an Objective C method exposed to JS as a callable object.

DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ObjCPlugin.[hm], ObjCPluginFunction.[hm].

DumpRenderTree/ObjCPlugin.h: Added.
DumpRenderTree/ObjCPlugin.m: Added.
DumpRenderTree/ObjCPluginFunction.h: Added.
DumpRenderTree/ObjCPluginFunction.m: Added.

DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added a new method, "removeDefaultMethod", which removes the default method from the plugin object's class. The effect is that the plugin object is mutated from a callable function to a simple object. (pluginInvoke): Handle "removeDefaultMethod". (pluginInvokeDefault): Made the default method actually do something (return 1).

2:16 PM Changeset in webkit [13585] by eseidel

4 edits in trunk/WebKitTools

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by ggaren.

Remove WebFrame::viewImpl(), setMainFrame on page.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFrame):
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::mouseMoved): (WebKit::WebView::mouseDown): (WebKit::WebView::mouseUp): (WebKit::WebView::mouseDoubleClick): (WebKit::WebViewWndProc):

1:55 PM Changeset in webkit [13584] by eseidel

4 edits in trunk/WebKitTools

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix html editing input & basic form submission.

Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::submitForm): (WebKit::WebFrame::loadURL):
Spinneret/Spinneret/WebFrame.h:
Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::keyPress): (WebKit::WebViewWndProc):

1:44 PM Changeset in webkit [13583] by eseidel

6 edits in trunk/WebCore

2006-03-30 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Fix text form controls, and add basic submit support!

bridge/win/FrameWin.cpp: (WebCore::FrameWin::submitForm):
bridge/win/FrameWin.h:
platform/win/KeyEventWin.cpp: (WebCore::keyIdentifierForWindowsKeyCode): (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::incomingReferrer):
platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

12:56 PM Changeset in webkit [13582] by adele

2 edits in trunk/WebCore

Reviewed by Justin.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8083 REGRESSION: Repro crash when dragging to select over a new text field

editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): When searching for non-editable content, if the end of the selection is in a shadow tree, then we need to jump out of that first.

11:28 AM Changeset in webkit [13581] by justing

20 edits
6 adds in trunk

LayoutTests:

Reviewed by darin

http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field

fast/forms/plaintext-mode-1-expected.txt: Added.
fast/forms/plaintext-mode-1.html: Added.
fast/forms/plaintext-mode-2-expected.checksum: Added.
fast/forms/plaintext-mode-2-expected.png: Added.
fast/forms/plaintext-mode-2-expected.txt: Added.
fast/forms/plaintext-mode-2.html: Added.

WebCore:

Reviewed by darin

http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionEditable]): (-[WebCoreFrameBridge isSelectionRichlyEditable]):
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
dom/Node.cpp: (WebCore::Node::isContentRichlyEditable):
dom/Node.h:
editing/EditCommand.cpp: (WebCore::EditCommand::apply):
editing/JSEditor.cpp:
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::doApply):
editing/Selection.h: (WebCore::Selection::rootEditableElement): (WebCore::Selection::isContentEditable): (WebCore::Selection::isContentRichlyEditable):
editing/SelectionController.h: (WebCore::SelectionController::rootEditableElement): (WebCore::SelectionController::isContentEditable): (WebCore::SelectionController::isContentRichlyEditable):
html/HTMLElement.cpp: (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable): (WebCore::HTMLElement::setContentEditable):
rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle):
rendering/render_style.h: (WebCore::):

WebKit:

Reviewed by darin

http://bugzilla.opendarwin.org/show_bug.cgi?id=6989
REGRESSION: Plain-text mode needed for contenteditable area used in new text field

WebView/WebHTMLView.m: (-[WebHTMLView _canEditRichly]): Added. (-[WebHTMLView _canIncreaseSelectionListLevel]): Use _canEditRichly (-[WebHTMLView _canDecreaseSelectionListLevel]): Ditto. (-[WebHTMLView _increaseSelectionListLevel]): (-[WebHTMLView _decreaseSelectionListLevel]): (-[NSArray validateUserInterfaceItem:]): Split rich text editing actions off from ones that can be applied anywhere. (-[NSArray _applyStyleToSelection:withUndoAction:]): (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]): (-[NSArray _alignSelectionUsingCSSValue:withUndoAction:]):
WebView/WebHTMLViewPrivate.h:

11:21 AM Changeset in webkit [13580] by harrison

1 edit
12 adds in trunk/LayoutTests

Reviewed by Justin.

<rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"

editing/deleting/delete-block-merge-contents-022-expected.checksum: Added.
editing/deleting/delete-block-merge-contents-022-expected.png: Added.
editing/deleting/delete-block-merge-contents-022-expected.txt: Added.
editing/deleting/delete-block-merge-contents-022.html: Added.
editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
editing/deleting/delete-block-merge-contents-023-expected.png: Added.
editing/deleting/delete-block-merge-contents-023-expected.txt: Added.
editing/deleting/delete-block-merge-contents-023.html: Added.
editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
editing/deleting/delete-block-merge-contents-024-expected.png: Added.
editing/deleting/delete-block-merge-contents-024-expected.txt: Added.
editing/deleting/delete-block-merge-contents-024.html: Added.

11:20 AM Changeset in webkit [13579] by harrison

2 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/4444693> REGRESSION: Deleting empty lines causes quoted text to mistakenly get "unquoted"

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Formatting. (WebCore::DeleteSelectionCommand::moveNodesAfterNode): Generalize check that preserves nesting when deleting to the beginning of an ancestor block.

editing/deleting/delete-block-merge-contents-022.html: Added.
editing/deleting/delete-block-merge-contents-023.html: Added.
editing/deleting/delete-block-merge-contents-024.html: Added.

10:40 AM Changeset in webkit [13578] by adele

3 edits
4 adds in trunk

LayoutTests:

Test: fast/forms/visual-hebrew-text-field.html

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8076 REGRESSION: native text fields are reversed on "visual Hebrew" pages

css/html4.css: Set the -kthml-rtl-ordering property to "logical" for all input elements. This should help also with future conversions from AppKit to native.

WebCore: