Timeline

Apr 2, 2006:

12:55 AM Changeset in webkit [13635] by ggaren

• 5 edits
  1 add in trunk/JavaScriptGlue

Reviewed by Darin.

• Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz Composer

JSValueWrappers used to hold on to the ExecState that pertained at
the time of their creation. Since ExecStates are transient, that
design was totally bogus, and it would crash once the ExecState had
been deallocated.

Unfortunately, there's no clean solution to this problem, since
the JSGlue API has no notion of state. The solution here is to use
a shared, global ExecState for the purpose of JSGlue calls. Given
the pre-existing limitations in the JSGlue API, this design
shouldn't actually introduce any new limitations (see comments in
JSValueWrapper.cpp).

I tested with Quartz Composer and PAC files, neither of which are
layout-testable.

• JSUtils.cpp: (KJSValueToJSObject):
• JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (getProcessGlobalExecState): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
• JSValueWrapper.h:

Also added a test harness file. It was helpful while I was testing,
and may come in handy in the future:

• JavaScriptGlue.xcodeproj/project.pbxproj: testjsglue.cpp: Added.

Apr 1, 2006:

6:52 PM Changeset in webkit [13647] by darin

• 3 edits in trunk/LayoutTests

• updated one more result for change in focus ring appearance

• fast/forms/plaintext-mode-2-expected.checksum: Updated.
• fast/forms/plaintext-mode-2-expected.png: Ditto.

6:39 PM Changeset in webkit [13646] by darin

• 2 edits in trunk/WebCore

• add a few stubs to get Windows closer to building

• platform/win/TemporaryLinkStubs.cpp: (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles):

6:26 PM Changeset in webkit [13645] by darin

• 2 edits in trunk/WebCore

• fix the build

• WebCore.xcodeproj/project.pbxproj: Removed a bunch of files that should not have been mentioned at all, and a bunch of others that should be in the project but not in the target.

6:17 PM Changeset in webkit [13644] by darin

• 178 edits in trunk/LayoutTests

• updated layout test results, mostly for the change in focus ring appearance

• editing/input/range-for-empty-document-expected.txt:

• editing/selection/3690703-2-expected.checksum:
• editing/selection/3690703-2-expected.png:
• editing/selection/3690703-2-expected.txt:

• fast/overflow/scrollRevealButton-expected.checksum:
• fast/overflow/scrollRevealButton-expected.png:
• fast/overflow/scrollRevealButton-expected.txt:

• editing/deleting/collapse-whitespace-3587601-fix-expected.checksum:
• editing/deleting/collapse-whitespace-3587601-fix-expected.png:
• editing/deleting/delete-3608430-fix-expected.checksum:
• editing/deleting/delete-3608430-fix-expected.png:
• editing/deleting/delete-3608445-fix-expected.checksum:
• editing/deleting/delete-3608445-fix-expected.png:
• editing/deleting/delete-3608462-fix-expected.checksum:
• editing/deleting/delete-3608462-fix-expected.png:
• editing/deleting/delete-3959464-fix-expected.checksum:
• editing/deleting/delete-3959464-fix-expected.png:
• editing/deleting/delete-4038408-fix-expected.checksum:
• editing/deleting/delete-4038408-fix-expected.png:
• editing/deleting/delete-4083333-fix-expected.checksum:
• editing/deleting/delete-4083333-fix-expected.png:
• editing/deleting/delete-after-span-ws-001-expected.checksum:
• editing/deleting/delete-after-span-ws-001-expected.png:
• editing/deleting/delete-after-span-ws-002-expected.checksum:
• editing/deleting/delete-after-span-ws-002-expected.png:
• editing/deleting/delete-after-span-ws-003-expected.checksum:
• editing/deleting/delete-after-span-ws-003-expected.png:
• editing/deleting/delete-and-undo-expected.checksum:
• editing/deleting/delete-and-undo-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-008-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
• editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
• editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
• editing/deleting/delete-block-contents-001-expected.checksum:
• editing/deleting/delete-block-contents-001-expected.png:
• editing/deleting/delete-block-contents-002-expected.checksum:
• editing/deleting/delete-block-contents-002-expected.png:
• editing/deleting/delete-block-contents-003-expected.checksum:
• editing/deleting/delete-block-contents-003-expected.png:
• editing/deleting/delete-block-merge-contents-001-expected.checksum:
• editing/deleting/delete-block-merge-contents-001-expected.png:
• editing/deleting/delete-block-merge-contents-002-expected.checksum:
• editing/deleting/delete-block-merge-contents-002-expected.png:
• editing/deleting/delete-block-merge-contents-003-expected.checksum:
• editing/deleting/delete-block-merge-contents-003-expected.png:
• editing/deleting/delete-block-merge-contents-004-expected.checksum:
• editing/deleting/delete-block-merge-contents-004-expected.png:
• editing/deleting/delete-block-merge-contents-005-expected.checksum:
• editing/deleting/delete-block-merge-contents-005-expected.png:
• editing/deleting/delete-block-merge-contents-006-expected.checksum:
• editing/deleting/delete-block-merge-contents-006-expected.png:
• editing/deleting/delete-block-merge-contents-007-expected.checksum:
• editing/deleting/delete-block-merge-contents-007-expected.png:
• editing/deleting/delete-block-merge-contents-008-expected.checksum:
• editing/deleting/delete-block-merge-contents-008-expected.png:
• editing/deleting/delete-block-merge-contents-009-expected.checksum:
• editing/deleting/delete-block-merge-contents-009-expected.png:
• editing/deleting/delete-block-merge-contents-010-expected.checksum:
• editing/deleting/delete-block-merge-contents-010-expected.png:
• editing/deleting/delete-block-merge-contents-011-expected.checksum:
• editing/deleting/delete-block-merge-contents-011-expected.png:
• editing/deleting/delete-block-merge-contents-012-expected.checksum:
• editing/deleting/delete-block-merge-contents-012-expected.png:
• editing/deleting/delete-block-merge-contents-013-expected.checksum:
• editing/deleting/delete-block-merge-contents-013-expected.png:
• editing/deleting/delete-block-merge-contents-014-expected.checksum:
• editing/deleting/delete-block-merge-contents-014-expected.png:
• editing/deleting/delete-block-merge-contents-015-expected.checksum:
• editing/deleting/delete-block-merge-contents-015-expected.png:
• editing/deleting/delete-block-merge-contents-016-expected.checksum:
• editing/deleting/delete-block-merge-contents-016-expected.png:
• editing/deleting/delete-block-merge-contents-017-expected.checksum:
• editing/deleting/delete-block-merge-contents-017-expected.png:
• editing/deleting/delete-br-001-expected.checksum:
• editing/deleting/delete-br-001-expected.png:
• editing/deleting/delete-br-002-expected.checksum:
• editing/deleting/delete-br-002-expected.png:
• editing/deleting/delete-br-003-expected.checksum:
• editing/deleting/delete-br-003-expected.png:
• editing/deleting/delete-br-004-expected.checksum:
• editing/deleting/delete-br-004-expected.png:
• editing/deleting/delete-br-005-expected.checksum:
• editing/deleting/delete-br-005-expected.png:
• editing/deleting/delete-br-006-expected.checksum:
• editing/deleting/delete-br-006-expected.png:
• editing/deleting/delete-br-007-expected.checksum:
• editing/deleting/delete-br-007-expected.png:
• editing/deleting/delete-character-001-expected.checksum:
• editing/deleting/delete-character-001-expected.png:
• editing/deleting/delete-contiguous-ws-001-expected.checksum:
• editing/deleting/delete-contiguous-ws-001-expected.png:
• editing/deleting/delete-image-001-expected.checksum:
• editing/deleting/delete-image-001-expected.png:
• editing/deleting/delete-image-002-expected.checksum:
• editing/deleting/delete-image-002-expected.png:
• editing/deleting/delete-image-003-expected.checksum:
• editing/deleting/delete-image-003-expected.png:
• editing/deleting/delete-image-004-expected.checksum:
• editing/deleting/delete-image-004-expected.png:
• editing/deleting/delete-leading-ws-001-expected.checksum:
• editing/deleting/delete-leading-ws-001-expected.png:
• editing/deleting/delete-line-015-expected.checksum:
• editing/deleting/delete-line-015-expected.png:
• editing/deleting/delete-line-016-expected.checksum:
• editing/deleting/delete-line-016-expected.png:
• editing/deleting/delete-line-017-expected.checksum:
• editing/deleting/delete-line-017-expected.png:
• editing/deleting/delete-line-end-ws-001-expected.checksum:
• editing/deleting/delete-line-end-ws-001-expected.png:
• editing/deleting/delete-line-end-ws-002-expected.checksum:
• editing/deleting/delete-line-end-ws-002-expected.png:
• editing/deleting/delete-listitem-001-expected.checksum:
• editing/deleting/delete-listitem-001-expected.png:
• editing/deleting/delete-listitem-002-expected.checksum:
• editing/deleting/delete-listitem-002-expected.png:
• editing/deleting/delete-select-all-001-expected.checksum:
• editing/deleting/delete-select-all-001-expected.png:
• editing/deleting/delete-select-all-002-expected.checksum:
• editing/deleting/delete-select-all-002-expected.png:
• editing/deleting/delete-select-all-003-expected.checksum:
• editing/deleting/delete-select-all-003-expected.png:
• editing/deleting/delete-selection-001-expected.checksum:
• editing/deleting/delete-selection-001-expected.png:
• editing/deleting/delete-tab-001-expected.checksum:
• editing/deleting/delete-tab-001-expected.png:
• editing/deleting/delete-tab-002-expected.checksum:
• editing/deleting/delete-tab-002-expected.png:
• editing/deleting/delete-tab-003-expected.checksum:
• editing/deleting/delete-tab-003-expected.png:
• editing/deleting/delete-tab-004-expected.checksum:
• editing/deleting/delete-tab-004-expected.png:
• editing/deleting/delete-trailing-ws-001-expected.checksum:
• editing/deleting/delete-trailing-ws-001-expected.png:
• editing/deleting/delete-trailing-ws-002-expected.checksum:
• editing/deleting/delete-trailing-ws-002-expected.png:
• editing/deleting/delete-ws-fixup-001-expected.checksum:
• editing/deleting/delete-ws-fixup-001-expected.png:
• editing/deleting/delete-ws-fixup-002-expected.checksum:
• editing/deleting/delete-ws-fixup-002-expected.png:
• editing/deleting/delete-ws-fixup-003-expected.checksum:
• editing/deleting/delete-ws-fixup-003-expected.png:
• editing/deleting/delete-ws-fixup-004-expected.checksum:
• editing/deleting/delete-ws-fixup-004-expected.png:
• editing/deleting/smart-delete-001-expected.checksum:
• editing/deleting/smart-delete-001-expected.png:
• editing/deleting/smart-delete-002-expected.checksum:
• editing/deleting/smart-delete-002-expected.png:
• editing/execCommand/boldSelection-expected.checksum:
• editing/execCommand/boldSelection-expected.png:
• editing/execCommand/insertHTML-expected.checksum:
• editing/execCommand/insertHTML-expected.png:
• editing/execCommand/insertImage-expected.checksum:
• editing/execCommand/insertImage-expected.png:
• editing/execCommand/italicizeByCharacter-expected.checksum:
• editing/execCommand/italicizeByCharacter-expected.png:
• editing/execCommand/modifyForeColorByCharacter-expected.checksum:
• editing/execCommand/modifyForeColorByCharacter-expected.png:
• editing/execCommand/print-expected.checksum:
• editing/execCommand/print-expected.png:
• editing/execCommand/selectAll-expected.checksum:
• editing/execCommand/selectAll-expected.png:
• editing/execCommand/strikethroughSelection-expected.checksum:
• editing/execCommand/strikethroughSelection-expected.png:
• editing/inserting/4278698-expected.checksum:
• editing/inserting/4278698-expected.png:
• editing/inserting/editing-empty-divs-expected.checksum:
• editing/inserting/editing-empty-divs-expected.png:
• editing/inserting/insert-3659587-fix-expected.checksum:
• editing/inserting/insert-3659587-fix-expected.png:
• editing/inserting/insert-3775316-fix-expected.checksum:
• editing/inserting/insert-3775316-fix-expected.png:
• editing/inserting/insert-3778059-fix-expected.checksum:
• editing/inserting/insert-3778059-fix-expected.png:
• editing/inserting/insert-3800346-fix-expected.checksum:
• editing/inserting/insert-3800346-fix-expected.png:
• editing/inserting/insert-after-delete-001-expected.checksum:
• editing/inserting/insert-after-delete-001-expected.png:
• editing/inserting/insert-at-end-01-expected.checksum:
• editing/inserting/insert-at-end-01-expected.png:
• editing/inserting/insert-at-end-02-expected.checksum:
• editing/inserting/insert-at-end-02-expected.png:
• editing/inserting/insert-br-001-expected.checksum:
• editing/inserting/insert-br-001-expected.png:
• editing/inserting/insert-br-002-expected.checksum:
• editing/inserting/insert-br-002-expected.png:
• editing/inserting/insert-br-003-expected.checksum:
• editing/inserting/insert-br-003-expected.png:
• editing/inserting/insert-br-004-expected.checksum:
• editing/inserting/insert-br-004-expected.png:
• editing/inserting/insert-br-005-expected.checksum:
• editing/inserting/insert-br-005-expected.png:
• editing/inserting/insert-br-006-expected.checksum:
• editing/inserting/insert-br-006-expected.png:
• editing/inserting/insert-br-007-expected.checksum:
• editing/inserting/insert-br-007-expected.png:
• editing/inserting/insert-br-008-expected.checksum:
• editing/inserting/insert-br-008-expected.png:
• editing/inserting/insert-br-at-tabspan-001-expected.checksum:
• editing/inserting/insert-br-at-tabspan-001-expected.png:
• editing/inserting/insert-br-at-tabspan-002-expected.checksum:
• editing/inserting/insert-br-at-tabspan-002-expected.png:
• editing/inserting/insert-br-at-tabspan-003-expected.checksum:
• editing/inserting/insert-br-at-tabspan-003-expected.png:
• editing/inserting/insert-br-quoted-001-expected.checksum:
• editing/inserting/insert-br-quoted-001-expected.png:
• editing/inserting/insert-br-quoted-002-expected.checksum:
• editing/inserting/insert-br-quoted-002-expected.png:
• editing/inserting/insert-br-quoted-003-expected.checksum:
• editing/inserting/insert-br-quoted-003-expected.png:
• editing/inserting/insert-br-quoted-004-expected.checksum:
• editing/inserting/insert-br-quoted-004-expected.png:
• editing/inserting/insert-br-quoted-005-expected.checksum:
• editing/inserting/insert-br-quoted-005-expected.png:
• editing/inserting/insert-br-quoted-006-expected.checksum:
• editing/inserting/insert-br-quoted-006-expected.png:
• editing/inserting/insert-div-025-expected.checksum:
• editing/inserting/insert-div-025-expected.png:
• editing/inserting/insert-div-026-expected.checksum:
• editing/inserting/insert-div-026-expected.png:
• editing/inserting/insert-space-in-empty-doc-expected.checksum:
• editing/inserting/insert-space-in-empty-doc-expected.png:
• editing/inserting/insert-tab-001-expected.checksum:
• editing/inserting/insert-tab-001-expected.png:
• editing/inserting/insert-tab-002-expected.checksum:
• editing/inserting/insert-tab-002-expected.png:
• editing/inserting/insert-tab-003-expected.checksum:
• editing/inserting/insert-tab-003-expected.png:
• editing/inserting/insert-tab-004-expected.checksum:
• editing/inserting/insert-tab-004-expected.png:
• editing/inserting/insert-text-at-tabspan-001-expected.checksum:
• editing/inserting/insert-text-at-tabspan-001-expected.png:
• editing/inserting/insert-text-at-tabspan-002-expected.checksum:
• editing/inserting/insert-text-at-tabspan-002-expected.png:
• editing/inserting/insert-text-at-tabspan-003-expected.checksum:
• editing/inserting/insert-text-at-tabspan-003-expected.png:
• editing/inserting/insert-text-with-newlines-expected.checksum:
• editing/inserting/insert-text-with-newlines-expected.png:
• editing/inserting/return-key-with-selection-001-expected.checksum:
• editing/inserting/return-key-with-selection-001-expected.png:
• editing/inserting/return-key-with-selection-002-expected.checksum:
• editing/inserting/return-key-with-selection-002-expected.png:
• editing/inserting/return-key-with-selection-003-expected.checksum:
• editing/inserting/return-key-with-selection-003-expected.png:
• editing/inserting/typing-001-expected.checksum:
• editing/inserting/typing-001-expected.png:
• editing/inserting/typing-002-expected.checksum:
• editing/inserting/typing-002-expected.png:
• editing/inserting/typing-003-expected.checksum:
• editing/inserting/typing-003-expected.png:
• editing/inserting/typing-around-br-001-expected.checksum:
• editing/inserting/typing-around-br-001-expected.png:
• editing/inserting/typing-around-image-001-expected.checksum:
• editing/inserting/typing-around-image-001-expected.png:
• editing/pasteboard/3976872-expected.checksum:
• editing/pasteboard/3976872-expected.png:
• editing/pasteboard/4076267-2-expected.checksum:
• editing/pasteboard/4076267-2-expected.png:
• editing/pasteboard/4076267-3-expected.checksum:
• editing/pasteboard/4076267-3-expected.png:
• editing/pasteboard/4076267-expected.checksum:
• editing/pasteboard/4076267-expected.png:
• editing/pasteboard/block-wrappers-necessary-expected.checksum:
• editing/pasteboard/block-wrappers-necessary-expected.png:
• editing/pasteboard/cut-text-001-expected.checksum:
• editing/pasteboard/cut-text-001-expected.png:
• editing/pasteboard/display-block-on-spans-expected.checksum:
• editing/pasteboard/display-block-on-spans-expected.png:
• editing/pasteboard/paste-4035648-fix-expected.checksum:
• editing/pasteboard/paste-4035648-fix-expected.png:
• editing/pasteboard/paste-4038267-fix-expected.checksum:
• editing/pasteboard/paste-4038267-fix-expected.png:
• editing/pasteboard/paste-4039777-fix-expected.checksum:
• editing/pasteboard/paste-4039777-fix-expected.png:
• editing/pasteboard/paste-line-endings-001-expected.checksum:
• editing/pasteboard/paste-line-endings-001-expected.png:
• editing/pasteboard/paste-line-endings-002-expected.checksum:
• editing/pasteboard/paste-line-endings-002-expected.png:
• editing/pasteboard/paste-line-endings-003-expected.checksum:
• editing/pasteboard/paste-line-endings-003-expected.png:
• editing/pasteboard/paste-line-endings-004-expected.checksum:
• editing/pasteboard/paste-line-endings-004-expected.png:
• editing/pasteboard/paste-line-endings-005-expected.checksum:
• editing/pasteboard/paste-line-endings-005-expected.png:
• editing/pasteboard/paste-line-endings-006-expected.checksum:
• editing/pasteboard/paste-line-endings-006-expected.png:
• editing/pasteboard/paste-line-endings-007-expected.checksum:
• editing/pasteboard/paste-line-endings-007-expected.png:
• editing/pasteboard/paste-line-endings-008-expected.checksum:
• editing/pasteboard/paste-line-endings-008-expected.png:
• editing/pasteboard/paste-line-endings-009-expected.checksum:
• editing/pasteboard/paste-line-endings-009-expected.png:
• editing/pasteboard/paste-line-endings-010-expected.checksum:
• editing/pasteboard/paste-line-endings-010-expected.png:
• editing/pasteboard/paste-list-001-expected.checksum:
• editing/pasteboard/paste-list-001-expected.png:
• editing/pasteboard/paste-match-style-001-expected.checksum:
• editing/pasteboard/paste-match-style-001-expected.png:
• editing/pasteboard/paste-match-style-002-expected.checksum:
• editing/pasteboard/paste-match-style-002-expected.png:
• editing/pasteboard/paste-pre-001-expected.checksum:
• editing/pasteboard/paste-pre-001-expected.png:
• editing/pasteboard/paste-pre-002-expected.checksum:
• editing/pasteboard/paste-pre-002-expected.png:
• editing/pasteboard/paste-table-001-expected.checksum:
• editing/pasteboard/paste-table-001-expected.png:
• editing/pasteboard/paste-text-001-expected.checksum:
• editing/pasteboard/paste-text-001-expected.png:
• editing/pasteboard/paste-text-017-expected.checksum:
• editing/pasteboard/paste-text-017-expected.png:
• editing/pasteboard/paste-text-018-expected.checksum:
• editing/pasteboard/paste-text-018-expected.png:
• editing/pasteboard/paste-text-019-expected.checksum:
• editing/pasteboard/paste-text-019-expected.png:
• editing/pasteboard/paste-text-at-tabspan-001-expected.checksum:
• editing/pasteboard/paste-text-at-tabspan-001-expected.png:
• editing/pasteboard/paste-text-at-tabspan-002-expected.checksum:
• editing/pasteboard/paste-text-at-tabspan-002-expected.png:
• editing/pasteboard/paste-text-at-tabspan-003-expected.checksum:
• editing/pasteboard/paste-text-at-tabspan-003-expected.png:
• editing/pasteboard/smart-paste-001-expected.checksum:
• editing/pasteboard/smart-paste-001-expected.png:
• editing/pasteboard/smart-paste-002-expected.checksum:
• editing/pasteboard/smart-paste-002-expected.png:
• editing/pasteboard/smart-paste-003-expected.checksum:
• editing/pasteboard/smart-paste-003-expected.png:
• editing/pasteboard/smart-paste-004-expected.checksum:
• editing/pasteboard/smart-paste-004-expected.png:
• editing/pasteboard/smart-paste-005-expected.checksum:
• editing/pasteboard/smart-paste-005-expected.png:
• editing/pasteboard/smart-paste-006-expected.checksum:
• editing/pasteboard/smart-paste-006-expected.png:
• editing/pasteboard/smart-paste-007-expected.checksum:
• editing/pasteboard/smart-paste-007-expected.png:
• editing/selection/3690703-expected.checksum:
• editing/selection/3690703-expected.png:
• editing/selection/3690719-expected.checksum:
• editing/selection/3690719-expected.png:
• editing/selection/6476-expected.checksum:
• editing/selection/6476-expected.png:
• editing/selection/after-line-wrap-expected.checksum:
• editing/selection/after-line-wrap-expected.png:
• editing/selection/end-of-document-expected.checksum:
• editing/selection/end-of-document-expected.png:
• editing/selection/expanding-selections-expected.checksum:
• editing/selection/expanding-selections-expected.png:
• editing/selection/expanding-selections2-expected.checksum:
• editing/selection/expanding-selections2-expected.png:
• editing/selection/extend-by-character-001-expected.checksum:
• editing/selection/extend-by-character-001-expected.png:
• editing/selection/extend-by-character-002-expected.checksum:
• editing/selection/extend-by-character-002-expected.png:
• editing/selection/extend-by-character-003-expected.checksum:
• editing/selection/extend-by-character-003-expected.png:
• editing/selection/extend-by-character-004-expected.checksum:
• editing/selection/extend-by-character-004-expected.png:
• editing/selection/extend-by-character-005-expected.checksum:
• editing/selection/extend-by-character-005-expected.png:
• editing/selection/extend-by-character-006-expected.checksum:
• editing/selection/extend-by-character-006-expected.png:
• editing/selection/extend-by-word-001-expected.checksum:
• editing/selection/extend-by-word-001-expected.png:
• editing/selection/extend-by-word-002-expected.checksum:
• editing/selection/extend-by-word-002-expected.png:
• editing/selection/fake-doubleclick-expected.checksum:
• editing/selection/fake-doubleclick-expected.png:
• editing/selection/fake-drag-expected.checksum:
• editing/selection/fake-drag-expected.png:
• editing/selection/iframe-expected.checksum:
• editing/selection/iframe-expected.png:
• editing/selection/image-before-linebreak-expected.checksum:
• editing/selection/image-before-linebreak-expected.png:
• editing/selection/inline-table-expected.checksum:
• editing/selection/inline-table-expected.png:
• editing/selection/leave-requested-block-expected.checksum:
• editing/selection/leave-requested-block-expected.png:
• editing/selection/move-backwords-by-word-001-expected.checksum:
• editing/selection/move-backwords-by-word-001-expected.png:
• editing/selection/move-between-blocks-no-001-expected.checksum:
• editing/selection/move-between-blocks-no-001-expected.png:
• editing/selection/move-by-character-001-expected.checksum:
• editing/selection/move-by-character-001-expected.png:
• editing/selection/move-by-character-002-expected.checksum:
• editing/selection/move-by-character-002-expected.png:
• editing/selection/move-by-character-003-expected.checksum:
• editing/selection/move-by-character-003-expected.png:
• editing/selection/move-by-character-004-expected.checksum:
• editing/selection/move-by-character-004-expected.png:
• editing/selection/move-by-character-005-expected.checksum:
• editing/selection/move-by-character-005-expected.png:
• editing/selection/move-by-character-6-expected.checksum:
• editing/selection/move-by-character-6-expected.png:
• editing/selection/move-by-line-001-expected.checksum:
• editing/selection/move-by-line-001-expected.png:
• editing/selection/move-by-line-002-expected.checksum:
• editing/selection/move-by-line-002-expected.png:
• editing/selection/move-by-word-001-expected.checksum:
• editing/selection/move-by-word-001-expected.png:
• editing/selection/previous-line-position-expected.checksum:
• editing/selection/previous-line-position-expected.png:
• editing/selection/replaced-boundaries-1-expected.checksum:
• editing/selection/replaced-boundaries-1-expected.png:
• editing/selection/replaced-boundaries-2-expected.checksum:
• editing/selection/replaced-boundaries-2-expected.png:
• editing/selection/replaced-boundaries-3-expected.checksum:
• editing/selection/replaced-boundaries-3-expected.png:
• editing/selection/select-all-001-expected.checksum:
• editing/selection/select-all-001-expected.png:
• editing/selection/select-all-002-expected.checksum:
• editing/selection/select-all-002-expected.png:
• editing/selection/select-box-expected.checksum:
• editing/selection/select-box-expected.png:
• editing/selection/selection-3748164-fix-expected.checksum:
• editing/selection/selection-3748164-fix-expected.png:
• editing/selection/triple-click-in-pre-expected.checksum:
• editing/selection/triple-click-in-pre-expected.png:
• editing/selection/unrendered-001-expected.checksum:
• editing/selection/unrendered-001-expected.png:
• editing/selection/unrendered-002-expected.checksum:
• editing/selection/unrendered-002-expected.png:
• editing/selection/unrendered-003-expected.checksum:
• editing/selection/unrendered-003-expected.png:
• editing/selection/unrendered-004-expected.checksum:
• editing/selection/unrendered-004-expected.png:
• editing/selection/unrendered-005-expected.checksum:
• editing/selection/unrendered-005-expected.png:
• editing/style/block-style-004-expected.checksum:
• editing/style/block-style-004-expected.png:
• editing/style/block-style-005-expected.checksum:
• editing/style/block-style-005-expected.png:
• editing/style/block-style-006-expected.checksum:
• editing/style/block-style-006-expected.png:
• editing/style/block-styles-007-expected.checksum:
• editing/style/block-styles-007-expected.png:
• editing/style/remove-underline-across-paragraph-expected.checksum:
• editing/style/remove-underline-across-paragraph-expected.png:
• editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
• editing/style/remove-underline-across-paragraph-in-bold-expected.png:
• editing/style/remove-underline-after-paragraph-expected.checksum:
• editing/style/remove-underline-after-paragraph-expected.png:
• editing/style/remove-underline-after-paragraph-in-bold-expected.checksum:
• editing/style/remove-underline-after-paragraph-in-bold-expected.png:
• editing/style/remove-underline-expected.checksum:
• editing/style/remove-underline-expected.png:
• editing/style/remove-underline-from-stylesheet-expected.checksum:
• editing/style/remove-underline-from-stylesheet-expected.png:
• editing/style/remove-underline-in-bold-expected.checksum:
• editing/style/remove-underline-in-bold-expected.png:
• editing/style/smoosh-styles-001-expected.checksum:
• editing/style/smoosh-styles-001-expected.png:
• editing/style/smoosh-styles-002-expected.checksum:
• editing/style/smoosh-styles-002-expected.png:
• editing/style/smoosh-styles-003-expected.checksum:
• editing/style/smoosh-styles-003-expected.png:
• editing/style/style-3681552-fix-001-expected.checksum:
• editing/style/style-3681552-fix-001-expected.png:
• editing/style/style-3681552-fix-002-expected.checksum:
• editing/style/style-3681552-fix-002-expected.png:
• editing/style/style-3690704-fix-expected.checksum:
• editing/style/style-3690704-fix-expected.png:
• editing/style/style-3998892-fix-expected.checksum:
• editing/style/style-3998892-fix-expected.png:
• editing/style/style-boundary-001-expected.checksum:
• editing/style/style-boundary-001-expected.png:
• editing/style/style-boundary-002-expected.checksum:
• editing/style/style-boundary-002-expected.png:
• editing/style/style-boundary-003-expected.checksum:
• editing/style/style-boundary-003-expected.png:
• editing/style/style-boundary-004-expected.checksum:
• editing/style/style-boundary-004-expected.png:
• editing/style/typing-style-001-expected.checksum:
• editing/style/typing-style-001-expected.png:
• editing/style/typing-style-002-expected.checksum:
• editing/style/typing-style-002-expected.png:
• editing/style/typing-style-003-expected.checksum:
• editing/style/typing-style-003-expected.png:
• editing/style/unbold-in-bold-expected.checksum:
• editing/style/unbold-in-bold-expected.png:
• editing/style/underline-expected.checksum:
• editing/style/underline-expected.png:
• editing/undo/4063751-expected.checksum:
• editing/undo/4063751-expected.png:
• editing/undo/redo-typing-001-expected.checksum:
• editing/undo/redo-typing-001-expected.png:
• editing/undo/undo-typing-001-expected.checksum:
• editing/undo/undo-typing-001-expected.png:
• editing/unsupported-content/list-delete-001-expected.checksum:
• editing/unsupported-content/list-delete-001-expected.png:
• editing/unsupported-content/list-delete-002-expected.checksum:
• editing/unsupported-content/list-delete-002-expected.png:
• editing/unsupported-content/list-delete-003-expected.checksum:
• editing/unsupported-content/list-delete-003-expected.png:
• editing/unsupported-content/list-type-after-expected.checksum:
• editing/unsupported-content/list-type-after-expected.png:
• editing/unsupported-content/list-type-before-expected.checksum:
• editing/unsupported-content/list-type-before-expected.png:
• editing/unsupported-content/table-delete-001-expected.checksum:
• editing/unsupported-content/table-delete-001-expected.png:
• editing/unsupported-content/table-delete-002-expected.checksum:
• editing/unsupported-content/table-delete-002-expected.png:
• editing/unsupported-content/table-delete-003-expected.checksum:
• editing/unsupported-content/table-delete-003-expected.png:
• editing/unsupported-content/table-type-after-expected.checksum:
• editing/unsupported-content/table-type-after-expected.png:
• editing/unsupported-content/table-type-before-expected.checksum:
• editing/unsupported-content/table-type-before-expected.png:
• fast/css/outline-auto-empty-rects-expected.checksum:
• fast/css/outline-auto-empty-rects-expected.png:
• fast/css/outline-auto-location-expected.checksum:
• fast/css/outline-auto-location-expected.png:
• fast/dom/focus-contenteditable-expected.checksum:
• fast/dom/focus-contenteditable-expected.png:
• fast/encoding/utf-16-big-endian-expected.checksum:
• fast/encoding/utf-16-big-endian-expected.png:
• fast/encoding/utf-16-little-endian-expected.checksum:
• fast/encoding/utf-16-little-endian-expected.png:
• fast/events/focusingUnloadedFrame-expected.checksum:
• fast/events/focusingUnloadedFrame-expected.png:
• fast/forms/input-appearance-focus-expected.checksum:
• fast/forms/input-appearance-focus-expected.png:
• fast/forms/input-appearance-readonly-expected.checksum: Added.
• fast/forms/input-appearance-readonly-expected.png: Added.
• fast/forms/input-appearance-selection-expected.checksum:
• fast/forms/input-appearance-selection-expected.png:
• fast/forms/input-paste-undo-expected.checksum: Added.
• fast/forms/input-paste-undo-expected.png: Added.
• fast/forms/input-text-double-click-expected.checksum:
• fast/forms/input-text-double-click-expected.png:
• fast/forms/input-text-option-delete-expected.checksum:
• fast/forms/input-text-option-delete-expected.png:
• fast/forms/input-text-scroll-left-on-blur-expected.checksum:
• fast/forms/input-text-scroll-left-on-blur-expected.png:
• fast/lists/drag-into-marker-expected.checksum:
• fast/lists/drag-into-marker-expected.png:
• fast/overflow/childFocusRingClip-expected.checksum:
• fast/overflow/childFocusRingClip-expected.png:
• fast/overflow/overflow-focus-ring-expected.checksum:
• fast/overflow/overflow-focus-ring-expected.png:
• fast/text/justified-text-rect-expected.checksum:
• fast/text/justified-text-rect-expected.png:

6:16 PM Changeset in webkit [13643] by darin

• 95 edits in trunk/LayoutTests/editing/selection

• updated layout test results, mostly for the change in focus ring appearance

6:15 PM Changeset in webkit [13642] by darin

• 90 edits in trunk/LayoutTests/editing/inserting

• updated layout test results, mostly for the change in focus ring appearance

6:14 PM Changeset in webkit [13641] by darin

• 158 edits in trunk/LayoutTests/editing/deleting

• updated layout test results, mostly for the change in focus ring appearance

6:12 PM Changeset in webkit [13640] by darin

• 33 edits
  4 adds in trunk/LayoutTests/fast

• updated layout test results, mostly for the change in focus ring appearance

6:11 PM Changeset in webkit [13639] by darin

• 23 edits in trunk/WebCore

Reviewed by Adele.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8123 focus ring on new text field doesn't look like the old one

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7685 Focus ring color should change to match graphite when system theme is graphite

• some cleanup to how we parse user agent style sheets

• css/CSSValueKeywords.in: Added -webkit-focus-ring-color.

• css/cssstyleselector.cpp: (WebCore::parseUASheet): Parse an array of chars instead of UTF-16. Cuts the size of the style sheet in half. (WebCore::CSSStyleSelector::applyProperty): Allow negative value for outline-offset. Changed shadow parsing to use getColorFromPrimitiveValue instead of repeating the same logic. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Added a case for the focus ring color.
• rendering/render_style.h: (WebCore::RenderStyle::setOutlineOffset): Changed to allow negative values.

• css/html4.css: Removed a lot of excess spaces. Changed color of focus to -webkit-focus-ring-color. Changed width of focus to 5px. Added an outline-offset for <input type=text> of -2px.

• css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added focus ring color as an outline color all the time, and as any other color when not in strict mode. I'm confused about what's best for this whole strict mode policy, and I may need advice on Hyatt to perfect this one later. (WebCore::CSSParser::parseColorFromValue): Removed code to pin r, g, and b because the functions in platform already take care of that. Kept the pinning of a, though because that's done in floating point before converting to an integer. (WebCore::CSSParser::parseShadow): Allow focus ring color when not in strict mode.

• bridge/mac/FrameMac.h: Eliminated the virtual detachFromView function.
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Eliminated code to maintain the frame instances list. (WebCore::FrameMac::~FrameMac): Ditto. (WebCore::Frame::setNeedsReapplyStyles): Added.

• bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
• platform/mac/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): Changed to call the new Page::setNeedsReapplyStylesForSettingsChange instead of using the obsolete Frame::instances.

• page/Frame.h: Removed instances, mutableInstances, and detachFromView.
• page/Frame.cpp: Ditto.

• page/FrameTree.cpp: (WebCore::FrameTree::~FrameTree): Call setView(0) instead of detachFromView(). (WebCore::FrameTree::removeChild): Ditto.

• page/Page.h:
• page/Page.cpp: (WebCore::Page::init): Added a set of pages instead of a page count. Also register a function for when the focus ring color changes the first time this is called. (WebCore::Page::~Page): Call setView(0) instead of detachFromView. Also update to manager the set of pages. (WebCore::Page::setNeedsReapplyStyles): Call setNeedsReapplyStyles on all frames. (WebCore::Page::setNeedsReapplyStylesForSettingsChange): Call setNeedsReapplyStyles on all frames with the passed-in settings.

• css/make-css-file-arrays.pl: Changed to run the C preprocessor on the input files and to generate an array of char instead of unsigned short.

• platform/PlatformString.h: Added a constructor that takes a char* and a length.
• platform/String.cpp: (WebCore::String::String): Ditto.

• WebCore.xcodeproj/project.pbxproj: Just some tweaks; adding in a few files like the user agent style sheets.

• platform/Color.h: Removed all use of DeprecatedString. Cleaned up a bit. Added focusRingColor and setFocusRingColorChangeFunction.
• platform/Color.cpp: (WebCore::makeRGB): Rewrote using max and min. (WebCore::makeRGBA): Ditto. (WebCore::parseHexColor): Cleaned up a bit; changed partway to String instead of DeprecatedString. (WebCore::Color::Color): Changed to use String and to call setNamedColor to save code. (WebCore::Color::setNamedColor): Changed to use String in the interface.

• platform/mac/ColorMac.mm: (WebCore::observeTheme): Added. Function used to start up the observer. (WebCore::setFocusRingColorChangeFunction): Added. Used to get a call back so we can update all the views when the color changes (including recomputing style to get the color change in). (WebCore::setFocusRingColorChangeFunction): Added. Returns one of the two focus ring colors. Both of these match what AppKit uses -- neither matches what we used to have in the html4.css file. (+[WebCoreControlTintObserver controlTintDidChange]): Added. Used to update when the appearance is changed from blue to graphite and back. We keep a global so we don't have to call over to AppKit every time; that's probably overkill but we need the obsever for the color change function anyway.

12:54 PM Changeset in webkit [13638] by adele

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by Darin.

• Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8118 REGRESSION (r13595): Inline block's clipped overflow increases table row height

• fast/inline-block/overflow-clip-expected.checksum: Added.
• fast/inline-block/overflow-clip-expected.png: Added.
• fast/inline-block/overflow-clip-expected.txt: Added.
• fast/inline-block/overflow-clip.html: Added.

WebCore:

Test: fast/inline-block/overflow-clip.html

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8118 REGRESSION (r13595): Inline block's clipped overflow increases table row height

• rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): Don't look at interior overflow when calculating the contribution to the inline's vertical overflows.

5:13 AM Changeset in webkit [13637] by eseidel

• 11 edits in trunk/WebCore

2006-04-02 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Make WebCore safe against KJS::Node in JavaScriptCore private headers.

• editing/ReplaceSelectionCommand.h:
• khtml/ecma/JSXMLSerializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
• khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
• khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument):
• khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNode::mark): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::toNode): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::putValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity): (KJS::toJS): (KJS::getRuntimeObject): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
• khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): (KJS::ClipboardProtoFunc::callAsFunction):
• khtml/ecma/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollection::getNamedItems): (KJS::JSHTMLSelectCollection::put):
• khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
• khtml/ecma/kjs_window.cpp: (KJS::Window::put):
• kwq/KWQPageState.mm: (-[KWQPageState WebCore::]):

4:41 AM Changeset in webkit [13636] by eseidel

• 1 edit
  1 add in trunk/JavaScriptGlue

2006-04-02 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Add missing forwarding header.

• kxmlcore/Vector.h: Added.

Apr 1, 2006:

6:41 PM Changeset in webkit [13634] by darin

• 75 edits
  6 deletes in trunk/WebCore

Reviewed by Eric.

• removed a bunch of unneeded ForwardingHeaders and WebCore+SVG headers

• ForwardingHeaders/kcanvas: Removed.
• ForwardingHeaders/kcanvas/KCanvas.h: Removed.
• ForwardingHeaders/kdom: Removed.
• ForwardingHeaders/kdom/DOMString.h: Removed.
• ForwardingHeaders/kdom/Helper.h: Removed.
• ForwardingHeaders/kdom/KDOMSettings.h: Removed.
• ForwardingHeaders/kdom/Namespace.h: Removed.
• ForwardingHeaders/kdom/cache: Removed.
• ForwardingHeaders/kdom/cache/KDOMCachedImage.h: Removed.
• ForwardingHeaders/kdom/cache/KDOMCachedObject.h: Removed.
• ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h: Removed.
• ForwardingHeaders/kdom/cache/KDOMCachedScript.h: Removed.
• ForwardingHeaders/kdom/cache/KDOMLoader.h: Removed.
• ForwardingHeaders/kdom/core: Removed.
• ForwardingHeaders/kdom/core/DOMConfiguration.h: Removed.
• ForwardingHeaders/kdom/core/DOMException.h: Removed.
• ForwardingHeaders/kdom/core/DOMList.h: Removed.
• ForwardingHeaders/kdom/core/DOMString.h: Removed.
• ForwardingHeaders/kdom/core/NamedAttrMap.h: Removed.
• ForwardingHeaders/kdom/core/ProcessingInstruction.h: Removed.
• ForwardingHeaders/kdom/core/domattrs.h: Removed.
• ForwardingHeaders/kdom/ecma: Removed.
• ForwardingHeaders/kdom/ecma/GlobalObject.h: Removed.
• ForwardingHeaders/kdom/events: Removed.
• ForwardingHeaders/kdom/events/Event.h: Removed.
• ForwardingHeaders/kdom/events/EventListener.h: Removed.
• ForwardingHeaders/kdom/events/EventTarget.h: Removed.
• ForwardingHeaders/kdom/events/KeyboardEvent.h: Removed.
• ForwardingHeaders/kdom/events/MouseEvent.h: Removed.
• ForwardingHeaders/kdom/events/UIEvent.h: Removed.
• ForwardingHeaders/kdom/events/kdomevents.h: Removed.
• ForwardingHeaders/kdom/kdom.h: Removed.
• ForwardingHeaders/kdom/parser: Removed.
• ForwardingHeaders/kdom/parser/KDOMParser.h: Removed.
• ForwardingHeaders/ksvg2: Removed.
• ForwardingHeaders/ksvg2/KSVGPart.h: Removed.
• ForwardingHeaders/ksvg2/KSVGView.h: Removed.
• ForwardingHeaders/ksvg2/css: Removed.
• ForwardingHeaders/ksvg2/css/CSSPropertyNames.h: Removed.
• ForwardingHeaders/ksvg2/css/CSSValueKeywords.h: Removed.
• WebCore+SVG/KDOMHeaders.h: Removed.
• WebCore+SVG/Namespace.h: Removed.
• WebCore+SVG/kdom.h: Removed.

• WebCore.xcodeproj/project.pbxproj: Removed headers.

• kcanvas/KCanvasCreator.cpp:
• kcanvas/KCanvasResources.cpp:
• kcanvas/KCanvasTreeDebug.cpp:
• kcanvas/RenderPath.cpp:
• kcanvas/RenderSVGImage.cpp:
• kcanvas/device/quartz/KCanvasItemQuartz.mm:
• kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
• kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
• kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
• ksvg2/css/SVGCSSStyleSelector.cpp:
• ksvg2/events/SVGZoomEvent.h:
• ksvg2/misc/KCanvasRenderingStyle.cpp:
• ksvg2/misc/KSVGTimeScheduler.cpp:
• ksvg2/misc/SVGImageLoader.cpp:
• ksvg2/svg/SVGAElement.cpp:
• ksvg2/svg/SVGAnimationElement.cpp:
• ksvg2/svg/SVGCircleElement.cpp:
• ksvg2/svg/SVGClipPathElement.cpp:
• ksvg2/svg/SVGCursorElement.cpp:
• ksvg2/svg/SVGCursorElement.h:
• ksvg2/svg/SVGDOMImplementation.cpp:
• ksvg2/svg/SVGDocument.cpp:
• ksvg2/svg/SVGDocument.h:
• ksvg2/svg/SVGElement.cpp:
• ksvg2/svg/SVGEllipseElement.cpp:
• ksvg2/svg/SVGExternalResourcesRequired.cpp:
• ksvg2/svg/SVGExternalResourcesRequired.h:
• ksvg2/svg/SVGFEBlendElement.cpp:
• ksvg2/svg/SVGFEColorMatrixElement.cpp:
• ksvg2/svg/SVGFEComponentTransferElement.cpp:
• ksvg2/svg/SVGFECompositeElement.cpp:
• ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
• ksvg2/svg/SVGFEDisplacementMapElement.cpp:
• ksvg2/svg/SVGFEFloodElement.cpp:
• ksvg2/svg/SVGFEGaussianBlurElement.cpp:
• ksvg2/svg/SVGFEImageElement.cpp:
• ksvg2/svg/SVGFEImageElement.h:
• ksvg2/svg/SVGFELightElement.cpp:
• ksvg2/svg/SVGFEMergeElement.cpp:
• ksvg2/svg/SVGFEOffsetElement.cpp:
• ksvg2/svg/SVGFESpecularLightingElement.cpp:
• ksvg2/svg/SVGFETileElement.cpp:
• ksvg2/svg/SVGFETurbulenceElement.cpp:
• ksvg2/svg/SVGFilterElement.cpp:
• ksvg2/svg/SVGGradientElement.cpp:
• ksvg2/svg/SVGHelper.cpp:
• ksvg2/svg/SVGImageElement.cpp:
• ksvg2/svg/SVGLangSpace.cpp:
• ksvg2/svg/SVGLength.cpp:
• ksvg2/svg/SVGLineElement.cpp:
• ksvg2/svg/SVGLinearGradientElement.cpp:
• ksvg2/svg/SVGList.h:
• ksvg2/svg/SVGLocatable.cpp:
• ksvg2/svg/SVGMarkerElement.cpp:
• ksvg2/svg/SVGMarkerElement.h:
• ksvg2/svg/SVGMaskElement.cpp:
• ksvg2/svg/SVGPathElement.cpp:
• ksvg2/svg/SVGPatternElement.cpp:
• ksvg2/svg/SVGPolyElement.cpp:
• ksvg2/svg/SVGPolygonElement.cpp:
• ksvg2/svg/SVGPolylineElement.cpp:
• ksvg2/svg/SVGRadialGradientElement.cpp:
• ksvg2/svg/SVGRectElement.cpp:
• ksvg2/svg/SVGSVGElement.cpp:
• ksvg2/svg/SVGStopElement.cpp:
• ksvg2/svg/SVGStyleElement.cpp:
• ksvg2/svg/SVGStyledElement.cpp:
• ksvg2/svg/SVGStyledLocatableElement.cpp:
• ksvg2/svg/SVGStyledTransformableElement.cpp:
• ksvg2/svg/SVGTextElement.cpp:
• ksvg2/svg/SVGTransformable.cpp:
• ksvg2/svg/SVGUseElement.cpp:
• ksvg2/svg/SVGViewElement.cpp: Updated includes.

5:57 PM Changeset in webkit [13633] by eseidel

• 2 edits in trunk/WebKitLibraries

2006-04-01 Eric Seidel <​eseidel@apple.com>

• libWebKitSystemInterface.a: commit a universal binary.

4:14 PM Changeset in webkit [13632] by darin

• 1 add in trunk/LayoutTests/fast/forms/input-text-scroll-left-on-blur-expected.png

Oops. File was in change log, but not in commit.

4:04 PM Changeset in webkit [13631] by darin

• 3 edits in trunk/WebCore

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8089 REGRESSION: Caret position is off in native text field with text-align:right

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8082 REGRESSION: Empty RTL text fields place the caret on the left side

Need a way to make a test for this. No obvious way at the moment.

• rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Consider border, padding, and the width of the caret properly in the calculation of the caret's X position.

• rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Fixed some similar issues and rewrote this function for clarity. However, I suspect this function was and remains broken and is almost never called.

3:35 PM Changeset in webkit [13630] by darin

• 9 edits
  3 adds in trunk

LayoutTests:

Reviewed by Justin.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8106 REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

• fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
• fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
• fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
• fast/forms/input-text-scroll-left-on-blur.html: Added.

WebCore:

Reviewed by Justin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8106 REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

Test: fast/forms/input-text-scroll-left-on-blur.html

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Pass blur events through to the RenderTextField, as well as mouse, drag, and wheel events.
• rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll all the way to the left on a blur.

• unrelated small changes

• html/HTMLTextFieldInnerElement.cpp: Removed excess includes. (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Tweaked comments a bit.

• dom/Element.cpp: (WebCore::Element::scrollIntoView): Removed unneeded this-> before function call. (WebCore::Element::scrollIntoViewIfNeeded): Ditto.

• page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): Removed obsolete comment.

WebKitTools:

Reviewed by Justin.

• DumpRenderTree/EventSendingController.m: (-[EventSendingController keyDown:withModifiers:]): Fixed keyDown function so that it will work if you don't pass an array of modifiers or if elements in that array are not strings.

2:27 PM Changeset in webkit [13629] by darin

• 2 edits in trunk/WebKitLibraries

Reviewed by Beth.

• libWebKitSystemInterface.a: Changed alpha in the focus-ring drawing code to use the system default alpha.

12:59 PM Changeset in webkit [13628] by mjs

• 1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Ooops, actually land the fix with this ChangeLog entry:

2006-03-31 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adele.

<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into an empty editable subtree.

11:39 AM Changeset in webkit [13627] by darin

• 62 edits in trunk/LayoutTests

• re-updated many pixel results to try to create a new baseline

2:14 AM Changeset in webkit [13626] by mjs

• 2 edits
  2 adds in trunk

LayoutTests:

Test cases for:

<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

• fast/forms/input-paste-undo-expected.txt: Added.
• fast/forms/input-paste-undo.html: Added.

WebCore:

Reviewed by Adele.

<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into an empty editable subtree.

1:40 AM Changeset in webkit [13625] by darin

• 4 edits
  4 adds in trunk

LayoutTests:

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8063 REGRESSION: double clicking in new text fields won't select whole words

• fast/forms/input-text-double-click-expected.checksum: Added.
• fast/forms/input-text-double-click-expected.png: Added.
• fast/forms/input-text-double-click-expected.txt: Added.
• fast/forms/input-text-double-click.html: Added.

WebCore:

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8063 REGRESSION: double clicking in new text fields won't select whole words

Test: fast/forms/input-text-double-click.html

• editing/visible_units.cpp: (WebCore::nextBoundary): Set the end of the range by calling selectNodeContents rather than by calling setEndAfter. The problem with setEndAfter is that it doesn't do anything when the parent of the node is 0, and also it's not really what we want, since the boundary node is one with editable contents -- we want to stay inside the boundary node.

• editing/Selection.cpp: (WebCore::Selection::validate): Fix a tiny formatting glitch I noticed at the same time.

1:32 AM Changeset in webkit [13624] by darin

• 3 edits
  4 adds in trunk

LayoutTests:

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8105 REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

• fast/forms/input-text-option-delete-expected.checksum: Added.
• fast/forms/input-text-option-delete-expected.png: Added.
• fast/forms/input-text-option-delete-expected.txt: Added.
• fast/forms/input-text-option-delete.html: Added.

WebKit:

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8105 REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

Test: fast/forms/input-text-option-delete.html

• WebView/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Pass NO for smartDeleteOK. Smart deletion only applies to deleting a word at a time, and none of the callers of this function that delete a word at a time want smart deletion. (-[WebHTMLView deleteToEndOfLine:]): Fixed tiny formatting glitch.