⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 4, 2006:

11:42 PM Changeset in webkit [13761] by eseidel
  • 1 edit in branches/temp-tree-code/trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Make svn ignore xcode internal files

11:41 PM Changeset in webkit [13760] by eseidel
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

roll evaluateList into the loop, fix exception handling

8:55 PM Changeset in webkit [13699] by darin
  • 10 edits
    1 delete in trunk

LayoutTests:

Reviewed by Justin and Adele.

  • fast/forms/plaintext-mode-2-expected.txt: Updated because there's no longer and extra <div> element added.

WebCore:

Reviewed by Justin (editing parts) and Adele (the rest).

The smart paste code was getting confused and adding extra spaces.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isStartOfParagraph instead of isStartOfLine. (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::enclosingEmptyListItem): Change to call isStart/EndOfParagraph instead of Line.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Add a comment about how isStartOfLine is almost certainly wrong here.
  • clean up some loose ends in the Frame class from the recent renaming
  • page/Frame.h: Removed declarations of deleteMe1, deleteMe2, and handleMouseMoveEventPart2.
  • page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): Removed handleMouseMoveEventPart2 by renaming it to handleMouseMoveEvent and removing handleMouseMoveEvent itself.
  • invoke the makefile directly, removing the generate-derived-sources script
  • WebCore.vcproj/WebCore/build-generated-files.sh: Call make directly.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • generate-derived-sources: Removed.
7:26 PM Changeset in webkit [13698] by hyatt
  • 2 edits in trunk/LayoutTests/tables

Update table results after my change to create fewer RenderTexts.

7:19 PM Changeset in webkit [13697] by hyatt
  • 14 edits in trunk/LayoutTests/fast

Update fast results after my change to create fewer RenderTexts.

7:06 PM Changeset in webkit [13696] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

  • editing/selection/caret-rtl-expected.checksum: Added.
  • editing/selection/caret-rtl-expected.png: Added.
  • editing/selection/caret-rtl-expected.txt: Added.
  • editing/selection/caret-rtl.html: Added.
  • editing/selection/caret-rtl-2-expected.checksum: Added.
  • editing/selection/caret-rtl-2-expected.png: Added.
  • editing/selection/caret-rtl-2-expected.txt: Added.
  • editing/selection/caret-rtl-2.html: Added.

WebCore:

Reviewed by Justin.

Tests:
editing/selection/caret-rtl.html
editing/selection/caret-rtl-2.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): When calculating the position for the beginning or end of an InlineTextBox, we now use offsetForPosition instead of just using m_start and m_len, because offsetForPosition will take rtl text into account. I also made some formatting changes.
6:49 PM Changeset in webkit [13695] by adele
  • 2 edits in trunk/LayoutTests

New results for

  • fast/forms/input-truncate-newline-expected.txt

Filed bug:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8187
input-truncate-newline layout test fails when run as part of larger set of tests

5:47 PM Changeset in webkit [13759] by ggaren
  • 1 add in branches/temp-tree-code/trunk/JavaScriptCore/kjs/NodeType.h

forgot this file

5:47 PM Changeset in webkit [13758] by ggaren
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore

converted all executes to giant switch statement -- nothing is integrated with the evaluate loop yet, but it builds and passes all the tests

4:47 PM Changeset in webkit [13694] by thatcher
  • 1 move in tags/JavaScriptCore-521.9.1/JavaScriptCore

Correct place.

4:47 PM Changeset in webkit [13693] by thatcher
  • 1 add in tags/JavaScriptCore-521.9.1

New tag.

4:46 PM Changeset in webkit [13692] by thatcher
  • 1 move in tags/JavaScriptCore-521.9.1-temp

Move. This was in the wrong place.

4:42 PM Changeset in webkit [13691] by thatcher
  • 5 edits in tags/JavaScriptCore-521.9.1

Reviewed by Adele.

Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
Other 64 bit build fixes.

  • kjs/collector.cpp: (KJS::Collector::markOtherThreadConservatively): test for DARWIN_UNIX03 and use r1
  • kjs/dtoa.cpp: (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
4:34 PM Changeset in webkit [13690] by thatcher
  • 1 copy in tags/JavaScriptCore-521.9.1

new tag.

4:34 PM Changeset in webkit [13689] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8065, inline blocks incorrectly loses spaces between them.

Reviewed by beth

  • dom/Text.cpp: (WebCore::Text::rendererIsNeeded):
3:23 PM Changeset in webkit [13688] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
REGRESSION (NativeTextField): table contents misaligned in Netflix queue

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
REGRESSION: Native text field fails to wrap inside table

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
REGRESSION: text fields at connect.apple.com spill out of the containing box

  • fast/forms/input-table-expected.checksum: Added.
  • fast/forms/input-table-expected.png: Added.
  • fast/forms/input-table-expected.txt: Added.
  • fast/forms/input-table.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
REGRESSION: Native text field fails to wrap inside table

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
REGRESSION: text fields at connect.apple.com spill out of the containing box

Test: fast/forms/input-table.html

Rewrote calcMinMaxWidth for text fields so it considers width,
min-width, and max-width settings as well as the size attribute.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
3:11 PM Changeset in webkit [13687] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Darin.

This is a followup to my fix for <rdar://problem/4493218>


This patch re-names computeIntLength() and computerShortLength() to
be computeLengthInt() and computeLengthShort(), respectively, to
match the pre-existing computeLengthFloat(). This patch also adds
the slightly confusing-ly named computeLengthIntForLength() which
uses the max and min values of a 28-bit integer as bounds for
overflow. This function is necessary because Length objects expect
28-bit integers.

2:21 PM Changeset in webkit [13686] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

JavaScriptGlue:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • WebKit.xcodeproj/project.pbxproj:
1:52 PM Changeset in webkit [13685] by justing
  • 17 edits
    12 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting

Added:

  • editing/deleting/merge-different-styles-expected.checksum: Added.
  • editing/deleting/merge-different-styles-expected.png: Added.
  • editing/deleting/merge-different-styles-expected.txt: Added.
  • editing/deleting/merge-different-styles.html: Added.
  • editing/deleting/merge-no-br-expected.checksum: Added.
  • editing/deleting/merge-no-br-expected.png: Added.
  • editing/deleting/merge-no-br-expected.txt: Added.
  • editing/deleting/merge-no-br.html: Added.
  • editing/deleting/merge-whitespace-pre-expected.checksum: Added.
  • editing/deleting/merge-whitespace-pre-expected.png: Added.
  • editing/deleting/merge-whitespace-pre-expected.txt: Added.
  • editing/deleting/merge-whitespace-pre.html: Added.

Fixes (not enough style on nodes for the fixes to be reflected in pixel results):

  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:

Equivalent render trees:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:


Forgot to checkin these new expected results after fixing the DRT bug:

  • fast/lists/drag-into-marker-expected.checksum:
  • fast/lists/drag-into-marker-expected.png:
  • fast/lists/drag-into-marker-expected.txt:

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting


Rewrote moveNodesAfterNode to address these problems:
It moved nodes without preserving their style.
It traversed over siblings looking for a br to know when
to stop merging. If the br was burried inside a span, it
wouldn't find it. If the text is whitespace:pre, it wouldn't
stop.
In theory it would crash if the "enclosingInlineElements" of the start of the
selection to delete and the end of the selection to delete were the
same. We think that this will fix these:
<rdar://problems/3950559&4498113>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
But we haven't been able to construct a reproducible case.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand. (WebCore::CompositeEditCommand::prune): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/DeleteSelectionCommand.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::):
  • editing/markup.cpp: (WebCore::createMarkup): Was crashing when passed a collapsed range. I early return an empty string instead.
11:10 AM Changeset in webkit [13684] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix win32 build.
Disable ASSERT redefinition warnings for now.

10:48 AM Changeset in webkit [13683] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • WebKit part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
  • WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Pass private browsing setting down to WebCore.
10:47 AM Changeset in webkit [13682] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Adele Peterson.


  • WebCore part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setPrivateBrowsingEnabled:]): (-[WebCoreSettings privateBrowsingEnabled]): Teach WebCoreSettings about private browsing (WebKit knew, but WebCore didn't)


  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::privateBrowsingEnabled): (KHTMLSettings::setPrivateBrowsingEnabled): Teach KHTMLSettings about private browsing


  • kwq/KWQLineEdit.mm: Fix wrong class in a category method declaration; the compiler didn't seem to mind.


  • kwq/WebCoreTextField.mm: (-[KWQSearchFieldCell _addStringToRecentSearches:]): Override this method to bail out if private browsing is enabled.
9:15 AM Changeset in webkit [13681] by darin
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7951
REGRESSION: Safari crashes when printing a google map w/directions

Tests: none, because I believe it only happens when printing, due to the relayouts

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSectionsIfNeeded): Add new utility to let the cells ensure the sections' grid data is up to date.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::calcMinMaxWidth): Call above method.
5:11 AM Changeset in webkit [13680] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-04-04 Bjrn Graf <​bjoern.graf@gmail.com>

Reviewed by ggaren & darin. Landed by eseidel.

Integrate CURL version of gettimeofday
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7399
Disable crash report dialogs for testkjs.exe in Release mode
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8113

  • kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS): (main): (kjsmain):
4:54 AM Changeset in webkit [13679] by eseidel
  • 2 edits in trunk/WebCore

2006-04-03 Justin Haygood <​jhaygood@spsu.edu>

Reviewed by eseidel. Landed by eseidel.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollBars):
4:48 AM Changeset in webkit [13678] by eseidel
  • 3 edits in trunk/WebCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Work-around spaces-in-pathnames issue in gnumake on win32.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8173

  • WebCore.vcproj/WebCore/build-generated-files.sh:
3:08 AM Changeset in webkit [13677] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): remove trunc() to fix win32.
2:03 AM Changeset in webkit [13676] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • kjs/number_object.cpp: (intPow10): Compute integer powers of 10 using exponentiation by squaring. (NumberProtoFunc::callAsFunction): Use intPow10(n) in place of all pow(10.0, n), plus a bit of refactoring.

Apr 3, 2006:

11:54 PM Changeset in webkit [13675] by darin
  • 3 edits in trunk/WebCore
  • tried to fix build again
  • WebCore.xcodeproj/project.pbxproj: Removed JSStyleSheet files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
11:30 PM Changeset in webkit [13674] by darin
  • 56 edits in trunk/WebCore
  • fixed properties on a bunch of files (removed allow-tabs and svn:executable from many)
  • css/css_base.cpp:
  • html/html_headimpl.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • kwq/DeprecatedPtrListImpl.cpp:
  • kwq/DeprecatedValueListImpl.cpp:
  • loader/CachedScript.h:
  • platform/ArrayImpl.cpp:
  • platform/StringImpl.cpp:
  • rendering/DataRef.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/bidi.h:
  • rendering/render_list.cpp:
  • rendering/render_style.cpp:
  • rendering/table_layout.h: Converted tabs to spaces.
10:21 PM Changeset in webkit [13673] by ap
  • 8 edits
    12 adds in trunk

Reviewed by Darin.

Tests: fast/css/invalidation-errors.html

fast/css/invalidation-errors-2.html
fast/css/invalidation-errors-3.html

  • css/CSSGrammar.y: Rollback the properties added by parseValue() when it returns false.
  • css/cssparser.h: Moved shorthand counting to ShorthandScope, a new class in cssparser.cpp.
  • css/cssparser.cpp: (WebCore::CSSParser::rollbackLastProperties): Added. (WebCore::CSSParser::parseValue): Return false if there are too many properties in the list. (WebCore::CSSParser::parseBackgroundShorthand): Use ShorthandScope. (WebCore::CSSParser::parseShorthand): Ditto. (WebCore::CSSParser::parse4Values): Ditto.
9:47 PM Changeset in webkit [13672] by thatcher
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Bumping the PLT count back to 5.

9:07 PM Changeset in webkit [13671] by darin
  • 4 edits
    1 delete in trunk/WebCore
  • changed StyleSheet back to hand-generated since the generated toJS function was not making the right type of wrapper for CSS style sheets (fixes failing layout tests)
  • DerivedSources.make: Removed JSStyleSheet.h.
  • css/StyleSheet.idl: Removed.
  • khtml/ecma/kjs_css.cpp: Added DOMStyleSheet back in.
  • khtml/ecma/kjs_css.h: Ditto.
8:55 PM Changeset in webkit [13670] by darin
  • 3 edits in trunk/JavaScriptCore
  • tweak config.h and Platform.h to try to get buildbot working (making some small changes at the same time)
  • kjs/config.h: Removed now-unneeded HAVE_ICU.
  • kxmlcore/Platform.h: Tweak how platform gets set up. Move all the USE stuff to the end.
8:34 PM Changeset in webkit [13669] by darin
  • 2 edits in trunk/WebCore
  • fixed Macintosh build
  • WebCore.xcodeproj/project.pbxproj: Fixed paths of some files that were absolute paths from my machine.
8:14 PM Changeset in webkit [13668] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Add three new generated files as source files.
7:45 PM Changeset in webkit [13667] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix Win32 build breakage and remove an unused forward.

6:54 PM Changeset in webkit [13666] by darin
  • 7 edits in trunk

LayoutTests:

  • add a test of RTL to the test for bug 8106
  • fast/forms/input-text-scroll-left-on-blur-expected.png: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum: Updated.
  • fast/forms/input-text-scroll-left-on-blur.html: Updated.

WebCore:

Reviewed by Maciej.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll to the right if RTL.
6:50 PM Changeset in webkit [13665] by darin
  • 6 edits
    4 adds in trunk/WebCore

Reviewed by Maciej.

  • DerivedSources.make: Added.
  • css/CSSPrimitiveValue.idl: Added.
  • css/Counter.idl: Added.
  • css/StyleSheet.idl: Added.
  • WebCore.xcodeproj/project.pbxproj: Added new generated files, IDLs, and the makefile.
  • bindings/scripts/CodeGeneratorJS.pm:
  • generate-derived-sources: Added license header. Removed most of the script, except for a single invocation of make.
  • khtml/ecma/kjs_css.h: Removed DOMStyleSheet, DOMCSSPrimitiveValue, CSSPrimitiveValueConstructor, and DOMCounter.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): Changed to use JSStyleSheet as the base class. (KJS::DOMCSSStyleSheet::getOwnPropertySlot): Ditto. (KJS::DOMCSSValueProtoFunc::callAsFunction): Added. (KJS::toJS): Changed to use JSCSSPrimitiveValue. (KJS::DOMRGBColor::getValueProperty): Changed to call toJS instead of making a DOMCSSPrimitiveValue directly.
5:30 PM Changeset in webkit [13757] by eseidel
  • 5 edits
    1 copy
    1 add in branches/temp-tree-code/trunk/JavaScriptCore

Initial commit

4:58 PM Changeset in webkit [13664] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
A drag and drop in DumpRenderTree copies the source, instead of cutting it

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum: Added.
  • editing/pasteboard/drag-drop-modifies-page-expected.png: Added.
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
  • editing/pasteboard/drag-drop-modifies-page.html: Added.

Updated:

  • fast/lists/drag-onto-marker.html:
  • fast/lists/drag-onto-marker-expected.txt:
  • fast/lists/drag-onto-marker-expected.png:
  • fast/lists/drag-onto-marker-expected.checksum:

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page


The frame's selection is only set after all sub-commands have been
performed. When we send the khtmlBeforeTextInsertedEvent to the root
editable element we were using frame->selection(), which may no longer
be in the document.


Had to move the construction of the ReplacementFragment to when the
replace operation is applied, because endingSelection isn't the
endingSelection of the last operation when the replace operation
is constructed.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:

WebKitTools:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
A drag and drop in DumpRenderTree copies the source, instead of cutting it


Tell the source that the drag is over after the drag is performed, not before.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]):
4:49 PM Changeset in webkit [13663] by staikos
  • 5 edits
    9 adds in trunk/JavaScriptCore

Reviewed by Maciej.

Implement a unicode abstraction layer to make JavaScriptCore much more
easily ported to other platforms without having to take in libicu. Also
makes the unicode related code easier to understand.

4:46 PM Changeset in webkit [13662] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4495644> crash when mousing over
links at nationalrealestateinvestors.com in
WebCore::RenderBlock::findNextLineBreak

4:17 PM Changeset in webkit [13661] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.


  • re-fixed <rdar://problem/4481198> REGRESSION (TOT): search results list in bookmarks view remains when search text is deleted
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): I fixed this recently, but then broke it again by adding an early bail-out to this method. So now I'm removing the early bail-out.
4:08 PM Changeset in webkit [13756] by eseidel
  • 1502 adds in branches/temp-tree-code

initial import

3:30 PM Changeset in webkit [13660] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4495644> crash when mousing over links at
nationalrealestateinvestors.com in
WebCore::RenderBlock::findNextLineBreak

This is a fix for a repro crasher where a rootLineBox had a stale
pointer to a render object.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild): Only break from the function because of selfNeedsLayout() if we are not an inline flow, because if we are, we will not re-layout before bad things can happen.
3:26 PM Changeset in webkit [13659] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Removing idl files and some scripts from the WebCore target to prevent
them from being copied into the Resources.

  • WebCore.xcodeproj/project.pbxproj:
3:06 PM Changeset in webkit [13658] by thatcher
  • 5 edits in trunk/JavaScriptCore

Reviewed by Adele.

Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
Other 64 bit build fixes.

  • kjs/collector.cpp: (KJS::Collector::markOtherThreadConservatively): test for DARWIN_UNIX03 and use r1
  • kjs/dtoa.cpp: (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
2:58 PM Changeset in webkit [13657] by hyatt
  • 10 edits in trunk/WebCore

Win32 theme work. Bug 8162. r=anders

2:55 PM Changeset in webkit [13656] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

  • fast/dom/Element/offsetTop-table-cell-expected.txt: Added.
  • fast/dom/Element/offsetTop-table-cell.html: Added.

WebCore:

Reviewed by Beth.

Test: fast/dom/Element/offsetTop-table-cell.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop): Skip table rows when adding up the offsets, since a table cell's yPos() is relative to the table section, not the row.
2:42 PM Changeset in webkit [13655] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/inline-block-overflow-expected.png: Added.
  • fast/repaint/layer-outline-expected.checksum: Added.
  • fast/repaint/layer-outline-expected.png: Added.
  • fast/repaint/layer-outline-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal-expected.checksum: Added.
  • fast/repaint/layer-outline-horizontal-expected.png: Added.
  • fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal.html: Added.
  • fast/repaint/layer-outline.html: Added.

WebCore:

Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Use the outlineRect for the outline phase and do it only if the outlineRect isn't empty. (WebCore::RenderLayer::calculateRects): Actually add the outline width to the outline rect.
2:14 PM Changeset in webkit [13654] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Justin.

  • fast/forms/input-truncate-newline-expected.txt: Added.
  • fast/forms/input-truncate-newline.html: Added.

WebCore:

Reviewed by Justin.

Test: fast/forms/input-truncate-newline.html

  • html/HTMLInputElement.cpp: (WebCore::minPosition): Added helper function. (WebCore::HTMLInputElement::defaultEventHandler): Searches for /r or /n and truncates the text to be inserted to the earliest newline.
10:46 AM Changeset in webkit [13653] by ap
  • 2 edits in trunk/WebCore

Fixed a comment (forgot to save the file before the previous commit).

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
9:36 AM Changeset in webkit [13652] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: http/tests/xmlhttprequest/methods-lower-case.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): Uppercase some HTTP method names, to match a Firefox quirk. (WebCore::XMLHttpRequest::send): Account for the above change.
9:28 AM Changeset in webkit [13651] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): When an element changes size, the delta rectangles that need to be invalidated must be inflated by the outline size to ensure that the previous outline is erased, and the space where the new outline is to be drawn is also invalidated. This behaviour is identical to the behaviour of borders that was fixed in bug 6301.
  • manual-tests/outline-repaint-glitch.html: Added. Manual testcase. This is just an outline version of border-repaint-glitch.html
9:25 AM Changeset in webkit [13650] by darin
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Adding tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed
and ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

In addition I tweaked the httpd conf file to allow us to exec perl CGI scripts.

  • http/conf/httpd.conf:
  • http/tests/misc/error404-expected.checksum: Added.
  • http/tests/misc/error404-expected.png: Added.
  • http/tests/misc/error404-expected.txt: Added.
  • http/tests/misc/error404.pl: Added.
  • http/tests/misc/iframe404-expected.checksum: Added.
  • http/tests/misc/iframe404-expected.png: Added.
  • http/tests/misc/iframe404-expected.txt: Added.
  • http/tests/misc/iframe404.html: Added.

WebCore:

Reviewed by Maciej.

Support for fixing ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge currentForm]): Nuke redundant nil check. (-[WebCoreFrameBridge frameElement]): Tweak to not rely on our document, which gives a correct result even at the start of our loading process.
  • bindings/objc/DOM.mm: (-[DOMDocument _ownerElement]): Nuke redundant nil check.

WebKit:

Reviewed by Maciej.

fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed

  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): Only cancel failed loads for object elements, not for frames or a whole page.
9:04 AM Changeset in webkit [13649] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • page/Frame.cpp: (WebCore::Frame::reparseConfiguration): Added back updateStyleSelector call that was removed as part of the patch for bug 7907.
12:06 AM Changeset in webkit [13648] by mjs
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Tests for:

  • fast/forms/focus-control-to-page-expected.txt: Added.
  • fast/forms/focus-control-to-page.html: Added.

WebCore:

Reviewed by Hyatt.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame):
  • bridge/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Hyatt.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willMakeFirstResponderForNodeFocus]): New method
  • let WebHTMLView know that the next time it becomes first responder, it's to change focus within the page and the right node has already been set, so it should not move focus forward or backward inside it.
  • WebView/WebHTMLView.m: (-[NSArray needsPanelToBecomeKey]): Override to return YES, oddly enough this is the right way to tell AppKit that you should be in the tab cycle loop. (-[NSArray becomeFirstResponder]): Don't move forward or back in tab cycle when this becomeFirstResponder is for tabbing from a control in the page. (-[WebHTMLView _willMakeFirstResponderForNodeFocus]): Note that the next time this view becomes first responder, it will be for in-page focus navigation.
  • WebView/WebHTMLViewInternal.h:
Note: See TracTimeline for information about the timeline view.