⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 6, 2006:

11:51 PM Changeset in webkit [13784] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fix try/catch and forIn unwind handling as well as error throwing

10:34 PM Changeset in webkit [13783] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs
10:25 PM Changeset in webkit [13782] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

fix AssignDotNodeEvaluateState

10:13 PM Changeset in webkit [13781] by ggaren
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

loops work now -- mostly :)

9:52 PM Changeset in webkit [13724] by darin
  • 1 edit in trunk/WebKitTools/WebKitLauncher/WebKitLauncher.xcodeproj

Add the ignore property for inside this project.

9:06 PM Changeset in webkit [13780] by eseidel
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

make value returns use a single value instead of the stack

6:21 PM Changeset in webkit [13779] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

trying to find value leak

5:02 PM Changeset in webkit [13778] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

Fix returns and completions

2:10 PM Changeset in webkit [13777] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

add printStacks()

2:09 PM Changeset in webkit [13776] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/completion.h

prevent the All completion mask from matching Scope, since Scope isn't a real completion

1:53 PM Changeset in webkit [13775] by ggaren
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/internal.cpp

unwind barrier debug print function was using the wrong variable

1:46 PM Changeset in webkit [13774] by ggaren
  • 1 add in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.h

forgot to add this file

1:44 PM Changeset in webkit [13773] by ggaren
  • 7 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore

random bug fixes, value stack printouts are now more informative

12:36 PM Changeset in webkit [13772] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

integrated for-in loop. everything compiles, but we still die bbadbeef-style on all js runs.

11:45 AM Changeset in webkit [13723] by bdakin
  • 9 edits
    4 adds in trunk

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8203
REGRESSION: "Invite a friend" text field in GMail page spills out
of table

RenderReplaced::calcMinMaxWidth() sets m_minWidth to 0 when the
width is a percent, so this patch copies that behavior into
RenderTextField::calcMinMaxWidth().

4:06 AM Changeset in webkit [13771] by eseidel
  • 3 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

the beast

3:29 AM Changeset in webkit [13770] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

make ReferenceList iterators hold on to their lists so that we can keep an iterator stack without having the underlying lists get destroyed

1:58 AM Changeset in webkit [13769] by eseidel
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

add node stack and forIn

12:37 AM Changeset in webkit [13768] by eseidel
  • 5 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

go ggaren go

12:26 AM Changeset in webkit [13722] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Add JSDocument.cpp.
12:23 AM Changeset in webkit [13721] by darin
  • 5 edits in trunk/WebKitTools

Changes requested by Mark Rowe.

  • BuildSlaveSupport/build-launcher-app: Set executable bit, removed property change trash at the end of the file.
  • BuildSlaveSupport/build-launcher-dmg: Ditto.
  • WebKitLauncher/main.m: Removed trash at end of file.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Let Xcode update comments to make name match.
12:11 AM Changeset in webkit [13720] by darin
  • 4 edits in trunk/LayoutTests
  • regenerated test results
  • fast/forms/input-table-expected.txt: Regenerated. Seems right, matches Gecko.
  • fast/forms/form-element-geometry-expected.png: Regenerated.
  • fast/forms/form-element-geometry-expected.checksum: Regenerated.
12:02 AM Changeset in webkit [13719] by darin
  • 3 edits in trunk/JavaScriptCore
  • attempt to fix Windows build
  • kxmlcore/HashMap.h: (KXMLCore::HashMap::remove): Use (*it). instead of it->.
  • kxmlcore/HashSet.h: (KXMLCore::HashSet::remove): Ditto.

Apr 5, 2006:

11:41 PM Changeset in webkit [13718] by darin
  • 2 edits in trunk/LayoutTests
  • fast/forms/input-truncate-newline-expected.txt: Restored good expected results.
11:07 PM Changeset in webkit [13717] by darin
  • 2 edits in trunk/JavaScriptCore
  • attempt to fix Windows build
  • os-win32/stdint.h: Add int8_t, uint8_t, int64_t.
11:01 PM Changeset in webkit [13716] by darin
  • 2 edits in trunk/WebKit
  • fixed a storage leak from that last check-in
  • WebView/WebUnarchivingState.m: (-[WebUnarchivingState dealloc]): Release the two dictionaries.
10:57 PM Changeset in webkit [13715] by darin
  • 19 edits
    5 adds in trunk

LayoutTests:

Reviewed by Adele.

  • updated results for improved dumping of selection location in DumpRenderTree
  • fast/forms/input-text-self-emptying-click-expected.checksum: Added.
  • fast/forms/input-text-self-emptying-click-expected.png: Added.
  • fast/forms/input-text-self-emptying-click-expected.txt: Added.
  • fast/forms/input-text-self-emptying-click.html: Added.
  • editing/selection/3690703-2-expected.txt: Updated.
  • fast/forms/input-appearance-focus-expected.txt: Updated.
  • fast/forms/input-appearance-readonly-expected.txt: Updated.
  • fast/forms/input-appearance-selection-expected.txt: Updated.
  • fast/forms/input-paste-undo-expected.txt: Updated.
  • fast/forms/input-text-double-click-expected.txt: Updated.
  • fast/forms/input-text-option-delete-expected.txt: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
  • fast/forms/plaintext-mode-2-expected.txt: Updated.

WebCore:

Reviewed by Adele.

Test: fast/forms/input-text-self-emptying-click.html

  • page/MouseEventWithHitTestResults.h: Removed url, target, m_url and m_target, replacing them with isOverLink and m_isOverLink. Replaced innerNode with targetNode, and added logic to handle the case where the target node is removed from the document but the element the target node was in is still inside the document.
  • page/MouseEventWithHitTestResults.cpp: Added.
  • WebCore.xcodeproj/project.pbxproj: Added MouseEventWithHitTestResults.cpp.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • kwq/RenderTreeAsText.cpp: (nodePosition): Added a call to shadowParentNode so we correctly dump positions within shadow trees. This was needed to give a good result from my new test for this bug.
  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent): Update to pass fewer parameters to the constructor for MouseEventWithHitTestResults. Now takes isOverLink boolean, and no longer takes href and target parameters.
  • page/Frame.cpp: (WebCore::Frame::handleMousePressEventDoubleClick): Use new name targetNode, instead of old name innerNode. (WebCore::Frame::handleMousePressEventTripleClick): Ditto. (WebCore::Frame::handleMousePressEventSingleClick): Ditto. Also change code to check if over a link to use !isOverLink instead of url.isNull. (WebCore::Frame::handleMousePressEvent): Ditto. Also remove unused "url" local variable. (WebCore::Frame::handleMouseMoveEvent): Ditto. (WebCore::Frame::handleMouseReleaseEvent): Ditto. (WebCore::Frame::passWidgetMouseDownEventToWidget): Ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMousePressEvent): Use new name targetNode, instead of old name innerNode. (WebCore::FrameMac::handleMouseMoveEvent): Ditto. (WebCore::FrameMac::passSubframeEventToSubframe): Ditto. (WebCore::FrameMac::sendContextMenuEvent): Ditto.
  • page/FrameView.cpp: (WebCore::subframeForEvent): Use new name targetNode, instead of old name innerNode. (WebCore::FrameView::handleMousePressEvent): Ditto. (WebCore::FrameView::handleMouseDoubleClickEvent): Ditto. (WebCore::selectCursor): Ditto. Also change code to check if over a link to use isOverLink instead of !url.isNull. (WebCore::FrameView::handleMouseMoveEvent): Ditto. (WebCore::FrameView::handleMouseReleaseEvent): Ditto. (WebCore::FrameView::updateDragAndDrop): Ditto.
9:49 PM Changeset in webkit [13714] by mjs
  • 7 edits
    2 adds in trunk/WebKit

Reviewed by Eric.



  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addToUnarchiveState:]): (-[WebDataSource _popSubframeArchiveWithName:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource subresourceForURL:]):
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]):
  • WebView/WebFramePrivate.h:
  • WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation loadArchive]):
  • WebView/WebUnarchivingState.h: Added.
  • WebView/WebUnarchivingState.m: Added. (-[WebUnarchivingState init]): (-[WebUnarchivingState addArchive:]): (-[WebUnarchivingState archivedResourceForURL:]): (-[WebUnarchivingState popSubframeArchiveWithFrameName:]):
9:44 PM Changeset in webkit [13713] by mjs
  • 2 edits in trunk

Fixed date in ChangeLog entries for last checkin.

9:40 PM Changeset in webkit [13712] by mjs
  • 4 edits in trunk

LayoutTests:

Reviewed and landed by Maciej.

  • fast/clip/outline-overflowClip-expected.txt: Reverted to the correct expected result.

WebCore:

Reviewed and landed by Maciej.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Reverted this part of the fix for bug 7943. The outlineRect should not be inflated.
9:36 PM Changeset in webkit [13711] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Reviewed by Eric, landed by Maciej.

  • svg/custom/class-selector.svg: Added.

WebCore:

Reviewed by Eric, landed by Maciej.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7627:
SVG from the W3C SVG 1.1 test suite (cubic01.svg) renders as all black

Fix this svg stylesheet to use strict-mode, as this makes sure
class selecting is done correctly.

  • ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
9:14 PM Changeset in webkit [13710] by mjs
  • 3 edits
    10 adds in trunk/WebKitTools

Reviewed by Darin, landed by Maciej.

  • BuildSlaveSupport/build-launcher-app: Added. Builds WebKit.app from WebKitLauncher and bundles the WebKit frameworks inside it.
  • BuildSlaveSupport/build-launcher-dmg: Added. Builds, and optionally uploads, a disk image containing WebKit.app.
  • BuildSlaveSupport/run-performance-tests: Use currentSVNRevision.
  • Scripts/webkitdirs.pm: Add currentSVNRevision to retrieve the revision number of the SVN working copy.
  • WebKitLauncher: Added.
  • WebKitLauncher/Info.plist: Added.
  • WebKitLauncher/WebKitLauncher.xcodeproj: Added.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Added.
  • WebKitLauncher/WebKitNightlyEnabler.m: Added. This makes up the WebKitNightlyEnabler dylib which is loaded into Safari's address space to cause LaunchServices to treat Safari.app as WebKit.app when it is run from the nightly launcher.
  • WebKitLauncher/main.m: Added. The WebKit.app launcher. It sets up the environment to have Safari use the bundled frameworks and load the WebKitNightlyEnabler dylib before exec'ing Safari
  • WebKitLauncher/start.html: Added.
  • WebKitLauncher/webkit.icns: Added.
7:31 PM Changeset in webkit [13767] by eseidel
  • 8 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

merge

6:59 PM Changeset in webkit [13766] by eseidel
  • 8 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

commit attempt

6:52 PM Changeset in webkit [13765] by ggaren
  • 1 copy in branches/temp-tree-code/branches/evaluate-execute-merge

created branch for evaluate-execute merge

5:13 PM Changeset in webkit [13709] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix memory leak introduced by the previous change
  • kxmlcore/HashTable.h: Specialize NeedsRef so that it correctly returns true when the value in question is a pair where one of the pair needs a ref and the other of the pair does not.
5:00 PM Changeset in webkit [13708] by justing
  • 2 edits in trunk/WebCore

Reviewed by mjs

I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
implicit removes.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
3:43 PM Changeset in webkit [13707] by justing
  • 1 edit in trunk/WebCore/editing/InsertNodeBeforeCommand.cpp

Should fix the build

3:26 PM Changeset in webkit [13706] by mjs
  • 23 edits
    1 add in trunk

LayoutTests:

Reviewed by Anders.

Update prototype chain for the following fix:

  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Anders.

  • also removed document.actualEncoding since it is not in any spec or implemented by any other browser


  • DerivedSources.make: add JSDocument.h to results
  • WebCore.xcodeproj/project.pbxproj: Added new files to project
  • bindings/scripts/CodeGeneratorJS.pm: Support for new stuff needed by Document.
  • dom/Document.cpp: (WebCore::Document::readyState): moved impl here from JS bindings (WebCore::Document::inputEncoding): ditto (WebCore::Document::defaultCharset): ditto (WebCore::Document::setCharset): ditto
  • dom/Document.h: (WebCore::Document::charset): added, synonym for inputEncoding. (WebCore::Document::characterSet): ditto
  • dom/Document.idl: Added. Full interface for the Document object.
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): JSDocument, not DOMDocument
  • khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction): ditto
  • khtml/ecma/kjs_binding.cpp: (KJS::jsStringOrFalse): Added this convenience for the method on Document that bizzarely returns false on failure and a string otherwise.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_css.cpp: (KJS::toJS): renamed for consistency
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_dom.cpp:
  • removed all traces of DOMDocument (KJS::toJS): JSDocument, not DOMDocument
  • khtml/ecma/kjs_dom.h:
  • khtml/ecma/kjs_html.cpp: (KJS::): (KJS::JSHTMLDocument::JSHTMLDocument): inherit from JSDocument (KJS::JSHTMLDocument::getOwnPropertySlot): ditto (KJS::JSHTMLDocument::put): ditto
  • khtml/ecma/kjs_html.h:
  • khtml/ecma/kjs_traversal.cpp: (KJS::toJS): added overloads (KJS::toNodeFilter): handle JS functions as well as impl NodeFilter objects
  • khtml/ecma/kjs_traversal.h:
  • platform/AtomicString.h: (WebCore::AtomicString::AtomicString): Allow implicit conversion from String.
2:53 PM Changeset in webkit [13705] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
Hitting an assert on undo paste

  • editing/pasteboard/undoable-fragment-removes-expected.checksum: Added.
  • editing/pasteboard/undoable-fragment-removes-expected.png: Added.
  • editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
  • editing/pasteboard/undoable-fragment-removes.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
Hitting an assert on undo paste


ReplaceSelectionCommand was doing a combination of undoable and non-undoable
removes from the ReplacementFragment. On Undo Paste, the undoable removes
couldn't be undone because the tree was in a different state than it was
at the time of the remove. This patch makes all the removes from the fragment
non-undoable. We could make them all undoable, but I can't think of any reason
why we'd want the fragment to be reconstructed on an Undo Paste.

  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): Assert that the node to append isn't already in a tree, since if it is, it will be removed in a non-undoable way.
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Nodes were being moved from the fragment to the document with undoable inserts. Undoable inserts implicitly remove the node (in a non-undoable way) from its old location if it is already in a tree. I now explicitly remove the nodes from the fragment before inserting them into the document to make it clear that they are being removed in a non-non-undoable way. I also changed the one undoable remove from the fragment to a non-undoable remove.
  • editing/ReplaceSelectionCommand.h: Made ReplacementFragment's non-undoable removeNode public.
2:51 PM Changeset in webkit [13704] by darin
  • 2 edits in trunk/WebCore
  • fixed the build
  • WebCore.xcodeproj/project.pbxproj: Oops! Resolved merge conflict.
2:19 PM Changeset in webkit [13703] by darin
  • 34 edits
    2 adds
    1 delete in trunk

JavaScriptCore:

Reviewed by Maciej.

Change HashMap and HashSet implementation so they fold various types together.
This allows us to implement maps and sets that use RefPtr<WebCore::StringImpl>
and WebCore::String in terms of the underlying raw pointer type, and hence use
-1 for the deleted value.

  • kxmlcore/HashTraits.h: Added a new type to HashTraits, StorageTraits, which is a type to be used when storing a value that has the same layout as the type itself. This is used only for non-key cases. In the case of keys, the hash function must also be considered. Moved emptyValue out of GenericHashTraitsBase into GenericHashTraits. Added a new bool to HashTraits, needsRef, which indicates whether the type needs explicit reference counting. If the type itself has needsRef true, but the storage type has needsRef false, then the HashSet or HashMap has to handle the reference counting explicitly. Added hash trait specializations for all signed integer values that give -1 as the deleted value. Gave all integers StorageTraits of the canonical integer type of the same size so int and long will share code. Gave all pointers and RefPtrs StorageTraits of the appropriately sized integer type. Removed redundant TraitType and emptyValue definitions in the pointer specialization for HashTraits. Added PairBaseHashTraits, which doesn't try to set up needsDestruction and deletedValue. Useful for types where we don't want to force the existence of deletedValue, such as the type of a pair in a HashMap which is not the actual storage type. Removed an unneeded parameter from the DeletedValueAssigner template. Added HashKeyStorageTraits template, which determines what type can be used to store a given hash key type with a given hash function, and specialized it for pointers and RefPtr so that pointer hash tables share an underlying HashTable that uses IntHash.
  • kxmlcore/HashTable.h: Added HashTableConstIteratorAdapter, HashTableIteratorAdapter, NeedsRef, RefCountManagerBase, RefCountManager, HashTableRefCountManagerBase, and HashTableRefCountManager. All are used by both HashSet and HashMap to handle hash tables where the type stored is not the same as the real value type.


  • kxmlcore/HashFunctions.h: Added a new struct named IntTypes that finds an integer type given a sizeof value. Renamed pointerHash to intHash and made it use overloading and take integer parameters. Added an IntHash struct which is a hash function that works for integers. Changed PtrHash to call IntHash with an appropriately sized integer. Made IntHash the default hash function for many integer types. Made PtrHash the default hash function for RefPtr as well as for raw pointers.
  • kxmlcore/HashSet.h: Changed implementation to use a separate "storage type" derived from the new traits. The HashTable will use the storage type and all necessary translation and ref/deref is done at the HashSet level. Also reorganized the file so that the HashSet is at the top and has no inline implementation inside it so it's easy to read the interface to HashSet.
  • kxmlcore/HashMap.h: Changed implementation to use a separate "storage type" derived from the new traits. The HashTable will use the storage type and all necessary translation and ref/deref is done at the HashMap level. Also reorganized the file so that the HashMap is at the top and has no inline implementation inside it so it's easy to read the interface to HashMap.
  • kxmlcore/HashMapPtrSpec.h: Removed. Superceded by optimizations in HashMap itself.
  • JavaScriptCore.xcodeproj/project.pbxproj: Remove HashMapPtrSpec.h, resort files, and also remove some unnecessary build settings from the aggregate target that generates derived sources.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.

WebCore:

Reviewed by Maciej.

  • platform/StringHash.h: Added. Moved hash functions and such for WebCore::String and friends into this file so we don't have to include the hash traits header everywhere. Changed hashing for WebCore::StringImpl and WebCore::String so that they use a raw pointer for the underlying storage type, taking advantage of the new feature added in JavaScriptCore.
  • platform/AtomicString.h: Moved StrHash specialization to StringHash.h.
  • platform/PlatformString.h: Moved StrHash specialization to StringHash.h.
  • platform/StringImpl.h: Moved StrHash, CaseInsensitiveHash, and HashTraits to StringHash.h. Left DefaultHash behind so that you can't get the wrong hash function by accident if you forget to include "StringHash.h".
  • platform/StringImpl.cpp: Added include of StringHash.h and removed RefPtr<StringImpl> HashTraits<RefPtr<StringImpl> >::_deleted, which is the object with a global initializer causing all the trouble!
  • kwq/AccessibilityObjectCache.h: Changed hash function to be IntHash instead of PtrHash.
  • dom/StyledElement.cpp: Changed MappedAttributeKeyTraits to inherit from the generic traits in KXMLCore so we get a StorageType. Also cleaned up a tiny bit by adding default values to the MappedAttributeKey constructor.
  • platform/CharsetNames.cpp: Changed hash traits here to be a new TextEncodingIDHashTraits struct rather than defining new default traits for the integer type since more integer types have default traits in HashTraits.h now. Also added a specialization so this class will share the underlying implementation (since InvalidEncoding happens to be -1).
  • bridge/mac/FrameMac.h:
  • dom/Document.h:
  • dom/xml_tokenizer.h:
  • khtml/xsl/XSLTProcessor.h:
  • kwq/JavaAppletWidget.h:
  • page/FramePrivate.h:
  • page/Page.cpp:
  • platform/AtomicString.cpp:
  • platform/TransferJob.h:
  • rendering/render_applet.h: Added include of StringHash.h.
  • WebCore.xcodeproj/project.pbxproj: Added StringHash.h. Remove unneeded CREATE_HASH_TABLE variable in build settings. Re-sorted some file lists. Added quotes to the CREATE_HASH_TABLE initialization in the rule that builds generated files. Removed various unneeded build settings for that target as well.
  • ForwardingHeaders/kxmlcore/HashTraits.h: Added.
  • other minor cleanup
  • bridge/mac/FrameMac.mm: Sorted includes.
  • dom/Node.cpp: Removed bogus symbol after #endif.
  • khtml/xsl/XSLTProcessor.cpp: Sorted includes. Removed redundant using namespace WebCore.
  • loader/Cache.cpp: Ditto.

WebKitTools:

Reviewed by Maciej.

  • Scripts/check-for-global-initializers: Remove StringImpl from the list of files that are allowed to have global initializers.
1:28 PM Changeset in webkit [13764] by ggaren
  • 4 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

Oops. Committed wrong patch. This is with-stack.patch

1:09 PM Changeset in webkit [13763] by ggaren
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

Committing Eric's patch to unify how nodes know their interpreter state -- with minor tweaks to the ASSERTs. The unified method is for nodes to use a data member rather than virtual method dispatch. This is about a 7% performance win.

11:05 AM Changeset in webkit [13702] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4502311> text-transform:capitalize needs to
treat nbsp as a regular space when ICU changes

There will be future changes in ICU to match the Unicode 4.1
standard which no longer recognizes &nbsp as a word separator. We
need to work around this with text-transform:capitalize because
words after non-breaking spaces still need to be capitalized.

No layout tests added because existing layout tests cover this.

11:02 AM Changeset in webkit [13701] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

Test: fast/dom/navigator-vendorSub.html

  • khtml/ecma/kjs_navigator.cpp: (KJS::Navigator::getValueProperty): Return an empty string for vendorSub property.
  • khtml/ecma/kjs_navigator.h:
11:02 AM Changeset in webkit [13700] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by OMG BETH

  • Scripts/run-testkjs:
  • pipe STDERR to /dev/null by default; new --verbose option overrides this behavior
  • set DYLD_FRAMEWORK_PATH to the webkit-configured path
  • output run command in a format that can be copied and pasted into the terminal to run manually
12:17 AM Changeset in webkit [13762] by ggaren
  • 6 edits
    1 delete in branches/temp-tree-code/trunk/JavaScriptCore

more steps toward integrating the evaluate and execute loops

Note: See TracTimeline for information about the timeline view.