⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 10, 2006:

9:40 PM Changeset in webkit [13818] by ap
  • 2 edits
    2 moves
    1 delete in trunk

Reviewed by Darin.

WebKitTools:

  • Scripts/run-webkit-tests: Added support for running .pl and .php tests, removed support for .text. Reduced the number of places that explicitly list supported extensions. Some of the changes come from bug 8121, the patch for which got landed only partially.

LayoutTests:

  • http/tests/incremental/slow-utf8-text.pl: Added (renamed from .text).
  • http/tests/incremental/slow-utf8-text.text: Removed.
  • http/tests/incremental/split-hex-entities.pl: Added (renamed from .html).
  • http/tests/incremental/split-hex-entities.html: Removed.
  • http/tests/incremental/.htaccess: Removed.
9:17 PM Changeset in webkit [13817] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4139799> Seed: Safari: Private Browsing leaves traces in Icon Cache


  • Misc/WebIconDatabasePrivate.h: new ivars: pageURLsBoundDuringPrivateBrowsing, iconURLsBoundDuringPrivateBrowsing, and privateBrowsingEnabled
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): initialize new ivars, and listen for notifications that WebPreferences changed so we can react to changes to private browsing. (-[NSMutableDictionary iconForURL:withSize:cache:]): Don't remove icon URL from extraRetain dictionary; that's now done in _forgetIconForIconURLString. (I left a comment here earlier about why I was worried about this change, but I convinced myself that it's fine.) (-[WebIconDatabase removeAllIcons]): Removed no-longer-true (and never very clear) comment, and braces. Also remove all objects from the two private-browsing-related dictionaries. (-[WebIconDatabase _setIcon:forIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setHaveNoIconForIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setIconURL:forURL:]): added an assert that helped me out at one point (-[WebIconDatabase _clearDictionaries]): clear the two new dictionaries too (-[WebIconDatabase _loadIconDictionaries]): made an existing ERROR not fire in the expected case where there are no icons at all on disk (-[WebIconDatabase _updateFileDatabase]): when saving the pageURLToIconURL dictionary to disk, first remove any values that were created during private browsing (-[WebIconDatabase _retainIconForIconURLString:]): skip the code that deals with saving changes to disk if private browsing is enabled (-[WebIconDatabase _forgetIconForIconURLString:]): Remove the icon URL from extraRetain dictionary here. We're forgetting everything about this icon URL so we should forget its former extraRetain count too. (-[WebIconDatabase _resetCachedWebPreferences:]): Cache the new value of private browsing. If it has now been turned off, forget everything we learned while it was on. This causes (e.g.) icons for bookmarks or pre-existing history items to be forgotten if the icon was only learned during private browsing.
  • History/WebHistoryItem.m: removed an unnecessary #import I happened to notice
4:36 PM Changeset in webkit [13816] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/gc-4-expected.txt: Add one blank line (test result was failing).
4:30 PM Changeset in webkit [13815] by darin
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix mistaken bad editing of AdditionalIncludeDirectories.
3:30 PM Changeset in webkit [13814] by hyatt
  • 6 edits in trunk/WebCore

Make focus ring painting respect clips set by WebCore (e.g., overflow).

Reviewed by darin

  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawFocusRing):
  • platform/mac/WebCoreGraphicsBridge.h:
  • platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
  • rendering/RenderLayer.cpp: (WebCore::setClip): (WebCore::restoreClip):
3:29 PM Changeset in webkit [13813] by hyatt
  • 2 edits in trunk/WebKit

Make the broken CG focus ring painting work when WebCore sets a clip
(in addition to respecting the dirty rect clip).

Reviewed by darin

  • WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
3:12 PM Changeset in webkit [13812] by darin
  • 4 edits
    28 copies
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • death to khtml/ecma, long live bindings/js
  • khtml/ecma: Removed. Moved all files to bindings/js.
  • bindings/js/JSDOMParser.cpp: Added.
  • bindings/js/JSDOMParser.h: Added.
  • bindings/js/JSXMLHttpRequest.cpp: Added.
  • bindings/js/JSXMLHttpRequest.h: Added.
  • bindings/js/JSXMLSerializer.cpp: Added.
  • bindings/js/JSXMLSerializer.h: Added.
  • bindings/js/JSXSLTProcessor.cpp: Added.
  • bindings/js/JSXSLTProcessor.h: Added.
  • bindings/js/kjs_binding.cpp: Added.
  • bindings/js/kjs_binding.h: Added.
  • bindings/js/kjs_css.cpp: Added.
  • bindings/js/kjs_css.h: Added.
  • bindings/js/kjs_dom.cpp: Added.
  • bindings/js/kjs_dom.h: Added.
  • bindings/js/kjs_events.cpp: Added.
  • bindings/js/kjs_events.h: Added.
  • bindings/js/kjs_html.cpp: Added.
  • bindings/js/kjs_html.h: Added.
  • bindings/js/kjs_navigator.cpp: Added.
  • bindings/js/kjs_navigator.h: Added.
  • bindings/js/kjs_proxy.cpp: Added.
  • bindings/js/kjs_proxy.h: Added.
  • bindings/js/kjs_traversal.cpp: Added.
  • bindings/js/kjs_traversal.h: Added.
  • bindings/js/kjs_views.cpp: Added.
  • bindings/js/kjs_views.h: Added.
  • bindings/js/kjs_window.cpp: Added.
  • bindings/js/kjs_window.h: Added.
  • DerivedSources.make: Removed khtml/ecma from directory list.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Moved files from khtml/ecma to bindings/js.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
3:09 PM Changeset in webkit [13811] by eseidel
  • 21 edits
    4 copies
    1 delete in branches/treecode/JavaScriptCore

Re-base the treecode branch to latest HEAD.

I used the following command:
svn merge -r 13663:13752 ​svn+ssh://eseidel@svn.opensource.apple.com/svn/webkit/trunk/JavaScriptCore

The merge was rubber-stamped by Tim Hatcher.

2:40 PM Changeset in webkit [13810] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/gc-4.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.
2:38 PM Changeset in webkit [13809] by darin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • try to fix the Windows build
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): Put code to release m_drawingContext into an APPLE ifdef.
  • platform/win/TemporaryLinkStubs.cpp:
2:10 PM Changeset in webkit [13808] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth.

  • projects/compat/hitlist.html: updated dates
2:04 PM Changeset in webkit [13807] by eseidel
  • 1 delete in branches/temp-tree-code

Remove the temporary import branch for treecode.

2:02 PM Changeset in webkit [13806] by eseidel
  • 1 move in branches/treecode

Move the treecode branch to its proper place.

1:34 PM Changeset in webkit [13755] by thatcher
  • 1 add in branches/temp-tree-code

New branch folder for an upcoming import.

10:02 AM Changeset in webkit [13754] by ap
  • 2 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Eric.

  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Removed the addition of scroll offsets, which is redundant for scrolled views, then changed the first view to be the document's scrolled view instead of its scroll view (all subsequent views were already scrolled views).
  • manual-tests/dictionary-scrolled-iframe.html: Added.
9:49 AM Changeset in webkit [13753] by darin
  • 92 edits in trunk

LayoutTests:

  • regenerated pixel results because many may be affected by the fix for bug 8100

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebTextRenderer.m: (overrideLayoutOperation): For RTL runs, apply the word-rounding on the left. (CG_floatWidthForRun): For RTL runs, apply the last character's rounding on the left by adjusting the start position. (initializeWidthIterator): Added finalRoundingWidth field to WidthIterator. (advanceWidthIterator): For RTL runs, apply rounding on the left of the character, by increasing the width of the next character (which is the character to the left). For the last character, keep the rounding width in the iterator's finalRoundingWidth, to be used by CG_floatWidthForRun().

Apr 9, 2006:

10:40 PM Changeset in webkit [13805] by ggaren
  • 4 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

5% speedup by pushing all sourceelements nodes on the stack in one go

10:06 PM Changeset in webkit [13752] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by eric.

This patch switches manual RefPtr exchange with use of
RefPtr::release to ensure that a node's ref count never tops 1
(in the normal case).

  • kjs/nodes.cpp: (BlockNode::BlockNode): (CaseBlockNode::CaseBlockNode):
  • kjs/nodes.h: (KJS::ArrayNode::ArrayNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
9:53 PM Changeset in webkit [13804] by ggaren
  • 2 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

prevent unnecessary entries in the extra ref count on nodes table

9:40 PM Changeset in webkit [13751] by ap
  • 3 edits
    3 adds in trunk

Reviewed by Darin.

Test: http/tests/xmlhttprequest/basic-auth.html

  • platform/KURL.cpp: (KURL::setUser): Enable a code path that handles non-empty user name - it was already present, but commented out and protected with an assertion. (KURL::setPass): Ditto.
7:45 PM Changeset in webkit [13750] by darin
  • 1 edit in trunk/LayoutTests/fast/canvas/canvas-before-css-expected.checksum

Removed bogus suffix I checked in by accident.

5:55 PM Changeset in webkit [13803] by eseidel
  • 1 edit in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs/TreeCode.cpp

Prevent int->double conversion in hot code path

5:31 PM Changeset in webkit [13802] by ggaren
  • 5 edits in branches/temp-tree-code/branches/evaluate-execute-merge/JavaScriptCore/kjs

fixed up unwinding some more -- all the mozilla js tests now pass

4:48 PM Changeset in webkit [13749] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

First early steps towards a next, much smaller, round of renames
in WebCore.

4:38 PM Changeset in webkit [13748] by darin
  • 14 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/canvas/canvas-before-css-expected.checksum: Added.
  • fast/canvas/canvas-before-css-expected.png: Added.
  • fast/canvas/canvas-before-css-expected.txt: Added.
  • fast/canvas/canvas-before-css.html: Added.
  • fast/canvas/image-object-in-canvas.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.
  • fast/canvas/patternfill-repeat-expected.txt: Updated for name change from RenderCanvasImage to RenderHTMLCanvas.
  • fast/canvas/image-object-in-canvas-expected.txt: Ditto.
  • fast/canvas/fillrect_gradient-expected.txt: Ditto.
  • fast/canvas/quadraticCurveTo-expected.txt: Ditto.

WebCore:

Reviewed by Anders.

Test: fast/canvas/canvas-before-css.html

This patch makes us match the canvas documentation in Hixie's Web Applications
draft as far as when the canvas is created and recreated and how it's sized.
It also gets rid of the compositeOperation attribute of the canvas element.
We can add that back if we need it. Anders points out that this specifically
changes behavior for canvas elements where the size is set in CSS and not with
width and height attributes. The CSS size now determines how big a box the canvas
is rendered into, but has no effect on the size of the canvas's buffer.

  • html/CanvasRenderingContext2D.h: Added overloads of drawImage that take HTMLCanvasElement, which is no longer derived from HTMLImageElement.
  • html/CanvasRenderingContext2D.cpp: (WebCore::imageSize): Renamed from imageOrCanvasSize. Now used for images only, because canvas is no longer derived from image. (WebCore::CanvasRenderingContext2D::drawImage): Split the implementation of this for image sources from the implementation for canvas sources. (WebCore::CanvasRenderingContext2D::willDraw): Changed to call a new willDraw function on the canvas element. (WebCore::CanvasRenderingContext2D::drawingContext): Changed to call drawingContext on the canvas element rather than the renderer.
  • html/HTMLCanvasElement.h: Changed HTMLCanvasElement to derive from HTMLElement instead of HTMLImageElement. Added width, height, setWidth, setHeight, willDraw, paint, drawingContext, createDrawingContext, and reset functions. Added m_size, m_createdDrawingContext, m_data, and m_drawingContext data members. Removed mapToEntry, attach, detach, and isURLAttribute functins.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): Added initializers for new m_size, m_createdDrawingContext, m_data, and m_drawingContext data members. (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Free m_data and m_drawingContext. (WebCore::HTMLCanvasElement::parseMappedAttribute): Got rid of special case for srcAttr, which is no longer needed since we aren't deriving from HTMLImageElement. Added code that triggers a reset when either width or height is set. (WebCore::HTMLCanvasElement::createRenderer): Added code to set the intrinsic width and height of the renderer to the size of the element. (WebCore::HTMLCanvasElement::setHeight): Added. Sets the height attribute. (WebCore::HTMLCanvasElement::setWidth): Added. Sets the width attribute. (WebCore::HTMLCanvasElement::willDraw): Added. Tells the renderer to repaint. Also has FIXME mentioning we could dirty only the part that has changed in the future. (WebCore::HTMLCanvasElement::reset): Added. Sets the size of the canvas and discards the old buffer, which is an indirect way of resetting the buffer to transparent black. (WebCore::HTMLCanvasElement::paint): Added. Draws the canvas image into the graphics context that's passed in. (WebCore::HTMLCanvasElement::createDrawingContext): Added. Allocates a buffer for the bits, then creates a bitmap context for drawing into the buffer. (WebCore::HTMLCanvasElement::drawingContext): Added. Calls createDrawingContext if needed, then returns the current drawing context. (WebCore::HTMLCanvasElement::createPlatformImage): Changed to always call CGContextFlush and to create the image from the context in this class.
  • rendering/RenderHTMLCanvas.h: Remove almost all of the contents of this file. Removed ~RenderHTMLCanvas, setNeedsImageUpdate, element, updateDrawnImage, drawingContext, createDrawingContext, and drawnImage functions and _drawingContext, _drawingContextData, _drawnImage, and _needsImageUpdate booleans. Changed RenderHTMLCanvas to derive from RenderReplaced instead of RenderImage.
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::RenderHTMLCanvas): Changed to only initialize RenderReplaced. (WebCore::RenderHTMLCanvas::renderName): Moved this in here, since there's no good reason to have this virtual function inlined. (WebCore::RenderHTMLCanvas::paint): Changed implementation to use HTMLCanvasElement::paint instead ofcalling CGContextDrawImage directly. (WebCore::RenderHTMLCanvas::layout): Removed the code that detects changes in width and causes the drawing context to be recreated; instead, if the width and height changes we scale when we paint the canvas.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp: (WebCore::JSCanvasRenderingContext2DBaseProtoFunc::callAsFunction): Separated out handling for <canvas> vs. <img> elements in drawRect, since HTMLCanvasElement is no longer derived from HTMLImageElement.
3:00 PM Changeset in webkit [13747] by eseidel
  • 2 edits in trunk/WebCore

2006-04-09 Rob Buis <​buis@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6027:
Dirty rect invalidation issues in mozilla sample

Make sure the paths calculate the new bounding box and not
use the cached bbox.

No automated test case possible.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::setPath):
2:55 PM Changeset in webkit [13746] by eseidel
  • 3 edits
    4 adds in trunk

2006-04-09 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6930:
% width/height on nested <svg> tags do not work

Set the context correctly for inner <svg>, so calculation of
width/height for inner <svg> elements is done against the
viewport element.

Test: svg/custom/inner-percent.svg

  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::width): (WebCore::SVGSVGElement::height):
1:12 PM Changeset in webkit [13745] by eseidel
  • 2 edits in trunk/WebCore

2006-04-08 Rob Buis <​buis@kde.org>

Reviewed by eseidel.

No automated test case possible.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7531:
hang in SVGPolygonElementImpl::toPathData in polygon test case

Make sure the points list is cleared, just like the path
list is cleared first before (re)parsing.

  • ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::parseMappedAttribute):
1:03 AM Changeset in webkit [13744] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

Forgot to commit ChangeLog for JSC string capitalization fixes.

Note: See TracTimeline for information about the timeline view.