⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 11, 2006:

10:31 PM Changeset in webkit [13833] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Minor code cleanup -- passes all the JS tests.

  • kjs/object_object.cpp: (ObjectObjectImp::construct): (ObjectObjectImp::callAsFunction):
9:46 PM Changeset in webkit [13832] by darin
  • 9 edits in trunk

JavaScriptCore:

  • another attempt to fix Windows build -- Vector in Forward.h was not working
  • kxmlcore/Forward.h: Remove Vector.
  • kxmlcore/Vector.h: Add back default arguments, remove include of Forward.h.

WebCore:

  • try to fix Windows build
  • html/HTMLCollection.h: Add back include of Vector.h.
  • page/Frame.h: Ditto.
  • platform/Timer.h: Ditto.
  • more changes for no-SVG (not working yet though)
  • editing/CompositeEditCommand.h: Added css_valueimpl.h include.
9:15 PM Changeset in webkit [13831] by darin
  • 3 edits in trunk/WebCore
  • try to fix no-SVG build
  • kwq/RenderTreeAsText.cpp: Added back an include only needed for non-SVG.
  • rendering/RenderObject.h: Ditto.
9:07 PM Changeset in webkit [13830] by darin
  • 12 edits
    3 deletes in trunk

JavaScriptCore:

  • try to fix Windows build -- HashForward.h was not working
  • kxmlcore/HashForward.h: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Remove HashForward.h.
  • kjs/collector.h: Remove use of HashForward.h.
  • kxmlcore/HashCountedSet.h: Remove include of HashForward.h, restore default arguments.
  • kxmlcore/HashMap.h: Ditto.
  • kxmlcore/HashSet.h: Ditto.

JavaScriptGlue:

  • try to fix Windows build
  • kxmlcore/HashForward.h: Removed.

WebCore:

  • try to fix Windows build
  • ForwardingHeaders/kxmlcore/HashForward.h: Removed.
  • dom/xml_tokenizer.h: Include another header instead of HashForward.h.
  • loader/Cache.h: Ditto.
  • page/Page.h: Ditto.
  • platform/TransferJob.h: Ditto.
8:14 PM Changeset in webkit [13829] by justing
  • 2 edits in trunk
7:07 PM Changeset in webkit [13828] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

Added to test changes:

  • editing/pasteboard/merge-end-1-expected.checksum: Added.
  • editing/pasteboard/merge-end-1-expected.png: Added.
  • editing/pasteboard/merge-end-1-expected.txt: Added.
  • editing/pasteboard/merge-end-1.html: Added.
  • editing/pasteboard/merge-end-2-expected.checksum: Added.
  • editing/pasteboard/merge-end-2-expected.png: Added.
  • editing/pasteboard/merge-end-2-expected.txt: Added.
  • editing/pasteboard/merge-end-2.html: Added.


Use the editing library so the test can be run in slow motion.

  • editing/deleting/merge-unrendered-space.html:


Merges after pasted content no longer happen unnecessary. These
tests used to do unnecessary merges that happened to move nodes
that served as selection endpoints, which cleared the selection.
So, you'll see changes to the selection change delegate calls.

  • editing/pasteboard/8145-2-expected.txt:
  • editing/pasteboard/paste-line-endings-010-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:

WebCore:

Reviewed by harrison


Fixes more instances of:
<rdar://problem/3950559>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Do paragraph merging using moveParagraphs.
6:18 PM Changeset in webkit [13827] by eseidel
  • 63 edits
    3 copies
    1 delete in branches/treecode/JavaScriptCore

Merged with HEAD (13826), rs=timo.

6:08 PM Changeset in webkit [13826] by eseidel
  • 1 edit in branches/treecode/JavaScriptCore/kjs/TreeCode.cpp

.5% speedup on ibench by using Completion&. r=darin

5:57 PM Changeset in webkit [13825] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/merge-unrendered-space-expected.checksum: Added.
  • editing/deleting/merge-unrendered-space-expected.png: Added.
  • editing/deleting/merge-unrendered-space-expected.txt: Added.
  • editing/deleting/merge-unrendered-space.html: Added.

WebCore:

Reviewed by harrison


Some setup for work on paste performance.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Moved code from mergeParagraphs so that it can be used in ReplaceSelectionCommand.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): Put the code that chooses m_deepPosition into initDeepPosition. (WebCore::VisiblePosition::initDeepPosition): Fixed a bug: don't fall through to the code that's only for positions inside unrendered space between blocks when there's a candidate downstream() is a candidate. Added a comment about why the fall through code is necessary.
  • editing/VisiblePosition.h:
1:02 PM Changeset in webkit [13824] by harrison
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • fixed clean build, broken by Darin's check-in
  • kjs/date_object.cpp: Add needed include of lookup.h.
  • kjs/regexp_object.cpp: Move include of .lut.h file below other includes.
12:45 PM Changeset in webkit [13823] by eseidel
  • 2 edits in trunk/WebKitSite

2006-04-11 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

  • quality/testing.html: fix run-mozilla-tests to run-javascriptcore-tests
10:51 AM Changeset in webkit [13822] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.


  • fixed <rdar://problem/4509328> highlight all matches hangs when searching for tab character on www.google.com (and others)


For reasons not yet completely understood, searching for a tab character on some pages (Google, Amazon) finds a match
with a non-collapsed range but then claims that the end visible position of the match is the original start visible
position of the search range. This was causing the highlightAllMatches code to loop forever. Fixed the loop by
checking for the non-advancing search range explicitly. I'm going to track down a reduction of the bogus
search-for-tab issue, and write that up as a separate bug (that bug is not a regression; you can "find" a tab on
google in Tiger also).

  • page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): break the loop if the search range hasn't advanced
9:30 AM Changeset in webkit [13821] by darin
  • 352 edits
    7 adds
    1 delete in trunk

JavaScriptCore:

Rubber-stamped by John Sullivan.

  • switched from a shell script to a makefile for generated files
  • removed lots of unneeded includes
  • added new Forward.h and HashForward.h headers that allow compiling with fewer unneeded templates
  • DerivedSources.make: Added.
  • generate-derived-sources: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files, changed to use DerivedSources.make.
  • kxmlcore/Forward.h: Added.
  • kxmlcore/HashForward.h: Added.
  • kxmlcore/HashCountedSet.h: Include HashForward for default args.
  • kxmlcore/HashMap.h: Ditto.
  • kxmlcore/HashSet.h: Ditto.
  • kjs/object.h:
  • kjs/object.cpp: Moved KJS_MAX_STACK into the .cpp file.
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_runtime.h:
  • bindings/jni/jni_utility.h:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm:
  • bindings/objc/objc_runtime.mm:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.h:
  • bindings/runtime_array.cpp:
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp:
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp:
  • bindings/runtime_root.h:
  • kjs/JSImmediate.cpp:
  • kjs/Parser.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/collector.h:
  • kjs/context.h:
  • kjs/debugger.cpp:
  • kjs/error_object.h:
  • kjs/function_object.h:
  • kjs/internal.h:
  • kjs/lexer.cpp:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object_object.cpp:
  • kjs/operations.cpp:
  • kjs/protected_reference.h:
  • kjs/reference.h:
  • kjs/reference_list.h:
  • kjs/regexp_object.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
  • kjs/testkjs.cpp:
  • kjs/value.cpp:
  • kjs/value.h:
  • kxmlcore/HashTable.h:
  • kxmlcore/ListRefPtr.h:
  • kxmlcore/TCPageMap.h:
  • kxmlcore/Vector.h: Removed unneeded header includes.

JavaScriptGlue:

Rubber-stamped by John Sullivan.

  • added forwarding headers for the new Forward.h and HashForward.h files
  • kxmlcore/Forward.h: Added.
  • kxmlcore/HashForward.h: Added.

WebCore:

Rubber-stamped by John Sullivan (except for pbxproj change).

  • updated to use the new Forward.h and HashForward.h headers
  • moved the showTree debugging functions out of the WebCore namespace so they are easier to call from gdb, and renamed the showTree member functions so they don't get in the way; now you can do "call showTree(x)" in gdb and it just works
  • removed a lot of unneeded includes
  • WebCore.xcodeproj/project.pbxproj: Fixed a lot of paths that were not relative to the enclosing group.
  • ForwardingHeaders/kxmlcore/Forward.h: Added.
  • ForwardingHeaders/kxmlcore/HashForward.h: Added.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_navigator.cpp:
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_proxy.cpp:
  • bindings/js/kjs_traversal.h:
  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/DOMUtility.mm:
  • bindings/objc/DOMViews.mm:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.mm:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCoreFrameNamespaces.mm:
  • bridge/mac/WebCoreJavaScript.mm:
  • bridge/win/PageWin.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/css_base.h:
  • css/css_ruleimpl.h:
  • css/css_valueimpl.cpp:
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • dom/AbstractView.h:
  • dom/AtomicStringList.h:
  • dom/Attribute.cpp:
  • dom/Attribute.h:
  • dom/Comment.cpp:
  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/DOMImplementation.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dump): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
  • dom/EventTargetNode.h: (WebCore::EventTargetNode::postDispatchEventHandler):
  • dom/NamedAttrMap.h:
  • dom/Node.cpp: (WebCore::Node::showNode): (WebCore::Node::showTree): (WebCore::Node::showTreeAndMark): (showTree):
  • dom/Node.h:
  • dom/NodeList.cpp:
  • dom/NodeList.h:
  • dom/Position.cpp: (showTree):
  • dom/Position.h:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • dom/dom2_eventsimpl.cpp:
  • dom/dom2_eventsimpl.h:
  • dom/dom2_traversalimpl.h:
  • dom/dom_xmlimpl.cpp:
  • dom/xml_tokenizer.cpp:
  • dom/xml_tokenizer.h:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/ApplyStyleCommand.h:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/CreateLinkCommand.cpp:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/DeleteFromTextNodeCommand.h:
  • editing/DeleteSelectionCommand.cpp:
  • editing/EditCommand.cpp:
  • editing/EditCommand.h:
  • editing/HTMLInterchange.cpp:
  • editing/InsertIntoTextNodeCommand.cpp:
  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/JSEditor.cpp:
  • editing/JoinTextNodesCommand.cpp:
  • editing/MergeIdenticalElementsCommand.cpp:
  • editing/ModifySelectionListLevelCommand.cpp:
  • editing/MoveSelectionCommand.cpp:
  • editing/RebalanceWhitespaceCommand.h:
  • editing/RemoveCSSPropertyCommand.h:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.cpp: (WebCore::Selection::formatForDebugger): (WebCore::Selection::showTree): (showTree):
  • editing/Selection.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::formatForDebugger): (WebCore::SelectionController::showTree): (showTree):
  • editing/SelectionController.h:
  • editing/TextIterator.cpp:
  • editing/TextIterator.h:
  • editing/TypingCommand.cpp:
  • editing/TypingCommand.h:
  • editing/UnlinkCommand.cpp:
  • editing/VisiblePosition.cpp: (WebCore::isEqualIgnoringAffinity): (WebCore::VisiblePosition::formatForDebugger): (WebCore::VisiblePosition::showTree): (showTree):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition): (WebCore::operator==):
  • editing/WrapContentsInDummySpanCommand.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • editing/markup.h: (WebCore::):
  • editing/visible_units.cpp:
  • html/CanvasGradient.cpp:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp:
  • html/CanvasStyle.h:
  • html/FormDataList.cpp:
  • html/FormDataList.h:
  • html/HTMLCollection.cpp:
  • html/HTMLCollection.h:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:
  • html/HTMLElement.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLElementFactory.h:
  • html/HTMLFormCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLParser.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • html/HTMLTokenizer.cpp:
  • html/HTMLTokenizer.h:
  • html/html_baseimpl.cpp:
  • html/html_headimpl.h:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderPath.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • khtml/misc/decoder.cpp:
  • khtml/misc/decoder.h:
  • khtml/xsl/XSLStyleSheet.cpp:
  • khtml/xsl/XSLTProcessor.cpp:
  • khtml/xsl/XSLTProcessor.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimatedColor.h:
  • ksvg2/svg/SVGAnimatedLengthList.h:
  • ksvg2/svg/SVGAnimatedNumberList.h:
  • ksvg2/svg/SVGAnimatedString.h:
  • ksvg2/svg/SVGAnimatedTransformList.h:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGTransform.h:
  • kwq/AccessibilityObjectCache.mm:
  • kwq/ClipboardMac.mm:
  • kwq/JavaAppletWidget.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQEditCommand.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/RegularExpression.h:
  • kwq/RenderTreeAsText.cpp:
  • kwq/RenderTreeAsText.h:
  • kwq/WebCoreAXObject.mm:
  • loader/Cache.cpp:
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedObject.h:
  • loader/CachedScript.cpp:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp:
  • page/FrameTree.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
  • platform/Color.cpp:
  • platform/FloatRect.h:
  • platform/Font.cpp:
  • platform/Font.h:
  • platform/FontFamily.cpp:
  • platform/GraphicsContext.cpp:
  • platform/Image.cpp:
  • platform/Image.h:
  • platform/IntRect.h:
  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/SegmentedString.h:
  • platform/Shared.h:
  • platform/StreamingTextDecoder.cpp:
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/TextEncoding.h:
  • platform/Timer.cpp:
  • platform/Timer.h:
  • platform/TransferJob.cpp:
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/cairo/ImageCairo.cpp:
  • platform/cairo/ImageSourceCairo.cpp:
  • platform/image-decoders/gif/GIFImageReader.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/mac/FontFamilyMac.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/ImageMac.mm:
  • platform/mac/TextEncodingMac.cpp:
  • platform/mac/TransferJobMac.mm:
  • platform/win/FontPlatformDataWin.cpp:
  • platform/win/TransferJobWin.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderCanvas.cpp:
  • rendering/RenderCanvas.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (showTree):
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTextField.cpp:
  • rendering/RenderTextFragment.h:
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm:
  • rendering/RenderThemeWin.cpp:
  • rendering/bidi.cpp:
  • rendering/render_form.h:
  • rendering/render_line.cpp: (showTree):
  • rendering/render_line.h:
  • rendering/render_list.cpp:
  • rendering/render_replaced.cpp:
  • rendering/render_replaced.h:
  • rendering/render_style.cpp:
  • rendering/render_style.h:
  • xml/xmlhttprequest.h:
4:17 AM Changeset in webkit [13820] by eseidel
  • 2 edits in branches/treecode/JavaScriptCore

misc small speedups to bring 2% more on the js ibench. r=mjs

2:03 AM Changeset in webkit [13819] by eseidel
  • 9 edits in branches/treecode/JavaScriptCore/kjs

Roll DeclaredFunctionImp::call() down into the interpreter loop for a 5% speed gain on ibench. r=mjs

Apr 10, 2006:

9:40 PM Changeset in webkit [13818] by ap
  • 2 edits
    2 moves
    1 delete in trunk

Reviewed by Darin.

WebKitTools:

  • Scripts/run-webkit-tests: Added support for running .pl and .php tests, removed support for .text. Reduced the number of places that explicitly list supported extensions. Some of the changes come from bug 8121, the patch for which got landed only partially.

LayoutTests:

  • http/tests/incremental/slow-utf8-text.pl: Added (renamed from .text).
  • http/tests/incremental/slow-utf8-text.text: Removed.
  • http/tests/incremental/split-hex-entities.pl: Added (renamed from .html).
  • http/tests/incremental/split-hex-entities.html: Removed.
  • http/tests/incremental/.htaccess: Removed.
9:17 PM Changeset in webkit [13817] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4139799> Seed: Safari: Private Browsing leaves traces in Icon Cache


  • Misc/WebIconDatabasePrivate.h: new ivars: pageURLsBoundDuringPrivateBrowsing, iconURLsBoundDuringPrivateBrowsing, and privateBrowsingEnabled
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary init]): initialize new ivars, and listen for notifications that WebPreferences changed so we can react to changes to private browsing. (-[NSMutableDictionary iconForURL:withSize:cache:]): Don't remove icon URL from extraRetain dictionary; that's now done in _forgetIconForIconURLString. (I left a comment here earlier about why I was worried about this change, but I convinced myself that it's fine.) (-[WebIconDatabase removeAllIcons]): Removed no-longer-true (and never very clear) comment, and braces. Also remove all objects from the two private-browsing-related dictionaries. (-[WebIconDatabase _setIcon:forIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setHaveNoIconForIconURL:]): remember icon URL if private browsing is enabled (-[WebIconDatabase _setIconURL:forURL:]): added an assert that helped me out at one point (-[WebIconDatabase _clearDictionaries]): clear the two new dictionaries too (-[WebIconDatabase _loadIconDictionaries]): made an existing ERROR not fire in the expected case where there are no icons at all on disk (-[WebIconDatabase _updateFileDatabase]): when saving the pageURLToIconURL dictionary to disk, first remove any values that were created during private browsing (-[WebIconDatabase _retainIconForIconURLString:]): skip the code that deals with saving changes to disk if private browsing is enabled (-[WebIconDatabase _forgetIconForIconURLString:]): Remove the icon URL from extraRetain dictionary here. We're forgetting everything about this icon URL so we should forget its former extraRetain count too. (-[WebIconDatabase _resetCachedWebPreferences:]): Cache the new value of private browsing. If it has now been turned off, forget everything we learned while it was on. This causes (e.g.) icons for bookmarks or pre-existing history items to be forgotten if the icon was only learned during private browsing.
  • History/WebHistoryItem.m: removed an unnecessary #import I happened to notice
4:36 PM Changeset in webkit [13816] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/gc-4-expected.txt: Add one blank line (test result was failing).
4:30 PM Changeset in webkit [13815] by darin
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Fix mistaken bad editing of AdditionalIncludeDirectories.
3:30 PM Changeset in webkit [13814] by hyatt
  • 6 edits in trunk/WebCore

Make focus ring painting respect clips set by WebCore (e.g., overflow).

Reviewed by darin

  • platform/GraphicsContext.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::drawFocusRing):
  • platform/mac/WebCoreGraphicsBridge.h:
  • platform/mac/WebCoreGraphicsBridge.m: (-[WebCoreGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
  • rendering/RenderLayer.cpp: (WebCore::setClip): (WebCore::restoreClip):
3:29 PM Changeset in webkit [13813] by hyatt
  • 2 edits in trunk/WebKit

Make the broken CG focus ring painting work when WebCore sets a clip
(in addition to respecting the dirty rect clip).

Reviewed by darin

  • WebCoreSupport/WebGraphicsBridge.m: (-[WebGraphicsBridge drawFocusRingWithPath:radius:color:clipRect:]):
3:12 PM Changeset in webkit [13812] by darin
  • 4 edits
    28 copies
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • death to khtml/ecma, long live bindings/js
  • khtml/ecma: Removed. Moved all files to bindings/js.
  • bindings/js/JSDOMParser.cpp: Added.
  • bindings/js/JSDOMParser.h: Added.
  • bindings/js/JSXMLHttpRequest.cpp: Added.
  • bindings/js/JSXMLHttpRequest.h: Added.
  • bindings/js/JSXMLSerializer.cpp: Added.
  • bindings/js/JSXMLSerializer.h: Added.
  • bindings/js/JSXSLTProcessor.cpp: Added.
  • bindings/js/JSXSLTProcessor.h: Added.
  • bindings/js/kjs_binding.cpp: Added.
  • bindings/js/kjs_binding.h: Added.
  • bindings/js/kjs_css.cpp: Added.
  • bindings/js/kjs_css.h: Added.
  • bindings/js/kjs_dom.cpp: Added.
  • bindings/js/kjs_dom.h: Added.
  • bindings/js/kjs_events.cpp: Added.
  • bindings/js/kjs_events.h: Added.
  • bindings/js/kjs_html.cpp: Added.
  • bindings/js/kjs_html.h: Added.
  • bindings/js/kjs_navigator.cpp: Added.
  • bindings/js/kjs_navigator.h: Added.
  • bindings/js/kjs_proxy.cpp: Added.
  • bindings/js/kjs_proxy.h: Added.
  • bindings/js/kjs_traversal.cpp: Added.
  • bindings/js/kjs_traversal.h: Added.
  • bindings/js/kjs_views.cpp: Added.
  • bindings/js/kjs_views.h: Added.
  • bindings/js/kjs_window.cpp: Added.
  • bindings/js/kjs_window.h: Added.
  • DerivedSources.make: Removed khtml/ecma from directory list.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Moved files from khtml/ecma to bindings/js.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
3:09 PM Changeset in webkit [13811] by eseidel
  • 21 edits
    4 copies
    1 delete in branches/treecode/JavaScriptCore

Re-base the treecode branch to latest HEAD.

I used the following command:
svn merge -r 13663:13752 ​svn+ssh://eseidel@svn.opensource.apple.com/svn/webkit/trunk/JavaScriptCore

The merge was rubber-stamped by Tim Hatcher.

2:40 PM Changeset in webkit [13810] by darin
  • 2 edits in trunk/LayoutTests
  • fast/dom/gc-4.html: Test had a bug where it used <canvas> without a </canvas> tag. Changed test to include a </canvas> tag.
2:38 PM Changeset in webkit [13809] by darin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • try to fix the Windows build
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::reset): Put code to release m_drawingContext into an APPLE ifdef.
  • platform/win/TemporaryLinkStubs.cpp:
2:10 PM Changeset in webkit [13808] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Beth.

  • projects/compat/hitlist.html: updated dates
2:04 PM Changeset in webkit [13807] by eseidel
  • 1 delete in branches/temp-tree-code

Remove the temporary import branch for treecode.

2:02 PM Changeset in webkit [13806] by eseidel
  • 1 move in branches/treecode

Move the treecode branch to its proper place.

1:34 PM Changeset in webkit [13755] by thatcher
  • 1 add in branches/temp-tree-code

New branch folder for an upcoming import.

10:02 AM Changeset in webkit [13754] by ap
  • 2 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Eric.

  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject doAXTextMarkerForPosition:]): Removed the addition of scroll offsets, which is redundant for scrolled views, then changed the first view to be the document's scrolled view instead of its scroll view (all subsequent views were already scrolled views).
  • manual-tests/dictionary-scrolled-iframe.html: Added.
9:49 AM Changeset in webkit [13753] by darin
  • 92 edits in trunk

LayoutTests:

  • regenerated pixel results because many may be affected by the fix for bug 8100

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebTextRenderer.m: (overrideLayoutOperation): For RTL runs, apply the word-rounding on the left. (CG_floatWidthForRun): For RTL runs, apply the last character's rounding on the left by adjusting the start position. (initializeWidthIterator): Added finalRoundingWidth field to WidthIterator. (advanceWidthIterator): For RTL runs, apply rounding on the left of the character, by increasing the width of the next character (which is the character to the left). For the last character, keep the rounding width in the iterator's finalRoundingWidth, to be used by CG_floatWidthForRun().
Note: See TracTimeline for information about the timeline view.