⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 12, 2006:

11:32 PM Changeset in webkit [13858] by darin
  • 97 edits
    18 deletes in trunk/WebCore

Rubber-stamped by Anders.

  • get ready for some more de-KWQ-ing done by the renaming script in two ways

1) stop using forwarding headers for things within WebCore
2) remove a bit of unused stuff

  • loader/CachedImage.h:
  • loader/CachedImage.cpp:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • xml/XSLTProcessor.cpp: Removed unused showAnimations functions and data. We can add back later if we need it. And if we do, we won't use a typedef from KHTMLSettings.
  • ForwardingHeaders/java: Removed.
  • ForwardingHeaders/java/kjavaappletwidget.h: Removed.
  • ForwardingHeaders/khtml_settings.h: Removed.
  • ForwardingHeaders/kio: Removed.
  • ForwardingHeaders/kio/global.h: Removed.
  • ForwardingHeaders/ksslkeygen.h: Removed.
  • ForwardingHeaders/q3ptrlist.h: Removed.
  • ForwardingHeaders/q3valuelist.h: Removed.
  • ForwardingHeaders/qcombobox.h: Removed.
  • ForwardingHeaders/qfontmetrics.h: Removed.
  • ForwardingHeaders/qlineedit.h: Removed.
  • ForwardingHeaders/qmatrix.h: Removed.
  • ForwardingHeaders/qptrlist.h: Removed.
  • ForwardingHeaders/qptrqueue.h: Removed.
  • ForwardingHeaders/qregexp.h: Removed.
  • ForwardingHeaders/qscrollbar.h: Removed.
  • ForwardingHeaders/qtextedit.h: Removed.
  • ForwardingHeaders/qtextstream.h: Removed.
  • ForwardingHeaders/qvaluelist.h: Removed.
  • ForwardingHeaders/qwmatrix.h: Removed.
  • WebCore+SVG/DOMList.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp:
  • css/css_stylesheetimpl.h:
  • css/css_valueimpl.cpp:
  • css/css_valueimpl.h:
  • css/cssstyleselector.cpp:
  • dom/CharacterData.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/EventTargetNode.cpp:
  • dom/Node.cpp:
  • editing/BreakBlockquoteCommand.h:
  • editing/htmlediting.cpp:
  • html/FormDataList.h:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLTokenizer.h:
  • html/html_objectimpl.cpp:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGLengthList.cpp:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGNumberList.cpp:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGStringList.cpp:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/svgpathparser.cpp:
  • kwq/KWQKHTMLSettings.h:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/Decoder.cpp:
  • loader/FormData.h:
  • loader/loader.h:
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/Font.cpp:
  • platform/SegmentedString.h:
  • platform/mac/FontMac.mm:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderBlock.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/bidi.h:
  • rendering/break_lines.cpp:
  • rendering/render_applet.cpp:
  • rendering/render_form.cpp:
  • rendering/render_form.h:
  • rendering/render_frames.cpp:
  • rendering/render_style.h:
  • xml/xmlhttprequest.cpp: Updated includes.
  • WebCore.xcodeproj/project.pbxproj: Resorted a couple things.
10:43 PM Changeset in webkit [13857] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Plans for another round of renaming (eliminating KWQ).

8:19 PM Changeset in webkit [13856] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Fixes the build.

7:00 PM Changeset in webkit [13855] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison


Layout test for the changes made to VisiblePosition::init in r13825.


  • editing/selection/unrendered-space.html
  • editing/selection/unrendered-space-expected.png
  • editing/selection/unrendered-space-expected.checksum
  • editing/selection/unrendered-space-expected.txt
6:50 PM Changeset in webkit [13854] by adele
  • 24 edits
    2 adds in trunk

LayoutTests:

Test for setSelectionRange bug in text fields.

  • fast/forms/input-delete-expected.txt: Added.
  • fast/forms/input-delete.html: Added.

WebCore:

Reviewed by Darin and Tim O.

WebCore part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8061
REGRESSION: New text fields need to send callbacks used by autocomplete

Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8156
FrameMac::submitForm is busted after Vector changes

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): Use boundingBox method so this no longer relies on an NSTextField. The old code is no longer needed because this method was used by autocomplete, and that was not enabled for password or search fields. (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): New implementation that uses setValue and setSelectionRange instead of NSTextField specific code. (-[DOMHTMLInputElement _selectedRange]): Creates range by calling selectionStart and selectionEnd on the input element. (-[DOMHTMLInputElement _setAutofilled:]): Provides a way for the autofill code to set a flag on the input element so it knows when its value is set by autofill. This is how we change the background color.
  • bindings/objc/DOMPrivate.h: Removed _displayedValue, _setDisplayedValue, _setBackgroundColor since these are no longer needed for the new text field implementation, and aren't used for remaining NSView-style password and search fields. Added _setAutofilled method.
  • bridge/mac/FrameMac.h: Added virtual clearRecordedFormValues and recordFormValue. These were moved into Frame.cpp recently, which broke how Safari asked to add form values to the keychain.
  • bridge/mac/FrameMac.mm: (WebCore::createNSDictionary): Added. Converts a hashmap to an NSDictionary for m_formValuesAboutToBeSubmitted. This is needed to fix the submit form bug. (WebCore::selectorForKeyEvent): Added. This helper function converts key events into selectors that the autocomplete code needs to know about. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): Convert saved form and formValues into DOMElement and NSMutableDictionary. (WebCore::FrameMac::textFieldDidBeginEditing): Added so the input element can send this notification over the bridge. (WebCore::FrameMac::textFieldDidEndEditing): ditto. (WebCore::FrameMac::textDidChangeInTextField): ditto. (WebCore::FrameMac::doTextFieldCommandFromEvent): ditto. Also calls selectorForKeyEvent. (WebCore::FrameMac::textWillBeDeletedInTextField): ditto.
  • page/Frame.cpp: (WebCore::Frame::textFieldDidBeginEditing): ditto. (WebCore::Frame::textFieldDidEndEditing): ditto. (WebCore::Frame::textDidChangeInTextField): ditto. (WebCore::Frame::doTextFieldCommandFromEvent): ditto. (WebCore::Frame::textWillBeDeletedInTextField): ditto.
  • page/Frame.h: ditto.
  • platform/PlatformString.h: (WebCore::String::replace): Added to use an existing version of StringImpl::replace.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Setting the selection here should close the typing command. (WebCore::RenderTextField::subtreeHasChanged): Calls textDidChangeInTextField.
  • dom/Document.cpp: (WebCore::Document::setFocusNode): Calls dispatchFocusEvent and dispatchBlurEvent instead of directly dispatching the events. This gives the node a chance to do other work before dispatching the event.
  • dom/EventTargetNode.cpp:
(WebCore
EventTargetNode::dispatchFocusEvent): Added.
(WebCore
EventTargetNode::dispatchBlurEvent): Added.
  • dom/EventTargetNode.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): initializes m_autofilled. (WebCore::HTMLInputElement::dispatchFocusEvent): Calls textFieldDidBeginEditing and then calls up to the base class (WebCore::HTMLInputElement::dispatchBlurEvent): Calls textFieldDidEndEditing and then calls up to the base class (WebCore::HTMLInputElement::defaultEventHandler): For keypress events, calls doTextFieldCommandFromEvent so the form delegate will have a chance to say whether or not it is going to handle the event.

(WebCore::HTMLInputElement::isKeyboardFocusable): Uses isNonWidgetTextField instead of checking the inputType.

(WebCore::HTMLInputElement::isMouseFocusable): ditto.
(WebCore::HTMLInputElement::focus): ditto.
(WebCore::HTMLInputElement::constrainValue): Uses isTextField instead of checking inputType.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): ditto.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTextField): Added. Checks for TEXT, PASSWORD, and SEARCH (WebCore::HTMLInputElement::isNonWidgetTextField): Added. Checks for all converted controls. (WebCore::HTMLInputElement::autofilled): Added. (WebCore::HTMLInputElement::setAutofilled): Added.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Uses isNonWidgetTextField instead of checking the inputType.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): If the deletion is occuring in a text field, call textWillBeDeletedInTextField so the frame can call across the bridge to notify the form delegate.
  • css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType): Added autofill string for "-khtml-autofill".
  • css/css_base.h: (WebCore::CSSSelector::): Added PseudoAutofill to enum.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added case for PseudoAutofill that checks the input element's autofilled flag. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
  • css/html4.css: Added background-color and background-image for input:-khtml-autofill style. Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
  • css/CSSValueKeywords.in: ditto.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto. (WebCore::CSSParser::parseShadow): ditto.
6:31 PM Changeset in webkit [13853] by justing
  • 110 edits in trunk

LayoutTests:

Reviewed by hyatt



  • css1/basic/class_as_selector-expected.txt:
  • css1/basic/containment-expected.txt:
  • css1/basic/contextual_selectors-expected.txt:
  • css1/basic/id_as_selector-expected.txt:
  • css1/box_properties/border_bottom-expected.txt:
  • css1/box_properties/border_left-expected.txt:
  • css1/box_properties/border_right_inline-expected.txt:
  • css1/box_properties/border_top-expected.txt:
  • css1/box_properties/clear_float-expected.txt:
  • css1/box_properties/margin-expected.txt:
  • css1/box_properties/margin_bottom-expected.txt:
  • css1/box_properties/margin_left-expected.txt:
  • css1/box_properties/margin_right-expected.txt:
  • css1/box_properties/margin_top-expected.txt:
  • css1/box_properties/padding_left-expected.txt:
  • css1/box_properties/padding_right-expected.txt:
  • css1/cascade/cascade_order-expected.txt:
  • css1/classification/display-expected.txt:
  • css1/classification/list_style-expected.txt:
  • css1/classification/list_style_image-expected.txt:
  • css1/classification/list_style_position-expected.txt:
  • css1/classification/list_style_type-expected.txt:
  • css1/conformance/forward_compatible_parsing-expected.txt:
  • css1/pseudo/anchor-expected.txt:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • css2.1/t0505-c16-descendant-01-e-expected.txt:
  • css2.1/t050803-c14-classes-00-e-expected.txt:
  • css2.1/t0509-c15-ids-01-e-expected.txt:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-01-b-expected.txt:
  • css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-line-002-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/selection/selectNode-expected.txt:
  • editing/selection/selectNodeContents-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-before-expected.txt:
  • fast/block/float/014-expected.txt:
  • fast/css-generated-content/009-expected.txt:
  • fast/css/001-expected.txt:
  • fast/css/001-expected.png:
  • fast/css/001-expected.checksum:
  • fast/css/continuationCrash-expected.txt:
  • fast/css/list-outline-expected.txt:
  • fast/doctypes/001-expected.txt:
  • fast/doctypes/002-expected.txt:
  • fast/doctypes/003-expected.txt:
  • fast/doctypes/004-expected.txt:
  • fast/dom/window-onFocus-expected.txt:
  • fast/forms/form-hides-table-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/lists/001-expected.checksum:
  • fast/lists/001-expected.png:
  • fast/lists/001-expected.txt:
  • fast/lists/002-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/lists/004-expected.txt:
  • fast/lists/005-expected.txt:
  • fast/lists/006-expected.txt:
  • fast/lists/007-expected.txt:
  • fast/lists/008-expected.txt:
  • fast/lists/009-expected.txt:
  • fast/lists/drag-into-marker-expected.txt:
  • fast/lists/li-br-expected.txt:
  • fast/lists/ol-display-types-expected.txt:
  • fast/lists/olstart-expected.txt:
  • fast/lists/scrolled-marker-paint-expected.txt:
  • fast/overflow/overflow-rtl-expected.txt:
  • fast/parser/entities-in-xhtml-expected.txt:
  • fast/selectors/001-expected.txt:
  • fast/selectors/013-expected.txt:
  • fast/selectors/015-expected.txt:
  • fast/selectors/166-expected.txt:
  • fast/table/018-expected.txt:
  • fast/table/form-with-table-style-expected.txt:
  • fast/text/whitespace/tab-character-basics-expected.txt:
  • fast/tokenizer/004-expected.txt:
  • tables/mozilla/bugs/bug23235-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.txt:
  • tables/mozilla/bugs/bug3191-expected.txt:
  • tables/mozilla/bugs/bug32205-2-expected.txt:
  • tables/mozilla/marvin/backgr_index-expected.txt:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/x_table-expected.txt:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:

WebCore:

Reviewed by hyatt



  • manual-tests/list-marker-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Call positionListMarker() after laying out the children. (WebCore::RenderBlock::calcInlineMinMaxWidth): Call calcWidth() on the child if we are going to use its marginLeft() or marginRight(), which is if they are given as a percentage or if the child is a list marker.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionListMarker): Added this virtual function which RenderListItem implements and which is called from layoutBlock().
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Avoid adding focus rings around outside list markers. Previously it did not matter since the markers had zero width.
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Outside list markers should not contribute to the line width, even now that they have width.
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Skip outside list markers.
  • rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker): Added. (WebCore::RenderListMarker::paint): Removed code that was used to right-align outside text markers, since that is achieved by margins now. (WebCore::RenderListMarker::calcMinMaxWidth): Changed the marker height to be the font height. Made the width of outside list markers non-zero and equal to the width of inside markers. Changed the width to include only the marker and not any padding. Increased the width of bullets by 2 to contain spillage due to antialiasing. (WebCore::RenderListMarker::calcWidth): Calculate horizontal margins. Padding that was previously included in the width is now part of the margins. (WebCore::RenderListMarker::getRelativeMarkerRect): Adjusted for the changes to width and margins.
  • rendering/render_list.h:
5:36 PM Changeset in webkit [13852] by darin
  • 3 edits
    14 moves in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved some more files out of KWQ to more-permanent homes
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/BlockExceptions.h: Removed.
  • kwq/BlockExceptions.mm: Removed.
  • kwq/ClipboardMac.h: Removed.
  • kwq/ClipboardMac.mm: Removed.
  • kwq/DeprecatedPtrList.h: Removed.
  • kwq/DeprecatedPtrListImpl.cpp: Removed.
  • kwq/DeprecatedPtrListImpl.h: Removed.
  • kwq/DeprecatedValueList.h: Removed.
  • kwq/DeprecatedValueListImpl.cpp: Removed.
  • kwq/DeprecatedValueListImpl.h: Removed.
  • kwq/WebCoreTextArea.h: Removed.
  • kwq/WebCoreTextArea.mm: Removed.
  • kwq/WebCoreTextField.h: Removed.
  • kwq/WebCoreTextField.mm: Removed.
  • platform/DeprecatedPtrList.h: Added.
  • platform/DeprecatedPtrListImpl.cpp: Added.
  • platform/DeprecatedPtrListImpl.h: Added.
  • platform/DeprecatedValueList.h: Added.
  • platform/DeprecatedValueListImpl.cpp: Added.
  • platform/DeprecatedValueListImpl.h: Added.
  • platform/mac/BlockExceptions.h: Added.
  • platform/mac/BlockExceptions.mm: Added.
  • platform/mac/ClipboardMac.h: Added.
  • platform/mac/ClipboardMac.mm: Added.
  • platform/mac/WebCoreTextArea.h: Added.
  • platform/mac/WebCoreTextArea.mm: Added.
  • platform/mac/WebCoreTextField.h: Added.
  • platform/mac/WebCoreTextField.mm: Added.
5:21 PM Changeset in webkit [13851] by harrison
  • 10 edits
    4 adds in trunk/LayoutTests

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

  • editing/editing.js: Add sentence navigation/selection.


  • editing/selection/extend-by-sentence-001-expected.txt: Added.
  • editing/selection/extend-by-sentence-001.html: Added. Test for both <rdar://problem/4386640> and <rdar://problem/4414575>.


  • fast/dom/inner-text-001-expected.txt: Added.
  • fast/dom/inner-text-001.html: Added. Tests innerText on a variety of elements.


  • fast/dom/HTMLObjectElement/form/test1-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/forms/button-in-forms-collection-expected.txt:
  • fast/forms/focus-control-to-page-expected.txt:
  • fast/forms/focus-expected.txt:
  • fast/forms/textarea-hard-linewrap-expected.txt:
  • fast/forms/textarea-setvalue-submit-expected.txt:
  • fast/loader/loadInProgress-expected.txt: Updated for innerText changes that emit newlines for more kinds of blocks.
5:18 PM Changeset in webkit [13850] by harrison
  • 4 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app


(see related changes in WebCore)


Tests added:

  • editing/selection/extend-by-sentence-001.html: Added.
  • fast/dom/inner-text-001.html: Added.
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray selectSentence:]):
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h: Add sentence navigation and selection.
5:14 PM Changeset in webkit [13849] by harrison
  • 10 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

AXPreviousSentenceStartTextMarkerForTextMarker failed to stop at the beginning a block because
SimplifiedBackwardsTextIterator::handleNonTextNode() emitted a space when exiting the block.
Fixed by emitting a newline instead.


Word boundary failed to stop at the beginning of a block because no character at all was emitted
when leaving the block, because the exitNode was checking specific html tags to decide whether the
node is block, but the node was xml. Fixed by using the node's renderer, if present.


(see related changes in WebKit)


Tests added:

  • editing/selection/extend-by-sentence-001.html: Added.
  • fast/dom/inner-text-001.html: Added.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Add sentence navigation/selection.


  • editing/Selection.cpp: (WebCore::Selection::validate): Add sentence navigation/selection.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify): Add sentence navigation/selection.
  • editing/TextGranularity.h: (WebCore::): Add SentenceGranularity and SentenceBoundary.
  • editing/TextIterator.cpp: (WebCore::isTableCell): (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlineForNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode): (WebCore::shouldEmitExtraNewlineForNode): New utility functions that prefer renderers over html tag names.

(WebCore::TextIterator::handleNonTextNode):
(WebCore::TextIterator::exitNode):
(WebCore::SimplifiedBackwardsTextIterator::advance):
Use new utility functions.


(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
Use new utility functions. Also emit linefeed instead of space,
so sentence parsing works across block boundaries.


(WebCore::SimplifiedBackwardsTextIterator::exitNode):
Use new utility functions.

(WebCore::SimplifiedBackwardsTextIterator::emitNewline):
Renamed from emitNewlineForBROrText because it is not always for BR or text.


  • editing/TextIterator.h: Renamed emitNewlineForBROrText to emitNewline.


  • editing/visible_units.cpp:
  • editing/visible_units.h: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Add sentence navigation/selection.
4:54 PM Changeset in webkit [13848] by darin
  • 11 edits
    4 copies
    1 move
    1 delete in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved Decoder and FormData classes into loader directory (Decoder, because it's part of the loading process.

FormData, because it's used as a parameter when specifying
what to load. Arguably either could be in page instead.)

  • moved Length.h from css to renderer, cause that's where Hyatt says it belongs
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml: Removed.
  • loader/Decoder.cpp: Added.
  • loader/Decoder.h: Added.
  • loader/FormData.cpp: Added.
  • loader/FormData.h: Added.
  • css/Length.h: Removed.
  • rendering/Length.h: Added.
  • bridge/mac/WebCoreEncodings.mm:
  • dom/Document.h:
  • kwq/KWQFormData.mm:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXSLStyleSheet.cpp:
  • page/ResourceRequest.h:
  • platform/TransferJobInternal.h:
  • xml/xmlhttprequest.cpp: Updated includes.
4:49 PM Changeset in webkit [13847] by darin
  • 2 edits in trunk/WebKitTools

Rubber-stamped by Darin.

  • BuildSlaveSupport/build-launcher-dmg: Use the -srcfolder option to 'hdiutil create'. This creates the initial disk image based on the size of the source folder, and copies the contents to the new disk image. The file extension on the temporary uncompressed disk image has also been altered from ".uncompressed" to ".uncompressed.dmg" as hdiutil on 10.4.6 Intel fails when the extension is not ".dmg".
4:13 PM Changeset in webkit [13846] by justing
  • 2 edits
    1 add in trunk/WebCore

Reviewed by darin

  • manual-tests/inline-outline-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Add the maximal outline width to the inlines' repaint rect.
4:01 PM Changeset in webkit [13845] by hyatt
  • 2 edits in trunk/LayoutTests/http/tests/misc

Fix broken test results.

2:54 PM Changeset in webkit [13844] by justing
  • 1 edit in trunk/WebCore/editing/JSEditor.cpp

Removed unnecessary check for an empty string.

2:51 PM Changeset in webkit [13843] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

  • editing/deleting/merge-unrendered-space.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum: Added.
  • editing/execCommand/insertHorizontalRule-expected.png: Added.
  • editing/execCommand/insertHorizontalRule-expected.txt: Added.
  • editing/execCommand/insertHorizontalRule.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

  • editing/JSEditor.cpp:
2:50 PM Changeset in webkit [13842] by eseidel
  • 1 copy in branches/treecode-stable

Make a "stable" copy of treecode, which ggaren and I can drive towards TOT, independent of mjs' re-working.

2:43 PM Changeset in webkit [13841] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Part of <rdar://problem/4482530>

  • WebView/WebView.m: (-[WebView _focusedFrame]): Fixed up the logic here to take into account immediate subviews of WebView, which are not actually in a WebFrameView (they are peers to the main frame's WebFrameView).
1:21 PM Changeset in webkit [13840] by hyatt
  • 7 edits in trunk/LayoutTests/fast

Land updated results for overflow changes.

1:02 PM Changeset in webkit [13839] by darin
  • 3 edits
    4 copies
    2 deletes in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved xsl files into xml directory, removed xbl files (for now)
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/xbl: Removed.
  • khtml/xsl: Removed.
  • xml/XSLStyleSheet.cpp: Added.
  • xml/XSLStyleSheet.h: Added.
  • xml/XSLTProcessor.cpp: Added.
  • xml/XSLTProcessor.h: Added.
12:52 PM Changeset in webkit [13838] by hyatt
  • 4 edits in trunk/WebCore

Fix for 5283, make sure overflow doesn't paint on top of positioned elements.

Reviewed by beth

  • kwq/RenderTreeAsText.cpp: (writeLayers):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::dirtyOverflowList): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isOverflowOnly): (WebCore::RenderLayer::overflowList):
11:31 AM Changeset in webkit [13837] by eseidel
  • 2 edits in trunk/WebKitTools

2006-04-12 Eric Seidel <​eseidel@apple.com>

Reviewed by Tim H.

  • Scripts/update-webkit: Make this return non-zero when svn fails.
9:32 AM Changeset in webkit [13836] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Turn SVG support back on. I accidentally checked in this file with SVG off last night.
9:22 AM Changeset in webkit [13835] by darin
  • 4 edits in trunk/WebCore
  • try to fix Windows build
  • platform/TransferJobInternal.h: Declare HANDLE.
  • platform/image-decoders/gif/GIFImageReader.h: Include GIFImageDecoder.h.
  • rendering/RenderThemeWin.h: Declare HANDLE and HMODULE.
9:08 AM Changeset in webkit [13834] by darin
  • 3 edits in trunk/WebCore
  • another attempt to get things building
  • bindings/js/kjs_proxy.cpp: Add "kjs_events.h" include, needed when not building SVG (so for Windows too).
  • editing/TextIterator.h: Add back include of Vector.h.

Apr 11, 2006:

10:31 PM Changeset in webkit [13833] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Minor code cleanup -- passes all the JS tests.

  • kjs/object_object.cpp: (ObjectObjectImp::construct): (ObjectObjectImp::callAsFunction):
9:46 PM Changeset in webkit [13832] by darin
  • 9 edits in trunk

JavaScriptCore:

  • another attempt to fix Windows build -- Vector in Forward.h was not working
  • kxmlcore/Forward.h: Remove Vector.
  • kxmlcore/Vector.h: Add back default arguments, remove include of Forward.h.

WebCore:

  • try to fix Windows build
  • html/HTMLCollection.h: Add back include of Vector.h.
  • page/Frame.h: Ditto.
  • platform/Timer.h: Ditto.
  • more changes for no-SVG (not working yet though)
  • editing/CompositeEditCommand.h: Added css_valueimpl.h include.
9:15 PM Changeset in webkit [13831] by darin
  • 3 edits in trunk/WebCore
  • try to fix no-SVG build
  • kwq/RenderTreeAsText.cpp: Added back an include only needed for non-SVG.
  • rendering/RenderObject.h: Ditto.
9:07 PM Changeset in webkit [13830] by darin
  • 12 edits
    3 deletes in trunk

JavaScriptCore:

  • try to fix Windows build -- HashForward.h was not working
  • kxmlcore/HashForward.h: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Remove HashForward.h.
  • kjs/collector.h: Remove use of HashForward.h.
  • kxmlcore/HashCountedSet.h: Remove include of HashForward.h, restore default arguments.
  • kxmlcore/HashMap.h: Ditto.
  • kxmlcore/HashSet.h: Ditto.

JavaScriptGlue:

  • try to fix Windows build
  • kxmlcore/HashForward.h: Removed.

WebCore:

  • try to fix Windows build
  • ForwardingHeaders/kxmlcore/HashForward.h: Removed.
  • dom/xml_tokenizer.h: Include another header instead of HashForward.h.
  • loader/Cache.h: Ditto.
  • page/Page.h: Ditto.
  • platform/TransferJob.h: Ditto.
8:14 PM Changeset in webkit [13829] by justing
  • 2 edits in trunk
7:07 PM Changeset in webkit [13828] by justing
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

Added to test changes:

  • editing/pasteboard/merge-end-1-expected.checksum: Added.
  • editing/pasteboard/merge-end-1-expected.png: Added.
  • editing/pasteboard/merge-end-1-expected.txt: Added.
  • editing/pasteboard/merge-end-1.html: Added.
  • editing/pasteboard/merge-end-2-expected.checksum: Added.
  • editing/pasteboard/merge-end-2-expected.png: Added.
  • editing/pasteboard/merge-end-2-expected.txt: Added.
  • editing/pasteboard/merge-end-2.html: Added.


Use the editing library so the test can be run in slow motion.

  • editing/deleting/merge-unrendered-space.html:


Merges after pasted content no longer happen unnecessary. These
tests used to do unnecessary merges that happened to move nodes
that served as selection endpoints, which cleared the selection.
So, you'll see changes to the selection change delegate calls.

  • editing/pasteboard/8145-2-expected.txt:
  • editing/pasteboard/paste-line-endings-010-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:

WebCore:

Reviewed by harrison


Fixes more instances of:
<rdar://problem/3950559>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Do paragraph merging using moveParagraphs.
6:18 PM Changeset in webkit [13827] by eseidel
  • 63 edits
    3 copies
    1 delete in branches/treecode/JavaScriptCore

Merged with HEAD (13826), rs=timo.

6:08 PM Changeset in webkit [13826] by eseidel
  • 1 edit in branches/treecode/JavaScriptCore/kjs/TreeCode.cpp

.5% speedup on ibench by using Completion&. r=darin

5:57 PM Changeset in webkit [13825] by justing
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/merge-unrendered-space-expected.checksum: Added.
  • editing/deleting/merge-unrendered-space-expected.png: Added.
  • editing/deleting/merge-unrendered-space-expected.txt: Added.
  • editing/deleting/merge-unrendered-space.html: Added.

WebCore:

Reviewed by harrison


Some setup for work on paste performance.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Moved code from mergeParagraphs so that it can be used in ReplaceSelectionCommand.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): Put the code that chooses m_deepPosition into initDeepPosition. (WebCore::VisiblePosition::initDeepPosition): Fixed a bug: don't fall through to the code that's only for positions inside unrendered space between blocks when there's a candidate downstream() is a candidate. Added a comment about why the fall through code is necessary.
  • editing/VisiblePosition.h:
1:02 PM Changeset in webkit [13824] by harrison
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • fixed clean build, broken by Darin's check-in
  • kjs/date_object.cpp: Add needed include of lookup.h.
  • kjs/regexp_object.cpp: Move include of .lut.h file below other includes.
12:45 PM Changeset in webkit [13823] by eseidel
  • 2 edits in trunk/WebKitSite

2006-04-11 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

  • quality/testing.html: fix run-mozilla-tests to run-javascriptcore-tests
10:51 AM Changeset in webkit [13822] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.


  • fixed <rdar://problem/4509328> highlight all matches hangs when searching for tab character on www.google.com (and others)


For reasons not yet completely understood, searching for a tab character on some pages (Google, Amazon) finds a match
with a non-collapsed range but then claims that the end visible position of the match is the original start visible
position of the search range. This was causing the highlightAllMatches code to loop forever. Fixed the loop by
checking for the non-advancing search range explicitly. I'm going to track down a reduction of the bogus
search-for-tab issue, and write that up as a separate bug (that bug is not a regression; you can "find" a tab on
google in Tiger also).

  • page/Frame.cpp: (WebCore::Frame::highlightAllMatchesForString): break the loop if the search range hasn't advanced
9:30 AM Changeset in webkit [13821] by darin
  • 352 edits
    7 adds
    1 delete in trunk

JavaScriptCore:

Rubber-stamped by John Sullivan.

  • switched from a shell script to a makefile for generated files
  • removed lots of unneeded includes
  • added new Forward.h and HashForward.h headers that allow compiling with fewer unneeded templates
  • DerivedSources.make: Added.
  • generate-derived-sources: Removed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files, changed to use DerivedSources.make.
  • kxmlcore/Forward.h: Added.
  • kxmlcore/HashForward.h: Added.
  • kxmlcore/HashCountedSet.h: Include HashForward for default args.
  • kxmlcore/HashMap.h: Ditto.
  • kxmlcore/HashSet.h: Ditto.
  • kjs/object.h:
  • kjs/object.cpp: Moved KJS_MAX_STACK into the .cpp file.
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_instance.h:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_runtime.h:
  • bindings/jni/jni_utility.h:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/WebScriptObjectPrivate.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm:
  • bindings/objc/objc_instance.h:
  • bindings/objc/objc_instance.mm:
  • bindings/objc/objc_runtime.mm:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.h:
  • bindings/runtime_array.cpp:
  • bindings/runtime_array.h:
  • bindings/runtime_method.cpp:
  • bindings/runtime_method.h:
  • bindings/runtime_object.cpp:
  • bindings/runtime_root.h:
  • kjs/JSImmediate.cpp:
  • kjs/Parser.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/collector.h:
  • kjs/context.h:
  • kjs/debugger.cpp:
  • kjs/error_object.h:
  • kjs/function_object.h:
  • kjs/internal.h:
  • kjs/lexer.cpp:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object_object.cpp:
  • kjs/operations.cpp:
  • kjs/protected_reference.h:
  • kjs/reference.h:
  • kjs/reference_list.h:
  • kjs/regexp_object.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
  • kjs/testkjs.cpp:
  • kjs/value.cpp:
  • kjs/value.h:
  • kxmlcore/HashTable.h:
  • kxmlcore/ListRefPtr.h:
  • kxmlcore/TCPageMap.h:
  • kxmlcore/Vector.h: Removed unneeded header includes.

JavaScriptGlue:

Rubber-stamped by John Sullivan.

  • added forwarding headers for the new Forward.h and HashForward.h files
  • kxmlcore/Forward.h: Added.
  • kxmlcore/HashForward.h: Added.

WebCore:

Rubber-stamped by John Sullivan (except for pbxproj change).

  • updated to use the new Forward.h and HashForward.h headers
  • moved the showTree debugging functions out of the WebCore namespace so they are easier to call from gdb, and renamed the showTree member functions so they don't get in the way; now you can do "call showTree(x)" in gdb and it just works
  • removed a lot of unneeded includes
  • WebCore.xcodeproj/project.pbxproj: Fixed a lot of paths that were not relative to the enclosing group.
  • ForwardingHeaders/kxmlcore/Forward.h: Added.
  • ForwardingHeaders/kxmlcore/HashForward.h: Added.
  • bindings/js/JSCanvasRenderingContext2DBase.cpp:
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_navigator.cpp:
  • bindings/js/kjs_navigator.h:
  • bindings/js/kjs_proxy.cpp:
  • bindings/js/kjs_traversal.h:
  • bindings/js/kjs_window.cpp:
  • bindings/js/kjs_window.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMImplementationFront.h:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/DOMUtility.mm:
  • bindings/objc/DOMViews.mm:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.mm:
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCoreFrameNamespaces.mm:
  • bridge/mac/WebCoreJavaScript.mm:
  • bridge/win/PageWin.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • css/css_base.h:
  • css/css_ruleimpl.h:
  • css/css_valueimpl.cpp:
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • dom/AbstractView.h:
  • dom/AtomicStringList.h:
  • dom/Attribute.cpp:
  • dom/Attribute.h:
  • dom/Comment.cpp:
  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/DOMImplementation.h:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/Element.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dump): (WebCore::forbidEventDispatch): (WebCore::allowEventDispatch): (WebCore::eventDispatchForbidden):
  • dom/EventTargetNode.h: (WebCore::EventTargetNode::postDispatchEventHandler):
  • dom/NamedAttrMap.h:
  • dom/Node.cpp: (WebCore::Node::showNode): (WebCore::Node::showTree): (WebCore::Node::showTreeAndMark): (showTree):
  • dom/Node.h:
  • dom/NodeList.cpp:
  • dom/NodeList.h:
  • dom/Position.cpp: (showTree):
  • dom/Position.h:
  • dom/Range.cpp:
  • dom/Range.h:
  • dom/StyledElement.cpp:
  • dom/StyledElement.h:
  • dom/dom2_eventsimpl.cpp:
  • dom/dom2_eventsimpl.h:
  • dom/dom2_traversalimpl.h:
  • dom/dom_xmlimpl.cpp:
  • dom/xml_tokenizer.cpp:
  • dom/xml_tokenizer.h:
  • editing/AppendNodeCommand.cpp:
  • editing/ApplyStyleCommand.cpp:
  • editing/ApplyStyleCommand.h:
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/CreateLinkCommand.cpp:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/DeleteFromTextNodeCommand.h:
  • editing/DeleteSelectionCommand.cpp:
  • editing/EditCommand.cpp:
  • editing/EditCommand.h:
  • editing/HTMLInterchange.cpp:
  • editing/InsertIntoTextNodeCommand.cpp:
  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertNodeBeforeCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/JSEditor.cpp:
  • editing/JoinTextNodesCommand.cpp:
  • editing/MergeIdenticalElementsCommand.cpp:
  • editing/ModifySelectionListLevelCommand.cpp:
  • editing/MoveSelectionCommand.cpp:
  • editing/RebalanceWhitespaceCommand.h:
  • editing/RemoveCSSPropertyCommand.h:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/ReplaceSelectionCommand.h:
  • editing/Selection.cpp: (WebCore::Selection::formatForDebugger): (WebCore::Selection::showTree): (showTree):
  • editing/Selection.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::formatForDebugger): (WebCore::SelectionController::showTree): (showTree):
  • editing/SelectionController.h:
  • editing/TextIterator.cpp:
  • editing/TextIterator.h:
  • editing/TypingCommand.cpp:
  • editing/TypingCommand.h:
  • editing/UnlinkCommand.cpp:
  • editing/VisiblePosition.cpp: (WebCore::isEqualIgnoringAffinity): (WebCore::VisiblePosition::formatForDebugger): (WebCore::VisiblePosition::showTree): (showTree):
  • editing/VisiblePosition.h: (WebCore::VisiblePosition::VisiblePosition): (WebCore::operator==):
  • editing/WrapContentsInDummySpanCommand.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:
  • editing/markup.h: (WebCore::):
  • editing/visible_units.cpp:
  • html/CanvasGradient.cpp:
  • html/CanvasRenderingContext2D.h:
  • html/CanvasStyle.cpp:
  • html/CanvasStyle.h:
  • html/FormDataList.cpp:
  • html/FormDataList.h:
  • html/HTMLCollection.cpp:
  • html/HTMLCollection.h:
  • html/HTMLDocument.cpp:
  • html/HTMLDocument.h:
  • html/HTMLElement.cpp:
  • html/HTMLElementFactory.cpp:
  • html/HTMLElementFactory.h:
  • html/HTMLFormCollection.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLParser.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLSelectElement.h:
  • html/HTMLTokenizer.cpp:
  • html/HTMLTokenizer.h:
  • html/html_baseimpl.cpp:
  • html/html_headimpl.h:
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasFilters.h:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderPath.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerPattern.h:
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • khtml/misc/decoder.cpp:
  • khtml/misc/decoder.h:
  • khtml/xsl/XSLStyleSheet.cpp:
  • khtml/xsl/XSLTProcessor.cpp:
  • khtml/xsl/XSLTProcessor.h:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/ecma/GlobalObject.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimatedColor.h:
  • ksvg2/svg/SVGAnimatedLengthList.h:
  • ksvg2/svg/SVGAnimatedNumberList.h:
  • ksvg2/svg/SVGAnimatedString.h:
  • ksvg2/svg/SVGAnimatedTransformList.h:
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGTransform.h:
  • kwq/AccessibilityObjectCache.mm:
  • kwq/ClipboardMac.mm:
  • kwq/JavaAppletWidget.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQEditCommand.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQTextEdit.mm:
  • kwq/RegularExpression.h:
  • kwq/RenderTreeAsText.cpp:
  • kwq/RenderTreeAsText.h:
  • kwq/WebCoreAXObject.mm:
  • loader/Cache.cpp:
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp:
  • loader/CachedObject.h:
  • loader/CachedScript.cpp:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTree.cpp:
  • page/FrameTree.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
  • platform/Color.cpp:
  • platform/FloatRect.h:
  • platform/Font.cpp:
  • platform/Font.h:
  • platform/FontFamily.cpp:
  • platform/GraphicsContext.cpp:
  • platform/Image.cpp:
  • platform/Image.h:
  • platform/IntRect.h:
  • platform/KURL.cpp:
  • platform/KURL.h:
  • platform/SegmentedString.h:
  • platform/Shared.h:
  • platform/StreamingTextDecoder.cpp:
  • platform/StringImpl.cpp:
  • platform/StringImpl.h:
  • platform/TextEncoding.h:
  • platform/Timer.cpp:
  • platform/Timer.h:
  • platform/TransferJob.cpp:
  • platform/TransferJob.h:
  • platform/TransferJobInternal.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/cairo/ImageCairo.cpp:
  • platform/cairo/ImageSourceCairo.cpp:
  • platform/image-decoders/gif/GIFImageReader.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/mac/FontFamilyMac.mm:
  • platform/mac/FontMac.mm:
  • platform/mac/ImageMac.mm:
  • platform/mac/TextEncodingMac.cpp:
  • platform/mac/TransferJobMac.mm:
  • platform/win/FontPlatformDataWin.cpp:
  • platform/win/TransferJobWin.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderCanvas.cpp:
  • rendering/RenderCanvas.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.cpp:
  • rendering/RenderFlow.h:
  • rendering/RenderImage.cpp:
  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (showTree):
  • rendering/RenderObject.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/RenderTextField.cpp:
  • rendering/RenderTextFragment.h:
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.mm:
  • rendering/RenderThemeWin.cpp:
  • rendering/bidi.cpp:
  • rendering/render_form.h:
  • rendering/render_line.cpp: (showTree):
  • rendering/render_line.h:
  • rendering/render_list.cpp:
  • rendering/render_replaced.cpp:
  • rendering/render_replaced.h:
  • rendering/render_style.cpp:
  • rendering/render_style.h:
  • xml/xmlhttprequest.h:
4:17 AM Changeset in webkit [13820] by eseidel
  • 2 edits in branches/treecode/JavaScriptCore

misc small speedups to bring 2% more on the js ibench. r=mjs

2:03 AM Changeset in webkit [13819] by eseidel
  • 9 edits in branches/treecode/JavaScriptCore/kjs

Roll DeclaredFunctionImp::call() down into the interpreter loop for a 5% speed gain on ibench. r=mjs

Note: See TracTimeline for information about the timeline view.