⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 19, 2006:

11:31 PM Changeset in webkit [13986] by adele
  • 2 edits in trunk/LayoutTests

Updated test to use webkit-block-placeholder instead of khtml-block-placeholder.

  • editing/inserting/insert-div-010.html:
11:05 PM Changeset in webkit [13985] by adele
  • 4 edits in trunk/LayoutTests

Updating test results that were incorrectly checked in
when many of the table test results changed recently due to Color
improvements.

  • tables/mozilla/bugs/bug625-expected.checksum:
  • tables/mozilla/bugs/bug625-expected.png:
  • tables/mozilla/bugs/bug625-expected.txt:
10:22 PM Changeset in webkit [13984] by adele
  • 4 edits in trunk/LayoutTests

Updated results after rolling out optimizations in setInnerText and setInnerHTML.

  • fast/events/updateLayoutForHitTest-expected.txt:
  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/text/attributed-substring-from-range-expected.txt:
8:01 PM Changeset in webkit [13983] by adele
  • 2 edits in trunk/WebCore

Rubber-stamped by Darin.

Removed optimizations recently added in setInnerHTML and setInnerText. The setInnerHTML change broke a first-letter style test.
The setInnerText change caused an empty text node to get added when setting inner text to an empty string. The bug that this
change went in with remains fixed.

  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): (WebCore::HTMLElement::setInnerText):
7:51 PM Changeset in webkit [13982] by thatcher
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Haytt.

  • manual-tests/repaint-resized-overflow.html: Added.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::computeRepaintRects): Set the m_repaintOverflowOnResize flag to true if our object itself needs layout or if we're an overflow and have a normal child that needs layout, in which case if we end up resizing it will be because of the child, and that child might have not repainted itself correctly during its own layout. (WebCore::RenderLayer::updateLayerPositions): Do a full repaint if m_repaintOverflowOnResize is set and we resized but didn't move.
  • rendering/RenderLayer.h:
7:33 PM Changeset in webkit [13981] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • manual-tests/dynamic-shadow.html: Added.
  • rendering/render_style.cpp: (WebCore::RenderStyle::diff): Changed to return Layout when text-shadow changes.
7:18 PM Changeset in webkit [13980] by thatcher
  • 6 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8442
Bug 8442: improvements to Cocoa bindings support in WebView - code simplification

Removes the WebController class added earlier; changes NSTreeController and
WebView to together without it. Now you can just bind the contentObject binding
of the tree controller directly to the mainFrameDocument key of the WebView.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebView/WebDataSource.m: (-[WebDataSource _setTitle:]):
  • WebView/WebFrame.m: (-[WebFrame _closeOldDataSources]):
  • WebView/WebView.m: (-[WebView _progressStarted:]): (-[WebView _finalProgressComplete]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setMainFrameDocumentReady:]): (-[WebView mainFrameDocument]):
  • WebView/WebViewPrivate.h:
7:07 PM Changeset in webkit [13979] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Fix the change log for my last commit, change was done by James G. Speth <​speth@end.com>.

7:06 PM Changeset in webkit [13978] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6635
Bug 6635: Crash selecting inspector nodes for tabs that aren't foremost

Stop observing window will close notifications before we tell the highlight window to close,
this prevents the crash. Also prevent drawing highlights for hidden tabs.

  • WebInspector/WebInspector.m: (-_highlightNode:):
  • WebInspector/WebNodeHighlight.m: (-[WebNodeHighlight expire]):
7:04 PM Changeset in webkit [13977] by adele
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Added readOnly methods for HTMLInputElement and HTMLTextAreaElement so the DOM bindings can call
a method with the same name. This will make it easier to autogenerate the DOM bindings in the future.


  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::readOnly): Added. Calls isReadOnlyControl.
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::readOnly): ditto.
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::inputGetter): Calls readOnly instead of isReadOnlyControl. (KJS::JSHTMLElement::textAreaGetter): ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement readOnly]): ditto. (-[DOMHTMLTextAreaElement readOnly]): Calls readOnly instead of getting the attribute directly. (-[DOMHTMLTextAreaElement setReadOnly:]): Calls setReadOnly instead of setting the attribute directly.
6:44 PM Changeset in webkit [13976] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6637
Bug 6637: selecting node in Inspector after closing window crashes Safari

When the window the Web Inspector was inspecting is closed, the inspector goes into its
no-selection state. Choosing to inspect another element activates it again. The inspector
will also follow the WebView if the URL changes and select the root element on the new page.

6:03 PM Changeset in webkit [13975] by adele
  • 43 edits in trunk

LayoutTests:

Updated results for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8297
REGRESSION: Input element extends outside of DIV element at ​http://www.macdock.com/

  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/3690719-expected.png:
  • editing/selection/3690719-expected.txt:
  • fast/forms/input-appearance-minWidth-expected.checksum:
  • fast/forms/input-appearance-minWidth-expected.png:
  • fast/forms/input-appearance-minWidth-expected.txt:
  • fast/forms/input-appearance-width-expected.checksum:
  • fast/forms/input-appearance-width-expected.png:
  • fast/forms/input-appearance-width-expected.txt:
  • fast/forms/input-double-click-selection-gap-bug-expected.checksum:
  • fast/replaced/width100percent-expected.checksum:
  • fast/replaced/width100percent-expected.png:
  • fast/replaced/width100percent-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.checksum:
  • tables/mozilla/bugs/bug1188-expected.png:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug12384-expected.checksum:
  • tables/mozilla/bugs/bug12384-expected.png:
  • tables/mozilla/bugs/bug12384-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.checksum:
  • tables/mozilla/bugs/bug18359-expected.png:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug55545-expected.checksum:
  • tables/mozilla/bugs/bug55545-expected.png:
  • tables/mozilla/bugs/bug55545-expected.txt:
  • tables/mozilla/bugs/bug7342-expected.checksum:
  • tables/mozilla/bugs/bug7342-expected.png:
  • tables/mozilla/bugs/bug7342-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:

WebCore:

Reviewed by Hyatt.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8297
REGRESSION: Input element extends outside of DIV element at ​http://www.macdock.com/

  • platform/Font.h: Added runRounding parameter to floatWidth.
  • platform/mac/FontMac.mm: (WebCore::Font::floatWidth): ditto.
  • platform/win/FontWin.cpp: (WebCore::Font::floatWidth): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth): Use new floatWidth parameter to turn off run rounding.
3:40 PM Changeset in webkit [13974] by adele
  • 2 edits in trunk/WebCore

Reviewed by Beth.

Fix for Windows build.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::determineState): Use isReadOnlyControl instead of isReadOnly.
3:21 PM Changeset in webkit [13973] by adele
  • 27 edits
    4 adds in trunk

LayoutTests:

Tests for change to make readonly text fields have dimmed borders.

  • fast/forms/input-appearance-readonly-expected.checksum:
  • fast/forms/input-appearance-readonly-expected.png:
  • fast/forms/input-readonly-dimmed-expected.checksum: Added.
  • fast/forms/input-readonly-dimmed-expected.png: Added.
  • fast/forms/input-readonly-dimmed-expected.txt: Added.
  • fast/forms/input-readonly-dimmed.html: Added.

WebCore:

2006-04-19 Adele Peterson <​adele@apple.com>


Reviewed by Beth.


Fix to make readonly text fields have dimmed borders to match AppKit behavior.


Test: fast/forms/input-readonly-dimmed.html


  • dom/Node.h: (WebCore::Node::isReadOnlyControl): Changed from const version of isReadOnly.
  • dom/Node.cpp: (WebCore::Node::isReadOnlyNode): Changed from isReadOnly. (WebCore::Node::setNodeValue): Uses isReadOnlyNode instead of isReadOnly. (WebCore::Node::checkSetPrefix): ditto. (WebCore::Node::checkAddChild): ditto.
  • dom/Attr.cpp: (WebCore::Attr::setValue): ditto.
  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): ditto. (WebCore::CharacterData::appendData): ditto. (WebCore::CharacterData::checkCharDataOperation): ditto.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChild): ditto.
  • dom/Element.cpp: (WebCore::Element::setAttribute): ditto.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): ditto. (WebCore::NamedAttrMap::removeNamedItem): ditto.
  • dom/NamedAttrMap.h: (WebCore::NamedAttrMap::isReadOnlyNode): ditto.
  • dom/NamedNodeMap.h: (WebCore::NamedNodeMap::isReadOnlyNode): ditto.
  • dom/Range.cpp: (WebCore::Range::checkDeleteExtract): ditto. (WebCore::Range::containedByReadOnly): ditto.
  • dom/Text.cpp: (WebCore::Text::splitText): ditto.
  • dom/dom_xmlimpl.cpp: (WebCore::ProcessingInstruction::setData): ditto.


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::inputGetter): Uses isReadOnlyControl instead of isReadOnly. (KJS::JSHTMLElement::textAreaGetter): ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement readOnly]): ditto.
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::updateFromElement): ditto. (WebCore::RenderTextArea::updateFromElement): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): ditto. (WebCore::RenderTextField::updateFromElement): ditto.


  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::parseMappedAttribute): When readonly attribute changes, update the theme so the control will repaint.
  • html/HTMLGenericFormElement.h: (WebCore::HTMLGenericFormElement::isReadOnlyControl): Renamed from readOnly.
  • html/HTMLInputElement.h: Removed isReadOnly, since isReadOnlyControl now exists on HTMLGenericFormElement.
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::isReadOnlyControl): Renamed from isReadOnly.
  • rendering/RenderTheme.h: (WebCore::): Added ReadOnlyState to ControlState enum.
  • rendering/RenderThemeMac.h: Removed NSTextFieldCell since it was only being used to store the enabled state. Removed setTextFieldState since it was updating the enabled state of the cell, which is only used in one place.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): No longer initialized the NSTextFieldCell. (WebCore::RenderThemeMac::adjustRepaintRect): No longer calls setTextFieldState. (WebCore::RenderThemeMac::paintTextField): Uses the enabled state and the readonly state to determine whether to draw a dimmed version of the aqua border.
12:35 PM Changeset in webkit [13972] by bdakin
  • 2 edits
    2 adds in trunk/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8467 Block
with percentage background-size doesn't repaint properly when it
grows

  • manual-tests/backgroundSizeRepaint.html: Added.
  • manual-tests/resources/apple.jpg: Added.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): We must return true if we have a percentage background-size.
11:47 AM Changeset in webkit [13971] by hyatt
  • 2 edits in trunk/WebCore

Fix for a regression in the new text fields. Don't allow the repaint
rect created by dynamic line layout changes to spill out of an overflow
area's clip region.

(There is no test, since we have no way of testing cases where we repaint

too much rather than too little.)

Reviewed by darin

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
11:17 AM Changeset in webkit [13970] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Fix for bug 8449, incomplete repaint of table cell that moved. This
fix also solves some of the textfield repainting problems (e.g., on
google.com and lxr.mozilla.org).

Reviewed by hyatt

  • manual-tests/table-cell-move.html: Added.
  • rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::repaintViewRectangle):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
9:45 AM Changeset in webkit [13969] by ap
  • 3 edits
    2 adds in trunk

Fix by Mitz Pettel, reviewed by Eric.

Test: fast/css/dashboard-regions-attr-crash.html

  • css/cssparser.cpp: (WebCore::CSSParser::parseDashboardRegions): Added null check for args.
4:03 AM Changeset in webkit [13968] by eseidel
  • 7 edits in trunk/WebCore

2006-04-18 Rob Buis <​buis@kde.org>

Reviewed by eseidel & darin. Landed by eseidel.

No automated tests possible (from javascript).

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6664:
Inspector does not highlight SVG elements properly

Make sure RenderObject::absoluteBoundingBoxRect works for
svg specific render objects by overriding absoluteRects.
This fixes highlighting in the Inspector of svg shapes, paths,
images and text.

  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::absoluteRects):
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::getAbsoluteRepaintRect): (WebCore::RenderSVGImage::absoluteRects):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects):
  • kcanvas/RenderSVGText.h:
3:57 AM Changeset in webkit [13967] by eseidel
  • 8 edits
    6 adds in trunk

2006-04-17 Rob Buis <​buis@kde.org>

Reviewed by eseidel. Landed by eseidel.

Test: svg/custom/tref-update.svg

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6427:
<tref> element not implemented

Implementation of <tref> element.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGTRefElement.cpp: Added. (SVGTRefElement::SVGTRefElement): (SVGTRefElement::~SVGTRefElement): (SVGTRefElement::parseMappedAttribute): (SVGTRefElement::closeRenderer): (SVGTRefElement::childShouldCreateRenderer): (SVGTRefElement::createRenderer):
  • ksvg2/svg/SVGTRefElement.h: Added. (WebCore::SVGTRefElement::rendererIsNeeded):
  • ksvg2/svg/SVGTSpanElement.cpp: (SVGTSpanElement::childShouldCreateRenderer):
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer):
  • ksvg2/svg/svgtags.in:

Apr 18, 2006:

7:03 PM Changeset in webkit [13966] by darin
  • 2 edits in trunk/WebKitTools
  • attempt to fix Windows buildbot
  • Scripts/install-win-extras: Temporarily changed URLs to fr.rpmfind.net. We need a better long-term solution for this.
5:56 PM Changeset in webkit [13965] by darin
  • 2 edits in trunk/WebKit

Reviewed by Beth.

  • WebInspector/webInspector/inspector.css: Add "-webkit-" prefixes to the border radius properties to make the corners rounded again.
5:51 PM Changeset in webkit [13964] by darin
  • 7 edits in trunk/LayoutTests

Reviewed by Beth.

  • updated some results that were affected by recent changes

There are some other failures that might be reflecting actual
bugs; these seem fine though.

  • fast/events/updateLayoutForHitTest-expected.checksum:
  • fast/events/updateLayoutForHitTest-expected.png:
  • fast/events/updateLayoutForHitTest-expected.txt: Updated because the 4 clicks done in this test now seem to be behaving as a triple-click and selecting some text.
  • fast/forms/input-appearance-maxlength-expected.txt:
  • fast/forms/input-paste-undo-expected.txt:
  • fast/text/attributed-substring-from-range-expected.txt: Unimportant changes to the editing delegate calls.
5:16 PM Changeset in webkit [13963] by darin
  • 2 edits in trunk/WebCore
  • rendering/render_form.cpp: (WebCore::RenderSelect::updateFromElement): Roll out accidentally-landed change for bug 8398.
4:47 PM Changeset in webkit [13962] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fix for a leak exposed by background-size and detected by the
layout tests.

  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValue::cleanup): We must deref pairs.
4:10 PM Changeset in webkit [13961] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Build fix for Windows. Just a few typos from background-size patch.

3:17 PM Changeset in webkit [13960] by eseidel
  • 5 edits
    3 adds in trunk

2006-04-18 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix "new Function()" to correctly use lexical scoping.
Add ScopeChain::print() function for debugging.
<rdar://problem/4067864> REGRESSION (125-407): JavaScript failure on PeopleSoft REN Server

  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/scope_chain.cpp: (KJS::ScopeChain::print):
  • kjs/scope_chain.h:
3:06 PM Changeset in webkit [13959] by bdakin
  • 19 edits
    65 adds in trunk

Reviewed by Hyatt.

Implementation of CSS3 background-size property. See
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8353 for details.

2:56 PM Changeset in webkit [13958] by jdevalk
  • 2 edits
    6 adds in trunk/WebKitSite

Added webkit detection scripts and info on how to use them.

11:14 AM Changeset in webkit [13957] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/pasteboard/merge-end-3-expected.checksum: Added.
  • editing/pasteboard/merge-end-3-expected.png: Added.
  • editing/pasteboard/merge-end-3-expected.txt: Added.
  • editing/pasteboard/merge-end-3.html: Added.

WebCore:

Reviewed by harrison

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): The placeholder that's inserted to keep content from collapsing due to pruning was inserted at the position after the moved paragraph. That's only appropriate when moving the paragraph backward into the previous paragraph.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): The last paragraph of the incoming fragment should be merged with the paragraph after the end of the selection being pasted into even if the incoming fragment has only one block. This fixes a bug and gets rid of a use of the info gathered during the test insertion.
9:43 AM Changeset in webkit [13956] by adele
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8407
REGRESSION (NativeTextField): Leading and trailing spaces trimmed from text field value attribute

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Use white-space:pre for the inner div to avoid collapsing spaces in the text field.

LayoutTests:

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8407
REGRESSION (NativeTextField): Leading and trailing spaces trimmed from text field value attribute

  • fast/forms/input-spaces-expected.checksum: Added.
  • fast/forms/input-spaces-expected.png: Added.
  • fast/forms/input-spaces-expected.txt: Added.
  • fast/forms/input-spaces.html: Added.
9:37 AM Changeset in webkit [13955] by darin
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • manual-tests/applet-param-no-name.html: Added.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary): Skip param elements with empty name.
9:30 AM Changeset in webkit [13954] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix bug number in log message.

9:28 AM Changeset in webkit [13953] by darin
  • 2 edits
    2 adds in trunk/LayoutTests

Reviewed by Geoff.


  • fast/block/float/014.html: Use local image
  • fast/block/float/resources: Added.
  • fast/block/float/resources/training_thumb.jpg: Added.
9:07 AM Changeset in webkit [13952] by darin
  • 2 edits in trunk/WebCore
  • try to fix the Windows build
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::setColor): Update for changes to getRGBA.
Note: See TracTimeline for information about the timeline view.