⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 23, 2006:

9:58 PM Changeset in webkit [14031] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • Took the larger snippets of C++ in the code generator and broke them into HERE documents in the hopes of improving readability.


  • bindings/scripts/CodeGeneratorJS.pm: I indented variable names level with their corresponding HERE documents to clearly "sandwich" the HERE documents between opening and closing EOF statements.
8:47 PM Changeset in webkit [14030] by mjs
  • 13 edits
    2 copies
    2 deletes in trunk

WebCore:

Reviewed by Darin.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreStringTruncator.h: Added.
  • bridge/mac/WebCoreStringTruncator.mm: Added. (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • bridge/mac/WebCoreViewFactory.h:
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton initWithWidget::]): (-[WebCoreFileButton positionButton]): (-[WebCoreFileButton initWithWidget:]): (-[WebCoreFileButton initWithFrame:]): (-[WebCoreFileButton dealloc]): (-[WebCoreFileButton isFlipped]): (-[WebCoreFileButton drawRect:]): (-[WebCoreFileButton updateLabel]): (-[WebCoreFileButton setFilename:]): (-[WebCoreFileButton filename]): (-[WebCoreFileButton setFrameSize:]): (-[WebCoreFileButton bestVisualFrameSizeForCharacterCount:]): (-[WebCoreFileButton visualFrame]): (-[WebCoreFileButton setVisualFrame:]): (-[WebCoreFileButton baseline]): (-[WebCoreFileButton beginSheet]): (-[WebCoreFileButton chooseFilename:]): (-[WebCoreFileButton cancel]): (-[WebCoreFileButton chooseButtonPressed:]): (-[WebCoreFileButton mouseDown:]): (-[WebCoreFileButton acceptsFirstResponder]): (-[WebCoreFileButton becomeFirstResponder]): (-[WebCoreFileButton nextKeyView]): (-[WebCoreFileButton previousKeyView]): (-[WebCoreFileButton nextValidKeyView]): (-[WebCoreFileButton previousValidKeyView]): (-[WebCoreFileButton performClick]): (-[WebFileChooserButton initWithWidget:]): (-[WebFileChooserButton nextValidKeyView]): (-[WebFileChooserButton previousValidKeyView]): (-[WebFileChooserButton resignFirstResponder]): (KWQFileButton::KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):

WebKit:

Reviewed by Darin.


  • Misc/WebStringTruncator.m: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebCoreSupport/WebFileButton.h: Removed.
  • WebCoreSupport/WebFileButton.m: Removed.
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory fileButtonChooseFileLabel]): (-[WebViewFactory fileButtonNoFileSelectedLabel]):
  • WebKit.xcodeproj/project.pbxproj:
4:11 PM Changeset in webkit [14029] by mjs
  • 7 edits
    4 deletes in trunk

WebCore:

Reviewed by Eric.

  • remove WebCoreCookieAdapter, instead make mac implementation of CookieJar use Foundation directly.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies): (WebCore::cookiesEnabled):
  • platform/mac/WebCoreCookieAdapter.h: Removed.
  • platform/mac/WebCoreCookieAdapter.m: Removed.

WebKit:

Reviewed by Eric.


  • remove WebCookieAdapter, WebCore can just use Foundation directly.
  • WebCoreSupport/WebCookieAdapter.h: Removed.
  • WebCoreSupport/WebCookieAdapter.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
4:09 PM Changeset in webkit [14028] by mjs
  • 21 edits in trunk/WebKit

Reviewed by Adele.


  • prune WebView SPI of unused calls


Specifically I moved methods that have no callers outside WebKit
to WebViewInternal.h or removed them entirely.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/WebNetscapePluginDocumentView.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebNullPluginView.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebFrameBridge.m:
  • WebCoreSupport/WebPageBridge.m:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebView/WebDataSource.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebScriptDebugDelegate.m:
  • WebView/WebView.m: (-[WebView _downloadURL:]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
3:57 PM Changeset in webkit [14027] by eseidel
  • 3 edits
    4 adds in trunk

2006-04-21 Rob Buis <​buis@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8170:
SVG CSS property values with extra items do not get treated
as invalid (they should)

Fixes the handling of invalid svg css properties similar
to how invalid html css properties are handled, ie. discard
the property if there are more values in the value list than
expected.

Test: svg/custom/invalid-css.svg

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
3:45 PM Changeset in webkit [14026] by eseidel
  • 2 edits in trunk/WebCore

2006-04-23 Michael Emmel <​mike.emmel@gmail.com>

Reviewed by mjs. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8517
No test necessary, no functional change.

  • DerivedSources.make: use VPATH more consistently.
3:39 PM Changeset in webkit [14025] by eseidel
  • 8 edits
    2 adds in trunk

2006-04-21 Jon Shier <​jshier@iastate.edu>

Reviewed by ggaren. Landed by eseidel.



  • ChangeLog:
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): changed khtmlErrorEvent to errorEvent. (KJS::DOMEventTargetNode::putValueProperty): ditto.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): ditto. (KJS::Window::put):
  • dom/EventNames.h: Removed khtmlError macro.


12:16 PM Changeset in webkit [14024] by adele
  • 3 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (dump): If display() has been called during the test, grab the pixels from the view, after letting it repaint invalidated rects. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController display]): Added. Calls -display on the view and changes the subsequent behavior of dump(). (dumpRenderTree):
2:19 AM Changeset in webkit [14023] by eseidel
  • 3 edits
    8 adds in trunk

2006-04-23 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Reproducible crasher with <li value=1234567890 type=A>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8542

Fixed our alphabetical list generation to match WinIE (not FireFox)
Previously our alphabetical lists were completely wrong past 26 items.

Tests:

  • fast/lists/alpha-list-wrap.html
  • fast/lists/li-style-alpha-huge-value-crash.html
  • rendering/render_list.cpp: (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderListMarker::calcMinMaxWidth):

Apr 22, 2006:

9:23 PM Changeset in webkit [14022] by darin
  • 1 edit in trunk/LayoutTests/fast/dom/prototype-chain-expected.txt

Geoff seems to have checked in the change log, but not the updated result.

6:52 PM Changeset in webkit [14021] by mjs
  • 73 edits
    2 deletes in trunk/WebKit

Reviewed by Eric.

  • remove WebKit copy of assertions code, use the assertions stuff from JavaScriptCore instead.
  • Carbon/HIViewAdapter.m:
  • DOM/WebDOMOperations.m:
  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • DefaultDelegates/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
  • History/WebBackForwardList.m:
  • History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): (-[WebHistoryPrivate _saveHistoryGuts:URL:error:]):
  • History/WebHistoryItem.m:
  • Misc/WebAssertions.h: Removed.
  • Misc/WebAssertions.m: Removed.
  • Misc/WebDatabase.m:
  • Misc/WebDownload.m:
  • Misc/WebFileDatabase.m: (SetThreadPriority):
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary releaseIconForURL:]): (-[NSMutableDictionary delayDatabaseCleanup]): (-[NSMutableDictionary allowDatabaseCleanup]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]):
  • Misc/WebIconLoader.m:
  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m:
  • Misc/WebKitSystemBits.m: (initCapabilities):
  • Misc/WebLRUFileList.m: (WebLRUFileListRemoveOldestFileFromList): (WebLRUFileListGetFileSize):
  • Misc/WebLocalizableStrings.m:
  • Misc/WebNSCalendarDateExtras.m:
  • Misc/WebNSDataExtras.m:
  • Misc/WebNSDictionaryExtras.m:
  • Misc/WebNSFileManagerExtras.m:
  • Misc/WebNSPasteboardExtras.m:
  • Misc/WebNSURLExtras.m: (hexDigit): (hexDigitValue): (allCharactersInIDNScriptWhiteList):
  • Misc/WebNSURLRequestExtras.m:
  • Misc/WebNSUserDefaultsExtras.m:
  • Misc/WebStringTruncator.m:
  • Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel loadNib]):
  • Panels/WebPanelAuthenticationHandler.m:
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
  • Plugins/WebBaseNetscapePluginView.m: (TSMEventHandler): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]):
  • Plugins/WebBasePluginPackage.m:
  • Plugins/WebNetscapePluginDocumentView.m:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]):
  • Plugins/WebNetscapePluginRepresentation.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m: (-[WebPluginController addPlugin:]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]):
  • Plugins/WebPluginDatabase.m:
  • Plugins/WebPluginDocumentView.m:
  • WebCoreSupport/WebCookieAdapter.m:
  • WebCoreSupport/WebFileButton.m:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge runModal]):
  • WebCoreSupport/WebImageData.m: (-[WebImageData _checkSolidColor:]): (-[WebImageData tileInRect:fromPoint:context:]): (-[WebImageData scaleAndTileInRect:fromRect:withHorizontalTileRule:withVerticalTileRule:context:]):
  • WebCoreSupport/WebImageDecoder.m:
  • WebCoreSupport/WebImageRenderer.m: (-[WebImageRenderer TIFFRepresentation]):
  • WebCoreSupport/WebImageRendererFactory.m:
  • WebCoreSupport/WebJavaScriptTextInputPanel.m:
  • WebCoreSupport/WebKeyGenerator.m:
  • WebCoreSupport/WebPageBridge.m:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebCoreSupport/WebTextRenderer.m: (widthForGlyph): (-[WebTextRenderer initWithFont:]): (drawGlyphs): (initializeATSUStyle): (createATSULayoutParameters): (getTextBounds): (ATSU_draw):
  • WebCoreSupport/WebTextRendererFactory.m:
  • WebCoreSupport/WebViewFactory.m:
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebKitPrefix.h:
  • WebView/WebArchiver.m: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
  • WebView/WebClipView.m:
  • WebView/WebDataProtocol.m:
  • WebView/WebDataSource.m: (-[WebDataSource _startLoading]):
  • WebView/WebFormDataStream.m: (formEventCallback): (webSetHTTPBody):
  • WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]):
  • WebView/WebFrameView.m:
  • WebView/WebHTMLRepresentation.m:
  • WebView/WebHTMLView.m: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): (-[NSArray drawSingleRect:]): (-[NSArray namesOfPromisedFilesDroppedAtDestination:]): (-[NSArray _scaleFactorForPrintOperation:]): (-[NSArray deleteBackwardByDecomposingPreviousCharacter:]): (-[NSArray checkSpelling:]): (-[NSArray showGuessPanel:]): (-[NSArray _changeSpellingToWord:]): (-[NSArray ignoreSpelling:]): (-[NSArray performFindPanelAction:]): (-[WebTextCompleteController doCompletion]):
  • WebView/WebImageView.m:
  • WebView/WebLoader.m: (-[NSURLProtocol connection:willCacheResponse:]):
  • WebView/WebPDFRepresentation.m: (+[WebPDFRepresentation PDFDocumentClass]):
  • WebView/WebPDFView.m: (+[WebPDFView PDFKitBundle]): (+[WebPDFView PDFViewClass]): (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
  • WebView/WebTextRepresentation.m:
  • WebView/WebTextView.m:
  • WebView/WebUnarchivingState.m:
  • WebView/WebView.m:
4:48 PM Changeset in webkit [14020] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8514
Bug 8514: Web Inspector hides when the app is in the background

Makes the inspector not hide in the background. Since the inspector is a floating panel
we need to call setFloatingPanel:NO when the app is switching into the background. Then
call setFloatingPanel:YES when the app is activated again. Without this the inspector
would float above all applications.

  • WebInspector/WebInspector.m: (-[NSWindow window]): setHidesOnDeactivate:NO (-[NSWindow windowWillClose:]): de-regiser appliction active notifications (-[NSWindow showWindow:]): register for appliction active notifications (-_applicationWillResignActive): setFloatingPanel:NO (-_applicationDidBecomeActive): setFloatingPanel:YES
3:48 PM Changeset in webkit [14019] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/JavaScriptGlue

Copying the JavaScriptGlue tag to the release tag.

3:45 PM Changeset in webkit [14018] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/JavaScriptCore

Copying the JavaScriptCore tag to the release tag.

3:44 PM Changeset in webkit [14017] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/WebCore

Copying the WebCore tag to the release tag.

3:43 PM Changeset in webkit [14016] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.6/WebKit

Copying the WebKit tag to the release tag.

3:40 PM Changeset in webkit [14015] by thatcher
  • 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.6

New release tag folder.

3:11 PM Changeset in webkit [14014] by ggaren
  • 6 edits in trunk

LayoutTests:

Reviewed by Darin.

  • Updated prototype chain expectation since DOMElement no longer exists


  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Darin.

  • Finished autogeneration of Element
  • bindings/js/kjs_dom.cpp: Removed DOMElement class
  • bindings/js/kjs_dom.h: ditto
  • bindings/scripts/CodeGeneratorJS.pm: added support for special attribute lookup that elements do
  • dom/Element.idl: added new attribute, "IncludeAttributesInPropertyLookup," which tells the code generator to include HTML element attributes in property lookup
3:01 PM Changeset in webkit [14013] by darin
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

  • rendering/RenderObject.h: Removed erroneous RenderObject:: prefix from a member function name.
  • rendering/RenderText.h: Removed erroneous RenderText:: prefix from a member function name.
  • platform/Arena.cpp: Added <assert.h> to list of includes.
  • platform/KURL.cpp: Ditto.
  • platform/StringImpl.cpp: Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
  • platform/image-decoders/png/PNGImageDecoder.cpp: Ditto.
2:57 PM Changeset in webkit [14012] by darin
  • 1 edit
    1 add in trunk/WebCore
  • doc: Added.
1:23 PM Changeset in webkit [14011] by ap
  • 11 edits
    5 adds in trunk/WebKitTools

Reviewed by Maciej.

Test case numbers are not compatible with iExploder 1.2.

  • Scripts/run-iexploder-tests: Print the numbers of the last five tests that were accessed.
  • iExploder/CHANGELOG.txt: Added.
  • iExploder/LICENSE.txt: Changed to a standard zlib/png license.
  • iExploder/README.txt: Added some performance hints.
  • iExploder/htdocs/config.rb: Added.
  • iExploder/htdocs/cssproperties.in:
  • iExploder/htdocs/cssvalues.in:
  • iExploder/htdocs/htmlattrs.in:
  • iExploder/htdocs/htmltags.in:
  • iExploder/htdocs/iexploder.cgi:
    • Updated to support the latest HTML & CSS tags, properties, and values from both the WebKit and Mozilla CVS tree
    • cssproperties.in cleanup
    • Modularized the code a little bit.
    • Fix subtest bug that was causing last 5 tags to be missed
    • new subtest algorithm to deal better with larger tag counts
    • default HTML_MAX_TAGS increased from 32 to 96
  • iExploder/htdocs/index.html: Updated version to 1.3.2.
  • iExploder/htdocs/webserver.rb: Added. New standalone webserver, can be used as an alternative to our run-iexploder-tests.
  • iExploder/tools/showtest.rb: Added. Similar to run-iexploder-tests --get.
  • iExploder/htdocs/iexploder.rb: Added. Used by webserver.rb.
  • iExploder/tools/osx_last_crash.rb: Find logs modified in the last two days.
1:07 PM Changeset in webkit [14010] by ap
  • 1 edit
    1 add in trunk/WebKitTools

Commit Scripts/run-mangleme-tests (missed it the previous time).

12:04 PM Changeset in webkit [14009] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Eric.

  • push down a bunch of WebCoreFrameBridge code to C++ (plus some reformatting)
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isDescendantOfFrame:]): (-[WebCoreFrameBridge traverseNextFrameStayWithin:]): (-[WebCoreFrameBridge nextFrameWithWrap:]): (-[WebCoreFrameBridge previousFrameWithWrap:]): (+[WebCoreFrameBridge bridgeForDOMDocument:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge addData:]): (-[WebCoreFrameBridge didNotOpenURL:pageCache:]): (-[WebCoreFrameBridge restoreDocumentState]): (-[WebCoreFrameBridge _stringWithDocumentTypeStringAndMarkupString:]): (-[WebCoreFrameBridge nodesFromList:]): (-[WebCoreFrameBridge markupStringFromNode:nodes:]): (-[WebCoreFrameBridge markupStringFromRange:nodes:]): (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:allowShadowContent:]):
  • page/Frame.cpp: (WebCore::Frame::nodeInfoAtPoint): (WebCore::Frame::hasSelection): (WebCore::Frame::documentTypeString):
  • page/Frame.h:
  • page/FrameTree.cpp: (WebCore::FrameTree::traverseNextWithWrap): (WebCore::FrameTree::traversePreviousWithWrap): (WebCore::FrameTree::deepLastChild):
  • page/FrameTree.h:
1:01 AM Changeset in webkit [14008] by bdakin
  • 9 edits
    4 adds in trunk

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6141
DOMCSSPrimitiveValue is always returning values in pixels when
using getComputedStyle:

getFloatValue() took a unit type as a parameter, ignored it, and
returned m_value.num. This patch writes a second version of the
function that actually converts m_value.num to the specified unites
before returning it. Where a conversion is not required, I removed
the unit type from the caller so that it would go directly to the
inline version of the function.

  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValue::computeLengthFloat): Remove type parameter since a conversion is not needed. (WebCore::scaleFactorForConversion): Helper function for conversion. (WebCore::CSSPrimitiveValue::getFloatValue): This version of getFloatValue() takes a unit type parameter and converts m_value.num.
  • css/css_valueimpl.h: (WebCore::CSSPrimitiveValue::getFloatValue): This version does not take a parameter and just returns m_value.num.
  • css/cssparser.cpp: (WebCore::BorderImageParseContext::commitBorderImage): Remove type parameter since a conversion is not needed.
  • css/cssstyleselector.cpp: (WebCore::convertToLength): Same. (WebCore::CSSStyleSelector::applyProperty): Same. (WebCore::CSSStyleSelector::mapBackgroundSize): Same. (WebCore::CSSStyleSelector::mapBackgroundXPosition): Same. (WebCore::CSSStyleSelector::mapBackgroundYPosition): Same.
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Same.
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Same.
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): Same.
12:33 AM Changeset in webkit [14007] by ggaren
  • 8 edits
    6 adds in trunk

LayoutTests:

  • Layout test for whether the error event bubbles.
  • fast/events/onerror-bubbling-expected.txt: Added.
  • fast/events/onerror-bubbling.html: Added.

WebCore:

Reviewed by John.


  • dom/Document.cpp: (WebCore::Document::importNode): Throw an error if the node is null. This happens when the object provided in the JavaScript call is not a node. (WebCore::Document::adoptNode): Set the DOM exception code in all error cases instead of just a few, because that's what the spec requires.
Note: See TracTimeline for information about the timeline view.