⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 24, 2006:

10:24 PM Changeset in webkit [14045] by eseidel
  • 3 edits
    2 adds in trunk

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix for 5th worst unresolved crasher:
<rdar://problem/4129744> [REGRESSION]CrashTracer: ..400 crashes at com.apple.WebCore: DOM::NodeImpl::createRendererIfNeeded + 44

Test: fast/dom/remove-style-element.html

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
10:01 PM Changeset in webkit [14044] by mjs
  • 5 edits in trunk/WebKit

Reviewed by Geoff.


<rdar://problem/4525364> REGRESSION (yesterday?): LOG() mechanism is broken


  • initialize WebKit's log channels
  • Misc/WebKitLogging.h:
  • Misc/WebKitLogging.m: (initializeLogChannel): (WebKitInitializeLoggingChannelsIfNecessary):
  • WebView/WebPreferences.m: (+[WebPreferences initialize]):
  • WebView/WebView.m: (-[WebView _commonInitializationWithFrameName:groupName:]):
10:00 PM Changeset in webkit [14043] by eseidel
  • 4 edits in trunk/WebCore

2006-04-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Speculative fix for our 7th worst crasher.
Also added ASSERTs to help us better understand the issue.
<rdar://problem/4153404> CrashTracer: 2412 crashes in Safari at com.apple.WebCore: khtml::RenderStyle::RenderStyle[unified] + 44

  • dom/Document.cpp: (WebCore::Document::recalcStyle): (WebCore::Document::setInPageCache):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::recalcStyle):
5:30 PM Changeset in webkit [14042] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4503438> REGRESSION (NativeTextField): Can't insert caret when
selection is active in field (Business/Unit)

  • css/html4.css: Added -webkit-user-select:text for input elements.
5:22 PM Changeset in webkit [14041] by mjs
  • 6 edits in trunk

WebCore:

Build fix:


  • move some prematurely code back
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fini]):

WebKit:

Build fix:


  • move some prematurely code back
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebFrameBridge keyboardUIMode]):
4:54 PM Changeset in webkit [14040] by brmorris
  • 1 copy in S60/trunk

Creating trunk in S60 branch from r9049

4:33 PM Changeset in webkit [14039] by brmorris
  • 1 delete in S60/tags/s60-051212

Reversed s60-051212 import ('svn copy' is better)

3:56 PM Changeset in webkit [14038] by mjs
  • 6 edits in trunk

WebCore:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge domain]): (-[WebCoreFrameBridge canTargetLoadInFrame:]): (-[WebCoreFrameBridge fini]): (-[WebCoreFrameBridge dealloc]): (-[WebCoreFrameBridge finalize]): (_getPreSmartSet): (_getPostSmartSet): (-[WebCoreFrameBridge isCharacterSmartReplaceExempt:isPreviousCharacter:]): (-[WebCoreFrameBridge _retrieveKeyboardUIModeFromPreferences:]): (-[WebCoreFrameBridge keyboardUIMode]):

WebKit:

Reviewed by Darin.

  • move more code from WebFrameBridge to WebCoreFrameBridge
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge fini]): (-[WebFrameBridge expiresTimeForResponse:]): (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge _preferences]):
3:33 PM Changeset in webkit [14037] by brmorris
  • 1174 adds in S60/tags/s60-051212

Populated S60/tags/s60-051212

2:59 PM Changeset in webkit [14036] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim O.

Fix to send textFieldDidBeginEditing on the first editing change instead of on focus.
This matches our old behavior.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::subtreeHasChanged):
2:10 PM Changeset in webkit [14035] by ggaren
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/dom/prototype-chain-expected.txt: Updated now that 'JS' is no longer used as a prefix when serializing DOM elements to string.
  • fast/events/event-view-toString.html: ditto

WebCore:

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:05 PM Changeset in webkit [14034] by brmorris
  • 4 adds in S60

S60: Added toplevel repository layout

11:50 AM Changeset in webkit [14033] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Eric.

Fix for <rdar://problem/4513383> REGRESSION: Crash in
WebCore::shouldEmitTabBeforeNode() when iterating through document
text

  • editing/TextIterator.cpp: (WebCore::shouldEmitTabBeforeNode): Need to nil-check the renderer.
2:30 AM Changeset in webkit [14032] by mjs
  • 27 edits in trunk/WebKit

Reviewed by Anders.



I removed all use of these, now objects get at each other via
actual pointers, not using the view hierarchy. However, I left two
of the calls in because other clients rely on them as SPI (ugh).

  • History/WebHistoryItem.m:
  • Misc/WebNSViewExtras.h:
  • Misc/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): (-[NSView _web_parentWebFrameView]):
  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView layout]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView setWebFrame:]): (-[WebNetscapePluginEmbeddedView dataSource]):
  • Plugins/WebNullPluginView.h:
  • Plugins/WebNullPluginView.m: (-[WebNullPluginView setWebFrame:]): (-[WebNullPluginView viewDidMoveToWindow]):
  • Plugins/WebPluginController.h:
  • Plugins/WebPluginController.m: (-[WebPluginController setDataSource:]): (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): (-[WebPluginController webPlugInContainerShowStatus:]): (-[WebPluginController webPlugInContainerSelectionColor]): (-[WebPluginController webFrame]):
  • Plugins/WebPluginDocumentView.h:
  • Plugins/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): (-[WebPluginDocumentView layout]): (-[WebPluginDocumentView currentWindow]): (-[WebPluginDocumentView viewWillMoveToWindow:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): (-[WebFrameBridge formControlIsResigningFirstResponder:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory bridgeForView:]):
  • WebView/WebClipView.m: (-[NSView initWithFrame:]):
  • WebView/WebFrameView.m: (-[WebFrameView _shouldDrawBorder]): (-[WebFrameView webCoreBridge]):
  • WebView/WebHTMLView.m: (-[WebTextCompleteController dealloc]): (-[WebHTMLView _dataSource]): (-[WebHTMLView _bridge]): (-[WebHTMLView _webView]): (-[WebHTMLView _frameView]): (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): (-[NSArray becomeFirstResponder]): (-[NSArray setDataSource:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]): (-[WebHTMLView _frame]):
  • WebView/WebHTMLViewInternal.h:
  • WebView/WebImageView.h:
  • WebView/WebImageView.m: (-[WebImageView drawRect:]): (-[WebImageView adjustFrameSize]): (-[WebImageView setDataSource:]): (-[WebImageView webView]): (-[WebImageView writeImageToPasteboard:types:]): (-[WebImageView copy:]): (-[WebImageView elementAtPoint:]): (-[WebImageView mouseDragged:]):
  • WebView/WebPDFView.h:
  • WebView/WebPDFView.m: (-[WebPDFView _applyPDFDefaults]): (-[WebPDFView _trackFirstResponder]): (-[PDFPrefUpdatingProxy forwardInvocation:]):
  • WebView/WebRenderNode.m: (-[WebRenderNode initWithWebFrameView:]):
  • WebView/WebTextView.h:
  • WebView/WebTextView.m: (-[WebTextView _textSizeMultiplierFromWebView]): (-[WebTextView _preferences]): (-[WebTextView setDataSource:]): (-[WebTextView _webFrame]): (-[WebTextView dragSelectionWithEvent:offset:slideBack:]): (-[WebTextView menuForEvent:]): (-[WebTextView resignFirstResponder]): (-[WebTextView drawPageBorderWithSize:]): (-[WebTextView knowsPageRange:]):
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): (containingFrameView): (-[WebView _focusedFrame]): (-[WebView _frameViewAtWindowPoint:]):

Apr 23, 2006:

9:58 PM Changeset in webkit [14031] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • Took the larger snippets of C++ in the code generator and broke them into HERE documents in the hopes of improving readability.


  • bindings/scripts/CodeGeneratorJS.pm: I indented variable names level with their corresponding HERE documents to clearly "sandwich" the HERE documents between opening and closing EOF statements.
8:47 PM Changeset in webkit [14030] by mjs
  • 13 edits
    2 copies
    2 deletes in trunk

WebCore:

Reviewed by Darin.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreStringTruncator.h: Added.
  • bridge/mac/WebCoreStringTruncator.mm: Added. (stringWidth): (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • bridge/mac/WebCoreViewFactory.h:
  • kwq/KWQFileButton.h:
  • kwq/KWQFileButton.mm: (-[WebFileChooserButton initWithWidget::]): (-[WebCoreFileButton positionButton]): (-[WebCoreFileButton initWithWidget:]): (-[WebCoreFileButton initWithFrame:]): (-[WebCoreFileButton dealloc]): (-[WebCoreFileButton isFlipped]): (-[WebCoreFileButton drawRect:]): (-[WebCoreFileButton updateLabel]): (-[WebCoreFileButton setFilename:]): (-[WebCoreFileButton filename]): (-[WebCoreFileButton setFrameSize:]): (-[WebCoreFileButton bestVisualFrameSizeForCharacterCount:]): (-[WebCoreFileButton visualFrame]): (-[WebCoreFileButton setVisualFrame:]): (-[WebCoreFileButton baseline]): (-[WebCoreFileButton beginSheet]): (-[WebCoreFileButton chooseFilename:]): (-[WebCoreFileButton cancel]): (-[WebCoreFileButton chooseButtonPressed:]): (-[WebCoreFileButton mouseDown:]): (-[WebCoreFileButton acceptsFirstResponder]): (-[WebCoreFileButton becomeFirstResponder]): (-[WebCoreFileButton nextKeyView]): (-[WebCoreFileButton previousKeyView]): (-[WebCoreFileButton nextValidKeyView]): (-[WebCoreFileButton previousValidKeyView]): (-[WebCoreFileButton performClick]): (-[WebFileChooserButton initWithWidget:]): (-[WebFileChooserButton nextValidKeyView]): (-[WebFileChooserButton previousValidKeyView]): (-[WebFileChooserButton resignFirstResponder]): (KWQFileButton::KWQFileButton): (KWQFileButton::setFilename): (KWQFileButton::click): (KWQFileButton::sizeForCharacterWidth): (KWQFileButton::frameGeometry): (KWQFileButton::setFrameGeometry): (KWQFileButton::baselinePosition): (KWQFileButton::filenameChanged):

WebKit:

Reviewed by Darin.


  • Misc/WebStringTruncator.m: (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebCoreSupport/WebFileButton.h: Removed.
  • WebCoreSupport/WebFileButton.m: Removed.
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]):
  • WebCoreSupport/WebViewFactory.m: (-[WebViewFactory fileButtonChooseFileLabel]): (-[WebViewFactory fileButtonNoFileSelectedLabel]):
  • WebKit.xcodeproj/project.pbxproj:
4:11 PM Changeset in webkit [14029] by mjs
  • 7 edits
    4 deletes in trunk

WebCore:

Reviewed by Eric.

  • remove WebCoreCookieAdapter, instead make mac implementation of CookieJar use Foundation directly.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/CookieJar.mm: (WebCore::cookies): (WebCore::setCookies): (WebCore::cookiesEnabled):
  • platform/mac/WebCoreCookieAdapter.h: Removed.
  • platform/mac/WebCoreCookieAdapter.m: Removed.

WebKit:

Reviewed by Eric.


  • remove WebCookieAdapter, WebCore can just use Foundation directly.
  • WebCoreSupport/WebCookieAdapter.h: Removed.
  • WebCoreSupport/WebCookieAdapter.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFrameView.m: (-[WebFrameView initWithFrame:]):
4:09 PM Changeset in webkit [14028] by mjs
  • 21 edits in trunk/WebKit

Reviewed by Adele.


  • prune WebView SPI of unused calls


Specifically I moved methods that have no callers outside WebKit
to WebViewInternal.h or removed them entirely.

  • DefaultDelegates/WebDefaultContextMenuDelegate.m:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/WebNetscapePluginDocumentView.m:
  • Plugins/WebNetscapePluginStream.m:
  • Plugins/WebNullPluginView.m:
  • Plugins/WebPluginContainerCheck.m:
  • Plugins/WebPluginController.m:
  • WebCoreSupport/WebFrameBridge.m:
  • WebCoreSupport/WebPageBridge.m:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebView/WebDataSource.m:
  • WebView/WebHTMLView.m:
  • WebView/WebImageView.m:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebPDFView.m:
  • WebView/WebScriptDebugDelegate.m:
  • WebView/WebView.m: (-[WebView _downloadURL:]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
3:57 PM Changeset in webkit [14027] by eseidel
  • 3 edits
    4 adds in trunk

2006-04-21 Rob Buis <​buis@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8170:
SVG CSS property values with extra items do not get treated
as invalid (they should)

Fixes the handling of invalid svg css properties similar
to how invalid html css properties are handled, ie. discard
the property if there are more values in the value list than
expected.

Test: svg/custom/invalid-css.svg

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
3:45 PM Changeset in webkit [14026] by eseidel
  • 2 edits in trunk/WebCore

2006-04-23 Michael Emmel <​mike.emmel@gmail.com>

Reviewed by mjs. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8517
No test necessary, no functional change.

  • DerivedSources.make: use VPATH more consistently.
3:39 PM Changeset in webkit [14025] by eseidel
  • 8 edits
    2 adds in trunk

2006-04-21 Jon Shier <​jshier@iastate.edu>

Reviewed by ggaren. Landed by eseidel.



  • ChangeLog:
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): changed khtmlErrorEvent to errorEvent. (KJS::DOMEventTargetNode::putValueProperty): ditto.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): ditto. (KJS::Window::put):
  • dom/EventNames.h: Removed khtmlError macro.


12:16 PM Changeset in webkit [14024] by adele
  • 3 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (dump): If display() has been called during the test, grab the pixels from the view, after letting it repaint invalidated rects. (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController display]): Added. Calls -display on the view and changes the subsequent behavior of dump(). (dumpRenderTree):
2:19 AM Changeset in webkit [14023] by eseidel
  • 3 edits
    8 adds in trunk

2006-04-23 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Reproducible crasher with <li value=1234567890 type=A>
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8542

Fixed our alphabetical list generation to match WinIE (not FireFox)
Previously our alphabetical lists were completely wrong past 26 items.

Tests:

  • fast/lists/alpha-list-wrap.html
  • fast/lists/li-style-alpha-huge-value-crash.html
  • rendering/render_list.cpp: (WebCore::toLetterString): (WebCore::toHebrew): (WebCore::RenderListMarker::calcMinMaxWidth):
Note: See TracTimeline for information about the timeline view.